[FFmpeg-devel] [PATCH 1/3] tools/target_dec_fuzzer: Adjust GDV pixel threshold down by a factor of 2

2019-08-14 Thread Michael Niedermayer
Fixes: Timeout (7sec -> 1sec) Fixes: 14709/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_GDV_fuzzer-5704215281795072 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Niedermayer --- tools/target_dec_fuzzer.c | 2 +-

[FFmpeg-devel] [PATCH 3/3] avcodec/ivi: Allocate bufs later

2019-08-14 Thread Michael Niedermayer
Fixes: Timeout (24sec->2sec) Fixes: 15951/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_INDEO5_fuzzer-5095433266790400 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Niedermayer --- libavcodec/ivi.c | 39

Re: [FFmpeg-devel] [PATCH v1] fftoos/ffmpeg_opt: avoid to display the hwaccels name twice

2019-08-14 Thread Moritz Barsnick
On Tue, Aug 13, 2019 at 21:38:41 +0800, lance.lmw...@gmail.com wrote: > From: Limin Wang > fftoos/ffmpeg_opt: avoid to display the hwaccels name twice ^ Nit: fftools/ffmpeg_opt Moritz ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org

Re: [FFmpeg-devel] [REQUEST] ffmpeg-security subscription

2019-08-14 Thread Reimar Döffinger
On 13.08.2019, at 09:45, Paul B Mahol wrote: > On Mon, Aug 12, 2019 at 6:15 PM Michael Niedermayer > wrote: > >> Hi Paul >> >> On Mon, Aug 05, 2019 at 11:50:04AM +0200, Paul B Mahol wrote: >>> Hi, >>> >>> I here hereby request from lead FFmpeg entity to give me subscription to >>>

Re: [FFmpeg-devel] [PATCH v2 1/3] avfilter: add v360 filter

2019-08-14 Thread Li, Zhong
> From: ffmpeg-devel [mailto:ffmpeg-devel-boun...@ffmpeg.org] On Behalf > Of Eugene Lyapustin > Sent: Wednesday, August 14, 2019 9:14 AM > To: ffmpeg-devel@ffmpeg.org > Subject: [FFmpeg-devel] [PATCH v2 1/3] avfilter: add v360 filter > > Signed-off-by: Eugene Lyapustin > --- > doc/filters.texi

[FFmpeg-devel] [PATCH 2/2] libavfilter/dnn/dnn_backend_tf: add tf.pad support for tensorflow backend with native model.

2019-08-14 Thread Guo, Yejun
Signed-off-by: Guo, Yejun --- libavfilter/dnn/dnn_backend_tf.c | 47 1 file changed, 19 insertions(+), 28 deletions(-) diff --git a/libavfilter/dnn/dnn_backend_tf.c b/libavfilter/dnn/dnn_backend_tf.c index ca7434a..75dbe5e 100644 ---

[FFmpeg-devel] [PATCH 1/2] libavfilter/dnn/dnn_backend_tf: fix typo that variable uninitialized.

2019-08-14 Thread Guo, Yejun
if it is not initialized with zero, the tensorflow lib will report error message such as: Attempt to add output -7920 of depth_to_space4 not in range [0, 1) to node with type Identity Signed-off-by: Guo, Yejun --- libavfilter/dnn/dnn_backend_tf.c | 1 + 1 file changed, 1 insertion(+) diff

Re: [FFmpeg-devel] [PATCH] libavutil: AVEncodeInfo data structures

2019-08-14 Thread Nicolas George
James Almer (12019-08-13): > I'm fairly sure this was discussed before, but invalid arguments > shouldn't crash an user's application. They even have their own > standardized errno value for this purpose. > asserts() are to catch bugs in our code, not in theirs. Returning a NULL > pointer is the

Re: [FFmpeg-devel] [PATCH] libavfilter/vf_scale: Ensure scaled video is divisible by n

2019-08-14 Thread Lars Kiesow
Hi Michael, > will apply Thanks. ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".

[FFmpeg-devel] [PATCH 2/3] tools/target_dec_fuzzer: Adjust maxpixels for indeo4

2019-08-14 Thread Michael Niedermayer
Fixes: Timeout (131sec -> 4sec) Fixes: 15581/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_INDEO4_fuzzer-5651105515569152 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Niedermayer --- tools/target_dec_fuzzer.c |

Re: [FFmpeg-devel] [PATCH] lavu/hwcontext_vaapi: cope with race map for YUV420P

2019-08-14 Thread Li, Zhong
> From: ffmpeg-devel [mailto:ffmpeg-devel-boun...@ffmpeg.org] On Behalf > Of Fu, Linjie > Sent: Wednesday, August 14, 2019 9:59 AM > To: ffmpeg-devel@ffmpeg.org > Subject: Re: [FFmpeg-devel] [PATCH] lavu/hwcontext_vaapi: cope with race > map for YUV420P > > > -Original Message- > > From:

Re: [FFmpeg-devel] [PATCH 2/2] convert_from_tensorflow.py: support conv2d with dilation

2019-08-14 Thread Guo, Yejun
> -Original Message- > From: ffmpeg-devel [mailto:ffmpeg-devel-boun...@ffmpeg.org] On Behalf Of > Pedro Arthur > Sent: Wednesday, August 14, 2019 12:09 AM > To: FFmpeg development discussions and patches > Subject: Re: [FFmpeg-devel] [PATCH 2/2] convert_from_tensorflow.py: support >

Re: [FFmpeg-devel] [PATCH v6] avfilter/avf_aphasemeter: Add out-of-phase and mono detection

2019-08-14 Thread Moritz Barsnick
On Tue, Aug 13, 2019 at 18:01:29 +0200, Romane Lafon wrote: > +{ "duration", "set minimum mono or out-of-phase duration in seconds", > OFFSET(duration), AV_OPT_TYPE_DOUBLE, {.dbl=2.}, 0, 24*60*60, FLAGS }, ffmpeg also provides a AV_OPT_TYPE_DURATION. (This may have been discussed before -

Re: [FFmpeg-devel] [PATCH v1] fftoos/ffmpeg_opt: avoid to display the hwaccels name twice

2019-08-14 Thread Limin Wang
On Wed, Aug 14, 2019 at 10:22:26AM +0200, Moritz Barsnick wrote: > On Tue, Aug 13, 2019 at 21:38:41 +0800, lance.lmw...@gmail.com wrote: > > From: Limin Wang > > fftoos/ffmpeg_opt: avoid to display the hwaccels name twice > ^ > Nit: fftools/ffmpeg_opt Sorry, have updated the patch. > >

[FFmpeg-devel] [PATCH v1] fftools/ffmpeg_opt: avoid to display the hwaccels name twice

2019-08-14 Thread lance . lmwang
From: Limin Wang videotoolbox and qsv have been defined by hw_type_names[] in hwcontext.c Signed-off-by: Limin Wang --- fftools/ffmpeg_opt.c | 6 -- 1 file changed, 6 deletions(-) diff --git a/fftools/ffmpeg_opt.c b/fftools/ffmpeg_opt.c index f5ca18a..8baa898 100644 ---

Re: [FFmpeg-devel] [PATCH v1] fftoos/ffmpeg_opt: avoid to display the hwaccels name twice

2019-08-14 Thread Carl Eugen Hoyos
Am Di., 13. Aug. 2019 um 15:39 Uhr schrieb : > > From: Limin Wang > > videotoolbox and qsv have been defined by hw_type_names[] in hwcontext.c Please mention ticket #7464 in the commit message if this patch is supposed to fix it. Carl Eugen ___

[FFmpeg-devel] [PATCH 1/1] Support new SRT streamid specification

2019-08-14 Thread Aaron Boxer
This patch supports the new SRT streamid spec allowing caller to send key/value pairs of parameters to the listener, including user name. A callback parses the streamid - in this case, the parsers chooses the passphrase for the user based on specified list of passphrases. Thanks, Aaron From

Re: [FFmpeg-devel] [PATCH] avcodec/libdav1d: allow setting frame size limit in pixels

2019-08-14 Thread James Almer
On 8/6/2019 9:06 PM, James Almer wrote: > Signed-off-by: James Almer > --- > configure | 2 +- > libavcodec/libdav1d.c | 1 + > 2 files changed, 2 insertions(+), 1 deletion(-) > > diff --git a/configure b/configure > index 34c2adb4a4..eceb21b315 100755 > --- a/configure > +++

Re: [FFmpeg-devel] [PATCH 4/8] avcodec/ffwavesynth: Fixes invalid shift with pink noise seeking

2019-08-14 Thread Michael Niedermayer
On Mon, Aug 12, 2019 at 10:49:56PM +0200, Nicolas George wrote: > Michael Niedermayer (12019-08-10): > > Fixes: left shift of negative value -961533698048 > > Fixes: > > 16242/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_FFWAVESYNTH_fuzzer-5738550670131200 > > > > Found-by: continuous

Re: [FFmpeg-devel] [PATCH 1/2] fftools: Use right function signature and pointers

2019-08-14 Thread Michael Niedermayer
On Wed, Aug 14, 2019 at 06:06:04PM +0200, Paul B Mahol wrote: > LGTM will apply thx [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB Many things microsoft did are stupid, but not doing something just because microsoft did it is even more stupid. If everything

Re: [FFmpeg-devel] [PATCH 1/2] avutil: Add Simple loop detector

2019-08-14 Thread Lynne
Aug 14, 2019, 19:29 by mich...@niedermayer.cc: > On Tue, Aug 13, 2019 at 12:11:30PM +0200, Lynne wrote: > >> Aug 12, 2019, 20:53 by mich...@niedermayer.cc: >> >> > On Sun, Aug 11, 2019 at 08:30:51PM +0200, Reimar Döffinger wrote: >> > >> >> On 08.08.2019, at 10:36, Michael Niedermayer >> >>

[FFmpeg-devel] [PATCH v1] fftools/ffmpeg_opt: avoid to display the hwaccels name twice

2019-08-14 Thread lance . lmwang
From: Limin Wang videotoolbox and qsv have been defined by hw_type_names[] in hwcontext.c Fixes ticket #7464 Signed-off-by: Limin Wang --- fftools/ffmpeg_opt.c | 6 -- 1 file changed, 6 deletions(-) diff --git a/fftools/ffmpeg_opt.c b/fftools/ffmpeg_opt.c index f5ca18a..8baa898 100644

Re: [FFmpeg-devel] [PATCH] lavu/hwcontext_vaapi: provide detailed warning if directly mapping fails

2019-08-14 Thread Fu, Linjie
> -Original Message- > From: Li, Zhong > Sent: Wednesday, August 14, 2019 22:37 > To: FFmpeg development discussions and patches de...@ffmpeg.org> > Cc: Fu, Linjie > Subject: RE: [FFmpeg-devel] [PATCH] lavu/hwcontext_vaapi: provide > detailed warning if directly mapping fails > > >

Re: [FFmpeg-devel] [PATCHv2 5/6] avformat/mpegtsenc: fix PCR generation intervals

2019-08-14 Thread Marton Balint
On Mon, 12 Aug 2019, Andreas Håkon wrote: Hi Marton, ‐‐‐ Original Message ‐‐‐ On Sunday, 11 de August de 2019 22:14, Marton Balint wrote: > > +/* For VBR we select the highest multiple of frame duration which is less than 100 ms. */ > > Don't you think it's a good

[FFmpeg-devel] [PATCH] avcodec/rawdec: Remove redundant code

2019-08-14 Thread Michael Niedermayer
Signed-off-by: Michael Niedermayer --- libavcodec/rawdec.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/libavcodec/rawdec.c b/libavcodec/rawdec.c index 53f5b76e93..35d7653174 100644 --- a/libavcodec/rawdec.c +++ b/libavcodec/rawdec.c @@ -239,9 +239,6 @@ static int

Re: [FFmpeg-devel] [PATCH] avutil/mips: remove redundant code in TRANSPOSE16x8_UB_UB.

2019-08-14 Thread Michael Niedermayer
On Tue, Aug 13, 2019 at 07:13:12PM +0800, Shiyou Yin wrote: > --- > libavutil/mips/generic_macros_msa.h | 2 -- > 1 file changed, 2 deletions(-) will apply thx [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB Everything should be made as simple as possible,

[FFmpeg-devel] [PATCH 4/4] avformat/mpegtsenc: get rid of packet counting for sdt/pat/pmt

2019-08-14 Thread Marton Balint
The packet counting based approach caused excessive sdt/pat/pmt for VBR, so let's use a timestamp based approach instead similar to how we emit PCRs. SDT/PAT/PMT period should be consistent for both VBR and CBR from now on. Also change the type of sdt_period and pat_period to AV_OPT_TYPE_DURATION

[FFmpeg-devel] [PATCH 3/4] avformat/mpegtsenc: move some code around and simplify a bit

2019-08-14 Thread Marton Balint
PCR does not need to be recalcualted for CBR when inserting a NULL or PCR only packet. Signed-off-by: Marton Balint --- libavformat/mpegtsenc.c | 20 +--- 1 file changed, 9 insertions(+), 11 deletions(-) diff --git a/libavformat/mpegtsenc.c b/libavformat/mpegtsenc.c index

Re: [FFmpeg-devel] [PATCH 6/8] avcodec/decode: Do not overwrite AVFrame.pkt_pos if its already set

2019-08-14 Thread James Almer
On 8/14/2019 2:39 PM, Michael Niedermayer wrote: > On Mon, Aug 12, 2019 at 09:03:22PM -0300, James Almer wrote: >> On 8/12/2019 5:31 PM, Michael Niedermayer wrote: >>> On Mon, Aug 12, 2019 at 09:21:59PM +0200, Vittorio Giovara wrote: On Mon, Aug 12, 2019 at 9:19 PM Michael Niedermayer

Re: [FFmpeg-devel] [PATCH 06/13] avformat/mux: Use av_packet_rescale_ts

2019-08-14 Thread Michael Niedermayer
On Wed, Aug 14, 2019 at 05:59:13PM +0200, Paul B Mahol wrote: > LGTM will apply thx [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB If you fake or manipulate statistics in a paper in physics you will never get a job again. If you fake or manipulate statistics

Re: [FFmpeg-devel] [PATCH]lavf/rawenc: Only accept the appropriate stream type for raw muxers

2019-08-14 Thread myp...@gmail.com
On Sun, Aug 11, 2019 at 8:26 AM Carl Eugen Hoyos wrote: > > Am Mo., 1. Juli 2019 um 00:47 Uhr schrieb Carl Eugen Hoyos > : > > > > Am Mo., 1. Juli 2019 um 00:40 Uhr schrieb Carl Eugen Hoyos > > : > > > > > > Hi! > > > > > > Attached patch fixes ticket #7979 for me. > > > > Now attached. > >

Re: [FFmpeg-devel] [PATCH 1/1] avformat/matroska: fully parse stsd atom in v_quicktime tracks

2019-08-14 Thread Michael Niedermayer
On Wed, Aug 14, 2019 at 08:44:11PM +0200, Stanislav Ionascu wrote: > On Tue, Aug 13, 2019 at 10:22 PM Andreas Rheinhardt > wrote: > > > > Stanislav Ionascu: > > > Per matroska spec, v_quicktime contains the complete stsd atom, after > > > the mandatory size + fourcc. By properly parsing the hvcc

[FFmpeg-devel] [PATCH] avcodec/takdec: Fix integer overflow in decorrelate()

2019-08-14 Thread Michael Niedermayer
Fixes: signed integer overflow: -2424832 - 2145653689 cannot be represented in type 'int' Fixes: 16138/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_TAK_fuzzer-5643451346976768 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg

[FFmpeg-devel] [PATCH v3 0/3] add v360 filter

2019-08-14 Thread Eugene Lyapustin
v3: - Fix switch/case alignment - Add more checks for filter options Eugene Lyapustin (3): avfilter: add v360 filter avfilter/vf_v360: add padding option for cubemap avfilter/vf_v360: add dual fisheye format doc/filters.texi | 171 libavfilter/Makefile |1 +

[FFmpeg-devel] [PATCH v3 2/3] avfilter/vf_v360: add padding option for cubemap

2019-08-14 Thread Eugene Lyapustin
Signed-off-by: Eugene Lyapustin --- doc/filters.texi | 18 +++- libavfilter/vf_v360.c | 100 -- 2 files changed, 93 insertions(+), 25 deletions(-) diff --git a/doc/filters.texi b/doc/filters.texi index 6168a3502a..6c70ffceb1 100644 ---

[FFmpeg-devel] [PATCH v3 3/3] avfilter/vf_v360: add dual fisheye format

2019-08-14 Thread Eugene Lyapustin
Signed-off-by: Eugene Lyapustin --- doc/filters.texi | 20 ++ libavfilter/vf_v360.c | 63 +++ 2 files changed, 83 insertions(+) diff --git a/doc/filters.texi b/doc/filters.texi index 6c70ffceb1..feb3a123b6 100644 --- a/doc/filters.texi

[FFmpeg-devel] [PATCH v3 1/3] avfilter: add v360 filter

2019-08-14 Thread Eugene Lyapustin
Signed-off-by: Eugene Lyapustin --- doc/filters.texi | 137 +++ libavfilter/Makefile |1 + libavfilter/allfilters.c |1 + libavfilter/vf_v360.c| 1857 ++ 4 files changed, 1996 insertions(+) create mode 100644 libavfilter/vf_v360.c

Re: [FFmpeg-devel] [PATCH 03/13] avformat/mux: Use const AVPacket * in compare functions

2019-08-14 Thread Michael Niedermayer
On Wed, Aug 14, 2019 at 06:31:23PM +0200, Paul B Mahol wrote: > LGTM will apply thx [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB Good people do not need laws to tell them to act responsibly, while bad people will find a way around the laws. -- Plato

Re: [FFmpeg-devel] [PATCH] Change libaom default to crf=28.

2019-08-14 Thread James Zern
Hi, On Tue, Aug 13, 2019 at 8:23 PM elliottk wrote: > > Current default is 256kbps, which produces inconsistent > results (too high for low-res, too low for hi-res). > Use CRF instead, which will adapt. > --- > libavcodec/libaomenc.c | 8 > 1 file changed, 4 insertions(+), 4

Re: [FFmpeg-devel] [PATCH V1] libavdevice: Update the class name as uniform style

2019-08-14 Thread myp...@gmail.com
On Wed, Aug 14, 2019 at 11:57 PM Paul B Mahol wrote: > > LGTM > will apply, thanks. ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email

[FFmpeg-devel] [PATCH 2/4] avformat/mpegtsenc: add support for setting PCR interval for VBR streams

2019-08-14 Thread Marton Balint
Also document the algorithm for the default PCR interval. Fixes ticket #8061. Signed-off-by: Marton Balint --- doc/muxers.texi | 6 -- libavformat/mpegtsenc.c | 7 --- 2 files changed, 8 insertions(+), 5 deletions(-) diff --git a/doc/muxers.texi b/doc/muxers.texi index

[FFmpeg-devel] [PATCH 1/4] avformat/mpegtsenc: rename pcr_period variable to pcr_period_ms

2019-08-14 Thread Marton Balint
Signed-off-by: Marton Balint --- libavformat/mpegtsenc.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/libavformat/mpegtsenc.c b/libavformat/mpegtsenc.c index d4dd4abb12..5cdd9d3313 100644 --- a/libavformat/mpegtsenc.c +++ b/libavformat/mpegtsenc.c @@ -97,7 +97,7 @@

Re: [FFmpeg-devel] [PATCH v1] fftoos/ffmpeg_opt: avoid to display the hwaccels name twice

2019-08-14 Thread Limin Wang
On Wed, Aug 14, 2019 at 01:46:29PM +0200, Carl Eugen Hoyos wrote: > Am Di., 13. Aug. 2019 um 15:39 Uhr schrieb : > > > > From: Limin Wang > > > > videotoolbox and qsv have been defined by hw_type_names[] in hwcontext.c > > Please mention ticket #7464 in the commit message if this patch > is

Re: [FFmpeg-devel] [PATCH v1] lavf/mov: Fix timestamp rescale on sidx atom

2019-08-14 Thread Jun Li
On Thu, Jun 20, 2019 at 2:02 AM Jun Li wrote: > > > On Tue, May 21, 2019 at 1:05 AM Jun Li wrote: > >> >> >> On Thu, May 16, 2019 at 1:00 AM Jun Li wrote: >> >>> >>> >>> On Sun, May 12, 2019 at 7:44 PM Jun Li wrote: >>> On Fri, May 10, 2019 at 7:25 PM Jun Li wrote: >

[FFmpeg-devel] [PATCH 2/2] lavu/hwcontext_vaapi: remove redundant check in vaapi_map_to_memory

2019-08-14 Thread Linjie Fu
vaapi_get_image_format() will be called in vaapi_map_frame(), so it's redundant here. Also, NULL for VAImageFormat **image_format could be a bit improper since the function is supposed to be used to get the image format. Remove vaapi_get_image_format() in vaapi_map_to_memory(). Signed-off-by:

[FFmpeg-devel] [PATCH 1/2] lavu/hwcontext_vaapi: cope with race map for YUV420P

2019-08-14 Thread Linjie Fu
There is a race condition for AV_PIX_FMT_YUV420P when mapping from pix_fmt to fourcc, both VA_FOURCC_I420 and VA_FOURCC_YV12 could be found by pix_fmt. Currently, vaapi_get_image_format will go through the query results of pix_fmt and returned the first matched result according to the declared

[FFmpeg-devel] [PATCH] lavu/hwcontext_vaapi: provide detailed error msg if directly mapping fails

2019-08-14 Thread Linjie Fu
Detailed message could be helpful when using hwmap=mode=direct,format=xxx for both qsv and vaapi. Signed-off-by: Linjie Fu --- libavutil/hwcontext_vaapi.c | 9 ++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/libavutil/hwcontext_vaapi.c b/libavutil/hwcontext_vaapi.c index

[FFmpeg-devel] [PATCH v2] avformat/matroskadec: properly parse stsd in v_quicktime

2019-08-14 Thread Stanislav Ionascu
Per matroska spec, v_quicktime contains the complete stsd atom, after the mandatory size + fourcc. By properly parsing the hvcc sub-atoms of the track, it becomes possible to demux/decode mp4/mov tracks stored as is in matroska containers. Also dvh1 in stsd in matroska is more likely hevc codec

Re: [FFmpeg-devel] [PATCH] avdevice/decklink: adjust for timecode lag

2019-08-14 Thread Marton Balint
On Wed, 14 Aug 2019, Gyan wrote: On 09-08-2019 04:59 PM, Ilinca Tudose wrote: Hi Marton, The issue with the out of sync TC was reproducible on all tapes and decks that we tested. I don't have the exact number now, but a few dozens, less than 100. They all had between 7 and 17 frames out

Re: [FFmpeg-devel] [REQUEST] ffmpeg-security subscription

2019-08-14 Thread Reimar Döffinger
On 14.08.2019, at 11:45, Paul B Mahol wrote: > I strongly disagree with you. Why some people have subscription to security > mailing list and I'm not allowed also? Long version, explaining to the best of my knowledge and memory: The people on it are on it because at some point it was considered

Re: [FFmpeg-devel] [PATCH] libavformat/mxfenc: Allow more bitrates for NTSC IMX50

2019-08-14 Thread Thomas Mundt
Hi Tomas, Am Mi., 14. Aug. 2019 um 12:42 Uhr schrieb Tomas Härdin : > tis 2019-08-13 klockan 22:03 +0200 skrev Thomas Mundt: > > Hi, > > > > attached patch fixes ticket #8077. > > Please comment. > > Probably OK, bitrates lower than 5000 are fine in D-10 according to > S356m. > > > } else if

Re: [FFmpeg-devel] [PATCH] ffplay: properly detect all window size changes

2019-08-14 Thread Marton Balint
On Wed, 14 Aug 2019, Reino Wijnsma wrote: On 2019-08-13T23:20:08+0200, Marton Balint wrote: SDL_WINDOWEVENT_SIZE_CHANGED should be used instead of SDL_WINDOWEVENT_RESIZED because SDL_WINDOWEVENT_RESIZED is only emitted if the resize happened due to an external event. Fixes ticket #8072.

Re: [FFmpeg-devel] [PATCH 0/1] Parsing quicktime tracks in matroska containers

2019-08-14 Thread Stanislav Ionascu
It affects all codecs which need the data stored in stsd sub-atoms (and which mkvtoolnix is unable to extract). So far it's the case for dvh1, and these are hvcC and dvcC. The patch proposes to rely on the existing methods from avformat/isom, instead of parsing those (again) in matroskadec.

[FFmpeg-devel] [PATCH] lavu/hwcontext_vaapi: provide detailed warning if directly mapping fails

2019-08-14 Thread Linjie Fu
Detailed message could be helpful when using hwmap=mode=direct,format=xxx for both qsv and vaapi. Signed-off-by: Linjie Fu --- libavutil/hwcontext_vaapi.c | 9 ++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/libavutil/hwcontext_vaapi.c b/libavutil/hwcontext_vaapi.c index

Re: [FFmpeg-devel] [PATCH v2 1/3] avfilter: add v360 filter

2019-08-14 Thread Paul B Mahol
On Wed, Aug 14, 2019 at 9:01 AM Li, Zhong wrote: > > From: ffmpeg-devel [mailto:ffmpeg-devel-boun...@ffmpeg.org] On Behalf > > Of Eugene Lyapustin > > Sent: Wednesday, August 14, 2019 9:14 AM > > To: ffmpeg-devel@ffmpeg.org > > Subject: [FFmpeg-devel] [PATCH v2 1/3] avfilter: add v360 filter > >

Re: [FFmpeg-devel] [REQUEST] ffmpeg-security subscription

2019-08-14 Thread Paul B Mahol
On Wed, Aug 14, 2019 at 8:04 AM Reimar Döffinger wrote: > On 13.08.2019, at 09:45, Paul B Mahol wrote: > > > On Mon, Aug 12, 2019 at 6:15 PM Michael Niedermayer > > > wrote: > > > >> Hi Paul > >> > >> On Mon, Aug 05, 2019 at 11:50:04AM +0200, Paul B Mahol wrote: > >>> Hi, > >>> > >>> I here

Re: [FFmpeg-devel] [PATCH v2 1/3] avfilter: add v360 filter

2019-08-14 Thread Thilo Borgmann
[...] >>> +static int config_output(AVFilterLink *outlink) >>> +{ >>> +AVFilterContext *ctx = outlink->src; >>> +AVFilterLink *inlink = ctx->inputs[0]; >>> +V360Context *s = ctx->priv; >>> +const AVPixFmtDescriptor *desc = >>> av_pix_fmt_desc_get(inlink->format); >>> +const

Re: [FFmpeg-devel] [PATCH] avcodec/videotoolbox_hevc: avoid leaking cached_hw_frames_ctx

2019-08-14 Thread Pavel Koshevoy
On Tue, Aug 6, 2019 at 8:50 PM Pavel Koshevoy wrote: > > vtctx->cached_hw_frames_ctx is unref'd in videotoolbox_uninit, > but videotoolbox_hevc used ff_videotoolbox_uninit which > doesn't unref cache_hw_frames_ctx. > --- > libavcodec/videotoolbox.c | 2 +- > 1 file changed, 1 insertion(+), 1

[FFmpeg-devel] MJPEG FPS

2019-08-14 Thread Daniel Kučera
Hi guys, I'm trying to lower the latency when playing mjpeg multipart http stream and I came to this line: https://github.com/FFmpeg/FFmpeg/blob/master/libavformat/mpjpegdec.c#L157 Does it mean each mjpeg stream is decoded as 25FPS? Is this desired feature? -- S pozdravom / Best regards

Re: [FFmpeg-devel] [PATCH v2 1/3] avfilter: add v360 filter

2019-08-14 Thread Paul B Mahol
On Wed, Aug 14, 2019 at 11:56 AM Thilo Borgmann wrote: > [...] > > >>> +static int config_output(AVFilterLink *outlink) > >>> +{ > >>> +AVFilterContext *ctx = outlink->src; > >>> +AVFilterLink *inlink = ctx->inputs[0]; > >>> +V360Context *s = ctx->priv; > >>> +const

Re: [FFmpeg-devel] [PATCH 1/8] avcodec/cinepak: Require 1 bit per 4x4 block as minimum input

2019-08-14 Thread Tomas Härdin
mån 2019-08-12 klockan 21:17 +0200 skrev Michael Niedermayer: > Fixes: Timeout (12sec -> 32ms) > Fixes: 16078/clusterfuzz-testcase-minimized- > ffmpeg_AV_CODEC_ID_CINEPAK_fuzzer-5695832885559296 > > Found-by: continuous fuzzing process >

Re: [FFmpeg-devel] [PATCH] libavformat/mxfenc: Allow more bitrates for NTSC IMX50

2019-08-14 Thread Tomas Härdin
tis 2019-08-13 klockan 22:03 +0200 skrev Thomas Mundt: > Hi, > > attached patch fixes ticket #8077. > Please comment. Probably OK, bitrates lower than 5000 are fine in D-10 according to S356m. > } else if ((sc->video_bit_rate >= 4840) && (sc->video_bit_rate <= > 5000) &&

Re: [FFmpeg-devel] [PATCH v2 1/3] avfilter: add v360 filter

2019-08-14 Thread Thilo Borgmann
Am 14.08.19 um 15:14 schrieb Eugene: > On 14.08.2019 13:06, Paul B Mahol wrote: > >> On Wed, Aug 14, 2019 at 11:56 AM Thilo Borgmann >> wrote: >> >>> [...] >>> >> +static int config_output(AVFilterLink *outlink) >> +{ >> +    AVFilterContext *ctx = outlink->src; >> +   

Re: [FFmpeg-devel] [PATCH v2 1/3] avfilter: add v360 filter

2019-08-14 Thread Eugene
On 14.08.2019 13:06, Paul B Mahol wrote: On Wed, Aug 14, 2019 at 11:56 AM Thilo Borgmann wrote: [...] +static int config_output(AVFilterLink *outlink) +{ +AVFilterContext *ctx = outlink->src; +AVFilterLink *inlink = ctx->inputs[0]; +V360Context *s = ctx->priv; +const

Re: [FFmpeg-devel] MJPEG FPS

2019-08-14 Thread Moritz Barsnick
On Wed, Aug 14, 2019 at 11:23:09 +0200, Daniel Kučera wrote: > I'm trying to lower the latency when playing mjpeg multipart http > stream and I came to this line: > https://github.com/FFmpeg/FFmpeg/blob/master/libavformat/mpjpegdec.c#L157 > > Does it mean each mjpeg stream is decoded as 25FPS?

Re: [FFmpeg-devel] [PATCH v2 1/3] avfilter: add v360 filter

2019-08-14 Thread Paul B Mahol
On Wed, Aug 14, 2019 at 4:06 PM Thilo Borgmann wrote: > Am 14.08.19 um 15:14 schrieb Eugene: > > On 14.08.2019 13:06, Paul B Mahol wrote: > > > >> On Wed, Aug 14, 2019 at 11:56 AM Thilo Borgmann > > >> wrote: > >> > >>> [...] > >>> > >> +static int config_output(AVFilterLink *outlink) >

Re: [FFmpeg-devel] [PATCH v2 1/3] avfilter: add v360 filter

2019-08-14 Thread Thilo Borgmann
Am 14.08.19 um 16:09 schrieb Paul B Mahol: > On Wed, Aug 14, 2019 at 4:06 PM Thilo Borgmann > wrote: > >> Am 14.08.19 um 15:14 schrieb Eugene: >>> On 14.08.2019 13:06, Paul B Mahol wrote: >>> On Wed, Aug 14, 2019 at 11:56 AM Thilo Borgmann >> wrote: > [...] >

Re: [FFmpeg-devel] [PATCH 06/13] avformat/mux: Use av_packet_rescale_ts

2019-08-14 Thread Paul B Mahol
LGTM On Tue, Aug 13, 2019 at 4:55 AM Andreas Rheinhardt < andreas.rheinha...@gmail.com> wrote: > ff_write_chained essentially duplicated the functionality of > av_packet_rescale_ts. This has been changed. > > Signed-off-by: Andreas Rheinhardt > --- > libavformat/mux.c | 16 >

Re: [FFmpeg-devel] [PATCH V1] libavdevice: Update the class name as uniform style

2019-08-14 Thread Paul B Mahol
LGTM On Tue, Aug 13, 2019 at 12:53 PM Jun Zhao wrote: > From: Jun Zhao > > Update the class name to uniform indev/outdev style. > > Signed-off-by: Jun Zhao > --- > libavdevice/alsa_dec.c|2 +- > libavdevice/alsa_enc.c|2 +- > libavdevice/avfoundation.m|2 +- >

Re: [FFmpeg-devel] [PATCH 4/8] avcodec/loco: Check left column value

2019-08-14 Thread Paul B Mahol
LGTM On Mon, Aug 12, 2019 at 9:20 PM Michael Niedermayer wrote: > Fixes: Timeout (42sec -> 379 ms) > Fixes: > 16323/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_LOCO_fuzzer-5679178099195904 > > Found-by: continuous fuzzing process >

Re: [FFmpeg-devel] [PATCH 8/8] avcodec/nuv: Avoid duplicating frames

2019-08-14 Thread Paul B Mahol
On Mon, Aug 12, 2019 at 9:20 PM Michael Niedermayer wrote: > Fixes: Timeout (14sec -> 133ms) > Fixes: > 14843/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_NUV_fuzzer-5661969614372864 > Fixes: > 16257/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_NUV_fuzzer-5769175464673280 > (35sec

Re: [FFmpeg-devel] [PATCH 1/2] fftools: Use right function signature and pointers

2019-08-14 Thread Paul B Mahol
LGTM On Mon, Aug 12, 2019 at 11:59 PM Andreas Rheinhardt < andreas.rheinha...@gmail.com> wrote: > Andreas Rheinhardt: > > The option tables of the various fftools (in particular ffprobe) are > > arrays of OptionDef; said type contains a union of a pointer to void and > > a function pointer of

Re: [FFmpeg-devel] [PATCH 7/8] avcodec/qtrle: return last frame even if unchanged

2019-08-14 Thread Paul B Mahol
On Wed, Aug 14, 2019 at 6:04 PM Paul B Mahol wrote: > > > On Mon, Aug 12, 2019 at 9:19 PM Michael Niedermayer > wrote: > >> Fixes: Ticket7880 >> >> Signed-off-by: Michael Niedermayer >> --- >> libavcodec/qtrle.c| 44 +++ >> tests/ref/fate/qtrle-8bit

Re: [FFmpeg-devel] [PATCH 08/13] avformat/avformat.h: Correct some comments

2019-08-14 Thread Paul B Mahol
On Tue, Aug 13, 2019 at 12:03 PM Carl Eugen Hoyos wrote: > Am Di., 13. Aug. 2019 um 04:49 Uhr schrieb Andreas Rheinhardt > : > > > > 1. When set_parameters was removed from AVOutputFormat in 2fb75019, it > > was forgotten to remove the comment pertaining to it. Said comment now > > appeared to

Re: [FFmpeg-devel] [PATCH 2/8] tools/target_dec_fuzzer: adjust pixel threshold for MSRLE, as it allows coding gigantic images on tiny input

2019-08-14 Thread Paul B Mahol
lgtm On Mon, Aug 12, 2019 at 9:19 PM Michael Niedermayer wrote: > Fixes: Timeout (12sec ->2sec) > Fixes: > 16125/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_MSRLE_fuzzer-5650846364205056 > > Found-by: continuous fuzzing process >

Re: [FFmpeg-devel] [PATCH 2/8] tools/target_dec_fuzzer: adjust pixel threshold for MSRLE, as it allows coding gigantic images on tiny input

2019-08-14 Thread Michael Niedermayer
On Wed, Aug 14, 2019 at 07:02:29PM +0200, Paul B Mahol wrote: > lgtm will apply thx [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB What does censorship reveal? It reveals fear. -- Julian Assange signature.asc Description: PGP signature

Re: [FFmpeg-devel] [PATCH 4/8] avcodec/loco: Check left column value

2019-08-14 Thread Michael Niedermayer
On Wed, Aug 14, 2019 at 06:00:01PM +0200, Paul B Mahol wrote: > LGTM will apply thx [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB The worst form of inequality is to try to make unequal things equal. -- Aristotle signature.asc Description: PGP signature

Re: [FFmpeg-devel] [PATCH 6/8] avcodec/decode: Do not overwrite AVFrame.pkt_pos if its already set

2019-08-14 Thread Michael Niedermayer
On Mon, Aug 12, 2019 at 09:03:22PM -0300, James Almer wrote: > On 8/12/2019 5:31 PM, Michael Niedermayer wrote: > > On Mon, Aug 12, 2019 at 09:21:59PM +0200, Vittorio Giovara wrote: > >> On Mon, Aug 12, 2019 at 9:19 PM Michael Niedermayer > >> > >> wrote: > >> > >>> Signed-off-by: Michael

Re: [FFmpeg-devel] [PATCH 5/8] avcodec/flicvideo: Optimize and Simplify FLI_COPY in flic_decode_frame_24BPP() by using bytestream2_get_buffer()

2019-08-14 Thread Michael Niedermayer
On Wed, Aug 14, 2019 at 05:21:49PM +0200, Tomas Härdin wrote: > mån 2019-08-12 klockan 21:17 +0200 skrev Michael Niedermayer: > > Fixes: Timeout (31sec -> 22sec) > > Is this a large test case? 22sec still sounds excessive the input is about 240kbyte so 22sec is not great but thats what you get

Re: [FFmpeg-devel] [PATCH] libavutil: AVEncodeInfo data structures

2019-08-14 Thread Juan De León
On Wed, Aug 14, 2019 at 12:10 AM Nicolas George wrote: > James Almer (12019-08-13): > > I'm fairly sure this was discussed before, but invalid arguments > > shouldn't crash an user's application. They even have their own > > standardized errno value for this purpose. > > asserts() are to catch

Re: [FFmpeg-devel] [PATCH 8/8] avcodec/nuv: Avoid duplicating frames

2019-08-14 Thread Michael Niedermayer
On Wed, Aug 14, 2019 at 06:02:13PM +0200, Paul B Mahol wrote: > On Mon, Aug 12, 2019 at 9:20 PM Michael Niedermayer > wrote: > > > Fixes: Timeout (14sec -> 133ms) > > Fixes: > > 14843/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_NUV_fuzzer-5661969614372864 > > Fixes: > >

Re: [FFmpeg-devel] [PATCH 1/2] avutil: Add Simple loop detector

2019-08-14 Thread Michael Niedermayer
On Tue, Aug 13, 2019 at 12:11:30PM +0200, Lynne wrote: > Aug 12, 2019, 20:53 by mich...@niedermayer.cc: > > > On Sun, Aug 11, 2019 at 08:30:51PM +0200, Reimar Döffinger wrote: > > > >> On 08.08.2019, at 10:36, Michael Niedermayer > >> wrote: > >> > >> > This provides an alternative to retry

[FFmpeg-devel] [PATCH] libavutil: AVEncodeInfo data structures

2019-08-14 Thread Juan De León
AVEncodeInfoFrame data structure to store as AVFrameSideData of type AV_FRAME_DATA_ENCODE_INFO. The structure stores quantization index for each plane, DC/AC deltas for luma and chroma planes, and an array of AVEncodeInfoBlock type denoting position, size, and delta quantizer for each block in the

Re: [FFmpeg-devel] [PATCH] ffplay: properly detect all window size changes

2019-08-14 Thread Reino Wijnsma
On 2019-08-13T23:20:08+0200, Marton Balint wrote: > SDL_WINDOWEVENT_SIZE_CHANGED should be used instead of SDL_WINDOWEVENT_RESIZED > because SDL_WINDOWEVENT_RESIZED is only emitted if the resize happened due to > an external event. > > Fixes ticket #8072. > > Additional references: >

Re: [FFmpeg-devel] [PATCH] libavformat/rtspdec: Don't send teardown if rtsp_hd_out is null

2019-08-14 Thread Moritz Barsnick
On Mon, Aug 05, 2019 at 08:18:32 +0100, Ross Nicholson wrote: > Example stream that does not work: > rtsp://184.72.239.149/vod/mp4:BigBuckBunny_115k.mov > > Extending the condition allows the stream to be processed correctly. Can you give a bit more detail? Decoding this stream works for me (at

Re: [FFmpeg-devel] [PATCH v2 1/3] avfilter: add v360 filter

2019-08-14 Thread Li, Zhong
> From: ffmpeg-devel [mailto:ffmpeg-devel-boun...@ffmpeg.org] On Behalf > Of Thilo Borgmann > Sent: Wednesday, August 14, 2019 10:06 PM > To: ffmpeg-devel@ffmpeg.org > Subject: Re: [FFmpeg-devel] [PATCH v2 1/3] avfilter: add v360 filter > > Am 14.08.19 um 15:14 schrieb Eugene: > > On 14.08.2019

Re: [FFmpeg-devel] [PATCH] lavu/hwcontext_vaapi: provide detailed warning if directly mapping fails

2019-08-14 Thread Li, Zhong
> From: ffmpeg-devel [mailto:ffmpeg-devel-boun...@ffmpeg.org] On Behalf > Of Linjie Fu > Sent: Wednesday, August 14, 2019 5:25 PM > To: ffmpeg-devel@ffmpeg.org > Cc: Fu, Linjie > Subject: [FFmpeg-devel] [PATCH] lavu/hwcontext_vaapi: provide detailed > warning if directly mapping fails > >

Re: [FFmpeg-devel] [PATCH 5/8] avcodec/flicvideo: Optimize and Simplify FLI_COPY in flic_decode_frame_24BPP() by using bytestream2_get_buffer()

2019-08-14 Thread Tomas Härdin
mån 2019-08-12 klockan 21:17 +0200 skrev Michael Niedermayer: > Fixes: Timeout (31sec -> 22sec) Is this a large test case? 22sec still sounds excessive > -pixel_countdown = s->avctx->width; > -pixel_ptr = 0; > -while (pixel_countdown >

Re: [FFmpeg-devel] [PATCH] ffplay: properly detect all window size changes

2019-08-14 Thread Paul B Mahol
LGTM On Tue, Aug 13, 2019 at 11:20 PM Marton Balint wrote: > SDL_WINDOWEVENT_SIZE_CHANGED should be used instead of > SDL_WINDOWEVENT_RESIZED > because SDL_WINDOWEVENT_RESIZED is only emitted if the resize happened due > to > an external event. > > Fixes ticket #8072. > > Additional references:

Re: [FFmpeg-devel] [PATCHv2 1/3] avformat/avio: add avio_print_string_array and avio_print

2019-08-14 Thread Paul B Mahol
LGTM On Mon, Aug 12, 2019 at 10:32 AM Marton Balint wrote: > These functions can be used to print a variable number of strings > consecutively > to the IO context. Unlike av_bprintf, no temporary buffer is necessary. > > Signed-off-by: Marton Balint > --- > doc/APIchanges| 3 +++ >

Re: [FFmpeg-devel] [PATCHv2 3/3] avformat/avio: remove 4k limit from avio_printf

2019-08-14 Thread Paul B Mahol
LGTM On Sat, Aug 10, 2019 at 10:56 PM Marton Balint wrote: > We do this by switching to AVBPrint. > > v2: Also set IO context error flag in case of ENOMEM. > > Signed-off-by: Marton Balint > --- > doc/APIchanges| 3 +++ > libavformat/avio.h| 5 - > libavformat/aviobuf.c | 16

Re: [FFmpeg-devel] [PATCH 1/1] avformat/matroska: fully parse stsd atom in v_quicktime tracks

2019-08-14 Thread Stanislav Ionascu
On Tue, Aug 13, 2019 at 10:22 PM Andreas Rheinhardt wrote: > > Stanislav Ionascu: > > Per matroska spec, v_quicktime contains the complete stsd atom, after > > the mandatory size + fourcc. By properly parsing the hvcc sub-atoms of > > the track, it becomes possible to demux/decode mp4/mov tracks

Re: [FFmpeg-devel] [PATCH 09/13] avformat/mux: Don't use av_ prefix for static functions

2019-08-14 Thread Paul B Mahol
LGTM On Tue, Aug 13, 2019 at 4:50 AM Andreas Rheinhardt < andreas.rheinha...@gmail.com> wrote: > Signed-off-by: Andreas Rheinhardt > --- > libavformat/mux.c | 8 > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/libavformat/mux.c b/libavformat/mux.c > index

Re: [FFmpeg-devel] [PATCH 03/13] avformat/mux: Use const AVPacket * in compare functions

2019-08-14 Thread Paul B Mahol
LGTM On Tue, Aug 13, 2019 at 4:49 AM Andreas Rheinhardt < andreas.rheinha...@gmail.com> wrote: > There is no reason for these functions to modify the given packets at > all. > > Signed-off-by: Andreas Rheinhardt > --- > libavformat/audiointerleave.c | 2 +- > libavformat/audiointerleave.h | 2

Re: [FFmpeg-devel] [PATCH 7/8] avcodec/qtrle: return last frame even if unchanged

2019-08-14 Thread Paul B Mahol
On Mon, Aug 12, 2019 at 9:19 PM Michael Niedermayer wrote: > Fixes: Ticket7880 > > Signed-off-by: Michael Niedermayer > --- > libavcodec/qtrle.c| 44 +++ > tests/ref/fate/qtrle-8bit | 1 + > 2 files changed, 41 insertions(+), 4 deletions(-) > > diff

Re: [FFmpeg-devel] [PATCH] libavformat/rtspdec: Don't send teardown if rtsp_hd_out is null

2019-08-14 Thread Ross Nicholson
I would imagine that the way Kodi handles the stream, rtsp_hd_out is null as per the following: URLContext * rtsp_hd_out Additional output

Re: [FFmpeg-devel] [PATCH] libavformat/rtspdec: Don't send teardown if rtsp_hd_out is null

2019-08-14 Thread Ross Nicholson
On Wed, 14 Aug 2019 at 07:20, Moritz Barsnick wrote: > On Mon, Aug 05, 2019 at 08:18:32 +0100, Ross Nicholson wrote: > > Example stream that does not work: rtsp:// > 184.72.239.149/vod/mp4:BigBuckBunny_115k.mov > > > > Extending the condition allows the stream to be processed correctly. > > Can