Re: [FFmpeg-devel] [PATCH 1/2] avformat/hls: Use av_packet_move_ref() for packet ownership transfer

2019-12-03 Thread Andreas Rheinhardt
On Tue, Dec 3, 2019 at 11:27 AM Andreas Rheinhardt < andreas.rheinha...@gmail.com> wrote: > Signed-off-by: Andreas Rheinhardt > --- > libavformat/hls.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > I accidentally resent this; please ignore it. - Andreas

[FFmpeg-devel] [PATCH 1/2] avformat/hls: Use av_packet_move_ref() for packet ownership transfer

2019-12-03 Thread Andreas Rheinhardt
Signed-off-by: Andreas Rheinhardt --- libavformat/hls.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/libavformat/hls.c b/libavformat/hls.c index 21353bbad7..f60396f246 100644 --- a/libavformat/hls.c +++ b/libavformat/hls.c @@ -2201,9 +2201,8 @@ static int

[FFmpeg-devel] [PATCH] avformat/rmdec: Use av_packet_move_ref() for packet ownership transfer

2019-12-03 Thread Andreas Rheinhardt
Signed-off-by: Andreas Rheinhardt --- libavformat/rmdec.c | 5 + 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/libavformat/rmdec.c b/libavformat/rmdec.c index e612c42e57..2c40b866aa 100644 --- a/libavformat/rmdec.c +++ b/libavformat/rmdec.c @@ -836,10 +836,7 @@ static int

[FFmpeg-devel] [PATCH V3 1/2] lavf/libsrt: add linger parameter to libsrt

2019-12-03 Thread Jun Zhao
From: Jun Zhao add linger parameter to libsrt, it's setting the number of seconds that the socket waits for unsent data when closing. Reviewed-by: Andriy Gelman Signed-off-by: Jun Zhao --- doc/protocols.texi |5 + libavformat/libsrt.c | 13 + 2 files changed, 18

[FFmpeg-devel] [PATCH V3 0/2] Enable other srt options.

2019-12-03 Thread Jun Zhao
V3: - add more details for linger options. tks Andriy Gelman's comments - fix minor typo in commit message. V2: - correct the commit message. Jun Zhao (2): lavf/libsrt: add linger parameter to libsrt lavf/libsrt: enable other encryption parameters doc/protocols.texi | 21

[FFmpeg-devel] [PATCH] avformat/ttaenc: Don't unnecessarily copy packets

2019-12-03 Thread Andreas Rheinhardt
When the tta muxer writes the actual packet data at the end of the muxing process, it repeatedly copies the packets contained in the linked list of stored packets to an AVPacket located on the stack via ff_packet_list_get(), writes the data and unrefs the packet. But when one is willing to

[FFmpeg-devel] [PATCH v3] Patch for memory optimization with QuickTime/MP4

2019-12-03 Thread Jörg Beckmann
Hi, I recreated the patch from a clean source tree and applied it to a clean source tree: $ patch -p1 -i ../ffmpeg.patch patching file libavformat/isom.h patching file libavformat/mov.c Hope it works now. Cheers, Jörg --- libavformat/isom.h | 1 + libavformat/mov.c | 50

Re: [FFmpeg-devel] [PATCH 1/3] avformat/movenc: write the major brand also as the first compatible brand

2019-12-03 Thread James Almer
On 12/3/2019 5:20 AM, Carl Eugen Hoyos wrote: > Am Mo., 2. Dez. 2019 um 17:19 Uhr schrieb James Almer : >> >> Signed-off-by: James Almer >> --- >> This is meant to be squashed with patch 2/3, otherwise it will write >> duplicate >> compatible brands, and a lot of tests will have to be updated

[FFmpeg-devel] [PATCH V1 1/2] lavf/rtmpproto: Don't unref uninitialized buffers

2019-12-03 Thread Jun Zhao
From: Jun Zhao This happens if ffurl_open_whitelist fails and stream is unset. Signed-off-by: Jun Zhao --- libavformat/rtmpproto.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/libavformat/rtmpproto.c b/libavformat/rtmpproto.c index 5274993..42aacbd 100644 ---

Re: [FFmpeg-devel] [PATCH 1/2] libswscale/x86/yuv2rgb: Change inline assembly into nasm code

2019-12-03 Thread Carl Eugen Hoyos
Am Di., 3. Dez. 2019 um 04:53 Uhr schrieb Fu, Ting : > > > > > -Original Message- > > From: ffmpeg-devel On Behalf Of Carl > > Eugen Hoyos > > Sent: Monday, December 2, 2019 05:49 PM > > To: FFmpeg development discussions and patches > > Subject: Re: [FFmpeg-devel] [PATCH 1/2]

Re: [FFmpeg-devel] [PATCH 1/3] avformat/movenc: write the major brand also as the first compatible brand

2019-12-03 Thread Carl Eugen Hoyos
Am Mo., 2. Dez. 2019 um 17:19 Uhr schrieb James Almer : > > Signed-off-by: James Almer > --- > This is meant to be squashed with patch 2/3, otherwise it will write duplicate > compatible brands, and a lot of tests will have to be updated twice. > > I'm sending it like this to make

[FFmpeg-devel] [PATCH V3 2/2] lavf/libsrt: enable other encryption parameters

2019-12-03 Thread Jun Zhao
From: Jun Zhao Enable the SRTO_ENFORCEDENCRYPTION/SRTO_KMREFRESHRATE/ SRTO_KMPREANNOUNCE for srt encryption control. Signed-off-by: Jun Zhao --- doc/protocols.texi | 16 libavformat/libsrt.c | 18 ++ 2 files changed, 34 insertions(+), 0 deletions(-)

Re: [FFmpeg-devel] [PATCH] avformat/ttaenc: Don't unnecessarily copy packets

2019-12-03 Thread James Almer
On 12/3/2019 8:34 AM, Andreas Rheinhardt wrote: > When the tta muxer writes the actual packet data at the end of the > muxing process, it repeatedly copies the packets contained in the > linked list of stored packets to an AVPacket located on the stack via > ff_packet_list_get(), writes the data

Re: [FFmpeg-devel] [PATCH] MAINTAINERS: add myself to libavfilter/dnn

2019-12-03 Thread Michael Niedermayer
On Sat, Nov 30, 2019 at 12:24:58PM +0800, Guo, Yejun wrote: > Signed-off-by: Guo, Yejun > --- > MAINTAINERS | 2 ++ > 1 file changed, 2 insertions(+) will apply thx [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB Good people do not need laws to tell them to

[FFmpeg-devel] [PATCH V1 2/2] lavfi/avf_showspectrum: Fix the memory leak in error handle path

2019-12-03 Thread Jun Zhao
From: Jun Zhao Fix the memory leak in error handle path. Signed-off-by: Jun Zhao --- libavfilter/avf_showspectrum.c |5 ++--- 1 files changed, 2 insertions(+), 3 deletions(-) diff --git a/libavfilter/avf_showspectrum.c b/libavfilter/avf_showspectrum.c index d5785af..3a3ef7e 100644 ---

Re: [FFmpeg-devel] [PATCH v3 1/2] avformat/utils: simplify the code and remove av_strncasecmp

2019-12-03 Thread Michael Niedermayer
On Mon, Dec 02, 2019 at 12:51:05PM +0800, lance.lmw...@gmail.com wrote: > From: Limin Wang > > Signed-off-by: Limin Wang > --- > libavformat/utils.c | 5 ++--- > 1 file changed, 2 insertions(+), 3 deletions(-) > > diff --git a/libavformat/utils.c b/libavformat/utils.c > index

Re: [FFmpeg-devel] [PATCH] avfilter/vf_unsharp: Don't dereference NULL

2019-12-03 Thread Michael Niedermayer
On Sun, Dec 01, 2019 at 11:04:36AM +0100, Paul B Mahol wrote: > LGTM will apply thx [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB I have never wished to cater to the crowd; for what I know they do not approve, and what they approve I do not know. -- Epicurus

Re: [FFmpeg-devel] [PATCHv2 01/10] avformat/mpegtsenc: allow any sensible PID for elementary and PMT PIDs

2019-12-03 Thread Marton Balint
On Wed, 13 Nov 2019, Marton Balint wrote: This sets the range of the first automatically assigned PMT PID or elementary stream PID parameters to [0x20, 0x1ffa]. You can still assign manually a PID for a stream using AVStream->id in the wider [0x10, 0x1ffe] range as specified by ISO13818-1.

Re: [FFmpeg-devel] [PATCH V3 1/2] lavf/libsrt: add linger parameter to libsrt

2019-12-03 Thread Gyan
On 03-12-2019 04:27 pm, Jun Zhao wrote: From: Jun Zhao add linger parameter to libsrt, it's setting the number of seconds that the socket waits for unsent data when closing. Reviewed-by: Andriy Gelman Signed-off-by: Jun Zhao --- doc/protocols.texi |5 + libavformat/libsrt.c |

Re: [FFmpeg-devel] [PATCH v3] Patch for memory optimization with QuickTime/MP4

2019-12-03 Thread Carl Eugen Hoyos
Am Di., 3. Dez. 2019 um 09:27 Uhr schrieb Jörg Beckmann : > > Hi, > > I recreated the patch from a clean source tree and applied it to a clean > source tree: > > $ patch -p1 -i ../ffmpeg.patch > patching file libavformat/isom.h > patching file libavformat/mov.c > > Hope it works now. > > Cheers,

Re: [FFmpeg-devel] [PATCH] libavformat/utils: Fix code indentation

2019-12-03 Thread Michael Niedermayer
On Mon, Dec 02, 2019 at 09:53:47AM +0800, Linjie Fu wrote: > Introduced since 077939626eeaa0c1364065414c18ab9b3a072281. > > Signed-off-by: Linjie Fu > --- > libavformat/utils.c | 22 +++--- > 1 file changed, 11 insertions(+), 11 deletions(-) will apply thx [...] -- Michael

Re: [FFmpeg-devel] [PATCH 3/3] avfilter/vf_convolution: add X86 SIMD for filter_column()

2019-12-03 Thread chen
comments inline in code At 2019-12-03 15:52:07, xuju...@sjtu.edu.cn wrote: >From: Xu Jun > >+; void filter_column(uint8_t *dst, int height, >+; float rdiv, float bias, const int *const matrix, >+; const uint8_t *c[], int length, int radius, >+;

Re: [FFmpeg-devel] [PATCH] avfilter/vf_yaepblur: add yaepblur filter

2019-12-03 Thread Tao Zhang
ping:) leozhang 于2019年11月25日周一 下午5:53写道: > > Signed-off-by: leozhang > --- > This filter blur the input while preserving edges, with slice threads speed > up. > My test speed is about 100fps on 1080p video with 16 threads, on my test > machine whose cpu is E5-2660 v4 2.0GHz using 16 threads.

Re: [FFmpeg-devel] [PATCH V2 2/2] libswscale/x86/yuv2rgb: add ssse3 version

2019-12-03 Thread Michael Niedermayer
On Mon, Dec 02, 2019 at 11:12:42AM +0800, Ting Fu wrote: > Tested using this command: > /ffmpeg -pix_fmt yuv420p -s 1920*1080 -i ArashRawYuv420.yuv \ > -vcodec rawvideo -s 1920*1080 -pix_fmt rgb24 -f null /dev/null > > The fps increase from 389 to 640 on my local machine. > > Signed-off-by: Ting

Re: [FFmpeg-devel] [PATCH 1/3] avformat/movenc: write the major brand also as the first compatible brand

2019-12-03 Thread Michael Niedermayer
On Mon, Dec 02, 2019 at 01:18:36PM -0300, James Almer wrote: > Signed-off-by: James Almer > --- > This is meant to be squashed with patch 2/3, otherwise it will write duplicate > compatible brands, and a lot of tests will have to be updated twice. I dont think 2 updates are a problem if it

Re: [FFmpeg-devel] [PATCH] lavf/movenc: Replace dts by pts to calculate duration

2019-12-03 Thread Martin Storsjö
On Thu, 28 Nov 2019, manuelyuan wrote: There are many UGC videos with dynamic frame rates, which are represented by PTS jumps. After transcoding with ffmpeg -vsync 0 or -vsync 2, the output video duration becomes longer. Did you post any reproduction case of what, exactly (which field in

Re: [FFmpeg-devel] [PATCH] avdevice/xcbgrab: Improve non-shm performance

2019-12-03 Thread Kusanagi Kouichi
On 2019-11-19 22:59:56 +0900, Kusanagi Kouichi wrote: > Use AVBufferPool. > > before: > $ ffmpeg -benchmark -f x11grab -video_size 1920x1200 -r 200 -t 3 -i +0,0 -f > null - > ... > frame= 600 fps=102 q=-0.0 Lsize=N/A time=00:00:03.00 bitrate=N/A speed=0.51x > video:314kB audio:0kB subtitle:0kB

Re: [FFmpeg-devel] [PATCH v2] avfilter/vf_showinfo: Fix erroneous results for mean and stdev with pixel bits >8

2019-12-03 Thread Limin Wang
On Thu, Nov 28, 2019 at 11:51:13PM +0100, Michael Niedermayer wrote: > On Thu, Nov 28, 2019 at 10:34:41PM +0800, lance.lmw...@gmail.com wrote: > > From: Limin Wang > > > > The following is one of the testing results, you can observe the result of > > 16bit isn't correct. > > 1, yuv420p > >

Re: [FFmpeg-devel] [PATCH] avdevice/xcbgrab: Handle reply and error properly

2019-12-03 Thread Kusanagi Kouichi
On 2019-11-19 22:59:30 +0900, Kusanagi Kouichi wrote: > Fix a NULL dereference and leaks. > > Signed-off-by: Kusanagi Kouichi > --- > libavdevice/xcbgrab.c | 5 + > 1 file changed, 5 insertions(+) > > diff --git a/libavdevice/xcbgrab.c b/libavdevice/xcbgrab.c > index b7e689343e..063fecf838

Re: [FFmpeg-devel] [PATCH v3 1/2] avformat/utils: simplify the code and remove av_strncasecmp

2019-12-03 Thread Limin Wang
On Tue, Dec 03, 2019 at 09:43:53AM +0100, Michael Niedermayer wrote: > On Mon, Dec 02, 2019 at 12:51:05PM +0800, lance.lmw...@gmail.com wrote: > > From: Limin Wang > > > > Signed-off-by: Limin Wang > > --- > > libavformat/utils.c | 5 ++--- > > 1 file changed, 2 insertions(+), 3 deletions(-) >

Re: [FFmpeg-devel] [PATCH v2 1/3] avfilter/vf_elbg: Fix for the seed type

2019-12-03 Thread Limin Wang
ping the patchset, thx. On Fri, Nov 22, 2019 at 09:50:36AM +0800, lance.lmw...@gmail.com wrote: > From: Limin Wang > > Signed-off-by: Limin Wang > --- > libavfilter/vf_elbg.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/libavfilter/vf_elbg.c

Re: [FFmpeg-devel] [PATCH] avformat/ttaenc: Don't unnecessarily copy packets

2019-12-03 Thread Andreas Rheinhardt
On Tue, Dec 3, 2019 at 1:20 PM James Almer wrote: > On 12/3/2019 8:34 AM, Andreas Rheinhardt wrote: > > When the tta muxer writes the actual packet data at the end of the > > muxing process, it repeatedly copies the packets contained in the > > linked list of stored packets to an AVPacket

Re: [FFmpeg-devel] [PATCH V1 1/2] lavf/rtmpproto: Don't unref uninitialized buffers

2019-12-03 Thread Liu Steven
> 在 2019年12月3日,下午7:00,Jun Zhao 写道: > > From: Jun Zhao > > This happens if ffurl_open_whitelist fails and stream is unset. > > Signed-off-by: Jun Zhao > --- > libavformat/rtmpproto.c |2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/libavformat/rtmpproto.c

Re: [FFmpeg-devel] [PATCH V3 1/2] lavf/libsrt: add linger parameter to libsrt

2019-12-03 Thread myp...@gmail.com
On Tue, Dec 3, 2019 at 7:17 PM Gyan wrote: > > > On 03-12-2019 04:27 pm, Jun Zhao wrote: > > From: Jun Zhao > > > > add linger parameter to libsrt, it's setting the number of seconds > > that the socket waits for unsent data when closing. > > > > Reviewed-by: Andriy Gelman > > Signed-off-by:

Re: [FFmpeg-devel] [PATCH v2 2/2] avformat/utils: simplify the ff_mkdir_p with SEPARATOR

2019-12-03 Thread Limin Wang
On Mon, Dec 02, 2019 at 04:25:14PM +0100, Hendrik Leppkes wrote: > On Mon, Dec 2, 2019 at 3:36 PM Limin Wang wrote: > > > > On Mon, Dec 02, 2019 at 09:26:11AM +0100, Hendrik Leppkes wrote: > > > On Mon, Dec 2, 2019 at 3:16 AM Limin Wang wrote: > > > > > > > > On Sun, Dec 01, 2019 at 05:33:16PM

Re: [FFmpeg-devel] [PATCH v1 1/2] fftools: add global option to dump filter graph to stderr

2019-12-03 Thread Limin Wang
On Thu, Nov 21, 2019 at 01:32:58PM +0100, Carl Eugen Hoyos wrote: > Am Do., 21. Nov. 2019 um 12:28 Uhr schrieb Limin Wang > : > > > > On Thu, Nov 21, 2019 at 10:49:28AM +0100, Carl Eugen Hoyos wrote: > > > Am Mi., 20. Nov. 2019 um 16:03 Uhr schrieb : > > > > > > > > From: Limin Wang > > > > > >

[FFmpeg-devel] [PATCH 8/8] avformat/matroskadec: Reuse AVIOContext

2019-12-03 Thread Andreas Rheinhardt
When parsing EBML lacing, for every number read, a new AVIOContext has been initialized (via ffio_init_context()) just for this number. This has been changed: The context is kept now. Signed-off-by: Andreas Rheinhardt --- libavformat/matroskadec.c | 45 ++- 1

[FFmpeg-devel] [PATCH 5/8] avformat/matroskadec: Simplify control flow of parsing laces

2019-12-03 Thread Andreas Rheinhardt
Up until now, when an error happened in one of the inner loops in matroska_parse_laces, a variable designated for the return value has been set to an error value and break has been used to exit the current loop/case. This was done so that the end of matroska_parse_laces is reached, because said

[FFmpeg-devel] [PATCH 7/8] avformat/matroskadec: Improve frame size parsing error messages

2019-12-03 Thread Andreas Rheinhardt
When parsing the sizes of the frames in a lace fails, sometimes no error message was raised (e.g. when using xiph or fixed-size lacing). Only EBML lacing generated error messages (which were wrongly declared as AV_LOG_INFO), but even here not all errors resulted in an error message. So add a

[FFmpeg-devel] [PATCH 6/8] avformat/matroskadec: Remove unnecessary check

2019-12-03 Thread Andreas Rheinhardt
870e7552 introduced validating the lace sizes when they are parsed and removed the old check; yet when merging this libav commit in 6902c3ac, the old check for whether the frame extends beyond the frame has been kept. It is unnecessary and has been removed. Signed-off-by: Andreas Rheinhardt ---

Re: [FFmpeg-devel] [PATCH 5/6] tools/target_dec_fuzzer: Support fuzzing error detection

2019-12-03 Thread Michael Niedermayer
On Sat, Nov 30, 2019 at 12:59:20AM +0100, Michael Niedermayer wrote: > This should increase coverage > > Signed-off-by: Michael Niedermayer > --- > tools/target_dec_fuzzer.c | 6 ++ > 1 file changed, 6 insertions(+) will apply this and the other coverage increasing patch so we get

Re: [FFmpeg-devel] [PATCH v2] avfilter/buffersrc: deprecate sws_param option

2019-12-03 Thread Nicolas George
quinkbl...@foxmail.com (12019-12-03): > From: Zhao Zhili > > --- > doc/filters.texi| 4 +--- > libavfilter/buffersrc.c | 14 -- > libavfilter/version.h | 5 - > 3 files changed, 17 insertions(+), 6 deletions(-) LGTM. I will apply in a little time. Thanks. --

Re: [FFmpeg-devel] [PATCH V3 2/2] lavf/libsrt: enable other encryption parameters

2019-12-03 Thread Michael Niedermayer
On Tue, Dec 03, 2019 at 06:57:27PM +0800, Jun Zhao wrote: > From: Jun Zhao > > Enable the SRTO_ENFORCEDENCRYPTION/SRTO_KMREFRESHRATE/ > SRTO_KMPREANNOUNCE for srt encryption control. > > Signed-off-by: Jun Zhao > --- > doc/protocols.texi | 16 > libavformat/libsrt.c |

[FFmpeg-devel] [PATCH v3] avformat/matroskaenc: Use random TrackUID

2019-12-03 Thread Andreas Rheinhardt
Up until now, the TrackUID of a Matroska track which is supposed to be random was not random at all: It always coincided with the TrackNumber which is usually the 1-based index of the corresponding stream in the array of AVStreams. This has been changed: It is now set via an AVLFG if

[FFmpeg-devel] Fwd: [OpenMedia] CfP: Open Media devront

2019-12-03 Thread Kieran Kunhya
Dear FFmpeg developers, please see call for papers for FOSDEM 2020. Kieran -- Forwarded message - From: Christophe Massiot Date: Sun, 13 Oct 2019 at 16:34 Subject: [OpenMedia] CfP: Open Media devront To: FOSDEM , Open Media devroom < open-media-devr...@lists.fosdem.org> Hi

[FFmpeg-devel] [PATCH 1/8] avformat/matroskadec: Check before allocations

2019-12-03 Thread Andreas Rheinhardt
That way one doesn't have to free later. In this case (concerning TTA extradata), this also fixes a memleak when the output samplerate is invalid. Signed-off-by: Andreas Rheinhardt --- libavformat/matroskadec.c | 21 ++--- 1 file changed, 10 insertions(+), 11 deletions(-) diff

[FFmpeg-devel] [PATCH 2/8] avformat/matroskadec, avcodec/tta: Set extradata_size to 22

2019-12-03 Thread Andreas Rheinhardt
Up until c4e0e314, the seek table has been included in the tta extradata, so that the size of said extradata was 22 (the size of a TTA1 header) + 4 * number of frames. The decoder rejected anything below a size of 30 and so the Matroska demuxer exported 30 byte long extradata, of which only 18

[FFmpeg-devel] [PATCH 4/8] avformat/matroskadec: Avoid allocating array for lace sizes

2019-12-03 Thread Andreas Rheinhardt
The maximal number of frames in a lace can be 256; hence one has a not excessive upper bound on the size of an array that can hold the sizes of all the frames in a lace. Yet up until now, said array has been dynamically allocated. This has been changed. Signed-off-by: Andreas Rheinhardt ---

[FFmpeg-devel] [PATCH 3/8] avformat/matroskadec: Use bytestream API instead of AVIOContext

2019-12-03 Thread Andreas Rheinhardt
It avoids the overhead of function calls. Signed-off-by: Andreas Rheinhardt --- libavformat/matroskadec.c | 20 ++-- 1 file changed, 10 insertions(+), 10 deletions(-) diff --git a/libavformat/matroskadec.c b/libavformat/matroskadec.c index d50211bf4f..32bd6b8446 100644 ---

Re: [FFmpeg-devel] [PATCH] avdevice/xcbgrab: Handle reply and error properly

2019-12-03 Thread Marton Balint
On Tue, 3 Dec 2019, Kusanagi Kouichi wrote: On 2019-11-19 22:59:30 +0900, Kusanagi Kouichi wrote: Fix a NULL dereference and leaks. Signed-off-by: Kusanagi Kouichi --- libavdevice/xcbgrab.c | 5 + 1 file changed, 5 insertions(+) diff --git a/libavdevice/xcbgrab.c

Re: [FFmpeg-devel] [PATCH] avdevice/xcbgrab: Improve non-shm performance

2019-12-03 Thread Marton Balint
On Tue, 3 Dec 2019, Kusanagi Kouichi wrote: On 2019-11-19 22:59:56 +0900, Kusanagi Kouichi wrote: Use AVBufferPool. You don't need a buffer pool for the non-shm case, you should wrap the XCB data in a buffer ref instead. I will reply with a patch that shows how it is done, please check

Re: [FFmpeg-devel] [PATCH] tools: add a fuzzer tool for bitstream filters

2019-12-03 Thread Andriy Gelman
On Mon, 02. Dec 13:15, James Almer wrote: > Signed-off-by: James Almer > --- > Untested. > > The BSF can be set the same way a decoder can in target_dec_fuzzer. The > codec_id will be randomly chosen from the supported list, if any. > > tools/Makefile| 3 + >

Re: [FFmpeg-devel] [PATCH] tools: add a fuzzer tool for bitstream filters

2019-12-03 Thread James Almer
On 12/3/2019 4:31 PM, Andriy Gelman wrote: > On Mon, 02. Dec 13:15, James Almer wrote: >> Signed-off-by: James Almer >> --- >> Untested. >> >> The BSF can be set the same way a decoder can in target_dec_fuzzer. The >> codec_id will be randomly chosen from the supported list, if any. >> >>

Re: [FFmpeg-devel] [PATCH 1/3] avformat/movenc: write the major brand also as the first compatible brand

2019-12-03 Thread James Almer
On 12/3/2019 5:19 AM, Michael Niedermayer wrote: > On Mon, Dec 02, 2019 at 01:18:36PM -0300, James Almer wrote: >> Signed-off-by: James Almer >> --- > >> This is meant to be squashed with patch 2/3, otherwise it will write >> duplicate >> compatible brands, and a lot of tests will have to be

[FFmpeg-devel] [PATCH v2] tools: add a fuzzer tool for bitstream filters

2019-12-03 Thread James Almer
Signed-off-by: James Almer --- tools/Makefile| 3 + tools/target_bsf_fuzzer.c | 153 ++ 2 files changed, 156 insertions(+) create mode 100644 tools/target_bsf_fuzzer.c diff --git a/tools/Makefile b/tools/Makefile index 370ee35416..001093105b

[FFmpeg-devel] [PATCH v2] avformat, avcodec: add dfcmv demuxer and decoder

2019-12-03 Thread Ben Lubar
A few example CMV files can be found in the data/initial_movies folder of Dwarf Fortress (http://www.bay12games.com/dwarves/). The demuxer does not currently handle audio cues. There are warning messages logged for each audio file that should be played. As far as I know, the only two existing CMV

[FFmpeg-devel] [PATCH 1/2] avcodec/twinvqdec: Correct overflow in block align check

2019-12-03 Thread Michael Niedermayer
Fixes: signed integer overflow: 538976288 * 8 cannot be represented in type 'int' Fixes: 19126/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_TWINVQ_fuzzer-5687464110325760 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by:

[FFmpeg-devel] [PATCH 2/2] lavc/hevc_mp4toannexb: Simplify error check

2019-12-03 Thread Andriy Gelman
From: Andriy Gelman Signed-off-by: Andriy Gelman --- libavcodec/hevc_mp4toannexb_bsf.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/libavcodec/hevc_mp4toannexb_bsf.c b/libavcodec/hevc_mp4toannexb_bsf.c index 36fd6f0b15c..49daf4a616c 100644 ---

[FFmpeg-devel] [PATCH 1/2] lavc/hevc_mp4toannexb: Fix interger overflow

2019-12-03 Thread Andriy Gelman
From: Andriy Gelman Check packet grow size against INT_MAX instead of SIZE_MAX. Found with libFuzzer: 4294967044 cannot be represented as int. Signed-off-by: Andriy Gelman --- libavcodec/hevc_mp4toannexb_bsf.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git

Re: [FFmpeg-devel] [PATCH] tools: add a fuzzer tool for bitstream filters

2019-12-03 Thread Michael Niedermayer
On Tue, Dec 03, 2019 at 04:59:26PM -0300, James Almer wrote: > On 12/3/2019 4:31 PM, Andriy Gelman wrote: > > On Mon, 02. Dec 13:15, James Almer wrote: > >> Signed-off-by: James Almer > >> --- > >> Untested. > >> > >> The BSF can be set the same way a decoder can in target_dec_fuzzer. The > >>

Re: [FFmpeg-devel] [PATCH 1/2] lavc/hevc_mp4toannexb: Fix interger overflow

2019-12-03 Thread Andreas Rheinhardt
On Tue, Dec 3, 2019 at 10:41 PM Andriy Gelman wrote: > From: Andriy Gelman > > Check packet grow size against INT_MAX instead of SIZE_MAX. > > Found with libFuzzer: > 4294967044 cannot be represented as int. > > Signed-off-by: Andriy Gelman > --- > libavcodec/hevc_mp4toannexb_bsf.c | 4 ++-- >

[FFmpeg-devel] [PATCH] avdevice/xcbgrab: wrap non-shm image replies in a buffer ref

2019-12-03 Thread Marton Balint
This avoids a memcpy improving performance if SHM is not used. Signed-off-by: Marton Balint --- libavdevice/xcbgrab.c | 22 +++--- 1 file changed, 15 insertions(+), 7 deletions(-) diff --git a/libavdevice/xcbgrab.c b/libavdevice/xcbgrab.c index 063fecf838..440361c8fa 100644 ---

[FFmpeg-devel] [PATCH 2/2] avcodec/atrac9dec: Check q_unit_cnt more completely before using it to access at9_tab_band_ext_group

2019-12-03 Thread Michael Niedermayer
Fixes: index 8 out of bounds for type 'const uint8_t [8][3]' Fixes: 19127/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_ATRAC9_fuzzer-5709394985091072 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Niedermayer ---

Re: [FFmpeg-devel] [PATCH v2] avfilter/buffersrc: deprecate sws_param option

2019-12-03 Thread Michael Niedermayer
On Tue, Dec 03, 2019 at 03:35:24PM +0800, quinkbl...@foxmail.com wrote: > From: Zhao Zhili > > --- > doc/filters.texi| 4 +--- > libavfilter/buffersrc.c | 14 -- > libavfilter/version.h | 5 - > 3 files changed, 17 insertions(+), 6 deletions(-) > > diff --git

Re: [FFmpeg-devel] [PATCH v2] avformat, avcodec: add dfcmv demuxer and decoder

2019-12-03 Thread Michael Niedermayer
On Tue, Dec 03, 2019 at 03:27:12PM -0600, Ben Lubar wrote: > A few example CMV files can be found in the data/initial_movies folder > of Dwarf Fortress (http://www.bay12games.com/dwarves/). > > The demuxer does not currently handle audio cues. There are warning > messages logged for each audio

[FFmpeg-devel] [PATCH v2 3/3] lavc/hevc_mp4toannexb: Exit earlier if there is no nalu payload remaining

2019-12-03 Thread Andriy Gelman
From: Andriy Gelman Since the nal unit payload is located after the length prefix, there is no reason to continue reading if there is no nal unit payload remaining. --- libavcodec/hevc_mp4toannexb_bsf.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[FFmpeg-devel] [PATCH v2 1/3] lavc/hevc_mp4toannexb: Fix integer overflow

2019-12-03 Thread Andriy Gelman
From: Andriy Gelman Check packet grow size against INT_MAX instead of SIZE_MAX. Found with libFuzzer: 4294967044 cannot be represented as int. Signed-off-by: Andriy Gelman --- libavcodec/hevc_mp4toannexb_bsf.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git

[FFmpeg-devel] [PATCH v2 2/3] lavc/hevc_mp4toannexb: Simplify error check

2019-12-03 Thread Andriy Gelman
From: Andriy Gelman Signed-off-by: Andriy Gelman --- libavcodec/hevc_mp4toannexb_bsf.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/libavcodec/hevc_mp4toannexb_bsf.c b/libavcodec/hevc_mp4toannexb_bsf.c index bf4c25b3b7b..faf516634b2 100644 ---

Re: [FFmpeg-devel] [PATCH v2 3/3] lavc/hevc_mp4toannexb: Exit earlier if there is no nalu payload remaining

2019-12-03 Thread Andreas Rheinhardt
On Wed, Dec 4, 2019 at 1:04 AM Andriy Gelman wrote: > From: Andriy Gelman > > Since the nal unit payload is located after the length prefix, there is > no reason to continue reading if there is no nal unit payload remaining. > --- > libavcodec/hevc_mp4toannexb_bsf.c | 2 +- > 1 file changed, 1

Re: [FFmpeg-devel] [PATCH 3/3] avfilter/vf_convolution: add X86 SIMD for filter_column()

2019-12-03 Thread chen
At 2019-12-04 08:59:08, "Song, Ruiling" wrote: >> -Original Message- >> From: ffmpeg-devel On Behalf Of >> chen >> Sent: Tuesday, December 3, 2019 4:59 PM >> To: FFmpeg development discussions and patches > de...@ffmpeg.org> >> Subject: Re: [FFmpeg-devel] [PATCH 3/3]

Re: [FFmpeg-devel] [PATCH V3 2/2] lavf/libsrt: enable other encryption parameters

2019-12-03 Thread myp...@gmail.com
On Tue, Dec 3, 2019 at 11:01 PM Michael Niedermayer wrote: > > On Tue, Dec 03, 2019 at 06:57:27PM +0800, Jun Zhao wrote: > > From: Jun Zhao > > > > Enable the SRTO_ENFORCEDENCRYPTION/SRTO_KMREFRESHRATE/ > > SRTO_KMPREANNOUNCE for srt encryption control. > > > > Signed-off-by: Jun Zhao > > --- >

Re: [FFmpeg-devel] [PATCH 1/2] lavc/hevc_mp4toannexb: Fix interger overflow

2019-12-03 Thread Andriy Gelman
On Tue, 03. Dec 23:30, Andreas Rheinhardt wrote: > On Tue, Dec 3, 2019 at 10:41 PM Andriy Gelman > wrote: > > > From: Andriy Gelman > > > > Check packet grow size against INT_MAX instead of SIZE_MAX. > > > > Found with libFuzzer: > > 4294967044 cannot be represented as int. > > > >

Re: [FFmpeg-devel] [PATCH v2 1/3] lavc/hevc_mp4toannexb: Fix integer overflow

2019-12-03 Thread Andreas Rheinhardt
On Wed, Dec 4, 2019 at 1:04 AM Andriy Gelman wrote: > From: Andriy Gelman > > Check packet grow size against INT_MAX instead of SIZE_MAX. > > Found with libFuzzer: > 4294967044 cannot be represented as int. > > Signed-off-by: Andriy Gelman > --- > libavcodec/hevc_mp4toannexb_bsf.c | 6 +++---

Re: [FFmpeg-devel] [PATCH 3/3] avfilter/vf_convolution: add X86 SIMD for filter_column()

2019-12-03 Thread Song, Ruiling
> -Original Message- > From: ffmpeg-devel On Behalf Of > chen > Sent: Tuesday, December 3, 2019 4:59 PM > To: FFmpeg development discussions and patches de...@ffmpeg.org> > Subject: Re: [FFmpeg-devel] [PATCH 3/3] avfilter/vf_convolution: add X86 > SIMD for filter_column() > > comments

Re: [FFmpeg-devel] [PATCH v2 1/3] lavc/hevc_mp4toannexb: Fix integer overflow

2019-12-03 Thread Andriy Gelman
On Wed, 04. Dec 01:26, Andreas Rheinhardt wrote: > On Wed, Dec 4, 2019 at 1:04 AM Andriy Gelman > wrote: > > > From: Andriy Gelman > > > > Check packet grow size against INT_MAX instead of SIZE_MAX. > > > > Found with libFuzzer: > > 4294967044 cannot be represented as int. > > > >

Re: [FFmpeg-devel] [PATCH 1/2] lavc/hevc_mp4toannexb: Fix interger overflow

2019-12-03 Thread James Almer
On 12/3/2019 9:09 PM, Andriy Gelman wrote: > On Tue, 03. Dec 23:30, Andreas Rheinhardt wrote: >> On Tue, Dec 3, 2019 at 10:41 PM Andriy Gelman >> wrote: >> >>> From: Andriy Gelman >>> >>> Check packet grow size against INT_MAX instead of SIZE_MAX. >>> >>> Found with libFuzzer: >>> 4294967044

Re: [FFmpeg-devel] [PATCH 3/3] avfilter/vf_convolution: add X86 SIMD for filter_column()

2019-12-03 Thread Song, Ruiling
> -Original Message- > From: ffmpeg-devel On Behalf Of > chen > Sent: Wednesday, December 4, 2019 9:36 AM > To: FFmpeg development discussions and patches de...@ffmpeg.org> > Subject: Re: [FFmpeg-devel] [PATCH 3/3] avfilter/vf_convolution: add X86 > SIMD for filter_column() > > > > At

Re: [FFmpeg-devel] [PATCH 1/2] libswscale/x86/yuv2rgb: Change inline assembly into nasm code

2019-12-03 Thread Fu, Ting
> -Original Message- > From: ffmpeg-devel On Behalf Of Carl > Eugen Hoyos > Sent: Tuesday, December 3, 2019 04:23 PM > To: FFmpeg development discussions and patches > Subject: Re: [FFmpeg-devel] [PATCH 1/2] libswscale/x86/yuv2rgb: Change inline > assembly into nasm code > > Am Di.,

Re: [FFmpeg-devel] [PATCH v2 3/3] lavc/hevc_mp4toannexb: Exit earlier if there is no nalu payload remaining

2019-12-03 Thread Andriy Gelman
On Wed, 04. Dec 01:39, Andreas Rheinhardt wrote: > On Wed, Dec 4, 2019 at 1:04 AM Andriy Gelman > wrote: > > > From: Andriy Gelman > > > > Since the nal unit payload is located after the length prefix, there is > > no reason to continue reading if there is no nal unit payload remaining. > > ---

[FFmpeg-devel] [PATCH v3] avfilter/buffersrc: deprecate sws_param option

2019-12-03 Thread quinkblack
From: Zhao Zhili --- patch v3: document how to set the parameters for automatically inserted filters. doc/filters.texi| 7 +++ libavfilter/buffersrc.c | 14 -- libavfilter/version.h | 5 - 3 files changed, 19 insertions(+), 7 deletions(-) diff --git

Re: [FFmpeg-devel] [PATCH V2 2/2] libswscale/x86/yuv2rgb: add ssse3 version

2019-12-03 Thread Fu, Ting
> -Original Message- > From: ffmpeg-devel On Behalf Of > Michael Niedermayer > Sent: Tuesday, December 3, 2019 04:11 PM > To: FFmpeg development discussions and patches > Subject: Re: [FFmpeg-devel] [PATCH V2 2/2] libswscale/x86/yuv2rgb: add ssse3 > version > > On Mon, Dec 02, 2019 at

[FFmpeg-devel] [PATCH V3 1/2] libswscale/x86/yuv2rgb: Change inline assembly into nasm code

2019-12-03 Thread Ting Fu
Tested using this command: ./ffmpeg -pix_fmt yuv420p -s 1920*1080 -i ArashRawYuv420.yuv \ -vcodec rawvideo -s 1920*1080 -pix_fmt rgb24 -f null /dev/null The fps increase from 151 to 389 on my local machine. Signed-off-by: Ting Fu --- libswscale/x86/Makefile | 1 +

[FFmpeg-devel] [PATCH V3 2/2] libswscale/x86/yuv2rgb: add ssse3 version

2019-12-03 Thread Ting Fu
Tested using this command: /ffmpeg -pix_fmt yuv420p -s 1920*1080 -i ArashRawYuv420.yuv \ -vcodec rawvideo -s 1920*1080 -pix_fmt rgb24 -f null /dev/null The fps increase from 389 to 640 on my local machine. Signed-off-by: Ting Fu --- libswscale/x86/yuv2rgb.c | 8 +-

Re: [FFmpeg-devel] [PATCH] avdevice/xcbgrab: Improve non-shm performance

2019-12-03 Thread Kusanagi Kouichi
On 2019-12-03 21:25:37 +0100, Marton Balint wrote: > > > On Tue, 3 Dec 2019, Kusanagi Kouichi wrote: > > > On 2019-11-19 22:59:56 +0900, Kusanagi Kouichi wrote: > > > Use AVBufferPool. > > You don't need a buffer pool for the non-shm case, you should wrap the XCB > data in a buffer ref