[FFmpeg-devel] [PATCH] avformat/flvdec: RtmpSampleAccess no longer breaks stream detection

2020-08-19 Thread Peter van der Spek
Since release 4.2, FFmpeg fails to detect the correct streams in an RTMP stream that contains a |RtmpSampleAccess AMF object prior to the onMetaData AMF object. In the debug log it would show "[flv] Unknown type |RtmpSampleAccess". This functionality broke in commit d7638d8dfc3c4ffd0dc18a64937a5a0

Re: [FFmpeg-devel] [PATCH 2/4] libavcodec/j2kenc: Fix tag tree coding

2020-08-19 Thread Michael Niedermayer
On Wed, Aug 19, 2020 at 01:10:35AM +0530, gautamr...@gmail.com wrote: > From: Gautam Ramakrishnan > > This patch fixes tag tree coding for JPEG2000 > encoder. > --- > libavcodec/j2kenc.c | 43 +-- > libavcodec/jpeg2000.c | 1 + > libavcodec/jpeg2000.h |

[FFmpeg-devel] [PATCH] Set AVSTREAM_PARSE_HEADERS flag for AV1 MP4 streams.

2020-08-19 Thread ManojGuptaBonda
From: Vikas Agarwal It allow AV1 header parsing and help initialize chroma format and other info properly. Chroma format wasn't correct if we use below code: avformat_find_stream_info(fmtc, NULL); iVideoStream = av_find_best_stream(fmtc, AVMEDIA_TYPE_VIDEO, -1, -1, NULL, 0); eChromaFormat = (AV

Re: [FFmpeg-devel] [PATCH 1/1] Added avs2 tags for MKV

2020-08-19 Thread Andreas Rheinhardt
Ze Yuan: >>> The ordinary versions of these players don't use libavformat's Matroska >>> demuxer at all, so I presume that your patch intends to fix the problem >>> by changing how the files are muxed. > > Right. Without avs2 tag, MKV will use AVI compatible mode automatically I > think. > >>>

Re: [FFmpeg-devel] [PATCH 4/5] avcodec/dvbsubdec: request samples for missing coding methods

2020-08-19 Thread Michael Niedermayer
On Tue, Aug 18, 2020 at 10:55:34PM +0200, Clément Bœsch wrote: > --- > libavcodec/dvbsubdec.c | 7 --- > 1 file changed, 4 insertions(+), 3 deletions(-) LGTM thx [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB Any man who breaks a law that conscience tells

Re: [FFmpeg-devel] [PATCH 1/5] avcodec/dvbsubenc: merge rectangle encode code blocks

2020-08-19 Thread Michael Niedermayer
On Tue, Aug 18, 2020 at 10:55:31PM +0200, Clément Bœsch wrote: > --- > libavcodec/dvbsubenc.c | 3 --- > 1 file changed, 3 deletions(-) probably ok thx [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB Observe your enemies, for they first find out your faults. -

Re: [FFmpeg-devel] [PATCH 2/2] qsv: remove audio error code

2020-08-19 Thread myp...@gmail.com
On Wed, Aug 19, 2020 at 2:10 PM Haihao Xiang wrote: > > --- > libavcodec/qsv.c | 3 --- > 1 file changed, 3 deletions(-) > > diff --git a/libavcodec/qsv.c b/libavcodec/qsv.c > index faa424bb68..6776b745b9 100644 > --- a/libavcodec/qsv.c > +++ b/libavcodec/qsv.c > @@ -143,8 +143,6 @@ static const

Re: [FFmpeg-devel] [PATCH 2/2] qsv: remove audio error code

2020-08-19 Thread Nicolas George
Haihao Xiang (12020-08-19): > --- > libavcodec/qsv.c | 3 --- > 1 file changed, 3 deletions(-) > > diff --git a/libavcodec/qsv.c b/libavcodec/qsv.c > index faa424bb68..6776b745b9 100644 > --- a/libavcodec/qsv.c > +++ b/libavcodec/qsv.c > @@ -143,8 +143,6 @@ static const struct { > { MFX_ERR_

Re: [FFmpeg-devel] [aarch64] yuv2planeX - unroll outer loop by 4 to increase performance by 6.3%

2020-08-19 Thread Michael Niedermayer
On Tue, Aug 18, 2020 at 01:11:30PM -0500, Sebastian Pop wrote: > Hi, > > Unrolling by 4 the outer loop in yuv2planeX reduces the number of cache > accesses by 7.5%. > The values loaded for the filter are used in the 4 unrolled iterations and > avoids reloading 3 times the same values. > The perfor

[FFmpeg-devel] [RFC PATCH 3/4] libavcodec/jpeg2000: Modify cleanup

2020-08-19 Thread gautamramk
From: Gautam Ramakrishnan This patch makes the ff_jpeg2000_cleanup function take in an extra parameter which indicates whether it is called from the encoder or decoder. --- libavcodec/j2kenc.c | 2 +- libavcodec/jpeg2000.c| 2 +- libavcodec/jpeg2000.h| 2 +- libavcodec/jpeg2000dec.c

[FFmpeg-devel] [RFC PATCH 1/4] libavcodec/jpeg2000: Make tag tree functions non static

2020-08-19 Thread gautamramk
From: Gautam Ramakrishnan This patch makes the tag_tree_zero() and tag_tree_size() functions non static and callable from other files. --- libavcodec/jpeg2000.c | 12 ++-- libavcodec/jpeg2000.h | 3 +++ 2 files changed, 9 insertions(+), 6 deletions(-) diff --git a/libavcodec/jpeg2000.c

[FFmpeg-devel] [RFC PATCH 4/4] libavcodec/j2kenc: Support for multiple layers

2020-08-19 Thread gautamramk
From: Gautam Ramakrishnan This patch allows setting a compression ratio and to set multiple layers. The user has to input a compression ratio for each layer. The per layer compression ration can be set as follows: -layer_rates "r1,r2,...rn" for to create 'n' layers. --- libavcodec/j2kenc.c | 4

[FFmpeg-devel] [RFC PATCH 2/4] libavcodec/j2kenc: Fix tag tree coding

2020-08-19 Thread gautamramk
From: Gautam Ramakrishnan This patch fixes tag tree coding for JPEG2000 encoder. --- libavcodec/j2kenc.c | 41 - libavcodec/jpeg2000.c | 1 + libavcodec/jpeg2000.h | 1 + 3 files changed, 26 insertions(+), 17 deletions(-) diff --git a/libavcodec/j2ken

Re: [FFmpeg-devel] [PATCH v4]libavfilter/asrc_atone.c : generate algorithmic music

2020-08-19 Thread Nicolas George
Ashutosh Pradhan (12020-08-18): > Generate algorithmic music using riffs, lindenmayer systems, cellular > automaton and rhythm algorithms. > Fixed the error that was causing segmentation fault in the previous patch. Thanks. (But this last sentence should be below the --- in the mail, not in the c

Re: [FFmpeg-devel] [PATCH v5 2/5] lavc/avs3: add AVS3 related definitions

2020-08-19 Thread Nicolas George
hwr...@126.com (12020-08-19): > From: hwren > > Signed-off-by: hwren > --- > libavcodec/Makefile | 2 + > libavcodec/avs3.c | 95 + > libavcodec/avs3.h | 52 + > 3 files changed, 149 insertions(+) > create mode 100644 lib

Re: [FFmpeg-devel] [mov] See if mfra makes up the difference for an incomplete sidx.

2020-08-19 Thread Michael Niedermayer
On Tue, Aug 18, 2020 at 02:04:04PM +0100, Derek Buitenhuis wrote: > On 18/08/2020 04:57, Dale Curtis wrote: > > Can't be an else statement since the prior clause modifies is_complete. > > Ah, you're right. > > New version LGTM. if someone applies this, please add a "avformat/mov: " or equivalent

Re: [FFmpeg-devel] [PATCH v5 2/5] lavc/avs3: add AVS3 related definitions

2020-08-19 Thread Andreas Rheinhardt
hwr...@126.com: > From: hwren > > Signed-off-by: hwren > --- > libavcodec/Makefile | 2 + > libavcodec/avs3.c | 95 + > libavcodec/avs3.h | 52 + > 3 files changed, 149 insertions(+) > create mode 100644 libavcodec/avs3.c

[FFmpeg-devel] [PATCH] dnn/native: rename struct ConvolutionalNetwork to NativeModel

2020-08-19 Thread Ting Fu
Signed-off-by: Ting Fu --- libavfilter/dnn/dnn_backend_native.c | 112 +-- libavfilter/dnn/dnn_backend_native.h | 4 +- libavfilter/dnn/dnn_backend_tf.c | 24 +++--- 3 files changed, 70 insertions(+), 70 deletions(-) diff --git a/libavfilter/dnn/dnn_backend_native.

Re: [FFmpeg-devel] [PATCH 7/7] avcodec/aacdec_template: add support for 22.2 / channel_config 13

2020-08-19 Thread Jan Ekström
On Tue, Aug 18, 2020 at 7:45 PM Paul B Mahol wrote: > > On 8/18/20, Jan Ekström wrote: > > On Tue, Aug 18, 2020 at 12:45 PM Jan Ekström wrote: > >> > >> On Tue, Aug 18, 2020 at 12:17 PM Paul B Mahol wrote: > >> > > >> > I think there is open bug report about SEGV regarding this commit on > >> >

Re: [FFmpeg-devel] [PATCH v5 3/5] lavc/avs3_parser: add avs3 parser

2020-08-19 Thread Moritz Barsnick
On Wed, Aug 19, 2020 at 14:25:54 +0800, hwr...@126.com wrote: > +for (; cur < buf_size; ++cur) { > +state = (state << 8) | buf[cur]; > +if (ISPIC(buf[cur])){ > +++cur; ffmpeg prefers the "cur++" style (twice in this block, and elsewhere). > +

Re: [FFmpeg-devel] [PATCH v5 2/5] lavc/avs3: add AVS3 related definitions

2020-08-19 Thread Moritz Barsnick
On Wed, Aug 19, 2020 at 14:25:53 +0800, hwr...@126.com wrote: > + * AVS3 related definition definitions? > +}; > \ No newline at end of file Please amend a carriage return to the last line. > + * AVS3 related definition definitions? Moritz ___ ffmpe

Re: [FFmpeg-devel] [PATCH v5 5/5] lavc, doc: add libuavs3d video decoder wrapper

2020-08-19 Thread Moritz Barsnick
On Wed, Aug 19, 2020 at 14:25:56 +0800, hwr...@126.com wrote: > - AV1 Low overhead bitstream format demuxer > +- AVS3 video decoder via libuavs3d I wonder whether the raw demuxer should have been mentioned in its respective patch. Moritz ___ ffmpeg-dev

Re: [FFmpeg-devel] [PATCH v4]libavfilter/asrc_atone.c : generate algorithmic music

2020-08-19 Thread Paul B Mahol
On 8/19/20, Nicolas George wrote: > Ashutosh Pradhan (12020-08-18): >> Generate algorithmic music using riffs, lindenmayer systems, cellular >> automaton and rhythm algorithms. >> Fixed the error that was causing segmentation fault in the previous >> patch. > > Thanks. (But this last sentence shou

Re: [FFmpeg-devel] [PATCH 1/3] avcodec/h2645_parse: always return 0 on successful h{264, evc}_parse_nal_header() calls

2020-08-19 Thread James Almer
On 8/12/2020 3:25 PM, James Almer wrote: > HEVC NALs are no longer being skipped based on their nuh_layer_id > value since ad326379c6. > > Signed-off-by: James Almer > --- > libavcodec/h2645_parse.c | 8 > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/libavcodec/h264

Re: [FFmpeg-devel] [PATCH] Set AVSTREAM_PARSE_HEADERS flag for AV1 MP4 streams.

2020-08-19 Thread James Almer
On 8/19/2020 6:50 AM, ManojGuptaBonda wrote: > From: Vikas Agarwal > > It allow AV1 header parsing and help initialize chroma format and other > info properly. > > Chroma format wasn't correct if we use below code: > > avformat_find_stream_info(fmtc, NULL); iVideoStream = > av_find_best_stream(

Re: [FFmpeg-devel] [PATCH 1/7] avfilter/formats: Make check for buffer overflow redundant

2020-08-19 Thread Nicolas George
Andreas Rheinhardt (12020-08-15): > and remove the redundant check. > > This check for whether the allocated buffer is sufficient has been added > in commit 1cbf7fb4345a3e5b7791d483241bf4759bde4ece (merging commit > 5775a1832c4165e6acc1d307004b38701bb463f4). It is not sufficient to > detect invali

Re: [FFmpeg-devel] [PATCH 2/7] avfilter/formats: Avoid allocations when merging formats and samplerates

2020-08-19 Thread Nicolas George
Andreas Rheinhardt (12020-08-15): > This is the analogue of cfc65520324ae640299bd321ef88ae76dcee6f78 for > formats and samplerates; in contrast to said commit, one can avoid > allocating a new array for formats as well (the complications of the > generic channel layouts made this impossible for cha

Re: [FFmpeg-devel] [PATCH 3/7] avfilter/formats: Resize potentially oversized arrays

2020-08-19 Thread Nicolas George
Andreas Rheinhardt (12020-08-15): > Signed-off-by: Andreas Rheinhardt > --- > libavfilter/formats.c | 4 > 1 file changed, 4 insertions(+) The patch works, but I do not think it is necessary or even useful: these arrays are short-lived anyway, they will be freed very soon anyway. (Also, we

Re: [FFmpeg-devel] [PATCH 4/7] avfilter/formats: Avoid code duplication when merging samplerates

2020-08-19 Thread Nicolas George
Andreas Rheinhardt (12020-08-15): > by adapting the MERGE_FORMATS() so that only one instance of the > MERGE_REF() macro needs to exist in ff_merge_samplerates(). Nit: the first line of the commit message should be a short summary. > > Signed-off-by: Andreas Rheinhardt > --- > libavfilter/form

Re: [FFmpeg-devel] [PATCH 5/7] avfilter/formats: Factor checking for mergeability out of ff_merge_*

2020-08-19 Thread Nicolas George
Andreas Rheinhardt (12020-08-15): > The callers of the ff_merge_*() functions fall into two categories with > quite different needs: > > One caller is can_merge_formats() which only wants to test for mergeability > without it merging anything. In order to do so, it duplicates the lists > it intend

Re: [FFmpeg-devel] [PATCH 6/7] avfilter/formats: Always keep longer references list when merging lists

2020-08-19 Thread Nicolas George
Andreas Rheinhardt (12020-08-15): > This means that one only needs to update the shorter list of references. > > Signed-off-by: Andreas Rheinhardt > --- > I doubt that this optimizations is worth the additional complexity. I > have just added it for you to decide. I must say, I do not understand

Re: [FFmpeg-devel] [PATCH v4]libavfilter/asrc_atone.c : generate algorithmic music

2020-08-19 Thread Nicolas George
Paul B Mahol (12020-08-19): > Hmm, something about fluidsynthsounds? That would be ok by me. Other suggestions: fluidsynthmusic, fluidmusic. > Writing excellent synthesizer is not trivial task. Indeed. But it is also of little use for this project. On the other hand, writing a correct synthesiz

Re: [FFmpeg-devel] [PATCH v4]libavfilter/asrc_atone.c : generate algorithmic music

2020-08-19 Thread Paul B Mahol
On 8/19/20, Nicolas George wrote: > Paul B Mahol (12020-08-19): >> Hmm, something about fluidsynthsounds? > > That would be ok by me. Other suggestions: fluidsynthmusic, fluidmusic. > >> Writing excellent synthesizer is not trivial task. > > Indeed. But it is also of little use for this project. >

Re: [FFmpeg-devel] [PATCH 1/6] avfilter/formats: Remove ff_make_formatu64_list()

2020-08-19 Thread Paul B Mahol
On 8/8/20, Andreas Rheinhardt wrote: > It is unused since 8cbb055760c725d0fb99fb759caabb5f4e37e340 and it > actually coincides with avfilter_make_format64_list(). LGTM. ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/lis

Re: [FFmpeg-devel] [PATCH 7/7] avfilter/formats: Cosmetics

2020-08-19 Thread Paul B Mahol
On 8/15/20, Andreas Rheinhardt wrote: > Signed-off-by: Andreas Rheinhardt > --- > libavfilter/formats.c | 18 +- > 1 file changed, 9 insertions(+), 9 deletions(-) > LGTM ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffm

Re: [FFmpeg-devel] [PATCH 3/3] avformat/mlvdec: Only store dimensions after having validated them

2020-08-19 Thread Paul B Mahol
On 8/10/20, Andreas Rheinhardt wrote: > Otherwise it might happen that invalid dimensions are used when reading > a video packet; this might lead to undefined overflow. > > Signed-off-by: Andreas Rheinhardt > --- > libavformat/mlvdec.c | 20 +++- > 1 file changed, 11 insertions(+

Re: [FFmpeg-devel] [PATCH 1/3] avformat/vividas: Check return value before storing it in smaller type

2020-08-19 Thread Paul B Mahol
On 8/6/20, Andreas Rheinhardt wrote: > Signed-off-by: Andreas Rheinhardt > --- > libavformat/vividas.c | 9 + > 1 file changed, 5 insertions(+), 4 deletions(-) > Probably OK ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.

Re: [FFmpeg-devel] [PATCH 1/2] ffmpeg: add disable_all_auto_conversion_filters option.

2020-08-19 Thread Paul B Mahol
On 8/17/20, Alexander Strasser wrote: > On 2020-08-16 23:12 +0200, Nicolas George wrote: >> Alexander Strasser (12020-08-16): >> > I dislike the negative name too, because like mentioned by Marton it >> > doesn't work well with overriding the option to turn it off. >> > >> > On one hand for this o

Re: [FFmpeg-devel] [PATCH 2/4] lavfi/vaf_spectrumsynth: switch to activate.

2020-08-19 Thread Paul B Mahol
On 8/12/20, Nicolas George wrote: > Preserve the original workings, that does not use frames timestamps > and therefore is very fragile. That could be added later. > > Allow to remove needs_fifo. > Patch OK. > Signed-off-by: Nicolas George > --- > libavfilter/vaf_spectrumsynth.c | 69 +++

Re: [FFmpeg-devel] [PATCH 1/4] lavfi/vf_overlay_qsv: remove needs_fifo.

2020-08-19 Thread Paul B Mahol
On 8/12/20, Nicolas George wrote: > It is not relevant when using activate and framesync. > Nice catch, patch OK. > Signed-off-by: Nicolas George > --- > libavfilter/vf_overlay_qsv.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/libavfilter/vf_overlay_qsv.c b/libavfilter/vf_overlay

Re: [FFmpeg-devel] [PATCH 3/4] lavfi: remove needs_fifo.

2020-08-19 Thread Paul B Mahol
On 8/12/20, Nicolas George wrote: > Signed-off-by: Nicolas George > --- > libavfilter/avfilter.h | 3 +-- > libavfilter/avfiltergraph.c | 40 - > libavfilter/internal.h | 8 > 3 files changed, 1 insertion(+), 50 deletions(-) > LGTM __

Re: [FFmpeg-devel] [PATCH 1/4] lavfi/buffersink: remove redundant channel layouts.

2020-08-19 Thread Paul B Mahol
On 8/14/20, Nicolas George wrote: > Signed-off-by: Nicolas George > --- > libavfilter/buffersink.c | 23 +++ > 1 file changed, 23 insertions(+) > How they are currently redundant? Sorry, its not obvious to me from code. > diff --git a/libavfilter/buffersink.c b/libavfilter

Re: [FFmpeg-devel] [PATCH 2/4] lavfi/buffersink: clearly document that the Params struct are unused.

2020-08-19 Thread Paul B Mahol
On 8/14/20, Nicolas George wrote: > Signed-off-by: Nicolas George > --- > libavfilter/buffersink.h | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) LGTM ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listin

Re: [FFmpeg-devel] [RFC PATCH 4/4] libavcodec/j2kenc: Support for multiple layers

2020-08-19 Thread Gautam Ramakrishnan
On Wed, Aug 19, 2020 at 5:51 PM wrote: > > From: Gautam Ramakrishnan > > This patch allows setting a compression ratio and to > set multiple layers. The user has to input a compression > ratio for each layer. > The per layer compression ration can be set as follows: > -layer_rates "r1,r2,...rn" >

Re: [FFmpeg-devel] [PATCH 3/4] lavfi/buffersink: add a summary documentation of the API.

2020-08-19 Thread Paul B Mahol
On 8/14/20, Nicolas George wrote: > Signed-off-by: Nicolas George > --- > libavfilter/buffersink.h | 36 > 1 file changed, 36 insertions(+) > LGTM ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpe

Re: [FFmpeg-devel] [PATCH 4/4] ffplay: do not set redundant channel count on abuffersink.

2020-08-19 Thread Paul B Mahol
On 8/14/20, Nicolas George wrote: > Signed-off-by: Nicolas George > --- > fftools/ffplay.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > Looks OK, but I'm not maintainer of this code. ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org h

Re: [FFmpeg-devel] ffmpeg software and patch management

2020-08-19 Thread Timo Rothenpieler
On 19.08.2020 20:25, Carter, Tenisha [USA] wrote: Hello, Ffmpeg is currently being used on a system that I support and I need clarification that version 3.4 is still being maintained and patched on a daily basis. Can you please provide me a statement indicating that this software is still suppor

Re: [FFmpeg-devel] [aarch64] yuv2planeX - unroll outer loop by 4 to increase performance by 6.3%

2020-08-19 Thread Sebastian Pop
Thanks Michael for your feedback. On Wed, Aug 19, 2020 at 6:55 AM Michael Niedermayer wrote: > faster is better obviously, so if its tested with odd sizes and arm > developers had a chance to comment. it should be ok > > The current patch was tested with `make check` on Arm64 Graviton2. I also h

Re: [FFmpeg-devel] ffmpeg software and patch management

2020-08-19 Thread Carl Eugen Hoyos
Am Mi., 19. Aug. 2020 um 20:25 Uhr schrieb Carter, Tenisha [USA] : > Ffmpeg is currently being used on a system that I support and I need > clarification that version 3.4 is still being maintained and patched on a > daily basis. Can you please provide me a statement indicating that this > software

Re: [FFmpeg-devel] [PATCH 4/4] lavfi: remove request_samples.

2020-08-19 Thread Paul B Mahol
On 8/12/20, Nicolas George wrote: > Filters can use min_samples/max_samples if the number is constant > or activate and ff_inlink_consume_samples(). > LGTM ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-

Re: [FFmpeg-devel] [PATCH 5/5] avcodec/dvbsubdec: error out on unsupported coding methods

2020-08-19 Thread Paul B Mahol
On 8/18/20, Clément Bœsch wrote: > --- > libavcodec/dvbsubdec.c | 3 +++ > 1 file changed, 3 insertions(+) > LGTM ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above,

Re: [FFmpeg-devel] [PATCH 2/5] avcodec/dvbsubenc: reindent after previous commit

2020-08-19 Thread Paul B Mahol
On 8/18/20, Clément Bœsch wrote: > --- > libavcodec/dvbsubenc.c | 78 +- > 1 file changed, 39 insertions(+), 39 deletions(-) > LGTM ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman

Re: [FFmpeg-devel] [PATCH 3/5] avcodec/dvbsubenc: fix onject/object typo

2020-08-19 Thread Paul B Mahol
On 8/18/20, Clément Bœsch wrote: > --- > libavcodec/dvbsubenc.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > OK ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit l

Re: [FFmpeg-devel] [PATCH v5 1/3] [RFC] lavc: add FLIF decoding support

2020-08-19 Thread Paul B Mahol
On 8/17/20, Anamitra Ghorui wrote: > On Sat, 15 Aug 2020 00:29:10 +0530 > Anamitra Ghorui wrote: > >> This patch fixes a few cosmetic errors mentioned in v3, an error in the >> ColorBuckets reading function and removes a few redundancies in the >> rangecoder initialisation. >> >> Co-authored-by:

Re: [FFmpeg-devel] [PATCH 2/3] avformat/mlvdec: Don't leak open AVIOContexts on error

2020-08-19 Thread Paul B Mahol
On 8/10/20, Andreas Rheinhardt wrote: > Signed-off-by: Andreas Rheinhardt > --- > libavformat/mlvdec.c | 3 +++ > 1 file changed, 3 insertions(+) > Probably OK ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/f

Re: [FFmpeg-devel] [PATCH 2/8] avcodec/smacker: Don't warn for Huffmann tables with one element

2020-08-19 Thread Paul B Mahol
On 7/31/20, Andreas Rheinhardt wrote: > The Huffmann tables used by Smacker can consist of exactly one leaf only > in which case the length of the corresponding code is zero; there is > then exactly one value encoded. Our VLC can't handle this and therefore > this case needs to be treated separate

Re: [FFmpeg-devel] [PATCH 20/21] avcodec/smacker: Use unsigned for prediction values

2020-08-19 Thread Paul B Mahol
On 8/1/20, Andreas Rheinhardt wrote: > Up until now, the Smacker decoder has pretended that the prediction > values are signed in code like 'pred[0] += (unsigned)sign_extend(val, 16)' > (the cast has been added to this code later to fix undefined behaviour). > This has been even done in case the P

Re: [FFmpeg-devel] [PATCH 7/8] avcodec/smacker: Use same variable for return values and errors

2020-08-19 Thread Paul B Mahol
On 7/31/20, Andreas Rheinhardt wrote: > smacker_decode_header_tree() uses different variables for return values > (res) and for errors (err) leading to code like > res = foo(bar); > if (res < 0) { > err = res; > goto error; > } > Given that no positive return value is ever used at all one

Re: [FFmpeg-devel] [PATCH 13/21] avfilter/vf_remap: Fix double-free of AVFilterFormats on error

2020-08-19 Thread Paul B Mahol
On 8/9/20, Andreas Rheinhardt wrote: > The query_formats function of the remap filter tries to allocate > two lists of formats which on success are attached to more permanent objects > (AVFilterLinks) for storage afterwards. If attaching a list to an > AVFilterLink succeeds, it is in turn owned by

Re: [FFmpeg-devel] [PATCH 6/8] avcodec/smacker: Directly goto error in case of error

2020-08-19 Thread Paul B Mahol
On 7/31/20, Andreas Rheinhardt wrote: > Signed-off-by: Andreas Rheinhardt > --- > libavcodec/smacker.c | 7 --- > 1 file changed, 4 insertions(+), 3 deletions(-) > > diff --git a/libavcodec/smacker.c b/libavcodec/smacker.c > index 8a4d88cfed..4b1f0f1b7c 100644 > --- a/libavcodec/smacker.c >

Re: [FFmpeg-devel] [RFC PATCH 4/4] libavcodec/j2kenc: Support for multiple layers

2020-08-19 Thread Paul B Mahol
On 8/19/20, Gautam Ramakrishnan wrote: > On Wed, Aug 19, 2020 at 5:51 PM wrote: >> >> From: Gautam Ramakrishnan >> >> This patch allows setting a compression ratio and to >> set multiple layers. The user has to input a compression >> ratio for each layer. >> The per layer compression ration can

Re: [FFmpeg-devel] [RFC PATCH 4/4] libavcodec/j2kenc: Support for multiple layers

2020-08-19 Thread Andreas Rheinhardt
Gautam Ramakrishnan: > On Wed, Aug 19, 2020 at 5:51 PM wrote: >> >> From: Gautam Ramakrishnan >> >> This patch allows setting a compression ratio and to >> set multiple layers. The user has to input a compression >> ratio for each layer. >> The per layer compression ration can be set as follows:

Re: [FFmpeg-devel] [PATCH 5/8] avcodec/smacker: Improve header table error checks

2020-08-19 Thread Paul B Mahol
On 7/31/20, Andreas Rheinhardt wrote: > The extradata for Smacker video contains Huffman trees as well as a > field containing the size (in bytes) of said Huffman tree when stored > as a table. Due to three special values the decoder allocates more than > the size field indicates; yet when it pars

Re: [FFmpeg-devel] [PATCH 4/8] avcodec/smacker: Remove code duplication when decoding header trees

2020-08-19 Thread Paul B Mahol
On 7/31/20, Andreas Rheinhardt wrote: > Signed-off-by: Andreas Rheinhardt > --- > libavcodec/smacker.c | 83 +++- > 1 file changed, 28 insertions(+), 55 deletions(-) > Probably OK ___ ffmpeg-devel mailing list f

Re: [FFmpeg-devel] [PATCH] avformat/internal: Remove wrong documentation

2020-08-19 Thread Paul B Mahol
On 7/27/20, Andreas Rheinhardt wrote: > Has apparently been copied from ff_choose_timebase() in commit > a45cf639e6fb8c86aff91a00970060cd0be401c9. > > Signed-off-by: Andreas Rheinhardt > --- > Btw: There is exactly one user of this, namely the MXF muxer. > Should this be moved to mxfenc.c? The sa

Re: [FFmpeg-devel] [PATCH] avformat/siff: Reject audio packets without audio stream

2020-08-19 Thread Paul B Mahol
On 8/13/20, Michael Niedermayer wrote: > Fixes: Assertion failure > Fixes: > 24612/clusterfuzz-testcase-minimized-ffmpeg_DEMUXER_fuzzer-6600899842277376.fuzz > > Found-by: continuous fuzzing process > https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg > Signed-off-by: Michael Niedermay

[FFmpeg-devel] [PATCH] libavcodec/options_table: Add missing colorspace options

2020-08-19 Thread Harry Mallon
* chroma-derived-nc / chroma-derived-c and ictcp Signed-off-by: Harry Mallon --- doc/codecs.texi| 6 ++ libavcodec/options_table.h | 33 ++--- 2 files changed, 24 insertions(+), 15 deletions(-) diff --git a/doc/codecs.texi b/doc/codecs.texi index c09

Re: [FFmpeg-devel] [PATCH 6/8] avcodec/smacker: Directly goto error in case of error

2020-08-19 Thread Andreas Rheinhardt
Paul B Mahol: > On 7/31/20, Andreas Rheinhardt wrote: >> Signed-off-by: Andreas Rheinhardt >> --- >> libavcodec/smacker.c | 7 --- >> 1 file changed, 4 insertions(+), 3 deletions(-) >> >> diff --git a/libavcodec/smacker.c b/libavcodec/smacker.c >> index 8a4d88cfed..4b1f0f1b7c 100644 >> --- a

Re: [FFmpeg-devel] [PATCH 6/8] avcodec/smacker: Directly goto error in case of error

2020-08-19 Thread Paul B Mahol
On 8/19/20, Andreas Rheinhardt wrote: > Paul B Mahol: >> On 7/31/20, Andreas Rheinhardt wrote: >>> Signed-off-by: Andreas Rheinhardt >>> --- >>> libavcodec/smacker.c | 7 --- >>> 1 file changed, 4 insertions(+), 3 deletions(-) >>> >>> diff --git a/libavcodec/smacker.c b/libavcodec/smacker.c

Re: [FFmpeg-devel] [PATCH V4] dnn_backend_openvino.c: parse options in openvino backend

2020-08-19 Thread Alexander Strasser
Hi Yejun! On 2020-08-18 23:08 +0800, Guo, Yejun wrote: > Signed-off-by: Guo, Yejun > --- > v3: use AVOption > v4: don't add new file dnn_common.h/c > > libavfilter/dnn/dnn_backend_openvino.c | 50 > +- > 1 file changed, 49 insertions(+), 1 deletion(-) > > diff --

Re: [FFmpeg-devel] [PATCH] avformat/movenc: write the colr atom by default

2020-08-19 Thread Michael Bradshaw
On Mon, Apr 13, 2020 at 4:14 PM Michael Bradshaw wrote: > Attached is an updated patch that passes fate. > I completely forgot about this patch. If no one objects over the next few days I plan on pushing this. FATE still passes. ___ ffmpeg-devel mailin

Re: [FFmpeg-devel] [PATCH] avformat/movenc: write the colr atom by default

2020-08-19 Thread Paul B Mahol
On 8/19/20, Michael Bradshaw wrote: > On Mon, Apr 13, 2020 at 4:14 PM Michael Bradshaw wrote: > >> Attached is an updated patch that passes fate. >> > > I completely forgot about this patch. If no one objects over the next few > days I plan on pushing this. FATE still passes. Fine by me. ___

[FFmpeg-devel] [PATCH] libavcodec/proresdec2: Setup qmat_chroma according to RDD36

2020-08-19 Thread Harry Mallon
Signed-off-by: Harry Mallon --- libavcodec/proresdec2.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavcodec/proresdec2.c b/libavcodec/proresdec2.c index d5fbfc6711..4e1d0dd3f1 100644 --- a/libavcodec/proresdec2.c +++ b/libavcodec/proresdec2.c @@ -289,7 +289,7 @@ static

[FFmpeg-devel] [PATCH] libavcodec/options_table: Add missing colorspace options

2020-08-19 Thread Harry Mallon
* chroma-derived-nc / chroma-derived-c and ictcp Signed-off-by: Harry Mallon --- doc/codecs.texi| 6 ++ libavcodec/options_table.h | 33 ++--- 2 files changed, 24 insertions(+), 15 deletions(-) diff --git a/doc/codecs.texi b/doc/codecs.texi index c09

[FFmpeg-devel] [PATCH] libavformat/r3d.c: Fix Use-of-uninitialized-value in filename.

2020-08-19 Thread Thierry Foucu
While reading the filename tag, it mays return a EOF and we are still copying the file with uninitialized value. --- libavformat/r3d.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavformat/r3d.c b/libavformat/r3d.c index 7aa0c5a2c3..7ba589530d 100644 --- a/libavformat/r3d

[FFmpeg-devel] [PATCH v2] avfilter/formats: Avoid code duplication when merging samplerates

2020-08-19 Thread Andreas Rheinhardt
Right now, ff_merge_samplerates() contains three instances of the MERGE_REF() macro, a macro which reallocates an array, updates some pointers in a loop and frees several buffers. This commit makes it possible to contain only one instance of said macro in the function, thereby reducing codesize. S

Re: [FFmpeg-devel] [PATCH 3/7] avfilter/formats: Resize potentially oversized arrays

2020-08-19 Thread Andreas Rheinhardt
Nicolas George: > Andreas Rheinhardt (12020-08-15): >> Signed-off-by: Andreas Rheinhardt >> --- >> libavfilter/formats.c | 4 >> 1 file changed, 4 insertions(+) > > The patch works, but I do not think it is necessary or even useful: > these arrays are short-lived anyway, they will be freed

Re: [FFmpeg-devel] [PATCH 0/3] avcodec/aacdec_template: improvements to 22.2 layout logic

2020-08-19 Thread Jan Ekström
On Tue, Aug 18, 2020 at 10:25 PM Jan Ekström wrote: > > The first two commits fix both of the fuzzing samples I have on hand. > One being from #8845, and another provided privately by Michael. Changes have > been tested both with clang 10's ASAN as well as standard valgrind. > For the record I ha

Re: [FFmpeg-devel] [PATCH 6/7] avfilter/formats: Always keep longer references list when merging lists

2020-08-19 Thread Andreas Rheinhardt
Nicolas George: > Andreas Rheinhardt (12020-08-15): >> This means that one only needs to update the shorter list of references. >> >> Signed-off-by: Andreas Rheinhardt >> --- >> I doubt that this optimizations is worth the additional complexity. I >> have just added it for you to decide. > > I mu

[FFmpeg-devel] ffmpeg software and patch management

2020-08-19 Thread Carter, Tenisha [USA]
Hello, Ffmpeg is currently being used on a system that I support and I need clarification that version 3.4 is still being maintained and patched on a daily basis. Can you please provide me a statement indicating that this software is still supported and a date of how long it will be supported? Ve

Re: [FFmpeg-devel] [PATCH] libavformat/r3d.c: Fix Use-of-uninitialized-value in filename.

2020-08-19 Thread James Almer
On 8/19/2020 4:59 PM, Thierry Foucu wrote: > While reading the filename tag, it mays return a EOF and we are still > copying the file with uninitialized value. > --- > libavformat/r3d.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/libavformat/r3d.c b/libavformat/r3d.c

[FFmpeg-devel] [PATCH] libavformat/r3d.c: Fix Use-of-uninitialized-value in filename.

2020-08-19 Thread Thierry Foucu
While reading the filename tag, it mays return a EOF and we are still copying the file with uninitialized value. --- libavformat/r3d.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/libavformat/r3d.c b/libavformat/r3d.c index 7aa0c5a2c3..d013b8c30e 100644 --- a/libavformat

Re: [FFmpeg-devel] [PATCH 0/3] avcodec/aacdec_template: improvements to 22.2 layout logic

2020-08-19 Thread James Almer
On 8/19/2020 6:51 PM, Jan Ekström wrote: > On Tue, Aug 18, 2020 at 10:25 PM Jan Ekström wrote: >> >> The first two commits fix both of the fuzzing samples I have on hand. >> One being from #8845, and another provided privately by Michael. Changes have >> been tested both with clang 10's ASAN as we

Re: [FFmpeg-devel] [PATCH 4/4] ffplay: do not set redundant channel count on abuffersink.

2020-08-19 Thread Marton Balint
On Fri, 14 Aug 2020, Nicolas George wrote: Signed-off-by: Nicolas George --- fftools/ffplay.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fftools/ffplay.c b/fftools/ffplay.c index d673b8049a..6c9c041e9a 100644 --- a/fftools/ffplay.c +++ b/fftools/ffplay.c @@ -2008,7 +20

Re: [FFmpeg-devel] [PATCH 2/2] qsv: remove audio error code

2020-08-19 Thread Xiang, Haihao
On Wed, 2020-08-19 at 13:53 +0200, Nicolas George wrote: > Haihao Xiang (12020-08-19): > > --- > > libavcodec/qsv.c | 3 --- > > 1 file changed, 3 deletions(-) > > > > diff --git a/libavcodec/qsv.c b/libavcodec/qsv.c > > index faa424bb68..6776b745b9 100644 > > --- a/libavcodec/qsv.c > > +++ b/lib

Re: [FFmpeg-devel] [PATCH V4] dnn_backend_openvino.c: parse options in openvino backend

2020-08-19 Thread Guo, Yejun
> -Original Message- > From: ffmpeg-devel On Behalf Of > Alexander Strasser > Sent: 2020年8月20日 4:06 > To: FFmpeg development discussions and patches > Subject: Re: [FFmpeg-devel] [PATCH V4] dnn_backend_openvino.c: parse options > in openvino backend > > Hi Yejun! > > On 2020-08-18 23:

[FFmpeg-devel] [PATCH] avcodec/proresenc: add support for PQ and HLG

2020-08-19 Thread Michael Bradshaw
Signed-off-by: Michael Bradshaw --- libavcodec/proresenc_anatoliy.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/libavcodec/proresenc_anatoliy.c b/libavcodec/proresenc_anatoliy.c index 1128978330..3aa18a3ca4 100644 --- a/libavcodec/proresenc_anatoliy.c +++ b/libavcodec/pr

Re: [FFmpeg-devel] [PATCH] avcodec/proresenc: add support for PQ and HLG

2020-08-19 Thread Michael Bradshaw
On Wed, Aug 19, 2020 at 8:24 PM Michael Bradshaw wrote: > Signed-off-by: Michael Bradshaw > --- > libavcodec/proresenc_anatoliy.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/libavcodec/proresenc_anatoliy.c > b/libavcodec/proresenc_anatoliy.c > index 1128978330..3a

[FFmpeg-devel] [PATCH] avcodec/proresenc: add support for PQ and HLG

2020-08-19 Thread Michael Bradshaw
Signed-off-by: Michael Bradshaw --- libavcodec/proresenc_anatoliy.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/libavcodec/proresenc_anatoliy.c b/libavcodec/proresenc_anatoliy.c index 1128978330..3005db0bb4 100644 --- a/libavcodec/proresenc_anatoliy.c +++ b/libavcodec/pr

Re: [FFmpeg-devel] [PATCH] dnn/native: rename struct ConvolutionalNetwork to NativeModel

2020-08-19 Thread Guo, Yejun
> -Original Message- > From: ffmpeg-devel On Behalf Of Ting Fu > Sent: 2020年8月19日 21:43 > To: ffmpeg-devel@ffmpeg.org > Subject: [FFmpeg-devel] [PATCH] dnn/native: rename struct > ConvolutionalNetwork to NativeModel > > Signed-off-by: Ting Fu > --- > libavfilter/dnn/dnn_backend_native

[FFmpeg-devel] [PATCH] dnn: move output name from DNNModel.set_input_output to DNNModule.execute_model

2020-08-19 Thread Guo, Yejun
currently, output is set both at DNNModel.set_input_output and DNNModule.execute_model, it makes sense that the output name is provided at model inference time so all the output info is set at a single place. and so DNNModel.set_input_output is renamed to DNNModel.set_input Signed-off-by: Guo, Ye

Re: [FFmpeg-devel] [PATCH] avcodec/proresenc: add support for PQ and HLG

2020-08-19 Thread zhilizhao
> On Aug 20, 2020, at 10:36 AM, Michael Bradshaw > wrote: > > Signed-off-by: Michael Bradshaw > --- > libavcodec/proresenc_anatoliy.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/libavcodec/proresenc_anatoliy.c b/libavcodec/proresenc_anatoliy.c > index 1128978330

Re: [FFmpeg-devel] [PATCH v5 5/5] lavc, doc: add libuavs3d video decoder wrapper

2020-08-19 Thread hwren
At 2020-08-19 22:23:07, "Moritz Barsnick" wrote: >On Wed, Aug 19, 2020 at 14:25:56 +0800, hwr...@126.com wrote: >> - AV1 Low overhead bitstream format demuxer >> +- AVS3 video decoder via libuavs3d > >I wonder whether the raw demuxer should have been mentioned in its >respectiv

Re: [FFmpeg-devel] [PATCH v5 2/5] lavc/avs3: add AVS3 related definitions

2020-08-19 Thread hwren
At 2020-08-19 20:56:27, "Nicolas George" wrote: >hwr...@126.com (12020-08-19): >> From: hwren >> >> Signed-off-by: hwren >> --- >> libavcodec/Makefile | 2 + >> libavcodec/avs3.c | 95 + >> libavcodec/avs3.h | 52 +

Re: [FFmpeg-devel] [PATCH v5 2/5] lavc/avs3: add AVS3 related definitions

2020-08-19 Thread hwren
At 2020-08-19 22:18:52, "Moritz Barsnick" wrote: >On Wed, Aug 19, 2020 at 14:25:53 +0800, hwr...@126.com wrote: >> + * AVS3 related definition > >definitions? >> +}; >> \ No newline at end of file > >Please amend a carriage return to the last line. > >> + * AVS3 related definit

Re: [FFmpeg-devel] [PATCH v5 3/5] lavc/avs3_parser: add avs3 parser

2020-08-19 Thread hwren
At 2020-08-19 22:14:04, "Moritz Barsnick" wrote: >On Wed, Aug 19, 2020 at 14:25:54 +0800, hwr...@126.com wrote: >> +for (; cur < buf_size; ++cur) { >> +state = (state << 8) | buf[cur]; >> +if (ISPIC(buf[cur])){ >> +++cur; > >ffmpeg

Re: [FFmpeg-devel] [PATCH] avutil/video_enc_params: fix code comment

2020-08-19 Thread leozhang
zhilizhao 于2020年8月13日周四 下午12:55写道: > > > > > On Aug 13, 2020, at 11:57 AM, leozhang wrote: > > > > Signed-off-by: leozhang > > --- > > libavutil/video_enc_params.h | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/libavutil/video_enc_params.h b/libavutil/video_enc_par

Re: [FFmpeg-devel] [PATCH v4]libavfilter/asrc_atone.c : generate algorithmic music

2020-08-19 Thread Ashutosh Pradhan
On Wed, Aug 19, 2020 at 6:12 PM Nicolas George wrote: > Ashutosh Pradhan (12020-08-18): > > Generate algorithmic music using riffs, lindenmayer systems, cellular > automaton and rhythm algorithms. > > Fixed the error that was causing segmentation fault in the previous > patch. > > Thanks. (But th

Re: [FFmpeg-devel] [PATCH v5 2/5] lavc/avs3: add AVS3 related definitions

2020-08-19 Thread hwren
At 2020-08-19 21:15:32, "Andreas Rheinhardt" wrote: >hwr...@126.com: >> From: hwren >> >> Signed-off-by: hwren >> --- >> libavcodec/Makefile | 2 + >> libavcodec/avs3.c | 95 + >> libavcodec/avs3.h | 52 ++

[FFmpeg-devel] [PATCH v6 4/5] lavf/avs3dec: add raw avs3 demuxer

2020-08-19 Thread hwrenx
From: hwren Signed-off-by: hbj Signed-off-by: hwren --- Changelog| 1 + libavformat/Makefile | 1 + libavformat/allformats.c | 1 + libavformat/avs3dec.c| 68 libavformat/version.h| 2 +- 5 files changed, 72 insertions(+)

  1   2   >