Re: [FFmpeg-devel] [PATCH v2 0/4] Add hevc alpha layer decoding basic support

2023-02-28 Thread zhilizhao(赵志立)
> On Jan 6, 2023, at 23:52, Zhao Zhili wrote: > > From: Zhao Zhili > > v2: > 1. Check vps_max_layers and vps_max_layer_id inside hevc decoder > 2. Add hevc_extract_layer bsf to do the job rather than modifing > hevc_metadata, > 3. Check vps_max_layers_minus1 and vps_max_layer_id inside bsf

Re: [FFmpeg-devel] [PATCH] libavformat/tcp: add local_addr/local_port for network option

2023-02-28 Thread Nicolas George
jack (12023-02-28): > Signed-off-by: jack > --- > libavformat/tcp.c | 44 > 1 file changed, 44 insertions(+) Thanks for the patch You neglected to update the documentation, and a few remarks below. > > diff --git a/libavformat/tcp.c

Re: [FFmpeg-devel] [PATCH] checkasm: add support for vvc alf

2023-02-28 Thread Martin Storsjö
On Sun, 26 Feb 2023, Nuo Mi wrote: +#include + +#include "libavutil/intreadwrite.h" +#include "libavutil/mem_internal.h" + +#include "libavcodec/avcodec.h" + +#include "libavcodec/vvcdsp.h" +#include "libavcodec/vvcdec.h" + +#include "checkasm.h" + +static const uint32_t pixel_mask[3] = {

Re: [FFmpeg-devel] [PATCH 1/4] lavc/mediacodecenc: Add pix2color_fmt() and color2pix_fmt()

2023-02-28 Thread zhilizhao(赵志立)
> +static int pix2color_fmt(AVCodecContext *avctx, enum AVPixelFormat pix_fmt) > +{ > +for (int i = 0; i < FF_ARRAY_ELEMS(color_formats); i++) { > +if (pix_fmt == color_formats[i].pix_fmt) { > +return color_formats[i].color_format; > +} > +} > +

[FFmpeg-devel] [PATCH 8/8] lavc/libvpxenc: drop FrameListData.duration

2023-02-28 Thread Anton Khirnov
It is write-only. --- libavcodec/libvpxenc.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/libavcodec/libvpxenc.c b/libavcodec/libvpxenc.c index aeeaa0e681..3d1abb7df9 100644 --- a/libavcodec/libvpxenc.c +++ b/libavcodec/libvpxenc.c @@ -58,8 +58,6 @@ struct FrameListData { size_t sz;

[FFmpeg-devel] [PATCH 7/8] lavc/libvpxenc: handle queue desync more gracefully

2023-02-28 Thread Anton Khirnov
If the packets returned by libvpx and our internal frame properties queue get desynchronized for some reason (should not happen, but it is not clear libvpx API guarantees this), we will keep adding to the queue indefinitely and never remove anything. Change the code to drain the queue even if

Re: [FFmpeg-devel] [PATCH 2/4] lavc/mediacodec_wrapper: Refactor ff_AMediaCodecList_getCodecNameByType()

2023-02-28 Thread zhilizhao(赵志立)
> > A lot shorter, nested variables and keeps going in case of exceptions. > Makes use of C99 declarations. > > This patch has been released by Epic Games' legal department. This patch triggered multiple warning: warning: mixing declarations and code is incompatible with standards before C99

Re: [FFmpeg-devel] [PATCH] libavcodec/hevc: add epel_put_pixels which same as qpel in arm

2023-02-28 Thread ??????
Thank you for your advice. I will split it, and submit a new patch. On the other hand, I will run "make fate-hevc" to check over. --Original-- From:

Re: [FFmpeg-devel] [PATCH] libavcodec/libfdk-aacnc: send encoder delay/padding in packet side data

2023-02-28 Thread Martin Storsjö
On Fri, 24 Feb 2023, JonHGee wrote: --- libavcodec/libfdk-aacenc.c | 27 ++- 1 file changed, 26 insertions(+), 1 deletion(-) diff --git a/libavcodec/libfdk-aacenc.c b/libavcodec/libfdk-aacenc.c index 54549de473..55d10990e4 100644 --- a/libavcodec/libfdk-aacenc.c +++

[FFmpeg-devel] [PATCH] libavcodec/hevc: remove duplicate semicolon in hevcdsp_init_neon

2023-02-28 Thread xufuji456
--- libavcodec/arm/hevcdsp_init_neon.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/libavcodec/arm/hevcdsp_init_neon.c b/libavcodec/arm/hevcdsp_init_neon.c index 34f51b00d1..19e00af50e 100644 --- a/libavcodec/arm/hevcdsp_init_neon.c +++

[FFmpeg-devel] [PATCH] avcodec/aacps_tablegen: fix build error after 21814a7

2023-02-28 Thread Zhao Zhili
From: Zhao Zhili Fix tickets #10225 DECLARE_ALIGNED has been moved to mem_internal.h. Signed-off-by: Zhao Zhili --- libavcodec/aacps_tablegen.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavcodec/aacps_tablegen.h b/libavcodec/aacps_tablegen.h index

Re: [FFmpeg-devel] [PATCH] doc/filters: update SITI description

2023-02-28 Thread Thilo Borgmann
Am 28.02.23 um 14:13 schrieb Thilo Borgmann: Am 28.02.23 um 12:42 schrieb Werner Robitza: The filter implements the 'legacy' version from a superseded recommendation. ---   doc/filters.texi | 8 +---   1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/doc/filters.texi

[FFmpeg-devel] Website release notes for 6.0

2023-02-28 Thread Lynne
Wrote the release notes for 6.0, containing an explanation of the new releases/ABI bump details, and an overview of what has changed. Patch attached. >From 20ec89bc3e79406dcff6c56663a5f18fffc349e7 Mon Sep 17 00:00:00 2001 From: Lynne Date: Tue, 28 Feb 2023 10:39:18 +0100 Subject: [PATCH]

Re: [FFmpeg-devel] Website release notes for 6.0

2023-02-28 Thread Lynne
Feb 28, 2023, 10:41 by d...@lynne.ee: > Wrote the release notes for 6.0, containing an > explanation of the new releases/ABI bump details, > and an overview of what has changed. > > Patch attached. > Corrected a spelling mistake, more specifically stated which release is an LTS release, and a

[FFmpeg-devel] [PATCH] libavformat/tcp: add local_addr/local_port for network option

2023-02-28 Thread jack
Signed-off-by: jack --- libavformat/tcp.c | 44 1 file changed, 44 insertions(+) diff --git a/libavformat/tcp.c b/libavformat/tcp.c index a11ccbb913..598d61067e 100644 --- a/libavformat/tcp.c +++ b/libavformat/tcp.c @@ -36,6 +36,8 @@ typedef struct

[FFmpeg-devel] [PATCH] doc/filters: update SITI description

2023-02-28 Thread Werner Robitza
The filter implements the 'legacy' version from a superseded recommendation. --- doc/filters.texi | 8 +--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/doc/filters.texi b/doc/filters.texi index 47e92b9269..25574cd55c 100644 --- a/doc/filters.texi +++ b/doc/filters.texi @@

[FFmpeg-devel] [PATCH 3/8] lavc/libvpxenc: reindent

2023-02-28 Thread Anton Khirnov
--- libavcodec/libvpxenc.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/libavcodec/libvpxenc.c b/libavcodec/libvpxenc.c index eaa4ad8f25..abaa8c3513 100644 --- a/libavcodec/libvpxenc.c +++ b/libavcodec/libvpxenc.c @@ -1284,11 +1284,11 @@ static int

[FFmpeg-devel] [PATCH 1/8] lavu/frame: improve AVFrame.opaque[_ref] documentation

2023-02-28 Thread Anton Khirnov
Make them match each other, mention interaction with AV_CODEC_FLAG_COPY_OPAQUE. --- libavutil/frame.h | 30 +++--- 1 file changed, 23 insertions(+), 7 deletions(-) diff --git a/libavutil/frame.h b/libavutil/frame.h index 2580269549..4ed27cf43f 100644 ---

[FFmpeg-devel] [PATCH 5/8] lavc/libvpxenc: handle frame durations and AV_CODEC_CAP_ENCODER_REORDERED_OPAQUE

2023-02-28 Thread Anton Khirnov
--- libavcodec/libvpxenc.c | 139 + libavcodec/version.h | 2 +- 2 files changed, 100 insertions(+), 41 deletions(-) diff --git a/libavcodec/libvpxenc.c b/libavcodec/libvpxenc.c index 77921badba..af16e53deb 100644 --- a/libavcodec/libvpxenc.c +++

[FFmpeg-devel] [PATCH 2/8] lavc/libvpxenc: drop frame_number

2023-02-28 Thread Anton Khirnov
It is not used, except to check whether the packet is valid before writing HDR metadata to the packet in storeframe(). However, that check serves no purpose, as the encoded packet is already treated as valid higher up in this function. --- libavcodec/libvpxenc.c | 9 + 1 file changed, 1

[FFmpeg-devel] [PATCH 4/8] lavc/libvpxenc: rename hdr10_plus_fifo and related objects

2023-02-28 Thread Anton Khirnov
This AVFifo is used to propagate HDR metadata from input frames to output packets, since libvpx does not allow passing through arbitrary user data. It will be extended to pass through other kinds of data in future commits, so give it a more generic name. --- libavcodec/libvpxenc.c | 51

[FFmpeg-devel] [PATCH 6/8] lavc/libvpxenc: drop a useless condition

2023-02-28 Thread Anton Khirnov
A non-NULL packet is always passed to frame_data_apply(). --- libavcodec/libvpxenc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavcodec/libvpxenc.c b/libavcodec/libvpxenc.c index af16e53deb..33f35bbaf4 100644 --- a/libavcodec/libvpxenc.c +++ b/libavcodec/libvpxenc.c @@

[FFmpeg-devel] [PATCH 1/2] avcodec/libvpxdec: remove unnecessary init_static_data function

2023-02-28 Thread James Almer
It's used only by the encoder. Signed-off-by: James Almer --- libavcodec/libvpxdec.c | 1 - 1 file changed, 1 deletion(-) diff --git a/libavcodec/libvpxdec.c b/libavcodec/libvpxdec.c index 0ae19c3f72..8e6291fe20 100644 --- a/libavcodec/libvpxdec.c +++ b/libavcodec/libvpxdec.c @@ -391,6 +391,5

[FFmpeg-devel] [PATCH 2/2] libavcodec/libvpxenc: move libvpx-vp9 init_static_data function to the only place it's used

2023-02-28 Thread James Almer
Signed-off-by: James Almer --- libavcodec/Makefile| 4 +-- libavcodec/libvpx.c| 81 -- libavcodec/libvpx.h| 10 -- libavcodec/libvpxenc.c | 41 - 4 files changed, 42 insertions(+), 94 deletions(-) delete mode 100644

[FFmpeg-devel] [PATCH] avcodec/pthread_frame: remove forgotten deprecation warning wrappers

2023-02-28 Thread James Almer
Missed in e0786a8e. Signed-off-by: James Almer --- libavcodec/pthread_frame.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/libavcodec/pthread_frame.c b/libavcodec/pthread_frame.c index d9d5afaa82..31785acbef 100644 --- a/libavcodec/pthread_frame.c +++ b/libavcodec/pthread_frame.c @@

Re: [FFmpeg-devel] [PATCH] libavcodec/hevc: remove duplicate semicolon in hevcdsp_init_neon

2023-02-28 Thread Martin Storsjö
On Tue, 28 Feb 2023, xufuji456 wrote: --- libavcodec/arm/hevcdsp_init_neon.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/libavcodec/arm/hevcdsp_init_neon.c b/libavcodec/arm/hevcdsp_init_neon.c index 34f51b00d1..19e00af50e 100644 ---

Re: [FFmpeg-devel] [PATCH] aarch64: hevcdsp_idct: Reuse preexisting macros for transposes

2023-02-28 Thread Martin Storsjö
On Thu, 23 Feb 2023, Martin Storsjö wrote: Signed-off-by: Martin Storsjö --- libavcodec/aarch64/hevcdsp_idct_neon.S | 16 +++- 1 file changed, 3 insertions(+), 13 deletions(-) diff --git a/libavcodec/aarch64/hevcdsp_idct_neon.S b/libavcodec/aarch64/hevcdsp_idct_neon.S index

Re: [FFmpeg-devel] [PATCH] libavcodec/hevc: add epel_put_pixels which same as qpel in arm

2023-02-28 Thread Martin Storsjö
On Sun, 26 Feb 2023, xufuji456 wrote: --- libavcodec/arm/hevcdsp_init_neon.c | 21 +++-- 1 file changed, 19 insertions(+), 2 deletions(-) diff --git a/libavcodec/arm/hevcdsp_init_neon.c b/libavcodec/arm/hevcdsp_init_neon.c index 8094e6c62e..4063acaf51 100644 ---

Re: [FFmpeg-devel] [PATCH] libavcodec/hevc: reuse scale_store on idct32x32_neon

2023-02-28 Thread Martin Storsjö
On Fri, 24 Feb 2023, xufuji456 wrote: --- libavcodec/arm/hevcdsp_idct_neon.S | 18 ++ 1 file changed, 2 insertions(+), 16 deletions(-) diff --git a/libavcodec/arm/hevcdsp_idct_neon.S b/libavcodec/arm/hevcdsp_idct_neon.S index 75795e6a6a..41ca3b83a8 100644 ---

Re: [FFmpeg-devel] [PATCH 3/4] lavc/mediacodec_wrapper: Add function for probing supported color formats

2023-02-28 Thread zhilizhao(赵志立)
> This patch has been released by Epic Games' legal department. This patch has the same -Wdeclaration-after-statement issue as patch 2/4. PS: I’m not sure whether the legal statement is appropriate as commit message. It should be self-evident for patches sending to the mailing list :) > --- >

Re: [FFmpeg-devel] [PATCH] doc/filters: update SITI description

2023-02-28 Thread Thilo Borgmann
Am 28.02.23 um 12:42 schrieb Werner Robitza: The filter implements the 'legacy' version from a superseded recommendation. --- doc/filters.texi | 8 +--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/doc/filters.texi b/doc/filters.texi index 47e92b9269..25574cd55c 100644

[FFmpeg-devel] [PATCH] avcodec/nvenc: fix NULL pointer dereference

2023-02-28 Thread Zhao Zhili
From: Zhao Zhili This can happen if encoder init failed before setup the queue, then reorder_queue_flush() is called by close(). Fix ticket #10221 Signed-off-by: Zhao Zhili --- libavcodec/nvenc.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/libavcodec/nvenc.c b/libavcodec/nvenc.c

Re: [FFmpeg-devel] [PATCH] libavcodec/hevc: add hevc idct4x4 neon of aarch64 after fixed

2023-02-28 Thread Martin Storsjö
On Fri, 24 Feb 2023, xufuji456 wrote: --- libavcodec/aarch64/hevcdsp_idct_neon.S| 40 +++ libavcodec/aarch64/hevcdsp_init_aarch64.c | 4 +++ 2 files changed, 44 insertions(+) Thanks, this looks good to me now, will push in a moment. The subject of the commit doesn't

Re: [FFmpeg-devel] [PATCH] avcodec/nvenc: fix NULL pointer dereference

2023-02-28 Thread Steven Liu
Zhao Zhili 于2023年2月28日周二 18:44写道: > > From: Zhao Zhili > > This can happen if encoder init failed before setup the queue, then > reorder_queue_flush() is called by close(). > > Fix ticket #10221 > > Signed-off-by: Zhao Zhili > --- > libavcodec/nvenc.c | 2 ++ > 1 file changed, 2 insertions(+)

Re: [FFmpeg-devel] [PATCH 4/4] lavc/mediacodecenc: List supported pixel formats on configuration error

2023-02-28 Thread zhilizhao(赵志立)
> This patch has been released by Epic Games' legal department. > --- > libavcodec/mediacodecenc.c | 46 ++ > 1 file changed, 46 insertions(+) > > diff --git a/libavcodec/mediacodecenc.c b/libavcodec/mediacodecenc.c > index 03c80cbf99..1b8a2837c4 100644 > ---

[FFmpeg-devel] [PATCH] libavformat/tcp: add local_addr/local_port for network option

2023-02-28 Thread jackarain
Signed-off-by: jackarain --- doc/protocols.texi| 6 ++ libavformat/network.c | 14 + libavformat/network.h | 2 +- libavformat/tcp.c | 49 ++- 4 files changed, 65 insertions(+), 6 deletions(-) diff --git a/doc/protocols.texi

Re: [FFmpeg-devel] [PATCH] doc/filters: update SITI description

2023-02-28 Thread Werner Robitza
On Tue, Feb 28, 2023 at 2:16 PM Thilo Borgmann wrote: > > Am 28.02.23 um 14:13 schrieb Thilo Borgmann: > > Am 28.02.23 um 12:42 schrieb Werner Robitza: > >> The filter implements the 'legacy' version from a superseded > >> recommendation. > >> --- > >> doc/filters.texi | 8 +--- > >> 1

Re: [FFmpeg-devel] Website release notes for 6.0

2023-02-28 Thread Lynne
Feb 28, 2023, 10:59 by d...@lynne.ee: > Feb 28, 2023, 10:41 by d...@lynne.ee: > >> Wrote the release notes for 6.0, containing an >> explanation of the new releases/ABI bump details, >> and an overview of what has changed. >> >> Patch attached. >> Ping, release has been tagged for quite a while

Re: [FFmpeg-devel] [PATCH] checkasm: add support for vvc alf

2023-02-28 Thread Nuo Mi
On Tue, Feb 28, 2023 at 7:51 PM Martin Storsjö wrote: > On Sun, 26 Feb 2023, Nuo Mi wrote: > > > +#include > > + > > +#include "libavutil/intreadwrite.h" > > +#include "libavutil/mem_internal.h" > > + > > +#include "libavcodec/avcodec.h" > > + > > +#include "libavcodec/vvcdsp.h" > > +#include

Re: [FFmpeg-devel] [PATCH] avcodec/nvenc: fix NULL pointer dereference

2023-02-28 Thread Timo Rothenpieler
On 28.02.2023 16:03, Zhao Zhili wrote: I can move the check from here to close(). assert is helpful if it can catch bugs during development. It doesn't help much here since this is a rare case which doesn't triggered during development. Crashing with an assertion is still much better than

Re: [FFmpeg-devel] [PATCH] libavformat/tcp: add local_addr/local_port for network option

2023-02-28 Thread jackarain
Done. Nicolas George 于2023年2月28日周二 18:57写道: > jack (12023-02-28): > > Signed-off-by: jack > > --- > > libavformat/tcp.c | 44 > > 1 file changed, 44 insertions(+) > > Thanks for the patch > > You neglected to update the documentation, and a few

Re: [FFmpeg-devel] [PATCH] libavcodec/libfdk-aacenc: Enable writing DRC metadata

2023-02-28 Thread Martin Storsjö
On Mon, 27 Feb 2023, JonHGee wrote: Added basic DRC options and ref levels to AV options. If any options are selected, metadata mode is set accordingly and metadata is added to input buffer per FDK encoder API. --- libavcodec/libfdk-aacenc.c | 72 ++ 1 file

[FFmpeg-devel] [PATCH] libavformat/tcp: add local_addr/local_port for network option

2023-02-28 Thread jackarain
Signed-off-by: jackarain --- doc/protocols.texi| 6 ++ libavformat/network.c | 14 + libavformat/network.h | 2 +- libavformat/tcp.c | 48 ++- 4 files changed, 64 insertions(+), 6 deletions(-) diff --git a/doc/protocols.texi

Re: [FFmpeg-devel] [PATCH] avcodec/nvenc: fix NULL pointer dereference

2023-02-28 Thread Timo Rothenpieler
On 28.02.2023 19:43, Zhao Zhili wrote: From: Zhao Zhili This can happen if encoder init failed before setup the queue, then reorder_queue_flush() is called by close(). Fix ticket #10221 Signed-off-by: Zhao Zhili --- libavcodec/nvenc.c | 2 ++ 1 file changed, 2 insertions(+) diff --git

Re: [FFmpeg-devel] [PATCH v2] avcodec: add D3D12VA hardware accelerated H264, HEVC, VP9, and AV1 decoding

2023-02-28 Thread Wu, Tong1
> [PATCH v2] avcodec: add D3D12VA hardware accelerated H264, HEVC, VP9, > and AV1 decoding > > Patches attached. >-HWACCEL_D3D11VA2(h264), >+ HWACCEL_D3D11VA(h264), This shouldn't be changed. It will block d3d11va h264dec. >+#endif >+#if

Re: [FFmpeg-devel] [PATCH] avcodec/nvenc: fix NULL pointer dereference

2023-02-28 Thread Zhao Zhili
> From: ffmpeg-devel On Behalf Of Timo > Rothenpieler > Sent: 2023年2月28日 22:37 > To: ffmpeg-devel@ffmpeg.org > Subject: Re: [FFmpeg-devel] [PATCH] avcodec/nvenc: fix NULL pointer > dereference > > On 28.02.2023 19:43, Zhao Zhili wrote: > > From: Zhao Zhili > > > > This can happen if encoder

[FFmpeg-devel] [PATCH] Use https for repository links

2023-02-28 Thread Michael Niedermayer
Signed-off-by: Michael Niedermayer --- CREDITS| 4 ++-- doc/authors.texi | 4 ++-- doc/git-howto.texi | 2 +- 3 files changed, 5 insertions(+), 5 deletions(-) diff --git a/CREDITS b/CREDITS index e29f0b853c..f1aea93d6b 100644 --- a/CREDITS +++ b/CREDITS @@ -1,6 +1,6 @@ -See the

Re: [FFmpeg-devel] [PATCH 1/3] decklink: Don't take for granted that first frame to decklink output will be PTS 0

2023-02-28 Thread Marton Balint
On Thu, 23 Feb 2023, Devin Heitmueller wrote: The existing code assumed that the first frame received by the decklink output would always be PTS zero. However if running in other timing modes than the default of CBR, items such as frame dropping at the beginning may result in starting at a

Re: [FFmpeg-devel] [PATCH 5/8] lavc/libvpxenc: handle frame durations and AV_CODEC_CAP_ENCODER_REORDERED_OPAQUE

2023-02-28 Thread James Zern
On Tue, Feb 28, 2023 at 4:01 AM Anton Khirnov wrote: > > --- > libavcodec/libvpxenc.c | 139 + > libavcodec/version.h | 2 +- > 2 files changed, 100 insertions(+), 41 deletions(-) > lgtm > diff --git a/libavcodec/libvpxenc.c b/libavcodec/libvpxenc.c

Re: [FFmpeg-devel] [PATCH v4] avcodec/pngdec: read colorspace info when decoding with AVDISCARD_ALL

2023-02-28 Thread Leo Izen
On 2/27/23 11:34, Leo Izen wrote: On 2/21/23 17:35, Leo Izen wrote: These chunks are lightweight and it's useful information to have when running ffmpeg -i or ffprobe, for example. ---   libavcodec/pngdec.c  | 136 ++-   tests/ref/fate/png-icc   |   8

Re: [FFmpeg-devel] Website release notes for 6.0

2023-02-28 Thread Marton Balint
On Tue, 28 Feb 2023, Lynne wrote: Feb 28, 2023, 10:59 by d...@lynne.ee: Feb 28, 2023, 10:41 by d...@lynne.ee: Wrote the release notes for 6.0, containing an explanation of the new releases/ABI bump details, and an overview of what has changed. Patch attached. Ping, release has been

Re: [FFmpeg-devel] Website release notes for 6.0

2023-02-28 Thread Michael Niedermayer
Hi On Tue, Feb 28, 2023 at 08:44:01PM +0100, Marton Balint wrote: > > > On Tue, 28 Feb 2023, Lynne wrote: > > > Feb 28, 2023, 10:59 by d...@lynne.ee: > > > > > Feb 28, 2023, 10:41 by d...@lynne.ee: > > > > > > > Wrote the release notes for 6.0, containing an > > > > explanation of the new

Re: [FFmpeg-devel] [PATCH 1/2] avcodec/libvpxdec: remove unnecessary init_static_data function

2023-02-28 Thread James Zern
On Tue, Feb 28, 2023 at 4:07 AM James Almer wrote: > > It's used only by the encoder. > It sets AVCodec.pix_fmts, but maybe the values reported aren't used meaningfully. > Signed-off-by: James Almer > --- > libavcodec/libvpxdec.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git

Re: [FFmpeg-devel] [PATCH 1/2] avcodec/libvpxdec: remove unnecessary init_static_data function

2023-02-28 Thread James Almer
On 2/28/2023 5:40 PM, James Zern wrote: On Tue, Feb 28, 2023 at 4:07 AM James Almer wrote: It's used only by the encoder. It sets AVCodec.pix_fmts, but maybe the values reported aren't used meaningfully. Indeed, they aren't. AVCodec.pix_fmts is a list of formats an encoder accepts as

Re: [FFmpeg-devel] Website release notes for 6.0

2023-02-28 Thread Lynne
Feb 28, 2023, 20:47 by mich...@niedermayer.cc: > Hi > > On Tue, Feb 28, 2023 at 08:44:01PM +0100, Marton Balint wrote: > >> >> >> On Tue, 28 Feb 2023, Lynne wrote: >> >> > Feb 28, 2023, 10:59 by d...@lynne.ee: >> > >> > > Feb 28, 2023, 10:41 by d...@lynne.ee: >> > > >> > > > Wrote the release

Re: [FFmpeg-devel] [PATCH 2/8] lavc/libvpxenc: drop frame_number

2023-02-28 Thread James Zern
On Tue, Feb 28, 2023 at 4:02 AM Anton Khirnov wrote: > > It is not used, except to check whether the packet is valid before > writing HDR metadata to the packet in storeframe(). However, that check > serves no purpose, as the encoded packet is already treated as valid > higher up in this

Re: [FFmpeg-devel] [PATCH 3/8] lavc/libvpxenc: reindent

2023-02-28 Thread James Zern
On Tue, Feb 28, 2023 at 4:01 AM Anton Khirnov wrote: > > --- > libavcodec/libvpxenc.c | 10 +- > 1 file changed, 5 insertions(+), 5 deletions(-) > lgtm. > diff --git a/libavcodec/libvpxenc.c b/libavcodec/libvpxenc.c > index eaa4ad8f25..abaa8c3513 100644 > --- a/libavcodec/libvpxenc.c >

Re: [FFmpeg-devel] [PATCH 4/8] lavc/libvpxenc: rename hdr10_plus_fifo and related objects

2023-02-28 Thread James Zern
On Tue, Feb 28, 2023 at 4:02 AM Anton Khirnov wrote: > > This AVFifo is used to propagate HDR metadata from input frames to > output packets, since libvpx does not allow passing through arbitrary > user data. > > It will be extended to pass through other kinds of data in future > commits, so give

Re: [FFmpeg-devel] [PATCH 6/8] lavc/libvpxenc: drop a useless condition

2023-02-28 Thread James Zern
On Tue, Feb 28, 2023 at 4:02 AM Anton Khirnov wrote: > > A non-NULL packet is always passed to frame_data_apply(). > --- > libavcodec/libvpxenc.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > lgtm > diff --git a/libavcodec/libvpxenc.c b/libavcodec/libvpxenc.c > index

Re: [FFmpeg-devel] [PATCH 1/2] avcodec/libvpxdec: remove unnecessary init_static_data function

2023-02-28 Thread James Zern
On Tue, Feb 28, 2023 at 12:49 PM James Almer wrote: > > On 2/28/2023 5:40 PM, James Zern wrote: > > On Tue, Feb 28, 2023 at 4:07 AM James Almer wrote: > >> > >> It's used only by the encoder. > >> > > > > It sets AVCodec.pix_fmts, but maybe the values reported aren't used > > meaningfully. > >

Re: [FFmpeg-devel] [PATCH] libavcodec/libfdk-aacenc: Enable writing DRC metadata

2023-02-28 Thread Martin Storsjö
On Tue, 28 Feb 2023, JonHGee wrote: Signed-off-by: JonHGee --- libavcodec/libfdk-aacenc.c | 69 +++--- 1 file changed, 56 insertions(+), 13 deletions(-) diff --git a/libavcodec/libfdk-aacenc.c b/libavcodec/libfdk-aacenc.c index 54549de473..123dabf3ae 100644 ---

[FFmpeg-devel] [PATCH] lavc/avcodec.h: extend documentation for avcodec_open2()

2023-02-28 Thread Stefano Sabatini
In particular, clarify how to set options in the codec context, and mention when to use avcodec_parameters_to_context(). Fix trac issue http://trac.ffmpeg.org/ticket/5781. --- libavcodec/avcodec.h | 29 - 1 file changed, 24 insertions(+), 5 deletions(-) diff --git

Re: [FFmpeg-devel] [PATCH] lavc/avcodec.h: extend documentation for avcodec_open2()

2023-02-28 Thread Stefano Sabatini
On date Tuesday 2023-02-28 23:28:56 +0100, Stefano Sabatini wrote: > In particular, clarify how to set options in the codec context, and mention > when to use > avcodec_parameters_to_context(). > > Fix trac issue http://trac.ffmpeg.org/ticket/5781. > --- > libavcodec/avcodec.h | 29

[FFmpeg-devel] [PATCH] libavcodec/libfdk-aacnc: send encoder delay/padding in packet side data

2023-02-28 Thread JonHGee
Signed-off-by: JonHGee --- libavcodec/libfdk-aacenc.c | 25 - 1 file changed, 24 insertions(+), 1 deletion(-) diff --git a/libavcodec/libfdk-aacenc.c b/libavcodec/libfdk-aacenc.c index 54549de473..954ddab07f 100644 --- a/libavcodec/libfdk-aacenc.c +++

Re: [FFmpeg-devel] [PATCH 8/8] lavc/libvpxenc: drop FrameListData.duration

2023-02-28 Thread James Zern
On Tue, Feb 28, 2023 at 4:02 AM Anton Khirnov wrote: > > It is write-only. > --- > libavcodec/libvpxenc.c | 3 --- > 1 file changed, 3 deletions(-) > libaomenc.c transfers this to AVPacket. You added this in: 7cf161abe5 lavc/libaomenc: pass through frame durations to encoded packets Should

Re: [FFmpeg-devel] [PATCH] libavcodec/libfdk-aacenc: Enable writing DRC metadata

2023-02-28 Thread Martin Storsjö
On Tue, 28 Feb 2023, Jonathan Gee wrote: Looks mostly good to me now, thanks. I guess I can clean up the remaining few nitpicks without you having to resubmit the patch. So unless you disagree with the comments, I can push it with the minor touch-ups. // Martin Sounds good to me. No

Re: [FFmpeg-devel] [PATCH] lavfi/buffersrc: issue more specific error in case of invalid parameters

2023-02-28 Thread Stefano Sabatini
On date Wednesday 2023-03-01 01:01:26 +0100, Stefano Sabatini wrote: > --- > libavfilter/buffersrc.c | 13 ++--- > 1 file changed, 10 insertions(+), 3 deletions(-) > > diff --git a/libavfilter/buffersrc.c b/libavfilter/buffersrc.c > index ba17450b93..ea9556d691 100644 > ---

[FFmpeg-devel] [PATCH] libavcodec/libfdk-aacenc: Enable writing DRC metadata

2023-02-28 Thread JonHGee
Signed-off-by: JonHGee --- libavcodec/libfdk-aacenc.c | 69 +++--- 1 file changed, 56 insertions(+), 13 deletions(-) diff --git a/libavcodec/libfdk-aacenc.c b/libavcodec/libfdk-aacenc.c index 54549de473..123dabf3ae 100644 --- a/libavcodec/libfdk-aacenc.c +++

Re: [FFmpeg-devel] [PATCH] doc/ffmpeg: extend -dts_delta_threshold option description

2023-02-28 Thread Stefano Sabatini
On date Monday 2023-02-20 18:57:44 +0100, Anton Khirnov wrote: > Quoting Stefano Sabatini (2023-02-11 03:30:00) > > On date Thursday 2023-02-09 00:41:18 +0100, Michael Niedermayer wrote: > > > On Mon, Feb 06, 2023 at 02:25:23AM +0100, Stefano Sabatini wrote: > > [...] > > > > Subject: [PATCH 2/2]

Re: [FFmpeg-devel] [PATCH 1/2] ffmpeg_demux: show fixed timestamps in ts_fixup

2023-02-28 Thread Stefano Sabatini
On date Saturday 2023-02-11 01:12:18 +0100, Stefano Sabatini wrote: > On date Monday 2023-02-06 02:22:24 +0100, Stefano Sabatini wrote: > > Help debugging. > > --- > > fftools/ffmpeg_demux.c | 21 + > > 1 file changed, 13 insertions(+), 8 deletions(-) > > Will apply in a few

Re: [FFmpeg-devel] [PATCH] libavcodec/libfdk-aacenc: Enable writing DRC metadata

2023-02-28 Thread Jonathan Gee
> Looks mostly good to me now, thanks. I guess I can clean up the remaining > few nitpicks without you having to resubmit the patch. So unless you > disagree with the comments, I can push it with the minor touch-ups. > > // Martin > Sounds good to me. No disagreements here. Thank you for going

Re: [FFmpeg-devel] [PATCH 1/2] doc/dev_community: add the addresses of the committees

2023-02-28 Thread Thilo Borgmann
Am 22.02.23 um 13:34 schrieb Thilo Borgmann: Am 08.02.23 um 16:57 schrieb Thilo Borgmann: From: Nicolas George Omitting the .org from the address should be protection enough against spam spiders. Signed-off-by: Nicolas George ---   doc/dev_community/community.md | 4   1 file changed, 4

Re: [FFmpeg-devel] [PATCH] src/template_head2: Make "community" a seperate page containing Organisation and Code of Conduct.

2023-02-28 Thread Thilo Borgmann
Am 22.02.23 um 13:35 schrieb Thilo Borgmann: Am 08.02.23 um 16:48 schrieb Thilo Borgmann: Forgot to put this in the subject, this patch is for ffmpeg-web, of course. -Thilo Am 08.02.23 um 16:47 schrieb Thilo Borgmann: ---   src/template_head2 | 3 ++-   1 file changed, 2 insertions(+), 1

Re: [FFmpeg-devel] [PATCH] doc/filters: update SITI description

2023-02-28 Thread Thilo Borgmann
Am 28.02.23 um 18:12 schrieb Werner Robitza: On Tue, Feb 28, 2023 at 2:16 PM Thilo Borgmann wrote: Am 28.02.23 um 14:13 schrieb Thilo Borgmann: Am 28.02.23 um 12:42 schrieb Werner Robitza: The filter implements the 'legacy' version from a superseded recommendation. --- doc/filters.texi |

Re: [FFmpeg-devel] [PATCH] Use https for repository links

2023-02-28 Thread Stefano Sabatini
On date Tuesday 2023-02-28 20:27:12 +0100, Michael Niedermayer wrote: > Signed-off-by: Michael Niedermayer > --- > CREDITS| 4 ++-- > doc/authors.texi | 4 ++-- > doc/git-howto.texi | 2 +- > 3 files changed, 5 insertions(+), 5 deletions(-) LGTM.

Re: [FFmpeg-devel] [PATCH 5/8] lavc/libvpxenc: handle frame durations and AV_CODEC_CAP_ENCODER_REORDERED_OPAQUE

2023-02-28 Thread James Almer
On 2/28/2023 9:01 AM, Anton Khirnov wrote: +#if FF_API_REORDERED_OPAQUE +FF_DISABLE_DEPRECATION_WARNINGS +avctx->reordered_opaque = fd.reordered_opaque; +FF_ENABLE_DEPRECATION_WARNINGS +#endif If this was not being set before this patch, does it make sense at all to set it considering

[FFmpeg-devel] [PATCH] lavfi/buffersrc: issue more specific error in case of invalid parameters

2023-02-28 Thread Stefano Sabatini
--- libavfilter/buffersrc.c | 13 ++--- 1 file changed, 10 insertions(+), 3 deletions(-) diff --git a/libavfilter/buffersrc.c b/libavfilter/buffersrc.c index ba17450b93..ea9556d691 100644 --- a/libavfilter/buffersrc.c +++ b/libavfilter/buffersrc.c @@ -273,9 +273,16 @@ static av_cold int

[FFmpeg-devel] [PATCH] libswresample/audioconvert: check whether input frame data is null pointer

2023-02-28 Thread xufuji456
--- libswresample/audioconvert.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libswresample/audioconvert.c b/libswresample/audioconvert.c index 1d75ba1495..b297514b1a 100644 --- a/libswresample/audioconvert.c +++ b/libswresample/audioconvert.c @@ -242,7 +242,7 @@ int

Re: [FFmpeg-devel] [PATCH] lavc/avcodec.h: extend documentation for avcodec_open2()

2023-02-28 Thread zhilizhao(赵志立)
> On Mar 1, 2023, at 06:40, Stefano Sabatini wrote: > > On date Tuesday 2023-02-28 23:28:56 +0100, Stefano Sabatini wrote: >> In particular, clarify how to set options in the codec context, and mention >> when to use >> avcodec_parameters_to_context(). >> >> Fix trac issue

Re: [FFmpeg-devel] [PATCH] doc/filters: update SITI description

2023-02-28 Thread Werner Robitza
On Wed, Mar 1, 2023 at 1:15 AM Thilo Borgmann wrote: > > Am 28.02.23 um 18:12 schrieb Werner Robitza: > > On Tue, Feb 28, 2023 at 2:16 PM Thilo Borgmann > > wrote: > >> > >> Am 28.02.23 um 14:13 schrieb Thilo Borgmann: > >>> Am 28.02.23 um 12:42 schrieb Werner Robitza: > The filter