In MPEG-2 user data, there can be different types of Closed Captions
formats embedded (A53, SCTE-20, or DVD). The current behavior of the
CC extraction code in the MPEG-2 decoder is to not be aware of
multiple formats if multiple exist, therefore allowing one format
to overwrite the other during
Closed Captions decoder prints multiple \pos ASS tags per cue,
and preceding the \pos tag is a fixed \an7 that fixes rendering
position from the top left corner and enforces justification.
Printing multiple \an and \pos tags in this way is invalid behavior,
because only the first \pos tag in a
In this patchset are improvements for Closed Captions. This set overrides
the 3 patches I sent in the past few days, hence the v3 moniker.
Feedback should be addressed. Details about each change is in the commit.
Narrative:
(1) First, fix the MPEG-2 decoder so it does not try to overlap different
The formal title of the muxer according to the specification
is "RCWT (Raw Captions With Time)", so canonize this
in the long name of the codec and docs.
In the documentation section, point #2 was wrong: ccextractor
extracts the Closed Captions data and stores normalized bits
similarly to this
Raw Captions With Time (RCWT) is a format native to ccextractor, a commonly
used open source tool for processing 608/708 Closed Captions (CC) sources.
RCWT can be used to archive the original CC bitstream. The muxer was added
in January 2024. In this commit, add the demuxer.
One can now demux
In Closed Captions (US), the non-breaking space (0xA0) can be used to
align text horizontally from the left when used as a leading character.
However, CC decoder does not ignore it as a leading character
like it does an ordinary space, so a blank padding is rendered
on the black CC box. This is
Signed-off-by: Marth64
---
libavformat/sccdec.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/libavformat/sccdec.c b/libavformat/sccdec.c
index 5f2f95d80e..f6d5f29a0a 100644
--- a/libavformat/sccdec.c
+++ b/libavformat/sccdec.c
@@ -24,7 +24,6 @@
#include "internal.h"
#include
Anton Khirnov:
> Quoting Andreas Rheinhardt (2024-03-12 10:21:52)
>> Anton Khirnov:
>>> Quoting Andreas Rheinhardt (2024-03-12 09:56:46)
Anton Khirnov:
> Otherwise it might conflict with caller-defined identifiers.
>
> ff because it is not supposed to be used by external callers.
On date Tuesday 2024-03-12 01:00:00 -0500, Marth64 wrote:
> In MPEG-2 user data, there can be different types of Closed Captions
> formats embedded (A53, SCTE-20, or DVD). The current behavior of the
> CC extraction code in the MPEG-2 decoder is to not be aware of
> multiple formats if multiple
---
libavutil/aarch64/cpu.c | 25 +
1 file changed, 13 insertions(+), 12 deletions(-)
diff --git a/libavutil/aarch64/cpu.c b/libavutil/aarch64/cpu.c
index 7a05391343..196bdaf6b0 100644
--- a/libavutil/aarch64/cpu.c
+++ b/libavutil/aarch64/cpu.c
@@ -45,22 +45,23 @@ static
Otherwise it might conflict with caller-defined identifiers.
ff because it is not supposed to be used by external callers.
---
doc/developer.texi | 2 +-
doc/print_options.c| 4 ++--
libavcodec/avcodec.h | 4 ++--
libavcodec/avfft.h
On 12/03/2024 03:33, Wang, Fei W wrote:
> On Mon, 2024-03-11 at 21:57 -0300, James Almer wrote:
>> On 3/11/2024 9:49 PM, Michael Niedermayer wrote:
>>> On Mon, Mar 11, 2024 at 06:53:31PM +, Frank Plowman wrote:
VVC's subpictures feature is not yet implemented in the native
decoder.
Anton Khirnov:
> Quoting Andreas Rheinhardt (2024-03-12 09:56:46)
>> Anton Khirnov:
>>> Otherwise it might conflict with caller-defined identifiers.
>>>
>>> ff because it is not supposed to be used by external callers.
>>> ---
>>
>> This is public, so it should be av_attribute_deprecated.
>
> As
On date Monday 2024-03-11 13:41:43 +, hung kuishing wrote:
> > 在 2024年3月10日，21:55，Stefano Sabatini 写道：
> >
> > On date Saturday 2024-03-09 02:17:19 +, hung kuishing wrote:
> >>
> >> Signed-off-by: clarkh
> >> mailto:hungkuish...@outlook.com>>
> >> ---
> >> doc/examples/qsv_decode.c |
Use a more consistent and sensible prefix for the muxer structs and functions.
---
libavformat/fifo_test.c | 45 -
1 file changed, 22 insertions(+), 23 deletions(-)
diff --git a/libavformat/fifo_test.c b/libavformat/fifo_test.c
index 84b762db5f..903f4bc34b
---
doc/muxers.texi | 30 ++
1 file changed, 30 insertions(+)
diff --git a/doc/muxers.texi b/doc/muxers.texi
index 0aaef2b520..ccbb741992 100644
--- a/doc/muxers.texi
+++ b/doc/muxers.texi
@@ -1556,6 +1556,36 @@ ffmpeg -re -i ... -c:v libx264 -c:a aac -f fifo
---
libavformat/fifo_test.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/libavformat/fifo_test.c b/libavformat/fifo_test.c
index 3861c4aee4..84b762db5f 100644
--- a/libavformat/fifo_test.c
+++ b/libavformat/fifo_test.c
@@ -122,12 +122,12 @@ static void
Anton Khirnov:
> Otherwise it might conflict with caller-defined identifiers.
>
> ff because it is not supposed to be used by external callers.
> ---
This is public, so it should be av_attribute_deprecated.
For the same reason it is actually an API break to no longer provide the
un-prefixed
Allan Cady via ffmpeg-devel:
> To test the patch I've been working on, I wrote a small standalone C program,
> which I had saved in the project root. The file I'm patching is
> libavutil/timestamp.h. At first I had duplicated a bunch of definitions out
> of other include files (e.g. struct
Quoting Andreas Rheinhardt (2024-03-12 10:21:52)
> Anton Khirnov:
> > Quoting Andreas Rheinhardt (2024-03-12 09:56:46)
> >> Anton Khirnov:
> >>> Otherwise it might conflict with caller-defined identifiers.
> >>>
> >>> ff because it is not supposed to be used by external callers.
> >>> ---
> >>
>
On date Saturday 2024-03-09 12:27:52 -0600, Marth64 wrote:
> Signed-off-by: Marth64
> ---
> doc/demuxers.texi | 43 +-
> libavformat/dvdvideodec.c | 314 --
> 2 files changed, 339 insertions(+), 18 deletions(-)
Will push soon with the other
---
doc/metadata.texi | 1 +
doc/muxers.texi | 16
2 files changed, 17 insertions(+)
diff --git a/doc/metadata.texi b/doc/metadata.texi
index be91059a98..e081da7735 100644
--- a/doc/metadata.texi
+++ b/doc/metadata.texi
@@ -1,3 +1,4 @@
+@anchor{metadata}
@chapter Metadata
Quoting Andreas Rheinhardt (2024-03-12 09:56:46)
> Anton Khirnov:
> > Otherwise it might conflict with caller-defined identifiers.
> >
> > ff because it is not supposed to be used by external callers.
> > ---
>
> This is public, so it should be av_attribute_deprecated.
As the commit message
On date Sunday 2024-03-10 16:10:15 +0100, Stefano Sabatini wrote:
> On date Sunday 2024-03-10 14:20:12 +, ffmpeg-devel Mailing List wrote:
> > Great, thank you very much!
> > I'm attaching the (hopefully) final version of the patch.
> >
>
> > MD studio was a piece of software created by a
On date Monday 2024-03-11 11:32:29 -0500, Marth64 wrote:
> LGTM from readability perspective. Nice catch on the command missing slash.
Thanks, applied.
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
On 2024-03-12 04:25 pm, Stefano Sabatini wrote:
---
doc/metadata.texi | 1 +
doc/muxers.texi | 16
2 files changed, 17 insertions(+)
diff --git a/doc/metadata.texi b/doc/metadata.texi
index be91059a98..e081da7735 100644
--- a/doc/metadata.texi
+++ b/doc/metadata.texi
Thank you Stefano Sabatini and Andreas Rheinhardt - you guys have the patience
of saints.
On Tuesday, March 12th, 2024 at 11:27 AM, Stefano Sabatini
wrote:
> On date Sunday 2024-03-10 16:10:15 +0100, Stefano Sabatini wrote:
>
> > On date Sunday 2024-03-10 14:20:12 +, ffmpeg-devel Mailing
On 3/8/24 4:34 AM, Rajiv Harlalka wrote:
Check for zeros equal to the total samples early, because in case the
check is true we would already be leaving the first few frames out.
Signed-off-by: Rajiv Harlalka
#10692
---
libavfilter/af_atempo.c | 13 ++---
1 file changed, 6
On date Monday 2024-03-11 11:31:15 -0500, Marth64 wrote:
> LGTM. Options before are the same as after change.
Applied.
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link
Marth64:
> Raw Captions With Time (RCWT) is a format native to ccextractor, a commonly
> used open source tool for processing 608/708 Closed Captions (CC) sources.
> RCWT can be used to archive the original CC bitstream. The muxer was added
> in January 2024. In this commit, add the demuxer.
>
>
On Mon, Mar 11, 2024 at 9:58 AM wrote:
> From: Fei Wang
>
> The NoOutputBeforeRecoveryFlag of an IDR frame should be set to 1 as
> spec says in 8.1.1.
>
Pushed.
Thank you, Fei.
>
> Signed-off-by: Fei Wang
> ---
> libavcodec/vvc/vvc_ps.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
This simplifies the code for checking the output, and can print
the failing output (including a map of matching/mismatching
elements) if checkasm is run with the -v/--verbose option.
---
tests/checkasm/hevc_pel.c | 71 ++-
1 file changed, 41 insertions(+), 30
---
tests/checkasm/hevc_pel.c | 134 --
1 file changed, 98 insertions(+), 36 deletions(-)
diff --git a/tests/checkasm/hevc_pel.c b/tests/checkasm/hevc_pel.c
index 065da87622..73a4619978 100644
--- a/tests/checkasm/hevc_pel.c
+++ b/tests/checkasm/hevc_pel.c
@@
On date Tuesday 2024-03-12 01:00:03 -0500, Marth64 wrote:
> The formal title of the muxer according to the specification
> is "RCWT (Raw Captions With Time)", so canonize this
> in the long name of the codec and docs.
>
> In the documentation section, point #2 was wrong: ccextractor
> extracts
On date Tuesday 2024-03-12 01:00:05 -0500, Marth64 wrote:
> Signed-off-by: Marth64
> ---
> libavformat/sccdec.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/libavformat/sccdec.c b/libavformat/sccdec.c
> index 5f2f95d80e..f6d5f29a0a 100644
> --- a/libavformat/sccdec.c
> +++
Signed-off-by: Nicolas Gaullier
---
doc/fate.texi | 8
1 file changed, 8 insertions(+)
diff --git a/doc/fate.texi b/doc/fate.texi
index 2fa8c34c2d..17644ce65a 100644
--- a/doc/fate.texi
+++ b/doc/fate.texi
@@ -79,6 +79,14 @@ Do not put a '~' character in the samples path to indicate a
Stefano Sabatini:
> ---
> doc/muxers.texi | 30 ++
> 1 file changed, 30 insertions(+)
>
> diff --git a/doc/muxers.texi b/doc/muxers.texi
> index 0aaef2b520..ccbb741992 100644
> --- a/doc/muxers.texi
> +++ b/doc/muxers.texi
> @@ -1556,6 +1556,36 @@ ffmpeg -re -i ...
The first 32 elements of each row were correct, while the
last 16 were scrambled.
This hasn't been noticed, because the checkasm test erroneously
only checked half of the output (for 8 bit functions), and
apparently none of the samples as part of "fate-hevc" seem to
trigger this specific
Previously it only checked half the output in 8 bit per pixel mode,
as the output actually is 16 bit elements here.
---
tests/checkasm/hevc_pel.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/tests/checkasm/hevc_pel.c b/tests/checkasm/hevc_pel.c
index
On date Tuesday 2024-03-12 01:00:01 -0500, Marth64 wrote:
> Closed Captions decoder prints multiple \pos ASS tags per cue,
> and preceding the \pos tag is a fixed \an7 that fixes rendering
> position from the top left corner and enforces justification.
>
> Printing multiple \an and \pos tags in
Stefano Sabatini:
> On date Tuesday 2024-03-12 01:00:00 -0500, Marth64 wrote:
>> In MPEG-2 user data, there can be different types of Closed Captions
>> formats embedded (A53, SCTE-20, or DVD). The current behavior of the
>> CC extraction code in the MPEG-2 decoder is to not be aware of
>>
Regression since 0b98f28c46a7e3e914c51debc461
Signed-off-by: Nicolas Gaullier
---
tests/fate-run.sh | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tests/fate-run.sh b/tests/fate-run.sh
index 0fead78c58..9863e4f2d9 100755
--- a/tests/fate-run.sh
+++ b/tests/fate-run.sh
@@
On Tue, Mar 12, 2024 at 5:09 PM Frank Plowman wrote:
> On 12/03/2024 03:33, Wang, Fei W wrote:
> > On Mon, 2024-03-11 at 21:57 -0300, James Almer wrote:
> >> On 3/11/2024 9:49 PM, Michael Niedermayer wrote:
> >>> On Mon, Mar 11, 2024 at 06:53:31PM +, Frank Plowman wrote:
> VVC's
On Tue, Mar 12, 2024, 02:52 Rajiv Harlalka
wrote:
> On 3/8/24 4:34 AM, Rajiv Harlalka wrote:
> > Check for zeros equal to the total samples early, because in case the
> > check is true we would already be leaving the first few frames out.
> >
> > Signed-off-by: Rajiv Harlalka
> > #10692
> > ---
On date Tuesday 2024-03-12 01:00:02 -0500, Marth64 wrote:
> In Closed Captions (US), the non-breaking space (0xA0) can be used to
> align text horizontally from the left when used as a leading character.
> However, CC decoder does not ignore it as a leading character
> like it does an ordinary
In MPEG-2 user data, there can be different types of Closed Captions
formats embedded (A53, SCTE-20, or DVD). The current behavior of the
CC extraction code in the MPEG-2 decoder is to not be aware of
multiple formats if multiple exist, therefore allowing one format
to overwrite the other during
v2 on the way
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".
From: Zhao Zhili
---
v4: Fix missing SEI in set_avcc_extradata
v3: Remove unnecessary inclusion
configure| 2 +-
libavcodec/libx264.c | 153 ---
2 files changed, 130 insertions(+), 25 deletions(-)
diff --git a/configure b/configure
index
Will address, thanks for the review.
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".
On 3/12/2024 12:00 PM, Andreas Rheinhardt wrote:
Zhao Zhili:
From: Zhao Zhili
---
v4: Fix missing SEI in set_avcc_extradata
v3: Remove unnecessary inclusion
configure| 2 +-
libavcodec/libx264.c | 153 ---
2 files changed, 130
James Almer:
> On 3/12/2024 12:00 PM, Andreas Rheinhardt wrote:
>> Zhao Zhili:
>>> From: Zhao Zhili
>>>
>>> ---
>>> v4: Fix missing SEI in set_avcc_extradata
>>> v3: Remove unnecessary inclusion
>>>
>>> configure | 2 +-
>>> libavcodec/libx264.c | 153
Signed-off-by: Marth64
---
libavformat/dvdvideodec.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/libavformat/dvdvideodec.c b/libavformat/dvdvideodec.c
index a182f95097..19efc068cb 100644
--- a/libavformat/dvdvideodec.c
+++ b/libavformat/dvdvideodec.c
@@ -392,7 +392,7
Signed-off-by: Marth64
---
libavformat/dvdvideodec.c | 15 ---
1 file changed, 8 insertions(+), 7 deletions(-)
diff --git a/libavformat/dvdvideodec.c b/libavformat/dvdvideodec.c
index a182f95097..761ac97ec6 100644
--- a/libavformat/dvdvideodec.c
+++ b/libavformat/dvdvideodec.c
@@
Zhao Zhili:
> From: Zhao Zhili
>
> ---
> v4: Fix missing SEI in set_avcc_extradata
> v3: Remove unnecessary inclusion
>
> configure| 2 +-
> libavcodec/libx264.c | 153 ---
> 2 files changed, 130 insertions(+), 25 deletions(-)
>
> diff
Marth64:
> Signed-off-by: Marth64
> ---
> libavformat/dvdvideodec.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/libavformat/dvdvideodec.c b/libavformat/dvdvideodec.c
> index a182f95097..0ae2110cd2 100644
> --- a/libavformat/dvdvideodec.c
> +++
Marth64:
> Signed-off-by: Marth64
> ---
> libavformat/dvdvideodec.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/libavformat/dvdvideodec.c b/libavformat/dvdvideodec.c
> index a182f95097..19efc068cb 100644
> --- a/libavformat/dvdvideodec.c
> +++
Fix on the way with PRId64
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".
No need to use the generic ff_tget() when we know the type.
Signed-off-by: Andreas Rheinhardt
---
libavcodec/tiff.c | 36 ++--
1 file changed, 18 insertions(+), 18 deletions(-)
diff --git a/libavcodec/tiff.c b/libavcodec/tiff.c
index 8f278bfd12..3238b208d8
Signed-off-by: Marth64
---
libavformat/dvdvideodec.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/libavformat/dvdvideodec.c b/libavformat/dvdvideodec.c
index a182f95097..0ae2110cd2 100644
--- a/libavformat/dvdvideodec.c
+++ b/libavformat/dvdvideodec.c
@@ -423,7 +423,7 @@
Mar 12, 2024, 05:16 by ffm...@gyani.pro:
> Fixes #10900
> ---
> configure | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/configure b/configure
> index 05f8283af9..e0b5bcf589 100755
> --- a/configure
> +++ b/configure
> @@ -3076,6 +3076,7 @@ nvdec_deps="ffnvcodec"
>
On Tue, 12 Mar 2024, Nicolas Gaullier wrote:
Regression since 0b98f28c46a7e3e914c51debc461
Signed-off-by: Nicolas Gaullier
---
tests/fate-run.sh | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tests/fate-run.sh b/tests/fate-run.sh
index 0fead78c58..9863e4f2d9 100755
---
On 3/12/2024 7:57 PM, Andreas Rheinhardt wrote:
Affects many FATE-tests, see
http://fate.ffmpeg.org/report.cgi?time=20240312011016=ppc-linux-gcc-13.2-ubsan-altivec-qemu
Signed-off-by: Andreas Rheinhardt
---
libavformat/avidec.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff
On Tue, Mar 12, 2024 at 8:22 PM Pavel Koshevoy wrote:
>
>
> On Tue, Mar 12, 2024 at 2:52 AM Rajiv Harlalka
> wrote:
>
>> On 3/8/24 4:34 AM, Rajiv Harlalka wrote:
>> > Check for zeros equal to the total samples early, because in case the
>> > check is true we would already be leaving the first
Stefano Sabatini:
> ---
> doc/muxers.texi | 11 +++
> 1 file changed, 11 insertions(+)
>
> diff --git a/doc/muxers.texi b/doc/muxers.texi
> index de4b9b01f5..64d9221198 100644
> --- a/doc/muxers.texi
> +++ b/doc/muxers.texi
> @@ -1612,6 +1612,17 @@ This image format is used to store
Andreas Rheinhardt:
> This is easily possible with an X macro.
> Using an enum for the offsets also allows to remove
> two arrays which are not really needed and will typically
> be optimized away by the compiler: The first just exists
> to count the number of syntax elements*, the second one
>
On Mon, 11 Mar 2024, Kristoffer Brånemyr via ffmpeg-devel wrote:
Den måndag 26 februari 2024 kl. 19:36:58 CET, Kristoffer Brånemyr via ffmpeg-devel skrev:
Hi,
Here is a short patch to skip more parts of the header for the WebVTT subtitle
format. Without this the parser seems to stop
On Tue, Mar 12, 2024 at 5:20 PM Marth64 wrote:
> I have not interacted with this user and I am just a mediocre contributor.
> But from my experience running forums and IRC networks in the past,
> this always ends in one process...
>
>1. toxic user comes along
>2. upsets people
Exposed by
http://fate.ffmpeg.org/report.cgi?time=20240312011016=ppc-linux-gcc-13.2-ubsan-altivec-qemu
Signed-off-by: Andreas Rheinhardt
---
I only tested that it compiles (and the size of .text even
goes down a bit, presumably because of the elimination of
int_dst_stride (which basically means
Marth64:
> I found this code block when looking at this warning thrown in my
> compiler (gcc 11.4.0 x86_64-linux-gnu):
>
> ```
> In function ‘print_buildconf’,
> inlined from ‘show_buildconf’ at fftools/opt_common.c:260:5:
> fftools/opt_common.c:226:49: warning: writing 1 byte into a region
James Almer:
> On 3/12/2024 7:57 PM, Andreas Rheinhardt wrote:
>> Affects many FATE-tests, see
>> http://fate.ffmpeg.org/report.cgi?time=20240312011016=ppc-linux-gcc-13.2-ubsan-altivec-qemu
>>
>> Signed-off-by: Andreas Rheinhardt
>> ---
>> libavformat/avidec.c | 2 +-
>> 1 file changed, 1
It is accessed via AV_RN64() in ff_simple_idct_put_int32_10bit().
Should fix the UBSan failures in the mpeg4-simple-studio-profile
test here:
https://fate.ffmpeg.org/report.cgi?time=20240312011016=ppc-linux-gcc-13.2-ubsan-altivec-qemu
Signed-off-by: Andreas Rheinhardt
---
Hi
On Tue, Mar 12, 2024 at 01:14:45PM -0400, Ronald S. Bultje wrote:
> Hello,
>
> On Sat, Mar 9, 2024 at 8:25 PM Michael Niedermayer
> wrote:
>
> > Some members of the CC want to indefinitely ban Balling
> > from trac. And as our doc/community.texi says:
> > "Indefinite bans from the community
On Tue, Mar 12, 2024 at 2:52 AM Rajiv Harlalka
wrote:
> On 3/8/24 4:34 AM, Rajiv Harlalka wrote:
> > Check for zeros equal to the total samples early, because in case the
> > check is true we would already be leaving the first few frames out.
> >
> > Signed-off-by: Rajiv Harlalka
> > #10692
> >
Feb 29, 2024, 06:35 by tong1.wu-at-intel@ffmpeg.org:
> From: Tong Wu
>
> Since VAAPI and future D3D12VA implementation may share the same dpb
> logic and some other functions. A base layer encode context is introduced
> as vaapi context's base and extract the related funtions to a common
>
On Fri, 8 Mar 2024, Marton Balint wrote:
- Remove the 1024 cap on the number of samples, for high sample rate audio it
was suboptimal, calculate the low neighbour power of two for the number of
samples (audio blocks) instead.
- Make the function work correctly for non-pcm codecs by using
> The code block changes str and str is later accessed (via splitconf).
Sorry, for the lack of awareness, but I am confused how.
strstr() shouldn't modify the string right?
The only change I see is in the unused remove_tilde[]
Thank you, for taking a look and explaining.
On 3/12/2024 8:01 PM, Andreas Rheinhardt wrote:
James Almer:
On 3/12/2024 7:57 PM, Andreas Rheinhardt wrote:
Affects many FATE-tests, see
http://fate.ffmpeg.org/report.cgi?time=20240312011016=ppc-linux-gcc-13.2-ubsan-altivec-qemu
Signed-off-by: Andreas Rheinhardt
---
libavformat/avidec.c
On 6/24/2023 5:13 PM, Reimar Döffinger wrote:
Hi!
On 24 Jun 2023, at 21:14, Andreas Rheinhardt
wrote:
Michael Niedermayer:
Fixes: out of array access
Fixes: crash-0d640731c7da52415670eb47a2af701cbe2e1a3b
Found-by: Catena cyber
Signed-off-by: Michael Niedermayer
---
libavcodec/parser.c |
I get it now. Disregard patch. Thanks.
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".
h_subpel_filters_inner[i] and h_subpel_filters_outer[i / 2]
belong together and the former allows the range 0..6,
so the latter needs to support 0..3. But it has only three
elements. Add another one.
The value for the last element has been guesstimated
from subpel_filters in libavcodec/vp8dsp.c.
On 2024-03-12 09:15 pm, Lynne wrote:
Mar 12, 2024, 05:16 by ffm...@gyani.pro:
Fixes #10900
---
configure | 1 +
1 file changed, 1 insertion(+)
diff --git a/configure b/configure
index 05f8283af9..e0b5bcf589 100755
--- a/configure
+++ b/configure
@@ -3076,6 +3076,7 @@
On Sat, Jun 24, 2023 at 10:13:48PM +0200, Reimar Döffinger wrote:
> Hi!
>
> > On 24 Jun 2023, at 21:14, Andreas Rheinhardt
> > wrote:
> >
> > Michael Niedermayer:
> >> Fixes: out of array access
> >> Fixes: crash-0d640731c7da52415670eb47a2af701cbe2e1a3b
> >>
> >> Found-by: Catena cyber
> >>
I found this code block when looking at this warning thrown in my
compiler (gcc 11.4.0 x86_64-linux-gnu):
```
In function ‘print_buildconf’,
inlined from ‘show_buildconf’ at fftools/opt_common.c:260:5:
fftools/opt_common.c:226:49: warning: writing 1 byte into a region of size 0
Marth64:
>> The code block changes str and str is later accessed (via splitconf).
> Sorry, for the lack of awareness, but I am confused how.
> strstr() shouldn't modify the string right?
> The only change I see is in the unused remove_tilde[]
>
No, but strstr() returns a pointer pointing into
Affects many FATE-tests, see
http://fate.ffmpeg.org/report.cgi?time=20240312011016=ppc-linux-gcc-13.2-ubsan-altivec-qemu
Signed-off-by: Andreas Rheinhardt
---
libavformat/avidec.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/libavformat/avidec.c b/libavformat/avidec.c
On 3/11/2024 5:58 PM, Jan Ekström wrote:
This allows configuring an encoder by using AVFrameSideData.
---
libavcodec/avcodec.h | 8
libavcodec/options.c | 2 ++
2 files changed, 10 insertions(+)
diff --git a/libavcodec/avcodec.h b/libavcodec/avcodec.h
index 21fc74707f..432a3fd153
The documentation correctly states that the rdiv is a multiplier but
incorrectly states the default behavior is to multiply by the sum of all matrix
elements - it multiplies by 1/sum.
This changes the documentation to match the code.
---
doc/filters.texi | 2 +-
1 file changed, 1 insertion(+),
HAVE_FAST_UNALIGNED being true does not imply that
one can simply read from any pointer via *(long*).
It is undefined behaviour in case the pointer is not
sufficiently aligned; and even if it is, it is (likely)
a violation of the effective-type rules. Fix both
of these by using the appropriate
On Tue, 12 Mar 2024, Allan Cady via ffmpeg-devel wrote:
On Monday, March 11, 2024 at 12:11:45 PM PDT, Marton Balint wrote:
On Mon, 11 Mar 2024, Andreas Rheinhardt wrote:
Allan Cady via ffmpeg-devel:
From: "Allan Cady"
I propose changing the format to "%.6f", which will
give microsecond
I have not interacted with this user and I am just a mediocre contributor.
But from my experience running forums and IRC networks in the past,
this always ends in one process...
1. toxic user comes along
2. upsets people repeatedly, which also wastes time
3. admins ponder ban, which
On 3/11/2024 5:58 PM, Jan Ekström wrote:
---
libavutil/frame.c | 20 +++-
libavutil/frame.h | 14 ++
2 files changed, 29 insertions(+), 5 deletions(-)
diff --git a/libavutil/frame.c b/libavutil/frame.c
index 30db83a5e5..47ecd964b8 100644
--- a/libavutil/frame.c
On Mon, 11 Mar 2024 22:32:01 + Mark Thompson wrote:
> This is not correct. Along with scalable cases, the multiple param sets are
> to support applying film grain at the display resolution after scaling,
> providing a better result than upscaling the grain applied at the decode
>
OptionDef.u is only an offset (i.e. its off member) iff OPT_FLAG_OFFSET
is true. Otherwise, the pointer arithmetic can be undefined behaviour.
UBSan warns about this (on 32bit arches):
src/fftools/ffmpeg_opt.c:102:15: runtime error: pointer index expression with
base 0xffa4db10 overflowed to
On Mon, Mar 11, 2024 at 05:40:25PM -0400, Leo Izen wrote:
>
>
> On 3/9/24 20:25, Michael Niedermayer wrote:
> > Hi everyone
> >
> > Some members of the CC want to indefinitely ban Balling
> > from trac. And as our doc/community.texi says:
> > "Indefinite bans from the community must be
From: Rajiv Harlalka
Check for zeros equal to the total samples early, because in
that case we would already be leaving the first few frames out.
Fixes trac ticket #10692
---
libavfilter/af_atempo.c | 18 +-
1 file changed, 9 insertions(+), 9 deletions(-)
diff --git
Kindly ping.
Hi Mark, do you have more comments on this patch set?
>Subject: [FFmpeg-devel][PATCH v6 8/9] avcodec: add D3D12VA hardware HEVC
>encoder
>
>From: Tong Wu
>
>This implementation is based on D3D12 Video Encoding Spec:
On Tue, Mar 12, 2024 at 9:01 PM Pavel Koshevoy wrote:
> From: Rajiv Harlalka
>
> Check for zeros equal to the total samples early, because in
> that case we would already be leaving the first few frames out.
>
> Fixes trac ticket #10692
> ---
> libavfilter/af_atempo.c | 18 +-
>
On Tue, 5 Mar 2024, Christian Lee Seibold wrote:
The 's', ';', and '<' itemtypes are used for audio and video by
Gophernicus and Gopher+.
Signed-off-by: Christian Lee Seibold
---
libavformat/gopher.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/libavformat/gopher.c
On date Tuesday 2024-03-12 15:49:45 +0100, Andreas Rheinhardt wrote:
> No need to use the generic ff_tget() when we know the type.
>
> Signed-off-by: Andreas Rheinhardt
> ---
> libavcodec/tiff.c | 36 ++--
> 1 file changed, 18 insertions(+), 18 deletions(-)
On date Tuesday 2024-03-12 11:14:09 -0500, Marth64 wrote:
> Signed-off-by: Marth64
> ---
> libavformat/dvdvideodec.c | 15 ---
> 1 file changed, 8 insertions(+), 7 deletions(-)
LGTM, thanks (will apply soon if there are no further comments).
1 - 100 of 124 matches
Mail list logo
