Re: [FFmpeg-devel] 7.0 Name

2024-04-03 Thread Niklas Haas
On Mon, 01 Apr 2024 19:42:29 -0400 Sean McGovern wrote: > Hi, > > On Mon, Apr 1, 2024, 18:00 Lynne wrote: > > > Apr 1, 2024, 22:01 by mich...@niedermayer.cc: > > > > > Hi all > > > > > > I think we didnt decide on a name for 7.0 yet > > > > > > Previously suggested names: > > > Darwin, > > >

Re: [FFmpeg-devel] [PATCH] avcodec/vvcdec: move vvcdec.{c, h} to the top directory

2024-04-03 Thread Anton Khirnov
Quoting James Almer (2024-04-03 16:46:14) > On 4/3/2024 5:35 AM, Anton Khirnov wrote: > > Quoting James Almer (2024-04-02 21:28:28) > >> On 4/2/2024 4:25 PM, Andreas Rheinhardt wrote: > >>> James Almer: > As it's the main file declaring the AVCodec. > >>> > >>> And why is that supposed to be

[FFmpeg-devel] [PATCH 7/7 v6] avcodec/hevcdec: export global side data in AVCodecContext

2024-04-03 Thread James Almer
Signed-off-by: James Almer --- libavcodec/avcodec.h | 2 +- libavcodec/h2645_sei.c | 215 + libavcodec/h2645_sei.h | 2 + libavcodec/hevcdec.c | 4 + libavcodec/pthread_frame.c | 14 ++- 5 files changed, 143 insertions(+), 94

Re: [FFmpeg-devel] [PATCH] configure: Separate subsystem for Immersive Audio Model

2024-04-03 Thread James Almer
On 4/3/2024 1:01 AM, Eugene Zemtsov via ffmpeg-devel wrote: From: Eugene Zemtsov This change allows users to link ffmpeg as a library without support for Immersive Audio Model by specifying --disable-iamf. It helps to save on binary size in cases where it's important. Signed-off-by: Eugene

Re: [FFmpeg-devel] [PATCH] avcodec/vvcdec: move vvcdec.{c, h} to the top directory

2024-04-03 Thread James Almer
On 4/3/2024 5:35 AM, Anton Khirnov wrote: Quoting James Almer (2024-04-02 21:28:28) On 4/2/2024 4:25 PM, Andreas Rheinhardt wrote: James Almer: As it's the main file declaring the AVCodec. And why is that supposed to be an advantage? It's not, it's a cosmetic change. Makes it easier to

Re: [FFmpeg-devel] [PATCH 01/10] avcodec/libvpxenc: Avoid unused-variable warning if VP9 enc is disabled

2024-04-03 Thread Andreas Rheinhardt
Anton Khirnov: > Quoting Andreas Rheinhardt (2024-03-31 07:30:26) >> Signed-off-by: Andreas Rheinhardt >> --- >> libavcodec/libvpxenc.c | 7 --- >> 1 file changed, 4 insertions(+), 3 deletions(-) >> >> diff --git a/libavcodec/libvpxenc.c b/libavcodec/libvpxenc.c >> index

[FFmpeg-devel] [GASPP PATCH] Implicitly start out in the text section for armasm

2024-04-03 Thread Martin Storsjö
This fixes assembling files starting with bare symbol declarations, without explicitly switching to .text first. --- gas-preprocessor.pl | 3 +++ 1 file changed, 3 insertions(+) diff --git a/gas-preprocessor.pl b/gas-preprocessor.pl index 2880858..b66181a 100755 --- a/gas-preprocessor.pl +++

Re: [FFmpeg-devel] [PATCH] lavc/vvc: Only read split_cu_flag if a split is allowed

2024-04-03 Thread Nuo Mi
On Wed, Apr 3, 2024 at 5:59 PM Frank Plowman wrote: > On 02/04/2024 22:48, Frank Plowman wrote: > > Add a check to ensure some split is possible before reading the > > split_cu_flag. This is present in the spec, in VVCv3 section 7.3.11.4. > > Its omission could lead to infinite loops and

Re: [FFmpeg-devel] [PATCH] fix typo(1),style(1),nit(4) issue

2024-04-03 Thread Hendrik Leppkes
On Wed, Apr 3, 2024 at 10:50 AM 정지우 | Eugene wrote: > > - typo(1) : Line 242 : RFIC7616 ->RFC7616 > - style(1) : make_digest_auth() , make_digest_auth_sha() : A1hash-> a1_hash > and A2hash -> a2_hash > - nit(3) : httpauth.c: Line 245,265,389: > - nit(1) : httpauth.h: Line 85 > > Signed-off-by:

Re: [FFmpeg-devel] [PATCH 7/7 v5] avcodec/hevcdec: export global side data in AVCodecContext

2024-04-03 Thread James Almer
On 4/3/2024 5:32 AM, Anton Khirnov wrote: Quoting James Almer (2024-03-28 17:52:50) diff --git a/libavcodec/pthread_frame.c b/libavcodec/pthread_frame.c index fd356bd190..a693e12670 100644 --- a/libavcodec/pthread_frame.c +++ b/libavcodec/pthread_frame.c @@ -334,6 +334,15 @@

[FFmpeg-devel] [PATCH] fix typo(1),style(1),nit(4) issue

2024-04-03 Thread 정지우 | Eugene
- typo(1) : Line 242 : RFIC7616 ->RFC7616 - style(1) : make_digest_auth() , make_digest_auth_sha() : A1hash-> a1_hash and A2hash -> a2_hash - nit(3) : httpauth.c: Line 245,265,389: - nit(1) : httpauth.h: Line 85 Signed-off-by: Eugene-bitsensing --- libavformat/httpauth.c | 34

[FFmpeg-devel] [PATCH] avformat/httpauth: add SHA-256 Digest Authorization (Combined)

2024-04-03 Thread 정지우 | Eugene
- add SHA-256 Digest Authorization for RFC7616 using avutil/hash.h - make_digest_auth_sha() : A1hash-> a1_hash and A2hash -> a2_hash - combine with lint fix patch (Please ignore previous patch requests that were requested by mistake): [FFmpeg-devel] [PATCH] fix typo(1),style(1),nit(4) issue

Re: [FFmpeg-devel] Request: Memory cache to avoid write lags to storage.

2024-04-03 Thread Tomas Härdin
tis 2024-04-02 klockan 16:49 +0900 skrev texrayk-sup--- via ffmpeg- devel: > This feature caches data in memory that is scheduled to be written to > storage. This list isn't for feature requests. > When data writing cannot keep up due to storage lag or other reasons, > The data is cached in

Re: [FFmpeg-devel] [PATCH 01/10] avcodec/libvpxenc: Avoid unused-variable warning if VP9 enc is disabled

2024-04-03 Thread Anton Khirnov
Quoting Andreas Rheinhardt (2024-03-31 07:30:26) > Signed-off-by: Andreas Rheinhardt > --- > libavcodec/libvpxenc.c | 7 --- > 1 file changed, 4 insertions(+), 3 deletions(-) > > diff --git a/libavcodec/libvpxenc.c b/libavcodec/libvpxenc.c > index 635cdf7a0e..bcbdc4981e 100644 > ---

Re: [FFmpeg-devel] [PATCH] avcodec/hevc_ps: fix the problem of memcmp losing effectiveness

2024-04-03 Thread Anton Khirnov
Quoting Andreas Rheinhardt (2024-03-29 16:58:48) > This does not change that I consider it crazy to remove the parameter > sets referencing a parameter set that is removed. What's crazy about it? A PPS is parsed for a given SPS. If the SPS is gone, then the PPS must be either removed or re-parsed

Re: [FFmpeg-devel] [PATCH 7/7 v5] avcodec/hevcdec: export global side data in AVCodecContext

2024-04-03 Thread Anton Khirnov
Quoting James Almer (2024-03-28 17:52:50) > diff --git a/libavcodec/pthread_frame.c b/libavcodec/pthread_frame.c > index fd356bd190..a693e12670 100644 > --- a/libavcodec/pthread_frame.c > +++ b/libavcodec/pthread_frame.c > @@ -334,6 +334,15 @@ FF_ENABLE_DEPRECATION_WARNINGS > if (for_user) {

[FFmpeg-devel] [PATCH v3 1/5] avcodec/ac3: Implement float_to_fixed24 for aarch64 NEON

2024-04-03 Thread Geoff Hill
Signed-off-by: Geoff Hill --- libavcodec/aarch64/Makefile | 2 ++ libavcodec/aarch64/ac3dsp_init_aarch64.c | 36 libavcodec/aarch64/ac3dsp_neon.S | 35 +++ libavcodec/ac3dsp.c | 4 ++- libavcodec/ac3dsp.h

[FFmpeg-devel] [PATCH v3 4/5] avcodec/ac3: Implement sum_square_butterfly_int32 for aarch64 NEON

2024-04-03 Thread Geoff Hill
Signed-off-by: Geoff Hill --- libavcodec/aarch64/ac3dsp_init_aarch64.c | 5 + libavcodec/aarch64/ac3dsp_neon.S | 24 + tests/checkasm/ac3dsp.c | 27 3 files changed, 56 insertions(+) diff --git

[FFmpeg-devel] [PATCH v3 3/5] avcodec/ac3: Implement ac3_extract_exponents for aarch64 NEON

2024-04-03 Thread Geoff Hill
Signed-off-by: Geoff Hill --- libavcodec/aarch64/ac3dsp_init_aarch64.c | 2 ++ libavcodec/aarch64/ac3dsp_neon.S | 15 ++ tests/checkasm/ac3dsp.c | 36 3 files changed, 53 insertions(+) diff --git

[FFmpeg-devel] [PATCH v3 5/5] avcodec/ac3: Implement sum_square_butterfly_float for aarch64 NEON

2024-04-03 Thread Geoff Hill
Signed-off-by: Geoff Hill --- libavcodec/aarch64/ac3dsp_init_aarch64.c | 5 libavcodec/aarch64/ac3dsp_neon.S | 35 tests/checkasm/ac3dsp.c | 26 ++ 3 files changed, 66 insertions(+) diff --git

[FFmpeg-devel] [PATCH v3 2/5] avcodec/ac3: Implement ac3_exponent_min for aarch64 NEON

2024-04-03 Thread Geoff Hill
Signed-off-by: Geoff Hill --- libavcodec/aarch64/ac3dsp_init_aarch64.c | 2 ++ libavcodec/aarch64/ac3dsp_neon.S | 16 + tests/checkasm/ac3dsp.c | 41 3 files changed, 59 insertions(+) diff --git

Re: [FFmpeg-devel] [PATCH] doc/developer: (security) researchers should be credited

2024-04-03 Thread Tomas Härdin
ons 2024-04-03 klockan 02:13 +0200 skrev Michael Niedermayer: > Signed-off-by: Michael Niedermayer > --- >  doc/developer.texi | 4 >  1 file changed, 4 insertions(+) > > diff --git a/doc/developer.texi b/doc/developer.texi > index c86bb5820cc..63835dfa06c 100644 > --- a/doc/developer.texi >

Re: [FFmpeg-devel] [PATCH] avformat/mxfdec: Check that edit_unit_byte_count is not negative

2024-04-03 Thread Tomas Härdin
mån 2024-04-01 klockan 18:22 +0200 skrev Marton Balint: > > > On Mon, 1 Apr 2024, Michael Niedermayer wrote: > > > Signed-off-by: Michael Niedermayer > > --- > > libavformat/mxfdec.c | 6 +- > > 1 file changed, 5 insertions(+), 1 deletion(-) > > > > diff --git a/libavformat/mxfdec.c

Re: [FFmpeg-devel] [PATCH] avcodec/vvcdec: move vvcdec.{c, h} to the top directory

2024-04-03 Thread Anton Khirnov
Quoting James Almer (2024-04-02 21:28:28) > On 4/2/2024 4:25 PM, Andreas Rheinhardt wrote: > > James Almer: > >> As it's the main file declaring the AVCodec. > > > > And why is that supposed to be an advantage? > > It's not, it's a cosmetic change. Makes it easier to find at least one > file

Re: [FFmpeg-devel] [PATCH] lavc/vvc: Only read split_cu_flag if a split is allowed

2024-04-03 Thread Frank Plowman
On 02/04/2024 22:48, Frank Plowman wrote: Add a check to ensure some split is possible before reading the split_cu_flag. This is present in the spec, in VVCv3 section 7.3.11.4. Its omission could lead to infinite loops and ultimately crashing due to stack overflow. ---

[FFmpeg-devel] [PATCH 2/4] lavc: Remove libva 1.x support

2024-04-03 Thread Mark Thompson
libva 2.0 was released in 2017 and the 2.x versions are included in all supported distributions nowadays. --- libavcodec/vaapi_decode.c | 10 ++ libavcodec/vaapi_encode.c | 31 +++ libavcodec/vaapi_encode_h264.c | 18 -- 3 files

[FFmpeg-devel] [PATCH 1/4] lavu: Remove libva 1.x support

2024-04-03 Thread Mark Thompson
libva 2.0 was released in 2017 and the 2.x versions are included in all supported distributions nowadays. --- libavutil/hwcontext_vaapi.c | 4 1 file changed, 4 deletions(-) diff --git a/libavutil/hwcontext_vaapi.c b/libavutil/hwcontext_vaapi.c index 56d03aa4cd..bc82ab31e6 100644 ---

Re: [FFmpeg-devel] [PATCH v4 0/4] Fix some active sequences in subtitles

2024-04-03 Thread Oneric
On Mon, 19 Feb 2024 Oneric wrote: > avcodec/webvttdec: honour bidi marks > avcodec/{ass,webvttdec}: fix handling of backslashes > avcodec/{ass,webvttdec}: more portable curly brace escapes > avocdec/ass: simplify linebreaks > > libavcodec/ass.c | 47

Re: [FFmpeg-devel] [PATCH 2/2] configure: Only enable iamfdec, iamfenc when needed

2024-04-03 Thread James Almer
On 4/3/2024 4:46 PM, Andreas Rheinhardt wrote: Since 591e27d1e7b21b66f81c53f381356c5e6f1f0451 they would always be compiled even when nothing uses them; for shared builds the default linker behaviour is to include them even when not needed. Signed-off-by: Andreas Rheinhardt --- configure | 9

[FFmpeg-devel] [PATCH] Update the Changelog for 7.0

2024-04-03 Thread Jean-Baptiste Kempf
As attached. -- Jean-Baptiste Kempf - President +33 672 704 734 https://jbkempf.com/From bc5a37d34d9a634388e425d894aa1219a32d8394 Mon Sep 17 00:00:00 2001 From: Jean-Baptiste Kempf Date: Wed, 3 Apr 2024 23:12:54 +0200 Subject: [PATCH] Update the Changelog for 7.0 --- Changelog | 11

[FFmpeg-devel] [PATCH v2 1/4] lavu: Remove libva 1.x support

2024-04-03 Thread Mark Thompson
libva 2.0 was released in 2017 and the 2.x versions are included in all supported distributions nowadays. --- The other two quirk cases are very old and could probably be removed? That could then deprecate the quirks system as well. libavutil/hwcontext_vaapi.c | 22 -- 1

Re: [FFmpeg-devel] [PATCH 1/7] avcodec/wavpack: Fix leak and segfault on reallocation error

2024-04-03 Thread Andreas Rheinhardt
Andreas Rheinhardt: > av_realloc_f() frees the buffer it is given on allocation > failure. But in this case, the buffer is an array of > ownership pointers, causing leaks on error. Furthermore, > the count of pointers is unchanged on error and the codec's > close function uses it to free said

[FFmpeg-devel] [PATCH v3 0/5] avcodec/ac3: Add aarch64 NEON DSP

2024-04-03 Thread Geoff Hill
Here's v3 to push the AC-3 ARMv8 NEON experiment a step further. This version implements 5 of the AC-3 encoder DSP functions, and adds checkasm tests where missing. I've tested that the checkasm tests pass on aarch64 and x86. On AWS Graviton2 (t4g.medium), GCC 12.3: $ tests/checkasm/checkasm

Re: [FFmpeg-devel] [PATCH] [v4] avcodec/vaapi_encode: add customized surface alignment

2024-04-03 Thread Araz
> On Mon, Apr 1, 2024 at 9:33 PM Mark Thompson wrote: > It is not necessary to copy exactly the same field layout. > Are you sure that there is never a meaningful non-power-of-two-bytes case? > Given that this is defining new public API to libavutil we don't want to be artificially constrained to

Re: [FFmpeg-devel] [EXT] Re: Query from Reuters on XZ, open source, and Microsoft

2024-04-03 Thread Satter, Raphael (Reuters) via ffmpeg-devel
Dear Kieran & co., Thank you I’ve had a chance to see the talk. It’s a marker of how invisible even critical open source projects can be that I wasn’t aware of FFmpeg’s role in powering the likes of YouTube and Netflix. A few questions I had: * How much did Microsoft end up paying for

[FFmpeg-devel] [PATCH 4/4] configure: Remove libva 1.x support

2024-04-03 Thread Mark Thompson
libva 2.0 was released in 2017 and the 2.x versions are included in all supported distributions nowadays. Various features no longer need any configure check after this command, including all codecs except AV1. --- configure | 22 +++--- 1 file changed, 3 insertions(+), 19

[FFmpeg-devel] [PATCH 2/2] configure: Only enable iamfdec, iamfenc when needed

2024-04-03 Thread Andreas Rheinhardt
Since 591e27d1e7b21b66f81c53f381356c5e6f1f0451 they would always be compiled even when nothing uses them; for shared builds the default linker behaviour is to include them even when not needed. Signed-off-by: Andreas Rheinhardt --- configure | 9 + 1 file changed, 5 insertions(+), 4

Re: [FFmpeg-devel] [PATCH 1/4] lavc/vp9dsp: R-V V ipred dc

2024-04-03 Thread Rémi Denis-Courmont
Le torstaina 28. maaliskuuta 2024, 4.44.33 EEST flow gg a écrit : > I don't quite understand, I think here 8x8 because zve64x is not suitable > for sharing, it shares between dc16x16 and dc32x32, there isn't much common > code, it would require adding 3 if-else statements and function parameters,

[FFmpeg-devel] [PATCH v2 4/4] configure: Remove libva 1.x support

2024-04-03 Thread Mark Thompson
libva 2.0 was released in 2017 and the 2.x versions are included in all supported distributions nowadays. Various features no longer need any configure check after this command, including all codecs except AV1. Note that the libva version is the API version plus one, so this is removing support

Re: [FFmpeg-devel] [PATCH] avformat/mxfdec: Check that edit_unit_byte_count is not negative

2024-04-03 Thread Marton Balint
On Wed, 3 Apr 2024, Tomas Härdin wrote: mån 2024-04-01 klockan 18:22 +0200 skrev Marton Balint: On Mon, 1 Apr 2024, Michael Niedermayer wrote: > Signed-off-by: Michael Niedermayer > --- > libavformat/mxfdec.c | 6 +- > 1 file changed, 5 insertions(+), 1 deletion(-) > > diff --git

Re: [FFmpeg-devel] [EXT] Re: Query from Reuters on XZ, open source, and Microsoft

2024-04-03 Thread Kieran Kunhya via ffmpeg-devel
Hi Raphael, Answers in my own personal capacity, not the views of my employer, nor the views of anyone else in FFmpeg. On Wed, Apr 3, 2024 at 8:26 PM Satter, Raphael (Reuters) < raphael.sat...@thomsonreuters.com> wrote: > Dear Kieran & co., > > > > Thank you I’ve had a chance to see the talk.

Re: [FFmpeg-devel] [PATCH] doc/developer: (security) researchers should be credited

2024-04-03 Thread Michael Niedermayer
On Wed, Apr 03, 2024 at 10:07:56AM +0200, Tomas Härdin wrote: > ons 2024-04-03 klockan 02:13 +0200 skrev Michael Niedermayer: > > Signed-off-by: Michael Niedermayer > > --- > >  doc/developer.texi | 4 > >  1 file changed, 4 insertions(+) > > > > diff --git a/doc/developer.texi

[FFmpeg-devel] [PATCH 3/4] lavfi: Remove libva 1.x support

2024-04-03 Thread Mark Thompson
libva 2.0 was released in 2017 and the 2.x versions are included in all supported distributions nowadays. --- libavfilter/vaapi_vpp.c | 15 ++- 1 file changed, 6 insertions(+), 9 deletions(-) diff --git a/libavfilter/vaapi_vpp.c b/libavfilter/vaapi_vpp.c index ace1153a23..21d74f8112

Re: [FFmpeg-devel] [PATCH] configure: Fix iamfdec dependencies

2024-04-03 Thread James Almer
On 4/3/2024 4:35 PM, Andreas Rheinhardt wrote: Signed-off-by: Andreas Rheinhardt --- configure | 1 + 1 file changed, 1 insertion(+) diff --git a/configure b/configure index 71386c3920..a393f6ea65 100755 --- a/configure +++ b/configure @@ -2854,6 +2854,7 @@ hevcparse_select="golomb"

Re: [FFmpeg-devel] [PATCH 1/4] lavu: Remove libva 1.x support

2024-04-03 Thread Rémi Denis-Courmont
Le keskiviikkona 3. huhtikuuta 2024, 22.44.29 EEST Mark Thompson a écrit : > libva 2.0 was released in 2017 and the 2.x versions are included in all > supported distributions nowadays. > --- > libavutil/hwcontext_vaapi.c | 4 > 1 file changed, 4 deletions(-) > > diff --git

Re: [FFmpeg-devel] [PATCH 1/4] lavu: Remove libva 1.x support

2024-04-03 Thread Mark Thompson
On 03/04/2024 21:09, Rémi Denis-Courmont wrote: Le keskiviikkona 3. huhtikuuta 2024, 22.44.29 EEST Mark Thompson a écrit : libva 2.0 was released in 2017 and the 2.x versions are included in all supported distributions nowadays. --- libavutil/hwcontext_vaapi.c | 4 1 file changed, 4

[FFmpeg-devel] [PATCH v2 2/4] lavc: Remove libva 1.x support

2024-04-03 Thread Mark Thompson
libva 2.0 was released in 2017 and the 2.x versions are included in all supported distributions nowadays. --- Now removing lots of VA_CHECK_VERSION as well. libavcodec/vaapi_decode.c | 16 +-- libavcodec/vaapi_encode.c | 77 ++

Re: [FFmpeg-devel] [PATCH 1/3] lavu/hwcontext_vaapi: Add a new quirk

2024-04-03 Thread Mark Thompson
On 28/03/2024 02:17, Xiang, Haihao wrote: From: Haihao Xiang libva2 doesn't require a fixed surface-array any more, but some driver/hardware combinations which rely on this are still used. To reduce the impact to users, add a quirk for the driver/hardware combination which supports dynamic

[FFmpeg-devel] [PATCH] configure: Fix iamfdec dependencies

2024-04-03 Thread Andreas Rheinhardt
Signed-off-by: Andreas Rheinhardt --- configure | 1 + 1 file changed, 1 insertion(+) diff --git a/configure b/configure index 71386c3920..a393f6ea65 100755 --- a/configure +++ b/configure @@ -2854,6 +2854,7 @@ hevcparse_select="golomb" hevc_sei_select="atsc_a53 golomb"

Re: [FFmpeg-devel] [PATCH 1/4] lavu: Remove libva 1.x support

2024-04-03 Thread Michael Niedermayer
On Wed, Apr 03, 2024 at 08:44:29PM +0100, Mark Thompson wrote: > libva 2.0 was released in 2017 and the 2.x versions are included in all > supported distributions nowadays. on ubuntu mingw make CC libavdevice/version.o AR libavdevice/libavdevice.a CC libavfilter/vaapi_vpp.o In

Re: [FFmpeg-devel] [PATCH 0/3] avcodec/h264dec: Fix dropped frames when draining

2024-04-03 Thread arch1t3cht
On 28/03/2024 02:56, arch1t3cht wrote: Fix one or more frames being dropped when starting decoding at a SEI recovery point that is very close to the end of the stream (specifically, which is less than 2 * has_b_frames frames before the end of the stream in decoding order). One case of this was

[FFmpeg-devel] [PATCH v2 3/4] lavfi: Remove libva 1.x support

2024-04-03 Thread Mark Thompson
libva 2.0 was released in 2017 and the 2.x versions are included in all supported distributions nowadays. --- No change. libavfilter/vaapi_vpp.c | 15 ++- 1 file changed, 6 insertions(+), 9 deletions(-) diff --git a/libavfilter/vaapi_vpp.c b/libavfilter/vaapi_vpp.c index

[FFmpeg-devel] [PATCH 2/5] avformat/iamf_parse: Check sound_system

2024-04-03 Thread Michael Niedermayer
Fixes: index 13 out of bounds for type 'const struct IAMFSoundSystemMap [13]' Fixes: 67796/clusterfuzz-testcase-minimized-ffmpeg_dem_IAMF_fuzzer-4554553191104512 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael

[FFmpeg-devel] [PATCH 3/5] swscale/utils: Fix xInc overflow

2024-04-03 Thread Michael Niedermayer
Fixes: signed integer overflow: 2 * 1073741824 cannot be represented in type 'int' Fixes: 67802/clusterfuzz-testcase-minimized-ffmpeg_SWS_fuzzer-6249515855183872 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael

[FFmpeg-devel] [PATCH 5/5] avformat/pcm: Use 64bit in bitrate computation

2024-04-03 Thread Michael Niedermayer
Fixes: signed integer overflow: 65792 * 65312 cannot be represented in type 'int' Fixes: 67819/clusterfuzz-testcase-minimized-ffmpeg_dem_WADY_fuzzer-5236100912185344 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael

[FFmpeg-devel] [PATCH 4/5] avformat/mxfdec: Check index_edit_rate

2024-04-03 Thread Michael Niedermayer
Fixes: Assertion b >=0 failed at libavutil/mathematics.c:62 Fixes: 67811/clusterfuzz-testcase-minimized-ffmpeg_dem_MXF_fuzzer-5108429687422976 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Niedermayer ---

[FFmpeg-devel] [PATCH 1/5] avcodec/wavarc: fix signed integer overflow in block type 6/19

2024-04-03 Thread Michael Niedermayer
Fixes: signed integer overflow: -2088796289 + -91276551 cannot be represented in type 'int' Fixes: 67772/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_WAVARC_fuzzer-6533568953122816 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg

[FFmpeg-devel] 7.0 release

2024-04-03 Thread Michael Niedermayer
Hi I will try to make the 7.0 release from the release branch in the next 48h (with some luck but easy possible it will get delayed) i will not try to fix any issues marked as blocking 7.0 on trac, IIRC ATM there is one. Given that 7.0 is behind shedule it seems better to fix them for 7.0.1. But

[FFmpeg-devel] [PATCH 05/10] avcodec/dovi_rpu: clarify semantics of guess_profile()

2024-04-03 Thread Niklas Haas
From: Niklas Haas This is based on HEVC only, H.264/AV1 use their own (hopefully correctly signalled) profiles. --- libavcodec/dovi_rpu.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/libavcodec/dovi_rpu.c b/libavcodec/dovi_rpu.c index 267e52ceb66..4da711d763e 100644

[FFmpeg-devel] [PATCH 07/10] avcodec/dovi_rpu: add ff_dovi_rpu_generate()

2024-04-03 Thread Niklas Haas
From: Niklas Haas This function takes a decoded AVDOVIMetadata struct and turns it back into a binary RPU. Verified using existing tools, and matches the bitstream in official reference files. I decided to just roll the EMDF and NAL encapsulation into this function because the end user will

[FFmpeg-devel] [PATCH 06/10] avcodec/dovi_rpu: add ff_dovi_configure()

2024-04-03 Thread Niklas Haas
From: Niklas Haas We need to set up the configuration struct appropriately based on the codec type, colorspace metadata, and presence/absence of an EL (though, we currently don't support an EL). When present, we use the signalled RPU data header to help infer (and validate) the right values.

[FFmpeg-devel] [PATCH 08/10] avcodec/libaomenc: implement dolby vision coding

2024-04-03 Thread Niklas Haas
From: Niklas Haas --- libavcodec/libaomenc.c | 26 ++ 1 file changed, 26 insertions(+) diff --git a/libavcodec/libaomenc.c b/libavcodec/libaomenc.c index d660afab4ec..6bc46ec6e28 100644 --- a/libavcodec/libaomenc.c +++ b/libavcodec/libaomenc.c @@ -43,6 +43,7 @@

[FFmpeg-devel] [PATCH 10/10] avformat/movenc: warn if dovi cfg ignored

2024-04-03 Thread Niklas Haas
From: Niklas Haas Since this is guarded behind strict unofficial, we should warn if the user feeds a dolby vision stream to this muxer, as it will otherwise result in a broken file. --- libavformat/movenc.c | 15 ++- 1 file changed, 10 insertions(+), 5 deletions(-) diff --git

[FFmpeg-devel] [PATCH 09/10] avcodec/libx265: implement dolby vision coding

2024-04-03 Thread Niklas Haas
From: Niklas Haas libx265 supports these natively, we just need to attach the generated NALs to the x265picture, as well as setting the appropriate DV profile. --- libavcodec/libx265.c | 36 1 file changed, 36 insertions(+) diff --git a/libavcodec/libx265.c

Re: [FFmpeg-devel] [EXT] Re: Query from Reuters on XZ, open source, and Microsoft

2024-04-03 Thread Satter, Raphael (Reuters) via ffmpeg-devel
Thanks Kieran, much appreciated. I’ll have a look at the video and drop a few additional questions into the mailing list. Sent from Outlook for iOS From: Kieran Kunhya Sent: Wednesday, April 3, 2024 12:38:39 PM To: FFmpeg development

[FFmpeg-devel] [PATCH] lavc/vvc: Error if SPS ID is duplicated within CVS

2024-04-03 Thread Frank Plowman
Key line from the spec is: "All SPS NAL units with a particular value of sps_seq_parameter_set_id in a CVS shall have the same content." Prior to this patch, the VVC decoder's behaviour on encountering a duplicated SPS ID (within the entire bitstream, not restricted to a CVS) was simply to

[FFmpeg-devel] [PATCH] avcodec/libdav1d: Don't cast const away unnecessarily

2024-04-03 Thread Andreas Rheinhardt
Possible since c89f6ae6899e0f3ffb4f51da1f1776ab16f5b3a0. Signed-off-by: Andreas Rheinhardt --- libavcodec/libdav1d.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/libavcodec/libdav1d.c b/libavcodec/libdav1d.c index f022a4ad05..93c77ed9c6 100644 ---

Re: [FFmpeg-devel] [PATCH 1/2] avcodec: add YUV color space metadata to AVCodec

2024-04-03 Thread Niklas Haas
On Sun, 24 Mar 2024 14:04:37 +0100 Andreas Rheinhardt wrote: > Niklas Haas: > > On Mon, 05 Feb 2024 19:04:30 +0100 Andreas Rheinhardt > > wrote: > >> This presumes the relevant states to be a cartesian product. Which need > >> not be true. A callback would be better; this would also allow to

Re: [FFmpeg-devel] [PATCH] avcodec/vvcdec: move vvcdec.{c, h} to the top directory

2024-04-03 Thread Andreas Rheinhardt
Anton Khirnov: > Quoting James Almer (2024-04-03 16:46:14) >> On 4/3/2024 5:35 AM, Anton Khirnov wrote: >>> Quoting James Almer (2024-04-02 21:28:28) On 4/2/2024 4:25 PM, Andreas Rheinhardt wrote: > James Almer: >> As it's the main file declaring the AVCodec. > > And why is

Re: [FFmpeg-devel] [PATCH] configure: Add missing libdav1d/av1 decoders->dovi_rpu dependency

2024-04-03 Thread James Almer
On 4/3/2024 3:00 PM, Andreas Rheinhardt wrote: Signed-off-by: Andreas Rheinhardt --- configure | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/configure b/configure index 1c5b4f3fa4..71386c3920 100755 --- a/configure +++ b/configure @@ -2898,7 +2898,7 @@

[FFmpeg-devel] [PATCH] configure: Add missing libdav1d/av1 decoders->dovi_rpu dependency

2024-04-03 Thread Andreas Rheinhardt
Signed-off-by: Andreas Rheinhardt --- configure | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/configure b/configure index 1c5b4f3fa4..71386c3920 100755 --- a/configure +++ b/configure @@ -2898,7 +2898,7 @@ asv1_encoder_select="aandcttables bswapdsp fdctdsp pixblockdsp"

Re: [FFmpeg-devel] Query from Reuters on XZ, open source, and Microsoft

2024-04-03 Thread Kieran Kunhya via ffmpeg-devel
Hi Raphael, I was the author of the tweet and I gave a short talk about this topic at Demuxed at a video conference last year: https://m.youtube.com/watch?v=OIyOEuQQsCQ=930s That said this is a community project and it would be best to continue the discussion on this mailing list unless agreed

Re: [FFmpeg-devel] [PATCH] avformat/httpauth: add SHA-256 Digest Authorization (Combined)

2024-04-03 Thread Andreas Rheinhardt
정지우 | Eugene: > - add SHA-256 Digest Authorization for RFC7616 using avutil/hash.h > - make_digest_auth_sha() : A1hash-> a1_hash and A2hash -> a2_hash > - combine with lint fix patch > (Please ignore previous patch requests that were requested by mistake): > [FFmpeg-devel] [PATCH] fix

[FFmpeg-devel] [PATCH 02/10] avcodec/dovi_rpu: store entire config record

2024-04-03 Thread Niklas Haas
From: Niklas Haas And make it public. For encoding, users may also be interested in the configured level and compatibility ID. So generalize the dv_profile field and just expose the whole configuration record. This makes the already rather reductive ff_dovi_update_cfg() function almost wholly

[FFmpeg-devel] [PATCH 01/10] avcodec: add dolbyvision option

2024-04-03 Thread Niklas Haas
From: Niklas Haas Tri-state yes/no/auto option. Allows users to set `dolbyvision` to `no` to suppress coding dolby vision even when supported by the target codec. --- doc/APIchanges | 3 +++ doc/codecs.texi| 12 libavcodec/avcodec.h | 11 +++

[FFmpeg-devel] [PATCH 04/10] avcodec/dovi_rpu: clarify error on missing RPU VDR

2024-04-03 Thread Niklas Haas
From: Niklas Haas The code was written under the misguided assumption that these fields would only be present when the value changes, however this does not match the actual patent specification, which says that streams are required to either always signal this metadata, or never signal it. That

[FFmpeg-devel] [PATCH 03/10] avcodec/dovi_rpu: properly replace context header

2024-04-03 Thread Niklas Haas
From: Niklas Haas This was never set in ff_dovi_ctx_replace(), leading to possibly out-of-date when copying from a sub-thread to the main thread. --- libavcodec/dovi_rpu.c | 1 + 1 file changed, 1 insertion(+) diff --git a/libavcodec/dovi_rpu.c b/libavcodec/dovi_rpu.c index

[FFmpeg-devel] Query from Reuters on XZ, open source, and Microsoft

2024-04-03 Thread Satter, Raphael (Reuters) via ffmpeg-devel
Dear FFMPEG community, This is Raphael Satter, a journalist with Reuters. I saw your thread on X about your experience with Microsoft in the context of the XZ story and would love to follow up with a few questions. Is there a good person to talk to? I’m reachable using the details below or on

Re: [FFmpeg-devel] [PATCH 1/4] avutil/pix{desc, fmt}: add new matrix coefficients from H.273 v3

2024-04-03 Thread Jan Ekström
On Tue, Apr 2, 2024 at 8:58 PM Jan Ekström wrote: > > On Mon, Apr 1, 2024 at 2:34 PM Jan Ekström wrote: > > > > On Fri, Mar 29, 2024 at 8:32 PM Jan Ekström wrote: > > > > > > On Fri, Mar 29, 2024 at 2:33 AM Jan Ekström wrote: > > > > > > > > * SMPTE ST 2128 IPT-C2 defines the coefficients

[FFmpeg-devel] [PATCH] avformat/httpauth: add SHA-256 Digest Authorization [update]

2024-04-03 Thread 정지우 | Eugene
add SHA-256 Digest Authorization for RFC7616 using avutil/hash.h - make_digest_auth_sha() : A1hash-> a1_hash and A2hash -> a2_hash - combine with lint fix patch Signed-off-by: Eugene-bitsensing --- libavformat/httpauth.c | 130 ++--- libavformat/httpauth.h |

[FFmpeg-devel] [PATCH 1/2] swscale/ppc/swscale_ppc_template: Remove code not passing checkasm

2024-04-03 Thread Andreas Rheinhardt
Signed-off-by: Andreas Rheinhardt --- libswscale/ppc/swscale_ppc_template.c | 62 --- 1 file changed, 9 insertions(+), 53 deletions(-) diff --git a/libswscale/ppc/swscale_ppc_template.c b/libswscale/ppc/swscale_ppc_template.c index 84641f3a8b..e9abd33cbf 100644 ---

[FFmpeg-devel] [PATCH 2/2] swscale/ppc/swscale_ppc_template: Reindent after the previous commit

2024-04-03 Thread Andreas Rheinhardt
Signed-off-by: Andreas Rheinhardt --- libswscale/ppc/swscale_ppc_template.c | 107 +- 1 file changed, 53 insertions(+), 54 deletions(-) diff --git a/libswscale/ppc/swscale_ppc_template.c b/libswscale/ppc/swscale_ppc_template.c index e9abd33cbf..3c2addd4a4 100644 ---

Re: [FFmpeg-devel] [PATCH v2 00/16] avcodec/vvcdec: support subpicture

2024-04-03 Thread James Almer
On 4/4/2024 12:12 AM, Nuo Mi wrote: On Thu, Apr 4, 2024 at 10:09 AM James Almer wrote: On 4/3/2024 11:05 PM, Nuo Mi wrote: On Tue, Apr 2, 2024 at 11:24 PM James Almer wrote: On 4/2/2024 10:01 AM, Nuo Mi wrote: On Wed, Mar 27, 2024 at 9:01 PM Nuo Mi wrote: Changes since v1: add

Re: [FFmpeg-devel] [PATCH] avcodec/vvc/vvc_inter_template: Fix left shift of negative number

2024-04-03 Thread Nuo Mi
On Thu, Apr 4, 2024 at 10:00 AM Andreas Rheinhardt < andreas.rheinha...@outlook.com> wrote: > Affected the vvc-conformance-WP_A_3 FATE test. > > Applied. Thank you, Andreas. ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org

[FFmpeg-devel] [PATCH 6/6] avcodec/huffyuvenc: Avoid code duplication

2024-04-03 Thread Andreas Rheinhardt
This also fixes misindentated code. Signed-off-by: Andreas Rheinhardt --- libavcodec/huffyuvenc.c | 146 1 file changed, 43 insertions(+), 103 deletions(-) diff --git a/libavcodec/huffyuvenc.c b/libavcodec/huffyuvenc.c index fd6b01de81..d822793406

Re: [FFmpeg-devel] 7.0 Name

2024-04-03 Thread RaDSL via ffmpeg-devel
On 4/3/2024 6:42 AM, Niklas Haas wrote: On Mon, 01 Apr 2024 19:42:29 -0400 Sean McGovern wrote: Hi, On Mon, Apr 1, 2024, 18:00 Lynne wrote: Apr 1, 2024, 22:01 bymich...@niedermayer.cc: Hi all I think we didnt decide on a name for 7.0 yet Previously suggested names: Darwin, De broglie,

Re: [FFmpeg-devel] [PATCH] Update the Changelog for 7.0

2024-04-03 Thread Anton Khirnov
Quoting Jean-Baptiste Kempf (2024-04-03 23:18:27) > +- DV profile 10 support in av1 DV is Digital Video. -- Anton Khirnov ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit

[FFmpeg-devel] [PATCH] avcodec/vvc/vvc_inter_template: Fix left shift of negative number

2024-04-03 Thread Andreas Rheinhardt
Affected the vvc-conformance-WP_A_3 FATE test. Signed-off-by: Andreas Rheinhardt --- libavcodec/vvc/vvc_inter_template.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavcodec/vvc/vvc_inter_template.c b/libavcodec/vvc/vvc_inter_template.c index e5cff079fb..e2fbfd4fc0

[FFmpeg-devel] [PATCH v2 2/2] avcodec/vvc: Rename vvc_?foo->foo

2024-04-03 Thread Andreas Rheinhardt
A namespace is unnecessary here given that all these files are already in the vvc subfolder. Signed-off-by: Andreas Rheinhardt --- Now also fixing the header inclusion guards. libavcodec/vvc/Makefile | 28 +-- libavcodec/vvc/{vvc_cabac.c => cabac.c}

Re: [FFmpeg-devel] [PATCH 2/2] swscale/ppc/swscale_ppc_template: Reindent after the previous commit

2024-04-03 Thread Lynne
Apr 4, 2024, 04:58 by andreas.rheinha...@outlook.com: > Signed-off-by: Andreas Rheinhardt > --- > libswscale/ppc/swscale_ppc_template.c | 107 +- > 1 file changed, 53 insertions(+), 54 deletions(-) > > diff --git a/libswscale/ppc/swscale_ppc_template.c >

Re: [FFmpeg-devel] [PATCH] Update the Changelog for 7.0

2024-04-03 Thread Vittorio Giovara
On Thu, Apr 4, 2024 at 1:28 AM Jean-Baptiste Kempf wrote: > On Wed, 3 Apr 2024, at 23:18, Jean-Baptiste Kempf wrote: > > As attached. > > Updated version attached (v2). > lgtm with AV1 capitalized -- Vittorio ___ ffmpeg-devel mailing list

[FFmpeg-devel] [PATCH] avcodec/ppc/h264dsp: Fix left shifts of negative numbers

2024-04-03 Thread Andreas Rheinhardt
PPC equivalent of c756b3fca240df75ffa28e75f2eb34834c10294d. Signed-off-by: Andreas Rheinhardt --- libavcodec/ppc/h264dsp.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/libavcodec/ppc/h264dsp.c b/libavcodec/ppc/h264dsp.c index f50f2553a2..0650768d7b 100644 ---

Re: [FFmpeg-devel] [PATCH v2 2/2] avcodec/vvc: Rename vvc_?foo->foo

2024-04-03 Thread Nuo Mi
> > > > rename to libavcodec/vvc/dec.h > index aa3d715524..4dacefc06a 100644 > --- a/libavcodec/vvc/vvcdec.h > +++ b/libavcodec/vvc/dec.h > @@ -21,14 +21,14 @@ > * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA > 02110-1301 USA > */ > > -#ifndef AVCODEC_VVC_VVCDEC_H > -#define

Re: [FFmpeg-devel] [PATCH v2 00/16] avcodec/vvcdec: support subpicture

2024-04-03 Thread Nuo Mi
On Thu, Apr 4, 2024 at 10:09 AM James Almer wrote: > On 4/3/2024 11:05 PM, Nuo Mi wrote: > > On Tue, Apr 2, 2024 at 11:24 PM James Almer wrote: > > > >> On 4/2/2024 10:01 AM, Nuo Mi wrote: > >>> On Wed, Mar 27, 2024 at 9:01 PM Nuo Mi wrote: > >>> > Changes since v1: > add

[FFmpeg-devel] [PATCH] avcodec/lossless_videoencdsp: Don't presume alignment in diff_bytes

2024-04-03 Thread Andreas Rheinhardt
The alignment of all the parameters in diff_bytes can be anything the despite the documentation claiming otherwise. 8ecd38312210d48ec9e50d78fc223d60e71a30ed was based around said documentation and is therefore insufficient to fix e.g. the misaligned loads that happen in the huffyuvbgra and

Re: [FFmpeg-devel] [PATCH v2 00/16] avcodec/vvcdec: support subpicture

2024-04-03 Thread James Almer
On 4/3/2024 11:05 PM, Nuo Mi wrote: On Tue, Apr 2, 2024 at 11:24 PM James Almer wrote: On 4/2/2024 10:01 AM, Nuo Mi wrote: On Wed, Mar 27, 2024 at 9:01 PM Nuo Mi wrote: Changes since v1: add v2-0004-avcodec-vvcdec-fix-uninitialized-last-element-of-.patch to address the clang-usan and

[FFmpeg-devel] [PATCH 2/2] avcodec/vvc: Rename vvc_?foo->foo

2024-04-03 Thread Andreas Rheinhardt
A namespace is unnecessary here given that all these files are already in the vvc subfolder. Signed-off-by: Andreas Rheinhardt --- libavcodec/vvc/Makefile | 28 +-- libavcodec/vvc/{vvc_cabac.c => cabac.c} | 6 ++-- libavcodec/vvc/{vvc_cabac.h =>

[FFmpeg-devel] [PATCH 1/6] avcodec/huffyuvdec: Don't zero unnecessarily

2024-04-03 Thread Andreas Rheinhardt
A decoder's private data has already been zeroed (apart from options) before init is called. Signed-off-by: Andreas Rheinhardt --- libavcodec/huffyuvdec.c | 1 - 1 file changed, 1 deletion(-) diff --git a/libavcodec/huffyuvdec.c b/libavcodec/huffyuvdec.c index 3bed27be21..29e5419d91 100644 ---

[FFmpeg-devel] [PATCH 3/6] avcodec/huffyuv(dec|enc): Use union for temp/temp16

2024-04-03 Thread Andreas Rheinhardt
These pointers already point to the same buffers, so using a union is possible and avoids the overhead of syncing the pointers (and saves some memory). Signed-off-by: Andreas Rheinhardt --- libavcodec/huffyuvdec.c | 11 +-- libavcodec/huffyuvenc.c | 11 +-- 2 files changed, 10

[FFmpeg-devel] [PATCH 4/6] avcodec/huffyuv: Return proper error code

2024-04-03 Thread Andreas Rheinhardt
Also forward said error code in the encoder. Signed-off-by: Andreas Rheinhardt --- libavcodec/huffyuv.c| 3 ++- libavcodec/huffyuvenc.c | 6 +++--- 2 files changed, 5 insertions(+), 4 deletions(-) diff --git a/libavcodec/huffyuv.c b/libavcodec/huffyuv.c index 723ab6b92b..f22c5ebc59 100644

  1   2   >