[FFmpeg-devel] [PATCH] libavcodec/libxev: Update EVC codec naming

2024-06-10 Thread Dariusz Frankiewicz
Make consistency between encoder and decoder implementation. Signed-off-by: Dariusz Frankiewicz --- libavcodec/libxevd.c | 2 +- libavcodec/libxeve.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/libavcodec/libxevd.c b/libavcodec/libxevd.c index 520fdab7d8..51303ec71d 10

Re: [FFmpeg-devel] [PATCH] libavcodec/libxev: Update EVC codec naming

2024-06-10 Thread Andreas Rheinhardt
Dariusz Frankiewicz: > Make consistency between encoder and decoder implementation. > > Signed-off-by: Dariusz Frankiewicz > --- > libavcodec/libxevd.c | 2 +- > libavcodec/libxeve.c | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/libavcodec/libxevd.c b/libavcodec/li

Re: [FFmpeg-devel] [PATCH] avr32: remove explicit support

2024-06-10 Thread Martin Storsjö
On Sun, 9 Jun 2024, Rémi Denis-Courmont wrote: The vendor has long since switched to Arm, wit the last product reaching their official end-of-life over 11 years ago. Linux support for the ISA was dropped 7 years ago. More importantly, this architecture was never supported by upstream GCC, and th

Re: [FFmpeg-devel] [PATCH] configure: remove stray bfin architecture

2024-06-10 Thread Martin Storsjö
On Sun, 9 Jun 2024, Rémi Denis-Courmont wrote: This seems to have been omitted in 880e2aa23645ed9871c66ee1cbd00f93c72d2d73. --- configure | 5 - 1 file changed, 5 deletions(-) diff --git a/configure b/configure index e69ed55837..4e27e6fd2b 100755 --- a/configure +++ b/configure @@ -2130,7 +2

Re: [FFmpeg-devel] [PATCH 2/4] lavc/mpegvideo: use H263DSP dequant function

2024-06-10 Thread Michael Niedermayer
On Sun, Jun 09, 2024 at 07:23:45PM +0300, Rémi Denis-Courmont wrote: > --- > libavcodec/mpegvideo.c | 44 ++ > 1 file changed, 10 insertions(+), 34 deletions(-) > > diff --git a/libavcodec/mpegvideo.c b/libavcodec/mpegvideo.c > index 7af823b8bd..9be0fecc8d

Re: [FFmpeg-devel] [PATCH 4/4] swscale/aarch64: add neon {lum, chr}ConvertRange

2024-06-10 Thread Martin Storsjö
On Fri, 7 Jun 2024, Ramiro Polla wrote: chrRangeFromJpeg_8_c: 28.5 chrRangeFromJpeg_8_neon: 21.2 chrRangeFromJpeg_24_c: 81.2 chrRangeFromJpeg_24_neon: 34.7 chrRangeFromJpeg_128_c: 425.2 chrRangeFromJpeg_128_neon: 162.0 chrRangeFromJpeg_144_c: 480.2 chrRangeFromJpeg_144_neon: 180.2 chrRangeFromJp

Re: [FFmpeg-devel] remove DEC Alpha DSP & support code

2024-06-10 Thread Michael Niedermayer
On Sun, Jun 09, 2024 at 04:08:48PM -0400, Sean McGovern wrote: > Hi, > > Attached is a patch to do proper removal of support for the DEC Alpha. > I hope it is not mangled. > > Side note: it seems GMail now prevents sending patches directly with > git send-email -- I really wish we could move to a

Re: [FFmpeg-devel] [PATCH v3 4/4] swscale/aarch64: Add rgb24 to yuv implementation

2024-06-10 Thread Martin Storsjö
On Fri, 7 Jun 2024, Zhao Zhili wrote: From: Zhao Zhili Test on Apple M1: rgb24_to_uv_8_c: 0.0 rgb24_to_uv_8_neon: 0.2 rgb24_to_uv_128_c: 1.0 rgb24_to_uv_128_neon: 0.5 rgb24_to_uv_1080_c: 7.0 rgb24_to_uv_1080_neon: 5.7 rgb24_to_uv_1920_c: 12.5 rgb24_to_uv_1920_neon: 9.5 rgb24_to_uv_half_8_c: 0

Re: [FFmpeg-devel] [PATCH 2/4] lavc/mpegvideo: use H263DSP dequant function

2024-06-10 Thread Rémi Denis-Courmont
Le 10 juin 2024 14:41:31 GMT+03:00, Michael Niedermayer a écrit : >On Sun, Jun 09, 2024 at 07:23:45PM +0300, Rémi Denis-Courmont wrote: >> --- >> libavcodec/mpegvideo.c | 44 ++ >> 1 file changed, 10 insertions(+), 34 deletions(-) >> >> diff --git a/lib

Re: [FFmpeg-devel] remove DEC Alpha DSP & support code

2024-06-10 Thread Michael Niedermayer
On Sun, Jun 09, 2024 at 04:08:48PM -0400, Sean McGovern wrote: [...] > Side note: it seems GMail now prevents sending patches directly with > git send-email I have difficulty believing this, but if so, the problem is gmail and you should contact gmails support about this. if thats not possible or

Re: [FFmpeg-devel] [PATCH 2/4] lavc/mpegvideo: use H263DSP dequant function

2024-06-10 Thread Michael Niedermayer
On Mon, Jun 10, 2024 at 03:14:14PM +0300, Rémi Denis-Courmont wrote: > > > Le 10 juin 2024 14:41:31 GMT+03:00, Michael Niedermayer > a écrit : > >On Sun, Jun 09, 2024 at 07:23:45PM +0300, Rémi Denis-Courmont wrote: > >> --- > >> libavcodec/mpegvideo.c | 44 ++---

Re: [FFmpeg-devel] [WIP] False positives on Coverity

2024-06-10 Thread Vittorio Giovara
On Mon, Jun 10, 2024 at 12:04 AM Michael Niedermayer wrote: > On Sun, Jun 09, 2024 at 03:10:09PM +0200, Vittorio Giovara wrote: > > On Sun, Jun 9, 2024 at 12:50 AM Timo Rothenpieler > > > wrote: > > > > > On 08.06.2024 21:49, Vittorio Giovara wrote: > > > > On Sat, Jun 8, 2024 at 6:02 PM Michael

Re: [FFmpeg-devel] [WIP] False positives on Coverity

2024-06-10 Thread Timo Rothenpieler
On 10.06.2024 14:37, Vittorio Giovara wrote: On Mon, Jun 10, 2024 at 12:04 AM Michael Niedermayer wrote: On Sun, Jun 09, 2024 at 03:10:09PM +0200, Vittorio Giovara wrote: On Sun, Jun 9, 2024 at 12:50 AM Timo Rothenpieler On 08.06.2024 21:49, Vittorio Giovara wrote: On Sat, Jun 8, 2024 at 6:

Re: [FFmpeg-devel] remove DEC Alpha DSP & support code

2024-06-10 Thread Vittorio Giovara
On Mon, Jun 10, 2024 at 2:29 PM Michael Niedermayer wrote: > On Sun, Jun 09, 2024 at 04:08:48PM -0400, Sean McGovern wrote: > [...] > > Side note: it seems GMail now prevents sending patches directly with > > git send-email > > I have difficulty believing this, but if so, the problem is gmail > a

Re: [FFmpeg-devel] [WIP] False positives on Coverity

2024-06-10 Thread Vittorio Giovara
On Mon, Jun 10, 2024 at 2:41 PM Timo Rothenpieler wrote: > > In either case, my point is that email is not a good system for these > > reports, because they cannot be tracked nor analyzed, and if they do > pose a > > security risk they shouldn't be advertised so openly. Having a small > bounty >

Re: [FFmpeg-devel] remove DEC Alpha DSP & support code

2024-06-10 Thread Rémi Denis-Courmont
Le 10 juin 2024 14:57:29 GMT+03:00, Michael Niedermayer a écrit : >Also we have alpha fate clients: >https://fate.ffmpeg.org/?query=subarch:alpha%2F%2F Are there? I only see Ubuntu 22.04 builds which must be cross-compiled since Ubuntu 22.04 doesn't support DEC Alpha, not even as a port. So

Re: [FFmpeg-devel] remove DEC Alpha DSP & support code

2024-06-10 Thread Andreas Rheinhardt
Rémi Denis-Courmont: > > > Le 10 juin 2024 14:57:29 GMT+03:00, Michael Niedermayer > a écrit : >> Also we have alpha fate clients: >> https://fate.ffmpeg.org/?query=subarch:alpha%2F%2F > > Are there? I only see Ubuntu 22.04 builds which must be cross-compiled since > Ubuntu 22.04 doesn't supp

Re: [FFmpeg-devel] [PATCH] avcodec/vvc/inter: Don't return void

2024-06-10 Thread Nuo Mi
LGTM. Thank you, Andreas On Mon, Jun 10, 2024 at 1:37 PM Andreas Rheinhardt < andreas.rheinha...@outlook.com> wrote: > Returning a void is not allowed by the spec. Just return instead. > > Signed-off-by: Andreas Rheinhardt > --- > libavcodec/vvc/inter.c | 9 ++--- > 1 file changed, 6 insert

Re: [FFmpeg-devel] remove DEC Alpha DSP & support code

2024-06-10 Thread Rémi Denis-Courmont
Le 10 juin 2024 16:07:14 GMT+03:00, Andreas Rheinhardt a écrit : >Rémi Denis-Courmont: >> >> >> Le 10 juin 2024 14:57:29 GMT+03:00, Michael Niedermayer >> a écrit : >>> Also we have alpha fate clients: >>> https://fate.ffmpeg.org/?query=subarch:alpha%2F%2F >> >> Are there? I only see Ubunt

Re: [FFmpeg-devel] [PATCH] libavcodec/libxev: Update EVC codec naming

2024-06-10 Thread PLT
> -Original Message- > From: ffmpeg-devel On Behalf Of > Andreas Rheinhardt > Sent: Monday, June 10, 2024 12:52 PM > To: ffmpeg-devel@ffmpeg.org > Subject: Re: [FFmpeg-devel] [PATCH] libavcodec/libxev: Update EVC codec > naming > > Dariusz Frankiewicz: > > Make consistency between enco

Re: [FFmpeg-devel] [PATCH] fate/vvc: add vvc-conformance-RPR_A_Alibaba_4

2024-06-10 Thread Nuo Mi
Hi Frank, Thank you for the patch. Could we follow the naming conventions used for other clips? On Mon, Jun 10, 2024 at 2:45 AM Frank Plowman wrote: > BeforeAfter > - > make fate-vvc CPU Time (No ASM) 131.52s

[FFmpeg-devel] [PATCH v2] libavcodec/libxeve: Update EVC codec naming

2024-06-10 Thread Dariusz Frankiewicz
Make consistency between encoder and decoder implementation. Signed-off-by: Dariusz Frankiewicz --- libavcodec/libxeve.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavcodec/libxeve.c b/libavcodec/libxeve.c index 1d9972619d..40eab08ef2 100644 --- a/libavcodec/libxeve.c

[FFmpeg-devel] [PATCH] fftools/ffmpeg_mux_init: Return error upon error

2024-06-10 Thread Andreas Rheinhardt
Currently it may return an uninitialized value. Introduced in 840f2bc18eddd72fa886aec30efc82991b920c45. Fixes Coverity issue #1603565. Signed-off-by: Andreas Rheinhardt --- fftools/ffmpeg_mux_init.c | 9 ++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/fftools/ffmpeg_mux_i

[FFmpeg-devel] [PATCH v2] avcodec/mpegvideo_enc: Add check for av_packet_new_side_data()

2024-06-10 Thread Jiasheng Jiang
Add check for av_packet_new_side_data() to avoid null pointer dereference if allocation fails. Fixes: bdc1220eeb ("h263enc: Add an option for outputting info about MBs as side data") Signed-off-by: Jiasheng Jiang --- Changelog: v1 -> v2: Wrap lines in the body of the commit message. --- libavc

Re: [FFmpeg-devel] [PATCH] avcodec/riscv: add h264 dc idct rvv

2024-06-10 Thread Rémi Denis-Courmont
Le maanantaina 10. kesäkuuta 2024, 9.22.14 EEST J. Dekker a écrit : > checkasm: bench runs 131072 (1 << 17) > h264_idct4_add_dc_8bpp_c: 1.5 > h264_idct4_add_dc_8bpp_rvv_i64: 0.7 RDCYCLE would exhibit larger and more meaningful numbers here. > h264_idct4_add_dc_9bpp_c: 1.5 > h264_idct4_add_dc_9bpp

[FFmpeg-devel] [PATCH] configure: Disable DNN without backend

2024-06-10 Thread Andreas Rheinhardt
The DNN filters are useless without a backend. This will also "fix" Coverity issues #1598288 and #1601718. Signed-off-by: Andreas Rheinhardt --- configure | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/configure b/configure index 6c5b8aab9a..83284427df 100755 --- a/configure

Re: [FFmpeg-devel] [PATCH v3 4/4] swscale/aarch64: Add rgb24 to yuv implementation

2024-06-10 Thread Zhao Zhili
> On Jun 10, 2024, at 19:59, Martin Storsjö wrote: > > On Fri, 7 Jun 2024, Zhao Zhili wrote: > >> From: Zhao Zhili >> > > No further comments from me, on this patchset. (Rémi had a comment on 2/4 > though - I don't have a strong opinion on that matter either way.) Thanks. I have modified

Re: [FFmpeg-devel] [PATCH v3 4/4] swscale/aarch64: Add rgb24 to yuv implementation

2024-06-10 Thread Rémi Denis-Courmont
Le maanantaina 10. kesäkuuta 2024, 19.26.17 EEST Zhao Zhili a écrit : > However, git pull and git push has no response from git at source.ffmpeg.org > :ffmpeg. Git pull from https://git.ffmpeg.org > is fine. And there is no commit after 94f2274a.

Re: [FFmpeg-devel] [PATCH] swscale/x86/rgb2rgb: add SSE2 shuffle_bytes functions

2024-06-10 Thread James Almer
On 6/9/2024 12:36 PM, James Almer wrote: So I would not add these SSE2 versions. But the one missing SSSE3 version (shuffle_bytes_2103_ssse3) is of course worth it. I will look into that. I'm not sure why you said it's missing, because it's there. _

Re: [FFmpeg-devel] [PATCH] fate/vvc: add vvc-conformance-RPR_A_Alibaba_4

2024-06-10 Thread Frank Plowman
On 10/06/2024 14:26, Nuo Mi wrote: > Hi Frank, > Thank you for the patch. > Could we follow the naming conventions used for other clips? > Hi, I did it this way because I do not have access to the FATE server, so somebody had to upload the clip for me and I felt it was easier if they did not have

Re: [FFmpeg-devel] [PATCH] fate/vvc: add vvc-conformance-RPR_A_Alibaba_4

2024-06-10 Thread James Almer
On 6/10/2024 2:23 PM, Frank Plowman wrote: On 10/06/2024 14:26, Nuo Mi wrote: Hi Frank, Thank you for the patch. Could we follow the naming conventions used for other clips? Hi, I did it this way because I do not have access to the FATE server, so somebody had to upload the clip for me and I

[FFmpeg-devel] [PATCH v2] fate/vvc: add vvc-conformance-RPR_A_4

2024-06-10 Thread Frank Plowman
BeforeAfter - make fate-vvc CPU Time (No ASM) 131.52s 134.83s libavcodec/vvc/* Line Coverage 95.3%96.9% inter_template.c Line Coverage 74.3%88.2% inter.c Line Coverage 85.3%99.2%

Re: [FFmpeg-devel] [PATCH] fate/vvc: add vvc-conformance-RPR_A_Alibaba_4

2024-06-10 Thread Frank Plowman
On 10/06/2024 18:31, James Almer wrote: > On 6/10/2024 2:23 PM, Frank Plowman wrote: >> On 10/06/2024 14:26, Nuo Mi wrote: >>> Hi Frank, >>> Thank you for the patch. >>> Could we follow the naming conventions used for other clips? >>> >> Hi, >> >> I did it this way because I do not have access to t

[FFmpeg-devel] [PATCH 0/5] Apple Spatial Metadata

2024-06-10 Thread Derek Buitenhuis
So I am a bit hesitant to send this, because while some of the boxes are documented officially by Apple, some of what are created by the Vision Pro / iPhones are not, because the official PDF is outdated. It's a call we have to make whether or not we want to push this, or hold out faith Apple w

[FFmpeg-devel] [PATCH 1/5] avutil/spherical: Add more spherical types

2024-06-10 Thread Derek Buitenhuis
These originate from the Apple Vision Pro, and are documented here: https://developer.apple.com/documentation/coremedia/cmprojectiontype Signed-off-by: Derek Buitenhuis --- libavutil/spherical.c | 3 +++ libavutil/spherical.h | 16 2 files changed, 19 insertions(+) diff -

[FFmpeg-devel] [PATCH 2/5] avutil/stereo3d: Fill out stereo info provided by Vision Pro files

2024-06-10 Thread Derek Buitenhuis
Based on what is in the files themselves, and what the API provides to users. URLs: * https://developer.apple.com/documentation/videotoolbox/kvtcompressionpropertykey_heroeye * https://developer.apple.com/documentation/videotoolbox/kvtcompressionpropertykey_stereocamerabaseline * https://

[FFmpeg-devel] [PATCH 3/5] fftools/ffprobe: Print more Stereo 3D info from side data

2024-06-10 Thread Derek Buitenhuis
Signed-off-by: Derek Buitenhuis --- fftools/ffprobe.c | 8 1 file changed, 8 insertions(+) diff --git a/fftools/ffprobe.c b/fftools/ffprobe.c index 2d38e5dfdc..082cec8a64 100644 --- a/fftools/ffprobe.c +++ b/fftools/ffprobe.c @@ -2544,6 +2544,14 @@ static void print_pkt_side_data(Writer

[FFmpeg-devel] [PATCH 4/5] avformat/mov: Add support for exporting Video Extension Usage info

2024-06-10 Thread Derek Buitenhuis
This box is provided by files created by the Apple Vision Pro, as well as the iPhone 15+ when capture for Vision Pro is enabled. The boxes are a mix of things documented by Apple in some PDFs, their API docs, and reverse engineering. Ideally we will have a real spec one day. Links: * https://d

[FFmpeg-devel] [PATCH 5/5] avformat/mov: Add support for reading and exporting horizontal field of view

2024-06-10 Thread Derek Buitenhuis
These boxes are created by the Apple Vision Pro and the iPhone 15+ when capture for the Vision Pro is enabled. Based off of the swift API: * https://developer.apple.com/documentation/coremedia/kcmformatdescriptionextension_horizontalfieldofview Signed-off-by: Derek Buitenhuis --- libavformat

[FFmpeg-devel] [PATCH] lavc/vc1dsp: match C block layout in inv_trans_4x4_rvv

2024-06-10 Thread Rémi Denis-Courmont
Although checkasm does not verify this, the decoder requires that the transform updates the input block exactly like the C code does. This fixes vc1-ism, vc1_ilaced_twomv, vc1_sa00040, vc1_sa10091, vc1_sa10143, vc1_sa20021, vc1test_smm0005 and wmv3-drm-dec tests. --- libavcodec/riscv/vc1dsp_rvv.S

Re: [FFmpeg-devel] [PATCH 1/2] ffplay: add -scaling_quality option for SDL

2024-06-10 Thread Marton Balint
On Tue, 4 Jun 2024, Ramiro Polla wrote: On Thu, May 30, 2024 at 11:36 PM Ramiro Polla wrote: --- doc/ffplay.texi | 2 ++ fftools/ffplay.c | 6 +- 2 files changed, 7 insertions(+), 1 deletion(-) diff --git a/doc/ffplay.texi b/doc/ffplay.texi index 93f77eeece..60f883e159 100644 --- a/d

[FFmpeg-devel] [PATCH 1/3] avfilter/af_afftdn: Assert format

2024-06-10 Thread Michael Niedermayer
Maybe helps: CID1515514 Uninitialized scalar variable Maybe helps: CID1515517 Uninitialized scalar variable Sponsored-by: Sovereign Tech Fund Signed-off-by: Michael Niedermayer --- libavfilter/af_afftdn.c | 5 + 1 file changed, 5 insertions(+) diff --git a/libavfilter/af_afftdn.c b/libavfil

[FFmpeg-devel] [PATCH 2/3] avfilter/af_afir: Assert format

2024-06-10 Thread Michael Niedermayer
Maybe helps: CID1516805 Uninitialized scalar variable Sponsored-by: Sovereign Tech Fund Signed-off-by: Michael Niedermayer --- libavfilter/af_afir.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/libavfilter/af_afir.c b/libavfilter/af_afir.c index 24f8f8cbf1c..4867bfba24b 100644 --- a/li

[FFmpeg-devel] [PATCH 3/3] avfilter/af_amerge: Cleanup on av_channel_layout_copy() failure

2024-06-10 Thread Michael Niedermayer
Fixes: CID1503088 Resource leak Sponsored-by: Sovereign Tech Fund Signed-off-by: Michael Niedermayer --- libavfilter/af_amerge.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/libavfilter/af_amerge.c b/libavfilter/af_amerge.c index 493c8521388..67c87d1d9e5 100644 --- a/l

[FFmpeg-devel] [PATCH] lavc/vc1dsp: match C block layout in inv_trans_4x8_rvv

2024-06-10 Thread Rémi Denis-Courmont
Although checkasm does not verify this, the decoder requires that the transform updates the input block exactly like the C code does. This fixes vc1-ism, vc1_ilaced_twomv, vc1_sa00040, vc1_sa10091, vc1_sa10143, vc1_sa20021, vc1test_smm0005 and wmv3-drm-dec tests. --- libavcodec/riscv/vc1dsp_rvv.S

Re: [FFmpeg-devel] [PATCH] fftools/ffmpeg_demux: gracefully ignore mismatching channel layouts for -channel_layout option

2024-06-10 Thread Marton Balint
On Wed, 5 Jun 2024, Anton Khirnov wrote: Quoting Marton Balint (2024-06-03 23:48:47) The very old behaviour of -channel_layout was to simply warn the user about channel layouts which does not have a matching channel count, and ignore them, instead of reporting an error. The recent fix re-ad

Re: [FFmpeg-devel] [PATCH 1/3] avformat/mov_chan: use the newly added channel ids for more exact mapping

2024-06-10 Thread Marton Balint
On Mon, 3 Jun 2024, Marton Balint wrote: Also make the iso_channel_position table consistent with what the AAC decoder uses in avcodec/aac/aacdec_usac.c. Fate changes are caused by the change of how 7.1 layout is mapped, previously it included Side Surround channels, now it includes the Surr

Re: [FFmpeg-devel] [PATCH 4/5] avformat/mov: Add support for exporting Video Extension Usage info

2024-06-10 Thread James Almer
On 6/10/2024 3:44 PM, Derek Buitenhuis wrote: +static int mov_read_vexu(MOVContext *c, AVIOContext *pb, MOVAtom atom) +{ +int size; +int64_t remaining; +uint32_t tag; + +if (c->fc->nb_streams < 1) +return 0; + +if (atom.size < 8) { +av_log(c->fc, AV_LOG_ERROR,

Re: [FFmpeg-devel] [PATCH 4/5] avformat/mov: Add support for exporting Video Extension Usage info

2024-06-10 Thread Derek Buitenhuis
On 6/10/2024 8:38 PM, James Almer wrote: >> +remaining = atom.size; >> +while (remaining > 0) { > > Maybe this loop should call mov_read_default, with proj and eyes added > to mov_default_parse_table[]. Although i don't know if eyes may show up > as child for other parent boxes or not. >

[FFmpeg-devel] [PATCHv4 2/4] lavc/mpegvideo: use H263DSP dequant function

2024-06-10 Thread Rémi Denis-Courmont
--- libavcodec/mpegvideo.c | 40 +--- 1 file changed, 9 insertions(+), 31 deletions(-) diff --git a/libavcodec/mpegvideo.c b/libavcodec/mpegvideo.c index 7af823b8bd..810888fc47 100644 --- a/libavcodec/mpegvideo.c +++ b/libavcodec/mpegvideo.c @@ -201,13 +201,11

[FFmpeg-devel] [PATCHv4 1/4] lavc/h263dsp: add DCT dequantisation functions

2024-06-10 Thread Rémi Denis-Courmont
Note that optimised implementations of these functions will be taken into actual use only if MpegEncContext.dct_unquantize_h263_{inter,intra} are *not* overloaded by existing optimisations. --- libavcodec/h263dsp.c | 25 + libavcodec/h263dsp.h | 4 2 files changed, 29

[FFmpeg-devel] [PATCHv4 3/4] checkasm/h263dsp: test dct_unquantize_{intra, inter}

2024-06-10 Thread Rémi Denis-Courmont
--- tests/checkasm/h263dsp.c | 53 +++- 1 file changed, 52 insertions(+), 1 deletion(-) diff --git a/tests/checkasm/h263dsp.c b/tests/checkasm/h263dsp.c index 2d0957a90b..a8530403ee 100644 --- a/tests/checkasm/h263dsp.c +++ b/tests/checkasm/h263dsp.c @@ -18,13

[FFmpeg-devel] [PATCHv4 4/4] lavc/h263dsp: R-V V dct_unquantize_{intra, inter}

2024-06-10 Thread Rémi Denis-Courmont
T-Head C908: h263dsp.dct_unquantize_inter_c: 3.7 h263dsp.dct_unquantize_inter_rvv_i32: 1.7 h263dsp.dct_unquantize_intra_c: 4.0 h263dsp.dct_unquantize_intra_rvv_i32: 2.0 SpacemiT X60: h263dsp.dct_unquantize_inter_c: 3.5 h263dsp.dct_unquantize_inter_rvv_i32: 1.5 h263dsp.dct_unquant

Re: [FFmpeg-devel] [PATCH] Add extra const to FF_PFNGLSHADERSOURCEPROC.

2024-06-10 Thread Billy O'Neal (VC AIR) via ffmpeg-devel
Hi there folks! I double checked patchwork and it looks like it's still showing the first version of this patch, before I applied suggestions from Andreas Rheinhardt . Should I resend with a different subject line or is there something else I specifically broke? Thanks again! Billy O'Neal Vis

Re: [FFmpeg-devel] remove DEC Alpha DSP & support code

2024-06-10 Thread Michael Niedermayer
On Mon, Jun 10, 2024 at 02:42:16PM +0200, Vittorio Giovara wrote: > On Mon, Jun 10, 2024 at 2:29 PM Michael Niedermayer > wrote: > > > On Sun, Jun 09, 2024 at 04:08:48PM -0400, Sean McGovern wrote: [...] > > if thats not possible or helpfull and you still want to keep > > using a servivce where y

Re: [FFmpeg-devel] remove DEC Alpha DSP & support code

2024-06-10 Thread Sean McGovern
Hi, On Mon, Jun 10, 2024 at 8:17 PM Michael Niedermayer wrote: > > On Mon, Jun 10, 2024 at 02:42:16PM +0200, Vittorio Giovara wrote: > > On Mon, Jun 10, 2024 at 2:29 PM Michael Niedermayer > > wrote: > > > > > On Sun, Jun 09, 2024 at 04:08:48PM -0400, Sean McGovern wrote: > [...] > > > if thats

[FFmpeg-devel] [PATCH] lavu/hwcontext_vulkan: Support write on drm frame

2024-06-10 Thread Xiang, Haihao
From: Haihao Xiang Otherwise nothing is written into the destination when a write mapping is requested. For example, a vulkan frame mapped from a drm frame (which is wrapped as a vaapi frame in the example) is used as the output of scale_vulkan filter, it always gets a green screen without this

Re: [FFmpeg-devel] [PATCH] swscale/x86/rgb2rgb: add SSE2 shuffle_bytes functions

2024-06-10 Thread Andreas Rheinhardt
James Almer: > On 6/9/2024 12:36 PM, James Almer wrote: >>> So I would not add these SSE2 versions. But the one missing SSSE3 >>> version (shuffle_bytes_2103_ssse3) is of course worth it. >> >> I will look into that. > > I'm not sure why you said it's missing, because it's there. Sorry for having

Re: [FFmpeg-devel] [PATCH] fftools/ffmpeg_mux_init: Return error upon error

2024-06-10 Thread Anton Khirnov
Quoting Andreas Rheinhardt (2024-06-10 15:24:49) > Currently it may return an uninitialized value. > Introduced in 840f2bc18eddd72fa886aec30efc82991b920c45. > Fixes Coverity issue #1603565. > > Signed-off-by: Andreas Rheinhardt > --- > fftools/ffmpeg_mux_init.c | 9 ++--- > 1 file changed, 6

[FFmpeg-devel] [PATCH] fftools/ffmpeg_mux_init: Fix leak when using non-encoding option

2024-06-10 Thread Andreas Rheinhardt
Signed-off-by: Andreas Rheinhardt --- fftools/ffmpeg_mux_init.c | 1 + 1 file changed, 1 insertion(+) diff --git a/fftools/ffmpeg_mux_init.c b/fftools/ffmpeg_mux_init.c index 2ed4171a75..e25c6e7e24 100644 --- a/fftools/ffmpeg_mux_init.c +++ b/fftools/ffmpeg_mux_init.c @@ -3146,6 +3146,7 @@ stati

Re: [FFmpeg-devel] [PATCH] fftools/ffmpeg_mux_init: Return error upon error

2024-06-10 Thread Andreas Rheinhardt
Anton Khirnov: > Quoting Andreas Rheinhardt (2024-06-10 15:24:49) >> Currently it may return an uninitialized value. >> Introduced in 840f2bc18eddd72fa886aec30efc82991b920c45. >> Fixes Coverity issue #1603565. >> >> Signed-off-by: Andreas Rheinhardt >> --- >> fftools/ffmpeg_mux_init.c | 9 ++-

Re: [FFmpeg-devel] [PATCH] fftools/ffmpeg_mux_init: Return error upon error

2024-06-10 Thread Andreas Rheinhardt
Andreas Rheinhardt: > Anton Khirnov: >> Quoting Andreas Rheinhardt (2024-06-10 15:24:49) >>> Currently it may return an uninitialized value. >>> Introduced in 840f2bc18eddd72fa886aec30efc82991b920c45. >>> Fixes Coverity issue #1603565. >>> >>> Signed-off-by: Andreas Rheinhardt >>> --- >>> fftools