Re: [FFmpeg-devel] Reintroducing FFmpeg to Debian

2014-08-17 Thread Michael Niedermayer
On Fri, Aug 15, 2014 at 01:19:38AM +0200, Luca Barbato wrote: Stefano Sabatini wrote: [...] The list is quite long and debunking each of the statements could take a lot of time. I'm going to address two historical misrepresentations: # The change of management Michael Niedermayer

[FFmpeg-devel] [PATCH] gifdec: use truncated width for image manipulation

2014-08-17 Thread Christophe Gisquet
Hi, the attached patch fixes ticket #3538, which is an off-by-one error. Unfortunately, I see no way of detecting it as a correctable behavior and not an actual error besides that. Maybe restricting this to actual off-by-one errors would be better, too. -- Christophe From

Re: [FFmpeg-devel] [PATCH 3/3] vidstabutils: fix indentation

2014-08-17 Thread Michael Niedermayer
On Sat, Aug 16, 2014 at 05:47:14PM -0700, Timothy Gu wrote: Signed-off-by: Timothy Gu timothyg...@gmail.com --- libavfilter/vidstabutils.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) applied thanks [...] -- Michael GnuPG fingerprint:

Re: [FFmpeg-devel] [PATCH] ffprobe: add -show_data_hash option.

2014-08-17 Thread Michael Niedermayer
On Sun, Aug 17, 2014 at 11:33:06AM +0200, Nicolas George wrote: Le decadi 30 thermidor, an CCXXII, Michael Niedermayer a écrit : whats the status of this patch ? has it been forgotten ? It seems it was indeed. Thanks for keeping track. I have pushed to my tree for merging: 4f3e2f1

Re: [FFmpeg-devel] [PATCH 2/2] avformat/movenchint: use av_freep() for saftey

2014-08-17 Thread Paul B Mahol
On 8/16/14, Michael Niedermayer michae...@gmx.at wrote: Signed-off-by: Michael Niedermayer michae...@gmx.at --- libavformat/movenchint.c |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/libavformat/movenchint.c b/libavformat/movenchint.c index 2602254..006aa09

Re: [FFmpeg-devel] [PATCH 4/4] dpx: fix endianess for RGB 8bits

2014-08-17 Thread Christophe Gisquet
Le 13 août 2014 12:22, Christophe Gisquet christophe.gisq...@gmail.com a écrit : Fixes DLAD_8b_3c_big.dpx from ticket #3692 --- libavcodec/dpx.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/libavcodec/dpx.c b/libavcodec/dpx.c index 2ad7527..d4d6833 100644 --- a/libavcodec/dpx.c

[FFmpeg-devel] [PATCH] Replace old cookies with new cookies of the same name

2014-08-17 Thread Micah Galizia
When new cookie values (with the same name as an existing cookie) are returned in an HLS stream, the current implementation will append the new cookie to the list of cookies. This causes FFMPEG to send multiple cookie values for the same cookie and in some cases exceed the http header size in some

Re: [FFmpeg-devel] [PATCH 2/2] avformat/movenchint: use av_freep() for saftey

2014-08-17 Thread Michael Niedermayer
On Sun, Aug 17, 2014 at 12:24:27PM +0200, Paul B Mahol wrote: On 8/16/14, Michael Niedermayer michae...@gmx.at wrote: Signed-off-by: Michael Niedermayer michae...@gmx.at --- libavformat/movenchint.c |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git

Re: [FFmpeg-devel] [PATCH] Replace old cookies with new cookies of the same name

2014-08-17 Thread Nicolas George
Le decadi 30 thermidor, an CCXXII, Micah Galizia a écrit : When new cookie values (with the same name as an existing cookie) are returned in an HLS stream, the current implementation will append the new cookie to the list of cookies. This causes FFMPEG to send multiple cookie values for the

Re: [FFmpeg-devel] [PATCH] Replace old cookies with new cookies of the same name

2014-08-17 Thread wm4
On Sun, 17 Aug 2014 13:29:15 +0200 Nicolas George geo...@nsup.org wrote: Le decadi 30 thermidor, an CCXXII, Micah Galizia a écrit : When new cookie values (with the same name as an existing cookie) are returned in an HLS stream, the current implementation will append the new cookie to the

Re: [FFmpeg-devel] [PATCH 2/5] avfilter/select: use av_pixelutils_bdiff()

2014-08-17 Thread Michael Niedermayer
On Thu, Aug 14, 2014 at 11:05:12PM +0200, Clément Bœsch wrote: --- libavfilter/f_select.c | 20 +--- 1 file changed, 5 insertions(+), 15 deletions(-) LGTM [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB In a rich man's house there is no

Re: [FFmpeg-devel] Reintroducing FFmpeg to Debian

2014-08-17 Thread Andreas Cadhalpun
Hi Russ, On 16.08.2014 18:33, Russ Allbery wrote: All the renaming and cordial co-existence in the world won't change this. The things that would change this is for one or both projects to develop a better security track record and a history of higher-quality code releases that require less

Re: [FFmpeg-devel] [PATCH 5/5] avfilter/fieldmatch: use av_pixelutils_bdiff()

2014-08-17 Thread Michael Niedermayer
On Thu, Aug 14, 2014 at 11:05:15PM +0200, Clément Bœsch wrote: Not that much relevant from a performance PoV because not called often. --- libavfilter/vf_fieldmatch.c | 42 ++ 1 file changed, 22 insertions(+), 20 deletions(-) should be ok [...] --

Re: [FFmpeg-devel] [PATCH 3/5] avutil/pixelutils: faster pixelutils_sad_[au]_16x16

2014-08-17 Thread Michael Niedermayer
On Thu, Aug 14, 2014 at 11:05:13PM +0200, Clément Bœsch wrote: ~560 → ~500 decicycles This is following the comments from Michael in https://ffmpeg.org/pipermail/ffmpeg-devel/2014-August/160599.html Using 2 registers for accumulator didn't help. On the other hand, some re-ordering between

Re: [FFmpeg-devel] [PATCH] Replace old cookies with new cookies of the same name

2014-08-17 Thread Nicolas George
Le decadi 30 thermidor, an CCXXII, wm4 a écrit : AFAIK this cookie string is exposed by AVOption API, and I use it for setting cookies. And I don't feel like rewriting this code at all. I do not propose to break user-visible API. You confuse it with internal data structures. Regards, --

[FFmpeg-devel] [PATCH 2/2] lavf/http: remove special case for cookies attributes.

2014-08-17 Thread Nicolas George
With the previous change, unknown attributes are all ignored, as specified by the RFC. Signed-off-by: Nicolas George geo...@nsup.org --- libavformat/http.c | 5 - 1 file changed, 5 deletions(-) diff --git a/libavformat/http.c b/libavformat/http.c index bd67645..018d25c 100644 ---

Re: [FFmpeg-devel] Invitation to VDD and registration

2014-08-17 Thread Reimar Döffinger
On Sat, Aug 16, 2014 at 05:13:53PM +0100, Kieran Kunhya wrote: And do not forget the language barrier: when writing a mail, there is as much time as necessary to find words. IRL, the people struggling to find their words are at a clear disadvantage. We can rotate between different

Re: [FFmpeg-devel] [RFC][PATCH] Allow include files to be installed into subdirectory

2014-08-17 Thread Michael Niedermayer
On Mon, Aug 11, 2014 at 02:23:47AM +0300, Ivan Kalvachev wrote: The patch is inspired by something I read in the Debian discussion. Libav and FFmpeg could be installed side by side without conflicts in the libraries, thanks to using additional suffixes. However development/include files are

[FFmpeg-devel] [PATCH] avcodec/lcldec: fix decoding of YUV444 sample

2014-08-17 Thread Piotr Bandurski
Hi, Attached patch fixes decoding of this file: http://www.datafilehost.com/d/1bde8ab0 Regards 0001-avcodec-lcldec-fix-decoding-of-YUV444-sample.patch Description: Binary data ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org

Re: [FFmpeg-devel] [PATCH] avcodec/lcldec: fix decoding of YUV444 sample

2014-08-17 Thread Michael Niedermayer
On Sun, Aug 17, 2014 at 06:27:25PM +0200, Piotr Bandurski wrote: Hi, Attached patch fixes decoding of this file: http://www.datafilehost.com/d/1bde8ab0 Regards From 71bef996471551ab4ba8ff3270413c0c7cb4c6cc Mon Sep 17 00:00:00 2001 From: Piotr Bandurski ami_st...@o2.pl Date: Sun, 17

[FFmpeg-devel] [PATCH 1/2] alacenc: increase predictor buffer

2014-08-17 Thread Christophe Gisquet
This change is almost cosmetical only, and reduces the changes needed to fix the 24bps case. --- libavcodec/alacenc.c | 19 ++- 1 file changed, 10 insertions(+), 9 deletions(-) diff --git a/libavcodec/alacenc.c b/libavcodec/alacenc.c index bc68a06..6345253 100644 ---

[FFmpeg-devel] [PATCH 2/2] alacenc: fix extra bits extraction

2014-08-17 Thread Christophe Gisquet
The raw coded bits are extracted prior to decorrelation, as is correctly performed by the decoder, and not after. --- libavcodec/alacenc.c | 16 ++-- 1 file changed, 14 insertions(+), 2 deletions(-) diff --git a/libavcodec/alacenc.c b/libavcodec/alacenc.c index 6345253..b9ad899

[FFmpeg-devel] [PATCH 0/2] Fix ALAC encoder for 24bps

2014-08-17 Thread Christophe Gisquet
The encoder, for content having a bitdepth higher than 16, stores the LSBs uncompressed. To do so, it performs first channel rematrixing then extract these MSBs. However, these 2 steps are inverted, as can be seen in the decoder, or in the official encoder:

Re: [FFmpeg-devel] [PATCH 0/2] Fix ALAC encoder for 24bps

2014-08-17 Thread Christophe Gisquet
2014-08-17 19:09 GMT+02:00 Christophe Gisquet christophe.gisq...@gmail.com: It would possible to detect bitstreams before this change and achieve correct decoding if need be. fate tests still pass with the changes, which means the test sample doesn't contain the corner case involved, and not

Re: [FFmpeg-devel] [PATCH 0/2] Fix ALAC encoder for 24bps

2014-08-17 Thread Michael Niedermayer
On Sun, Aug 17, 2014 at 07:15:54PM +0200, Christophe Gisquet wrote: 2014-08-17 19:09 GMT+02:00 Christophe Gisquet christophe.gisq...@gmail.com: It would possible to detect bitstreams before this change and achieve correct decoding if need be. fate tests still pass with the changes, which

Re: [FFmpeg-devel] [PATCH 1/2] lavf/http: fix cookie parsing.

2014-08-17 Thread Michael Niedermayer
On Sun, Aug 17, 2014 at 02:26:29PM +0200, Nicolas George wrote: The current code would use any unknown attribute-value pair as the cookie value. RFC 6265 states that the first key-value pair is the actual cookie, and the attribute-value pairs only start after. With the current code:

Re: [FFmpeg-devel] [PATCH] avcodec: export motion vectors in frame side data on demand

2014-08-17 Thread Clément Bœsch
On Thu, Aug 14, 2014 at 01:19:10PM +0200, Stefano Sabatini wrote: On date Monday 2014-08-11 15:22:59 +0200, Clément Bœsch encoded: From: Clément Bœsch clem...@stupeflix.com The reasoning behind this addition is that various third party applications are interested in getting some motion

Re: [FFmpeg-devel] [PATCH] gifdec: use truncated width for image manipulation

2014-08-17 Thread Michael Niedermayer
On Sun, Aug 17, 2014 at 10:41:53AM +0200, Christophe Gisquet wrote: Hi, the attached patch fixes ticket #3538, which is an off-by-one error. Unfortunately, I see no way of detecting it as a correctable behavior and not an actual error besides that. Maybe restricting this to actual

Re: [FFmpeg-devel] [PATCH] gifdec: use truncated width for image manipulation

2014-08-17 Thread Christophe Gisquet
Hi, 2014-08-17 20:39 GMT+02:00 Michael Niedermayer michae...@gmx.at: +if (width s-screen_width) { +av_log(s-avctx, AV_LOG_ERROR, Invalid image width.\n); +return AVERROR_INVALIDDATA; +} +if (left + width s-screen_width) { +/* width must be kept around

Re: [FFmpeg-devel] [PATCH 2/2] alacenc: fix extra bits extraction

2014-08-17 Thread Christophe Gisquet
Hi, 2014-08-17 19:09 GMT+02:00 Christophe Gisquet christophe.gisq...@gmail.com: The raw coded bits are extracted prior to decorrelation, as is correctly performed by the decoder, and not after. Forgot to mention it fixes ticket #2768 (haven't checked 2497 yet), so commit message amended. --

[FFmpeg-devel] [PATCH v4] added ULs for demuxing avid media composer mxf files

2014-08-17 Thread Mark Reid
The AAF SDK refers to these ULs as Legacy. These ULs are the same as the ones found in FFmbc's version of mxf.c and the ones found in libMXF Fixes Ticket#1554, Ticket#3100 and Ticket#3450 --- libavformat/mxf.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/libavformat/mxf.c

[FFmpeg-devel] [PATCH v4] added ULs for demuxing avid media composer mxf files

2014-08-17 Thread Mark Reid
Changes since v3: *added more details to commit message Mark Reid (1): added ULs for demuxing avid media composer mxf files libavformat/mxf.c | 3 +++ 1 file changed, 3 insertions(+) -- 2.0.0 ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org

Re: [FFmpeg-devel] [PATCH] gifdec: use truncated width for image manipulation

2014-08-17 Thread Michael Niedermayer
On Sun, Aug 17, 2014 at 09:47:25PM +0200, Christophe Gisquet wrote: Hi, 2014-08-17 20:39 GMT+02:00 Michael Niedermayer michae...@gmx.at: +if (width s-screen_width) { +av_log(s-avctx, AV_LOG_ERROR, Invalid image width.\n); +return AVERROR_INVALIDDATA; +} +

[FFmpeg-devel] [RFC] removing libmpcodecs for reuniting purposes.

2014-08-17 Thread compn
libav brought up the point again that it doesnt like libmpcodecs. is there anyone using the remaining libmpcodecs filters ? most of the filters have been ported to libavfilter already. comments? -compn ___ ffmpeg-devel mailing list

Re: [FFmpeg-devel] [RFC] removing libmpcodecs for reuniting purposes.

2014-08-17 Thread wm4
On Sun, 17 Aug 2014 19:04:35 -0400 compn te...@mi.rr.com wrote: libav brought up the point again that it doesnt like libmpcodecs. is there anyone using the remaining libmpcodecs filters ? most of the filters have been ported to libavfilter already. comments? +1000 Nobody cares about

Re: [FFmpeg-devel] [PATCH 0/2] Fix ALAC encoder for 24bps

2014-08-17 Thread Carl Eugen Hoyos
Carl Eugen Hoyos cehoyos at ag.or.at writes: If this is related to ticket #2768, please mention it in the commit message. Sorry, please disregard... Carl Eugen ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org

Re: [FFmpeg-devel] [PATCH] avfilter/showcqt: add fontcolor option

2014-08-17 Thread Timothy Gu
On Sun, Aug 17, 2014 at 4:54 PM, Muhammad Faiz mfc...@gmail.com wrote: This fontcolor option uses arithmetic expression, not color value, so color names aren't available. Thank's You should use AV_OPT_TYPE_COLOR instead of AV_OPT_TYPE_STRING to make the color names usable. Look at how

Re: [FFmpeg-devel] [PATCH v4] added ULs for demuxing avid media composer mxf files

2014-08-17 Thread Michael Niedermayer
On Sun, Aug 17, 2014 at 02:26:45PM -0700, Mark Reid wrote: The AAF SDK refers to these ULs as Legacy. These ULs are the same as the ones found in FFmbc's version of mxf.c and the ones found in libMXF Fixes Ticket#1554, Ticket#3100 and Ticket#3450 --- libavformat/mxf.c | 3 +++ 1 file

Re: [FFmpeg-devel] [PATCH 1/2] alacenc: increase predictor buffer

2014-08-17 Thread Michael Niedermayer
On Sun, Aug 17, 2014 at 05:09:13PM +, Christophe Gisquet wrote: This change is almost cosmetical only, and reduces the changes needed to fix the 24bps case. --- libavcodec/alacenc.c | 19 ++- 1 file changed, 10 insertions(+), 9 deletions(-) applied thanks [...] --

Re: [FFmpeg-devel] [PATCH 2/2] alacenc: fix extra bits extraction

2014-08-17 Thread Michael Niedermayer
On Sun, Aug 17, 2014 at 10:20:14PM +0200, Christophe Gisquet wrote: Hi, 2014-08-17 19:09 GMT+02:00 Christophe Gisquet christophe.gisq...@gmail.com: The raw coded bits are extracted prior to decorrelation, as is correctly performed by the decoder, and not after. Forgot to mention it

[FFmpeg-devel] [PATCH] lavd/v4l2: do not fail when VIDIOC_ENUMSTD returns ENODATA

2014-08-17 Thread Andre Wolokita
As of September 14 2012, v4l_enumstd() will return ENODATA when a device's std field is set to 0. That is, the device does not have a standard format. In order to properly handle this case, v4l2_set_parameters should catch the ENODATA code and break instead of failing. Below is the v4l2-core

Re: [FFmpeg-devel] [PATCH] lavd/v4l2: do not fail when VIDIOC_ENUMSTD returns ENODATA

2014-08-17 Thread Michael Niedermayer
On Mon, Aug 18, 2014 at 10:18:35AM +0800, Andre Wolokita wrote: As of September 14 2012, v4l_enumstd() will return ENODATA when a device's std field is set to 0. That is, the device does not have a standard format. In order to properly handle this case, v4l2_set_parameters should catch the

Re: [FFmpeg-devel] [PATCH] lavd/v4l2: do not fail when VIDIOC_ENUMSTD returns ENODATA

2014-08-17 Thread Andre Wolokita
Fixed parentheses mismatch. Signed-off-by: Andre Wolokita andre.wolok...@analog.com --- libavdevice/v4l2.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavdevice/v4l2.c b/libavdevice/v4l2.c index 64df0c7..fc87d6c 100644 --- a/libavdevice/v4l2.c +++