Re: [FFmpeg-devel] [PATCH] configure: create the tests directory like the doc directory

2014-12-14 Thread Dave Yeo
On 12/14/14 07:42 PM, Michael Niedermayer wrote: This fixes an issue where the tests directory is not created for out of tree builds before its needed Signed-off-by: Michael Niedermayer --- configure |1 + 1 file changed, 1 insertion(+) diff --git a/configure b/configure index 0ec1a7c..

Re: [FFmpeg-devel] [PATCH] lavfi: Port fspp to FFmpeg

2014-12-14 Thread arwa arif
> > > > + > > +DECLARE_ASM_CONST(8, uint64_t, MM_FIX_0_382683433) = > FIX64(0.382683433, 14); > > > +DECLARE_ALIGNED (8, uint64_t, ff_MM_FIX_0_541196100)= > FIX64(0.541196100, 14); > > +DECLARE_ALIGNED (8, uint64_t, ff_MM_FIX_0_707106781)= > FIX64(0.707106781, 14); > > these 2 conflict with the

Re: [FFmpeg-devel] [PATCH] lavu/frame: fix malloc error path in av_frame_copy_props()

2014-12-14 Thread Michael Niedermayer
On Mon, Dec 15, 2014 at 04:32:58AM +0100, wm4 wrote: > The error path frees all side data, but forgets to reset the side data > count. This can blow up later in av_frame_unref() and free_side_data(). > --- > libavutil/frame.c | 1 + > 1 file changed, 1 insertion(+) applied thanks [...] -- Mich

[FFmpeg-devel] [PATCH] configure: create the tests directory like the doc directory

2014-12-14 Thread Michael Niedermayer
This fixes an issue where the tests directory is not created for out of tree builds before its needed Signed-off-by: Michael Niedermayer --- configure |1 + 1 file changed, 1 insertion(+) diff --git a/configure b/configure index 0ec1a7c..3328026 100755 --- a/configure +++ b/configure @@ -57

[FFmpeg-devel] [PATCH] lavu/frame: fix malloc error path in av_frame_copy_props()

2014-12-14 Thread wm4
The error path frees all side data, but forgets to reset the side data count. This can blow up later in av_frame_unref() and free_side_data(). --- libavutil/frame.c | 1 + 1 file changed, 1 insertion(+) diff --git a/libavutil/frame.c b/libavutil/frame.c index 4ee0630..5c9aa29 100644 --- a/libavut

Re: [FFmpeg-devel] [PATCH]Set the default for --shlibdir to --libdir

2014-12-14 Thread Carl Eugen Hoyos
Ivan Kalvachev gmail.com> writes: > Please, commit your current patch. Merged by Michael. > BTW, another possible solution is to remove > --shlibdir entirely. Is that option even used/useful? Removing sounds like introducing a regression for no gain to me. Thank you, Carl Eugen ___

Re: [FFmpeg-devel] [PATCH]Fix leak reading invalid mxf files

2014-12-14 Thread Carl Eugen Hoyos
Tomas Härdin codemill.se> writes: > > New patch attached that also fixes the remaining > > leaks from ticket #4173. > > I would split in two parts, please tell me if > > you prefer more separate commits. > > Eh, it's small enough that it's clear what the > patch does. The patch was merged by

Re: [FFmpeg-devel] [PATCH]Set the default for --shlibdir to --libdir

2014-12-14 Thread Ivan Kalvachev
On 12/13/14, Carl Eugen Hoyos wrote: > Clément Bœsch pkh.me> writes: > >> > > > Attached patch fixes ticket #4183. > >> >--libdir=DIR install libs in DIR [PREFIX/lib] >> > - --shlibdir=DIR install shared libs in DIR [PREFIX/lib] >> > + --shlibdir=DIR install

Re: [FFmpeg-devel] [PATCH] lavfi: Port fspp to FFmpeg

2014-12-14 Thread Michael Niedermayer
On Sun, Dec 14, 2014 at 12:26:15PM +0530, arwa arif wrote: > I have tried to port fspp. Not sure, if it is correct or not. [...] > +static void filter(FSPPContext *p , uint8_t *dst , uint8_t *src, > + int dst_stride , int src_stride , > + int width , int height

[FFmpeg-devel] [PATCH] lavd/alsa-audio-common: dont crash while closing not opened device

2014-12-14 Thread Lukasz Marek
snd_pcm_close() doesn't handle NULL correctly. Signed-off-by: Lukasz Marek --- libavdevice/alsa-audio-common.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/libavdevice/alsa-audio-common.c b/libavdevice/alsa-audio-common.c index b7f5313..fff21a1 100644 --- a/libavdevice

Re: [FFmpeg-devel] [PATCH] avformat: add dump_metadata_lines

2014-12-14 Thread Michael Niedermayer
On Fri, Dec 12, 2014 at 12:13:29PM +0100, wm4 wrote: [...] > If you really want to reduce rampant code duplication, improve the API > so that you don't need tons of boilerplate to do ANYTHING. Basically, > most code examples should be tiny and simple, instead of big and buggy > like they are now.

Re: [FFmpeg-devel] [PATCH] cmdutils: dont call read_header before listing devices

2014-12-14 Thread Lukasz Marek
On 15.12.2014 00:33, Lukasz Marek wrote: List device callback must be able to return valid list without opening device. This callback should return input values for open function, not vice-versa. Read header funtion is very likey to fail without proper configuration provided. Signed-off-by: Luka

[FFmpeg-devel] [PATCH] cmdutils: dont call read_header before listing devices

2014-12-14 Thread Lukasz Marek
List device callback must be able to return valid list without opening device. This callback should return input values for open function, not vice-versa. Read header funtion is very likey to fail without proper configuration provided. Signed-off-by: Lukasz Marek --- cmdutils.c | 3 +-- 1 file c

Re: [FFmpeg-devel] [PATCH 2/2] lavd/avdevice: use better option types for caps options

2014-12-14 Thread Lukasz Marek
On 13.12.2014 23:11, Michael Niedermayer wrote: On Sat, Dec 13, 2014 at 08:27:08PM +0100, Lukasz Marek wrote: Using dedicated types allows to use format/layout names, not just raw int values. Signed-off-by: Lukasz Marek LGTM pushed this one. first from patchset dropped. __

Re: [FFmpeg-devel] [PATCH] cmdutils: use macros for device test

2014-12-14 Thread Lukasz Marek
On 13.12.2014 20:03, Michael Niedermayer wrote: On Sat, Dec 13, 2014 at 07:54:57PM +0100, Lukasz Marek wrote: Signed-off-by: Lukasz Marek --- cmdutils.c | 7 +-- 1 file changed, 1 insertion(+), 6 deletions(-) LGTM pushed ___ ffmpeg-devel m

Re: [FFmpeg-devel] [PATCH] lavd/alsa-audio-common: mark default device in device list

2014-12-14 Thread Lukasz Marek
On 14.12.2014 17:10, Nicolas George wrote: Le tridi 23 frimaire, an CCXXIII, Lukasz Marek a écrit : Signed-off-by: Lukasz Marek --- libavdevice/alsa-audio-common.c | 2 ++ 1 file changed, 2 insertions(+) Looks right, thanks. pushed ___ ffmpeg-

Re: [FFmpeg-devel] [PATCH]Fix leak reading invalid mxf files

2014-12-14 Thread Tomas Härdin
On Sat, 2014-12-13 at 13:18 +0100, Carl Eugen Hoyos wrote: > On Friday 12 December 2014 01:43:19 pm Tomas Härdin wrote: > > On Wed, 2014-12-10 at 11:30 +0100, Carl Eugen Hoyos wrote: > > > Hi! > > > > > > Attached patch fixes ticket #4173 for me. > > > To be split in two parts. > > > > > > Please c

[FFmpeg-devel] mjpeg2jpeg_filter

2014-12-14 Thread Don Moir
I needed to convert AVI1 to normal jpeg. This happens a lot with camera streams and the code in mjpeg2jpeg_filter works fine. I was looking at the code in mjpeg2jpeg_filter in file mjpeg2jpeg_bsf.c and noticing that just creates a constant array of bytes each time for the replacement header. U

Re: [FFmpeg-devel] [PATCH] lavd/alsa-audio-common: mark default device in device list

2014-12-14 Thread Nicolas George
Le tridi 23 frimaire, an CCXXIII, Lukasz Marek a écrit : > Signed-off-by: Lukasz Marek > --- > libavdevice/alsa-audio-common.c | 2 ++ > 1 file changed, 2 insertions(+) Looks right, thanks. Regards, -- Nicolas George signature.asc Description: Digital signature ___

Re: [FFmpeg-devel] [PATCH] avformat: Implement subtitle charenc guessing

2014-12-14 Thread Nicolas George
Le tridi 23 frimaire, an CCXXIII, Carl Eugen Hoyos a écrit : > Imo, if your distribution contains the libraries > but does not install them by default, it is a > good indication that we should not auto-detect > them. This is a matter of taste. FFmpeg has that policy, but MPlayer, on the other h

Re: [FFmpeg-devel] [PATCH] avformat: Implement subtitle charenc guessing

2014-12-14 Thread Nicolas George
Le tridi 23 frimaire, an CCXXIII, Rodger Combs a écrit : > I couldn't see a sensible way to do this in lavc, since the detector > libraries generally require more than one packet to work effectively. > Looking at that doxy again, I can see how the detection could be done in > lavf and the conversio

[FFmpeg-devel] [PATCH 2/2] Move AVSubtitle from lavc to lavu

2014-12-14 Thread Clément Bœsch
--- doc/APIchanges | 5 +++ libavcodec/avcodec.h | 63 +++--- libavcodec/utils.c | 29 +++--- libavcodec/version.h | 3 ++ libavutil/Makefile | 2 + libavutil/subtitle.c | 62 + libavutil/subtitle.h | 107 ++

[FFmpeg-devel] [PATCH 1/2] Move AVPicture definition from lavc to lavu

2014-12-14 Thread Clément Bœsch
This is necessary before moving AVSubtitle* structures. --- doc/APIchanges | 4 libavcodec/avcodec.h | 25 ++--- libavcodec/version.h | 2 +- libavutil/Makefile | 1 + libavutil/picture.h | 37 + libavutil/version.h | 2 +-

[FFmpeg-devel] (no subject)

2014-12-14 Thread Clément Bœsch
Hi, I'm moving the AVPicture structure to lavu because it's necessary for moving the AVSubtitle* structures. After the two patchs, the AVSubtitle are unchanged and available in libavutil with new functions: • AVSubtitle *av_subtitle_alloc(void); • void av_subtitle_get_defaults(AVSubtitle *sub);

Re: [FFmpeg-devel] [PATCH] lavfi: add colorlevels filter

2014-12-14 Thread Michael Niedermayer
On Wed, Dec 10, 2014 at 02:26:51PM +, Paul B Mahol wrote: > Signed-off-by: Paul B Mahol > --- > doc/filters.texi | 41 +++ > libavfilter/Makefile | 1 + > libavfilter/allfilters.c | 1 + > libavfilter/vf_colorlevels.c | 254 > +

Re: [FFmpeg-devel] [PATCH] avcodec/xiph: mark returned header pointers const from avpriv_split_xiph_headers()

2014-12-14 Thread Michael Niedermayer
On Sun, Dec 14, 2014 at 11:29:52AM +0100, Reimar Döffinger wrote: > On 12.12.2014, at 14:46, Michael Niedermayer wrote: > > Signed-off-by: Michael Niedermayer > > Should be fine. applied thanks [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB The educated dif

Re: [FFmpeg-devel] [PATCH] lavfi: Port fspp to FFmpeg

2014-12-14 Thread Carl Eugen Hoyos
arwa arif gmail.com> writes: > I have tried to port fspp. Not sure, if it is > correct or not. Did you compare the output of -vf fspp and -vf mp=fspp? > +av_cold void ff_fspp_init_x86(FSPPContext *s) > +{ > +#if HAVE_MMX_INLINE > +int cpu_flags = av_get_cpu_flags(); > + > +if (cpu_flag

Re: [FFmpeg-devel] [PATCH] avcodec/xiph: mark returned header pointers const from avpriv_split_xiph_headers()

2014-12-14 Thread Reimar Döffinger
On 12.12.2014, at 14:46, Michael Niedermayer wrote: > Signed-off-by: Michael Niedermayer Should be fine. ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel