Re: [FFmpeg-devel] [PATCHv4] flac: ignore duplicated ID3 tags if vorbis tags exist

2015-02-07 Thread Ben Boeckel
On Sun, 08 Feb, 2015 at 02:05:45 GMT, Michael Niedermayer wrote: > i tried clementine > it happily adds and edits id3 tags on ogg files, one has to rename > the file to .mp3 though. > So no problem as noone would be doing that if it wherent for a > small detail > clementine does not play ogg f

Re: [FFmpeg-devel] [PATCHv4] flac: ignore duplicated ID3 tags if vorbis tags exist

2015-02-07 Thread Ben Boeckel
On Sun, 08 Feb, 2015 at 02:07:28 GMT, Michael Niedermayer wrote: > iam not a user of EXPLODE but it seems most code using it checks no > other flags OK. Added locally. --Ben ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailma

Re: [FFmpeg-devel] [PATCH] x86/vp9dsp: fix clobbering of xmm6 on IDCT sse2 functions

2015-02-07 Thread James Almer
On 07/02/15 11:05 PM, Ronald S. Bultje wrote: > Hi, > > On Sat, Feb 7, 2015 at 8:33 PM, James Almer wrote: > >> Signed-off-by: James Almer >> --- >> libavcodec/x86/vp9itxfm.asm | 3 +++ >> 1 file changed, 3 insertions(+) >> >> diff --git a/libavcodec/x86/vp9itxfm.asm b/libavcodec/x86/vp9itxfm.

Re: [FFmpeg-devel] [PATCH 2/3] Fix Decklink for Mac

2015-02-07 Thread Michael Niedermayer
On Sun, Jan 11, 2015 at 03:38:46PM +0100, Georg Lippitsch wrote: > --- > libavdevice/decklink_common.cpp | 10 ++ > 1 file changed, 10 insertions(+) applied thanks [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB Into a blind darkness they enter who fol

Re: [FFmpeg-devel] [PATCH] 10 Bit support for Decklink input device

2015-02-07 Thread Michael Niedermayer
On Sun, Jan 18, 2015 at 08:44:33PM +0100, Georg Lippitsch wrote: > Example to capture video clip at 1080i50 10 bit: > ffmpeg -bm_v210 1 -f decklink -i 'UltraStudio Mini Recorder@11' -acodec copy > -vcodec copy output.avi > --- > libavdevice/decklink_common_c.h | 1 + > libavdevice/decklink_dec.c

Re: [FFmpeg-devel] [PATCH] libavformat/mxfenc.c: added mxf opatom muxer

2015-02-07 Thread Michael Niedermayer
On Wed, Jan 28, 2015 at 07:44:21PM -0800, Mark Reid wrote: > --- > libavformat/allformats.c | 1 + > libavformat/mxfenc.c | 139 > ++- > 2 files changed, 127 insertions(+), 13 deletions(-) applied please add a fate/regression test thanks [...]

Re: [FFmpeg-devel] [PATCH] avutil/ppc: Add macro defination of vector types and vector

2015-02-07 Thread Michael Niedermayer
On Sat, Feb 07, 2015 at 11:12:17AM +0800, Zhenan Lin wrote: > Hi, > > > > The attached patch add macro defination of vector types and vector base > types. Add function printv for dev purpose. Our team is working on AltiVec > functions for HEVC decoder. > > > > Best regards, > > Zhenan. >

Re: [FFmpeg-devel] [PATCH] x86/vp9dsp: fix clobbering of xmm6 on IDCT sse2 functions

2015-02-07 Thread James Almer
On 07/02/15 11:08 PM, James Almer wrote: > On 07/02/15 11:05 PM, Ronald S. Bultje wrote: >> Hi, >> >> On Sat, Feb 7, 2015 at 8:33 PM, James Almer wrote: >> >>> Signed-off-by: James Almer >>> --- >>> libavcodec/x86/vp9itxfm.asm | 3 +++ >>> 1 file changed, 3 insertions(+) >>> >>> diff --git a/lib

[FFmpeg-devel] [PATCH] avutil/ppc: Add macro defination of vector types and vector

2015-02-07 Thread Zhenan Lin
Hi, The attached patch add macro defination of vector types and vector base types. Add function printv for dev purpose. Our team is working on AltiVec functions for HEVC decoder. Best regards, Zhenan. avutil-ppc-Add-macro-defination-of-vector-types.patch Description: Binary data __

Re: [FFmpeg-devel] [PATCH] x86/vp9dsp: fix clobbering of xmm6 on IDCT sse2 functions

2015-02-07 Thread James Almer
On 07/02/15 11:05 PM, Ronald S. Bultje wrote: > Hi, > > On Sat, Feb 7, 2015 at 8:33 PM, James Almer wrote: > >> Signed-off-by: James Almer >> --- >> libavcodec/x86/vp9itxfm.asm | 3 +++ >> 1 file changed, 3 insertions(+) >> >> diff --git a/libavcodec/x86/vp9itxfm.asm b/libavcodec/x86/vp9itxfm.

Re: [FFmpeg-devel] [PATCHv4] flac: ignore duplicated ID3 tags if vorbis tags exist

2015-02-07 Thread Michael Niedermayer
On Sat, Feb 07, 2015 at 11:14:06PM +, Ben Boeckel wrote: > On Fri, 06 Feb, 2015 at 22:26:16 GMT, Michael Niedermayer wrote: > > hard erroring out with no atempt to somehow recover should probably > > only happen when AV_EF_EXPLODE is set unless its near certain that > > continuing is not possib

Re: [FFmpeg-devel] [PATCHv4] flac: ignore duplicated ID3 tags if vorbis tags exist

2015-02-07 Thread Michael Niedermayer
On Sat, Feb 07, 2015 at 11:14:07PM +, Ben Boeckel wrote: > On Fri, 06 Feb, 2015 at 19:46:39 GMT, wm4 wrote: > > Discussing this topic further, it seems id3v2 tags really can happen > > with literally almost any container format, including mp4 and ogg. Many > > of these formats will have the sam

Re: [FFmpeg-devel] [PATCH] x86/vp9dsp: fix clobbering of xmm6 on IDCT sse2 functions

2015-02-07 Thread Ronald S. Bultje
Hi, On Sat, Feb 7, 2015 at 8:33 PM, James Almer wrote: > Signed-off-by: James Almer > --- > libavcodec/x86/vp9itxfm.asm | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/libavcodec/x86/vp9itxfm.asm b/libavcodec/x86/vp9itxfm.asm > index 64859a0..bfe427f 100644 > --- a/libavcodec/x86/v

[FFmpeg-devel] [PATCH] x86/vp9dsp: fix clobbering of xmm6 on IDCT sse2 functions

2015-02-07 Thread James Almer
Signed-off-by: James Almer --- libavcodec/x86/vp9itxfm.asm | 3 +++ 1 file changed, 3 insertions(+) diff --git a/libavcodec/x86/vp9itxfm.asm b/libavcodec/x86/vp9itxfm.asm index 64859a0..bfe427f 100644 --- a/libavcodec/x86/vp9itxfm.asm +++ b/libavcodec/x86/vp9itxfm.asm @@ -407,6 +407,9 @@ IDCT_4x

Re: [FFmpeg-devel] [PATCHv4] flac: ignore duplicated ID3 tags if vorbis tags exist

2015-02-07 Thread Ben Boeckel
On Fri, 06 Feb, 2015 at 10:51:22 GMT, wm4 wrote: >> +av_dict_copy(&other_meta, s->metadata, 0); >> +av_dict_free(&s->metadata); > > Just swap these pointers? Done. --Ben ___ ffmpeg-devel mailing list ffmpeg-devel

Re: [FFmpeg-devel] [PATCHv4] flac: ignore duplicated ID3 tags if vorbis tags exist

2015-02-07 Thread Ben Boeckel
On Fri, 06 Feb, 2015 at 19:46:39 GMT, wm4 wrote: > Discussing this topic further, it seems id3v2 tags really can happen > with literally almost any container format, including mp4 and ogg. Many > of these formats will have the same problems. Well, it's only a problem if vorbis tags also exist sinc

Re: [FFmpeg-devel] [PATCHv4] flac: ignore duplicated ID3 tags if vorbis tags exist

2015-02-07 Thread Ben Boeckel
On Fri, 06 Feb, 2015 at 22:26:16 GMT, Michael Niedermayer wrote: > hard erroring out with no atempt to somehow recover should probably > only happen when AV_EF_EXPLODE is set unless its near certain that > continuing is not possible. (this may be the case for CRC errors in > critical headers) Shou

Re: [FFmpeg-devel] [PATCH 5/5] x86: hevc_mc: put_pixels and 1d epel for x86_32

2015-02-07 Thread Michael Niedermayer
On Sat, Feb 07, 2015 at 06:49:40PM +, Christophe Gisquet wrote: > Now that the xmm register and gpr count has decreased, it is > possible to port to x86_32. To save on code, x86_32 with or > without PIC is handled as if PIC. > --- > libavcodec/x86/hevc_mc.asm| 39 +++---

[FFmpeg-devel] [PATCH] x86/hevc_sao: make sao_band_filter work on x86_32

2015-02-07 Thread James Almer
Signed-off-by: James Almer --- libavcodec/x86/hevc_sao.asm | 40 libavcodec/x86/hevcdsp_init.c | 24 2 files changed, 48 insertions(+), 16 deletions(-) diff --git a/libavcodec/x86/hevc_sao.asm b/libavcodec/x86/hevc_sao.asm index

Re: [FFmpeg-devel] [PATCH]Read CbYCr dpx files

2015-02-07 Thread Michael Niedermayer
On Sat, Feb 07, 2015 at 06:38:17PM +, Carl Eugen Hoyos wrote: > Michael Niedermayer gmx.at> writes: > > > > Attached patch implements reading uyvy, yuv444 and > > > yuva444 dpx files, yuva444 is untested. > > > > how can this be tested ? > > I used the following to test: > $ gm convert inp

Re: [FFmpeg-devel] [PATCH]Enable pic on OSX for x86_64

2015-02-07 Thread Michael Niedermayer
On Sat, Feb 07, 2015 at 08:27:49PM +, Carl Eugen Hoyos wrote: > Ronald S. Bultje gmail.com> writes: > > > I'm not sure we should ever set -mdynamic-no-pic > > on Mac x86-64? > > My patch avoids it (but it gets ignored by > clang afaict). skiping the -mdynamic-no-pic check and addition on

Re: [FFmpeg-devel] [PATCH]Enable pic on OSX for x86_64

2015-02-07 Thread Carl Eugen Hoyos
Ronald S. Bultje gmail.com> writes: > I'm not sure we should ever set -mdynamic-no-pic > on Mac x86-64? My patch avoids it (but it gets ignored by clang afaict). Carl Eugen ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mai

Re: [FFmpeg-devel] [PATCH]Enable pic on OSX for x86_64

2015-02-07 Thread Ronald S. Bultje
Hi, On Sat, Feb 7, 2015 at 2:53 PM, Carl Eugen Hoyos wrote: > Michael Niedermayer gmx.at> writes: > > > > -enabled x86_64 && objformat="macho64" > > > +enabled x86_64 && objformat="macho64" && enable pic > > > enabled_any pic shared || > > > > can you explain what fails

Re: [FFmpeg-devel] [PATCH 0/5] x86: hevc_mc: some simd for x86_32

2015-02-07 Thread Michael Niedermayer
On Sat, Feb 07, 2015 at 07:55:13PM +0100, Christophe Gisquet wrote: > 2015-02-07 19:49 GMT+01:00 Christophe Gisquet : > > Christophe Gisquet (5): > > x86: hevc_mc: fewer gpr autoloads for _v filters > > x86: hevc_mc: remove lea in EPEL_LOAD > > x86: hevc_mc: save 1 gpr in epel filter loading

Re: [FFmpeg-devel] [PATCH]Enable pic on OSX for x86_64

2015-02-07 Thread Carl Eugen Hoyos
Michael Niedermayer gmx.at> writes: > > -enabled x86_64 && objformat="macho64" > > +enabled x86_64 && objformat="macho64" && enable pic > > enabled_any pic shared || > > can you explain what fails without this ? > > this: > check_cpp_condition stdlib.h "defined(__PIC__)

Re: [FFmpeg-devel] [PATCH]Enable pic on OSX for x86_64

2015-02-07 Thread Michael Niedermayer
On Sat, Feb 07, 2015 at 04:31:48PM +0100, Carl Eugen Hoyos wrote: > Hi! > > Attached patch allows compilation with icc on OSX. > > Please comment, Carl Eugen > configure |2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > 54159746713608d35cac3531e37dfaf386fbcf46 patchosxpic.diff > dif

Re: [FFmpeg-devel] [PATCH 0/5] x86: hevc_mc: some simd for x86_32

2015-02-07 Thread Christophe Gisquet
2015-02-07 19:49 GMT+01:00 Christophe Gisquet : > Christophe Gisquet (5): > x86: hevc_mc: fewer gpr autoloads for _v filters > x86: hevc_mc: remove lea in EPEL_LOAD > x86: hevc_mc: save 1 gpr in epel filter loading > x86: hevc_mc: fewer xmm regs used in epel h/v > x86: hevc_mc: put_pixels

[FFmpeg-devel] [PATCH 5/5] x86: hevc_mc: put_pixels and 1d epel for x86_32

2015-02-07 Thread Christophe Gisquet
Now that the xmm register and gpr count has decreased, it is possible to port to x86_32. To save on code, x86_32 with or without PIC is handled as if PIC. --- libavcodec/x86/hevc_mc.asm| 39 +++ libavcodec/x86/hevcdsp.h | 4 +++- libavcodec/x86/hevcdsp_init.c

[FFmpeg-devel] [PATCH 3/5] x86: hevc_mc: save 1 gpr in epel filter loading

2015-02-07 Thread Christophe Gisquet
The 3*stride value stored in r3src can be loaded much later, so use r3src instead of a dedicated gpr when possible. --- libavcodec/x86/hevc_mc.asm | 65 ++ 1 file changed, 31 insertions(+), 34 deletions(-) diff --git a/libavcodec/x86/hevc_mc.asm b/libav

[FFmpeg-devel] [PATCH 4/5] x86: hevc_mc: fewer xmm regs used in epel h/v

2015-02-07 Thread Christophe Gisquet
--- libavcodec/x86/hevc_mc.asm | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/libavcodec/x86/hevc_mc.asm b/libavcodec/x86/hevc_mc.asm index 74e08d4..a127a4d 100644 --- a/libavcodec/x86/hevc_mc.asm +++ b/libavcodec/x86/hevc_mc.asm @@ -734,7 +734,7 @@ cglobal hevc_p

[FFmpeg-devel] [PATCH 2/5] x86: hevc_mc: remove lea in EPEL_LOAD

2015-02-07 Thread Christophe Gisquet
The second parameter to the macro is always an immediate address, so no lea is needed. --- libavcodec/x86/hevc_mc.asm | 19 +++ 1 file changed, 7 insertions(+), 12 deletions(-) diff --git a/libavcodec/x86/hevc_mc.asm b/libavcodec/x86/hevc_mc.asm index f6dff4c..aab69dd 100644 --- a

[FFmpeg-devel] [PATCH 0/5] x86: hevc_mc: some simd for x86_32

2015-02-07 Thread Christophe Gisquet
The first 3 patches try to reduce GPR usage, while the fourth one reduces the xmm count. It's strange that this count was modified but not set to lower: I may be missing something here. The last one then uses them to have some MC SIMD for x86_32. That last patch is maybe not so worth it, as that'

[FFmpeg-devel] [PATCH 1/5] x86: hevc_mc: fewer gpr autoloads for _v filters

2015-02-07 Thread Christophe Gisquet
In that case, it's just to load my, but mx/r3src is not used. --- libavcodec/x86/hevc_mc.asm | 18 -- 1 file changed, 12 insertions(+), 6 deletions(-) diff --git a/libavcodec/x86/hevc_mc.asm b/libavcodec/x86/hevc_mc.asm index 3f56782..f6dff4c 100644 --- a/libavcodec/x86/hevc_mc.as

Re: [FFmpeg-devel] [PATCH]Read CbYCr dpx files

2015-02-07 Thread Carl Eugen Hoyos
Michael Niedermayer gmx.at> writes: > > Attached patch implements reading uyvy, yuv444 and > > yuva444 dpx files, yuva444 is untested. > > how can this be tested ? I used the following to test: $ gm convert input -colorspace Rec709YCbCr -sampling-factor 4:2:2 out1.dpx $ gm convert input -color

Re: [FFmpeg-devel] [PATCH] avfilter: add HRTF filter

2015-02-07 Thread James Almer
On 03/02/15 7:09 AM, Paul B Mahol wrote: > diff --git a/libavfilter/af_hrtf.h b/libavfilter/af_hrtf.h > new file mode 100644 > index 000..c810e66 > --- /dev/null > +++ b/libavfilter/af_hrtf.h > @@ -0,0 +1,550 @@ > +/* > + * Copyright (c) 2004 Yue Shi Lai > + * > + * This file is part of FFmpeg.

Re: [FFmpeg-devel] [PATCH]Read CbYCr dpx files

2015-02-07 Thread Michael Niedermayer
On Thu, Feb 05, 2015 at 12:42:28AM +0100, Carl Eugen Hoyos wrote: > Hi! > > Attached patch implements reading uyvy, yuv444 and yuva444 dpx files. > yuva444 is untested. how can this be tested ? [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB Why not whip the t

Re: [FFmpeg-devel] [PATCH] avfilter: add HRTF filter

2015-02-07 Thread Michael Niedermayer
On Tue, Feb 03, 2015 at 10:09:49AM +, Paul B Mahol wrote: > Signed-off-by: Paul B Mahol > --- > doc/filters.texi | 24 ++ > libavfilter/Makefile | 1 + > libavfilter/af_hrtf.c| 554 > +++ > libavfilter/af_hrtf.h| 550

Re: [FFmpeg-devel] Post-processing filter Documentation

2015-02-07 Thread Michael Niedermayer
On Sat, Feb 07, 2015 at 03:53:55PM +0530, arwa arif wrote: > On Mon, Feb 2, 2015 at 10:23 AM, Michael Niedermayer > wrote: > > > On Sat, Jan 31, 2015 at 02:30:29PM +0530, arwa arif wrote: > > > On Thu, Jan 29, 2015 at 5:18 PM, Stefano Sabatini > > > wrote: > > > > > > > On date Thursday 2015-01-

Re: [FFmpeg-devel] Adding Rollup support in Closed caption

2015-02-07 Thread Michael Niedermayer
On Sat, Feb 07, 2015 at 11:09:28AM +0530, Anshul wrote: > > On 02/07/2015 10:30 AM, Michael Niedermayer wrote: > >On Fri, Feb 06, 2015 at 08:22:40PM +0530, Anshul wrote: > >>On 01/30/2015 08:49 AM, Anshul wrote: > >>>On January 30, 2015 4:23:08 AM IST, Michael Niedermayer > >>>wrote: > @@ -4

Re: [FFmpeg-devel] [PATCH]Check mlv streams more completely

2015-02-07 Thread Carl Eugen Hoyos
Paul B Mahol gmail.com> writes: > Why I'm not allowed to see sample? Why don't you download the sample like everybody else did? Carl Eugen ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH] hevc/sao: do in-place band filtering when possible

2015-02-07 Thread Michael Niedermayer
On Sat, Feb 07, 2015 at 02:01:09AM -0300, James Almer wrote: > On 05/02/15 2:44 PM, Christophe Gisquet wrote: > > On the other hand, the stride is known at compilation time, so the asm > > could use that to reduce the number of gprs and therefore helps having > > a x86_32 version. > > I already ha

Re: [FFmpeg-devel] [PATCH]Check mlv streams more completely

2015-02-07 Thread Paul B Mahol
On 2/7/15, Carl Eugen Hoyos wrote: > Peter Ross xvid.org> writes: > >> On Wed, Feb 04, 2015 at 11:27:46PM +0100, Carl Eugen Hoyos wrote: >> > Hi! >> > >> > Attached patch fixes the crash from ticket #4296 for me. >> > >> > Please review, Carl Eugen >> >> LGTM. > > Patch applied. Why I'm not allo

Re: [FFmpeg-devel] [RFC] Exporting the alpha mode from decoders

2015-02-07 Thread Clément Bœsch
On Sat, Feb 07, 2015 at 04:32:02PM +0100, wm4 wrote: > On Sat, 7 Feb 2015 10:34:16 + (UTC) > Carl Eugen Hoyos wrote: > > > Carl Eugen Hoyos ag.or.at> writes: > > > > > wm4 googlemail.com> writes: > > > > > > > > I will fix this later if nobody beats me. > > > > > > > > How do you intend

Re: [FFmpeg-devel] [RFC] Exporting the alpha mode from decoders

2015-02-07 Thread Carl Eugen Hoyos
wm4 googlemail.com> writes: > AV_PIX_FMT_PAL8 is still inconsistent. It doesn't > have an alpha flag, but going by the doxygen, > it's implied that it can have alpha. The doxygen is correct afaict, I don't know the exact meaning of the alpha flag. Carl Eugen

Re: [FFmpeg-devel] [PATCH]Correctly read RLE encoding from dpx files

2015-02-07 Thread Carl Eugen Hoyos
Christophe Gisquet gmail.com> writes: > 2015-02-07 16:47 GMT+01:00 Carl Eugen Hoyos: > > Attached patch intends to fix reading the > > RLE-attribute from dpx files. > > I don't think this is valid. You are skipping > a byte, as if there was an additional element > to skip. But there is none.

Re: [FFmpeg-devel] [PATCH 6/7] x86: lavc: share more constant through defines

2015-02-07 Thread Michael Niedermayer
On Sat, Feb 07, 2015 at 04:13:15PM +0100, Christophe Gisquet wrote: > Hi, > > 2015-02-05 20:20 GMT+01:00 Christophe Gisquet : > > +%define pw_10 ff_pw_2048 > > Fixed in the attached patch. > > -- > Christophe > constants.c | 22 -- > constants.h

Re: [FFmpeg-devel] [PATCH]Correctly read RLE encoding from dpx files

2015-02-07 Thread Christophe Gisquet
Hi, 2015-02-07 16:47 GMT+01:00 Carl Eugen Hoyos : > Attached patch intends to fix reading the RLE-attribute from dpx files. I don't think this is valid. You are skipping a byte, as if there was an additional element to skip. But there is none. The bitstream is really: bits per component [1 byte]

[FFmpeg-devel] [PATCH]Correctly read RLE encoding from dpx files

2015-02-07 Thread Carl Eugen Hoyos
Hi! Attached patch intends to fix reading the RLE-attribute from dpx files. Please review, Carl Eugen diff --git a/libavcodec/dpx.c b/libavcodec/dpx.c index 3b78486..8584a03 100644 --- a/libavcodec/dpx.c +++ b/libavcodec/dpx.c @@ -136,6 +136,7 @@ static int decode_frame(AVCodecContext *avctx,

Re: [FFmpeg-devel] [RFC] Exporting the alpha mode from decoders

2015-02-07 Thread wm4
On Sat, 7 Feb 2015 10:34:16 + (UTC) Carl Eugen Hoyos wrote: > Carl Eugen Hoyos ag.or.at> writes: > > > wm4 googlemail.com> writes: > > > > > > I will fix this later if nobody beats me. > > > > > > How do you intend to beat this? > > > > Setting it to 0RGB32 instead of RGB32. > > This w

[FFmpeg-devel] [PATCH]Enable pic on OSX for x86_64

2015-02-07 Thread Carl Eugen Hoyos
Hi! Attached patch allows compilation with icc on OSX. Please comment, Carl Eugen diff --git a/configure b/configure index 0c209c5..c019cde 100755 --- a/configure +++ b/configure @@ -4068,7 +4068,7 @@ case $target_os in SLIBNAME_WITH_VERSION='$(SLIBPREF)$(FULLNAME).$(LIBVERSION)$(SLIBSUF

Re: [FFmpeg-devel] [PATCH]Check mlv streams more completely

2015-02-07 Thread Carl Eugen Hoyos
Peter Ross xvid.org> writes: > On Wed, Feb 04, 2015 at 11:27:46PM +0100, Carl Eugen Hoyos wrote: > > Hi! > > > > Attached patch fixes the crash from ticket #4296 for me. > > > > Please review, Carl Eugen > > LGTM. Patch applied. Thank you, Carl Eugen

Re: [FFmpeg-devel] [PATCH 7/7] x86: hevc: remove a parameter to WP internals

2015-02-07 Thread Christophe Gisquet
Hi, 2015-02-06 18:33 GMT+01:00 James Almer : > Yes, that should do it. > > And for that matter you were right, it should be "4, 6". I was reading it as > regs > loaded when the second argument is regs needed. Ok, here's an updated patch. I also fixed the unneeded mov on UNIX64, as height is alr

Re: [FFmpeg-devel] [PATCH 6/7] x86: lavc: share more constant through defines

2015-02-07 Thread Christophe Gisquet
Hi, 2015-02-05 20:20 GMT+01:00 Christophe Gisquet : > +%define pw_10 ff_pw_2048 Fixed in the attached patch. -- Christophe From 63a50c9fc6a053550d74435dd32ef6036b830f49 Mon Sep 17 00:00:00 2001 From: Christophe Gisquet Date: Wed, 4 Feb 2015 11:41:45 +0100 Subject: [PATCH 1/7] x86: lavc: share

[FFmpeg-devel] [PATCH] avcodec: remove vima decoder

2015-02-07 Thread Paul B Mahol
Signed-off-by: Paul B Mahol --- libavcodec/Makefile | 1 - libavcodec/allcodecs.c | 1 - libavcodec/avcodec.h| 1 - libavcodec/codec_desc.c | 7 --- libavcodec/vima.c | 10 -- 5 files changed, 20 deletions(-) diff --git a/libavcodec/Makefile b/libavcodec/Makefile i

Re: [FFmpeg-devel] [PATCH 2/2] lavc/lossless_audiodsp: revert various commits

2015-02-07 Thread Michael Niedermayer
On Sat, Feb 07, 2015 at 09:20:10AM +, Christophe Gisquet wrote: > Their intent was to make the DSP work with wmalossless pro. > The later was fixed to work with the DSP. > --- > libavcodec/lossless_audiodsp.h | 3 ++- > libavcodec/x86/lossless_audiodsp_init.c | 26 ++-

Re: [FFmpeg-devel] [PATCH 1/2] wmalossless: reset lms_update

2015-02-07 Thread Michael Niedermayer
On Sat, Feb 07, 2015 at 09:20:09AM +, Christophe Gisquet wrote: > It may contain garbage at the end, and zeroing allows using DSP > with longer loops. > --- > libavcodec/wmalosslessdec.c | 26 ++ > 1 file changed, 14 insertions(+), 12 deletions(-) applied thanks [...

Re: [FFmpeg-devel] [PATCH] pixdesc: Include more functions in FF_DISABLE_DEPRECATION_WARNINGS

2015-02-07 Thread Michael Niedermayer
On Fri, Feb 06, 2015 at 08:16:10PM -0800, Timothy Gu wrote: > --- > libavutil/pixdesc.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) applied thanks [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB If a bugfix only changes things apparently unrelated

Re: [FFmpeg-devel] [PATCH]Check mlv streams more completely

2015-02-07 Thread Paul B Mahol
On 2/7/15, Carl Eugen Hoyos wrote: > Paul B Mahol gmail.com> writes: > >> >> Attached patch fixes the crash from ticket #4296 for me. >> >> >> >> Please review, Carl Eugen >> > >> > what is link to file? >> > >> ping > > I don't understand your question. > Wasn't this answered multiple times in t

Re: [FFmpeg-devel] [PATCH 3/3] avutil/pixfmt: Clarify the meaning of the alpha bits in rgb444 and similar formats

2015-02-07 Thread Michael Niedermayer
On Fri, Feb 06, 2015 at 09:49:17PM +0100, wm4 wrote: > On Fri, 6 Feb 2015 20:57:50 +0100 > Michael Niedermayer wrote: > > > Signed-off-by: Michael Niedermayer > > --- > > libavutil/pixfmt.h |8 > > 1 file changed, 4 insertions(+), 4 deletions(-) > > > > diff --git a/libavutil/pix

Re: [FFmpeg-devel] [PATCH 1/3] avutil/pixfmt: Clarify the meaning of the alpha byte in RGB0 and similar formats

2015-02-07 Thread Michael Niedermayer
On Fri, Feb 06, 2015 at 08:57:48PM +0100, Michael Niedermayer wrote: > Found-by: wm4 > Signed-off-by: Michael Niedermayer applied with X instead of u and without the often thanks to all [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB It is what and why we do

Re: [FFmpeg-devel] [PATCH]Check mlv streams more completely

2015-02-07 Thread Peter Ross
On Wed, Feb 04, 2015 at 11:27:46PM +0100, Carl Eugen Hoyos wrote: > Hi! > > Attached patch fixes the crash from ticket #4296 for me. > > Please review, Carl Eugen LGTM. -- Peter (A907 E02F A6E5 0CD2 34CD 20D2 6760 79C5 AC40 DD6B) signature.asc Description: Digital signature __

Re: [FFmpeg-devel] [PATCH]Check mlv streams more completely

2015-02-07 Thread Carl Eugen Hoyos
Paul B Mahol gmail.com> writes: > >> Attached patch fixes the crash from ticket #4296 for me. > >> > >> Please review, Carl Eugen > > > > what is link to file? > > > ping I don't understand your question. Wasn't this answered multiple times in ticket #4296? Carl Eugen _

Re: [FFmpeg-devel] [PATCH] avutil/ppc: Add macro defination of vector types and vector

2015-02-07 Thread Carl Eugen Hoyos
Zhenan Lin live.cn> writes: > The attached patch add macro defination of vector > types and vector base types. Add function printv > for dev purpose. Our team is working on AltiVec > functions for HEVC decoder. Thank you for working on Altivec! Do you know why fate passes on your (?) server

Re: [FFmpeg-devel] [PATCH]Check mlv streams more completely

2015-02-07 Thread Paul B Mahol
On 2/5/15, Paul B Mahol wrote: > On 2/4/15, Carl Eugen Hoyos wrote: >> Hi! >> >> Attached patch fixes the crash from ticket #4296 for me. >> >> Please review, Carl Eugen >> > > what is link to file? > ping ___ ffmpeg-devel mailing list ffmpeg-devel@ffmp

Re: [FFmpeg-devel] [PATCH 1/3] avutil/pixfmt: Clarify the meaning of the alpha byte in RGB0 and similar formats

2015-02-07 Thread Carl Eugen Hoyos
Michael Niedermayer gmx.at> writes: > +AV_PIX_FMT_0RGB=0x123+4,///< packed RGB 8:8:8, > 32bpp, uRGBuRGB... u=unused/undefined (often 0) Why is "often 0" useful? Imo, removing it makes the doc clearer. I also prefer "X" because it is used in Kernal headers and similar. Thank you, Carl E

Re: [FFmpeg-devel] [RFC] Exporting the alpha mode from decoders

2015-02-07 Thread Carl Eugen Hoyos
Carl Eugen Hoyos ag.or.at> writes: > wm4 googlemail.com> writes: > > > > I will fix this later if nobody beats me. > > > > How do you intend to beat this? > > Setting it to 0RGB32 instead of RGB32. This was merged by Michael. If you find an issue with RGB555, please tell! Thank you for the

Re: [FFmpeg-devel] Post-processing filter Documentation

2015-02-07 Thread arwa arif
On Mon, Feb 2, 2015 at 10:23 AM, Michael Niedermayer wrote: > On Sat, Jan 31, 2015 at 02:30:29PM +0530, arwa arif wrote: > > On Thu, Jan 29, 2015 at 5:18 PM, Stefano Sabatini > > wrote: > > > > > On date Thursday 2015-01-29 03:46:42 +0530, Arwa Arif encoded: > > > > I have updated the page with

Re: [FFmpeg-devel] [PATCH 1/3] avutil/pixfmt: Clarify the meaning of the alpha byte in RGB0 and similar formats

2015-02-07 Thread Paul B Mahol
On 2/6/15, Michael Niedermayer wrote: > Found-by: wm4 > Signed-off-by: Michael Niedermayer > --- > libavutil/pixfmt.h |8 > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/libavutil/pixfmt.h b/libavutil/pixfmt.h > index ef1837f..9f4928e 100644 > --- a/libavutil/pixf

[FFmpeg-devel] [PATCH 1/2] wmalossless: reset lms_update

2015-02-07 Thread Christophe Gisquet
It may contain garbage at the end, and zeroing allows using DSP with longer loops. --- libavcodec/wmalosslessdec.c | 26 ++ 1 file changed, 14 insertions(+), 12 deletions(-) diff --git a/libavcodec/wmalosslessdec.c b/libavcodec/wmalosslessdec.c index e6e3476..557b6b9 10064

[FFmpeg-devel] [PATCH 2/2] lavc/lossless_audiodsp: revert various commits

2015-02-07 Thread Christophe Gisquet
Their intent was to make the DSP work with wmalossless pro. The later was fixed to work with the DSP. --- libavcodec/lossless_audiodsp.h | 3 ++- libavcodec/x86/lossless_audiodsp_init.c | 26 ++ 2 files changed, 4 insertions(+), 25 deletions(-) diff --git a/libav

[FFmpeg-devel] [PATCH 0/2] Let wmalossless use 16-wide DSPs

2015-02-07 Thread Christophe Gisquet
This is my take on the case order=8. If that's the only case where it is not a multiple of 16, then that's probably not worth it. The scalarproduct_and_madd_int16 originally required orders that are multiple of 16. wmalossless pro samples sometimes have an order of 8. The patchset first changes w