Re: [FFmpeg-devel] [PATCH 1/2] avutil/log: added av_log_format_line2 which returns buffer length

2016-04-25 Thread Michael Niedermayer
On Mon, Apr 25, 2016 at 08:32:23AM +0200, der_ghul...@ghulbus-inc.de wrote: > From: Andreas Weis > > The new function behaves the same as av_log_format_line, but also forwards > the return value from the underlying snprintf call. This will allow > callers to accurately

Re: [FFmpeg-devel] CONFIG_W64_DEMUXER and dead-code elimination

2016-04-25 Thread Matt Oliver
On 26 April 2016 at 01:49, Carl Eugen Hoyos wrote: > Matt Oliver gmail.com> writes: > > > Even so icl does also suffer from issues when using lto > > with optimised builds aswell so its not just limited to > > debug builds. > > Can you confirm that this is Windows-only, ie

Re: [FFmpeg-devel] [PATCH] qsvenc_hevc: Fix usage of ff_hevc_extract_rbsp

2016-04-25 Thread Michael Niedermayer
On Tue, Apr 26, 2016 at 12:00:16AM +0100, Derek Buitenhuis wrote: > On 4/25/2016 11:37 PM, Michael Niedermayer wrote: > > i cant easily test this but does this need a > > av_freep of skipped_bytes_pos somewhere ? > > > > otherwise it should be ok > > I cannot easily test it either,

Re: [FFmpeg-devel] [PATCH] qsvenc_hevc: Fix usage of ff_hevc_extract_rbsp

2016-04-25 Thread Derek Buitenhuis
On 4/25/2016 11:37 PM, Michael Niedermayer wrote: > i cant easily test this but does this need a > av_freep of skipped_bytes_pos somewhere ? > > otherwise it should be ok I cannot easily test it either, unfortunately. I'm not sure why it would, though (without having looked very hard). - Derek

Re: [FFmpeg-devel] [PATCH] qsvenc_hevc: Fix usage of ff_hevc_extract_rbsp

2016-04-25 Thread Michael Niedermayer
On Mon, Apr 25, 2016 at 08:04:44PM +0100, Derek Buitenhuis wrote: > Signed-off-by: Derek Buitenhuis > --- > grep reveals no other usages. > --- > libavcodec/qsvenc_hevc.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git

Re: [FFmpeg-devel] [PATCH] configure: Don't require nonfree for nvenc

2016-04-25 Thread Timo Rothenpieler
ping I'd really like some feedback on this. signature.asc Description: OpenPGP digital signature ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH] lavc/hevc_parse: Don't take a HEVCContext

2016-04-25 Thread Derek Buitenhuis
On 4/25/2016 7:50 PM, John Warburton wrote: > Is it possible that this patch, particularly to libavcodec/hevc.h, is > causing my compilation error today, cross-compiling using mingw-w64 > and gcc-5.3.0 from GNU/Linux to Windows 64-bit? Yes it looks as if qsv also called that, and I missed it. I

Re: [FFmpeg-devel] [PATCH] concatdec: Fix handling of H.264 in MP4 in case of "-auto_convert 0"

2016-04-25 Thread Andrey Utkin
On Mon, Apr 25, 2016 at 04:35:03PM +0200, Nicolas George wrote: > Thanks for sending it again. I find my version is simpler, and it is > probably closer to what it will look like when migrating to the new API. If > that is fine with you, I would like to push it. Your patch breaks a particular

Re: [FFmpeg-devel] [PATCH] lavc/hevc_parse: Don't take a HEVCContext

2016-04-25 Thread John Warburton
Is it possible that this patch, particularly to libavcodec/hevc.h, is causing my compilation error today, cross-compiling using mingw-w64 and gcc-5.3.0 from GNU/Linux to Windows 64-bit? libavcodec/qsvenc_hevc.c: In function 'generate_fake_vps': libavcodec/qsvenc_hevc.c:71:38: warning: passing

Re: [FFmpeg-devel] [PATCH] Backporting commits from head 1) commit hash 15ef98afd10b3696d29fb6d19606ba03a9dd47ad (configure: build fix for P5600 with mips code restructuring) 2) commit hash ad16eff64b

2016-04-25 Thread Michael Niedermayer
On Mon, Apr 25, 2016 at 03:40:28PM +0530, shivraj.pa...@imgtec.com wrote: > From: Shivraj Patil > > Signed-off-by: Shivraj Patil > --- > configure | 252 > ++ >

Re: [FFmpeg-devel] [PATCH v3 1/2] lavc/ccaption_dec: do not ignore repeated character commands

2016-04-25 Thread Thierry Foucu
On Tue, Apr 19, 2016 at 10:04 AM, Aman Gupta wrote: > This is a tricky one.. I tried your sample in VLC, and it has the same > issue as the latest version of ffmpeg. > > The previous behavior of ffmpeg can be restored with the following patch: > > diff --git

Re: [FFmpeg-devel] libavcodec/exr : Fix slice threading

2016-04-25 Thread James Almer
On 4/23/2016 8:46 AM, Martin Vignali wrote: > Hello, > > Patch in attach, fix slice threading (reported by James Almer in > "Libavcodec/exr : add support for tile" discussion) > the xsize and ysize are now in the thread data instead of exr context. > > Theses variables are used to store the real

Re: [FFmpeg-devel] [PATCH v2 01/12] lavc/videotoolboxenc: Use shared pixel buffer pool

2016-04-25 Thread Richard Kern
> On Apr 23, 2016, at 12:23 PM, Carl Eugen Hoyos wrote: > > Rick Kern gmail.com> writes: > >> +if(!*refPtr) return; > > Is this needed (I don't know)? > If yes, please make it two lines. > >> +CFRelease(*refPtr); >> +*refPtr = NULL; >> +switch (fmt) { >> +

Re: [FFmpeg-devel] [PATCH v2 03/12] lavc/videotoolboxenc: Require hardware encoding

2016-04-25 Thread Richard Kern
> On Apr 23, 2016, at 12:25 PM, Carl Eugen Hoyos wrote: > > Rick Kern gmail.com> writes: > >> +#if !TARGET_OS_IPHONE >> +{ "allow_sw", "Allow software encoding", OFFSET(allow_sw), > > I have no strong opinion, but shouldn't the option > always exist (but only work in

Re: [FFmpeg-devel] [PATCH] lavc/hevc_parse: Don't take a HEVCContext

2016-04-25 Thread Michael Niedermayer
On Mon, Apr 25, 2016 at 02:41:33PM +0100, Derek Buitenhuis wrote: > It's not even used anymore, and the checks are no longer > functionally important. > > Signed-off-by: Derek Buitenhuis > --- > libavcodec/hevc.c| 2 +- > libavcodec/hevc.h| 4 ++-- >

Re: [FFmpeg-devel] CONFIG_W64_DEMUXER and dead-code elimination

2016-04-25 Thread Derek Buitenhuis
On 4/25/2016 4:49 PM, Carl Eugen Hoyos wrote: > Can you confirm that this is Windows-only, ie that lto > works fine on Linux with the Intel compiler? > (It did work fine when I last tested.) FWIW, I've had issues with LTO on Linux, with clang and gold, due to (lack of) DCE. - Derek

Re: [FFmpeg-devel] [PATCH] libavcodec/qsvdec_h2645.c Bug fixed: wrong ticks_per_frame.

2016-04-25 Thread Hendrik Leppkes
On Mon, Apr 25, 2016 at 5:44 PM, Ivan Uskov wrote: > Hello Derek, > > Monday, April 25, 2016, 4:50:28 PM, you wrote: > > DB> On 4/25/2016 2:14 PM, Ivan Uskov wrote: >>> The attached patch does fixes the issue of frames duplication when >>> elementary h.264 stream

Re: [FFmpeg-devel] CONFIG_W64_DEMUXER and dead-code elimination

2016-04-25 Thread Carl Eugen Hoyos
Matt Oliver gmail.com> writes: > Even so icl does also suffer from issues when using lto > with optimised builds aswell so its not just limited to > debug builds. Can you confirm that this is Windows-only, ie that lto works fine on Linux with the Intel compiler? (It did work fine when I last

Re: [FFmpeg-devel] [PATCH] libavcodec/qsvdec_h2645.c Bug fixed: wrong ticks_per_frame.

2016-04-25 Thread Ivan Uskov
Hello Derek, Monday, April 25, 2016, 4:50:28 PM, you wrote: DB> On 4/25/2016 2:14 PM, Ivan Uskov wrote: >> The attached patch does fixes the issue of frames duplication when >> elementary h.264 stream decodes by qsvdec. DB> Could you perhaps elaborate in the commit message, and a code

Re: [FFmpeg-devel] CONFIG_W64_DEMUXER and dead-code elimination

2016-04-25 Thread Matt Oliver
On 25 April 2016 at 20:42, Michael Niedermayer wrote: > On Mon, Apr 25, 2016 at 06:17:22PM +1000, Matt Oliver wrote: > > On 23 April 2016 at 23:46, wm4 wrote: > > > > > On Sat, 23 Apr 2016 14:52:12 +0200 > > > Reimar Döffinger

Re: [FFmpeg-devel] [PATCH] concatdec: Fix handling of H.264 in MP4 in case of "-auto_convert 0"

2016-04-25 Thread Nicolas George
Le septidi 7 floréal, an CCXXIV, Andrey Utkin a écrit : > This is my patch which has stuck waiting for premoderation. > > - Forwarded message from Andrey Utkin - > > From: Andrey Utkin > To: ffmpeg-devel@ffmpeg.org > CC:

[FFmpeg-devel] [PATCH] lavc/hevc_parse: Don't take a HEVCContext

2016-04-25 Thread Derek Buitenhuis
It's not even used anymore, and the checks are no longer functionally important. Signed-off-by: Derek Buitenhuis --- libavcodec/hevc.c| 2 +- libavcodec/hevc.h| 4 ++-- libavcodec/hevc_parse.c | 11 +-- libavcodec/hevc_parser.c | 2 +- 4

Re: [FFmpeg-devel] [PATCH] libavcodec/qsvdec_h2645.c Bug fixed: wrong ticks_per_frame.

2016-04-25 Thread Derek Buitenhuis
On 4/25/2016 2:14 PM, Ivan Uskov wrote: > The attached patch does fixes the issue of frames duplication when > elementary h.264 stream decodes by qsvdec. Could you perhaps elaborate in the commit message, and a code comment, on why it must be 2? Where does that value come from, etc. -

[FFmpeg-devel] [PATCH] libavcodec/qsvdec.c: Restoring decoding functionality after unsuccessful merge from libav.

2016-04-25 Thread Ivan Uskov
Hello All, After commit d30cf57a7b2097b565db02ecfffbdc9c16423d0e qsv-based decoding aborts with crash, there are many incorrect places appeared. The attached patch fixes the issues but keeps new method of the 'sync' variable allocation introduced in commit

[FFmpeg-devel] [PATCH] concatdec: Fix handling of H.264 in MP4 in case of "-auto_convert 0"

2016-04-25 Thread Andrey Utkin
This is my patch which has stuck waiting for premoderation. - Forwarded message from Andrey Utkin - From: Andrey Utkin To: ffmpeg-devel@ffmpeg.org CC: andrey_ut...@fastmail.com, Carl Eugen Hoyos , Andrey Utkin

Re: [FFmpeg-devel] [PATCH] lavf/concatdec: remove unrelated change during codecpar merge.

2016-04-25 Thread Derek Buitenhuis
On 4/25/2016 1:09 PM, Nicolas George wrote: > Indeed, I had made a note to look into it, if only to silence the warnings, > and it seems the new API does the right thing. That will take a little time, > though, it would probably be better to have the fix immediately. I'm not opposed to it, as

Re: [FFmpeg-devel] [PATCH] lavf/concatdec: remove unrelated change during codecpar merge.

2016-04-25 Thread Nicolas George
Le septidi 7 floréal, an CCXXIV, Hendrik Leppkes a écrit : > concatdec should be converted to the new BSF API, which should clear > and/or replace the extradata itself then IIRC. Indeed, I had made a note to look into it, if only to silence the warnings, and it seems the new API does the right

Re: [FFmpeg-devel] [PATCH] lavf/concatdec: remove unrelated change during codecpar merge.

2016-04-25 Thread Hendrik Leppkes
On Mon, Apr 25, 2016 at 1:59 PM, Nicolas George wrote: > Le sextidi 6 floréal, an CCXXIV, Derek Buitenhuis a écrit : >> Removing this causes failures when concatdec is used to concat two H.264 >> streams from an MP4 source, when remuxed, IIRC. >> >> Example:

Re: [FFmpeg-devel] [PATCH] lavf/concatdec: remove unrelated change during codecpar merge.

2016-04-25 Thread Nicolas George
Le sextidi 6 floréal, an CCXXIV, Derek Buitenhuis a écrit : > Removing this causes failures when concatdec is used to concat two H.264 > streams from an MP4 source, when remuxed, IIRC. > > Example: https://trac.ffmpeg.org/raw-attachment/ticket/3108/examplefiles.zip > > ./ffmpeg -f concat -i

Re: [FFmpeg-devel] CONFIG_W64_DEMUXER and dead-code elimination

2016-04-25 Thread Hendrik Leppkes
On Mon, Apr 25, 2016 at 1:09 PM, Ronald S. Bultje wrote: > Hi, > > On Mon, Apr 25, 2016 at 1:17 AM, Matt Oliver wrote: > >> Obviously changing things would require a consensus from all the devs. >> Personally I would like to see the DCE stuff removed as

Re: [FFmpeg-devel] CONFIG_W64_DEMUXER and dead-code elimination

2016-04-25 Thread Ronald S. Bultje
Hi, On Mon, Apr 25, 2016 at 1:17 AM, Matt Oliver wrote: > Obviously changing things would require a consensus from all the devs. > Personally I would like to see the DCE stuff removed as currently as stated > debug or lto builds will fail with msvc and these are both

Re: [FFmpeg-devel] CONFIG_W64_DEMUXER and dead-code elimination

2016-04-25 Thread Michael Niedermayer
On Mon, Apr 25, 2016 at 06:17:22PM +1000, Matt Oliver wrote: > On 23 April 2016 at 23:46, wm4 wrote: > > > On Sat, 23 Apr 2016 14:52:12 +0200 > > Reimar Döffinger wrote: > > > > > On 23.04.2016, at 13:21, wm4 wrote: > > >

Re: [FFmpeg-devel] [PATCH] lavf/concatdec: remove unrelated change during codecpar merge.

2016-04-25 Thread Andrey Utkin
On Mon, Apr 25, 2016 at 08:58:40AM +0200, Nicolas George wrote: > Le sextidi 6 floréal, an CCXXIV, Andrey Utkin a écrit : > > Please look at my email in ffmpeg-devel > > '[PATCH] concatdec: Fix handling of H.264 in MP4 in case of "-auto_convert > > 0"' > > it adds a check which allows to

[FFmpeg-devel] [PATCH] Backporting commits from head 1) commit hash 15ef98afd10b3696d29fb6d19606ba03a9dd47ad (configure: build fix for P5600 with mips code restructuring) 2) commit hash ad16eff64ba78d

2016-04-25 Thread shivraj.patil
From: Shivraj Patil Signed-off-by: Shivraj Patil --- configure | 252 ++ libavcodec/mips/aaccoder_mips.c | 4 + libavcodec/mips/aacdec_mips.h | 2 +

Re: [FFmpeg-devel] CONFIG_W64_DEMUXER and dead-code elimination

2016-04-25 Thread Matt Oliver
On 23 April 2016 at 23:46, wm4 wrote: > On Sat, 23 Apr 2016 14:52:12 +0200 > Reimar Döffinger wrote: > > > On 23.04.2016, at 13:21, wm4 wrote: > > > > > On Sat, 23 Apr 2016 01:16:31 +0200 > > > Hendrik Leppkes

Re: [FFmpeg-devel] [PATCH] lavf/concatdec: remove unrelated change during codecpar merge.

2016-04-25 Thread Nicolas George
Le sextidi 6 floréal, an CCXXIV, Andrey Utkin a écrit : > Please look at my email in ffmpeg-devel > '[PATCH] concatdec: Fix handling of H.264 in MP4 in case of "-auto_convert 0"' > it adds a check which allows to correctly handle both cases. I will be able to look at this patch when it arrives,

[FFmpeg-devel] [PATCH 2/2] avutil/log: added test case for av_log_format_line2

2016-04-25 Thread der_ghulbus
From: Andreas Weis Signed-off-by: Andreas Weis --- libavutil/log.c | 30 ++ 1 file changed, 30 insertions(+) diff --git a/libavutil/log.c b/libavutil/log.c index 0efba7a..6d192b6 100644 --- a/libavutil/log.c +++

[FFmpeg-devel] [PATCH 1/2] avutil/log: added av_log_format_line2 which returns buffer length

2016-04-25 Thread der_ghulbus
From: Andreas Weis The new function behaves the same as av_log_format_line, but also forwards the return value from the underlying snprintf call. This will allow callers to accurately determine the size requirements for the line buffer. Signed-off-by: Andreas Weis