Re: [FFmpeg-devel] [PATCH 2/2] configure: instruct MSVC 2015 to properly process UTF-8 string literals

On 4 February 2017 at 02:32, Hendrik Leppkes wrote: > On Fri, Feb 3, 2017 at 3:05 PM, James Almer wrote: > > On 2/3/2017 5:41 AM, Hendrik Leppkes wrote: > >> Without the /UTF-8 switch, the MSVC compiler treats all files as in the > >> system codepage,

Re: [FFmpeg-devel] [PATCH] avcodec/flacdsp: Avoid undefined operations in non debug builds

On Thu, Dec 15, 2016 at 01:32:18AM +0100, Michael Niedermayer wrote: > This fixes ubsan warnings in non debug builds by using unsigned operations > > in debug builds the correct signed operations are retained so that overflows > (which should not occur in valid files and may indicate problems in

[FFmpeg-devel] [PATCH] ffplay: fix borderless mode on Windows

Signed-off-by: Marton Balint --- ffplay.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/ffplay.c b/ffplay.c index 6325e6f..1c9db73 100644 --- a/ffplay.c +++ b/ffplay.c @@ -1261,13 +1261,15 @@ static int video_open(VideoState *is) } if

Re: [FFmpeg-devel] [PATCH] avcodec/flacdec: Check for invalid vlcs

On Fri, Dec 09, 2016 at 04:29:35PM +0100, Michael Niedermayer wrote: > Signed-off-by: Michael Niedermayer > --- > libavcodec/flacdec.c | 8 +++- > 1 file changed, 7 insertions(+), 1 deletion(-) applied [...] -- Michael GnuPG fingerprint:

Re: [FFmpeg-devel] mp3 encoder audio quality

On Fri, Feb 3, 2017, at 02:20 PM, Lina Sharifi wrote: > Hi all, > I am trying to build an mp3 encoder( ffmpeg integrated with lame) in C++. > For some reason I am not receiving good quality output [...] ffmpeg-devel mailing list is only for submitting patches. libav-user is the correct mailing

Re: [FFmpeg-devel] [PATCH] lavf/matroskadec: fix is_keyframe for early Blocks

On Fri, Feb 3, 2017 at 2:42 PM, Chris Cunningham wrote: > Blocks are marked as key frames whenever the "reference" field is > zero. This breaks for non-keyframe Blocks with a reference timestamp > of zero. > > The likelihood of reference timestamp being zero is

[FFmpeg-devel] mp3 encoder audio quality

Hi all, I am trying to build an mp3 encoder( ffmpeg integrated with lame) in C++. For some reason I am not receiving good quality output. Here are the output samples: FFMPEG result: https://drive.google.com/file/d/0B9DbYNPuSyiRYTFzRmliNWxLcnM/view?usp=sharing Reference Sample:

Re: [FFmpeg-devel] [PATCH v3] avfilter/scale: refactor common code for scaling height/width expressions

On Wed, Feb 01, 2017 at 04:30:18PM -0800, Aman Gupta wrote: > From: Aman Gupta > > Implements support for height/width expressions in vf_scale_vaapi, > by refactoring common code into a new libavfilter/scale.c > --- > libavfilter/Makefile | 8 +-- > libavfilter/scale.c

[FFmpeg-devel] fixed vs floating point mp3 encoder

Hi, I am using ffmpeg integrated with libmp3lame for encoding (AV_CODEC_ID_MP3), Is there an option for to enable fixed point (integer) encoder? Probably a codec flag? Thanks, Lina ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org

Re: [FFmpeg-devel] [PATCH] avutil/hwcontext_vaapi: fix SEGV in vaTerminate when vaInitialize fails

On 03/02/17 22:44, Aman Gupta wrote: > On Fri, Feb 3, 2017 at 12:19 PM, Mark Thompson wrote: > >> On 03/02/17 05:45, wm4 wrote: >>> On Thu, 2 Feb 2017 09:29:13 -0800 >>> Aman Gupta wrote: >>> From: Aman Gupta Program terminated

[FFmpeg-devel] [PATCH] lavf/matroskadec: fix is_keyframe for early Blocks

Blocks are marked as key frames whenever the "reference" field is zero. This breaks for non-keyframe Blocks with a reference timestamp of zero. The likelihood of reference timestamp being zero is increased by a longstanding bug in muxing that encodes reference timestamp as the absolute time of

Re: [FFmpeg-devel] [PATCH] avutil/hwcontext_vaapi: fix SEGV in vaTerminate when vaInitialize fails

On Fri, Feb 3, 2017 at 12:19 PM, Mark Thompson wrote: > On 03/02/17 05:45, wm4 wrote: > > On Thu, 2 Feb 2017 09:29:13 -0800 > > Aman Gupta wrote: > > > >> From: Aman Gupta > >> > >> Program terminated with signal SIGSEGV, Segmentation fault. >

Re: [FFmpeg-devel] DVR MPEG4 variant (AS-3024)

2017-02-03 23:18 GMT+02:00 Compn : > On Fri, 3 Feb 2017 15:46:20 +0200, Ivo Andonov > wrote: > > > I successfully used a modified Pinetron library on Windows to use my own > > software for decoding the stream. While fiddling with the modification I > > saw

Re: [FFmpeg-devel] DVR MPEG4 variant (AS-3024)

On Fri, 3 Feb 2017 15:46:20 +0200, Ivo Andonov wrote: > I successfully used a modified Pinetron library on Windows to use my own > software for decoding the stream. While fiddling with the modification I > saw they are using the statically linked FFmpeg API. the dvr

Re: [FFmpeg-devel] [PATCH] avutil/hwcontext_vaapi: fix SEGV in vaTerminate when vaInitialize fails

On 03/02/17 05:45, wm4 wrote: > On Thu, 2 Feb 2017 09:29:13 -0800 > Aman Gupta wrote: > >> From: Aman Gupta >> >> Program terminated with signal SIGSEGV, Segmentation fault. >> opts=opts@entry=0x0, flags=flags@entry=0) at libavutil/hwcontext.c:494 >> --- >>

Re: [FFmpeg-devel] [PATCH] lavf/matroskadec: fix is_keyframe for early Blocks

On Fri, 3 Feb 2017 10:04:34 -0800 Vignesh Venkatasubramanian wrote: > On Thu, Feb 2, 2017 at 10:16 PM, wm4 wrote: > > On Thu, 2 Feb 2017 10:47:52 -0800 > > Vignesh Venkatasubramanian wrote: > > > >>

Re: [FFmpeg-devel] [PATCH] Efficiently support several output pixel formats in Cinepak decoder

On Fri, 3 Feb 2017 18:37:52 +0100 u-9...@aetey.se wrote: > On Fri, Feb 03, 2017 at 05:51:19PM +0100, Hendrik Leppkes wrote: > > On Fri, Feb 3, 2017 at 5:36 PM, wrote: > > > So get_format() is not a solution, mo matter how good or misleading > > > its documentation is. > >

Re: [FFmpeg-devel] [PATCH] lavf/matroskadec: fix is_keyframe for early Blocks

On Thu, Feb 2, 2017 at 10:16 PM, wm4 wrote: > On Thu, 2 Feb 2017 10:47:52 -0800 > Vignesh Venkatasubramanian wrote: > >> On Tue, Jan 31, 2017 at 10:18 PM, wm4 wrote: >> > >> > On Tue, 31 Jan 2017 12:02:01 -0800 >>

Re: [FFmpeg-devel] [PATCH] Efficiently support several output pixel formats in Cinepak decoder

On Fri, Feb 03, 2017 at 05:51:19PM +0100, Hendrik Leppkes wrote: > On Fri, Feb 3, 2017 at 5:36 PM, wrote: > > So get_format() is not a solution, mo matter how good or misleading > > its documentation is. > > "The application" can implement the get_format callback anyway it >

Re: [FFmpeg-devel] DVR MPEG4 variant (AS-3024)

2017-02-03 18:16 GMT+02:00 Carl Eugen Hoyos : > 2017-02-03 16:54 GMT+01:00 Ivo Andonov : > > 2017-02-03 16:59 GMT+02:00 Carl Eugen Hoyos : > > >> The encoder sets no user data, so identification is not as simple as > >> hoped: How do

Re: [FFmpeg-devel] [PATCH] matroskaenc: Add support for writing video projection.

On Fri, Feb 3, 2017 at 3:28 AM Vittorio Giovara wrote: > On Thu, Feb 2, 2017 at 9:34 PM, James Almer wrote: > > On 1/31/2017 12:40 PM, Aaron Colwell wrote: > >> > >> > >> On Tue, Jan 31, 2017 at 2:12 AM Vittorio Giovara < >

Re: [FFmpeg-devel] [PATCH] Efficiently support several output pixel formats in Cinepak decoder

On Fri, Feb 3, 2017 at 5:36 PM, wrote: > >> So, what I don't >> understand then, is why below you're claiming that get_format() doesn't do >> this. this is exactly what get_format() does. Why do you believe >> get_format() isn't capable of helping you accomplish this? > >

Re: [FFmpeg-devel] [PATCH] Efficiently support several output pixel formats in Cinepak decoder

Hello Ronald, On Fri, Feb 03, 2017 at 08:52:53AM -0500, Ronald S. Bultje wrote: > > I thought about generating the bodies of the functions from something > > like a template but it did not feel like this would make the code more > > understandable aka maintainable. So I wonder if there is any

Re: [FFmpeg-devel] DVR MPEG4 variant (AS-3024)

2017-02-03 16:54 GMT+01:00 Ivo Andonov : > 2017-02-03 16:59 GMT+02:00 Carl Eugen Hoyos : >> The encoder sets no user data, so identification is not as simple as >> hoped: How do subsequent frames start? Do you know what the >> first bytes mean? >> > Yes,

Re: [FFmpeg-devel] DVR MPEG4 variant (AS-3024)

2017-02-03 17:54 GMT+02:00 Ivo Andonov : > 2017-02-03 16:59 GMT+02:00 Carl Eugen Hoyos : > >> 2017-02-03 15:14 GMT+01:00 Ivo Andonov : >> > 2017-02-03 15:58 GMT+02:00 Carl Eugen Hoyos : >> >> >> > I've got some

Re: [FFmpeg-devel] DVR MPEG4 variant (AS-3024)

2017-02-03 16:59 GMT+02:00 Carl Eugen Hoyos : > 2017-02-03 15:14 GMT+01:00 Ivo Andonov : > > 2017-02-03 15:58 GMT+02:00 Carl Eugen Hoyos : > > >> > I've got some old Pinetron DVRs that are supposed to produce a MPEG4 > >> > bitstream.

Re: [FFmpeg-devel] [PATCH 2/2] configure: instruct MSVC 2015 to properly process UTF-8 string literals

On Fri, Feb 3, 2017 at 3:05 PM, James Almer wrote: > On 2/3/2017 5:41 AM, Hendrik Leppkes wrote: >> Without the /UTF-8 switch, the MSVC compiler treats all files as in the >> system codepage, instead of in UTF-8, which causes UTF-8 string literals >> to be interpreted wrong. >>

Re: [FFmpeg-devel] [PATCH v2] avformat/hlsenc: add hls_flag option to write segments to temporary file until complete

2017-02-02 8:28 GMT+08:00 Aman Gupta : > From: Aman Gupta > > Adds a `-hls_flags +temp_file` which will write segment data to > filename.tmp, and then rename to filename when the segment is complete. > > This patch is similar in spirit to one used in Plex's ffmpeg

Re: [FFmpeg-devel] [PATCH v2] avformat/hlsenc: add hls_flag option to write segments to temporary file until complete

2017-02-03 23:15 GMT+08:00 Steven Liu : > > > 2017-02-02 8:28 GMT+08:00 Aman Gupta : > >> From: Aman Gupta >> >> Adds a `-hls_flags +temp_file` which will write segment data to >> filename.tmp, and then rename to filename when the segment

Re: [FFmpeg-devel] DVR MPEG4 variant (AS-3024)

2017-02-03 15:14 GMT+01:00 Ivo Andonov : > 2017-02-03 15:58 GMT+02:00 Carl Eugen Hoyos : >> > I've got some old Pinetron DVRs that are supposed to produce a MPEG4 >> > bitstream. Indeed they are but no non-Pinetron software can decode it. >> >> Please

Re: [FFmpeg-devel] [PATCH] avcodec/dpxenc: support colour metadata in DPX encoder, fixes ticket #6023

2017-02-03 15:46 GMT+01:00 Vittorio Giovara : > if (priv_trc_opt = "") { Why is this useful? >if (avctx->color_trc == AVCOL_BT709) > buf[801] = DPX_BT709 >else if (avctx->color_trc == AVCOL_BT601) > buf[801] = DPX_BT601 I would suggest a switch()

Re: [FFmpeg-devel] [PATCH] avcodec/dpxenc: support colour metadata in DPX encoder, fixes ticket #6023

On Fri, Feb 3, 2017 at 2:10 PM, Kieran O Leary wrote: > Hi Vittorio! > > thanks for getting back to me. > > On Fri, Feb 3, 2017 at 12:57 PM, Vittorio Giovara > wrote: >> >> >> >> Hey Kieran, >> I think the code looks fine. I am just wondering

Re: [FFmpeg-devel] DVR MPEG4 variant (AS-3024)

2017-02-03 15:58 GMT+02:00 Carl Eugen Hoyos : > 2017-02-03 14:46 GMT+01:00 Ivo Andonov : > > This is my first post here. Actually my first post to a mailing list. > > Excuse me if this is the wrong place to write or if my mailing-list > culture > > is

Re: [FFmpeg-devel] [PATCH 2/2] configure: instruct MSVC 2015 to properly process UTF-8 string literals

On 2/3/2017 5:41 AM, Hendrik Leppkes wrote: > Without the /UTF-8 switch, the MSVC compiler treats all files as in the > system codepage, instead of in UTF-8, which causes UTF-8 string literals > to be interpreted wrong. > > This switch was only introduced in VS2015 Update 2, and any earlier >

Re: [FFmpeg-devel] [PATCH] doc: add a lexicon

On Tue, Jan 31, 2017 at 09:47:12AM -0900, Lou Logan wrote: > On Mon, 30 Jan 2017 15:58:12 +0100, Clément Bœsch wrote: > > > --- > > doc/lexicon | 23 +++ > > 1 file changed, 23 insertions(+) > > create mode 100644 doc/lexicon > > > > diff --git a/doc/lexicon b/doc/lexicon >

Re: [FFmpeg-devel] DVR MPEG4 variant (AS-3024)

2017-02-03 14:46 GMT+01:00 Ivo Andonov : > This is my first post here. Actually my first post to a mailing list. > Excuse me if this is the wrong place to write or if my mailing-list culture > is not complete! Remember not to top-post here. > I've got some old Pinetron

Re: [FFmpeg-devel] DVR MPEG4 variant (AS-3024)

On 2/3/17, Ivo Andonov wrote: > Hi Everyone, > > This is my first post here. Actually my first post to a mailing list. > Excuse me if this is the wrong place to write or if my mailing-list culture > is not complete! > > I've got some old Pinetron DVRs that are supposed to

[FFmpeg-devel] DVR MPEG4 variant (AS-3024)

Hi Everyone, This is my first post here. Actually my first post to a mailing list. Excuse me if this is the wrong place to write or if my mailing-list culture is not complete! I've got some old Pinetron DVRs that are supposed to produce a MPEG4 bitstream. Indeed they are but no non-Pinetron

Re: [FFmpeg-devel] [PATCH] Efficiently support several output pixel formats in Cinepak decoder

Hi Rune, On Fri, Feb 3, 2017 at 4:08 AM, wrote: > On Thu, Feb 02, 2017 at 11:16:35AM -0500, Ronald S. Bultje wrote: > > On Thu, Feb 2, 2017 at 10:59 AM, wrote: > > > It is the irregular differences between them which are the reason > > > for splitting. I would

Re: [FFmpeg-devel] [PATCH 1/2] configure: add nologo switch to invocation of lib.exe

2017-02-03 9:41 GMT+01:00 Hendrik Leppkes : > This suppresses the startup banner, which is consistent with all other calls > to the Windows SDK binaries. > if check_cmd lib.exe -list; then > -SLIB_EXTRA_CMD=-'sed -e "s/ @[^ ]*//"

Re: [FFmpeg-devel] [PATCH] avcodec/dpxenc: support colour metadata in DPX encoder, fixes ticket #6023

Vittorio Giovara wrote: >I think the code looks fine. I am just wondering if we >should also offer the possibility to set these flags from >the standard context options (-color_trc and others). I'm >aware that not all values match or are valid but maybe a >small conversion table or extending the

Re: [FFmpeg-devel] [PATCH] avcodec/dpxenc: support colour metadata in DPX encoder, fixes ticket #6023

Hi Vittorio! thanks for getting back to me. On Fri, Feb 3, 2017 at 12:57 PM, Vittorio Giovara < vittorio.giov...@gmail.com> wrote: > > > Hey Kieran, > I think the code looks fine. I am just wondering if we should also > offer the possibility to set these flags from the standard context >

Re: [FFmpeg-devel] [PATCH] avcodec/dpxenc: support colour metadata in DPX encoder, fixes ticket #6023

On Wed, Feb 1, 2017 at 1:42 PM, Kieran O Leary wrote: > Hello, > > I'm cc'ing Vittorio as I don't think that he's subscribed to the list but > he's contributed to dpxenc.c and recent colorspace filters. The same with > Kate Murray from the Library of Congress who knows a

Re: [FFmpeg-devel] [PATCH] matroskaenc: Add support for writing video projection.

On Thu, Feb 2, 2017 at 9:34 PM, James Almer wrote: > On 1/31/2017 12:40 PM, Aaron Colwell wrote: >> >> >> On Tue, Jan 31, 2017 at 2:12 AM Vittorio Giovara > > wrote: >> >> On Sat, Jan 28, 2017 at 4:13 AM, James

Re: [FFmpeg-devel] [PATCH] avutil/internal: Document ugly looking windows specific file related function renaming

On Thu, Feb 02, 2017 at 09:07:25AM +0100, wm4 wrote: > On Wed, 1 Feb 2017 22:24:14 +0100 > Michael Niedermayer wrote: > > > On Wed, Feb 01, 2017 at 03:26:45PM +0100, wm4 wrote: > > > On Wed, 1 Feb 2017 14:35:50 +0100 > > > Michael Niedermayer wrote: >

Re: [FFmpeg-devel] [PATCH] Efficiently support several output pixel formats in Cinepak decoder

On Fri, Feb 03, 2017 at 11:14:28AM +0100, wm4 wrote: > > On a 16-bit-per-pixel output with a CPU-based decoder you will > > not find _any_ over 25% of Cinepak speed. Raw video can not compete > > either when indata delivery bandwidth si limited. > > > > It has also an unused improvement margin in

Re: [FFmpeg-devel] [PATCH] Efficiently support several output pixel formats in Cinepak decoder

On Fri, 3 Feb 2017 10:46:12 +0100 u-9...@aetey.se wrote: > On Thu, Feb 02, 2017 at 05:52:29PM +0100, wm4 wrote: > > On Thu, 2 Feb 2017 16:59:51 +0100 > > u-9...@aetey.se wrote: > > The heavy code duplication has other downsides. What if someone fixes > > a bug, but only in the rgb32 version

Re: [FFmpeg-devel] [PATCH] Efficiently support several output pixel formats in Cinepak decoder

On Thu, Feb 02, 2017 at 05:52:29PM +0100, wm4 wrote: > On Thu, 2 Feb 2017 16:59:51 +0100 > u-9...@aetey.se wrote: > > On Thu, Feb 02, 2017 at 04:25:05PM +0100, wm4 wrote: > > > I can see how conversion in the decoder could speed it up somewhat > > I would not call "twice" for "somewhat" :) > >

Re: [FFmpeg-devel] [PATCH] Efficiently support several output pixel formats in Cinepak decoder

Hello Ronald, On Thu, Feb 02, 2017 at 11:16:35AM -0500, Ronald S. Bultje wrote: > On Thu, Feb 2, 2017 at 10:59 AM, wrote: > > It is the irregular differences between them which are the reason > > for splitting. I would not call this "duplication". If you feel > > it is

[FFmpeg-devel] [PATCH 1/2] configure: add nologo switch to invocation of lib.exe

This suppresses the startup banner, which is consistent with all other calls to the Windows SDK binaries. --- configure | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/configure b/configure index b22c8b3389..d3d652f0f4 100755 --- a/configure +++ b/configure @@ -4804,7 +4804,7

[FFmpeg-devel] [PATCH 2/2] configure: instruct MSVC 2015 to properly process UTF-8 string literals

Without the /UTF-8 switch, the MSVC compiler treats all files as in the system codepage, instead of in UTF-8, which causes UTF-8 string literals to be interpreted wrong. This switch was only introduced in VS2015 Update 2, and any earlier versions do not have an equivalent solution. Fixes