Re: [FFmpeg-devel] [PATCH 4/4] vp9: split out generic decoding skeleton interface API from VP9 types.

2017-03-27 Thread Ronald S. Bultje
Hi, On Mon, Mar 27, 2017 at 9:12 PM, Michael Niedermayer wrote: > On Mon, Mar 27, 2017 at 05:35:35PM -0400, Ronald S. Bultje wrote: > > This allows vp9dsp.h to only include the VP9 types header, and not the > > decoder skeleton interface which is for hardware decoders

[FFmpeg-devel] [PATCH] vp9: split out generic decoding skeleton interface API from VP9 types.

2017-03-27 Thread Ronald S. Bultje
This allows vp9dsp.h to only include the VP9 types header, and not the decoder skeleton interface which is for hardware decoders (dxva2/vaapi). --- libavcodec/arm/vp9dsp_init_16bpp_arm_template.c | 1 + libavcodec/arm/vp9dsp_init_arm.c| 1 + libavcodec/dxva2_vp9.c

Re: [FFmpeg-devel] [PATCH 4/4] vp9: split out generic decoding skeleton interface API from VP9 types.

2017-03-27 Thread Michael Niedermayer
On Mon, Mar 27, 2017 at 05:35:35PM -0400, Ronald S. Bultje wrote: > This allows vp9dsp.h to only include the VP9 types header, and not the > decoder skeleton interface which is for hardware decoders (dxva2/vaapi). > --- > libavcodec/dxva2_vp9.c | 2 +- > libavcodec/vaapi_vp9.c | 2 +- >

[FFmpeg-devel] [PATCH] libopus: Add channel mapping 2 support in libopusdec

2017-03-27 Thread Felicia Lim
Hi all, Here is another patch to decode Opus ambisonics files using channel mapping 2 [1], this time in libopusdec.c. Please let me know if there are any concerns. Thanks, Felicia [1] *https://trac.tools.ietf.org/html/draft-ietf-codec-ambisonics-02#section-3.1

Re: [FFmpeg-devel] [PATCH] avcodec/dnxhdenc: DNxHR 444 and HQX support

2017-03-27 Thread Mark Reid
On Mon, Mar 27, 2017 at 3:14 PM, Paul B Mahol wrote: > On 3/27/17, Paul B Mahol wrote: > > On 3/27/17, Mark Reid wrote: > >> On Mon, Mar 27, 2017 at 11:08 AM, Paul B Mahol > wrote: > >> > >>> Signed-off-by: Paul B Mahol

Re: [FFmpeg-devel] [Libav-user] New libav API usage axamples

2017-03-27 Thread Paolo Prete
Il Lunedì 27 Marzo 2017 10:05, Carl Eugen Hoyos ha scritto: 2017-03-27 9:11 GMT+02:00 Gabor Alsecz : > Thanks for the code snippet you have pasted here. Many of us > struggling here because lack of samples even based on the latest API. > I just can

Re: [FFmpeg-devel] [PATCH] h264: revert 1189af429211ac650aac730368a6cf5b23756605.

2017-03-27 Thread Michael Niedermayer
On Mon, Mar 27, 2017 at 10:26:38PM +0200, wm4 wrote: > On Mon, 27 Mar 2017 21:54:49 +0200 > Michael Niedermayer wrote: > > > On Mon, Mar 27, 2017 at 11:03:53AM -0400, Ronald S. Bultje wrote: > > > The patch introduces race conditions. > > > --- > > >

Re: [FFmpeg-devel] [PATCH 01/10] lavu: add av_fourcc_make_string() and av_4cc2str()

2017-03-27 Thread Alexander Strasser
Hi Clément, I think your idea of introducing this function and the convenience macro is good. Below are some comments, feel free to ignore. On 2017-03-27 09:51 +0200, Clément Bœsch wrote: > --- > doc/APIchanges | 4 > libavutil/avutil.h | 14 ++ > libavutil/utils.c

Re: [FFmpeg-devel] [PATCH] avcodec/dnxhdenc: DNxHR 444 and HQX support

2017-03-27 Thread Paul B Mahol
On 3/27/17, Paul B Mahol wrote: > On 3/27/17, Mark Reid wrote: >> On Mon, Mar 27, 2017 at 11:08 AM, Paul B Mahol wrote: >> >>> Signed-off-by: Paul B Mahol >>> --- >>> libavcodec/dnxhdenc.c | 227

Re: [FFmpeg-devel] [PATCH] movenc: Add support for writing st3d and sv3d boxes.

2017-03-27 Thread James Almer
On 3/27/2017 2:40 PM, Aaron Colwell wrote: > Made all suggested changes and attached a new patch. Thanks for the quick > review. > > Aaron Pushed with some small changes (restricting to mp4 mode and changing from experimental to unofficial strict level). Thanks.

Re: [FFmpeg-devel] [PATCH] ffprobe: Support adding av_log output to frames

2017-03-27 Thread Michael Niedermayer
On Mon, Dec 05, 2016 at 09:30:12AM +0100, Stefano Sabatini wrote: > On date Thursday 2016-12-01 22:21:17 +0100, Michael Niedermayer encoded: > > On Tue, Jun 14, 2016 at 05:55:47PM +0200, Stefano Sabatini wrote: > > > On date Wednesday 2016-06-08 18:20:39 +0200, Michael Niedermayer encoded: > > > >

Re: [FFmpeg-devel] [PATCH] avcodec/dnxhdenc: DNxHR 444 and HQX support

2017-03-27 Thread Paul B Mahol
On 3/27/17, Mark Reid wrote: > On Mon, Mar 27, 2017 at 11:08 AM, Paul B Mahol wrote: > >> Signed-off-by: Paul B Mahol >> --- >> libavcodec/dnxhdenc.c | 227 ++ >> +--- >> libavcodec/dnxhdenc.h |

Re: [FFmpeg-devel] [PATCH 2/2] avcodec/vorbisenc: Implement transient detection in Vorbis encoder

2017-03-27 Thread Rostislav Pehlivanov
On 27 March 2017 at 03:58, Tyler Jones wrote: > The existing AAC psychoacoustic system is used to detect transients within > the > vorbis encoder. This is useful, in general, as an initial step in later > utilizing > a complex psychoacoustic model for the vorbis encoder,

[FFmpeg-devel] [PATCH 4/4] vp9: split out generic decoding skeleton interface API from VP9 types.

2017-03-27 Thread Ronald S. Bultje
This allows vp9dsp.h to only include the VP9 types header, and not the decoder skeleton interface which is for hardware decoders (dxva2/vaapi). --- libavcodec/dxva2_vp9.c | 2 +- libavcodec/vaapi_vp9.c | 2 +- libavcodec/vp9.h | 145 +-

[FFmpeg-devel] [PATCH 3/4] vp9: split out reconstruction functions in their own source file.

2017-03-27 Thread Ronald S. Bultje
--- libavcodec/Makefile | 2 +- libavcodec/vp9_mc_template.c | 6 +- libavcodec/vp9block.c| 643 +-- libavcodec/vp9data.c | 10 + libavcodec/vp9data.h | 1 + libavcodec/vp9dec.h | 7 + libavcodec/vp9recon.c

[FFmpeg-devel] [PATCH 2/4] vp9: split out loopfilter functions in their own source file.

2017-03-27 Thread Ronald S. Bultje
--- libavcodec/Makefile | 2 +- libavcodec/vp9.c| 181 +- libavcodec/vp9dec.h | 3 + libavcodec/vp9lpf.c | 202 4 files changed, 208 insertions(+), 180 deletions(-) create mode 100644

[FFmpeg-devel] [PATCH 1/4] vp9: re-split the decoder/format/dsp interface header files.

2017-03-27 Thread Ronald S. Bultje
The advantage here is that the internal software decoder interface is not exposed to the DSP functions or the hardware accelerations. --- libavcodec/aarch64/vp9dsp_init.h| 2 +- libavcodec/aarch64/vp9dsp_init_aarch64.c| 2 +- libavcodec/arm/vp9dsp_init.h| 2

Re: [FFmpeg-devel] [PATCH] avcodec/dnxhdenc: DNxHR 444 and HQX support

2017-03-27 Thread Mark Reid
On Mon, Mar 27, 2017 at 11:08 AM, Paul B Mahol wrote: > Signed-off-by: Paul B Mahol > --- > libavcodec/dnxhdenc.c | 227 ++ > +--- > libavcodec/dnxhdenc.h | 6 +- > 2 files changed, 163 insertions(+), 70

Re: [FFmpeg-devel] [PATCH] h264: revert 1189af429211ac650aac730368a6cf5b23756605.

2017-03-27 Thread wm4
On Mon, 27 Mar 2017 21:54:49 +0200 Michael Niedermayer wrote: > On Mon, Mar 27, 2017 at 11:03:53AM -0400, Ronald S. Bultje wrote: > > The patch introduces race conditions. > > --- > > libavcodec/h264_slice.c | 3 --- > > libavcodec/h264dec.c| 24

Re: [FFmpeg-devel] [PATCH 1/3] lavfi/dynaudnorm: rename pow2 to pow_2

2017-03-27 Thread Paul B Mahol
On 3/27/17, Clement Boesch wrote: > On Sun, Mar 26, 2017 at 08:56:49PM +0200, Nicolas George wrote: >> Le sextidi 6 germinal, an CCXXV, Clement Boesch a ecrit : >> > This conflict with the DJGPP libc which includes a pow2 function^1 >> > >> > We can not make DJGPP posix only to avoid

Re: [FFmpeg-devel] [PATCH 1/3] lavfi/dynaudnorm: rename pow2 to pow_2

2017-03-27 Thread Clément Bœsch
On Sun, Mar 26, 2017 at 08:56:49PM +0200, Nicolas George wrote: > Le sextidi 6 germinal, an CCXXV, Clement Boesch a écrit : > > This conflict with the DJGPP libc which includes a pow2 function¹ > > > > We can not make DJGPP posix only to avoid the conflict due to the lack > > of posix_memalign. >

Re: [FFmpeg-devel] [PATCH] h264: revert 1189af429211ac650aac730368a6cf5b23756605.

2017-03-27 Thread Michael Niedermayer
On Mon, Mar 27, 2017 at 11:03:53AM -0400, Ronald S. Bultje wrote: > The patch introduces race conditions. > --- > libavcodec/h264_slice.c | 3 --- > libavcodec/h264dec.c| 24 > libavcodec/h264dec.h| 8 > 3 files changed, 35 deletions(-) As this reverts

[FFmpeg-devel] [PATCH] Fix all -Wformat warnings raised by DJGPP

2017-03-27 Thread Clément Bœsch
--- To be applied on top of the av_4cc2str() patchset. This is inspired by the next commit to merge from Libav which was done using the same method. --- ffmpeg.c | 2 +- ffprobe.c | 2 +- libavcodec/alsdec.c| 4 ++--

Re: [FFmpeg-devel] [PATCH] avcodec/dnxhdenc: DNxHR 444 and HQX support

2017-03-27 Thread Paul B Mahol
On 3/27/17, Rostislav Pehlivanov wrote: > On 27 March 2017 at 19:08, Paul B Mahol wrote: > >> Signed-off-by: Paul B Mahol >> --- >> libavcodec/dnxhdenc.c | 227 ++ >> +--- >>

Re: [FFmpeg-devel] [PATCH] avcodec/dnxhdenc: DNxHR 444 and HQX support

2017-03-27 Thread Rostislav Pehlivanov
On 27 March 2017 at 19:08, Paul B Mahol wrote: > Signed-off-by: Paul B Mahol > --- > libavcodec/dnxhdenc.c | 227 ++ > +--- > libavcodec/dnxhdenc.h | 6 +- > 2 files changed, 163 insertions(+), 70 deletions(-) >

[FFmpeg-devel] [PATCH] lavu/mem: clamp alignment to 16 for DJGPP

2017-03-27 Thread Clément Bœsch
See also https://gcc.gnu.org/bugzilla/show_bug.cgi?id=80208 --- libavutil/mem.h | 3 +++ 1 file changed, 3 insertions(+) diff --git a/libavutil/mem.h b/libavutil/mem.h index 718a143c4c..527cd03191 100644 --- a/libavutil/mem.h +++ b/libavutil/mem.h @@ -97,6 +97,9 @@ #define

[FFmpeg-devel] [PATCH] avcodec/dnxhdenc: DNxHR 444 and HQX support

2017-03-27 Thread Paul B Mahol
Signed-off-by: Paul B Mahol --- libavcodec/dnxhdenc.c | 227 +++--- libavcodec/dnxhdenc.h | 6 +- 2 files changed, 163 insertions(+), 70 deletions(-) diff --git a/libavcodec/dnxhdenc.c b/libavcodec/dnxhdenc.c index 33f25fb..6716b74

Re: [FFmpeg-devel] [PATCH] movenc: Add support for writing st3d and sv3d boxes.

2017-03-27 Thread Aaron Colwell
Made all suggested changes and attached a new patch. Thanks for the quick review. Aaron On Mon, Mar 27, 2017 at 10:00 AM James Almer wrote: > On 3/27/2017 1:02 PM, Aaron Colwell wrote: > > > > 0001-movenc-Add-support-for-writing-st3d-andsv3d-boxes.patch > > > > > > From

Re: [FFmpeg-devel] [PATCH 4/4] lavfi: remove af_asynts filter

2017-03-27 Thread Rostislav Pehlivanov
On 16 March 2017 at 07:02, Rostislav Pehlivanov wrote: > > > On 6 March 2017 at 20:47, Marton Balint wrote: > >> >> On Mon, 6 Mar 2017, Rostislav Pehlivanov wrote: >> >> Long overdue for removal, af_aresample should be used instead. >>> >>> Signed-off-by:

Re: [FFmpeg-devel] [PATCH] movenc: Add support for writing st3d and sv3d boxes.

2017-03-27 Thread James Almer
On 3/27/2017 1:02 PM, Aaron Colwell wrote: > > 0001-movenc-Add-support-for-writing-st3d-andsv3d-boxes.patch > > > From 8654212c2f2a3ee404020cf5b948d7db3e6270f2 Mon Sep 17 00:00:00 2001 > From: Aaron Colwell > Date: Mon, 27 Mar 2017 08:00:12 -0700 > Subject: [PATCH] movenc:

[FFmpeg-devel] [PATCH] movenc: Add support for writing st3d and sv3d boxes.

2017-03-27 Thread Aaron Colwell
From 8654212c2f2a3ee404020cf5b948d7db3e6270f2 Mon Sep 17 00:00:00 2001 From: Aaron Colwell Date: Mon, 27 Mar 2017 08:00:12 -0700 Subject: [PATCH] movenc: Add support for writing st3d and sv3d boxes. --- libavformat/movenc.c | 105

Re: [FFmpeg-devel] [PATCH 04/10] lavf: fix usages of av_get_codec_tag_string()

2017-03-27 Thread Clément Bœsch
On Mon, Mar 27, 2017 at 05:07:34PM +0200, Nicolas George wrote: > Le septidi 7 germinal, an CCXXV, Clement Boesch a écrit : > > No, I can't do that, av_4cc2str() creates a temporary anonymous buffer > > with a reduced lifetime. It can only live within the function call. > > I believe you are

Re: [FFmpeg-devel] [PATCH 2/3] lavfi/psnr: rename pow2 to pow_2

2017-03-27 Thread Ronald S. Bultje
Hi, On Sun, Mar 26, 2017 at 6:39 PM, Clément Bœsch wrote: > On Sun, Mar 26, 2017 at 06:17:57PM -0400, Ronald S. Bultje wrote: > [...] > > > I'll improve the message, but basically the djgpp libc can be > configured > > > to be POSIX only, where these functions functions and macro

Re: [FFmpeg-devel] [PATCH] dirac: make initialization of arithmetic coder tables threadsafe.

2017-03-27 Thread Ronald S. Bultje
Hi, On Mon, Mar 27, 2017 at 11:10 AM, Michael Niedermayer < mich...@niedermayer.cc> wrote: > On Mon, Mar 27, 2017 at 10:09:05AM -0400, Ronald S. Bultje wrote: > > --- > > libavcodec/dirac_arith.c | 17 +++-- > > libavcodec/dirac_arith.h | 1 + > > libavcodec/diracdec.c| 9

Re: [FFmpeg-devel] [PATCH] dirac: make initialization of arithmetic coder tables threadsafe.

2017-03-27 Thread Michael Niedermayer
On Mon, Mar 27, 2017 at 10:09:05AM -0400, Ronald S. Bultje wrote: > --- > libavcodec/dirac_arith.c | 17 +++-- > libavcodec/dirac_arith.h | 1 + > libavcodec/diracdec.c| 9 - > 3 files changed, 20 insertions(+), 7 deletions(-) > > diff --git a/libavcodec/dirac_arith.c

Re: [FFmpeg-devel] [PATCH 04/10] lavf: fix usages of av_get_codec_tag_string()

2017-03-27 Thread Nicolas George
Le septidi 7 germinal, an CCXXV, Clement Boesch a écrit : > No, I can't do that, av_4cc2str() creates a temporary anonymous buffer > with a reduced lifetime. It can only live within the function call. I believe you are mistaken: # it has automatic storage duration associated with the enclosing

Re: [FFmpeg-devel] [PATCH] h264: revert 1189af429211ac650aac730368a6cf5b23756605.

2017-03-27 Thread Ronald S. Bultje
Hi, On Mon, Mar 27, 2017 at 10:49 AM, Michael Niedermayer < mich...@niedermayer.cc> wrote: > On Mon, Mar 27, 2017 at 09:39:32AM -0400, Ronald S. Bultje wrote: > > The patch introduces race conditions. > > --- > > libavcodec/h264_slice.c | 3 --- > > libavcodec/h264dec.c| 20

[FFmpeg-devel] [PATCH] h264: revert 1189af429211ac650aac730368a6cf5b23756605.

2017-03-27 Thread Ronald S. Bultje
The patch introduces race conditions. --- libavcodec/h264_slice.c | 3 --- libavcodec/h264dec.c| 24 libavcodec/h264dec.h| 8 3 files changed, 35 deletions(-) diff --git a/libavcodec/h264_slice.c b/libavcodec/h264_slice.c index a703853..fa1e9ae 100644

Re: [FFmpeg-devel] [PATCH 04/10] lavf: fix usages of av_get_codec_tag_string()

2017-03-27 Thread Clément Bœsch
On Mon, Mar 27, 2017 at 11:59:05AM -0300, James Almer wrote: > On 3/27/2017 11:50 AM, Clément Bœsch wrote: > > On Mon, Mar 27, 2017 at 11:35:41AM -0300, James Almer wrote: > > [...] > >>> -char tag_buf[32]; > >>> - > >>> -av_get_codec_tag_string(tag_buf, sizeof(tag_buf), > >>>

Re: [FFmpeg-devel] [PATCH] h264: revert 1189af429211ac650aac730368a6cf5b23756605.

2017-03-27 Thread Ronald S. Bultje
Hi, On Mon, Mar 27, 2017 at 9:49 AM, wm4 wrote: > On Mon, 27 Mar 2017 09:39:32 -0400 > "Ronald S. Bultje" wrote: > > > The patch introduces race conditions. > > --- > > libavcodec/h264_slice.c | 3 --- > > libavcodec/h264dec.c| 20

Re: [FFmpeg-devel] [PATCH 04/10] lavf: fix usages of av_get_codec_tag_string()

2017-03-27 Thread James Almer
On 3/27/2017 11:50 AM, Clément Bœsch wrote: > On Mon, Mar 27, 2017 at 11:35:41AM -0300, James Almer wrote: > [...] >>> -char tag_buf[32]; >>> - >>> -av_get_codec_tag_string(tag_buf, sizeof(tag_buf), par->codec_tag); >> >> char *tag_buf = av_4cc2str(par->codec_tag); and keep the two

Re: [FFmpeg-devel] [PATCH 01/10] lavu: add av_fourcc_make_string() and av_4cc2str()

2017-03-27 Thread Clément Bœsch
On Mon, Mar 27, 2017 at 11:16:24AM -0300, James Almer wrote: > On 3/27/2017 4:51 AM, Clément Bœsch wrote: > > --- > > doc/APIchanges | 4 > > libavutil/avutil.h | 14 ++ > > libavutil/utils.c | 21 + > > libavutil/version.h | 2 +- > > 4 files

Re: [FFmpeg-devel] [PATCH] dirac: make initialization of arithmetic coder tables threadsafe.

2017-03-27 Thread wm4
On Mon, 27 Mar 2017 10:09:05 -0400 "Ronald S. Bultje" wrote: > --- > libavcodec/dirac_arith.c | 17 +++-- > libavcodec/dirac_arith.h | 1 + > libavcodec/diracdec.c| 9 - > 3 files changed, 20 insertions(+), 7 deletions(-) > > diff --git

Re: [FFmpeg-devel] [PATCH 04/10] lavf: fix usages of av_get_codec_tag_string()

2017-03-27 Thread Clément Bœsch
On Mon, Mar 27, 2017 at 11:35:41AM -0300, James Almer wrote: [...] > > -char tag_buf[32]; > > - > > -av_get_codec_tag_string(tag_buf, sizeof(tag_buf), par->codec_tag); > > char *tag_buf = av_4cc2str(par->codec_tag); and keep the two line below > unchanged. > No, I can't do that,

Re: [FFmpeg-devel] [PATCH] h264: revert 1189af429211ac650aac730368a6cf5b23756605.

2017-03-27 Thread Michael Niedermayer
On Mon, Mar 27, 2017 at 09:39:32AM -0400, Ronald S. Bultje wrote: > The patch introduces race conditions. > --- > libavcodec/h264_slice.c | 3 --- > libavcodec/h264dec.c| 20 > libavcodec/h264dec.h| 8 > 3 files changed, 31 deletions(-) This seems to break

Re: [FFmpeg-devel] [PATCH 02/10] lavc: deprecate av_get_codec_tag_string()

2017-03-27 Thread Clément Bœsch
On Mon, Mar 27, 2017 at 04:34:18PM +0200, wm4 wrote: > On Mon, 27 Mar 2017 09:51:55 +0200 > Clément Bœsch wrote: > > > --- > > libavcodec/avcodec.h | 5 + > > libavcodec/version.h | 3 +++ > > 2 files changed, 8 insertions(+) > > > > diff --git a/libavcodec/avcodec.h

Re: [FFmpeg-devel] [PATCH 02/10] lavc: deprecate av_get_codec_tag_string()

2017-03-27 Thread wm4
On Mon, 27 Mar 2017 09:51:55 +0200 Clément Bœsch wrote: > --- > libavcodec/avcodec.h | 5 + > libavcodec/version.h | 3 +++ > 2 files changed, 8 insertions(+) > > diff --git a/libavcodec/avcodec.h b/libavcodec/avcodec.h > index 4f3303366f..5c891b531a 100644 > ---

Re: [FFmpeg-devel] [PATCH 04/10] lavf: fix usages of av_get_codec_tag_string()

2017-03-27 Thread James Almer
On 3/27/2017 4:51 AM, Clément Bœsch wrote: > --- > libavformat/aiffdec.c | 8 +++- > libavformat/apngdec.c | 8 ++-- > libavformat/avidec.c | 8 ++-- > libavformat/matroskadec.c | 7 ++- > libavformat/movenc.c | 6 +- > libavformat/mux.c | 7 +++ >

Re: [FFmpeg-devel] [PATCH] dirac: make initialization of arithmetic coder tables threadsafe.

2017-03-27 Thread Rostislav Pehlivanov
On 27 March 2017 at 15:09, Ronald S. Bultje wrote: > --- > libavcodec/dirac_arith.c | 17 +++-- > libavcodec/dirac_arith.h | 1 + > libavcodec/diracdec.c| 9 - > 3 files changed, 20 insertions(+), 7 deletions(-) > > diff --git

Re: [FFmpeg-devel] [PATCH 01/10] lavu: add av_fourcc_make_string() and av_4cc2str()

2017-03-27 Thread James Almer
On 3/27/2017 4:51 AM, Clément Bœsch wrote: > --- > doc/APIchanges | 4 > libavutil/avutil.h | 14 ++ > libavutil/utils.c | 21 + > libavutil/version.h | 2 +- > 4 files changed, 40 insertions(+), 1 deletion(-) > > diff --git a/doc/APIchanges

[FFmpeg-devel] [PATCH] dirac: make initialization of arithmetic coder tables threadsafe.

2017-03-27 Thread Ronald S. Bultje
--- libavcodec/dirac_arith.c | 17 +++-- libavcodec/dirac_arith.h | 1 + libavcodec/diracdec.c| 9 - 3 files changed, 20 insertions(+), 7 deletions(-) diff --git a/libavcodec/dirac_arith.c b/libavcodec/dirac_arith.c index bf91392..49c0909 100644 ---

[FFmpeg-devel] [PATCH] h264: revert 1189af429211ac650aac730368a6cf5b23756605.

2017-03-27 Thread Ronald S. Bultje
The patch introduces race conditions. --- libavcodec/h264_slice.c | 3 --- libavcodec/h264dec.c| 20 libavcodec/h264dec.h| 8 3 files changed, 31 deletions(-) diff --git a/libavcodec/h264_slice.c b/libavcodec/h264_slice.c index a703853..fa1e9ae 100644 ---

[FFmpeg-devel] [PATCH] hevc: initialize no_rasl_output_flag in hevc_frame_start().

2017-03-27 Thread Ronald S. Bultje
This prevents a race condition in files with multiple slices per frame. --- libavcodec/hevc.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/libavcodec/hevc.c b/libavcodec/hevc.c index 505249e..bfe2386 100644 --- a/libavcodec/hevc.c +++ b/libavcodec/hevc.c @@ -825,8

Re: [FFmpeg-devel] [PATCH] h264: revert 1189af429211ac650aac730368a6cf5b23756605.

2017-03-27 Thread wm4
On Mon, 27 Mar 2017 09:39:32 -0400 "Ronald S. Bultje" wrote: > The patch introduces race conditions. > --- > libavcodec/h264_slice.c | 3 --- > libavcodec/h264dec.c| 20 > libavcodec/h264dec.h| 8 > 3 files changed, 31 deletions(-) >

Re: [FFmpeg-devel] [PATCH] rtmpproto: send swfverify value as swfurl if latter is unused

2017-03-27 Thread Ricardo Constantino
On 27 March 2017 at 00:15, Michael Niedermayer wrote: > On Mon, Mar 20, 2017 at 08:22:51PM +, Ricardo Constantino wrote: > > Replicates lavf/librtmp.c behavior in L149-156 and rtmpdump's > > behavior with "--swfVfy " passing the url to swfUrl. > > > > Fixes trac

Re: [FFmpeg-devel] [PATCH 2/2] avcodec/vorbisenc: Implement transient detection in Vorbis encoder

2017-03-27 Thread Michael Niedermayer
On Sun, Mar 26, 2017 at 08:58:33PM -0600, Tyler Jones wrote: > The existing AAC psychoacoustic system is used to detect transients within the > vorbis encoder. This is useful, in general, as an initial step in later > utilizing > a complex psychoacoustic model for the vorbis encoder, but more

[FFmpeg-devel] [PATCH] pthread_frame: minor simplification to error handling

2017-03-27 Thread wm4
Get rid of the "ret" variable, and always use err. Report the packet as consumed if err is unset. This should be equivalent to the old code, which obviously required err=0 for p->result>=0 (and otherwise, p->result must have had the value err was last set to). The code block added by commit

Re: [FFmpeg-devel] [PATCH]lavc/h264_ps: Check chroma_location limits

2017-03-27 Thread wm4
On Mon, 27 Mar 2017 13:29:35 +0200 Carl Eugen Hoyos wrote: > 2017-03-27 11:40 GMT+02:00 wm4 : > > On Mon, 27 Mar 2017 09:31:39 +0200 > > Carl Eugen Hoyos wrote: > > > >> 2017-03-24 15:16 GMT+01:00 Ronald S. Bultje

Re: [FFmpeg-devel] [PATCH]lavc/h264_ps: Check chroma_location limits

2017-03-27 Thread Carl Eugen Hoyos
2017-03-27 11:40 GMT+02:00 wm4 : > On Mon, 27 Mar 2017 09:31:39 +0200 > Carl Eugen Hoyos wrote: > >> 2017-03-24 15:16 GMT+01:00 Ronald S. Bultje : >> In addition, giving the fact that you seem (?) to have stopped >> contributing may

Re: [FFmpeg-devel] [PATCH v3] avformat, ffmpeg: deprecate old rotation API

2017-03-27 Thread wm4
On Sat, 25 Mar 2017 12:28:26 +0100 wm4 wrote: > The old "API" that signaled rotation as a metadata value has been > replaced by DISPLAYMATRIX side data quite a while ago. > > There is no reason to make muxers/demuxers/API users support both. In > addition, the metadata

Re: [FFmpeg-devel] [PATCH] pthread_frame: do not attempt to unlock a mutex on the wrong thread

2017-03-27 Thread wm4
On Sat, 25 Mar 2017 13:25:32 +0100 Michael Niedermayer wrote: > On Sat, Mar 25, 2017 at 01:13:13PM +0100, wm4 wrote: > > On Sat, 25 Mar 2017 13:01:58 +0100 > > Michael Niedermayer wrote: > > > > > On Sat, Mar 25, 2017 at 12:03:23PM +0100, wm4

Re: [FFmpeg-devel] [PATCH]lavc/h264_ps: Check chroma_location limits

2017-03-27 Thread Paul B Mahol
On 3/27/17, Carl Eugen Hoyos wrote: > 2017-03-24 15:16 GMT+01:00 Ronald S. Bultje : >> There is also the risk with the initial patch that compiling libavcodec >> against a newer libavutil but then runtime linking it with another (older) >> one would lead to

Re: [FFmpeg-devel] [PATCH]lavc/h264_ps: Check chroma_location limits

2017-03-27 Thread wm4
On Mon, 27 Mar 2017 09:31:39 +0200 Carl Eugen Hoyos wrote: > 2017-03-24 15:16 GMT+01:00 Ronald S. Bultje : > > There is also the risk with the initial patch that compiling libavcodec > > against a newer libavutil but then runtime linking it with another

Re: [FFmpeg-devel] [PATCH] avcodec/avcodec: Correct and make consistent AVERROR() in comments

2017-03-27 Thread wm4
On Sun, 26 Mar 2017 21:17:54 +0200 Michael Niedermayer wrote: > Signed-off-by: Michael Niedermayer > --- > libavcodec/avcodec.h | 8 > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/libavcodec/avcodec.h

Re: [FFmpeg-devel] [PATCH]lavc/dxva2: Use correct type specifier for HRESULT

2017-03-27 Thread Clément Bœsch
On Mon, Mar 27, 2017 at 10:57:44AM +0200, Hendrik Leppkes wrote: > On Mon, Mar 27, 2017 at 9:54 AM, Carl Eugen Hoyos wrote: > > 2017-03-27 9:52 GMT+02:00 Carl Eugen Hoyos : > >> Hi! > >> > >> This is untested, sorry if this not wanted / plain wrong. > > > >

Re: [FFmpeg-devel] [PATCH]lavc/dxva2: Use correct type specifier for HRESULT

2017-03-27 Thread Hendrik Leppkes
On Mon, Mar 27, 2017 at 9:54 AM, Carl Eugen Hoyos wrote: > 2017-03-27 9:52 GMT+02:00 Carl Eugen Hoyos : >> Hi! >> >> This is untested, sorry if this not wanted / plain wrong. > > The "x" are wrong, I guess. > So is such a change wanted? > Using %hr is

Re: [FFmpeg-devel] [PATCH 02/10] lavc: deprecate av_get_codec_tag_string()

2017-03-27 Thread Clément Bœsch
On Mon, Mar 27, 2017 at 10:56:26AM +0200, Carl Eugen Hoyos wrote: > 2017-03-27 10:52 GMT+02:00 Clément Bœsch : > > On Mon, Mar 27, 2017 at 10:47:55AM +0200, Carl Eugen Hoyos wrote: > >> 2017-03-27 10:21 GMT+02:00 Clément Bœsch : > >> > On Mon, Mar 27, 2017 at 10:12:46AM

Re: [FFmpeg-devel] [PATCH 02/10] lavc: deprecate av_get_codec_tag_string()

2017-03-27 Thread Carl Eugen Hoyos
2017-03-27 10:52 GMT+02:00 Clément Bœsch : > On Mon, Mar 27, 2017 at 10:47:55AM +0200, Carl Eugen Hoyos wrote: >> 2017-03-27 10:21 GMT+02:00 Clément Bœsch : >> > On Mon, Mar 27, 2017 at 10:12:46AM +0200, Carl Eugen Hoyos wrote: >> >> 2017-03-27 10:09 GMT+02:00 Clément

Re: [FFmpeg-devel] [PATCH 02/10] lavc: deprecate av_get_codec_tag_string()

2017-03-27 Thread Clément Bœsch
On Mon, Mar 27, 2017 at 10:47:55AM +0200, Carl Eugen Hoyos wrote: > 2017-03-27 10:21 GMT+02:00 Clément Bœsch : > > On Mon, Mar 27, 2017 at 10:12:46AM +0200, Carl Eugen Hoyos wrote: > >> 2017-03-27 10:09 GMT+02:00 Clément Bœsch : > >> > >> >> > +attribute_deprecated > >>

Re: [FFmpeg-devel] [PATCH 02/10] lavc: deprecate av_get_codec_tag_string()

2017-03-27 Thread Carl Eugen Hoyos
2017-03-27 10:21 GMT+02:00 Clément Bœsch : > On Mon, Mar 27, 2017 at 10:12:46AM +0200, Carl Eugen Hoyos wrote: >> 2017-03-27 10:09 GMT+02:00 Clément Bœsch : >> >> >> > +attribute_deprecated >> >> > size_t av_get_codec_tag_string(char *buf, size_t buf_size, unsigned >>

[FFmpeg-devel] Build error avcodec_send_packet

2017-03-27 Thread יוסף אלון
בס"ד I would like to compile to following program: With the flages: -lavcodec -lavutil -lavfilter -lavformat -lswscale -lz #include "libavcodec/avcodec.h" #include "libavformat/avformat.h" #include "libswscale/swscale.h" #include // The flush packet is a non-NULL packet with size 0 and data

Re: [FFmpeg-devel] [PATCH 02/10] lavc: deprecate av_get_codec_tag_string()

2017-03-27 Thread Clément Bœsch
On Mon, Mar 27, 2017 at 10:12:46AM +0200, Carl Eugen Hoyos wrote: > 2017-03-27 10:09 GMT+02:00 Clément Bœsch : > > >> > +attribute_deprecated > >> > size_t av_get_codec_tag_string(char *buf, size_t buf_size, unsigned int > >> > codec_tag); > >> > +#endif > >> > >> Sorry if I missed

Re: [FFmpeg-devel] [PATCH 02/10] lavc: deprecate av_get_codec_tag_string()

2017-03-27 Thread Carl Eugen Hoyos
2017-03-27 10:09 GMT+02:00 Clément Bœsch : >> > +attribute_deprecated >> > size_t av_get_codec_tag_string(char *buf, size_t buf_size, unsigned int >> > codec_tag); >> > +#endif >> >> Sorry if I missed it: >> Please explain what the problem is with the current code. > > I can't make

Re: [FFmpeg-devel] libavcodec/exr : add support for uint32

2017-03-27 Thread Carl Eugen Hoyos
2017-03-25 13:09 GMT+01:00 Martin Vignali : > Ping for apply Please send your public key to Michael and ask him to add you as committer, you have many commits in FFmpeg. Carl Eugen ___ ffmpeg-devel mailing list

Re: [FFmpeg-devel] [PATCH 02/10] lavc: deprecate av_get_codec_tag_string()

2017-03-27 Thread Clément Bœsch
On Mon, Mar 27, 2017 at 10:00:09AM +0200, Carl Eugen Hoyos wrote: > 2017-03-27 9:51 GMT+02:00 Clément Bœsch : > > --- > > libavcodec/avcodec.h | 5 + > > libavcodec/version.h | 3 +++ > > 2 files changed, 8 insertions(+) > > > > diff --git a/libavcodec/avcodec.h

Re: [FFmpeg-devel] [PATCH 02/10] lavc: deprecate av_get_codec_tag_string()

2017-03-27 Thread Carl Eugen Hoyos
2017-03-27 9:51 GMT+02:00 Clément Bœsch : > --- > libavcodec/avcodec.h | 5 + > libavcodec/version.h | 3 +++ > 2 files changed, 8 insertions(+) > > diff --git a/libavcodec/avcodec.h b/libavcodec/avcodec.h > index 4f3303366f..5c891b531a 100644 > --- a/libavcodec/avcodec.h > +++

Re: [FFmpeg-devel] [PATCH]lavc/dxva2: Use correct type specifier for HRESULT

2017-03-27 Thread Carl Eugen Hoyos
2017-03-27 9:52 GMT+02:00 Carl Eugen Hoyos : > Hi! > > This is untested, sorry if this not wanted / plain wrong. The "x" are wrong, I guess. So is such a change wanted? Carl Eugen ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org

[FFmpeg-devel] [PATCH 06/10] ffprobe: fix usage of av_get_codec_tag_string()

2017-03-27 Thread Clément Bœsch
--- ffprobe.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/ffprobe.c b/ffprobe.c index ba27bce823..17888c7063 100644 --- a/ffprobe.c +++ b/ffprobe.c @@ -2242,8 +2242,7 @@ static int show_stream(WriterContext *w, AVFormatContext *fmt_ctx, int stream_id #endif /*

[FFmpeg-devel] [PATCH 08/10] lavf/ape: remove unused magic field

2017-03-27 Thread Clément Bœsch
--- libavformat/ape.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/libavformat/ape.c b/libavformat/ape.c index 50a1aa13c1..c06db78480 100644 --- a/libavformat/ape.c +++ b/libavformat/ape.c @@ -57,7 +57,6 @@ typedef struct APEContext { APEFrame *frames; /* Info from Descriptor

[FFmpeg-devel] [PATCH 09/10] lavf: use av_4cc2str() where appropriate

2017-03-27 Thread Clément Bœsch
--- libavformat/avidec.c | 10 +++--- libavformat/cafdec.c | 6 ++ libavformat/dxa.c | 6 -- libavformat/iff.c | 4 ++-- libavformat/mlvdec.c | 3 ++- libavformat/mov.c | 5 ++--- libavformat/rmdec.c| 9 ++---

[FFmpeg-devel] [PATCH 10/10] lavc: use av_4cc2str() where appropriate

2017-03-27 Thread Clément Bœsch
--- libavcodec/pngdec.c | 7 ++- libavcodec/vqavideo.c | 8 ++-- 2 files changed, 4 insertions(+), 11 deletions(-) diff --git a/libavcodec/pngdec.c b/libavcodec/pngdec.c index a4eb6cce1b..52f5cc06f8 100644 --- a/libavcodec/pngdec.c +++ b/libavcodec/pngdec.c @@ -1143,11 +1143,8 @@

[FFmpeg-devel] [PATCH 07/10] ffmpeg_videotoolbox: fix usage of av_get_codec_tag_string()

2017-03-27 Thread Clément Bœsch
--- ffmpeg_videotoolbox.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/ffmpeg_videotoolbox.c b/ffmpeg_videotoolbox.c index 744a2a0009..2a8a895a46 100644 --- a/ffmpeg_videotoolbox.c +++ b/ffmpeg_videotoolbox.c @@ -48,7 +48,6 @@ static int

[FFmpeg-devel] [PATCH 05/10] tools/fourcc2pixfmt: fix usages of av_get_codec_tag_string()

2017-03-27 Thread Clément Bœsch
--- tools/fourcc2pixfmt.c | 21 +++-- 1 file changed, 7 insertions(+), 14 deletions(-) diff --git a/tools/fourcc2pixfmt.c b/tools/fourcc2pixfmt.c index 625f531f5c..1882e218bd 100644 --- a/tools/fourcc2pixfmt.c +++ b/tools/fourcc2pixfmt.c @@ -51,13 +51,9 @@ static void

[FFmpeg-devel] [PATCH]lavc/dxva2: Use correct type specifier for HRESULT

2017-03-27 Thread Carl Eugen Hoyos
Hi! This is untested, sorry if this not wanted / plain wrong. Please comment, Carl Eugen From 32e617e5f3557031759f06ac939faf6fd5827da6 Mon Sep 17 00:00:00 2001 From: Carl Eugen Hoyos Date: Mon, 27 Mar 2017 09:49:40 +0200 Subject: [PATCH] lavc/dxva2: Use correct type specifier

[FFmpeg-devel] [PATCH 02/10] lavc: deprecate av_get_codec_tag_string()

2017-03-27 Thread Clément Bœsch
--- libavcodec/avcodec.h | 5 + libavcodec/version.h | 3 +++ 2 files changed, 8 insertions(+) diff --git a/libavcodec/avcodec.h b/libavcodec/avcodec.h index 4f3303366f..5c891b531a 100644 --- a/libavcodec/avcodec.h +++ b/libavcodec/avcodec.h @@ -5667,6 +5667,7 @@ attribute_deprecated void

[FFmpeg-devel] [PATCH 03/10] lavc: fix usages of av_get_codec_tag_string()

2017-03-27 Thread Clément Bœsch
--- libavcodec/dds.c| 12 libavcodec/mjpegdec.c | 8 +++- libavcodec/mmaldec.c| 15 ++- libavcodec/sheervideo.c | 4 +--- libavcodec/utils.c | 9 +++-- 5 files changed, 17 insertions(+), 31 deletions(-) diff --git a/libavcodec/dds.c

[FFmpeg-devel] [PATCH 04/10] lavf: fix usages of av_get_codec_tag_string()

2017-03-27 Thread Clément Bœsch
--- libavformat/aiffdec.c | 8 +++- libavformat/apngdec.c | 8 ++-- libavformat/avidec.c | 8 ++-- libavformat/matroskadec.c | 7 ++- libavformat/movenc.c | 6 +- libavformat/mux.c | 7 +++ libavformat/rsd.c | 7 ++-

[FFmpeg-devel] [PATCH 01/10] lavu: add av_fourcc_make_string() and av_4cc2str()

2017-03-27 Thread Clément Bœsch
--- doc/APIchanges | 4 libavutil/avutil.h | 14 ++ libavutil/utils.c | 21 + libavutil/version.h | 2 +- 4 files changed, 40 insertions(+), 1 deletion(-) diff --git a/doc/APIchanges b/doc/APIchanges index 6aaa9adceb..4736e3e6fc 100644 ---

Re: [FFmpeg-devel] [PATCH] libavcodec/opusenc: use correct format specifiers

2017-03-27 Thread Carl Eugen Hoyos
2017-03-26 21:14 GMT+02:00 Kyle Swanson : > Ignore previous patch, we should actually be using %" PRId64 ". Can't > believe that took three tries ⊙﹏⊙. I removed the spaces that are not used anywhere else in the codebase and pushed. Thank you, Carl Eugen

Re: [FFmpeg-devel] [PATCH]lavc/h264_ps: Check chroma_location limits

2017-03-27 Thread Carl Eugen Hoyos
2017-03-24 15:16 GMT+01:00 Ronald S. Bultje : > There is also the risk with the initial patch that compiling libavcodec > against a newer libavutil but then runtime linking it with another (older) > one would lead to crashes. This is never supported (and is of course expected

Re: [FFmpeg-devel] [PATCH] avcodec/mjpegdec: Fixes runtime error: signed integer overflow: -24543 * 2031616 cannot be represented in type 'int'

2017-03-27 Thread Carl Eugen Hoyos
2017-03-27 3:18 GMT+02:00 Ronald S. Bultje : > So apparently it's OK that my system is taken over by a carefully > crafted sample posted on bugzilla? Please stop this! I don't know if and on what kind of mission you are (and it won't make a difference to me) but these kind of

Re: [FFmpeg-devel] [PATCH v9] avformat/dashdec: add dash demuxer base version

2017-03-27 Thread Rodger Combs
> On Mar 27, 2017, at 01:52, Steven Liu wrote: > > 2017-03-27 8:39 GMT+08:00 Rodger Combs >: > >> >>> On Mar 26, 2017, at 19:10, Steven Liu wrote: >>> >>> v2 fixed: >>> 1. from

Re: [FFmpeg-devel] [PATCH v9] avformat/dashdec: add dash demuxer base version

2017-03-27 Thread Steven Liu
2017-03-27 8:39 GMT+08:00 Rodger Combs : > > > On Mar 26, 2017, at 19:10, Steven Liu wrote: > > > > v2 fixed: > > 1. from autodetect to disabled > > 2. from camelCase code style to ffmpeg code style > > 3. from RepType to AVMediaType > > 4. fix