Re: [FFmpeg-devel] [PATCH] libavfilter/scale: Populate ow/oh when using 0 as w/h

I screwed up my git-send-email. Please ignore this patch as I already submitted what should be an identical one on June 7th. My apologies. On Mon, Jun 12, 2017 at 1:51 AM, Kevin Mark wrote: > The input width and height is known at parse time so there's no > reason ow/oh

Re: [FFmpeg-devel] [PATCH 2/2] libavfilter/scale2ref: Maintain main input's DAR

I've been using this patch for the past week now and I believe it's good to go. Does someone want to take a second look before merging? On Mon, Jun 5, 2017 at 6:55 AM, Kevin Mark wrote: > The scale2ref filter will now maintain the DAR of the main input and > not the DAR of

Re: [FFmpeg-devel] [PATCH 1/2] libavfilter/scale: More descriptive in/ref/out logging

Hi Michael, Hoping to get your thoughts on the grepability issue (wrt my previous email). If it needs to be on a single line there's no reason the new format cannot be changed to do so (removing the \n and adding a separator, really). However I'm a big fan of it as-is (for both scale and

Re: [FFmpeg-devel] [PATCH 04/11] avformat/librtmp: check return value of setsockopt

2017-06-11 22:05 GMT+08:00 Timo Rothenpieler : > Fixes CID 1396837 > --- > libavformat/librtmp.c | 5 - > 1 file changed, 4 insertions(+), 1 deletion(-) > > diff --git a/libavformat/librtmp.c b/libavformat/librtmp.c > index 146df660ac..f3cfa9a8e2 100644 > ---

Re: [FFmpeg-devel] [WIP][PATCH] Opus Piramid Vector Quantization Search in x86 SIMD asm

On 2017-06-11 11:34, Ivan Kalvachev wrote: > On 6/10/17, James Darnley wrote: >> On 2017-06-09 13:41, Ivan Kalvachev wrote: >>> >>> const_*_edge is used on only one place is the code. >>> Would you check if this patch fixes the issue. >>> >>> I expected that the addresses

Re: [FFmpeg-devel] [PATCH] avcodec/fft_template: Fix multiple runtime error: signed integer overflow: -1943918714 - 1935113003 cannot be represented in type 'int'

On 6/11/2017 10:21 AM, Paul B Mahol wrote: > On 6/11/17, Michael Niedermayer wrote: >> On Fri, Jun 09, 2017 at 09:07:39PM -0400, Ronald S. Bultje wrote: >>> Hi, >>> >>> On Thu, Jun 8, 2017 at 8:57 PM, Michael Niedermayer >>> >>> wrote: >>> On

Re: [FFmpeg-devel] [PATCH] avcodec/fft_template: Fix multiple runtime error: signed integer overflow: -1943918714 - 1935113003 cannot be represented in type 'int'

On Sun, Jun 11, 2017 at 03:21:38PM +0200, Paul B Mahol wrote: > On 6/11/17, Michael Niedermayer wrote: > > On Fri, Jun 09, 2017 at 09:07:39PM -0400, Ronald S. Bultje wrote: > >> Hi, > >> > >> On Thu, Jun 8, 2017 at 8:57 PM, Michael Niedermayer > >>

Re: [FFmpeg-devel] [PATCH] avformat/mov: add support for reading VP Codec Configuration Box

On 6/3/2017 2:40 PM, James Almer wrote: > On 5/27/2017 7:00 PM, James Almer wrote: >> As defined in "VP Codec ISO Media File Format Binding v1.0" >> https://github.com/webmproject/vp9-dash/blob/master/VPCodecISOMediaFileFormatBinding.md >> >> Signed-off-by: James Almer >> ---

[FFmpeg-devel] [PATCH] avformat/libssh: check the user provided a password before trying to use it

Fixes ticket #6413 Signed-off-by: James Almer --- The public key authentication also tries to use the password variable. I don't know if NULL is valid in that case or not. Perhaps for that one it would be better to replace the current usage of legacy API instead.

Re: [FFmpeg-devel] [PATCH 05/11] avformat/pcmdec: fix memory leak

On 6/11/17, Timo Rothenpieler wrote: > Fixes CID 1396267 > --- > libavformat/pcmdec.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/libavformat/pcmdec.c b/libavformat/pcmdec.c > index 3c7e8ac84b..d0ceea6fa9 100644 > --- a/libavformat/pcmdec.c > +++

[FFmpeg-devel] [PATCH] h264_parse: Do not touch chroma weights at all if stream is monochrome

Also return an error if the weight denominator is incorrect, rather than overriding it with zero and continuing. --- libavcodec/h264_parse.c | 24 ++-- 1 file changed, 14 insertions(+), 10 deletions(-) diff --git a/libavcodec/h264_parse.c b/libavcodec/h264_parse.c index

Re: [FFmpeg-devel] [PATCH 10/11] avcodec/h264_parser: zero-initialize H264PredWeightTable

On 11/06/17 16:12, Timo Rothenpieler wrote: >> Seems dubious? That is not a small structure, and it's being used >> essentially write-only here to skip over an unwanted part of the slice >> header - since it will only ever write to a small proportion of the >> elements, initialising all of

[FFmpeg-devel] [PATCH] avcodec/htmlsubtitles: Replace very slow redundant sscanf() calls by cleaner and faster code

This reduces the worst case from O(n²) to O(n) time Fixes Timeout Fixes: 2127/clusterfuzz-testcase-minimized-6595787859427328 Signed-off-by: Michael Niedermayer --- libavcodec/htmlsubtitles.c | 20 +++- 1 file changed, 15 insertions(+), 5 deletions(-)

Re: [FFmpeg-devel] [PATCH 10/11] avcodec/h264_parser: zero-initialize H264PredWeightTable

Seems dubious? That is not a small structure, and it's being used essentially write-only here to skip over an unwanted part of the slice header - since it will only ever write to a small proportion of the elements, initialising all of them to zero feels like a waste. (The only argument in

Re: [FFmpeg-devel] [PATCH 10/11] avcodec/h264_parser: zero-initialize H264PredWeightTable

On 11/06/17 15:07, Timo Rothenpieler wrote: > Fixes CID 1404889 > --- > libavcodec/h264_parser.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/libavcodec/h264_parser.c b/libavcodec/h264_parser.c > index 2564c6c6c3..1a304f318f 100644 > --- a/libavcodec/h264_parser.c >

Re: [FFmpeg-devel] [PATCH] hevc: Add support for alternative transfer characterics SEI

On 6/9/2017 6:35 PM, Vittorio Giovara wrote: > Signed-off-by: Vittorio Giovara > --- > libavcodec/hevc_sei.c | 9 + > libavcodec/hevc_sei.h | 7 +++ > libavcodec/hevcdec.c | 5 + > 3 files changed, 21 insertions(+) > > diff --git

[FFmpeg-devel] [PATCH 11/11] avcodec/dcaadpcm: fix unitialized read

Fixes CID 1409924 --- libavcodec/dcaadpcm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavcodec/dcaadpcm.c b/libavcodec/dcaadpcm.c index 8742c7ccf6..aff737ddb6 100644 --- a/libavcodec/dcaadpcm.c +++ b/libavcodec/dcaadpcm.c @@ -80,7 +80,7 @@ static int64_t

[FFmpeg-devel] [PATCH 10/11] avcodec/h264_parser: zero-initialize H264PredWeightTable

Fixes CID 1404889 --- libavcodec/h264_parser.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavcodec/h264_parser.c b/libavcodec/h264_parser.c index 2564c6c6c3..1a304f318f 100644 --- a/libavcodec/h264_parser.c +++ b/libavcodec/h264_parser.c @@ -155,7 +155,7 @@ found:

[FFmpeg-devel] [PATCH 06/11] avcodec/vaapi_encode: fix potential uninitialized read

Fixes CID 1400440 --- libavcodec/vaapi_encode.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavcodec/vaapi_encode.c b/libavcodec/vaapi_encode.c index 7e9c00f51d..9336bbecd4 100644 --- a/libavcodec/vaapi_encode.c +++ b/libavcodec/vaapi_encode.c @@ -738,7 +738,7 @@ fail:

[FFmpeg-devel] [PATCH 07/11] avfilter/vf_signature: fix memory leaks in error cases

Fixes CIDs 1403234 and 1403235 --- libavfilter/vf_signature.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/libavfilter/vf_signature.c b/libavfilter/vf_signature.c index 06b1b910d4..f0078ba1a6 100644 --- a/libavfilter/vf_signature.c +++ b/libavfilter/vf_signature.c @@

[FFmpeg-devel] [PATCH 04/11] avformat/librtmp: check return value of setsockopt

Fixes CID 1396837 --- libavformat/librtmp.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/libavformat/librtmp.c b/libavformat/librtmp.c index 146df660ac..f3cfa9a8e2 100644 --- a/libavformat/librtmp.c +++ b/libavformat/librtmp.c @@ -239,7 +239,10 @@ static int

[FFmpeg-devel] [PATCH 08/11] avfilter/vf_signature: use av_strlcpy instead of strcpy

Fixes CID 1403236 --- libavfilter/vf_signature.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavfilter/vf_signature.c b/libavfilter/vf_signature.c index f0078ba1a6..c20b0bfabb 100644 --- a/libavfilter/vf_signature.c +++ b/libavfilter/vf_signature.c @@ -576,7 +576,7 @@

[FFmpeg-devel] [PATCH 02/11] avfilter/vf_scale_npp: fix out-of-bounds reads

Fixes CIDs 1396414 and 1396415 --- libavfilter/vf_scale_npp.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavfilter/vf_scale_npp.c b/libavfilter/vf_scale_npp.c index b5acce653b..c36772e800 100644 --- a/libavfilter/vf_scale_npp.c +++ b/libavfilter/vf_scale_npp.c @@ -400,7

[FFmpeg-devel] [PATCH 05/11] avformat/pcmdec: fix memory leak

Fixes CID 1396267 --- libavformat/pcmdec.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/libavformat/pcmdec.c b/libavformat/pcmdec.c index 3c7e8ac84b..d0ceea6fa9 100644 --- a/libavformat/pcmdec.c +++ b/libavformat/pcmdec.c @@ -68,6 +68,7 @@ static int pcm_read_header(AVFormatContext *s)

[FFmpeg-devel] [PATCH 09/11] avfilter/signature_lookup: fix potential uninitialized reads

Fixes CIDs 1403238 and 1403239 --- libavfilter/signature_lookup.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavfilter/signature_lookup.c b/libavfilter/signature_lookup.c index 272c717c77..7de4a88ca2 100644 --- a/libavfilter/signature_lookup.c +++

[FFmpeg-devel] [PATCH 03/11] libavutil/opencl: fix potentiall nul dereference

Fixes CID 1396840 --- libavutil/opencl.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavutil/opencl.c b/libavutil/opencl.c index af35770e06..202756516b 100644 --- a/libavutil/opencl.c +++ b/libavutil/opencl.c @@ -169,7 +169,7 @@ const char *av_opencl_errstr(cl_int

[FFmpeg-devel] [PATCH 01/11] avfilter/unsharp: fix uninitialized pointer read

Fixes CID 1396855 --- libavfilter/unsharp_opencl.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/libavfilter/unsharp_opencl.c b/libavfilter/unsharp_opencl.c index d84920c590..1545455846 100644 --- a/libavfilter/unsharp_opencl.c +++ b/libavfilter/unsharp_opencl.c @@ -43,7

Re: [FFmpeg-devel] [PATCH] avcodec/fft_template: Fix multiple runtime error: signed integer overflow: -1943918714 - 1935113003 cannot be represented in type 'int'

On 6/11/17, Michael Niedermayer wrote: > On Fri, Jun 09, 2017 at 09:07:39PM -0400, Ronald S. Bultje wrote: >> Hi, >> >> On Thu, Jun 8, 2017 at 8:57 PM, Michael Niedermayer >> >> wrote: >> >> > On Thu, Jun 08, 2017 at 06:35:07PM -0400, Ronald S.

Re: [FFmpeg-devel] [PATCH] Add support for RockChip Media Process Platform This adds hardware decoding for h264 / HEVC / VP8 using MPP Rockchip API. Will return frames holding a av_drmprime struct tha

On Sun, 11 Jun 2017 05:24:16 + "LongChair ." wrote: > From: LongChair > > --- > Changelog | 1 + > configure | 12 ++ > libavcodec/Makefile| 4 + > libavcodec/allcodecs.c | 6 + > libavcodec/drmprime.h |

Re: [FFmpeg-devel] [PATCH] avcodec/fft_template: Fix multiple runtime error: signed integer overflow: -1943918714 - 1935113003 cannot be represented in type 'int'

On Sun, 11 Jun 2017 13:26:44 +0200 Michael Niedermayer wrote: > Iam fighting on this issue because i see this pushing FFmpeg into a > direction where the code is harder to understand and harder to maintain > and we already have many open bugs That's funny, because

Re: [FFmpeg-devel] [PATCH] avcodec/fft_template: Fix multiple runtime error: signed integer overflow: -1943918714 - 1935113003 cannot be represented in type 'int'

On Sun, 11 Jun 2017 03:58:30 +0300 Ivan Kalvachev wrote: > Of course, as FFmpeg developer, it is your right to initiate a vote > that would prevent Michael from trying to make FFmpeg more secure. > He has always complied with official decisions. Nothing but polemic

Re: [FFmpeg-devel] [PATCH] avcodec/fft_template: Fix multiple runtime error: signed integer overflow: -1943918714 - 1935113003 cannot be represented in type 'int'

On Fri, Jun 09, 2017 at 09:07:39PM -0400, Ronald S. Bultje wrote: > Hi, > > On Thu, Jun 8, 2017 at 8:57 PM, Michael Niedermayer > wrote: > > > On Thu, Jun 08, 2017 at 06:35:07PM -0400, Ronald S. Bultje wrote: > > > Hi, > > > > > > On Thu, Jun 8, 2017 at 6:10 PM, Michael

Re: [FFmpeg-devel] [WIP][PATCH] Opus Piramid Vector Quantization Search in x86 SIMD asm

On 6/11/17, Hendrik Leppkes wrote: > On Sun, Jun 11, 2017 at 11:34 AM, Ivan Kalvachev > wrote: >> On 6/10/17, James Darnley wrote: >>> On 2017-06-09 13:41, Ivan Kalvachev wrote: On 6/9/17, Michael Niedermayer

Re: [FFmpeg-devel] [WIP][PATCH] Opus Piramid Vector Quantization Search in x86 SIMD asm

On Sun, Jun 11, 2017 at 11:34 AM, Ivan Kalvachev wrote: > On 6/10/17, James Darnley wrote: >> On 2017-06-09 13:41, Ivan Kalvachev wrote: >>> On 6/9/17, Michael Niedermayer wrote: seems this breaks build with mingw64,

Re: [FFmpeg-devel] [WIP][PATCH] Opus Piramid Vector Quantization Search in x86 SIMD asm

On 6/10/17, James Darnley wrote: > On 2017-06-09 13:41, Ivan Kalvachev wrote: >> On 6/9/17, Michael Niedermayer wrote: >>> seems this breaks build with mingw64, didnt investigate but it >>> fails with these errors: >>> >>>