Re: [FFmpeg-devel] [PATCH] Add FITS Encoder

2017-07-14 Thread Reimar Döffinger
On 14.07.2017, at 19:04, Paras Chadha wrote: > +static int write_keyword_value(char * header, const char * keyword, int > value) > +{ > +int i, len, ret; > +len = strlen(keyword); > +for (i = 0; i < len; i++) { > +header[i] = keyword[i]; > +} would suggest memcpy (especi

Re: [FFmpeg-devel] [PATCH] fate: add sub-srt-badsyntax test

2017-07-14 Thread Michael Niedermayer
On Tue, Jul 11, 2017 at 11:16:43PM +0200, Michael Niedermayer wrote: > Based-on: srt sample by ubitux > > Signed-off-by: Michael Niedermayer > --- > tests/fate/subtitles.mak | 3 +++ > tests/ref/fate/sub-srt-badsyntax | 22 ++ > 2 files changed, 25 insertions(+) > c

Re: [FFmpeg-devel] [PATCH] lavf/mov: add support for sidx fragment indexes

2017-07-14 Thread Dale Curtis
On Fri, Jul 14, 2017 at 5:38 PM, Michael Niedermayer wrote: > > I dont think CTTS is the only affected atom. > > Thanks for the response. Yes, I think that's likely true. The ctts one is just likely the most important since it controls timestamp ordering. > what you describe sounds like an opti

Re: [FFmpeg-devel] [PATCH] lavf/mov: add support for sidx fragment indexes

2017-07-14 Thread Michael Niedermayer
Hi On Fri, Jul 14, 2017 at 02:52:23PM -0700, Dale Curtis wrote: > After looking at this some more. I don't think the way ctts entries are > stored is correct unless you assume all ctts entries are known prior to any > seeks taking place. Either through reading all trun boxes ahead of time or > con

Re: [FFmpeg-devel] [PATCH] lavf/mov: add support for sidx fragment indexes

2017-07-14 Thread Dale Curtis
After looking at this some more. I don't think the way ctts entries are stored is correct unless you assume all ctts entries are known prior to any seeks taking place. Either through reading all trun boxes ahead of time or content having a ctts atom. The current code is broken in the presence of s

[FFmpeg-devel] [PATCH] avfilter: add VMAF filter

2017-07-14 Thread Ashish Singh
Hi, templatized 8-bit and 10-bit functions. Documented options in doc/filters.texi and fixed most of the issues with earlier patches. Signed-off-by: Ashish Singh --- Changelog| 1 + configure| 5 + doc/filters.texi | 64 + libavfilter/Makefil

Re: [FFmpeg-devel] [PATCH] Add FITS Demuxer

2017-07-14 Thread Nicolas George
Le tridi 23 messidor, an CCXXV, Paras Chadha a écrit : > Hi, I have attached the dump of a FITS File containing 5 images and 4 > binary table xtensions. The dump is taken using fdump utility. Please take > a look. Thanks for the dump. But it is you who know the format, thus it is you who can tell

[FFmpeg-devel] [PATCH] Add FITS Encoder

2017-07-14 Thread Paras Chadha
Signed-off-by: Paras Chadha --- doc/general.texi | 2 + libavcodec/Makefile| 1 + libavcodec/allcodecs.c | 1 + libavcodec/fitsenc.c | 259 + libavformat/img2enc.c | 1 + 5 files changed, 264 insertions(+) create mode 100644 li

Re: [FFmpeg-devel] [PATCH] avcodec: add MagicYUV encoder

2017-07-14 Thread Reimar Döffinger
On 14.07.2017, at 16:30, Paul B Mahol wrote: > Signed-off-by: Paul B Mahol Probably not making myself popular with that request, but maybe you could do a pass over the code and add comments for things that might be useful for people to know? If you need concrete examples I am thinking of qsort

Re: [FFmpeg-devel] [PATCH 1/2] avcodec/vorbisenc: Add pre-echo detection

2017-07-14 Thread Tyler Jones
On Fri, Jul 14, 2017 at 12:43:26AM +0200, Michael Niedermayer wrote: > On Wed, Jul 12, 2017 at 04:18:06PM -0600, Tyler Jones wrote: > [...] > > > > +av_cold int psy_vorbis_init(VorbisPsyContext *vpctx, int sample_rate, > > +int channels, int blocks) > > non static fun

Re: [FFmpeg-devel] [PATCH 1/3] avcodec/get_bits: add cached bitstream reader

2017-07-14 Thread foo86
On Fri, Jul 14, 2017 at 05:12:25PM +0200, Hendrik Leppkes wrote: > On Fri, Jul 14, 2017 at 4:08 PM, foo86 wrote: > > On Thu, Jul 13, 2017 at 12:27:03PM +0200, Paul B Mahol wrote: > >> +static inline unsigned int get_bits(GetBitContext *s, int n) > >> { > >> +#ifdef CACHED_BITSTREAM_READER > >> +

Re: [FFmpeg-devel] [PATCH 1/3] avcodec/get_bits: add cached bitstream reader

2017-07-14 Thread Hendrik Leppkes
On Fri, Jul 14, 2017 at 4:08 PM, foo86 wrote: > On Thu, Jul 13, 2017 at 12:27:03PM +0200, Paul B Mahol wrote: >> +static inline unsigned int get_bits(GetBitContext *s, int n) >> { >> +#ifdef CACHED_BITSTREAM_READER >> +register int tmp = 0; >> +#ifdef BITSTREAM_READER_LE >> +uint64_t left

[FFmpeg-devel] [PATCH] webmdashenc: Fix memory leak

2017-07-14 Thread Derek Buitenhuis
Signed-off-by: Derek Buitenhuis --- libavformat/webmdashenc.c | 38 ++ 1 file changed, 30 insertions(+), 8 deletions(-) diff --git a/libavformat/webmdashenc.c b/libavformat/webmdashenc.c index 550ad72e4d..1280d8a763 100644 --- a/libavformat/webmdashenc.c +++ b

[FFmpeg-devel] [PATCH] avcodec: add MagicYUV encoder

2017-07-14 Thread Paul B Mahol
Signed-off-by: Paul B Mahol --- libavcodec/Makefile | 1 + libavcodec/allcodecs.c | 2 +- libavcodec/magicyuvenc.c | 482 +++ 3 files changed, 484 insertions(+), 1 deletion(-) create mode 100644 libavcodec/magicyuvenc.c diff --git a/libavco

Re: [FFmpeg-devel] [PATCH 1/3] avcodec/get_bits: add cached bitstream reader

2017-07-14 Thread foo86
On Thu, Jul 13, 2017 at 12:27:03PM +0200, Paul B Mahol wrote: > +static inline unsigned int get_bits(GetBitContext *s, int n) > { > +#ifdef CACHED_BITSTREAM_READER > +register int tmp = 0; > +#ifdef BITSTREAM_READER_LE > +uint64_t left = 0; > +#endif > + > +av_assert2(n>0 && n<=32); >

Re: [FFmpeg-devel] [PATCH] avformat/riff.h : remove unused function parameter "const AVCodecTag *tags" of "void ff_put_bmp_header()"

2017-07-14 Thread Derek Buitenhuis
On 7/14/2017 12:12 PM, Александр Слободенюк wrote: > It was left by the history Probably OK. - Derek ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH 1/3] avcodec/aacdec_template: Fix undefined integer overflow in apply_tns()

2017-07-14 Thread Ronald S. Bultje
Hi, On Fri, Jul 14, 2017 at 6:55 AM, Kieran Kunhya wrote: > On Thu, 13 Jul 2017 at 23:06 Michael Niedermayer > wrote: > > > On Wed, Jul 12, 2017 at 01:54:28PM +, Kieran Kunhya wrote: > > > > > > > > I actually would request a short note explaining the SUINTFLOAT type > > usage. > > > > Some

Re: [FFmpeg-devel] [PATCH] avfilter: add motion filter

2017-07-14 Thread Ashish Pratap Singh
On Thu, Jul 13, 2017 at 7:04 PM, Nicolas George wrote: > Hi. Thanks for the patch. See comments below. > > Le quintidi 25 messidor, an CCXXV, Ashish Singh a écrit : > > Hi, this is motion filter, one of the component filters of VMAF. > > It takes two videos as input. > > Run it using: ffmpeg -i m

[FFmpeg-devel] [PATCH] avformat/riff.h : remove unused function parameter "const AVCodecTag *tags" of "void ff_put_bmp_header()"

2017-07-14 Thread Александр Слободенюк
It was left by the history 0001-avformat-riff.h-remove-unused-function-parameter.patch Description: Binary data ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH 1/3] avcodec/aacdec_template: Fix undefined integer overflow in apply_tns()

2017-07-14 Thread Kieran Kunhya
On Thu, 13 Jul 2017 at 23:06 Michael Niedermayer wrote: > On Wed, Jul 12, 2017 at 01:54:28PM +, Kieran Kunhya wrote: > > > > > > I actually would request a short note explaining the SUINTFLOAT type > usage. > > > Something like: > > > +typedef unsignedSUINTFLOAT; // Equivalent to

Re: [FFmpeg-devel] [PATCH] avformat/riff: remove useless tag correlation 'mpg2' --> AV_CODEC_ID_MPEG1VIDEO.

2017-07-14 Thread Александр Слободенюк
Also if you will write an mpeg1video , it will be created with tag 'mpg1',not'mpg2'inall cases (because correlation AV_CODEC_ID_MPEG1_VIDEO -- 'mpg1') stands before 'mpg2' tag in ff_codec_bmp_tags: ffmpeg -i whatever.mov -vcodec mpeg1video test.avi (output)

Re: [FFmpeg-devel] [PATCH] vdpau: do not use buggy HEVC support by default

2017-07-14 Thread Manoj Bonda
>That's great to hear. Is there a bug tracker for this? Please find the Bug ID 200328360 for above. > - 10 bit surface support - mapping GL surfaces as progressive frames instead of fields - getting rid of display preemption Will add these to feature request List and will take them up along wit

Re: [FFmpeg-devel] [PATCH] vdpau: do not use buggy HEVC support by default

2017-07-14 Thread wm4
On Fri, 14 Jul 2017 09:55:58 + Manoj Bonda wrote: > Hi, > > Thanks i'll look into the issue and come up with an ETA ASAP. > Going on I will be the maintainer of VDPAU. Please direct any VDPAU issues to > me. That's great to hear. Is there a bug tracker for this? Other than fixing the bug

[FFmpeg-devel] [PATCH] avformat/riff: remove useless tag correlation 'mpg2' --> AV_CODEC_ID_MPEG1VIDEO.

2017-07-14 Thread Александр Слободенюк
This is actually a bug, that just doesn't affect anything. First of all, the logic of functions that work with ff_codec_bmp_tags is "One tag -- one codec id". Also if you write this tag as MPEG2VIDEO, and then read the header (all by ffmpeg), it will interpret as MPEG1VIDEO: ffmpeg -i whateve

Re: [FFmpeg-devel] [PATCH] vdpau: do not use buggy HEVC support by default

2017-07-14 Thread Manoj Bonda
Hi, Thanks i'll look into the issue and come up with an ETA ASAP. Going on I will be the maintainer of VDPAU. Please direct any VDPAU issues to me. Thanks, ManojGupta. -Original Message- From: ffmpeg-devel [mailto:ffmpeg-devel-boun...@ffmpeg.org] On Behalf Of Philip Langdale Sent: Fr

Re: [FFmpeg-devel] [PATCH] vdpau: do not use buggy HEVC support by default

2017-07-14 Thread Philip Langdale
On 2017-07-14 08:19, Yogender Gupta wrote: Please help to understand what is broken with a command line, so that we can address this issue. This is the issue that the hevc low level decoder outputs frames instead of fields - which all the other decoders do. Originally, the vdpau support didn't

Re: [FFmpeg-devel] [PATCH] vdpau: do not use buggy HEVC support by default

2017-07-14 Thread wm4
On Fri, 14 Jul 2017 08:19:25 + Yogender Gupta wrote: > Please help to understand what is broken with a command line, so that we can > address this issue. With ffmpeg CLI, you can try something like: ffmpeg -hwaccel vdpau -i some_8bit_hevc_file.mkv -frames 10 -pix_fmt yuv420p out.y4m Yo

Re: [FFmpeg-devel] [PATCH] vdpau: do not use buggy HEVC support by default

2017-07-14 Thread Yogender Gupta
Please help to understand what is broken with a command line, so that we can address this issue. Thanks, Yogender -Original Message- From: ffmpeg-devel [mailto:ffmpeg-devel-boun...@ffmpeg.org] On Behalf Of wm4 Sent: Monday, July 03, 2017 4:29 PM To: ffmpeg-devel@ffmpeg.org Subject: Re: [

Re: [FFmpeg-devel] [PATCH] avfilter: add motion filter

2017-07-14 Thread Tobias Rapp
On 13.07.2017 09:44, Ashish Singh wrote: Hi, this is motion filter, one of the component filters of VMAF. It takes two videos as input. Run it using: ffmpeg -i main -i ref -lavfi motion -f null - Currently it outputs the average motion score over all frames. --- Changelog | 1