Re: [FFmpeg-devel] [PATCH] lavc/qsv: skip the packet if decoding failure.

2018-01-25 Thread Song, Ruiling
> -Original Message- > From: Jun Zhao [mailto:mypopy...@gmail.com] > Sent: Friday, January 26, 2018 1:02 PM > To: FFmpeg development discussions and patches ; > Song, Ruiling > Subject: Re: [FFmpeg-devel] [PATCH] lavc/qsv: skip the packet

Re: [FFmpeg-devel] [PATCH] fate: add id3v2 test

2018-01-25 Thread Richard Shaffer
>From f7398407c1f5822e1536ce03d46c885b2ad00c38 Mon Sep 17 00:00:00 2001 From: Richard Shaffer Date: Thu, 25 Jan 2018 19:54:59 -0800 Subject: [PATCH] fate: add id3v2 test Adds basic unit test for parsing ID3v2 tags. --- This follows the suggestion to use the ffprobe utility

Re: [FFmpeg-devel] [PATCH] lavc/qsv: skip the packet if decoding failure.

2018-01-25 Thread Jun Zhao
On 2018/1/25 16:37, Ruiling Song wrote: > From: "Ruiling, Song" > > MediaSDK may fail to decode some frame, just skip it. > Otherwise, it will keep decoding the failure packet repeatedly > without processing any packet afterwards. > > v2: > switch to using

Re: [FFmpeg-devel] [PATCH] lavc/qsv: skip the packet if decoding failure.

2018-01-25 Thread Jun Zhao
On 2018/1/25 16:37, Ruiling Song wrote: > From: "Ruiling, Song" > > MediaSDK may fail to decode some frame, just skip it. > Otherwise, it will keep decoding the failure packet repeatedly > without processing any packet afterwards. > > v2: > switch to using

[FFmpeg-devel] [PATCH] lavc/aarch64/sbrdsp_neon: fix build on old binutils

2018-01-25 Thread Rodger Combs
--- libavcodec/aarch64/sbrdsp_neon.S | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavcodec/aarch64/sbrdsp_neon.S b/libavcodec/aarch64/sbrdsp_neon.S index d1d79b749c..d23717e760 100644 --- a/libavcodec/aarch64/sbrdsp_neon.S +++ b/libavcodec/aarch64/sbrdsp_neon.S @@ -287,7

Re: [FFmpeg-devel] [PATCH] avformat/hlsenc: Check ret on avformat_write_header

2018-01-25 Thread 刘歧
> On 24 Jan 2018, at 09:24, Brendan McGrath wrote: > > Encoding currently fails when using hls_ts_options with the fmp4 > segment type. > > This is due to the fact that avformat_write_header does not process > the passed options when the avformat is already

Re: [FFmpeg-devel] [PATCH 3/3] hls: don't print a certain warning if playlist loading is aborted

2018-01-25 Thread 刘歧
> On 24 Jan 2018, at 15:08, wm4 wrote: > > AVERROR_EXIT happens when the user's interrupt callback signals that > playback should be aborted. In this case, the demuxer shouldn't print a > warning, as it's expected that all network accesses are stopped. > --- >

Re: [FFmpeg-devel] [PATCH] avformat/hlsenc: Check ret on avformat_write_header

2018-01-25 Thread 刘歧
> On 24 Jan 2018, at 09:24, Brendan McGrath wrote: > > Encoding currently fails when using hls_ts_options with the fmp4 > segment type. > > This is due to the fact that avformat_write_header does not process > the passed options when the avformat is already

Re: [FFmpeg-devel] [PATCH v2 2/2] avformat/dashenc: Signal http end of chunk(http_shutdown) explicitly

2018-01-25 Thread Jeyapal, Karthick
On 1/2/18 1:49 PM, Karthick J wrote: > From: Karthick Jeyapal > > Currently http end of chunk is signalled implicitly in dashenc_io_open(). > This mean playlists http writes would have to wait upto a segment duration to > signal end of chunk causing delays. > This patch

[FFmpeg-devel] [PATCH 2/2] avcodec/indeo5: Do not leave frame_type set to an invalid value

2018-01-25 Thread Michael Niedermayer
Fixes: null pointer dereference Fixes: 5264/clusterfuzz-testcase-minimized-4621956621008896 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Niedermayer --- libavcodec/indeo5.c | 1 + 1 file

[FFmpeg-devel] [PATCH 1/2] avcodec/dirac_dwt: Fix several integer overflows

2018-01-25 Thread Michael Niedermayer
Fixes: runtime error: signed integer overflow: -2146071175 + -268479557 cannot be represented in type 'int' Fixes: 5237/clusterfuzz-testcase-minimized-4569895275593728 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael

Re: [FFmpeg-devel] [PATCH]: Change Stack Frame Limit in Cuda Context

2018-01-25 Thread Bang He
On Thu, Jan 25, 2018 at 7:44 AM, Ben Chang wrote: > Hi, > > Please help review this patch to reduce stack frame size per GPU thread. > The default allocation size per thread (1024 bytes) is excessive and can be > reduced to 128 bytes based on nvidia cuda kernel compilation

Re: [FFmpeg-devel] [PATCH] rtsp: rename certain options after a deprecation period

2018-01-25 Thread Jan Ekström
On Fri, Jan 26, 2018 at 1:56 AM, Carl Eugen Hoyos wrote: > 2018-01-26 0:52 GMT+01:00 wm4 : >> (and I already wrote that on IRC too, where he lurks as >> michaelni) > > Could one of the native speakers please try to convince > me that this is not a

Re: [FFmpeg-devel] [PATCH]: Change Stack Frame Limit in Cuda Context

2018-01-25 Thread Mark Thompson
On 24/01/18 23:44, Ben Chang wrote: > Hi, > > Please help review this patch to reduce stack frame size per GPU thread. The > default allocation size per thread (1024 bytes) is excessive and can be > reduced to 128 bytes based on nvidia cuda kernel compilation statistics. This > should help

Re: [FFmpeg-devel] [PATCH V2 2/3] lavfi/procamp_vaapi: fix the green video issue if without arguments.

2018-01-25 Thread Mark Thompson
On 24/01/18 10:30, Carl Eugen Hoyos wrote: > 2018-01-24 4:04 GMT+01:00 Jun Zhao : > >> -procamp_params[i].type = VAProcFilterColorBalance; >> -procamp_params[i].attrib = VAProcColorBalanceBrightness; >> -procamp_params[i].value = map(ctx->bright,

Re: [FFmpeg-devel] [PATCH] rtsp: rename certain options after a deprecation period

2018-01-25 Thread wm4
On Fri, 26 Jan 2018 00:56:16 +0100 Carl Eugen Hoyos wrote: > 2018-01-26 0:52 GMT+01:00 wm4 : > > (and I already wrote that on IRC too, where he lurks as > > michaelni) > > Could one of the native speakers please try to convince > me that this is not

Re: [FFmpeg-devel] [PATCH] rtsp: rename certain options after a deprecation period

2018-01-25 Thread Carl Eugen Hoyos
2018-01-26 0:52 GMT+01:00 wm4 : > (and I already wrote that on IRC too, where he lurks as > michaelni) Could one of the native speakers please try to convince me that this is not a disparaging term? Thank you, Carl Eugen ___

Re: [FFmpeg-devel] [PATCH] rtsp: rename certain options after a deprecation period

2018-01-25 Thread wm4
On Fri, 26 Jan 2018 00:21:14 +0100 Carl Eugen Hoyos wrote: > 2018-01-26 0:00 GMT+01:00 Hendrik Leppkes : > > On Thu, Jan 25, 2018 at 11:35 PM, Carl Eugen Hoyos > > wrote: > >>> and in particular stop outright harassing me into

Re: [FFmpeg-devel] [PATCH]: Change Stack Frame Limit in Cuda Context

2018-01-25 Thread Timo Rothenpieler
Am 26.01.2018 um 00:17 schrieb Ben Chang: Just use another provider like gmail. Done. Patch looks ok on first glance, will do a proper review tomorrow. smime.p7s Description: S/MIME Cryptographic Signature ___ ffmpeg-devel mailing list

Re: [FFmpeg-devel] [PATCH] ffmpeg: Ignore SIGPIPE

2018-01-25 Thread Nicolas George
Mark Thompson (2018-01-25): > Please don't. In this case the semantics of ignoring the signal are > clear and I think we can be confident the change is ok, but that > certainly isn't true in almost all other cases (especially if people > are going to catch signals and do something in the signal

Re: [FFmpeg-devel] [PATCH V2 2/3] lavfi/procamp_vaapi: fix the green video issue if without arguments.

2018-01-25 Thread Carl Eugen Hoyos
2018-01-26 0:21 GMT+01:00 Mark Thompson : > On 24/01/18 03:04, Jun Zhao wrote: >> >> From 1d3b388c313881e931928dc4049896265919725d Mon Sep 17 00:00:00 2001 >> From: Jun Zhao >> Date: Wed, 24 Jan 2018 09:28:24 +0800 >> Subject: [PATCH V2 2/3]

Re: [FFmpeg-devel] [PATCH] ffmpeg: Ignore SIGPIPE

2018-01-25 Thread Mark Thompson
On 25/01/18 23:22, Nicolas George wrote: > Mark Thompson (2018-01-25): >> And applied. > > I am glad to see that my advice was so well taken into account. From now > on, I will defer to you on matters relating to Unix system programming, > especially signals, shall I? Please don't. In this case

Re: [FFmpeg-devel] [PATCH] rtsp: rename certain options after a deprecation period

2018-01-25 Thread Hendrik Leppkes
On Fri, Jan 26, 2018 at 12:21 AM, Carl Eugen Hoyos wrote: > 2018-01-26 0:00 GMT+01:00 Hendrik Leppkes : >> On Thu, Jan 25, 2018 at 11:35 PM, Carl Eugen Hoyos >> wrote: and in particular stop outright harassing me into leaving.

Re: [FFmpeg-devel] [PATCH V2 2/3] lavfi/procamp_vaapi: fix the green video issue if without arguments.

2018-01-25 Thread Mark Thompson
On 24/01/18 03:04, Jun Zhao wrote: > > From 1d3b388c313881e931928dc4049896265919725d Mon Sep 17 00:00:00 2001 > From: Jun Zhao > Date: Wed, 24 Jan 2018 09:28:24 +0800 > Subject: [PATCH V2 2/3] lavfi/procamp_vaapi: fix the green video issue if > without arguments. > > Fix

Re: [FFmpeg-devel] [PATCH]: Change Stack Frame Limit in Cuda Context

2018-01-25 Thread Ben Chang
>Just use another provider like gmail. Done. Patch-wise, is it approved? Thanks, Ben ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH] ffmpeg: Ignore SIGPIPE

2018-01-25 Thread Nicolas George
Mark Thompson (2018-01-25): > And applied. I am glad to see that my advice was so well taken into account. From now on, I will defer to you on matters relating to Unix system programming, especially signals, shall I? Regards, -- Nicolas George signature.asc Description: Digital signature

Re: [FFmpeg-devel] [PATCH] rtsp: rename certain options after a deprecation period

2018-01-25 Thread Carl Eugen Hoyos
2018-01-26 0:00 GMT+01:00 Hendrik Leppkes : > On Thu, Jan 25, 2018 at 11:35 PM, Carl Eugen Hoyos wrote: >>> and in particular stop outright harassing me into leaving. >> >> Yes, I would very much prefer if I could stop;-) > > So you openly admit to

Re: [FFmpeg-devel] [PATCH] rtsp: rename certain options after a deprecation period

2018-01-25 Thread Hendrik Leppkes
On Thu, Jan 25, 2018 at 11:35 PM, Carl Eugen Hoyos wrote: >> and in particular stop outright harassing me into leaving. > > Yes, I would very much prefer if I could stop;-) > So you openly admit to harassing a fellow developer, and even more so to your plans to not stop? If

Re: [FFmpeg-devel] [PATCH] ffmpeg: Ignore SIGPIPE

2018-01-25 Thread Mark Thompson
On 19/01/18 00:18, Mark Thompson wrote: > On 19/01/18 00:08, Carl Eugen Hoyos wrote: >> 2018-01-19 0:42 GMT+01:00 Mark Thompson : >> >>> To offer this suggestion in a more concrete form. >> >> Works as expected here except for printing an error which >> may be intended. > > Yes,

Re: [FFmpeg-devel] [PATCH] rtsp: rename certain options after a deprecation period

2018-01-25 Thread Carl Eugen Hoyos
2018-01-25 23:13 GMT+01:00 wm4 : > On Thu, 25 Jan 2018 23:08:21 +0100 > Carl Eugen Hoyos wrote: > >> 2018-01-25 23:04 GMT+01:00 wm4 : >> > On Thu, 25 Jan 2018 22:41:48 +0100 >> > Carl Eugen Hoyos wrote: >> > >>

Re: [FFmpeg-devel] [PATCH] rtsp: rename certain options after a deprecation period

2018-01-25 Thread wm4
On Thu, 25 Jan 2018 23:08:21 +0100 Carl Eugen Hoyos wrote: > 2018-01-25 23:04 GMT+01:00 wm4 : > > On Thu, 25 Jan 2018 22:41:48 +0100 > > Carl Eugen Hoyos wrote: > > > >> 2018-01-25 21:54 GMT+01:00 wm4 : > >>

Re: [FFmpeg-devel] [PATCH] rtsp: rename certain options after a deprecation period

2018-01-25 Thread Carl Eugen Hoyos
2018-01-25 23:04 GMT+01:00 wm4 : > On Thu, 25 Jan 2018 22:41:48 +0100 > Carl Eugen Hoyos wrote: > >> 2018-01-25 21:54 GMT+01:00 wm4 : >> >> > Clearly you're trying to bikeshed me here. I'll just ignore this >> > instead of wasting

Re: [FFmpeg-devel] [PATCH] rtsp: rename certain options after a deprecation period

2018-01-25 Thread wm4
On Thu, 25 Jan 2018 22:41:48 +0100 Carl Eugen Hoyos wrote: > 2018-01-25 21:54 GMT+01:00 wm4 : > > > Clearly you're trying to bikeshed me here. I'll just ignore this > > instead of wasting my time on you. > > Is there really no hope that you go away

Re: [FFmpeg-devel] [PATCH] rtsp: rename certain options after a deprecation period

2018-01-25 Thread Carl Eugen Hoyos
2018-01-25 21:54 GMT+01:00 wm4 : > Clearly you're trying to bikeshed me here. I'll just ignore this > instead of wasting my time on you. Is there really no hope that you go away for good? Carl Eugen ___ ffmpeg-devel mailing list

Re: [FFmpeg-devel] [PATCH] rtsp: rename certain options after a deprecation period

2018-01-25 Thread wm4
On Thu, 25 Jan 2018 21:17:54 +0100 Michael Niedermayer wrote: > On Thu, Jan 25, 2018 at 08:54:51PM +0100, wm4 wrote: > > On Thu, 25 Jan 2018 20:46:13 +0100 > > Michael Niedermayer wrote: > > > > > On Thu, Jan 25, 2018 at 07:00:43PM +0100, wm4

Re: [FFmpeg-devel] [PATCH] rtsp: rename certain options after a deprecation period

2018-01-25 Thread Nicolas George
Michael Niedermayer (2018-01-25): > If you want to use an integer there are many ways to achive this, > adding a AV_OPT_TYPE_TIMEOUT with int64 in nano seconds would be one. > Using a double in seconds would be much easier though We already have AV_OPT_TYPE_DURATION, in microseconds rather than

Re: [FFmpeg-devel] [PATCH] rtsp: rename certain options after a deprecation period

2018-01-25 Thread Michael Niedermayer
On Thu, Jan 25, 2018 at 08:54:51PM +0100, wm4 wrote: > On Thu, 25 Jan 2018 20:46:13 +0100 > Michael Niedermayer wrote: > > > On Thu, Jan 25, 2018 at 07:00:43PM +0100, wm4 wrote: > > > The names inherently clash with the meanings of the HTTP libavformat > > > protocol

Re: [FFmpeg-devel] [PATCH 1/2] avcodec/hevc_ps: Check log2_sao_offset_scale_*

2018-01-25 Thread Michael Niedermayer
On Wed, Jan 24, 2018 at 11:42:44PM -0300, James Almer wrote: > On 1/24/2018 11:03 PM, Michael Niedermayer wrote: > > On Wed, Jan 24, 2018 at 12:47:18AM -0300, James Almer wrote: > >> On 1/24/2018 12:34 AM, Michael Niedermayer wrote: > >>> Fixes: 4868/clusterfuzz-testcase-minimized-6236542906400768

Re: [FFmpeg-devel] [PATCH] rtsp: rename certain options after a deprecation period

2018-01-25 Thread wm4
On Thu, 25 Jan 2018 20:46:13 +0100 Michael Niedermayer wrote: > On Thu, Jan 25, 2018 at 07:00:43PM +0100, wm4 wrote: > > The names inherently clash with the meanings of the HTTP libavformat > > protocol options. Rename them after a deprecation period to make them > >

Re: [FFmpeg-devel] [PATCH] rtsp: rename certain options after a deprecation period

2018-01-25 Thread Michael Niedermayer
On Thu, Jan 25, 2018 at 07:00:43PM +0100, wm4 wrote: > The names inherently clash with the meanings of the HTTP libavformat > protocol options. Rename them after a deprecation period to make them > compatible with the HTTP ones. > --- > I see no better way that wouldn't require more effort than

Re: [FFmpeg-devel] [PATCH] rtmp: Plug leak if sending bytes read report fails.

2018-01-25 Thread Michael Niedermayer
On Tue, Jan 23, 2018 at 04:49:16PM -0800, Josh Allmann wrote: > --- > libavformat/rtmpproto.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) applied thx [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB I have often repented speaking, but never of

Re: [FFmpeg-devel] [PATCH] avdevice/decklink_dec: Extract 1080i and NTSC VANC

2018-01-25 Thread Ray Tiley
Apologies for attaching the patch, still trying to figure out patches, didn't know how to send the patch and include info in the email unrelated to commit message / change. The unpack_v210 is only called for SD resolutions ,specifically NTSC which is 720 wide. unpack_v210 should never be called

Re: [FFmpeg-devel] [PATCH] rtsp: rename certain options after a deprecation period

2018-01-25 Thread wm4
On Thu, 25 Jan 2018 15:12:27 -0300 James Almer wrote: > On 1/25/2018 3:00 PM, wm4 wrote: > > The names inherently clash with the meanings of the HTTP libavformat > > protocol options. Rename them after a deprecation period to make them > > compatible with the HTTP ones. > >

Re: [FFmpeg-devel] [PATCH] rtsp: rename certain options after a deprecation period

2018-01-25 Thread James Almer
On 1/25/2018 3:00 PM, wm4 wrote: > The names inherently clash with the meanings of the HTTP libavformat > protocol options. Rename them after a deprecation period to make them > compatible with the HTTP ones. > --- > I see no better way that wouldn't require more effort than justified. > The

[FFmpeg-devel] [PATCH] rtsp: rename certain options after a deprecation period

2018-01-25 Thread wm4
The names inherently clash with the meanings of the HTTP libavformat protocol options. Rename them after a deprecation period to make them compatible with the HTTP ones. --- I see no better way that wouldn't require more effort than justified. The incompatible semantics of the "timeout" option

[FFmpeg-devel] Using FFmpeg as standalone EXE in commercial product.

2018-01-25 Thread Cody Herzog
Hello. I'm working on a closed-source commercial product, and I would like to deliver FFmpeg as a stand-alone EXE with my installer. My program will call into FFmpeg using the Windows CreateProcess() API, and will stream to it through standard input. I have made a minimal build of FFmpeg which

Re: [FFmpeg-devel] [PATCH] avdevice/decklink_dec: Extract 1080i and NTSC VANC

2018-01-25 Thread Devin Heitmueller
Hi Ray, > > Please find updated patch attatched. I reverted the vanc lines changes and > found that all my tests worked as expected, so not sure what was wrong w/ > my original test. The need to extract vanc from the entire line vs just the > luma in NTSC is still required. It’s helpful if in

Re: [FFmpeg-devel] [PATCH]: Change Stack Frame Limit in Cuda Context

2018-01-25 Thread Carl Eugen Hoyos
2018-01-25 3:41 GMT+01:00 Ben Chang : >> Please remove this or use another email address. > > Is this absolutely necessary? Have you ever read the footer? You are sending an email to a public email list that you know is mirrored on the internet and claim that the content of

Re: [FFmpeg-devel] [PATCH] avfilter/vf_framerate: fix cpy_line_width calculation on >8 bits format

2018-01-25 Thread Muhammad Faiz
On Sat, Jan 20, 2018 at 3:04 PM, Muhammad Faiz wrote: > Fix tsan warnings on fate-filter-framerate-12bit-down and > fate-filter-framerate-12bit-up. > > Signed-off-by: Muhammad Faiz > --- > libavfilter/vf_framerate.c | 2 +- > 1 file changed, 1 insertion(+), 1

[FFmpeg-devel] [PATCH] lavc/qsv: skip the packet if decoding failure.

2018-01-25 Thread Ruiling Song
From: "Ruiling, Song" MediaSDK may fail to decode some frame, just skip it. Otherwise, it will keep decoding the failure packet repeatedly without processing any packet afterwards. v2: switch to using av_packet_unref(). Signed-off-by: Ruiling Song