Re: [FFmpeg-devel] [PATCH] lavfi: add colorkey_opencl filter

2019-04-13 Thread Cld fire
> > You mean the list at < > http://git.videolan.org/?p=ffmpeg.git;a=blob;f=libavfilter/vf_colorkey.c;h=3d65e59d42c6fa480e00f4b7ab079677bcac876a;hb=HEAD#l113>? > AV_PIX_FMT_NONE (-1) is the invalid enum AVPixelFormat value used as the > sentinel for the end of the list passed to ff_make_format_list

[FFmpeg-devel] [PATCH v2] lavfi: add colorkey_opencl filter

2019-04-13 Thread Jarek Samic
This is a direct port of the CPU filter. Signed-off-by: Jarek Samic --- I've made the changes requested from the first patch. I also investigated splitting the kernel into two kernels in order to remove the blending if branch; I noticed negligible performance improvement (if any at all) with my

Re: [FFmpeg-devel] [DECISION] Include more developers in the voting committee [#4]

2019-04-13 Thread Marton Balint
On Sat, 13 Apr 2019, James Almer wrote: On 4/13/2019 7:47 PM, Marton Balint wrote: On Sat, 6 Apr 2019, Balint Marton wrote: Hi All Here is a call for the people in the voting committee [1] on the decision of extending it. [...] Some of these developers are already in the voting commit

Re: [FFmpeg-devel] [DECISION] Include more developers in the voting committee [#4]

2019-04-13 Thread James Almer
On 4/13/2019 7:47 PM, Marton Balint wrote: > > On Sat, 6 Apr 2019, Balint Marton wrote: > >> Hi All >> >> Here is a call for the people in the voting committee [1] on the >> decision of extending it. >> > [...] >> >> Some of these developers are already in the voting committee, the new >> ones wo

Re: [FFmpeg-devel] [PATCH V1] avformat/avformat.h: correct the comment for AVInputFormat.extensions

2019-04-13 Thread Michael Niedermayer
On Sat, Apr 13, 2019 at 08:46:06AM +0800, Jun Zhao wrote: > From: Jun Zhao > > Now the probe logic is: Only read_probe is NULL and extensions are defined, > then no probe is done. Correct the comment to follow the coding logic. > > Signed-off-by: Jun Zhao > --- > libavformat/avformat.h |4

Re: [FFmpeg-devel] [PATCH]lavfi/fspp: Add a cast to silence a clang warning

2019-04-13 Thread Michael Niedermayer
On Sat, Apr 13, 2019 at 07:25:54PM -0300, James Almer wrote: > On 4/13/2019 7:04 PM, Carl Eugen Hoyos wrote: > > Hi! > > > > Attached patch silences two warnings shown when compiling with clang: > > libavfilter/vf_fspp.h:51:42: warning: implicit conversion from 'int' > > to 'int16_t' (aka 'short')

Re: [FFmpeg-devel] [DECISION] Include more developers in the voting committee [#4]

2019-04-13 Thread Marton Balint
On Sat, 6 Apr 2019, Balint Marton wrote: Hi All Here is a call for the people in the voting committee [1] on the decision of extending it. [...] Some of these developers are already in the voting committee, the new ones would be: Aman Gupta Gyan Doshi Jan Ekström Jun Zhao Karthick Jey

Re: [FFmpeg-devel] [PATCH]lavfi/fspp: Add a cast to silence a clang warning

2019-04-13 Thread James Almer
On 4/13/2019 7:04 PM, Carl Eugen Hoyos wrote: > Hi! > > Attached patch silences two warnings shown when compiling with clang: > libavfilter/vf_fspp.h:51:42: warning: implicit conversion from 'int' > to 'int16_t' (aka 'short') changes value from 44130 to -21406 > > Please comment, Carl Eugen > >

[FFmpeg-devel] [PATCH]lavfi/fspp: Add a cast to silence a clang warning

2019-04-13 Thread Carl Eugen Hoyos
Hi! Attached patch silences two warnings shown when compiling with clang: libavfilter/vf_fspp.h:51:42: warning: implicit conversion from 'int' to 'int16_t' (aka 'short') changes value from 44130 to -21406 Please comment, Carl Eugen From d731e523d9c5854183d20d37fe921f49fb048498 Mon Sep 17 00:00:00

[FFmpeg-devel] [GSOC] [PATCH v2] avfilter: add panorama filter

2019-04-13 Thread Eugene Lyapustin
Add filter for conversion between various panorama formats. Supported formats: equirectangular, cubemap 3x2, cubemap 6x1 Contributions: doc/filters: add panorama filter description unify remap calculation procedure add option for interpolation method Signed-off-by: Eugene Lyapust

Re: [FFmpeg-devel] [GSOC] [PATCH] avfilter: add panorama filter

2019-04-13 Thread Eugene Lyapustin
On 13.04.2019 19:30, Moritz Barsnick wrote: On Sat, Apr 13, 2019 at 15:50:14 +0300, Eugene Lyapustin wrote: +static inline int equal(double a, double b, double epsilon) +{ +return fabs(a - b) < epsilon; +} + +static inline int smaller(double a, double b, double epsilon) +{ +return ((a -

[FFmpeg-devel] [PATCH 1/2] avcodec/cbs_av1: add a function to get a payload size without trailing zero bytes

2019-04-13 Thread James Almer
Factor it out from cbs_av1_read_metadata_itut_t35() Signed-off-by: James Almer --- libavcodec/cbs_av1.c | 11 +++ libavcodec/cbs_av1_syntax_template.c | 10 +- 2 files changed, 12 insertions(+), 9 deletions(-) diff --git a/libavcodec/cbs_av1.c b/libavcodec/cbs_av

[FFmpeg-devel] [PATCH 1/3] avcodec/cbs_av1: add support for Padding OBUs

2019-04-13 Thread James Almer
Based on itut_t35 Matadata OBU parsing code. Signed-off-by: James Almer --- libavcodec/cbs_av1.c | 20 + libavcodec/cbs_av1.h | 7 ++ libavcodec/cbs_av1_syntax_template.c | 32 3 files changed, 59 insertions(+) di

[FFmpeg-devel] [PATCH 2/2 v2] avcodec/cbs_av1: add support for Padding OBUs

2019-04-13 Thread James Almer
Based on itut_t35 Matadata OBU parsing code. Signed-off-by: James Almer --- libavcodec/cbs_av1.c | 20 libavcodec/cbs_av1.h | 7 +++ libavcodec/cbs_av1_syntax_template.c | 24 3 files changed, 51 insertions(+) di

Re: [FFmpeg-devel] [PATCH 1/3] avcodec/cbs_av1: add support for Padding OBUs

2019-04-13 Thread James Almer
On 4/13/2019 4:21 PM, James Almer wrote: > Based on itut_t35 Matadata OBU parsing code. > > Signed-off-by: James Almer > --- > libavcodec/cbs_av1.c | 20 + > libavcodec/cbs_av1.h | 7 ++ > libavcodec/cbs_av1_syntax_template.c | 32

Re: [FFmpeg-devel] [PATCH] lavfi: add nlmeans_opencl filter

2019-04-13 Thread Mark Thompson
On 12/04/2019 08:38, Song, Ruiling wrote: +#define RELEASE_KERNEL(k)\ +do { \ +if (k) { \ +cle = clReleaseKernel(k);

Re: [FFmpeg-devel] [PATCH] lavfi: add colorkey_opencl filter

2019-04-13 Thread Mark Thompson
On 11/04/2019 03:42, Cld fire wrote: > On Wed, Apr 10, 2019 at 6:10 PM Mark Thompson wrote: >>> +// Make sure the input is a format we support >>> +if (fmt != AV_PIX_FMT_ARGB && >>> +fmt != AV_PIX_FMT_RGBA && >>> +fmt != AV_PIX_FMT_ABGR && >>> +f

Re: [FFmpeg-devel] [PATCH 1/2] avcodec/truemotion2: Fix integer overflow in tm2_decode_blocks()

2019-04-13 Thread Michael Niedermayer
On Wed, Mar 27, 2019 at 01:17:41AM +0100, Michael Niedermayer wrote: > Fixes: signed integer overflow: 255 + 2147483634 cannot be represented in > type 'int' > Fixes: > 13472/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_TRUEMOTION2_fuzzer-5712444142387200 > > Found-by: continuous fuzzing pr

Re: [FFmpeg-devel] [GSOC] [PATCH] avfilter: add panorama filter

2019-04-13 Thread Moritz Barsnick
On Sat, Apr 13, 2019 at 15:50:14 +0300, Eugene Lyapustin wrote: > libavfilter/Makefile | 1 + > libavfilter/allfilters.c | 1 + > libavfilter/vf_panorama.c | 637 ++ The documentation in doc/filters.texi also needs to be amended. > +static const AVOpt

Re: [FFmpeg-devel] [PATCH] avcodec: add LSCR decoder

2019-04-13 Thread Paul B Mahol
On 4/12/19, Paul B Mahol wrote: > Signed-off-by: Paul B Mahol > --- > libavcodec/Makefile | 1 + > libavcodec/allcodecs.c | 1 + > libavcodec/avcodec.h| 1 + > libavcodec/codec_desc.c | 7 +++ > libavcodec/pngdec.c | 135 > libavforma

Re: [FFmpeg-devel] [GSOC] [PATCH] avfilter: add panorama filter

2019-04-13 Thread Paul B Mahol
Hi, On 4/13/19, Eugene Lyapustin wrote: > Add filter for conversion between various panorama formats. > Supported formats: equirectangular, cubemap 3x2, cubemap 6x1 > > Contributions: > > unify remap calculation procedure > add option for interpolation method > > Signed-off-by: Eugene

[FFmpeg-devel] [PATCH v3 1/2] avcodec/videotoolbox: add support for 10bit pixel format

2019-04-13 Thread der richter
From: fumoboy007 this patch was originally posted on issue #7704 and was slightly adjusted to check for the availability of the pixel format. --- configure | 2 ++ fftools/ffmpeg_videotoolbox.c | 3 +++ libavcodec/videotoolbox.c | 34 +

[FFmpeg-devel] [PATCH v3 2/2] avcodec/videotoolbox: add support for full range pixel formats

2019-04-13 Thread der richter
From: Akemi --- fftools/ffmpeg_videotoolbox.c | 6 -- libavcodec/videotoolbox.c | 14 +- libavutil/hwcontext_videotoolbox.c | 20 ++-- libavutil/hwcontext_videotoolbox.h | 6 ++ 4 files changed, 33 insertions(+), 13 deletions(-) diff --git a/f

Re: [FFmpeg-devel] [PATCH 2/3] avcodec/h264: error out on ff_h264_pred_weight_table() only if strict spec compliance is requested

2019-04-13 Thread James Almer
On 4/13/2019 10:46 AM, Carl Eugen Hoyos wrote: > 2019-04-13 15:28 GMT+02:00, James Almer : > >> It would be nice to know what the reference decoder does > > That's why I told you;-) I must have missed it. Outside of saying its output is bitexact for the first sample as ffmpeg after my patch, i d

[FFmpeg-devel] [PATCH 3/3] lavf/webm_chunk: Correct duration if start time > 0

2019-04-13 Thread Andreas Rheinhardt via ffmpeg-devel
Up until now, it was simply presumed that the first packet had a pts of zero; otherwise the duration of the first chunk was wrong. Signed-off-by: Andreas Rheinhardt --- libavformat/webm_chunk.c | 10 ++ 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/libavformat/webm_chunk.

Re: [FFmpeg-devel] [PATCH 2/3] avcodec/h264: error out on ff_h264_pred_weight_table() only if strict spec compliance is requested

2019-04-13 Thread Carl Eugen Hoyos
2019-04-13 15:28 GMT+02:00, James Almer : > It would be nice to know what the reference decoder does That's why I told you;-) Carl Eugen ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscr

Re: [FFmpeg-devel] [PATCH 2/3] avcodec/h264: error out on ff_h264_pred_weight_table() only if strict spec compliance is requested

2019-04-13 Thread James Almer
On 4/13/2019 10:28 AM, James Almer wrote: > On 4/13/2019 5:44 AM, Carl Eugen Hoyos wrote: >> 2019-04-10 21:47 GMT+02:00, Carl Eugen Hoyos : >>> 2019-04-09 20:32 GMT+02:00, James Almer : Fixes ticket #7174. Signed-off-by: James Almer --- This makes what's essentially a non

[FFmpeg-devel] [PATCH 2/3] lavf/webm_chunk: Fix NULL dereference

2019-04-13 Thread Andreas Rheinhardt
The earlier version of the webm_chunk muxer had several bugs: 1. If the first packet of an audio stream didn't have a PTS of zero, then no chunk will be started before a packet is delivered to the underlying Matroska/WebM muxer, i.e. the AVFormatContext used to write these packets had a NULL as AV

[FFmpeg-devel] [PATCH 1/3] lavf/webm_chunk: Respect buffer size

2019-04-13 Thread Andreas Rheinhardt via ffmpeg-devel
The last argument of av_strlcpy is supposed to contain the size of the destination buffer, but it was filled with the size of the source string, effectively negating its very purpose. Signed-off-by: Andreas Rheinhardt --- libavformat/webm_chunk.c | 2 +- 1 file changed, 1 insertion(+), 1 deletio

Re: [FFmpeg-devel] [PATCH 2/3] avcodec/h264: error out on ff_h264_pred_weight_table() only if strict spec compliance is requested

2019-04-13 Thread James Almer
On 4/13/2019 5:44 AM, Carl Eugen Hoyos wrote: > 2019-04-10 21:47 GMT+02:00, Carl Eugen Hoyos : >> 2019-04-09 20:32 GMT+02:00, James Almer : >>> Fixes ticket #7174. >>> >>> Signed-off-by: James Almer >>> --- >>> This makes what's essentially a non spec compliant >>> stream decodable again with no v

Re: [FFmpeg-devel] [PATCH v2 1/2] avcodec/videotoolbox: add support for 10bit pixel format

2019-04-13 Thread Aman Gupta
On Sat, Apr 13, 2019 at 3:25 AM der richter wrote: > From: fumoboy007 > > this patch was originally posted on issue #7704 and was slightly > adjusted to check for the availability of the pixel format. > --- > configure | 2 ++ > fftools/ffmpeg_videotoolbox.c | 3

[FFmpeg-devel] [GSOC] [PATCH] avfilter: add panorama filter

2019-04-13 Thread Eugene Lyapustin
Add filter for conversion between various panorama formats. Supported formats: equirectangular, cubemap 3x2, cubemap 6x1 Contributions: unify remap calculation procedure add option for interpolation method Signed-off-by: Eugene Lyapustin --- use bilinear from cubemap to eq

[FFmpeg-devel] [GSOC] [PATCH] avfilter: add panorama filter

2019-04-13 Thread Eugene Lyapustin
Hello, This patch is a qualification task on 360 video filter. I took a filter originally written by Paul B Mahol, and which was modified last year by another student. The filter had a lot of hardcoded conversions between formats, and it would be a pain to extend it with new ones. So I unified t

[FFmpeg-devel] [PATCH] avutil/colorspace: add macros for RGB->YUV BT.709

2019-04-13 Thread Gyan
Will be helpful for correct result in filters that paint like fillborders/drawbox or those using drawutils. Gyan From 9c83440a0ac048a1dcb0762b85adbce5a58e0939 Mon Sep 17 00:00:00 2001 From: Gyan Doshi Date: Sat, 13 Apr 2019 17:01:09 +0530 Subject: [PATCH] avutil/colorspace: add macros for RGB->

[FFmpeg-devel] [PATCH v2 1/2] avcodec/videotoolbox: add support for 10bit pixel format

2019-04-13 Thread der richter
From: fumoboy007 this patch was originally posted on issue #7704 and was slightly adjusted to check for the availability of the pixel format. --- configure | 2 ++ fftools/ffmpeg_videotoolbox.c | 3 +++ libavcodec/videotoolbox.c | 32 +

[FFmpeg-devel] [PATCH v2 2/2] avcodec/videotoolbox: add support for full range pixel formats

2019-04-13 Thread der richter
From: Akemi --- fftools/ffmpeg_videotoolbox.c | 6 -- libavcodec/videotoolbox.c | 14 +- libavutil/hwcontext_videotoolbox.c | 20 ++-- libavutil/hwcontext_videotoolbox.h | 6 ++ 4 files changed, 33 insertions(+), 13 deletions(-) diff --git a/f

Re: [FFmpeg-devel] [PATCH 2/3] avcodec/h264: error out on ff_h264_pred_weight_table() only if strict spec compliance is requested

2019-04-13 Thread Carl Eugen Hoyos
2019-04-10 21:47 GMT+02:00, Carl Eugen Hoyos : > 2019-04-09 20:32 GMT+02:00, James Almer : >> Fixes ticket #7174. >> >> Signed-off-by: James Almer >> --- >> This makes what's essentially a non spec compliant >> stream decodable again with no visual artifacts, and >> without reintroducing the risk