Signed-off-by: Linjie Fu
---
doc/encoders.texi | 7 +++
1 file changed, 7 insertions(+)
diff --git a/doc/encoders.texi b/doc/encoders.texi
index eefd124751..2e54dcc15f 100644
--- a/doc/encoders.texi
+++ b/doc/encoders.texi
@@ -2899,6 +2899,13 @@ will refer only to P- or I-frames. When set t
> -Original Message-
> From: myp...@gmail.com [mailto:myp...@gmail.com]
> Sent: Wednesday, June 12, 2019 16:14
> To: FFmpeg development discussions and patches de...@ffmpeg.org>
> Cc: Fu, Linjie
> Subject: Re: [FFmpeg-devel] [PATCH, v2] lavc/vaapi_encode: add support for
> AVC Trellis
>
Trellis quantization is an algorithm that can improve data compression
in DCT-based encoding methods. It reduces the size of some DCT
coefficients while recovering others to take their place.
Trellis quantization effectively finds the optimal quantization for
each block to maximize the PSNR relati
Andreas Rheinhardt:
> Hello,
>
> I have added the necessary numbers for the index version (which you can
> find at https://github.com/mkver/FFmpeg/commits/start_6 if you care) to
> the commit message of the first patch and have also adapted the
> overread check as you suggested (no performance imp
Hi, RonaldHave you see the reply of Haihao？
He mentioned that decode_frame_header() has use s->s.refs[s->s.h.refidx[i]].f
without safe check.
For this suggestion, We must avoid the point on vp9.c 794-795.Could I restore
the null point in decode_frame_header()？
Thanks,Cen
原始信息 由
Deleting a unit from a fragment in CBS only fails if there is no unit
in the fragment corresponding to the position given as argument to
ff_cbs_delete_unit. Given that ff_cbs_h264_delete_sei_message asserts
this to be so, we know that the call to ff_cbs_delete_unit can never
fail and hence ff_cbs_h
ff_cbs_delete_unit never fails if the index of the unit to delete is
valid; document this behaviour explicitly and remove the checks for
whether ff_cbs_delete_unit failed, because all the callers of
ff_cbs_delete_unit already make sure that the index is valid.
Signed-off-by: Andreas Rheinhardt
--
The recent changes to h264_metadata (enabled by the recent changes to
ff_cbs_write_packet) made it possible to add side_data to the output
packet at any place, not only after the output packet has been written
and the properties of the input packet copied. This means that one can
now localize the c
This commit changes h265_metadata to (a) use ff_bsf_get_packet_ref
instead of ff_bsf_get_packet (thereby avoiding one malloc and free per
filtered packet) and (b) to use only one packet structure at all,
thereby avoiding a call to av_packet_copy_props.
(b) has been made possible by the recent chan
According to the BSF API, when a BSF is finished with an input packet,
it should return AVERROR(EAGAIN) to signal that another packet should be
sent to the BSF via av_bsf_send_packet that the actual BSF can receive
via ff_bsf_get_packet[_ref]. filter_units on the other hand simply called
ff_bsf_get
Signed-off-by: Andreas Rheinhardt
---
libavcodec/filter_units_bsf.c | 46 +--
1 file changed, 23 insertions(+), 23 deletions(-)
diff --git a/libavcodec/filter_units_bsf.c b/libavcodec/filter_units_bsf.c
index a787933f0a..8c501e1726 100644
--- a/libavcodec/filter_u
This commit changes av1_metadata to (a) use ff_bsf_get_packet_ref
instead of ff_bsf_get_packet (thereby avoiding one malloc and free per
filtered packet) and (b) to use only one packet structure at all,
thereby avoiding a call to av_packet_copy_props.
(b) has been made possible by the recent chang
According to the API, the packet structure a bsf receives must not be
touched on failure, yet filter_units nevertheless did it.
Signed-off-by: Andreas Rheinhardt
---
libavcodec/filter_units_bsf.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/libavcodec/filter_units_bsf.c b/libavcodec/fil
This commit changes h264_metadata to (a) use ff_bsf_get_packet_ref
instead of ff_bsf_get_packet (thereby avoiding one malloc and free per
filtered packet) and (b) to use only one packet structure at all,
thereby avoiding a call to av_packet_copy_props.
(b) has been made possible by the recent chan
Up until now, ff_cbs_write_packet always initialized the packet
structure it received without documenting this behaviour; furthermore,
the packet's buffer would (on success) be overwritten with the new
buffer without unreferencing the old. This meant that the input packet
had to be either clean (ot
This commit changes mpeg2_metadata to (a) use ff_bsf_get_packet_ref
instead of ff_bsf_get_packet (thereby avoiding one malloc and free per
filtered packet) and (b) to use only one packet structure at all,
thereby avoiding a call to av_packet_copy_props.
(b) has been made possible by the recent cha
When testing whether a particular unit should be kept or discarded, it
is best to start at the very last unit of a fragment and count down,
because that way a unit that will eventually be deleted won't be
memmoved during earlier deletions; and frag/au->nb_units need only be
evaluated once in this c
This commit changes h264_redundant_pps to (a) use ff_bsf_get_packet_ref
instead of ff_bsf_get_packet (thereby avoiding one malloc and free per
filtered packet) and (b) to use only one packet structure at all,
thereby avoiding a call to av_packet_copy_props.
(b) has been made possible by the recent
This commit changes vp9_metadata to (a) use ff_bsf_get_packet_ref
instead of ff_bsf_get_packet (thereby avoiding one malloc and free per
filtered packet) and (b) to use only one packet structure at all,
thereby avoiding a call to av_packet_copy_props.
(b) has been made possible by the recent chang
This commit changes filter_units to (a) use ff_bsf_get_packet_ref
instead of ff_bsf_get_packet (thereby avoiding one malloc and free per
filtered packet) and (b) to use only one packet structure at all,
thereby avoiding a call to av_packet_copy_props (or, in case of
passthrough, to av_packet_move_r
When looping over an access unit's units in positive direction and
deleting some of them, one needs to make sure that a unit that is at
the position of a unit that just got deleted gets checked, too.
Signed-off-by: Andreas Rheinhardt
---
libavcodec/h264_redundant_pps_bsf.c | 2 ++
1 file changed
If a new sequence display extension had to be added, this was up until
now done at two places: One where a sequence display extension was
initialized with default values and one where the actual sequence
display extension was inserted into the fragment. This division of
labour is unnecessary and po
Signed-off-by: Andreas Rheinhardt
---
libavcodec/h265_metadata_bsf.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/libavcodec/h265_metadata_bsf.c b/libavcodec/h265_metadata_bsf.c
index 2fb74aea5a..0dd7634774 100644
--- a/libavcodec/h265_metadata_bsf.c
+++ b/libavcodec/h265_m
Hello,
this patchset is mainly about switching the bitstream filters using cbs
from ff_bsf_get_packet to ff_bsf_get_packet_ref (except trace_headers,
which also uses it). But in the course of doing so, I also found several
other (usually small) things to improve and this is included here.
This pa
On 6/13/2019 3:32 PM, Michael Niedermayer wrote:
> Fixes: signed integer overflow: -2147483648 - 1 cannot be represented in type
> 'int'
> Fixes:
> 14880/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_HEVC_fuzzer-5130977304641536
>
> Found-by: continuous fuzzing process
> https://github.com/
> -Original Message-
> From: ffmpeg-devel [mailto:ffmpeg-devel-boun...@ffmpeg.org] On Behalf
> Of Michael Niedermayer
> Sent: Sunday, June 16, 2019 6:07 AM
> To: FFmpeg development discussions and patches de...@ffmpeg.org>
> Subject: Re: [FFmpeg-devel] [PATCH 2/4] avcodec/hevc_ps: Fix inte
On 16.06.2019, at 17:12, Paul B Mahol wrote:
> On 6/16/19, Reimar Döffinger wrote:
>>
>>
>> On 16.06.2019, at 12:30, Lynne wrote:
>>
>>> Jun 16, 2019, 10:57 AM by mich...@niedermayer.cc:
>>>
Fixes: left shift of negative value -4
Fixes: signed integer overflow: -15091694 * 167 can
Fixes: global-buffer-overflow
Fixes:
15247/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_ATRAC9_fuzzer-5671602181636096
Found-by: continuous fuzzing process
https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg
Signed-off-by: Michael Niedermayer
---
libavcodec/atrac9dec.c | 8 +++
Fixes: global-buffer-overflow
Fixes:
15247/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_ATRAC9_fuzzer-5671602181636096
Found-by: continuous fuzzing process
https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg
Signed-off-by: Michael Niedermayer
---
libavcodec/atrac9dec.c | 2 ++
On Sun, Jun 16, 2019 at 08:31:37PM +0200, Lynne wrote:
> Jun 16, 2019, 4:12 PM by one...@gmail.com:
>
> > On 6/16/19, Reimar Döffinger wrote:
> >
> >>
> >>
> >> On 16.06.2019, at 12:30, Lynne wrote:
> >>
> >>> Jun 16, 2019, 10:57 AM by mich...@niedermayer.cc:
> >>>
> Fixes: left shift of ne
On 6/15/2019 7:00 PM, Michael Niedermayer wrote:
> Fixes: Direct leak of 536 byte(s) in 1 object(s)
> Fixes:
> 15266/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_BINK_fuzzer-5629530426834944
>
> Found-by: continuous fuzzing process
> https://github.com/google/oss-fuzz/tree/master/projects/f
On Sun, Jun 16, 2019 at 12:20:35PM +0200, Lynne wrote:
> Jun 15, 2019, 11:00 PM by mich...@niedermayer.cc:
>
> > Fixes: global-buffer-overflow
> > Fixes:
> > 15247/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_ATRAC9_fuzzer-5671602181636096
> >
> > Found-by: continuous fuzzing process
> > ht
Jun 16, 2019, 4:12 PM by one...@gmail.com:
> On 6/16/19, Reimar Döffinger wrote:
>
>>
>>
>> On 16.06.2019, at 12:30, Lynne wrote:
>>
>>> Jun 16, 2019, 10:57 AM by mich...@niedermayer.cc:
>>>
Fixes: left shift of negative value -4
Fixes: signed integer overflow: -15091694 * 167 cannot b
Fixes: signed integer overflow: 214013 * 2531011 cannot be represented in type
'int'
Fixes:
15254/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_QDMC_fuzzer-5698137026461696
Found-by: continuous fuzzing process
https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg
Signed-off-by: Mic
Fixes: left shift of negative value -4483
Fixes:
15256/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_TTA_fuzzer-5738691617619968
Found-by: continuous fuzzing process
https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg
Signed-off-by: Michael Niedermayer
---
libavcodec/tta.c | 2 +
Fixes: left shift of negative value -13
Fixes:
15260/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_VC1_fuzzer-5702076048343040
Found-by: continuous fuzzing process
https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg
Signed-off-by: Michael Niedermayer
---
libavcodec/vc1dsp.c | 16
Fixes: signed integer overflow: 2314885530818453536 - -8926099139098304480
cannot be represented in type 'long'
Fixes:
15259/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_FFWAVESYNTH_fuzzer-5764366093254656
Found-by: continuous fuzzing process
https://github.com/google/oss-fuzz/tree/master/
Fixes: division by zero
Fixes:
15257/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_BINTEXT_fuzzer-5757352881422336
Found-by: continuous fuzzing process
https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg
Signed-off-by: Michael Niedermayer
---
libavcodec/bintext.c | 4
1 fil
Fixes: shift exponent 64 is too large for 32-bit type 'int'
Fixes:
15253/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_RV10_fuzzer-5671114300194816
Found-by: continuous fuzzing process
https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg
Signed-off-by: Michael Niedermayer
---
lib
> On Jun 15, 2019, at 7:54 PM, Lance Wang wrote:
>
>> On Fri, Jun 7, 2019 at 11:13 PM wrote:
>>
>> From: Limin Wang
>>
>> Signed-off-by: Limin Wang
>> ---
>> libavcodec/videotoolboxenc.c | 5 +
>> 1 file changed, 5 insertions(+)
>>
>> diff --git a/libavcodec/videotoolboxenc.c b/libavcod
On 6/16/19, Reimar Döffinger wrote:
>
>
> On 16.06.2019, at 12:30, Lynne wrote:
>
>> Jun 16, 2019, 10:57 AM by mich...@niedermayer.cc:
>>
>>> Fixes: left shift of negative value -4
>>> Fixes: signed integer overflow: -15091694 * 167 cannot be represented in
>>> type 'int'
>>> Fixes: signed intege
On Sun, Jun 16, 2019 at 2:12 PM Paul B Mahol wrote:
> On 6/16/19, Swaraj Hota wrote:
> > On Sun 16 Jun, 2019, 8:24 AM Peter Ross, wrote:
> >
> >> On Mon, Jun 10, 2019 at 09:25:27AM +0530, Swaraj Hota wrote:
> >> > Fixes ticket #2956.
> >> >
> >> > Signed-off-by: Swaraj Hota
> >> > ---
> >> > A
On 16.06.2019, at 12:30, Lynne wrote:
> Jun 16, 2019, 10:57 AM by mich...@niedermayer.cc:
>
>> Fixes: left shift of negative value -4
>> Fixes: signed integer overflow: -15091694 * 167 cannot be represented in
>> type 'int'
>> Fixes: signed integer overflow: 1898547155 + 453967445 cannot be r
On 14.06.2019, at 17:01, James Almer wrote:
> On 6/14/2019 11:52 AM, Reimar Döffinger wrote:
>>
>>
>> On 14.06.2019, at 03:15, Chris Cunningham wrote:
>>
>>> Only "succeed" to read a header if the codec is valid. Otherwise
>>> return AVERROR_INVALIDDATA.
>>
>> That doesn't sound right to me,
> 在 2019年6月16日，19:42，Jun Zhao 写道：
>
> From: Jun Zhao
>
> Update suboption for hls_playlist_type
>
> Signed-off-by: Jun Zhao
> ---
> libavformat/hlsenc.c |1 +
> 1 files changed, 1 insertions(+), 0 deletions(-)
>
> diff --git a/libavformat/hlsenc.c b/libavformat/hlsenc.c
> index 9884f74.
From: Jun Zhao
fix and update docs for hls_playlist_type
Signed-off-by: Jun Zhao
---
doc/muxers.texi | 16 ++--
1 files changed, 14 insertions(+), 2 deletions(-)
diff --git a/doc/muxers.texi b/doc/muxers.texi
index 50147c4..b2fbe3f 100644
--- a/doc/muxers.texi
+++ b/doc/muxers.t
From: Jun Zhao
Update suboption for hls_playlist_type
Signed-off-by: Jun Zhao
---
libavformat/hlsenc.c |1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/libavformat/hlsenc.c b/libavformat/hlsenc.c
index 9884f74..6c0d0a5 100644
--- a/libavformat/hlsenc.c
+++ b/libavformat
Jun 16, 2019, 10:57 AM by mich...@niedermayer.cc:
> Fixes: left shift of negative value -4
> Fixes: signed integer overflow: -15091694 * 167 cannot be represented in type
> 'int'
> Fixes: signed integer overflow: 1898547155 + 453967445 cannot be represented
> in type 'int'
> Fixes:
> 15258/clus
Jun 15, 2019, 11:00 PM by mich...@niedermayer.cc:
> Fixes: global-buffer-overflow
> Fixes:
> 15247/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_ATRAC9_fuzzer-5671602181636096
>
> Found-by: continuous fuzzing process
> https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg
> Signed-o
Fixes:
15255/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_APE_fuzzer-5718831688843264
Fixes: left shift of 1 by 31 places cannot be represented in type 'int'
Found-by: continuous fuzzing process
https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg
Signed-off-by: Michael Niedermaye
Fixes: signed integer overflow: -538976267 * 31 cannot be represented in type
'int'
Fixes: left shift of 65312 by 16 places cannot be represented in type 'int'
Fixes:
15255/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_APE_fuzzer-5718831688843264
Found-by: continuous fuzzing process
https:/
Fixes: left shift of negative value -4
Fixes: signed integer overflow: -15091694 * 167 cannot be represented in type
'int'
Fixes: signed integer overflow: 1898547155 + 453967445 cannot be represented in
type 'int'
Fixes:
15258/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_APE_fuzzer-57590955
Fixes: signed integer overflow: -829262115 + -1410750414 cannot be represented
in type 'int'
Fixes:
15251/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_APE_fuzzer-5651742252859392
Found-by: continuous fuzzing process
https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg
Signed-off-
On Sun, Jun 16, 2019 at 3:24 PM Michael Niedermayer
wrote:
> On Sat, Jun 15, 2019 at 12:48:25AM +0800, lance.lmw...@gmail.com wrote:
> > From: Limin Wang
> >
> > Signed-off-by: Limin Wang
> > ---
> > libavfilter/vf_cover_rect.c | 17 ++---
> > 1 file changed, 10 insertions(+), 7 de
On Sun, Jun 16, 2019 at 3:26 PM Michael Niedermayer
wrote:
> On Sun, Jun 16, 2019 at 07:11:27AM +0800, Lance Wang wrote:
> > On Sun, Jun 16, 2019 at 6:20 AM Michael Niedermayer
>
> > wrote:
> >
> > > On Fri, Jun 14, 2019 at 11:52:47PM +0800, Lance Wang wrote:
> > > > On Fri, Jun 14, 2019 at 5:31
On 6/16/19, Swaraj Hota wrote:
> On Sun 16 Jun, 2019, 8:24 AM Peter Ross, wrote:
>
>> On Mon, Jun 10, 2019 at 09:25:27AM +0530, Swaraj Hota wrote:
>> > Fixes ticket #2956.
>> >
>> > Signed-off-by: Swaraj Hota
>> > ---
>> > Added entry in "doc/general.texi".
>> > ---
>> > Changelog
On Sun 16 Jun, 2019, 8:24 AM Peter Ross, wrote:
> On Mon, Jun 10, 2019 at 09:25:27AM +0530, Swaraj Hota wrote:
> > Fixes ticket #2956.
> >
> > Signed-off-by: Swaraj Hota
> > ---
> > Added entry in "doc/general.texi".
> > ---
> > Changelog| 1 +
> > doc/general.texi |
On Sun, Jun 16, 2019 at 12:37:32PM +1000, Peter Ross wrote:
> On Sun, Jun 16, 2019 at 12:00:55AM +0200, Michael Niedermayer wrote:
> > Fixes: Direct leak of 536 byte(s) in 1 object(s)
> > Fixes:
> > 15266/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_BINK_fuzzer-5629530426834944
> >
> > Found
On Fri, Jun 14, 2019 at 07:35:44AM -0700, Amir Pauker wrote:
> FF_DECODE_ERROR_CONCEALMENT_ACTIVE is set when the decoded frame has error(s)
> but the returned value from
> avcodec_receive_frame is zero i.e. concealed errors
>
> Signed-off-by: Amir Pauker
> ---
> doc/APIchanges | 3 +++
>
On Fri, Jun 14, 2019 at 07:43:46AM -0700, Amir Pauker wrote:
> set AVFrame decode_error_flags to FF_DECODE_ERROR_CONCEALMENT_ACTIVE in case
> h->slice_ctx->er.error_occurred is set after the call to
> ff_h264_execute_decode_slices.
> This allows the user to detect concealed decoding errors in the
On Fri, Jun 14, 2019 at 08:51:34PM +0100, Cameron Cawley wrote:
> Signed-off-by: Cameron Cawley
> ---
> libavformat/rpl.c | 78
> +++
> 1 file changed, 44 insertions(+), 34 deletions(-)
a fate test for this probably would make sense
[...]
--
On Sun, Jun 16, 2019 at 01:13:38AM +0800, Jun Zhao wrote:
> From: Jun Zhao
>
> Redundant condition: '!A || B' is equivalent to '!A || (A && B)' but
> more clearly.
>
> Signed-off-by: Jun Zhao
> ---
> libavfilter/af_asetnsamples.c |2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
On Sat, Jun 15, 2019 at 12:48:24AM +0800, lance.lmw...@gmail.com wrote:
> From: Limin Wang
>
> Signed-off-by: Limin Wang
> ---
> doc/filters.texi | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/doc/filters.texi b/doc/filters.texi
> index ec1c7c7..4d48068 100644
> -
On Sun, Jun 16, 2019 at 07:11:27AM +0800, Lance Wang wrote:
> On Sun, Jun 16, 2019 at 6:20 AM Michael Niedermayer
> wrote:
>
> > On Fri, Jun 14, 2019 at 11:52:47PM +0800, Lance Wang wrote:
> > > On Fri, Jun 14, 2019 at 5:31 PM Michael Niedermayer
> >
> > > wrote:
[...]
> >
> > >
> > >
> > > >
>
On Sat, Jun 15, 2019 at 12:48:25AM +0800, lance.lmw...@gmail.com wrote:
> From: Limin Wang
>
> Signed-off-by: Limin Wang
> ---
> libavfilter/vf_cover_rect.c | 17 ++---
> 1 file changed, 10 insertions(+), 7 deletions(-)
>
> diff --git a/libavfilter/vf_cover_rect.c b/libavfilter/vf_
65 matches
Mail list logo
