> -Original Message-
> From: James Zern [mailto:jz...@google.com]
> Sent: Tuesday, August 27, 2019 12:03 PM
> To: FFmpeg development discussions and patches
> Cc: Guo, Yejun
> Subject: Re: [FFmpeg-devel] [PATCH V5] avcodec/libvpxenc: add ROI-based
> encoding support for VP8/VP9 support
LGTM
On Mon, Aug 26, 2019 at 8:28 PM James Almer wrote:
> The reference frame isn't valid after seeking
>
> Signed-off-by: James Almer
> ---
> libavcodec/qtrle.c | 9 +
> 1 file changed, 9 insertions(+)
>
> diff --git a/libavcodec/qtrle.c b/libavcodec/qtrle.c
> index 3255c64063..102198
Hi,
On Thu, Aug 22, 2019 at 5:56 PM Guo, Yejun wrote:
>
> example command line to verify it:
> ./ffmpeg -i input.stream -vf addroi=0:0:iw/3:ih/3:-0.8 -c:v libvpx -b:v 2M
> tmp.webm
>
> Signed-off-by: Guo, Yejun
> ---
> libavcodec/libvpxenc.c | 194
> +++
Signed-off-by: Steven Liu
---
libavfilter/vf_delogo.c | 72 ++---
1 file changed, 68 insertions(+), 4 deletions(-)
diff --git a/libavfilter/vf_delogo.c b/libavfilter/vf_delogo.c
index 065d093641..b50699fb4d 100644
--- a/libavfilter/vf_delogo.c
+++ b/libavfilte
On 8/26/2019 5:30 PM, Michael Niedermayer wrote:
> On Mon, Aug 26, 2019 at 05:23:22PM -0300, James Almer wrote:
>> On 8/26/2019 5:20 PM, Michael Niedermayer wrote:
>>> On Mon, Aug 26, 2019 at 01:17:25PM -0300, James Almer wrote:
Used to signal frames that can be safely discarded without losing
On Sat, Aug 24, 2019, at 19:23, Lauri Kasanen wrote:
> Hi,
>
> I approve of this series, but being in the middle of a move, I can't
> test it.
Alright, thanks. It's not urgent (distros that have this broken can patch
locally for the time being), but would be nice to go through it once you have
>
>
> Lets check H264
> claim "They do not have a timestamp"
> immedeatly after the pic_struct field which tells you about the repeating
> behavior there is a loop for each repeated value with a timestamp.
> This timestamp is lost, if at CFR one can call it that way.
>
> about "Every encoded frame
>
> "time of origin, capture" is clearly a timecode, not a timestamp in
> the sense we're talking about here (plus that the bitstream codes it
> in hours/minutes/seconds). I expect you know the difference.
> If these timecodes are considered useful it would be trivial to expose
> them from the deco
Follow the description of av_realloc, the memory needs to be allocated
by av_realloc.
---
libavcodec/cbs_h2645.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/libavcodec/cbs_h2645.c b/libavcodec/cbs_h2645.c
index 69ea6dc6bb..8da8421e47 100644
--- a/libavcodec/cbs_h2645.c
+++
On Mon, Aug 26, 2019 at 9:38 PM Michael Niedermayer
wrote:
>
> On Mon, Aug 26, 2019 at 01:45:55PM +0200, Hendrik Leppkes wrote:
> > On Mon, Aug 26, 2019 at 11:09 AM Michael Niedermayer
> > wrote:
> > >
> > > On Mon, Aug 26, 2019 at 09:51:45AM +0200, Hendrik Leppkes wrote:
> > > > On Mon, Aug 26,
On Sun, Aug 25, 2019 at 03:22:02 +0530, Shivam wrote:
> The patch contains DICOM demuxer. I have improved the code as suggested.
Second part of my review:
> From: Shivam Goyal <1998.goyal.shi...@gmail.com>
> Date: Sun, 25 Aug 2019 02:57:35 +0530
> Subject: [PATCH] lavf: Add DICOM demuxer
>
> ---
On Sun, Aug 25, 2019 at 03:20:13 +0530, Shivam wrote:
> The patch contains DICOM decoder. I have improved the code as suggested.
Hi Shivan,
nice job.
First of all, all your samples now appear to demux and decode properly.
I didn't get a chance to look at their output, but I guess you have
that co
On Mon, Aug 26, 2019 at 05:23:22PM -0300, James Almer wrote:
> On 8/26/2019 5:20 PM, Michael Niedermayer wrote:
> > On Mon, Aug 26, 2019 at 01:17:25PM -0300, James Almer wrote:
> >> Used to signal frames that can be safely discarded without losing
> >> any picture data, side data, or metadata other
On 8/26/2019 5:20 PM, Michael Niedermayer wrote:
> On Mon, Aug 26, 2019 at 01:17:25PM -0300, James Almer wrote:
>> Used to signal frames that can be safely discarded without losing
>> any picture data, side data, or metadata other than timing info.
>>
>> Signed-off-by: James Almer
>> ---
>> This i
On Mon, Aug 26, 2019 at 01:17:25PM -0300, James Almer wrote:
> Used to signal frames that can be safely discarded without losing
> any picture data, side data, or metadata other than timing info.
>
> Signed-off-by: James Almer
> ---
> This implements the "disposable frame" solution to allow libra
On Mon, Aug 26, 2019 at 01:45:55PM +0200, Hendrik Leppkes wrote:
> On Mon, Aug 26, 2019 at 11:09 AM Michael Niedermayer
> wrote:
> >
> > On Mon, Aug 26, 2019 at 09:51:45AM +0200, Hendrik Leppkes wrote:
> > > On Mon, Aug 26, 2019 at 9:33 AM Michael Niedermayer
> > > wrote:
> > > >
> > > > On Sun,
ff_reget_buffer() will attempt to create a writable copy of the frame,
which is not needed when the decoder intends to return a reference to
the same buffer as the previous frame.
Should reduce data copy, hopefully achieving a similar speed up as
a9dacdeea6168787a142209bd19fdd74aefc9dd6 without dr
> On Aug 26, 2019, at 11:23 AM, Hendrik Leppkes wrote:
>
> On Mon, Aug 26, 2019 at 7:47 PM Baptiste Coudurier
> mailto:baptiste.coudur...@gmail.com>> wrote:
>>
>> Hey guys,
>>
>>
>>> On Aug 26, 2019, at 9:25 AM, James Almer wrote:
>>>
>>> On 8/26/2019 11:35 AM, Hendrik Leppkes wrote:
O
The reference frame isn't valid after seeking
Signed-off-by: James Almer
---
libavcodec/qtrle.c | 9 +
1 file changed, 9 insertions(+)
diff --git a/libavcodec/qtrle.c b/libavcodec/qtrle.c
index 3255c64063..1021986f01 100644
--- a/libavcodec/qtrle.c
+++ b/libavcodec/qtrle.c
@@ -571,6 +57
On Mon, Aug 26, 2019 at 7:47 PM Baptiste Coudurier
wrote:
>
> Hey guys,
>
>
> > On Aug 26, 2019, at 9:25 AM, James Almer wrote:
> >
> > On 8/26/2019 11:35 AM, Hendrik Leppkes wrote:
> >> On Mon, Aug 26, 2019 at 1:18 AM James Almer wrote:
> >>>
> >>> On 8/25/2019 7:14 PM, Michael Niedermayer wrot
On Mon, Aug 26, 2019 at 7:47 PM Baptiste Coudurier <
baptiste.coudur...@gmail.com> wrote:
> Hey guys,
>
>
> > On Aug 26, 2019, at 9:25 AM, James Almer wrote:
> >
> > On 8/26/2019 11:35 AM, Hendrik Leppkes wrote:
> >> On Mon, Aug 26, 2019 at 1:18 AM James Almer wrote:
> >>>
> >>> On 8/25/2019 7:1
Hey guys,
> On Aug 26, 2019, at 9:25 AM, James Almer wrote:
>
> On 8/26/2019 11:35 AM, Hendrik Leppkes wrote:
>> On Mon, Aug 26, 2019 at 1:18 AM James Almer wrote:
>>>
>>> On 8/25/2019 7:14 PM, Michael Niedermayer wrote:
On Sun, Aug 25, 2019 at 11:46:36PM +0200, Michael Niedermayer wrote
On Mon, Aug 26, 2019 at 7:45 PM Baptiste Coudurier <
baptiste.coudur...@gmail.com> wrote:
> Hi Paul,
>
>
> > On Aug 25, 2019, at 12:37 AM, Paul B Mahol wrote:
> >
> > On Sun, Aug 25, 2019 at 9:33 AM Michael Niedermayer
>
> > wrote:
> >
> >> On Fri, Aug 23, 2019 at 11:20:48AM -0300, James Almer w
Hi Paul,
> On Aug 25, 2019, at 12:37 AM, Paul B Mahol wrote:
>
> On Sun, Aug 25, 2019 at 9:33 AM Michael Niedermayer
> wrote:
>
>> On Fri, Aug 23, 2019 at 11:20:48AM -0300, James Almer wrote:
>>> On 8/8/2019 8:23 PM, Michael Niedermayer wrote:
Fixes: shift exponent 32 is too large for 32
ff_reget_buffer() will attempt to create a writable copy of the frame,
which is not needed when the decoder intends to return a reference to
the same buffer as the previous frame.
Should reduce data copy, hopefully achieving a similar speed up as
a9dacdeea6168787a142209bd19fdd74aefc9dd6 without dr
On 8/26/2019 11:35 AM, Hendrik Leppkes wrote:
> On Mon, Aug 26, 2019 at 1:18 AM James Almer wrote:
>>
>> On 8/25/2019 7:14 PM, Michael Niedermayer wrote:
>>> On Sun, Aug 25, 2019 at 11:46:36PM +0200, Michael Niedermayer wrote:
On Sun, Aug 25, 2019 at 01:22:22PM -0300, James Almer wrote:
>
Used to signal frames that can be safely discarded without losing
any picture data, side data, or metadata other than timing info.
Signed-off-by: James Almer
---
This implements the "disposable frame" solution to allow library
users to drop duplicate frames before further processing if desired,
i
This reverts commit a9dacdeea6168787a142209bd19fdd74aefc9dd6.
This patch effectively made the decoder output vfr content out of samples
where cfr is expected.
Addresses ticket #7880.
Signed-off-by: James Almer
---
libavcodec/qtrle.c| 12 ++---
tests/ref/fate/qtrle-8bit | 109 +
Signed-off-by: James Almer
---
Maybe we could also add an AV_CODEC_CAP_DISPOSABLE_FRAMES capability
to lavc and use it on relevant decoders like this one, to let the user
know to expect frames with this flag?
Although if lavc generic code doesn't do anything different for decoders
setting it, then
On Mon, Aug 26, 2019 at 1:18 AM James Almer wrote:
>
> On 8/25/2019 7:14 PM, Michael Niedermayer wrote:
> > On Sun, Aug 25, 2019 at 11:46:36PM +0200, Michael Niedermayer wrote:
> >> On Sun, Aug 25, 2019 at 01:22:22PM -0300, James Almer wrote:
> >>> On 8/24/2019 3:18 PM, Michael Niedermayer wrote:
On 8/26/2019 4:32 AM, Michael Niedermayer wrote:
> On Sun, Aug 25, 2019 at 08:04:03PM -0300, James Almer wrote:
>> On 8/25/2019 6:46 PM, Michael Niedermayer wrote:
>>> On Sun, Aug 25, 2019 at 01:22:22PM -0300, James Almer wrote:
On 8/24/2019 3:18 PM, Michael Niedermayer wrote:
> Fixes: Tic
On Sun, Aug 25, 2019 at 22:53:19 +0800, Steven Liu wrote:
Nitpicking:
> + * Get the HTTP shurdown reponse status, be used after http_shutdown.
^^
Typos: shutdown, response.
Moritz
___
ffmpeg-devel mailing list
ffmpeg-devel@ff
Hi,
‐‐‐ Original Message ‐‐‐
On Monday, 19 de August de 2019 21:16, Andreas Håkon
wrote:
> Hi,
>
> This is the third version of my patch for an "interleaved MPEG-TS muxer".
> This new version includes all recommendations and rebases the fix of the
> incorrect PCR with multiple programs
On Mon, Aug 26, 2019 at 11:09 AM Michael Niedermayer
wrote:
>
> On Mon, Aug 26, 2019 at 09:51:45AM +0200, Hendrik Leppkes wrote:
> > On Mon, Aug 26, 2019 at 9:33 AM Michael Niedermayer
> > wrote:
> > >
> > > On Sun, Aug 25, 2019 at 08:04:03PM -0300, James Almer wrote:
> > > > On 8/25/2019 6:46 PM
On Mon, Aug 26, 2019 at 11:09 AM Michael Niedermayer
wrote:
> On Mon, Aug 26, 2019 at 09:51:45AM +0200, Hendrik Leppkes wrote:
> > On Mon, Aug 26, 2019 at 9:33 AM Michael Niedermayer
> > wrote:
> > >
> > > On Sun, Aug 25, 2019 at 08:04:03PM -0300, James Almer wrote:
> > > > On 8/25/2019 6:46 PM,
Hi Marton,
‐‐‐ Original Message ‐‐‐
On Friday, 23 de August de 2019 23:13, Marton Balint wrote:
> On Fri, 23 Aug 2019, Marton Balint wrote:
>
> > On Fri, 16 Aug 2019, Andreas Håkon wrote:
> >
> > > Hi Marton,
> > > Very good work with your series of patches on the mpegtsenc!
> >
> > > A
On Mon, Aug 26, 2019 at 09:53:46AM +0200, Paul B Mahol wrote:
> On Sun, Aug 25, 2019 at 11:35 PM Michael Niedermayer
> wrote:
>
> > On Sun, Aug 25, 2019 at 01:05:35PM -0300, James Almer wrote:
> > > On 8/24/2019 3:18 PM, Michael Niedermayer wrote:
> > > > Testcase:
> > 14843/clusterfuzz-testcase-
On Mon, Aug 26, 2019 at 09:51:45AM +0200, Hendrik Leppkes wrote:
> On Mon, Aug 26, 2019 at 9:33 AM Michael Niedermayer
> wrote:
> >
> > On Sun, Aug 25, 2019 at 08:04:03PM -0300, James Almer wrote:
> > > On 8/25/2019 6:46 PM, Michael Niedermayer wrote:
> > > > On Sun, Aug 25, 2019 at 01:22:22PM -03
On Sun, Aug 25, 2019 at 12:06:30PM -0300, James Almer wrote:
> On 8/25/2019 4:32 AM, Michael Niedermayer wrote:
> > On Fri, Aug 23, 2019 at 11:20:48AM -0300, James Almer wrote:
> >> On 8/8/2019 8:23 PM, Michael Niedermayer wrote:
> >>> Fixes: shift exponent 32 is too large for 32-bit type 'unsigned
On Mon, Aug 26, 2019 at 9:51 AM Paul B Mahol wrote:
>
>
> On Mon, Aug 26, 2019 at 9:37 AM Michael Niedermayer
> wrote:
>
>> On Sun, Aug 25, 2019 at 11:43:42PM -0300, James Almer wrote:
>> > On 8/25/2019 8:18 PM, James Almer wrote:
>> > > On 8/25/2019 7:14 PM, Michael Niedermayer wrote:
>> > >> O
Okay, thanks
I will patch that
Le sam. 24 août 2019 à 20:09, Marton Balint a écrit :
>
>
> On Fri, 23 Aug 2019, Anthony Delannoy wrote:
>
> >> I think we should only merge the part of this patchset which makes the EIT
> >> available as a data stream. Parsing the whole EIT or dumping the data as
On Mon, Aug 26, 2019 at 9:37 AM Michael Niedermayer
wrote:
> On Sun, Aug 25, 2019 at 11:43:42PM -0300, James Almer wrote:
> > On 8/25/2019 8:18 PM, James Almer wrote:
> > > On 8/25/2019 7:14 PM, Michael Niedermayer wrote:
> > >> On Sun, Aug 25, 2019 at 11:46:36PM +0200, Michael Niedermayer wrote:
On Mon, Aug 26, 2019 at 9:33 AM Michael Niedermayer
wrote:
>
> On Sun, Aug 25, 2019 at 08:04:03PM -0300, James Almer wrote:
> > On 8/25/2019 6:46 PM, Michael Niedermayer wrote:
> > > On Sun, Aug 25, 2019 at 01:22:22PM -0300, James Almer wrote:
> > >> On 8/24/2019 3:18 PM, Michael Niedermayer wrote
On Sun, Aug 25, 2019 at 11:35 PM Michael Niedermayer
wrote:
> On Sun, Aug 25, 2019 at 01:05:35PM -0300, James Almer wrote:
> > On 8/24/2019 3:18 PM, Michael Niedermayer wrote:
> > > Testcase:
> 14843/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_NUV_fuzzer-5661969614372864
> > > Testcase:
> 1
On Sun, Aug 25, 2019 at 08:04:03PM -0300, James Almer wrote:
> On 8/25/2019 6:46 PM, Michael Niedermayer wrote:
> > On Sun, Aug 25, 2019 at 01:22:22PM -0300, James Almer wrote:
> >> On 8/24/2019 3:18 PM, Michael Niedermayer wrote:
[...]
> > if every filter following needs to process frames twice 2
On Sun, Aug 25, 2019 at 11:43:42PM -0300, James Almer wrote:
> On 8/25/2019 8:18 PM, James Almer wrote:
> > On 8/25/2019 7:14 PM, Michael Niedermayer wrote:
> >> On Sun, Aug 25, 2019 at 11:46:36PM +0200, Michael Niedermayer wrote:
> >>> On Sun, Aug 25, 2019 at 01:22:22PM -0300, James Almer wrote:
>
On Sun, Aug 25, 2019 at 08:04:03PM -0300, James Almer wrote:
> On 8/25/2019 6:46 PM, Michael Niedermayer wrote:
> > On Sun, Aug 25, 2019 at 01:22:22PM -0300, James Almer wrote:
> >> On 8/24/2019 3:18 PM, Michael Niedermayer wrote:
> >>> Fixes: Ticket7880
> >>>
> >>> Signed-off-by: Michael Niedermay
On Sun, Aug 25, 2019 at 11:37:02PM -0300, James Almer wrote:
> On 8/24/2019 3:18 PM, Michael Niedermayer wrote:
> > Fixes: Ticket7880
> >
> > Signed-off-by: Michael Niedermayer
> > ---
> > libavcodec/qtrle.c| 30 ++
> > tests/ref/fate/qtrle-8bit | 1 +
> > 2
48 matches
Mail list logo