[FFmpeg-devel] [PATCH v1] avformat/rtsp: fix https://trac.ffmpeg.org/ticket/7517

2021-03-03 Thread gaojiangjie
From: Jiangjie Gao Signed-off-by: Jiangjie Gao --- libavformat/rtsp.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/libavformat/rtsp.c b/libavformat/rtsp.c index 9a2933346e..29ee0b317f 100644 --- a/libavformat/rtsp.c +++ b/libavformat/rtsp.c @@ -2510,8 +2510,9 @@ static

[FFmpeg-devel] [PATCH] avcodec/decode: use the context's internal buffer_pkt in avcodec_decode_subtitle2()

2021-03-03 Thread James Almer
This removes stack usage of AVPacket, and ensures proper handling of packet references. Signed-off-by: James Almer --- libavcodec/decode.c | 29 ++--- 1 file changed, 10 insertions(+), 19 deletions(-) diff --git a/libavcodec/decode.c b/libavcodec/decode.c index

[FFmpeg-devel] [PATCH] avcodec/decode: constify the source packet parameter in extract_packet_props()

2021-03-03 Thread James Almer
Signed-off-by: James Almer --- libavcodec/decode.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/libavcodec/decode.c b/libavcodec/decode.c index d445ac75b0..5e5d0c7066 100644 --- a/libavcodec/decode.c +++ b/libavcodec/decode.c @@ -144,7 +144,7 @@ fail2: #define

[FFmpeg-devel] [PATCH] fftools/ffplay: do not write out of rdft visualization texture

2021-03-03 Thread Marton Balint
If the window is resized it was possible that xpos pointed outside the visualization texture. By rearranging the overflow check we make sure this (and a crash) does not happen. We also don't have to use xleft for start position, as that is 0 anyways, and if we ever want to take into account xleft

Re: [FFmpeg-devel] [PATCH v6 0/4] Initial implementation of TTML encoding/muxing

2021-03-03 Thread Jan Ekström
On Tue, Mar 2, 2021 at 11:00 AM Jan Ekström wrote: > > I've intentionally kept this initial version simple (no styling etc) to focus > on the basics. As this goes through review, additional features can be added > (I had initial PoC for styling implemented some time around previous VDD), and >

[FFmpeg-devel] [PATCH 2/2] avfilter: add msad video filter

2021-03-03 Thread Paul B Mahol
Signed-off-by: Paul B Mahol --- doc/filters.texi | 21 +++ libavfilter/allfilters.c | 1 + libavfilter/vf_identity.c | 115 -- 3 files changed, 120 insertions(+), 17 deletions(-) diff --git a/doc/filters.texi b/doc/filters.texi index

[FFmpeg-devel] [PATCH 1/2] avfilter: add identity video filter

2021-03-03 Thread Paul B Mahol
Signed-off-by: Paul B Mahol --- doc/filters.texi | 22 +++ libavfilter/Makefile | 1 + libavfilter/allfilters.c | 1 + libavfilter/vf_identity.c | 372 ++ 4 files changed, 396 insertions(+) create mode 100644 libavfilter/vf_identity.c

Re: [FFmpeg-devel] [PATCH] configure: Fix bashism in openal check. (was: [PATCH] Bugfix for #9135)

2021-03-03 Thread Reimar Döffinger
> > I have never come around to setting up postfix for forwarding mails > externally on my current system. So, for now, I am using the second best > solution. Please see the attachment. Maybe not worth the effort, but FYI git can communicate directly with a SMTP server nowadays, and msmtmp is

Re: [FFmpeg-devel] [PATCH 1/1] avcodec/libopusdec: Enable FEC/PLC

2021-03-03 Thread Philip-Dylan Gleonec
Le 18/02/2021 à 17:38, Philip-Dylan Gleonec a écrit : Here is the reworked patch properly attached. Sorry about the duplicate mail, I just noticed I had a mishap with my mail client and the previous patch was scrubbed. Hello, Is someone interested in picking this up, or is there some further

Re: [FFmpeg-devel] [PATCH] avcodec/libopusenc: reload packet loss at encode

2021-03-03 Thread Philip-Dylan Gleonec
Le 16/02/2021 à 15:04, Philip-Dylan Gleonec a écrit : An estimation of packet loss is required by libopus to compute its FEC data. Currently, this estimation is constant, and can not be changed after configuration. This means an application using libopus through ffmpeg can not adapt the packet

Re: [FFmpeg-devel] [PATCH] avutil/parseutils: Check sign in av_parse_time()

2021-03-03 Thread Michael Niedermayer
On Sat, Jan 16, 2021 at 12:25:11AM +0100, Michael Niedermayer wrote: > Fixes: signed integer overflow: -9223372053736 * 100 cannot be > represented in type 'long' > Fixes: > 26910/clusterfuzz-testcase-minimized-ffmpeg_dem_CONCAT_fuzzer-6607924558430208 > > Found-by: continuous fuzzing

Re: [FFmpeg-devel] [PATCH 6/7] avformat/lxfdec: Fix multiple integer overflows related to track_size

2021-03-03 Thread Michael Niedermayer
On Wed, Jan 20, 2021 at 04:54:56PM +0100, Tomas Härdin wrote: > lör 2021-01-16 klockan 00:22 +0100 skrev Michael Niedermayer: > > On Fri, Jan 15, 2021 at 09:48:38AM +0100, Tomas Härdin wrote: > > > tor 2021-01-14 klockan 23:51 +0100 skrev Michael Niedermayer: > > > > Fixes: signed integer

Re: [FFmpeg-devel] [PATCH 7/7] avformat/mccdec: Use av_sat_add64() for fs

2021-03-03 Thread Michael Niedermayer
On Thu, Jan 14, 2021 at 11:51:16PM +0100, Michael Niedermayer wrote: > Fixes: signed integer overflow: -9223372036854775808 + -242 cannot be > represented in type 'long' > Fixes: > 26910/clusterfuzz-testcase-minimized-ffmpeg_dem_MCC_fuzzer-6723018395090944 > > Found-by: continuous fuzzing

Re: [FFmpeg-devel] [PATCH] avformat/frmdec: Simplify finding pixel format

2021-03-03 Thread Paul B Mahol
lgtm ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] [PATCH] avformat/mspdec: Check packet_size more completely

2021-03-03 Thread Michael Niedermayer
On Wed, Mar 03, 2021 at 12:58:40PM +0100, Paul B Mahol wrote: > lgtm will apply thx [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB Old school: Use the lowest level language in which you can solve the problem conveniently. New school: Use the

Re: [FFmpeg-devel] [PATCH 4/4] avformat/aiffdec: Check that SSND is at least 8 bytes

2021-03-03 Thread Michael Niedermayer
On Wed, Mar 03, 2021 at 12:16:53PM +0100, Paul B Mahol wrote: > lgtm will apply thanks [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB Democracy is the form of government in which you can choose your dictator signature.asc Description: PGP signature

[FFmpeg-devel] [PATCH] avformat/frmdec: Simplify finding pixel format

2021-03-03 Thread Andreas Rheinhardt
The fourccs used by the Megalux Frame format to determine the pixel format are actually no fourccs at all as they are a single byte. Furthermore, their range is continuous (1-5), so they are actually ordinary indices. So treat them as such and don't use PixelFormatTags for them. Signed-off-by:

Re: [FFmpeg-devel] [PATCH 3/4] avformat/dcstr: Check sample rate

2021-03-03 Thread Michael Niedermayer
On Wed, Mar 03, 2021 at 12:18:32PM +0100, Paul B Mahol wrote: > Check also for == 0 case ok, will apply with that change Thanks! [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB Breaking DRM is a little like attempting to break through a door even though the

Re: [FFmpeg-devel] [PATCH] avcodec/mpeg4videodec: add forgotten flags to mpeg4_options

2021-03-03 Thread Michael Niedermayer
On Wed, Mar 03, 2021 at 12:49:16PM +0100, Andreas Rheinhardt wrote: > Michael Niedermayer: > > On Tue, Mar 02, 2021 at 07:53:07PM +0100, Paul B Mahol wrote: > >> Signed-off-by: Paul B Mahol > >> --- > >> libavcodec/mpeg4videodec.c | 6 -- > >> 1 file changed, 4 insertions(+), 2 deletions(-)

[FFmpeg-devel] [PATCH] avfilter: add identity filter

2021-03-03 Thread Paul B Mahol
Signed-off-by: Paul B Mahol --- doc/filters.texi | 22 +++ libavfilter/Makefile | 1 + libavfilter/allfilters.c | 1 + libavfilter/vf_identity.c | 377 ++ 4 files changed, 401 insertions(+) create mode 100644 libavfilter/vf_identity.c

Re: [FFmpeg-devel] [PATCH 4/5] avcodec/parser: Schedule av_parser_change for removal

2021-03-03 Thread Andreas Rheinhardt
Andreas Rheinhardt: > Originally deprecated in 748c2fca7e4d99357c234936aa71212a6282be36, > publically deprecated in 9a07c1332cfe092b57b5758f22b686ca58806c60 > (merged into FFmpeg in 1885ffb03d0af28e6bac2bcc8725fa15b93f6ac9). > > Signed-off-by: Andreas Rheinhardt > --- > libavcodec/avcodec.h | 6

Re: [FFmpeg-devel] [PATCH] ivfenc: write duration for frame_cnt=1.

2021-03-03 Thread Ronald S. Bultje
Hi, On Tue, Mar 2, 2021 at 1:59 PM Andreas Rheinhardt < andreas.rheinha...@gmail.com> wrote: > Ronald S. Bultje: > > --- > > libavformat/ivfenc.c | 10 +++--- > > 1 file changed, 7 insertions(+), 3 deletions(-) > > > > diff --git a/libavformat/ivfenc.c b/libavformat/ivfenc.c > > index

Re: [FFmpeg-devel] [PATCH] avformat/mspdec: Check packet_size more completely

2021-03-03 Thread Paul B Mahol
lgtm On Wed, Mar 3, 2021 at 11:01 AM Michael Niedermayer wrote: > Fixes: OOM > Fixes: > 28348/clusterfuzz-testcase-minimized-ffmpeg_dem_MSP_fuzzer-4612055872831488 > Fixes: > 28360/clusterfuzz-testcase-minimized-ffmpeg_dem_MSP_fuzzer-6245230626078720 > > Found-by: continuous fuzzing process >

Re: [FFmpeg-devel] [PATCH] avcodec/mpeg4videodec: add forgotten flags to mpeg4_options

2021-03-03 Thread Andreas Rheinhardt
Michael Niedermayer: > On Tue, Mar 02, 2021 at 07:53:07PM +0100, Paul B Mahol wrote: >> Signed-off-by: Paul B Mahol >> --- >> libavcodec/mpeg4videodec.c | 6 -- >> 1 file changed, 4 insertions(+), 2 deletions(-) >> >> diff --git a/libavcodec/mpeg4videodec.c b/libavcodec/mpeg4videodec.c >>

Re: [FFmpeg-devel] [PATCH] avcodec/mpeg4videodec: add forgotten flags to mpeg4_options

2021-03-03 Thread Michael Niedermayer
On Tue, Mar 02, 2021 at 07:53:07PM +0100, Paul B Mahol wrote: > Signed-off-by: Paul B Mahol > --- > libavcodec/mpeg4videodec.c | 6 -- > 1 file changed, 4 insertions(+), 2 deletions(-) > > diff --git a/libavcodec/mpeg4videodec.c b/libavcodec/mpeg4videodec.c > index fd985f0430..43c2cf2dc3

Re: [FFmpeg-devel] [PATCH 3/4] avformat/dcstr: Check sample rate

2021-03-03 Thread Paul B Mahol
Check also for == 0 case On Wed, Mar 3, 2021 at 10:50 AM Michael Niedermayer wrote: > Fixes: signed integer overflow: -1300248894420254720 * 16 cannot be > represented in type 'long' > Fixes: > 30879/clusterfuzz-testcase-minimized-ffmpeg_dem_DCSTR_fuzzer-5094464215449600 > > Found-by:

Re: [FFmpeg-devel] [PATCH 4/4] avformat/aiffdec: Check that SSND is at least 8 bytes

2021-03-03 Thread Paul B Mahol
lgtm ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] [PATCH] avformat/mspdec: Check packet_size more completely

2021-03-03 Thread Michael Niedermayer
On Wed, Mar 03, 2021 at 11:00:23AM +0100, Michael Niedermayer wrote: > Fixes: OOM > Fixes: > 28348/clusterfuzz-testcase-minimized-ffmpeg_dem_MSP_fuzzer-4612055872831488 > Fixes: > 28360/clusterfuzz-testcase-minimized-ffmpeg_dem_MSP_fuzzer-6245230626078720 > > Found-by: continuous fuzzing

Re: [FFmpeg-devel] [PATCH 1/2] avcodec/alsdec: Check bitstream input in read_block()

2021-03-03 Thread Michael Niedermayer
On Tue, Mar 02, 2021 at 07:52:30PM +0100, Michael Niedermayer wrote: > Fixes: Timeout > Fixes: > 28110/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_ALS_fuzzer-5036338973507584 > > Found-by: continuous fuzzing process > https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg >

[FFmpeg-devel] [PATCH] avformat/mspdec: Check packet_size more completely

2021-03-03 Thread Michael Niedermayer
Fixes: OOM Fixes: 28348/clusterfuzz-testcase-minimized-ffmpeg_dem_MSP_fuzzer-4612055872831488 Fixes: 28360/clusterfuzz-testcase-minimized-ffmpeg_dem_MSP_fuzzer-6245230626078720 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by:

[FFmpeg-devel] [PATCH 4/4] avformat/aiffdec: Check that SSND is at least 8 bytes

2021-03-03 Thread Michael Niedermayer
Fixes: Infinite loop Fixes: 30874/clusterfuzz-testcase-minimized-ffmpeg_dem_AIFF_fuzzer-5933710488764416 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Niedermayer --- libavformat/aiffdec.c | 2 ++ 1 file changed, 2

[FFmpeg-devel] [PATCH 3/4] avformat/dcstr: Check sample rate

2021-03-03 Thread Michael Niedermayer
Fixes: signed integer overflow: -1300248894420254720 * 16 cannot be represented in type 'long' Fixes: 30879/clusterfuzz-testcase-minimized-ffmpeg_dem_DCSTR_fuzzer-5094464215449600 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by:

[FFmpeg-devel] [PATCH 2/4] avformat/voc_packet: prevent remaining size from becoming negative in ff_voc_get_packet()

2021-03-03 Thread Michael Niedermayer
Fixes: memleak Fixes: 30909/clusterfuzz-testcase-minimized-ffmpeg_dem_AVS_fuzzer-4886284057313280 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Niedermayer --- libavformat/voc_packet.c | 14 +- 1 file

[FFmpeg-devel] [PATCH 1/4] avcodec/jpegls: Check A[Q] for overflow in ff_jpegls_update_state_regular()

2021-03-03 Thread Michael Niedermayer
Fixes: Timeout Fixes: 30912/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_MJPEG_fuzzer-5556235476795392 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Niedermayer --- libavcodec/jpegls.h | 2 +- 1 file changed, 1