[FFmpeg-devel] [PATCH] avformat/rawenc: perform stream checks for mp2 muxer

2021-04-10 Thread Gyan Doshi
--- libavformat/rawenc.c | 1 + 1 file changed, 1 insertion(+) diff --git a/libavformat/rawenc.c b/libavformat/rawenc.c index caec297f4a..0802d9a831 100644 --- a/libavformat/rawenc.c +++ b/libavformat/rawenc.c @@ -433,6 +433,7 @@ AVOutputFormat ff_mp2_muxer = { .extensions=

Re: [FFmpeg-devel] [PATCH] avfilter/vf_overlay_cuda: check ctx->hwctx->internal null pointer

2021-04-10 Thread Steven Liu
Timo Rothenpieler 于2021年4月10日周六 下午8:34写道: > > Can you test if > https://github.com/BtbN/FFmpeg/commit/454d5c5d3eda7b5356f961a0e1b66f3a56d95363 > Also fixes the issue? Yes, it can fix the issue Thanks Timo. Thanks Steven ___ ffmpeg-devel mailing list

Re: [FFmpeg-devel] [PATCH 4/4] avfilter/vf_v360: refactor (i)flat_range for fisheye

2021-04-10 Thread Daniel Playfair Cal
> AFAIK, the h/v/d fov works fine with fisheye in/out. I used synthetic fisheye > images from paul bourke site. > And diagonal fov from w/h either works with both in and out or not at all. That doesn't seem correct. If an image with an equidistant projection is of dimensions WxH and has the

[FFmpeg-devel] [PATCH 3/3] avformat/webpenc: don't assume animated webp streams will have more than one packet

2021-04-10 Thread James Almer
The libwebp_animencoder returns a single packet with the entire animated stream, as that's what the external library produces. As such, only ensure the stream was produced by said encoder (or propagated by a demuxer, once support is added) when attempting to write the requested loop value. Fixes

[FFmpeg-devel] [PATCH 2/3] avcodec/libwebpenc_animencoder: set the correct packet pts

2021-04-10 Thread James Almer
The only packet produced by this encoder contains the entire animated stream, so its pts is 0. Signed-off-by: James Almer --- libavcodec/libwebpenc_animencoder.c | 5 + 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/libavcodec/libwebpenc_animencoder.c

[FFmpeg-devel] [PATCH 1/3] avcodec/libwebpenc_animencoder: stop propagating bogus empty packets

2021-04-10 Thread James Almer
Packets must have at least one of data or side_data. If none are available, then got_packet must not be signaled. The generic encode code already discarded these empty packets, but it's better just not propagating them at all. Signed-off-by: James Almer --- This patchset supersedes

Re: [FFmpeg-devel] [PATCH 1/3] avcodec/libwebpenc_animencoder: Don't return pkt without data/side-data

2021-04-10 Thread James Almer
On 4/10/2021 10:28 PM, Andreas Rheinhardt wrote: James Almer: On 4/10/2021 9:39 PM, Andreas Rheinhardt wrote: They are essentially forbidden in our encoding API as they are considered empty. So just set the data, but leave the size at zero. This doesn't seem like a good solution. You're

Re: [FFmpeg-devel] [PATCH 1/3] avcodec/libwebpenc_animencoder: Don't return pkt without data/side-data

2021-04-10 Thread Andreas Rheinhardt
James Almer: > On 4/10/2021 9:39 PM, Andreas Rheinhardt wrote: >> They are essentially forbidden in our encoding API as they are >> considered empty. So just set the data, but leave the size at zero. > > This doesn't seem like a good solution. You're propagating dummy packets > when the encoder

Re: [FFmpeg-devel] [PATCH 3/3] avformat/webpenc: Check seeks

2021-04-10 Thread Andreas Rheinhardt
James Almer: > On 4/10/2021 9:43 PM, Andreas Rheinhardt wrote: >> When writing the trailer, the WebP muxer unconditionally seeks back >> to the front to update some elements. Yet this doesn't work if >> the seek failed, so check for this. >> >> (This has been mentioned in ticket #9179.) >> >>

Re: [FFmpeg-devel] [PATCH 3/3] avformat/webpenc: Check seeks

2021-04-10 Thread James Almer
On 4/10/2021 9:43 PM, Andreas Rheinhardt wrote: When writing the trailer, the WebP muxer unconditionally seeks back to the front to update some elements. Yet this doesn't work if the seek failed, so check for this. (This has been mentioned in ticket #9179.) Signed-off-by: Andreas Rheinhardt

Re: [FFmpeg-devel] [PATCH 1/3] avcodec/libwebpenc_animencoder: Don't return pkt without data/side-data

2021-04-10 Thread James Almer
On 4/10/2021 9:39 PM, Andreas Rheinhardt wrote: They are essentially forbidden in our encoding API as they are considered empty. So just set the data, but leave the size at zero. This doesn't seem like a good solution. You're propagating dummy packets when the encoder didn't produce any. It's

Re: [FFmpeg-devel] [PATCH 1/7] avcodec/rv34: Move dsp init code to rv30/rv40

2021-04-10 Thread Andreas Rheinhardt
Andreas Rheinhardt: > It avoids both runtime and compile-time checks. > > Signed-off-by: Andreas Rheinhardt > --- > libavcodec/rv30.c | 1 + > libavcodec/rv34.c | 9 - > libavcodec/rv40.c | 1 + > 3 files changed, 2 insertions(+), 9 deletions(-) > > diff --git a/libavcodec/rv30.c

[FFmpeg-devel] [PATCH 3/3] avformat/webpenc: Check seeks

2021-04-10 Thread Andreas Rheinhardt
When writing the trailer, the WebP muxer unconditionally seeks back to the front to update some elements. Yet this doesn't work if the seek failed, so check for this. (This has been mentioned in ticket #9179.) Signed-off-by: Andreas Rheinhardt --- libavformat/webpenc.c | 8 1 file

[FFmpeg-devel] [PATCH 2/3] avformat/webpenc: Don't treat zero-sized packets as invalid

2021-04-10 Thread Andreas Rheinhardt
Before f9043de99a23e35a34c79bfbc9ef17b27f7236d1, sending zero-sized packets to the WebP muxer led to memleaks (unless the muxer was already in animation mode). Therefore said commit simply returned immediately if such a packet were sent to the muxer. But now it turns out that such packets are not

[FFmpeg-devel] [PATCH 1/3] avcodec/libwebpenc_animencoder: Don't return pkt without data/side-data

2021-04-10 Thread Andreas Rheinhardt
They are essentially forbidden in our encoding API as they are considered empty. So just set the data, but leave the size at zero. (The old encoding API allowed such packets: It used buffer_pkt_valid to record whether the packet is empty or not. This has been changed in

Re: [FFmpeg-devel] [PATCH] avutil/cpu: Use HW_NCPUONLINE to detect # of online CPUs with OpenBSD

2021-04-10 Thread Brad Smith
ping. On 4/3/2021 2:49 PM, Brad Smith wrote: avutil/cpu: Use HW_NCPUONLINE to detect # of online CPUs with OpenBSD Signed-off-by: Brad Smith --- libavutil/cpu.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/libavutil/cpu.c b/libavutil/cpu.c index 8e3576a1f3..9d249737df 100644

Re: [FFmpeg-devel] [PATCH 4/4] avfilter/vf_v360: refactor (i)flat_range for fisheye

2021-04-10 Thread Paul B Mahol
On Mon, Mar 22, 2021 at 1:35 PM Daniel Playfair Cal < daniel.playfair@gmail.com> wrote: > > I disagree, if I use 180 hfov and 180 vfov it should not have extra > areas but only half of previous input. > > Not sure I follow - the ih_fov and vh_fov refer to the input (i.e. the > fisheye image).

Re: [FFmpeg-devel] [PATCH 6/6] avformat/mvi: Check audio_data_size to be non negative

2021-04-10 Thread James Almer
On 4/10/2021 7:24 PM, Michael Niedermayer wrote: Fixes: left shift of negative value -224 Fixes: 32144/clusterfuzz-testcase-minimized-ffmpeg_dem_MVI_fuzzer-4971479323246592 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by:

[FFmpeg-devel] [PATCH 4/6] tools/target_dec_fuzzer: adjust threshold for arbc

2021-04-10 Thread Michael Niedermayer
Fixes: Timeout (63sec -> 48ms) Fixes: 31886/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_ARBC_fuzzer-5287235705503744 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Niedermayer --- tools/target_dec_fuzzer.c | 1 +

[FFmpeg-devel] [PATCH 5/6] avcodec/utils: Check ima wav duration for overflow

2021-04-10 Thread Michael Niedermayer
Fixes: signed integer overflow: 44331634 * 65 cannot be represented in type 'int' Fixes: 32120/clusterfuzz-testcase-minimized-ffmpeg_dem_RSD_fuzzer-5760221223583744 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael

[FFmpeg-devel] [PATCH 1/6] avformat/cafdec: Check channels

2021-04-10 Thread Michael Niedermayer
Fixes: signed integer overflow: -1184429040541376544 * 32 cannot be represented in type 'long' Fixes: 31788/clusterfuzz-testcase-minimized-ffmpeg_dem_CAF_fuzzer-6236746338664448 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by:

[FFmpeg-devel] [PATCH 2/6] Execure whole size check earlier for rv20

2021-04-10 Thread Michael Niedermayer
Fixes: Timeout Fixes: 31380/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_RV20_fuzzer-5230899257016320 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Niedermayer --- libavcodec/rv10.c | 8 ++-- 1 file changed,

[FFmpeg-devel] [PATCH 3/6] tools/target_dec_fuzzer: Adjust threshold for TSCC

2021-04-10 Thread Michael Niedermayer
Fixes: Timeout Fixes: 31850/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_TSCC_fuzzer-5940231289307136 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Niedermayer --- tools/target_dec_fuzzer.c | 1 + 1 file

[FFmpeg-devel] [PATCH 6/6] avformat/mvi: Check audio_data_size to be non negative

2021-04-10 Thread Michael Niedermayer
Fixes: left shift of negative value -224 Fixes: 32144/clusterfuzz-testcase-minimized-ffmpeg_dem_MVI_fuzzer-4971479323246592 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Niedermayer --- libavformat/mvi.c | 2 +- 1

Re: [FFmpeg-devel] [PATCH] avcodec/msp2dec: Check available space in RLE decoder

2021-04-10 Thread Michael Niedermayer
On Fri, Apr 09, 2021 at 10:59:44PM -0300, James Almer wrote: > On 4/7/2021 11:59 AM, Michael Niedermayer wrote: > > On Wed, Apr 07, 2021 at 12:42:50AM +0200, Andreas Rheinhardt wrote: > > > Michael Niedermayer: > > > > Fixes: out of array read > > > > Fixes: > > > >

[FFmpeg-devel] [PATCH 3/4] pthread_frame: introduce a codec callback to update the user-facing context

2021-04-10 Thread James Almer
From: Hendrik Leppkes --- libavcodec/codec.h | 5 + libavcodec/pthread_frame.c | 2 ++ 2 files changed, 7 insertions(+) diff --git a/libavcodec/codec.h b/libavcodec/codec.h index 50a22f6e3c..de050b2815 100644 --- a/libavcodec/codec.h +++ b/libavcodec/codec.h @@ -258,6 +258,11 @@

[FFmpeg-devel] [PATCH 2/4] ffprobe: only print exported private decoder options

2021-04-10 Thread James Almer
Signed-off-by: James Almer --- fftools/ffprobe.c | 2 +- tests/ref/fate/mov-zombie | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/fftools/ffprobe.c b/fftools/ffprobe.c index 38462e1ff3..8c7b238adf 100644 --- a/fftools/ffprobe.c +++ b/fftools/ffprobe.c @@ -2714,7

[FFmpeg-devel] [PATCH 4/4] avcodec/h264dec: update exported AVOptions in the user-facing context

2021-04-10 Thread James Almer
Based on a patch by Hendrik Leppkes. Fixes ticket #9176. Signed-off-by: James Almer --- libavcodec/h264_slice.c | 14 ++ libavcodec/h264dec.c| 1 + libavcodec/h264dec.h| 2 ++ 3 files changed, 17 insertions(+) diff --git a/libavcodec/h264_slice.c

[FFmpeg-devel] [PATCH 1/4] avcodec/h264dec: add missing flags to is_avc and nal_length_size AVOptions

2021-04-10 Thread James Almer
Signed-off-by: James Almer --- libavcodec/h264dec.c | 5 +++-- tests/ref/fate/mov-zombie | 2 +- 2 files changed, 4 insertions(+), 3 deletions(-) diff --git a/libavcodec/h264dec.c b/libavcodec/h264dec.c index 47b9abbc5c..f44c8c8175 100644 --- a/libavcodec/h264dec.c +++

Re: [FFmpeg-devel] [PATCH 2/4] doc/protocols: update options

2021-04-10 Thread Andriy Gelman
On Sat, 10. Apr 12:40, Gyan Doshi wrote: > > > On 2021-04-10 11:45, Andriy Gelman wrote: > > On Sun, 15. Nov 13:20, Andriy Gelman wrote: > > > From: Andriy Gelman > > > > > > Define listen_timeout. Set user-agent and timeout to deprecated. > > > > > > Signed-off-by: Andriy Gelman > > > --- >

Re: [FFmpeg-devel] [PATCH v2] libsvtav1: Add logical_processors option

2021-04-10 Thread Christopher Degawa
ping on this patch again ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] [PATCH] JPEG-LS Decoder: Update

2021-04-10 Thread Carl Eugen Hoyos
Am Sa., 10. Apr. 2021 um 14:35 Uhr schrieb Spyros Theoharis : > > - 8 up to 16 bits > - 444/422/420/411 > - fixed restart mechanism support > - RGB/YUV 444 images (via -rgb444 input option) This typically indicates that you should send four patches instead of one. How can we create samples /

Re: [FFmpeg-devel] [PATCH] IEC61937_EAC3 decoding support

2021-04-10 Thread Carl Eugen Hoyos
Am Sa., 10. Apr. 2021 um 10:46 Uhr schrieb Denis Shulyaka : > > This patch adds support to decode IEC61937_EAC3 (aka dolby digital plus). > > Signed-off-by: Denis Shulyaka > --- > libavformat/spdifdec.c | 47 ++ > 1 file changed, 38 insertions(+), 9

[FFmpeg-devel] [PATCH] avformat/rawenc: remove singlejpeg muxer

2021-04-10 Thread Gyan Doshi
It was added in 51ac1f616f due to ticket #4218, in order to show a single image via ffserver. With ffserver long gone, it serves no purpose. --- libavformat/Makefile | 1 - libavformat/allformats.c | 1 - libavformat/rawenc.c | 13 - 3 files changed, 15 deletions(-) diff

Re: [FFmpeg-devel] [PATCH 1/2] avformat/hls: check return value of new_init_section()

2021-04-10 Thread Marton Balint
On Sat, 10 Apr 2021, Andreas Rheinhardt wrote: Marton Balint: Fixes part of ticket #8931. Signed-off-by: Marton Balint --- libavformat/hls.c | 4 1 file changed, 4 insertions(+) diff --git a/libavformat/hls.c b/libavformat/hls.c index 597bea7f25..b589ad2870 100644 ---

Re: [FFmpeg-devel] [PATCH 2/2] avfilter/af_mcompand: check allocation results

2021-04-10 Thread Marton Balint
On Sat, 10 Apr 2021, Andreas Rheinhardt wrote: Marton Balint: Fixes the only remaining part of ticket #8931. Signed-off-by: Marton Balint --- libavfilter/af_mcompand.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/libavfilter/af_mcompand.c b/libavfilter/af_mcompand.c index

[FFmpeg-devel] [PATCH] JPEG-LS Decoder: Update

2021-04-10 Thread Spyros Theoharis
- 8 up to 16 bits - 444/422/420/411 - fixed restart mechanism support - RGB/YUV 444 images (via -rgb444 input option) --- libavcodec/jpegls.c| 5 + libavcodec/jpegls.h| 2 +- libavcodec/jpeglsdec.c | 268 + libavcodec/mjpegdec.c | 77

Re: [FFmpeg-devel] [PATCH] avfilter/vf_overlay_cuda: check ctx->hwctx->internal null pointer

2021-04-10 Thread Timo Rothenpieler
Can you test if https://github.com/BtbN/FFmpeg/commit/454d5c5d3eda7b5356f961a0e1b66f3a56d95363 Also fixes the issue? I'm unable to reproduce the crash. smime.p7s Description: S/MIME Cryptographic Signature ___ ffmpeg-devel mailing list

Re: [FFmpeg-devel] [PATCH 1/2] avformat/hls: check return value of new_init_section()

2021-04-10 Thread Andreas Rheinhardt
Marton Balint: > Fixes part of ticket #8931. > > Signed-off-by: Marton Balint > --- > libavformat/hls.c | 4 > 1 file changed, 4 insertions(+) > > diff --git a/libavformat/hls.c b/libavformat/hls.c > index 597bea7f25..b589ad2870 100644 > --- a/libavformat/hls.c > +++ b/libavformat/hls.c >

Re: [FFmpeg-devel] [PATCH 2/2] avfilter/af_mcompand: check allocation results

2021-04-10 Thread Andreas Rheinhardt
Marton Balint: > Fixes the only remaining part of ticket #8931. > > Signed-off-by: Marton Balint > --- > libavfilter/af_mcompand.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/libavfilter/af_mcompand.c b/libavfilter/af_mcompand.c > index ce4f366ad7..d1a3dc123a 100644 > ---

[FFmpeg-devel] [PATCH 2/2] avfilter/af_mcompand: check allocation results

2021-04-10 Thread Marton Balint
Fixes the only remaining part of ticket #8931. Signed-off-by: Marton Balint --- libavfilter/af_mcompand.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/libavfilter/af_mcompand.c b/libavfilter/af_mcompand.c index ce4f366ad7..d1a3dc123a 100644 --- a/libavfilter/af_mcompand.c +++

[FFmpeg-devel] [PATCH 1/2] avformat/hls: check return value of new_init_section()

2021-04-10 Thread Marton Balint
Fixes part of ticket #8931. Signed-off-by: Marton Balint --- libavformat/hls.c | 4 1 file changed, 4 insertions(+) diff --git a/libavformat/hls.c b/libavformat/hls.c index 597bea7f25..b589ad2870 100644 --- a/libavformat/hls.c +++ b/libavformat/hls.c @@ -842,6 +842,10 @@ static int

Re: [FFmpeg-devel] [PATCH V7 4/6] lavu: add side data AV_FRAME_DATA_BOUNDING_BOXES

2021-04-10 Thread Guo, Yejun
> -Original Message- > From: ffmpeg-devel On Behalf Of > Lynne > Sent: 2021年4月10日 3:20 > To: FFmpeg development discussions and patches > > Subject: Re: [FFmpeg-devel] [PATCH V7 4/6] lavu: add side data > AV_FRAME_DATA_BOUNDING_BOXES > > Apr 9, 2021, 20:08 by bygran...@gmail.com: > >

Re: [FFmpeg-devel] [PATCH V7 4/6] lavu: add side data AV_FRAME_DATA_BOUNDING_BOXES

2021-04-10 Thread Guo, Yejun
> -Original Message- > From: ffmpeg-devel On Behalf Of > Lynne > Sent: 2021年4月9日 23:16 > To: FFmpeg development discussions and patches > > Subject: Re: [FFmpeg-devel] [PATCH V7 4/6] lavu: add side data > AV_FRAME_DATA_BOUNDING_BOXES > > Apr 9, 2021, 16:35 by bygran...@gmail.com: > >

[FFmpeg-devel] [PATCH] IEC61937_EAC3 decoding support

2021-04-10 Thread Denis Shulyaka
This patch adds support to decode IEC61937_EAC3 (aka dolby digital plus). Signed-off-by: Denis Shulyaka --- libavformat/spdifdec.c | 47 ++ 1 file changed, 38 insertions(+), 9 deletions(-) diff --git a/libavformat/spdifdec.c b/libavformat/spdifdec.c

[FFmpeg-devel] [PATCH] IEC61937_EAC3 decoding support

2021-04-10 Thread Denis Shulyaka
Signed-off-by: Denis Shulyaka --- libavformat/spdifdec.c | 47 ++ 1 file changed, 38 insertions(+), 9 deletions(-) diff --git a/libavformat/spdifdec.c b/libavformat/spdifdec.c index 1808fa9d65..58841e7775 100644 --- a/libavformat/spdifdec.c +++

Re: [FFmpeg-devel] [PATCH 2/4] doc/protocols: update options

2021-04-10 Thread Gyan Doshi
On 2021-04-10 11:45, Andriy Gelman wrote: On Sun, 15. Nov 13:20, Andriy Gelman wrote: From: Andriy Gelman Define listen_timeout. Set user-agent and timeout to deprecated. Signed-off-by: Andriy Gelman --- doc/protocols.texi | 13 +++-- 1 file changed, 11 insertions(+), 2

[FFmpeg-devel] [PATCH v2] avformat/rtsp: fix timeout option

2021-04-10 Thread Andriy Gelman
From: Andriy Gelman 92c40ef882be115e72d2aa02f9032b7ce88f8537 added a listen_timeout option for sdp. This allowed a user to set variable timeout in sdp which was originally hard coded to 10 seconds. The commit used the initial_timeout variable to store the value. However, in rtsp this variable

Re: [FFmpeg-devel] [PATCH 2/4] doc/protocols: update options

2021-04-10 Thread Andriy Gelman
On Sun, 15. Nov 13:20, Andriy Gelman wrote: > From: Andriy Gelman > > Define listen_timeout. Set user-agent and timeout to deprecated. > > Signed-off-by: Andriy Gelman > --- > doc/protocols.texi | 13 +++-- > 1 file changed, 11 insertions(+), 2 deletions(-) > > diff --git