Re: [FFmpeg-devel] [PATCH V8 1/3] lavu: add side data AV_FRAME_DATA_DETECTION_BBOXES for object detection/classification

2021-04-13 Thread Guo, Yejun
> -Original Message- > From: myp...@gmail.com > Sent: 2021年4月14日 9:29 > To: FFmpeg development discussions and patches > > Cc: Guo, Yejun > Subject: Re: [FFmpeg-devel] [PATCH V8 1/3] lavu: add side data > AV_FRAME_DATA_DETECTION_BBOXES for object detection/classification > > On Tue,

Re: [FFmpeg-devel] [PATCH V8 1/3] lavu: add side data AV_FRAME_DATA_DETECTION_BBOXES for object detection/classification

2021-04-13 Thread myp...@gmail.com
On Tue, Apr 13, 2021 at 1:26 PM Guo, Yejun wrote: > > --- > doc/APIchanges | 2 + > libavutil/Makefile | 2 + > libavutil/detection_bbox.c | 73 + > libavutil/detection_bbox.h | 107 + > libavutil/frame.c

[FFmpeg-devel] [PATCH] avcodec/libaomdec: export frame pict_type

2021-04-13 Thread James Almer
Should fix ticket #9180 Signed-off-by: James Almer --- libavcodec/libaomdec.c | 14 ++ 1 file changed, 14 insertions(+) diff --git a/libavcodec/libaomdec.c b/libavcodec/libaomdec.c index 1fc0a0001d..6de3bcc5c3 100644 --- a/libavcodec/libaomdec.c +++ b/libavcodec/libaomdec.c @@

Re: [FFmpeg-devel] [PATCH 1/4] avcodec/h264dec: add missing flags to is_avc and nal_length_size AVOptions

2021-04-13 Thread James Almer
On 4/11/2021 10:25 AM, James Almer wrote: On 4/11/2021 6:56 AM, Anton Khirnov wrote: Quoting James Almer (2021-04-10 23:00:20) Signed-off-by: James Almer ---   libavcodec/h264dec.c  | 5 +++--   tests/ref/fate/mov-zombie | 2 +-   2 files changed, 4 insertions(+), 3 deletions(-) diff --git

Re: [FFmpeg-devel] [PATCH] fftools/ffmpeg_filter: Fix check for mjpeg encoder

2021-04-13 Thread Eoff, Ullysses A
Fixes #9186 for me. > -Original Message- > From: ffmpeg-devel On Behalf Of Andreas > Rheinhardt > Sent: Tuesday, April 13, 2021 10:32 AM > To: ffmpeg-devel@ffmpeg.org > Cc: Andreas Rheinhardt > Subject: [FFmpeg-devel] [PATCH] fftools/ffmpeg_filter: Fix check for mjpeg > encoder > >

Re: [FFmpeg-devel] [PATCH 6/9] avcodec/mjpegenc: Include all supported pix_fmts in mpegenc pix_fmts

2021-04-13 Thread Eoff, Ullysses A
> -Original Message- > From: ffmpeg-devel On Behalf Of Andreas > Rheinhardt > Sent: Tuesday, April 13, 2021 10:34 AM > To: ffmpeg-devel@ffmpeg.org > Subject: Re: [FFmpeg-devel] [PATCH 6/9] avcodec/mjpegenc: Include all > supported pix_fmts in mpegenc pix_fmts > > Eoff, Ullysses A: > >

Re: [FFmpeg-devel] [PATCH] avformat/dashdec: Also fetch final partial segment

2021-04-13 Thread Matt Robinson
On Tue, 6 Apr 2021 at 02:36, Steven Liu wrote: > > > 2021年4月6日 上午1:45,Matt Robinson 写道: > > > > Currently, the DASH demuxer omits the final segment for a non-live > > stream (using SegmentTemplate) if it is shorter than the other segments. > > > > Correct calc_max_seg_no to round up when

[FFmpeg-devel] [PATCH] avcodec/encode: ensure encoders don't return empty packets

2021-04-13 Thread James Almer
The current checks ensured that if they contained data, it was refcounted, but then wrongly assumed that side data was present if there was no data, instead of checking for it. Signed-off-by: James Almer --- libavcodec/encode.c | 16 ++-- 1 file changed, 6 insertions(+), 10

Re: [FFmpeg-devel] [PATCH] mov: Prioritize aspect ratio values found in pasp atom

2021-04-13 Thread Vittorio Giovara
On Wed, Apr 7, 2021 at 10:00 PM Derek Buitenhuis wrote: > On 07/04/2021 19:56, Vittorio Giovara wrote: > > My OS doesn't even let me install Quicktime 7, if anybody could chime in > > and help solve this point it would be much appreciated. > > Alternatively, I'd say we shouldn't cargo cult

Re: [FFmpeg-devel] [PATCH 6/9] avcodec/mjpegenc: Include all supported pix_fmts in mpegenc pix_fmts

2021-04-13 Thread Andreas Rheinhardt
Eoff, Ullysses A: > This commit breaks mjpeg_vaapi and mjpeg_qsv encoders. > > https://trac.ffmpeg.org/ticket/9186 > > ...please fix. > Please test this patch: https://ffmpeg.org/pipermail/ffmpeg-devel/2021-April/279028.html It should now work on all strictness levels (it was broken before

[FFmpeg-devel] [PATCH] fftools/ffmpeg_filter: Fix check for mjpeg encoder

2021-04-13 Thread Andreas Rheinhardt
The MJPEG encoder supports some pixel format/color range combinations only when strictness is set to unofficial or less. Before commit 059fc2d9da5364627613fb3e6424079e14dbdfd3 said encoder's pix_fmts array only included the pixel formats supported with default strictness. When strictness was <=

Re: [FFmpeg-devel] [PATCH] libavdevice/gdigrab: fix capture window title contain non-ASCII chars

2021-04-13 Thread Jan Ekström
On Tue, Apr 13, 2021 at 12:35 AM Jan Ekström wrote: > > On Sat, Mar 20, 2021 at 5:34 PM <1160386...@qq.com> wrote: > > > > From: He Yang <1160386...@qq.com> > > > > Signed-off-by: He Yang <1160386...@qq.com> > > Sorry for taking a while to respond, and thank you for the > contribution. I have

Re: [FFmpeg-devel] [PATCH 6/9] avcodec/mjpegenc: Include all supported pix_fmts in mpegenc pix_fmts

2021-04-13 Thread Eoff, Ullysses A
This commit breaks mjpeg_vaapi and mjpeg_qsv encoders. https://trac.ffmpeg.org/ticket/9186 ...please fix. Thanks, U. Artie > -Original Message- > From: ffmpeg-devel On Behalf Of Andreas > Rheinhardt > Sent: Monday, April 05, 2021 10:40 PM > To: ffmpeg-devel@ffmpeg.org > Cc: Andreas

Re: [FFmpeg-devel] [PATCH 3/5] avformat/aaxdec: Check avio_seek() in inner loop for failure

2021-04-13 Thread James Almer
On 4/13/2021 12:45 PM, Michael Niedermayer wrote: Fixes: Timeout Fixes: 32450/clusterfuzz-testcase-minimized-ffmpeg_dem_AAX_fuzzer-4875522262827008 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Niedermayer ---

[FFmpeg-devel] [PATCH 4/5] avformat/utils: Use 64bit earlier in r_frame_rate check

2021-04-13 Thread Michael Niedermayer
Fixes: signed integer overflow: 1406796319 * 2 cannot be represented in type 'int' Fixes: 32777/clusterfuzz-testcase-minimized-ffmpeg_IO_DEMUXER_fuzzer-5632576913014784 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael

[FFmpeg-devel] [PATCH 1/5] avcodec/dpx: Check bits_per_color earlier

2021-04-13 Thread Michael Niedermayer
Fixes: shift exponent 251 is too large for 32-bit type 'int' Fixes: 32147/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_DPX_fuzzer-5519111675314176 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Niedermayer ---

[FFmpeg-devel] [PATCH 2/5] avcodec/exr: increase vlc depth

2021-04-13 Thread Michael Niedermayer
Fixes: shift exponent -4 is negative Fixes: 32265/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_EXR_fuzzer-465133454137753 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Niedermayer --- libavcodec/exr.c | 2 +- 1

[FFmpeg-devel] [PATCH 3/5] avformat/aaxdec: Check avio_seek() in inner loop for failure

2021-04-13 Thread Michael Niedermayer
Fixes: Timeout Fixes: 32450/clusterfuzz-testcase-minimized-ffmpeg_dem_AAX_fuzzer-4875522262827008 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Niedermayer --- libavformat/aaxdec.c | 5 - 1 file changed, 4

[FFmpeg-devel] [PATCH 5/5] tools/target_dec_fuzzer: Adjust threshold for jpeg2000

2021-04-13 Thread Michael Niedermayer
Fixes: Timeout (25->4sec) Fixes: 32780/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_JPEG2000_fuzzer-6017852583837696 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Niedermayer --- tools/target_dec_fuzzer.c | 1 +

[FFmpeg-devel] [PATCH] Closed caption support for cuviddec with ff_parse_a53_cc preserving a53 data

2021-04-13 Thread Dhanish Vijayan
--- libavcodec/cuviddec.c | 183 ++ 1 file changed, 183 insertions(+) diff --git a/libavcodec/cuviddec.c b/libavcodec/cuviddec.c index ec57afdefe..9967cb4c94 100644 --- a/libavcodec/cuviddec.c +++ b/libavcodec/cuviddec.c @@ -31,6 +31,8 @@ #include

Re: [FFmpeg-devel] [PATCH] checkasm: add (private) kperf timing for macOS

2021-04-13 Thread Martin Storsjö
On Tue, 13 Apr 2021, Josh Dekker wrote: Signed-off-by: Josh Dekker --- configure| 2 + tests/checkasm/Makefile | 1 + tests/checkasm/checkasm.c| 19 - tests/checkasm/checkasm.h| 10 ++- tests/checkasm/macos_kperf.c | 143

Re: [FFmpeg-devel] [PATCH] checkasm: add (private) kperf timing for macOS

2021-04-13 Thread Martin Storsjö
On Tue, 13 Apr 2021, Lynne wrote: Could you move this to libavutil and hook this up to libavutil/timer.h as well? I'm a bit hesitant about that, as the API (just like the existing linux perf integration which is predecent for heavyweight timer APIs) requires a bit more setup than what

[FFmpeg-devel] [PATCH v3 2/2] lavc/aarch64: add pred16x16 10-bit functions

2021-04-13 Thread Mikhail Nitenko
Benchmarks: pred16x16_dc_10_c: 124.0 pred16x16_dc_10_neon: 97.2 pred16x16_horizontal_10_c: 71.7 pred16x16_horizontal_10_neon: 66.2 pred16x16_top_dc_10_c: 90.7 pred16x16_top_dc_10_neon: 71.5 pred16x16_vertical_10_c: 64.7 pred16x16_vertical_10_neon: 61.7 Some functions work slower than C and are

[FFmpeg-devel] [PATCH v3 1/2] lavc/aarch64: change h264pred_init structure

2021-04-13 Thread Mikhail Nitenko
Change structure to allow addition of other bit depths. --- libavcodec/aarch64/h264pred_init.c | 57 ++ 1 file changed, 27 insertions(+), 30 deletions(-) diff --git a/libavcodec/aarch64/h264pred_init.c b/libavcodec/aarch64/h264pred_init.c index b144376f90..fc8989ae0d

Re: [FFmpeg-devel] [PATCH] Added Closed caption support for cuviddec for preserving a53 data n GPU decoding

2021-04-13 Thread Dhanish Vijayan
I used the patch provided here - https://github.com/tea/FFmpeg/commit/ba3df26047ca2e2c2a79c4cab436ace032c73d57 With this patch I was able to get the Closed caption issue fixed with the cuvid. After seeing your message, I am trying to figure out how I can use the ff_parse_a53_cc for parsing. The

Re: [FFmpeg-devel] [PATCH] Added Closed caption support for cuviddec for preserving a53 data n GPU decoding

2021-04-13 Thread Timo Rothenpieler
On 13.04.2021 01:41, James Almer wrote: You have ff_parse_a53_cc() in atsc_a53.c for this I'm pretty sure I NAKed this or a very similar patch in the past, asking to not re-implement an entire parser in cuviddec. Same applies here: I'm not going to accept a patch that implements a complex,

Re: [FFmpeg-devel] [PATCH 1/2] fftools/ffprobe: Remove check on show_frames and show_packets in XML writer

2021-04-13 Thread Tobias Rapp
On 31.03.2021 12:13, Tobias Rapp wrote: The "packets_and_frames" element has been added to ffprobe.xsd in 0c9f0da0f7656059e9bd41931d250aafddf35ea3 but apparently removing the check in ffprobe.c has been forgotten. Signed-off-by: Tobias Rapp --- fftools/ffprobe.c | 7 --- 1 file changed,