Re: [FFmpeg-devel] [PATCH v2] x86/tx_float: implement inverse MDCT AVX2 assembly

2022-09-01 Thread Lynne
Sep 2, 2022, 07:49 by d...@lynne.ee: > Version 2 notes: halved the amount of loads and loops for the > pre-transform loop by exploiting the symmetry. > > This commit implements an iMDCT in pure assembly. > > This is capable of processing any mod-8 transforms, rather than just > power of two, but

[FFmpeg-devel] [PATCH v2] x86/tx_float: implement inverse MDCT AVX2 assembly

2022-09-01 Thread Lynne
Version 2 notes: halved the amount of loads and loops for the pre-transform loop by exploiting the symmetry. This commit implements an iMDCT in pure assembly. This is capable of processing any mod-8 transforms, rather than just power of two, but since power of two is all we have assembly for

Re: [FFmpeg-devel] [RFC] d3dva security hw+threads

2022-09-01 Thread Lynne
Sep 2, 2022, 01:46 by t...@rothenpieler.org: > On 02.09.2022 01:32, Michael Niedermayer wrote: > >> Hi all >> >> Theres a use after free issue in H.264 Decoding on d3d11va with multiple >> threads >> I dont have the hardware/platform nor do i know the hw decoding code so i >> made >> no attempt

Re: [FFmpeg-devel] [RFC] d3dva security hw+threads

2022-09-01 Thread Timo Rothenpieler
On 02.09.2022 01:32, Michael Niedermayer wrote: Hi all Theres a use after free issue in H.264 Decoding on d3d11va with multiple threads I dont have the hardware/platform nor do i know the hw decoding code so i made no attempt to fix this beyond asking others to ... hwaccel with multiple

[FFmpeg-devel] [RFC] d3dva security hw+threads

2022-09-01 Thread Michael Niedermayer
Hi all Theres a use after free issue in H.264 Decoding on d3d11va with multiple threads I dont have the hardware/platform nor do i know the hw decoding code so i made no attempt to fix this beyond asking others to ... There where 2 patches posted by the maintainer, neither really felt "right"

Re: [FFmpeg-devel] [PATCH 3/3] avcodec/bink: disallow odd positioned scaled blocks

2022-09-01 Thread Michael Niedermayer
On Tue, Jul 12, 2022 at 08:20:18PM +0200, Michael Niedermayer wrote: > On Tue, Jun 14, 2022 at 12:09:59AM +0200, Michael Niedermayer wrote: > > On Tue, Jun 14, 2022 at 12:01:14AM +0200, Paul B Mahol wrote: > > > On Mon, Jun 13, 2022 at 11:55 PM Michael Niedermayer > > > > > > wrote: > > > > > >

[FFmpeg-devel] [PATCH] avcodec/libtheoraenc: Do not use invalid error code

2022-09-01 Thread Andreas Rheinhardt
Signed-off-by: Andreas Rheinhardt --- libavcodec/libtheoraenc.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/libavcodec/libtheoraenc.c b/libavcodec/libtheoraenc.c index 22835553d6..92bf3a133c 100644 --- a/libavcodec/libtheoraenc.c +++ b/libavcodec/libtheoraenc.c @@

[FFmpeg-devel] [PATCH] x86/tx_float: implement inverse MDCT AVX2 assembly

2022-09-01 Thread Lynne
This commit implements an iMDCT in pure assembly. This is capable of processing any mod-8 transforms, rather than just power of two, but since power of two is all we have assembly for currently, that's what's supported. It would really benefit if we could somehow use the C code to decide which

Re: [FFmpeg-devel] [PATCH] lavu: header and documentation for AVWriter

2022-09-01 Thread Stefano Sabatini
On date Thursday 2022-09-01 15:01:27 +0200, Nicolas George wrote: [...] > Thanks for the review. I do not think it is necessary to send an updated > patch for these changes, is it? Not needed, thanks. ___ ffmpeg-devel mailing list

[FFmpeg-devel] [PATCH 8/8] avformat/matroskaenc: Write CodecDelay for codecs != Opus

2022-09-01 Thread Andreas Rheinhardt
The field is not specific to Opus. The mp2fixed encoder signals initial_padding and is used by both the matroska-encoding-delay test as well as the lavf-mkv tests which necessitated several FATE ref changes. Signed-off-by: Andreas Rheinhardt --- libavformat/matroskaenc.c | 2 +-

[FFmpeg-devel] [PATCH 7/8] avformat/matroskaenc: Use custom min timestamp

2022-09-01 Thread Andreas Rheinhardt
Signed-off-by: Andreas Rheinhardt --- libavformat/matroskaenc.c | 1 + libavformat/webm_chunk.c | 4 + tests/fate/matroska.mak| 2 +- tests/ref/fate/matroska-ogg-opus-remux | 108 ++-- tests/ref/fate/matroska-opus-remux | 130

[FFmpeg-devel] [PATCH 6/8] avformat/mux: Allow muxers to set custom min timestamp

2022-09-01 Thread Andreas Rheinhardt
Matroska requires pts to be >= 0 with a slight exception: It has a mechanism to deal with codec delay, i.e. with the data added at the beginning that does not correspond to actual input data and should be discarded by the player. Only the audio actually intended to be output needs to have a

[FFmpeg-devel] [PATCH 5/8] avformat/matroskaenc: Actually apply timestamp offset for Opus

2022-09-01 Thread Andreas Rheinhardt
Matroska generally requires timestamps to be nonnegative, but there is an exception: Data that corresponds to encoder delay and is not supposed to be output anyway can have a negative timestamp. This is achieved by using the CodecDelay header field: The demuxer has to subtract this value from the

[FFmpeg-devel] [PATCH 4/8] avformat/matroskaenc: Don't override samplerate for CodecDelay

2022-09-01 Thread Andreas Rheinhardt
Opus can be decoded to multiple samplerates (namely 48kHz, 24KHz, 16Khz, 12 KHz and 8Khz); libopus as well as our encoder wrapper support these sample rates. The OpusHead contains a field for this original samplerate. Yet the pre-skip (and the granule-position in the Ogg-Opus mapping in general)

[FFmpeg-devel] [PATCH 3/8] avformat/matroskaenc: Only write DiscardPadding if nonzero

2022-09-01 Thread Andreas Rheinhardt
It is possible for the trailing padding to be zero, namely e.g. if the AV_PKT_DATA_SKIP_SAMPLES side data is used for leading padding. Matroska supports this (use a negative DiscardPadding), but players do not; at least Firefox refuses to play such a file. So for now only write DiscardPadding if

[FFmpeg-devel] [PATCH 2/8] fate/matroska: Add tests for muxing with initial_padding

2022-09-01 Thread Andreas Rheinhardt
Signed-off-by: Andreas Rheinhardt --- tests/fate/matroska.mak| 19 + tests/ref/fate/matroska-encoding-delay | 85 tests/ref/fate/matroska-ogg-opus-remux | 92 ++ tests/ref/fate/matroska-opus-remux | 103 +

[FFmpeg-devel] [PATCH 1/8] fftools/ffprobe: Report initial and trailing padding

2022-09-01 Thread Andreas Rheinhardt
Signed-off-by: Andreas Rheinhardt --- trailing_padding seems to be unused and could actually be deprecated. doc/ffprobe.xsd | 2 ++ fftools/ffprobe.c | 3 +++ tests/ref/fate/concat-demuxer-extended-lavf-mxf | 2 +-

[FFmpeg-devel] [PATCH]lavfi/rotate: Fix undefined behaviour

2022-09-01 Thread Carl Eugen Hoyos
Hi! Attached patch fixes ticket #9799. Please comment, Carl Eugen From 2cce687961c3b56a92d88184269bf9fa075ae297 Mon Sep 17 00:00:00 2001 From: Carl Eugen Hoyos Date: Thu, 1 Sep 2022 20:55:54 +0200 Subject: [PATCH] lavfi/rotate: Avoid undefined behaviour. Fixes the following integer overflows:

Re: [FFmpeg-devel] [PATCH 1/1] avcodec/mpegutils: add motion_vec debug mode

2022-09-01 Thread Chema Gonzalez
Hi Paul, Can you please describe how you can get the MV values? Thanks, -Chema On Thu, Sep 1, 2022 at 10:52 AM Paul B Mahol wrote: > > On Thu, Sep 1, 2022 at 5:06 PM Chema Gonzalez wrote: > > > Hi, > > > > All the other debug modes (qp, skip, mb_type) use the same approach. > > > > > This

Re: [FFmpeg-devel] [PATCH]lavc/tiff: Support multi-component files without RowsPerStrip tag

2022-09-01 Thread Carl Eugen Hoyos
Am Do., 1. Sept. 2022 um 04:10 Uhr schrieb Steven Liu : > > Carl Eugen Hoyos 于2022年9月1日周四 01:48写道: > > > > Hi! > > > > Attached patch fixes ticket #9514 for me. > > > > Please review, Carl Eugen > > lgtm Patch applied. Thank you, Carl Eugen ___

Re: [FFmpeg-devel] [PATCH 1/1] avcodec/mpegutils: add motion_vec debug mode

2022-09-01 Thread Paul B Mahol
On Thu, Sep 1, 2022 at 5:06 PM Chema Gonzalez wrote: > Hi, > > All the other debug modes (qp, skip, mb_type) use the same approach. > > This adds to much code for something that is already possible. > -Chema > > > On Thu, Sep 1, 2022 at 6:30 AM Ronald S. Bultje > wrote: > > > > Hi, > > > > On

Re: [FFmpeg-devel] [PATCH 1/1] avcodec/mpegutils: add motion_vec debug mode

2022-09-01 Thread Chema Gonzalez
Hi, All the other debug modes (qp, skip, mb_type) use the same approach. -Chema On Thu, Sep 1, 2022 at 6:30 AM Ronald S. Bultje wrote: > > Hi, > > On Wed, Aug 31, 2022 at 7:10 PM Chema Gonzalez wrote: >> >> Add a new debug mode ("motion_vec") that prints the values of the >> motion vectors

[FFmpeg-devel] [PATCH v11 9/9] Changes in Changelog and MAINTAINERS files

2022-09-01 Thread Dawid Kozinski
- Changelog update - MAINTAINERS update Signed-off-by: Dawid Kozinski --- Changelog | 4 ++-- MAINTAINERS | 5 + 2 files changed, 7 insertions(+), 2 deletions(-) diff --git a/Changelog b/Changelog index fa83786a20..9631262858 100644 --- a/Changelog +++ b/Changelog @@ -36,7 +36,8 @@

[FFmpeg-devel] [PATCH v11 8/9] Extended MOV demuxer to handle EVC video content

2022-09-01 Thread Dawid Kozinski
- Added evc extension to the list of extensions for ff_mov_demuxer Signed-off-by: Dawid Kozinski --- libavformat/mov.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavformat/mov.c b/libavformat/mov.c index 35e2271b14..d537dfd434 100644 --- a/libavformat/mov.c +++

[FFmpeg-devel] [PATCH v11 7/9] Extended MOV muxer to handle EVC video content

2022-09-01 Thread Dawid Kozinski
- Changes in mov_write_video_tag function to handle EVC elementary stream - Provided structure EVCDecoderConfigurationRecord that specifies the decoder configuration information for ISO/IEC 23094-1 video content Signed-off-by: Dawid Kozinski --- libavformat/Makefile| 2 +-

Re: [FFmpeg-devel] [PATCH 1/1] avcodec/mpegutils: add motion_vec debug mode

2022-09-01 Thread Ronald S. Bultje
Hi, On Wed, Aug 31, 2022 at 7:10 PM Chema Gonzalez wrote: > Add a new debug mode ("motion_vec") that prints the values of the > motion vectors (MV). > Isn't this super-hacky? In a well-designed system, a codec might export its MVs using designated structs (which we already have) and then use

[FFmpeg-devel] [PATCH v11 6/9] Provided support for EVC decoder

2022-09-01 Thread Dawid Kozinski
- Added EVC decoder wrapper - Changes in project configuration file and libavcodec Makefile - Added documentation for xevd wrapper Signed-off-by: Dawid Kozinski --- configure | 4 + doc/decoders.texi | 24 +++ doc/general_contents.texi | 10 +- libavcodec/Makefile

[FFmpeg-devel] [PATCH v11 5/9] Provided support for EVC encoder

2022-09-01 Thread Dawid Kozinski
- Added EVC encoder wrapper - Changes in project configuration file and libavcodec Makefile - Added documentation for xeve wrapper Signed-off-by: Dawid Kozinski --- configure | 4 + doc/encoders.texi | 69 + doc/general_contents.texi | 11 + libavcodec/Makefile

[FFmpeg-devel] [PATCH v11 4/9] Added demuxer to handle reading EVC video files

2022-09-01 Thread Dawid Kozinski
- Provided AVInputFormat structure describing EVC input format (ff_evc_demuxer) Signed-off-by: Dawid Kozinski --- libavformat/Makefile | 1 + libavformat/allformats.c | 1 + libavformat/evcdec.c | 124 +++ 3 files changed, 126 insertions(+)

[FFmpeg-devel] [PATCH v11 3/9] Added muxer to handle writing EVC encoded data into file or output bytestream

2022-09-01 Thread Dawid Kozinski
- Provided AVOutputFormat structure describing EVC output format (ff_evc_muxer) - Added documentation for EVC muxer Signed-off-by: Dawid Kozinski --- doc/muxers.texi | 6 ++ libavformat/Makefile | 1 + libavformat/allformats.c | 1 + libavformat/rawenc.c | 13

[FFmpeg-devel] [PATCH v11 2/9] Added parser implementaion for EVC format

2022-09-01 Thread Dawid Kozinski
Signed-off-by: Dawid Kozinski --- libavcodec/Makefile | 1 + libavcodec/evc.h| 155 + libavcodec/evc_parser.c | 726 libavcodec/parsers.c| 1 + 4 files changed, 883 insertions(+) create mode 100644 libavcodec/evc.h create

[FFmpeg-devel] [PATCH v11 1/9] MPEG-5 EVC codec registration

2022-09-01 Thread Dawid Kozinski
Added prerequisites that must be met before providing support for the MPEG-5 EVC codec - Added new entry to codec IDs list - Added new entry to the codec descriptor list - Bumped libavcodec minor version - Added profiles for EVC codec Signed-off-by: Dawid Kozinski --- libavcodec/avcodec.h|

Re: [FFmpeg-devel] [PATCH] lavu: header and documentation for AVWriter

2022-09-01 Thread Nicolas George
Stefano Sabatini (12022-09-01): > serializeS Locally fixed. > This "something" is vague and can be confused with the "something" in > "av_something_write", maybe something as: > when presented with invalid arguments, if the flag is not set the > called method should leave... No, the first

Re: [FFmpeg-devel] [PATCH v2] fftools/ffplay: fix rotation incorrect when frame contains the displaymatrix

2022-09-01 Thread zhilizhao(赵志立)
> On Sep 1, 2022, at 12:53 PM, 1035567...@qq.com wrote: > > From: Wang Yaqiang > > For example, if the jpeg contains exif information > and the rotation direction is included in the exif, > the displaymatrix will be set on the side_data of the frame when decoding. > However, when ffplay is

Re: [FFmpeg-devel] [PATCH] fftools/ffmpeg: fix av_display_rotation_set() type cast

2022-09-01 Thread Steven Liu
Zhao Zhili 于2022年9月1日周四 10:59写道: > > From: Zhao Zhili > > Signed-off-by: Zhao Zhili > --- > fftools/ffmpeg.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/fftools/ffmpeg.c b/fftools/ffmpeg.c > index fbabbe6ea2..ecaf3bd984 100644 > --- a/fftools/ffmpeg.c > +++