[FFmpeg-devel] [PATCH 3/3] avcodec/fmtconvert: Remove unused AVCodecContext parameter

2022-09-19 Thread Andreas Rheinhardt
Unused since d74a8cb7e42f703be5796eeb485f06af710ae8ca. Signed-off-by: Andreas Rheinhardt --- libavcodec/aarch64/fmtconvert_init.c | 4 +--- libavcodec/ac3dec.c | 2 +- libavcodec/ac3dec.h | 1 + libavcodec/arm/fmtconvert_init_arm.c | 3 +--

[FFmpeg-devel] [PATCH 2/3] avcodec/blockdsp: Remove unused AVCodecContext parameter

2022-09-19 Thread Andreas Rheinhardt
Possible since be95df12bb06b183c8d2aea3b0831fdf05466cf3. Signed-off-by: Andreas Rheinhardt --- libavcodec/4xm.c | 2 +- libavcodec/asvdec.c| 2 +- libavcodec/bink.c | 2 +- libavcodec/blockdsp.c | 5 ++--- libavcodec/blockdsp.h | 6 ++

[FFmpeg-devel] [PATCH 1/3] avcodec/cavsdsp: Remove unused function parameter

2022-09-19 Thread Andreas Rheinhardt
Signed-off-by: Andreas Rheinhardt --- libavcodec/cavs.c| 2 +- libavcodec/cavsdsp.c | 7 +++ libavcodec/cavsdsp.h | 6 +++--- libavcodec/x86/cavsdsp.c | 7 +++ 4 files changed, 10 insertions(+), 12 deletions(-) diff --git a/libavcodec/cavs.c b/libavcodec/cavs.c index

Re: [FFmpeg-devel] [PATCH 1/6] fate/ffmpeg: Use transcode instead of enc_dec in shortest-sub test

2022-09-19 Thread Andreas Rheinhardt
Andreas Rheinhardt: > enc_dec is designed for raw input and output and computes > the PSNR between these two. The input of the shortest-sub > test is the idx file of a vobsub sub+idx combination > and the output is the output of framecrc of said vobsub > subtitle muxed into Matroska together with

[FFmpeg-devel] [PATCH] avformat/movenc: Write auxi box for animated AVIF with alpha

2022-09-19 Thread Vignesh Venkatasubramanian
According to the HEIF specification Section 7.5.3.1, tracks with handler_type 'auxv' must contain a 'auxi' box in its SampleEntry to notify the nature of the auxiliary track to the decoder. The content is the same as the 'auxC' box. So paramterize and re-use the existing function. Signed-off-by:

[FFmpeg-devel] [PATCH 4/4] avcodec/me_cmp: Don't access AVCodecContext directly in ff_me_cmp_init()

2022-09-19 Thread Andreas Rheinhardt
Instead, pass the used parameters directly. This has the advantage that the user needn't have an AVCodecContext to call ff_me_cmp_init(). This in particular applies to the checkasm test for this. The calls to avcodec_alloc_context3() and avcodec_free_context() made checkasm pull most of

[FFmpeg-devel] [PATCH 3/4] avcodec/tests/snowenc: Don't use SnowContext

2022-09-19 Thread Andreas Rheinhardt
This test tests only the DSP functions and does not really use the SnowContext at all. Signed-off-by: Andreas Rheinhardt --- libavcodec/tests/snowenc.c | 43 +++--- 1 file changed, 21 insertions(+), 22 deletions(-) diff --git a/libavcodec/tests/snowenc.c

[FFmpeg-devel] [PATCH 2/4] avcodec/tests/snowenc: Don't unnecessarily include snowenc.c

2022-09-19 Thread Andreas Rheinhardt
This made this file export the snow encoder and therefore pulled most of libavcodec into the corresponding test tool. Signed-off-by: Andreas Rheinhardt --- libavcodec/tests/snowenc.c | 8 +++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/libavcodec/tests/snowenc.c

[FFmpeg-devel] [PATCH 1/4] avcodec/snow: Move ff_snow_inner_add_yblock() to snow_dwt.c

2022-09-19 Thread Andreas Rheinhardt
Only used there and by x86 snow asm code as fallback. Signed-off-by: Andreas Rheinhardt --- libavcodec/snow.c | 33 - libavcodec/snow.h | 3 --- libavcodec/snow_dwt.c | 32 libavcodec/snow_dwt.h | 3 +++ 4 files changed,

Re: [FFmpeg-devel] [PATCH] lavc: add detection of forced subtitles

2022-09-19 Thread Hendrik Leppkes
On Mon, Sep 19, 2022 at 10:53 PM Andreas Rheinhardt wrote: > > Scott Theisen: > > This is from the following MythTV commits: > > libavcodec: add support for detecting forced subtitle segments. > > https://github.com/MythTV/mythtv/commit/5099f1a5777966fba482b623e581c1eef5c8fc09 > > This adds

Re: [FFmpeg-devel] [PATCH] lavc: add detection of forced subtitles

2022-09-19 Thread Andreas Rheinhardt
Scott Theisen: > This is from the following MythTV commits: > libavcodec: add support for detecting forced subtitle segments. > https://github.com/MythTV/mythtv/commit/5099f1a5777966fba482b623e581c1eef5c8fc09 > This adds forced subtitle segment detection to the PGS subtitle decoder and > copies

Re: [FFmpeg-devel] [PATCH] tests/checkasm: add a test for VorbisDSPContext

2022-09-19 Thread James Almer
On 9/19/2022 2:57 PM, Rémi Denis-Courmont wrote: +void checkasm_check_vorbisdsp(void) +{ +VorbisDSPContext dsp; + +ff_vorbisdsp_init(); + +if (check_func(dsp.vorbis_inverse_coupling, "vorbis_inverse_coupling")) +test_inverse_coupling(); +report("vorbis_inverse_coupling");

Re: [FFmpeg-devel] [PATCH] tests/checkasm: add a test for VorbisDSPContext

2022-09-19 Thread James Almer
On 9/19/2022 2:55 PM, Ronald S. Bultje wrote: Hi, On Mon, Sep 19, 2022 at 1:05 PM James Almer wrote: --- a/tests/checkasm/checkasm.c +++ b/tests/checkasm/checkasm.c @@ -165,6 +165,9 @@ static const struct { #if CONFIG_VIDEODSP { "videodsp", checkasm_check_videodsp },

Re: [FFmpeg-devel] [PATCH] tests/checkasm: add a test for VorbisDSPContext

2022-09-19 Thread Rémi Denis-Courmont
Le maanantaina 19. syyskuuta 2022, 20.04.41 EEST James Almer a écrit : > Signed-off-by: James Almer > --- > tests/checkasm/Makefile| 1 + > tests/checkasm/checkasm.c | 3 ++ > tests/checkasm/checkasm.h | 1 + > tests/checkasm/vorbisdsp.c | 88 ++ >

Re: [FFmpeg-devel] [PATCH] tests/checkasm: add a test for VorbisDSPContext

2022-09-19 Thread Ronald S. Bultje
Hi, On Mon, Sep 19, 2022 at 1:05 PM James Almer wrote: > --- a/tests/checkasm/checkasm.c > +++ b/tests/checkasm/checkasm.c > @@ -165,6 +165,9 @@ static const struct { > #if CONFIG_VIDEODSP > { "videodsp", checkasm_check_videodsp }, > #endif > +#if CONFIG_VIDEODSP > +

[FFmpeg-devel] [PATCH] lavc: add detection of forced subtitles

2022-09-19 Thread Scott Theisen
This is from the following MythTV commits: libavcodec: add support for detecting forced subtitle segments. https://github.com/MythTV/mythtv/commit/5099f1a5777966fba482b623e581c1eef5c8fc09 This adds forced subtitle segment detection to the PGS subtitle decoder and copies the result to AVSubtitle.

Re: [FFmpeg-devel] [PATCH] avcodec/vorbisdec: Move ff_vorbis_inverse_coupling() to vorbisdsp.c

2022-09-19 Thread James Almer
On 9/19/2022 2:16 PM, Andreas Rheinhardt wrote: Only used there. Also make it static. Signed-off-by: Andreas Rheinhardt --- libavcodec/vorbis.h| 1 - libavcodec/vorbisdec.c | 23 --- libavcodec/vorbisdsp.c | 26 -- 3 files changed, 24

[FFmpeg-devel] [PATCH] avcodec/vorbisdec: Move ff_vorbis_inverse_coupling() to vorbisdsp.c

2022-09-19 Thread Andreas Rheinhardt
Only used there. Also make it static. Signed-off-by: Andreas Rheinhardt --- libavcodec/vorbis.h| 1 - libavcodec/vorbisdec.c | 23 --- libavcodec/vorbisdsp.c | 26 -- 3 files changed, 24 insertions(+), 26 deletions(-) diff --git

[FFmpeg-devel] [PATCH] tests/checkasm: add a test for VorbisDSPContext

2022-09-19 Thread James Almer
Signed-off-by: James Almer --- tests/checkasm/Makefile| 1 + tests/checkasm/checkasm.c | 3 ++ tests/checkasm/checkasm.h | 1 + tests/checkasm/vorbisdsp.c | 88 ++ tests/fate/checkasm.mak| 1 + 5 files changed, 94 insertions(+) create mode

Re: [FFmpeg-devel] [PATCH] avcodec/libvpxenc: add -min-gf-interval

2022-09-19 Thread Vignesh Venkatasubramanian
On Tue, Sep 13, 2022 at 5:28 PM James Zern wrote: > > this maps to the vpxenc argument with the same name and the > VP9E_SET_MIN_GF_INTERVAL codec control > > Signed-off-by: James Zern > --- > doc/encoders.texi | 2 ++ > libavcodec/libvpxenc.c | 11 +++ > libavcodec/version.h |

[FFmpeg-devel] [PATCH] Reduce rounding error in ff_scale_adjust_dimensions.

2022-09-19 Thread Tristan Schmelcher
When force_original_aspect_ratio and force_divisible_by are both used, dimensions are now rounded to the nearest allowed multiple of force_divisible_by rather than first rounding to the nearest integer and then rounding in a static direction. This results in less distortion of the aspect ratio.

[FFmpeg-devel] [PATCHv3 3/3] lavc/vorbisdec: use intermediate variables

2022-09-19 Thread remi
From: Rémi Denis-Courmont The compiler cannot infer that the two float vectors do not alias, causing unnecessary extra loads and serialisation. This patch caches the two input values in local variables so that compiler can optimise individual loop iterations. --- libavcodec/vorbisdec.c | 24

[FFmpeg-devel] [PATCHv3 2/3] lavc/vorbisdsp: use ptrdiff_t rather than intptr_t

2022-09-19 Thread remi
From: Rémi Denis-Courmont ... for a difference between pointers. --- libavcodec/aarch64/vorbisdsp_init.c | 2 +- libavcodec/arm/vorbisdsp_init_arm.c | 2 +- libavcodec/ppc/vorbisdsp_altivec.c | 2 +- libavcodec/vorbis.h | 2 +- libavcodec/vorbisdec.c | 2 +-

[FFmpeg-devel] [PATCHv3 1/3] lavc/vorbisdec: use ptrdiff_t to iterate over intptr_t

2022-09-19 Thread remi
From: Rémi Denis-Courmont While this probably never overflows, we are better safe than sorry. The callback prototype should probably also use ptrdiff_t or size_t, but I diggress (this would affect the DSP callback prototype). --- libavcodec/ppc/vorbisdsp_altivec.c | 4 ++--

Re: [FFmpeg-devel] [PATCHv2 1/2] lavc/vorbisdec: use ptrdiff_t to iterate over intptr_t

2022-09-19 Thread Rémi Denis-Courmont
Le maanantaina 19. syyskuuta 2022, 18.48.11 EEST James Almer a écrit : > On 9/19/2022 12:35 PM, r...@remlab.net wrote: > > From: Rémi Denis-Courmont > > > > While this probably never overflows, we are better safe than sorry. > > > > The callback prototype should probably also use ptrdiff_t or

Re: [FFmpeg-devel] [PATCHv2 1/2] lavc/vorbisdec: use ptrdiff_t to iterate over intptr_t

2022-09-19 Thread James Almer
On 9/19/2022 12:35 PM, r...@remlab.net wrote: From: Rémi Denis-Courmont While this probably never overflows, we are better safe than sorry. The callback prototype should probably also use ptrdiff_t or size_t, but I diggress (this would affect the DSP callback prototype). If you mean using

[FFmpeg-devel] [PATCHv2 1/2] lavc/vorbisdec: use ptrdiff_t to iterate over intptr_t

2022-09-19 Thread remi
From: Rémi Denis-Courmont While this probably never overflows, we are better safe than sorry. The callback prototype should probably also use ptrdiff_t or size_t, but I diggress (this would affect the DSP callback prototype). --- libavcodec/vorbisdec.c | 3 +-- 1 file changed, 1 insertion(+),

[FFmpeg-devel] [PATCHv2 2/2] lavc/vorbisdec: use intermediate variables

2022-09-19 Thread remi
From: Rémi Denis-Courmont The compiler cannot infer that the two float vectors do not alias, causing unnecessary extra loads and serialisation. This patch caches the two input values in local variables so that compiler can optimise individual loop iterations. --- libavcodec/vorbisdec.c | 24

[FFmpeg-devel] [PATCH v2] format/imfdec: improve error handling when selecting tracks for playback

2022-09-19 Thread pal
From: Pierre-Anthony Lemieux --- libavformat/imfdec.c | 15 --- 1 file changed, 12 insertions(+), 3 deletions(-) diff --git a/libavformat/imfdec.c b/libavformat/imfdec.c index 5bbe7a53f8..9ba8b6de8b 100644 --- a/libavformat/imfdec.c +++ b/libavformat/imfdec.c @@ -681,8 +681,11 @@

Re: [FFmpeg-devel] [PATCH] format/imfdec: improve error handling when selecting tracks for playback

2022-09-19 Thread Pierre-Anthony Lemieux
On Mon, Sep 19, 2022 at 7:42 AM Michael Niedermayer wrote: > > On Sat, Sep 17, 2022 at 08:57:37AM -0700, Pierre-Anthony Lemieux wrote: > > On Sat, Sep 17, 2022 at 7:43 AM Michael Niedermayer > > wrote: > > > > > > On Fri, Sep 16, 2022 at 01:19:09PM -0700, Pierre-Anthony Lemieux wrote: > > > > On

[FFmpeg-devel] [PATCH] avfilter/metal: fix build when minimun deployments is less than ios 13

2022-09-19 Thread Aki Sakurai
supportsFamily is only available after ios 13. https://developer.apple.com/documentation/metal/mtldevice/3143473-supportsfamily?language=objc Signed-off-by: Aki Sakurai --- libavfilter/metal/utils.m | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavfilter/metal/utils.m

Re: [FFmpeg-devel] [PATCH] format/imfdec: improve error handling when selecting tracks for playback

2022-09-19 Thread Michael Niedermayer
On Sat, Sep 17, 2022 at 08:57:37AM -0700, Pierre-Anthony Lemieux wrote: > On Sat, Sep 17, 2022 at 7:43 AM Michael Niedermayer > wrote: > > > > On Fri, Sep 16, 2022 at 01:19:09PM -0700, Pierre-Anthony Lemieux wrote: > > > On Fri, Sep 16, 2022 at 1:15 PM Michael Niedermayer > > > wrote: > > > > >

Re: [FFmpeg-devel] [PATCH v2 2/2] swscale/output: Don't call av_pix_fmt_desc_get() in a loop

2022-09-19 Thread Andreas Rheinhardt
Michael Niedermayer: > On Fri, Sep 16, 2022 at 04:55:39PM +0200, Andreas Rheinhardt wrote: >> Up until now, libswscale/output.c used a macro to write >> an output pixel which involved a call to av_pix_fmt_desc_get() >> to find out whether the input pixel format is BE or LE >> despite this being

Re: [FFmpeg-devel] [PATCH v2 2/2] swscale/output: Don't call av_pix_fmt_desc_get() in a loop

2022-09-19 Thread Michael Niedermayer
On Fri, Sep 16, 2022 at 04:55:39PM +0200, Andreas Rheinhardt wrote: > Up until now, libswscale/output.c used a macro to write > an output pixel which involved a call to av_pix_fmt_desc_get() > to find out whether the input pixel format is BE or LE > despite this being known at compile-time (there

Re: [FFmpeg-devel] [PATCH v2 1/2] swscale/input: Avoid calls to av_pix_fmt_desc_get()

2022-09-19 Thread Andreas Rheinhardt
Andreas Rheinhardt: > Up until now, libswscale/input.c used a macro to read > an input pixel which involved a call to av_pix_fmt_desc_get() > to find out whether the input pixel format is BE or LE > despite this being known at compile-time (there are templates > per pixfmt). Even worse, these

Re: [FFmpeg-devel] [PATCH] avutil/dict: Error out in case of key == NULL

2022-09-19 Thread Andreas Rheinhardt
Andreas Rheinhardt: > Up until now, using NULL as key in av_dict_get() on a non-empty > AVDictionary would crash; using NULL as key in av_dict_set() > would also crash for a non-empty AVDictionary unless AV_DICT_MULTIKEY > was set; in case the dictionary was initially empty or AV_DICT_MULTIKEY >

Re: [FFmpeg-devel] [PATCH v4 4/6] lavu/display: Add horizontal and vertical scaling to the display matrix

2022-09-19 Thread Andreas Rheinhardt
Thilo Borgmann: > --- > doc/APIchanges | 3 +++ > libavutil/display.c | 35 +++ > libavutil/display.h | 26 ++ > libavutil/version.h | 2 +- > 4 files changed, 65 insertions(+), 1 deletion(-) > > diff --git a/doc/APIchanges

[FFmpeg-devel] [PATCH] lavc/pthread_frame: always transfer stashed hwaccel state

2022-09-19 Thread Anton Khirnov
Fixes assertion failures after avcodec_flush_buffers(), where stashed hwaccel state is present, but prev_thread is NULL. Found-by: Wang Bin --- libavcodec/pthread_frame.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/libavcodec/pthread_frame.c

Re: [FFmpeg-devel] [PATCH v4] libavfilter/x86/vf_convolution: add sobel filter optimization and unit test with intel AVX512 VNNI

2022-09-19 Thread Andreas Rheinhardt
bin.wang-at-intel@ffmpeg.org: > From: bwang30 > > This commit enabled assembly code with intel AVX512 VNNI and added unit test > for sobel filter > > sobel_c: 4537 > sobel_avx512icl 2136 > > Signed-off-by: bwang30 > --- > libavfilter/convolution.h | 2 + >

Re: [FFmpeg-devel] [PATCH v4] libavfilter/x86/vf_convolution: add sobel filter optimization and unit test with intel AVX512 VNNI

2022-09-19 Thread Henrik Gramner
On Wed, Sep 7, 2022 at 8:47 AM wrote: > +.loop1: > +pxor m4, m4 > +pxor m5, m5 Those zero-initializations are redundant. Aside from that the asm LGTM. ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org

[FFmpeg-devel] [PATCH v4 5/6] ffmpeg: Add display_matrix option

2022-09-19 Thread Thilo Borgmann
From: Jan Ekström This enables overriding the rotation as well as horizontal/vertical flip state of a specific video stream on the input side. Additionally, switch the singular test that was utilizing the rotation metadata to instead override the input display rotation, thus leading to the same

[FFmpeg-devel] [PATCH v4 4/6] lavu/display: Add horizontal and vertical scaling to the display matrix

2022-09-19 Thread Thilo Borgmann
--- doc/APIchanges | 3 +++ libavutil/display.c | 35 +++ libavutil/display.h | 26 ++ libavutil/version.h | 2 +- 4 files changed, 65 insertions(+), 1 deletion(-) diff --git a/doc/APIchanges b/doc/APIchanges index

[FFmpeg-devel] [PATCH v4 6/6] ffmpeg: Deprecate display rotation override with a metadata key

2022-09-19 Thread Thilo Borgmann
From: Jan Ekström Now that we have proper options for defining display matrix overrides, this should no longer be required. fftools does not have its own versioning, so for now the define is just set to 1 and disables the functionality if set to zero. --- fftools/ffmpeg.c | 2 ++

[FFmpeg-devel] [PATCH v4 3/6] fftools: Add support for dictionary options

2022-09-19 Thread Thilo Borgmann
From: Jan Ekström --- fftools/cmdutils.c | 17 + fftools/cmdutils.h | 2 ++ fftools/ffmpeg_opt.c | 29 ++--- 3 files changed, 45 insertions(+), 3 deletions(-) diff --git a/fftools/cmdutils.c b/fftools/cmdutils.c index b6dd73902b..f918d83854 100644

[FFmpeg-devel] [PATCH v4 2/6] fftools/cmdutils: Print arguments of options

2022-09-19 Thread Thilo Borgmann
--- fftools/cmdutils.c | 5 + fftools/cmdutils.h | 1 + 2 files changed, 6 insertions(+) diff --git a/fftools/cmdutils.c b/fftools/cmdutils.c index f911c52be2..b6dd73902b 100644 --- a/fftools/cmdutils.c +++ b/fftools/cmdutils.c @@ -162,6 +162,11 @@ void show_help_options(const OptionDef

[FFmpeg-devel] [PATCH v4 1/6] lavu/opt: Allow options to be arguments of other options

2022-09-19 Thread Thilo Borgmann
Adds AV_OPT_FLAG_ARGUMENT for options being used as arguments for other options. Adds av_arg_show() to allow printing of such arguments in help output. --- doc/APIchanges | 4 libavutil/opt.c | 14 +- libavutil/opt.h | 8 libavutil/version.h | 4 ++-- 4

[FFmpeg-devel] [PATCH v4 0/6] Add display_matrix option

2022-09-19 Thread Thilo Borgmann
Hi, this is an updated and cleaned-up version of Jan's patchset discussed in [1], now v4... I'd especially appreciate any comments on 5/6, ffmpeg_opt.c:119ff which is pretty ugly as-is. Previous reviews were split between threads [2][3] and are merged into. Now it comes with cover letter as

Re: [FFmpeg-devel] [PATCH v3 2/3] lavc/decode: Add internal surface re-allocate method for hwaccel

2022-09-19 Thread Wang, Fei W
On Wed, 2022-09-07 at 22:56 +0100, Mark Thompson wrote: > On 23/08/2022 09:19, Fei Wang wrote: > > From: Linjie Fu > > > > Add HWACCEL_CAP_INTERNAL_ALLOC flag to indicate hwaccels are able > > to > > re-allocate surface internally through ff_decode_get_hw_frames_ctx. > > So that hwaccels don't