Re: [FFmpeg-devel] [PATCH] configure: check for sysctl.h explicitly

2023-01-20 Thread Aman Karmani
On Tue, Jan 17, 2023 at 3:23 AM Andreas Rheinhardt < andreas.rheinha...@outlook.com> wrote: > Aman Karmani: > > From: Aman Karmani > > > > HAVE_SYSCTL is used to guard #include , so make sure > > we only define it when that header is present. > > > > In recent glibc, the header was removed: > >

[FFmpeg-devel] [PATCH] avcodec/mfenc: fix double-free on init failure

2023-01-20 Thread Cameron Gutman
mfenc sets FF_CODEC_CAP_INIT_CLEANUP, so calling mf_close() on failure inside mf_init() results in a double-free. Signed-off-by: Cameron Gutman --- libavcodec/mfenc.c | 1 - 1 file changed, 1 deletion(-) diff --git a/libavcodec/mfenc.c b/libavcodec/mfenc.c index 36a6d8482d..f3415df10b 100644

Re: [FFmpeg-devel] [PATCH 04/26] avcodec: remove FF_API_THREAD_SAFE_CALLBACKS

2023-01-20 Thread Michael Niedermayer
On Mon, Jan 16, 2023 at 10:38:18AM -0300, James Almer wrote: > Signed-off-by: James Almer > --- > fftools/ffmpeg.c | 5 - > libavcodec/avcodec.h | 21 --- > libavcodec/decode.c | 13 -- > libavcodec/encode.c | 7 +- >

Re: [FFmpeg-devel] [PATCH 4/5] lavfi/graphparser: reimplement avfilter_graph_parse* using new API

2023-01-20 Thread Anton Khirnov
Quoting Nicolas George (2023-01-20 21:47:16) > Anton Khirnov (12023-01-20): > > --- > > libavfilter/graphparser.c | 537 +- > > 1 file changed, 126 insertions(+), 411 deletions(-) > > I notice you removed the "RFC" from the subject line, That means I now

Re: [FFmpeg-devel] [PATCH] avcodec/libjxldec: fix gamma22 and gamma28 recognization

2023-01-20 Thread Jan Ekström
On Wed, Jan 18, 2023 at 4:24 PM Leo Izen wrote: > > Gamma 2.2 and Gamma 2.8 are tagged in the file as 0.45455 and 0.35714, > respectively (i.e. 1/2.2 and 1/2.8). Trying to identify them as 2.2 and > 2.8 instead of these values will cause the transfer function to not > properly be recognized. This

Re: [FFmpeg-devel] [PATCH 4/5] lavfi/graphparser: reimplement avfilter_graph_parse* using new API

2023-01-20 Thread Nicolas George
Nicolas George (12023-01-20): > - Writing a large patch for a part of the code you know well or for a > new feature is fine, of course. In fact, even for code we know well, we should consult, as long as we are not the only one who knows it well: as long as other developers might also have plans

Re: [FFmpeg-devel] [PATCH 4/5] lavfi/graphparser: reimplement avfilter_graph_parse* using new API

2023-01-20 Thread Nicolas George
Jean-Baptiste Kempf (12023-01-20): > First, maintainer does not mean owner No. But maintainer means person who knows the code very well. > Then, also, in the same email you say "I have no time" and "you should > consult with me before". Those are contradictory. This is not contradictory. I

Re: [FFmpeg-devel] [PATCH 00/26] Major library version bump

2023-01-20 Thread Leo Izen
On 1/18/23 14:28, Anton Khirnov wrote: Quoting James Almer (2023-01-16 14:38:14) It's been a while since the last bump, so it's time to do some cleaning and remove deprecated APIs. This will also give us an "Open ABI season" in which we can do breaking changes (like changing public struct

Re: [FFmpeg-devel] [PATCH 4/5] lavfi/graphparser: reimplement avfilter_graph_parse* using new API

2023-01-20 Thread Jean-Baptiste Kempf
On Fri, 20 Jan 2023, at 21:47, Nicolas George wrote: > have comments. I need some time, my time is very limited these days. > > By the way, I am baffled that you would write a 30k+ patch on code you > do not maintain and do not know well without consulting the maintainer > who knows it. First,

Re: [FFmpeg-devel] [PATCH 4/5] lavfi/graphparser: reimplement avfilter_graph_parse* using new API

2023-01-20 Thread Nicolas George
Anton Khirnov (12023-01-20): > --- > libavfilter/graphparser.c | 537 +- > 1 file changed, 126 insertions(+), 411 deletions(-) I notice you removed the "RFC" from the subject line, but I probably have comments. I need some time, my time is very limited these

[FFmpeg-devel] [PATCH 1/5] lavfi/avfilter: export process_options()

2023-01-20 Thread Anton Khirnov
Also, replace an AVFilterContext argument with a logging context+private class, as those are the only things needed in this function. Will be useful in future commits. --- libavfilter/avfilter.c | 20 ++-- libavfilter/internal.h | 13 + 2 files changed, 23

[FFmpeg-devel] [PATCH 5/5] fftools/ffmpeg: add special syntax for loading filter options from files

2023-01-20 Thread Anton Khirnov
Many filters accept user-provided data that is cumbersome to provide as text strings - e.g. binary files or very long text. For that reason such filters typically provide a option whose value is the path from which the filter loads the actual data. However, filters doing their own IO internally

[FFmpeg-devel] [PATCH 3/5] lavfi: add a new filtergraph parsing API

2023-01-20 Thread Anton Khirnov
Callers currently have two ways of adding filters to a graph - they can either - create, initialize, and link them manually - use one of the avfilter_graph_parse*() functions, which take a (typically end-user-written) string, split it into individual filter definitions+options, then create

[FFmpeg-devel] [PATCH 4/5] lavfi/graphparser: reimplement avfilter_graph_parse* using new API

2023-01-20 Thread Anton Khirnov
--- libavfilter/graphparser.c | 537 +- 1 file changed, 126 insertions(+), 411 deletions(-) diff --git a/libavfilter/graphparser.c b/libavfilter/graphparser.c index ac6171e0c4..5db8b95a0c 100644 --- a/libavfilter/graphparser.c +++ b/libavfilter/graphparser.c

[FFmpeg-devel] [PATCH 2/5] lavfi/avfilter: track whether a filter has been initialized

2023-01-20 Thread Anton Khirnov
Refuse to link uninitialized filters or initialize a filter twice. --- libavfilter/avfilter.c | 12 libavfilter/internal.h | 4 2 files changed, 16 insertions(+) diff --git a/libavfilter/avfilter.c b/libavfilter/avfilter.c index 86b275dc4f..619b96f5ac 100644 ---

[FFmpeg-devel] FFmpeg Consultant Request

2023-01-20 Thread Eric Bartos
Hello, I am trying to solve a problem regarding embedded captions. I need the ability to take a mp4 with muxed 608/708 captions and output a mp4 with only muxed 708. If this is possible and something any developers are interested in helping me solve please reach out and we can have a chat. I have

[FFmpeg-devel] What's the last version of ffmpeg known to work on Windows 9x/ME?

2023-01-20 Thread Carlo Bramini
Hello, what's the last version of ffmpeg known to work on the ancient Windows 9x/ME? I looked to the history but I was not able to find this information. Thank you very much for your time. Sincerely. ___ ffmpeg-devel mailing list

[FFmpeg-devel] sws/swscale_unscaled.c: Faster yuv422p10 -> yuv422p conversion

2023-01-20 Thread Tomas Härdin
I have in mind a more general solution that handles 9, 12, 14 and 16- bit too, and 444p and maybe 420p /Tomas From 99cc73053cc9a544ae923e5c8e3f4686f3c05454 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Tomas=20H=C3=A4rdin?= Date: Wed, 18 Jan 2023 17:28:53 +0100 Subject: [PATCH]

Re: [FFmpeg-devel] avformat/mxfenc: SMPTE RDD 48:2018 Amd 1:2022 (FFV1 in MXF) support

2023-01-20 Thread Tomas Härdin
ons 2023-01-18 klockan 15:15 +0100 skrev Jerome Martinez: > On 18/01/2023 14:40, Tomas Härdin wrote: > > Creating a new subthread because I just noticed something > > I am a bit lost there because the line of code below is not part of > this > FFV1 patch. > Additionally, none on my patches (FFV1

Re: [FFmpeg-devel] [PATCH 00/26] Major library version bump

2023-01-20 Thread Tomas Härdin
ons 2023-01-18 klockan 18:23 -0300 skrev James Almer: > On 1/18/2023 4:28 PM, Anton Khirnov wrote: > > Quoting James Almer (2023-01-16 14:38:14) > > > It's been a while since the last bump, so it's time to do some > > > cleaning and > > > remove deprecated APIs. This will also give us an "Open ABI