Re: [FFmpeg-devel] [PATCH] fftools/ffplay: Fixed typo in frame_queue_destory

2023-07-04 Thread Steven Liu
QiTong Li 于2023年7月5日周三 11:36写道: > > Not sure if the function naming frame_queue_destory is intended because > "destory" is not really a word. Changing it to "destroy" makes more sense. > > Signed-off-by: QiTong Li > --- > fftools/ffplay.c | 8 > 1 file changed, 4 insertions(+), 4

[FFmpeg-devel] [PATCH] fftools/ffplay: Fixed typo in frame_queue_destory

2023-07-04 Thread QiTong Li
Not sure if the function naming frame_queue_destory is intended because "destory" is not really a word. Changing it to "destroy" makes more sense. Signed-off-by: QiTong Li --- fftools/ffplay.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/fftools/ffplay.c

Re: [FFmpeg-devel] [PATCH 1/2] avformat/hlsenc: fall back to av_get_random_seed() when generating AES128 key

2023-07-04 Thread Michael Niedermayer
On Tue, Jul 04, 2023 at 07:54:06AM +0200, Anton Khirnov wrote: > Quoting Michael Niedermayer (2023-07-04 01:50:57) > > On Mon, Jul 03, 2023 at 11:09:54PM +0200, Anton Khirnov wrote: > > > Quoting Marton Balint (2023-07-03 22:54:41) > > > > On Mon, 3 Jul 2023, Anton Khirnov wrote: > > > > My patch

Re: [FFmpeg-devel] [PATCH v2 1/2] avutil/random_seed: add av_random()

2023-07-04 Thread Michael Niedermayer
On Tue, Jul 04, 2023 at 06:35:06PM -0300, James Almer wrote: > On 7/4/2023 5:54 PM, Hendrik Leppkes wrote: > > On Tue, Jul 4, 2023 at 10:41 PM James Almer wrote: > > > > > > Uses the existing code for av_get_random_seed() to return a buffer with > > > cryptographically secure random data, or an

[FFmpeg-devel] [PATCH v3 3/3] avutil/random_seed: add support for gcrypt and OpenSSL as source of randomness

2023-07-04 Thread James Almer
Signed-off-by: James Almer --- configure | 2 +- libavutil/random_seed.c | 16 2 files changed, 17 insertions(+), 1 deletion(-) diff --git a/configure b/configure index 107d533b3e..d6e78297fe 100755 --- a/configure +++ b/configure @@ -3892,7 +3892,7 @@

[FFmpeg-devel] [PATCH v3 2/3] avutil/random_seed: add av_random_bytes()

2023-07-04 Thread James Almer
Uses the existing code for av_get_random_seed() to return a buffer with cryptographically secure random data, or an error if none could be generated. Signed-off-by: James Almer --- libavutil/random_seed.c | 33 ++--- libavutil/random_seed.h | 12 2 files

[FFmpeg-devel] [PATCH v3 1/3] avutil/random_seed: use fread() in read_random()

2023-07-04 Thread James Almer
This ensures the requested amount of bytes is read. Also remove /dev/random as it's no longer necessary. Signed-off-by: James Almer --- libavutil/random_seed.c | 23 --- 1 file changed, 12 insertions(+), 11 deletions(-) diff --git a/libavutil/random_seed.c

[FFmpeg-devel] [PATCH 6/6] avradio/sdrdemux: slightly different normalization of FM scores

2023-07-04 Thread Michael Niedermayer
This way teh scores now resemble station vs noise floor while before they where "whatever" This results in somewhat cleaner results from probing as well Signed-off-by: Michael Niedermayer --- libavradio/sdrdemux.c | 78 --- 1 file changed, 43

[FFmpeg-devel] [PATCH 5/6] avradio/sdrdemux: When searching for stations move in smaller steps

2023-07-04 Thread Michael Niedermayer
Moving too quick can lead to missed stations --- libavradio/sdrdemux.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavradio/sdrdemux.c b/libavradio/sdrdemux.c index 92b1e2b170..598dab8f18 100644 --- a/libavradio/sdrdemux.c +++ b/libavradio/sdrdemux.c @@ -1216,7 +1216,7

[FFmpeg-devel] [PATCH 4/6] avradio/sdrdemux: adjust frequency precission in probing depending on modulation

2023-07-04 Thread Michael Niedermayer
for AM we can find the frequency very precissely, for FM currently not so much Signed-off-by: Michael Niedermayer --- libavradio/sdrdemux.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/libavradio/sdrdemux.c b/libavradio/sdrdemux.c index 90f6805c3b..92b1e2b170 100644 ---

[FFmpeg-devel] [PATCH 3/6] avradio/sdrdemux: Skip probing in the area outside the bandwidth

2023-07-04 Thread Michael Niedermayer
--- libavradio/sdrdemux.c | 8 1 file changed, 8 insertions(+) diff --git a/libavradio/sdrdemux.c b/libavradio/sdrdemux.c index 39e2e54ee7..90f6805c3b 100644 --- a/libavradio/sdrdemux.c +++ b/libavradio/sdrdemux.c @@ -394,6 +394,7 @@ static int probe_am(SDRContext *sdr) int i;

[FFmpeg-devel] [PATCH 2/6] avradio: Fill in missing bandwidth values at 80% of frequency

2023-07-04 Thread Michael Niedermayer
The previous of 100% was a unrealistic default Signed-off-by: Michael Niedermayer --- libavradio/sdrdemux.c | 2 ++ libavradio/sdrinradio.c | 2 +- 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/libavradio/sdrdemux.c b/libavradio/sdrdemux.c index cb5e7afb2f..39e2e54ee7 100644

[FFmpeg-devel] [PATCH 1/6] avradio/sdrdemux: end on EOF dont wraparound

2023-07-04 Thread Michael Niedermayer
This is more usefull for testing Signed-off-by: Michael Niedermayer --- libavradio/sdrdemux.c | 8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/libavradio/sdrdemux.c b/libavradio/sdrdemux.c index d24e09ede2..cb5e7afb2f 100644 --- a/libavradio/sdrdemux.c +++

Re: [FFmpeg-devel] [PATCH v2 1/2] avutil/random_seed: add av_random()

2023-07-04 Thread Marton Balint
On Tue, 4 Jul 2023, James Almer wrote: Uses the existing code for av_get_random_seed() to return a buffer with cryptographically secure random data, or an error if none could be generated. Signed-off-by: James Almer --- libavutil/random_seed.c | 54 -

Re: [FFmpeg-devel] [PATCH v2 1/2] avutil/random_seed: add av_random()

2023-07-04 Thread James Almer
On 7/4/2023 5:54 PM, Hendrik Leppkes wrote: On Tue, Jul 4, 2023 at 10:41 PM James Almer wrote: Uses the existing code for av_get_random_seed() to return a buffer with cryptographically secure random data, or an error if none could be generated. Signed-off-by: James Almer ---

Re: [FFmpeg-devel] [PATCH v2 1/2] avutil/random_seed: add av_random()

2023-07-04 Thread Hendrik Leppkes
On Tue, Jul 4, 2023 at 10:41 PM James Almer wrote: > > Uses the existing code for av_get_random_seed() to return a buffer with > cryptographically secure random data, or an error if none could be generated. > > Signed-off-by: James Almer > --- > libavutil/random_seed.c | 54

Re: [FFmpeg-devel] [PATCH v2 1/2] avutil/random_seed: add av_random()

2023-07-04 Thread James Almer
On 7/4/2023 5:41 PM, James Almer wrote: Uses the existing code for av_get_random_seed() to return a buffer with cryptographically secure random data, or an error if none could be generated. Signed-off-by: James Almer --- libavutil/random_seed.c | 54 -

[FFmpeg-devel] [PATCH v2 2/2] avutil/random_seed: add support for gcrypt and OpenSSL as source of randomness

2023-07-04 Thread James Almer
Signed-off-by: James Almer --- configure | 2 +- libavutil/random_seed.c | 14 ++ 2 files changed, 15 insertions(+), 1 deletion(-) diff --git a/configure b/configure index 107d533b3e..d6e78297fe 100755 --- a/configure +++ b/configure @@ -3892,7 +3892,7 @@

[FFmpeg-devel] [PATCH v2 1/2] avutil/random_seed: add av_random()

2023-07-04 Thread James Almer
Uses the existing code for av_get_random_seed() to return a buffer with cryptographically secure random data, or an error if none could be generated. Signed-off-by: James Almer --- libavutil/random_seed.c | 54 - libavutil/random_seed.h | 12 + 2

Re: [FFmpeg-devel] [PATCH 1/2] avutil/random_seed: add av_random()

2023-07-04 Thread Anton Khirnov
Quoting James Almer (2023-07-04 22:18:40) > On 7/4/2023 5:14 PM, Anton Khirnov wrote: > > Quoting James Almer (2023-07-04 22:08:40) > >> On 7/4/2023 4:59 PM, Anton Khirnov wrote: > > Not if any of the functions above were called but failed to fill the > buffer. > > I

Re: [FFmpeg-devel] [PATCH 1/2] avutil/random_seed: add av_random()

2023-07-04 Thread James Almer
On 7/4/2023 5:14 PM, Anton Khirnov wrote: Quoting James Almer (2023-07-04 22:08:40) On 7/4/2023 4:59 PM, Anton Khirnov wrote: Not if any of the functions above were called but failed to fill the buffer. I could add return AVERROR(ENOSYS) to the HAVE_UNISTD_H block, and return

Re: [FFmpeg-devel] [PATCH 1/2] avutil/random_seed: add av_random()

2023-07-04 Thread Anton Khirnov
Quoting James Almer (2023-07-04 22:08:40) > > RAND_bytes from OpenSSL returns 0 or -1 on error, so nothing i can > propagate. That's AVERROR_EXTERNAL then. -- Anton Khirnov ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org

Re: [FFmpeg-devel] [PATCH 1/2] avutil/random_seed: add av_random()

2023-07-04 Thread Anton Khirnov
Quoting James Almer (2023-07-04 22:08:40) > On 7/4/2023 4:59 PM, Anton Khirnov wrote: > >> > >> Not if any of the functions above were called but failed to fill the > >> buffer. > >> > >> I could add return AVERROR(ENOSYS) to the HAVE_UNISTD_H block, and > >> return AVERROR_INVALIDDATA outside. >

Re: [FFmpeg-devel] [PATCH 1/2] avutil/random_seed: add av_random()

2023-07-04 Thread James Almer
On 7/4/2023 4:59 PM, Anton Khirnov wrote: Not if any of the functions above were called but failed to fill the buffer. I could add return AVERROR(ENOSYS) to the HAVE_UNISTD_H block, and return AVERROR_INVALIDDATA outside. AVERROR_INVALIDDATA is defined as 'Invalid data found when processing

Re: [FFmpeg-devel] [PATCH 2/2] avutil/random_seed: ass support for gcrypt and OpenSSL as source of randomness

2023-07-04 Thread James Almer
On 7/4/2023 5:02 PM, Marton Balint wrote: On Tue, 4 Jul 2023, James Almer wrote: Signed-off-by: James Almer --- In the commit message s/ass/add/ I put these after /dev/random/ to not change the current behavior of av_get_random_seed(), but if either of these are prefered i can move

Re: [FFmpeg-devel] [PATCH 2/2] avutil/random_seed: ass support for gcrypt and OpenSSL as source of randomness

2023-07-04 Thread Marton Balint
On Tue, 4 Jul 2023, James Almer wrote: Signed-off-by: James Almer --- In the commit message s/ass/add/ I put these after /dev/random/ to not change the current behavior of av_get_random_seed(), but if either of these are prefered i can move them up. configure | 2 +-

Re: [FFmpeg-devel] [PATCH 1/2] avutil/random_seed: add av_random()

2023-07-04 Thread Anton Khirnov
> > Not if any of the functions above were called but failed to fill the buffer. > > I could add return AVERROR(ENOSYS) to the HAVE_UNISTD_H block, and > return AVERROR_INVALIDDATA outside. AVERROR_INVALIDDATA is defined as 'Invalid data found when processing input'. This function does not

Re: [FFmpeg-devel] [PATCH 1/2] avutil/random_seed: add av_random()

2023-07-04 Thread James Almer
On 7/4/2023 4:34 PM, Marton Balint wrote: On Tue, 4 Jul 2023, James Almer wrote: Uses the existing code for av_get_random_seed() to return a buffer with cryptographically secure random data, or an error if none could be generated. Signed-off-by: James Almer --- TODO: APIChanges entry and

Re: [FFmpeg-devel] [PATCH 1/2] avutil/random_seed: add av_random()

2023-07-04 Thread Marton Balint
On Tue, 4 Jul 2023, James Almer wrote: Uses the existing code for av_get_random_seed() to return a buffer with cryptographically secure random data, or an error if none could be generated. Signed-off-by: James Almer --- TODO: APIChanges entry and minor version bump. Also, if a new

Re: [FFmpeg-devel] [PATCH 1/2] avformat/hlsenc: fall back to av_get_random_seed() when generating AES128 key

2023-07-04 Thread Marton Balint
On Tue, 4 Jul 2023, James Almer wrote: On 7/3/2023 6:52 PM, Marton Balint wrote: On Mon, 3 Jul 2023, Anton Khirnov wrote: Quoting Marton Balint (2023-07-03 22:54:41) On Mon, 3 Jul 2023, Anton Khirnov wrote: My patch use av_get_random_seed() which uses what the underlying OS

Re: [FFmpeg-devel] [PATCH 1/2] avformat/hlsenc: fall back to av_get_random_seed() when generating AES128 key

2023-07-04 Thread James Almer
On 7/3/2023 6:52 PM, Marton Balint wrote: On Mon, 3 Jul 2023, Anton Khirnov wrote: Quoting Marton Balint (2023-07-03 22:54:41) On Mon, 3 Jul 2023, Anton Khirnov wrote: My patch use av_get_random_seed() which uses what the underlying OS provides, BCrypt for Windows, /dev/urandom for Linux,

[FFmpeg-devel] [PATCH 2/2] avutil/random_seed: ass support for gcrypt and OpenSSL as source of randomness

2023-07-04 Thread James Almer
Signed-off-by: James Almer --- I put these after /dev/random/ to not change the current behavior of av_get_random_seed(), but if either of these are prefered i can move them up. configure | 2 +- libavutil/random_seed.c | 13 + 2 files changed, 14 insertions(+), 1

[FFmpeg-devel] [PATCH 1/2] avutil/random_seed: add av_random()

2023-07-04 Thread James Almer
Uses the existing code for av_get_random_seed() to return a buffer with cryptographically secure random data, or an error if none could be generated. Signed-off-by: James Almer --- TODO: APIChanges entry and minor version bump. Also, if a new random.h header is prefered, i can move the

[FFmpeg-devel] [PATCH 2/2] lavf/dv: stop setting a random video bitrate

2023-07-04 Thread Anton Khirnov
A real value is determined from the bytestream. --- libavformat/dv.c | 1 - 1 file changed, 1 deletion(-) diff --git a/libavformat/dv.c b/libavformat/dv.c index d01ecedc62..6df93fe416 100644 --- a/libavformat/dv.c +++ b/libavformat/dv.c @@ -358,7 +358,6 @@ static int

[FFmpeg-devel] [PATCH 1/2] lavc/dvdec: export bitrate

2023-07-04 Thread Anton Khirnov
Changes the result of fate-mxf-probe-dv25, where the bitrate is now exported. Also changes the result of fate-bsf-dv-error-marker, where the exported bitrate is now different. Note that the codec layer bitrate does not match the container bitrate, because container timing is 25fps, while the DV

Re: [FFmpeg-devel] [PATCH 1/2] avformat/hlsenc: fall back to av_get_random_seed() when generating AES128 key

2023-07-04 Thread Anton Khirnov
Quoting James Almer (2023-07-04 16:37:03) > On 7/4/2023 2:54 AM, Anton Khirnov wrote: > > Quoting Michael Niedermayer (2023-07-04 01:50:57) > >> On Mon, Jul 03, 2023 at 11:09:54PM +0200, Anton Khirnov wrote: > >>> Quoting Marton Balint (2023-07-03 22:54:41) > On Mon, 3 Jul 2023, Anton Khirnov

Re: [FFmpeg-devel] [PATCH] doc/developer: Make tests a requirement

2023-07-04 Thread Rémi Denis-Courmont
Le tiistaina 4. heinäkuuta 2023, 2.00.04 EEST Michael Niedermayer a écrit : > Suggested-by: Anton > > Signed-off-by: Michael Niedermayer > --- > doc/developer.texi | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/doc/developer.texi b/doc/developer.texi > index

Re: [FFmpeg-devel] [PATCH 1/2] avformat/hlsenc: fall back to av_get_random_seed() when generating AES128 key

2023-07-04 Thread James Almer
On 7/4/2023 2:54 AM, Anton Khirnov wrote: Quoting Michael Niedermayer (2023-07-04 01:50:57) On Mon, Jul 03, 2023 at 11:09:54PM +0200, Anton Khirnov wrote: Quoting Marton Balint (2023-07-03 22:54:41) On Mon, 3 Jul 2023, Anton Khirnov wrote: My patch use av_get_random_seed() which uses what the

[FFmpeg-devel] [PATCH v4 7/7] avfilter/vf_bwdif: Add neon for filter_line3

2023-07-04 Thread John Cox
Signed-off-by: John Cox --- libavfilter/aarch64/vf_bwdif_init_aarch64.c | 28 ++ libavfilter/aarch64/vf_bwdif_neon.S | 272 2 files changed, 300 insertions(+) diff --git a/libavfilter/aarch64/vf_bwdif_init_aarch64.c b/libavfilter/aarch64/vf_bwdif_init_aarch64.c

[FFmpeg-devel] [PATCH v4 6/7] avfilter/vf_bwdif: Add a filter_line3 method for optimisation

2023-07-04 Thread John Cox
Add an optional filter_line3 to the available optimisations. filter_line3 is equivalent to filter_line, memcpy, filter_line filter_line shares quite a number of loads and some calculations in common with its next iteration and testing shows that using aarch64 neon filter_line3s performance is

[FFmpeg-devel] [PATCH v4 5/7] avfilter/vf_bwdif: Add neon for filter_line

2023-07-04 Thread John Cox
Exports C filter_line needed for tail fixup of neon code Adds neon for filter_line Signed-off-by: John Cox --- libavfilter/aarch64/vf_bwdif_init_aarch64.c | 21 ++ libavfilter/aarch64/vf_bwdif_neon.S | 203 libavfilter/bwdif.h | 5 +

[FFmpeg-devel] [PATCH v4 4/7] avfilter/vf_bwdif: Add neon for filter_edge

2023-07-04 Thread John Cox
Adds clip and spatial macros for aarch64 neon Exports C filter_edge needed for tail fixup of neon code Adds neon for filter_edge Signed-off-by: John Cox --- libavfilter/aarch64/vf_bwdif_init_aarch64.c | 20 +++ libavfilter/aarch64/vf_bwdif_neon.S | 177

[FFmpeg-devel] [PATCH v4 3/7] tests/checkasm: Add test for vf_bwdif filter_edge

2023-07-04 Thread John Cox
Signed-off-by: John Cox --- tests/checkasm/vf_bwdif.c | 54 +++ 1 file changed, 54 insertions(+) diff --git a/tests/checkasm/vf_bwdif.c b/tests/checkasm/vf_bwdif.c index 034bbabb4c..5fdba09fdc 100644 --- a/tests/checkasm/vf_bwdif.c +++

[FFmpeg-devel] [PATCH v4 2/7] avfilter/vf_bwdif: Add neon for filter_intra

2023-07-04 Thread John Cox
Adds an outline for aarch neon functions Adds common macros and consts for aarch64 neon Exports C filter_intra needed for tail fixup of neon code Adds neon for filter_intra Signed-off-by: John Cox --- libavfilter/aarch64/Makefile| 2 +

[FFmpeg-devel] [PATCH v4 1/7] tests/checkasm: Add test for vf_bwdif filter_intra

2023-07-04 Thread John Cox
Signed-off-by: John Cox --- tests/checkasm/vf_bwdif.c | 37 + 1 file changed, 37 insertions(+) diff --git a/tests/checkasm/vf_bwdif.c b/tests/checkasm/vf_bwdif.c index 46224bb575..034bbabb4c 100644 --- a/tests/checkasm/vf_bwdif.c +++

[FFmpeg-devel] [PATCH v4 0/7] avfilter/vf_bwdif: Add aarch64 neon functions

2023-07-04 Thread John Cox
Also adds a filter_line3 method which on aarch64 neon yields approx 30% speedup over 2xfilter_line and a memcpy Differences from v3: Remove a few lines of neon in filter_line that should have been removed when copying from line3 Sorry about the two patch sets in quick succession, but I think

Re: [FFmpeg-devel] [PATCH] doc/developer: Make tests a requirement

2023-07-04 Thread Nicolas George
Paul B Mahol (12023-07-04): > Tyrants and dictators. I would not have said it that way, but you are not wrong. While in theory it would be nice to have tests for all new code, the entitlement of the members of this project who contribute little code or none at all who demand ever more and more

Re: [FFmpeg-devel] [PATCH v2 05/15] tests/checkasm: Add test for vf_bwdif filter_intra

2023-07-04 Thread Kieran Kunhya
On Tue, 4 Jul 2023, 11:18 John Cox, wrote: > On Mon, 3 Jul 2023 00:14:16 +0300 (EEST), you wrote: > > >[snip] > >It's a bit of a shame that this only tests things for 8 bit, not 10, but > I > >guess that's better than nothing. The way the current code is set up to > >template both variants of

Re: [FFmpeg-devel] [PATCH v2 05/15] tests/checkasm: Add test for vf_bwdif filter_intra

2023-07-04 Thread John Cox
On Mon, 3 Jul 2023 00:14:16 +0300 (EEST), you wrote: >[snip] >It's a bit of a shame that this only tests things for 8 bit, not 10, but I >guess that's better than nothing. The way the current code is set up to >template both variants of the tests isn't very neat either... Is there actually

Re: [FFmpeg-devel] [PATCH 1/2] avformat/hlsenc: fall back to av_get_random_seed() when generating AES128 key

2023-07-04 Thread Kieran Kunhya
On Tue, 4 Jul 2023 at 06:54, Anton Khirnov wrote: > Quoting Michael Niedermayer (2023-07-04 01:50:57) > > On Mon, Jul 03, 2023 at 11:09:54PM +0200, Anton Khirnov wrote: > > > Quoting Marton Balint (2023-07-03 22:54:41) > > > > On Mon, 3 Jul 2023, Anton Khirnov wrote: > > > > My patch use

Re: [FFmpeg-devel] [PATCH] doc/developer: Make tests a requirement

2023-07-04 Thread Jean-Baptiste Kempf
Hello, On Tue, 4 Jul 2023, at 01:00, Michael Niedermayer wrote: > Suggested-by: Anton > > Signed-off-by: Michael Niedermayer > --- > doc/developer.texi | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/doc/developer.texi b/doc/developer.texi > index 0c2f2cd7d1..67f7f78e86

Re: [FFmpeg-devel] [PATCH] doc/developer: Make tests a requirement

2023-07-04 Thread Tomas Härdin
tis 2023-07-04 klockan 03:38 +0200 skrev Paul B Mahol: > Tyrants and dictators. You can't just have rules and stuff, man (Send all non-test-writers to GNUlag) /Tomas ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org

[FFmpeg-devel] [PATCH] avutil/bfin: remove dead code

2023-07-04 Thread Zhao Zhili
From: Zhao Zhili The code is unused for a decade since bf6c84d7eb27b. Signed-off-by: Zhao Zhili --- libavutil/bfin/bswap.h | 45 -- libavutil/bfin/timer.h | 41 -- 2 files changed, 86 deletions(-) delete mode 100644