Re: [FFmpeg-devel] [PATCH 16/33] fftools/ffmpeg_mux_init: improve of_add_programs()

On Thu, Jul 13, 2023 at 12:55:36PM +0200, Anton Khirnov wrote: > Replace duplicated(!) and broken* custom string parsing with > av_dict_parse_string(). Return error codes instead of aborting. > > * e.g. it treats NULL returned from av_get_token() as "separator not > found", when in fact

Re: [FFmpeg-devel] [PATCH 25/33] fftools/ffmpeg_filter: stop disregarding user-specified pixel format

On Thu, Jul 13, 2023 at 12:55:45PM +0200, Anton Khirnov wrote: > When the user explicitly specifies a pixel format that is not supported > by the encoder, ffmpeg CLI will currently use some heuristics to pick > another supported format. This is wrong and the correct action here is > to fail. > >

Re: [FFmpeg-devel] [PATCH] libsvtav1: Add workaround for gop_size == 1

Hi, On Thu, Jul 13, 2023 at 5:13 PM Vignesh Venkat < vigneshv-at-google@ffmpeg.org> wrote: > On Wed, Jun 28, 2023 at 4:27 PM James Almer wrote: > > > > On 6/28/2023 8:25 PM, Ronald S. Bultje wrote: > > > Hi, > > > > > > On Wed, Jun 28, 2023 at 12:48 PM Vignesh Venkat < > > >

Re: [FFmpeg-devel] [PATCH] libsvtav1: Add workaround for gop_size == 1

On Wed, Jun 28, 2023 at 4:27 PM James Almer wrote: > > On 6/28/2023 8:25 PM, Ronald S. Bultje wrote: > > Hi, > > > > On Wed, Jun 28, 2023 at 12:48 PM Vignesh Venkat < > > vigneshv-at-google@ffmpeg.org> wrote: > > > >> i will update the upstream bug to clarify this part. but in the > >>

Re: [FFmpeg-devel] [PATCH] lavc: deprecate AV_CODEC_FLAG_DROPCHANGED

Quoting Gyan Doshi (2023-07-13 21:20:32) > > > On 2023-07-12 07:14 pm, Anton Khirnov wrote: > > Quoting Gyan Doshi (2023-07-12 15:31:57) > >> > >> On 2023-07-12 06:51 pm, James Almer wrote: > >>> On 7/12/2023 10:14 AM, Gyan Doshi wrote: > > On 2023-07-12 06:12 pm, James Almer wrote: >

[FFmpeg-devel] [PATCH] lavc/alacdsp: unroll RISC-V V loops

This increases the group multiplier as per T-Head C910 benchmarks: alac_append_extra_bits_mono_c: 803.0 alac_append_extra_bits_stereo_c: 1604.2 alac_decorrelate_stereo_c: 1077.5 LMUL=1 alac_append_extra_bits_mono_rvv_i32: 418.2 alac_append_extra_bits_stereo_rvv_i32: 693.2

[FFmpeg-devel] [PATCH] lavc/vorbisdsp: unroll RISC-V V inverse_coupling

This increases the group multiplier as per T-Head C910 benchmarks: inverse_coupling_c: 4597.0 inverse_coupling_rvv_i32: 1312.7 (m1) inverse_coupling_rvv_i32: 1116.7 (m2) inverse_coupling_rvv_i32: 732.2 (m4) inverse_coupling_rvv_i32: 898.0 (m8) --- libavcodec/riscv/vorbisdsp_rvv.S | 2 +- 1

Re: [FFmpeg-devel] [PATCH] avcodec: add RFBW video decoder

will apply. ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] [PATCH 01/14] avradio/rds: reset station timeout on successfull group decode

On Thu, Jul 13, 2023 at 01:36:53AM +0200, Michael Niedermayer wrote: > Signed-off-by: Michael Niedermayer > --- > libavradio/rds.c | 3 +++ > 1 file changed, 3 insertions(+) will apply [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB Dictatorship naturally

Re: [FFmpeg-devel] [PATCH] lavc/libvpxenc: prevent fifo from filling up

On Fri, Jul 7, 2023 at 2:31 PM David Lemler wrote: > > Prevent the fifo used in encoding VPx videos from filling up and > stopping encode when it reaches 21845 items, which happens when the > video has more than that number of frames. > > Incorporated suggestion from James Zern to prevent calling

Re: [FFmpeg-devel] [PATCH] lavc: deprecate AV_CODEC_FLAG_DROPCHANGED

On 2023-07-12 07:14 pm, Anton Khirnov wrote: Quoting Gyan Doshi (2023-07-12 15:31:57) On 2023-07-12 06:51 pm, James Almer wrote: On 7/12/2023 10:14 AM, Gyan Doshi wrote: On 2023-07-12 06:12 pm, James Almer wrote: On 7/9/2023 9:57 AM, Anton Khirnov wrote: This decoding flag makes

Re: [FFmpeg-devel] [PATCH 5/5] lavc/aarch64: new optimization for 8-bit hevc_epel_uni_w_hv

Hi, Martin, Thanks for your comments. I have now amended the unreasonable parts of ldp/stp that I have seen.  And I updated patch 3 and patch 5. (Although I have attached all 5 patches) In addition, I thought that q8-q15 was required to be saved according to the calling convention before, but

Re: [FFmpeg-devel] [PATCH 01/33] fftools/ffmpeg_mux_init: return errors from of_open() instead of aborting

Quoting zhilizhao(赵志立) (2023-07-13 14:01:48) > > > > On Jul 13, 2023, at 18:55, Anton Khirnov wrote: > > > > --- > > fftools/ffmpeg_mux_init.c | 16 > > 1 file changed, 8 insertions(+), 8 deletions(-) > > > > diff --git a/fftools/ffmpeg_mux_init.c b/fftools/ffmpeg_mux_init.c >

Re: [FFmpeg-devel] [PATCH 01/33] fftools/ffmpeg_mux_init: return errors from of_open() instead of aborting

> On Jul 13, 2023, at 18:55, Anton Khirnov wrote: > > --- > fftools/ffmpeg_mux_init.c | 16 > 1 file changed, 8 insertions(+), 8 deletions(-) > > diff --git a/fftools/ffmpeg_mux_init.c b/fftools/ffmpeg_mux_init.c > index 6ab541d7c5..8a3e7b98cf 100644 > ---

Re: [FFmpeg-devel] Build failure un Debian Testing

On 7/13/2023 7:06 AM, Nicolas George wrote: Hi. We currently have a build failure on Debian Testing (and certainly Unstable): CC libavformat/adtsenc.o src/libavcodec/x86/mathops.h: Assembler messages: ×19 src/libavcodec/x86/mathops.h:125: Error: operand type

[FFmpeg-devel] [PATCH 29/33] fftools/ffmpeg_enc: initialize audio/video encoders from frame parameters

This is possible now that enc_open() is always called with a non-NULL frame for audio/video. Previously the code would directly reach into the buffersink, which is a layering violation. --- fftools/ffmpeg_enc.c | 35 +-- 1 file changed, 21 insertions(+), 14

[FFmpeg-devel] [PATCH 28/33] fftools/ffmpeg_filter: only flush vsync code if encoding actually started

Otherwise this has no effect. Will be useful in following commits. --- fftools/ffmpeg_filter.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/fftools/ffmpeg_filter.c b/fftools/ffmpeg_filter.c index f8e64ce6cc..4955fe38dd 100644 --- a/fftools/ffmpeg_filter.c +++

[FFmpeg-devel] [PATCH 31/33] fftools/ffmpeg: add more structure to FrameData

It now contains data from multiple sources, so group those items that always come from the decoder. Also, initialize them to invalid values, so that frames that did not originate from a decoder can be distinguished. --- fftools/ffmpeg.c | 8 +++- fftools/ffmpeg.h | 10 +++---

[FFmpeg-devel] [PATCH 25/33] fftools/ffmpeg_filter: stop disregarding user-specified pixel format

When the user explicitly specifies a pixel format that is not supported by the encoder, ffmpeg CLI will currently use some heuristics to pick another supported format. This is wrong and the correct action here is to fail. Surprisingly, a number of FATE tests are affected by this and actually use

[FFmpeg-devel] [PATCH 24/33] fftools/ffmpeg_mux_init: handle pixel format endianness

When -pix_fmt designates a BE/LE pixel format, it gets translated into the native one by av_get_pix_fmt(). This may not always be the best choice, as the encoder might only support one endianness. In such a case, explicitly choose the endianness supported by the encoder. While this is currently

[FFmpeg-devel] [PATCH 21/33] fftools/ffmpeg_mux: return errors from of_streamcopy() instead of aborting

--- fftools/ffmpeg.h | 2 +- fftools/ffmpeg_mux.c | 20 2 files changed, 13 insertions(+), 9 deletions(-) diff --git a/fftools/ffmpeg.h b/fftools/ffmpeg.h index 30020cd0f8..fdee20d6b2 100644 --- a/fftools/ffmpeg.h +++ b/fftools/ffmpeg.h @@ -826,7 +826,7 @@ void

[FFmpeg-devel] [PATCH 30/33] fftools/ffmpeg_filter: make OutputFilter.filter private

It should not be accessed from outside of filtering code. --- fftools/ffmpeg.h| 1 - fftools/ffmpeg_filter.c | 18 ++ 2 files changed, 10 insertions(+), 9 deletions(-) diff --git a/fftools/ffmpeg.h b/fftools/ffmpeg.h index bcd9cc584e..bd6b0ed6d1 100644 ---

[FFmpeg-devel] [PATCH 19/33] fftools/ffmpeg: return an error instead of aborting

--- fftools/ffmpeg.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fftools/ffmpeg.c b/fftools/ffmpeg.c index 96638242f3..68924d21e0 100644 --- a/fftools/ffmpeg.c +++ b/fftools/ffmpeg.c @@ -1094,7 +1094,7 @@ static int process_input(int file_index) av_log(ifile,

[FFmpeg-devel] [PATCH 17/33] fftools/ffmpeg_mux_init: return error codes from metadata processing instead of aborting

--- fftools/ffmpeg_mux_init.c | 63 --- 1 file changed, 39 insertions(+), 24 deletions(-) diff --git a/fftools/ffmpeg_mux_init.c b/fftools/ffmpeg_mux_init.c index b0befb8924..2bd152039d 100644 --- a/fftools/ffmpeg_mux_init.c +++ b/fftools/ffmpeg_mux_init.c @@

[FFmpeg-devel] [PATCH 15/33] fftools/ffmpeg_mux_init: return error codes from validate_enc_avopt() instead of aborting

--- fftools/ffmpeg_mux_init.c | 10 +++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/fftools/ffmpeg_mux_init.c b/fftools/ffmpeg_mux_init.c index 7a8c935795..3a327048bb 100644 --- a/fftools/ffmpeg_mux_init.c +++ b/fftools/ffmpeg_mux_init.c @@ -2342,7 +2342,7 @@ static int

[FFmpeg-devel] [PATCH 20/33] fftools/ffmpeg: handle error codes from process_input_packet()

None are returned for now, but that will change in future commits. --- fftools/ffmpeg.c | 9 ++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/fftools/ffmpeg.c b/fftools/ffmpeg.c index 68924d21e0..dd7cfcf632 100644 --- a/fftools/ffmpeg.c +++ b/fftools/ffmpeg.c @@ -1103,6

[FFmpeg-devel] [PATCH 07/33] fftools/ffmpeg_demux: return errors from ist_add() instead of aborting

--- fftools/ffmpeg_demux.c | 70 ++ 1 file changed, 43 insertions(+), 27 deletions(-) diff --git a/fftools/ffmpeg_demux.c b/fftools/ffmpeg_demux.c index bc915178ec..9e7f13a2b4 100644 --- a/fftools/ffmpeg_demux.c +++ b/fftools/ffmpeg_demux.c @@ -964,8

[FFmpeg-devel] [PATCH 33/33] doc/ffmpeg: fix -enc_time_base documentation

Stop claiming the argument is always a floating point number, which * confuses floating point and decimal numbers * is not always true even accounting for the above point --- doc/ffmpeg.texi | 7 +++ 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/doc/ffmpeg.texi

[FFmpeg-devel] [PATCH 10/33] fftools/ffmpeg_mux_init: return error codes from map_*() instead of aborting

--- fftools/ffmpeg_mux_init.c | 92 +++ 1 file changed, 55 insertions(+), 37 deletions(-) diff --git a/fftools/ffmpeg_mux_init.c b/fftools/ffmpeg_mux_init.c index 47b6f826b6..8e640610cd 100644 --- a/fftools/ffmpeg_mux_init.c +++ b/fftools/ffmpeg_mux_init.c @@

[FFmpeg-devel] [PATCH 16/33] fftools/ffmpeg_mux_init: improve of_add_programs()

Replace duplicated(!) and broken* custom string parsing with av_dict_parse_string(). Return error codes instead of aborting. * e.g. it treats NULL returned from av_get_token() as "separator not found", when in fact av_get_token() only returns NULL on memory allocation failure ---

[FFmpeg-devel] [PATCH 32/33] fftools/ffmpeg: rework -enc_time_base handling

Read the timebase from FrameData rather than the input stream. This should fix #10393 and generally be more reliable. Replace the use of '-1' to indicate demuxing timebase with the string 'demux'. Also allow to request filter timebase with '-enc_time_base filter'. --- doc/ffmpeg.texi |

[FFmpeg-devel] [PATCH 13/33] fftools/ffmpeg_mux_init: return error codes from copy_meta() instead of aborting

--- fftools/ffmpeg_mux_init.c | 12 1 file changed, 8 insertions(+), 4 deletions(-) diff --git a/fftools/ffmpeg_mux_init.c b/fftools/ffmpeg_mux_init.c index 8ad799f951..f85357d8e4 100644 --- a/fftools/ffmpeg_mux_init.c +++ b/fftools/ffmpeg_mux_init.c @@ -2089,7 +2089,7 @@ static int

[FFmpeg-devel] [PATCH 14/33] fftools/ffmpeg_mux_init: return error codes from parse_forced_key_frames() instead of aborting

--- fftools/ffmpeg_mux_init.c | 14 +- 1 file changed, 9 insertions(+), 5 deletions(-) diff --git a/fftools/ffmpeg_mux_init.c b/fftools/ffmpeg_mux_init.c index f85357d8e4..7a8c935795 100644 --- a/fftools/ffmpeg_mux_init.c +++ b/fftools/ffmpeg_mux_init.c @@ -2245,8 +2245,8 @@ static

[FFmpeg-devel] [PATCH 26/33] fftools/ffmpeg_filter: stop accessing encoder from pixfmt selection

ffmpeg CLI pixel format selection for filtering currently special-cases MJPEG encoding, where it will restrict the supported list of pixel formats depending on the value of the -strict option. In order to get that value it will apply it from the options dict into the encoder context, which is a

[FFmpeg-devel] [PATCH 22/33] fftools/ffmpeg_enc: return errors from enc_subtitle() instead of aborting

--- fftools/ffmpeg.h | 2 +- fftools/ffmpeg_dec.c | 4 +++- fftools/ffmpeg_enc.c | 16 3 files changed, 12 insertions(+), 10 deletions(-) diff --git a/fftools/ffmpeg.h b/fftools/ffmpeg.h index fdee20d6b2..bcd9cc584e 100644 --- a/fftools/ffmpeg.h +++ b/fftools/ffmpeg.h @@

[FFmpeg-devel] [PATCH 02/33] fftools/ffmpeg_demux: return errors from ifile_open() instead of aborting

--- fftools/ffmpeg_demux.c | 18 +- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/fftools/ffmpeg_demux.c b/fftools/ffmpeg_demux.c index 5d3e043793..a6df2a1904 100644 --- a/fftools/ffmpeg_demux.c +++ b/fftools/ffmpeg_demux.c @@ -1349,7 +1349,7 @@ int

[FFmpeg-devel] [PATCH 08/33] fftools/ffmpeg_mux_init: return errors from create_streams() instead of aborting

--- fftools/ffmpeg_mux_init.c | 10 +++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/fftools/ffmpeg_mux_init.c b/fftools/ffmpeg_mux_init.c index 4d40ceda05..dbc58abea8 100644 --- a/fftools/ffmpeg_mux_init.c +++ b/fftools/ffmpeg_mux_init.c @@ -1558,7 +1558,7 @@ static void

[FFmpeg-devel] [PATCH 12/33] fftools/ffmpeg_mux_init: return error codes from ost_add() instead of aborting

--- fftools/ffmpeg_mux_init.c | 88 +++ 1 file changed, 53 insertions(+), 35 deletions(-) diff --git a/fftools/ffmpeg_mux_init.c b/fftools/ffmpeg_mux_init.c index bd4c0a9f97..8ad799f951 100644 --- a/fftools/ffmpeg_mux_init.c +++ b/fftools/ffmpeg_mux_init.c @@

[FFmpeg-devel] [PATCH 18/33] fftools/ffmpeg_mux_init: replace all remaining aborts with returning error codes

Mainly concerns new_stream_*() and their callees. --- fftools/ffmpeg_mux_init.c | 126 -- 1 file changed, 79 insertions(+), 47 deletions(-) diff --git a/fftools/ffmpeg_mux_init.c b/fftools/ffmpeg_mux_init.c index 2bd152039d..4b7961b833 100644 ---

[FFmpeg-devel] [PATCH 11/33] fftools/ffmpeg_mux_init: move allocation out of prologue

ost_add() has a very large variable declaration prologue, performing "active" actions that can fail in there is confusing. --- fftools/ffmpeg_mux_init.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/fftools/ffmpeg_mux_init.c b/fftools/ffmpeg_mux_init.c index

[FFmpeg-devel] [PATCH 27/33] fftools/ffmpeg: rework initializing encoders with no frames

When no frames were passed from a filtergraph to an encoder, but the filtergraph is configured (i.e. has output parameters), encoder flush code will use those parameters to initialize the encoder in a last-ditch effort to produce some useful output. Rework this process so that it is triggered by

[FFmpeg-devel] [PATCH 09/33] fftools/ffmpeg_mux_init: improve error handling in of_add_attachments()

* return error codes instead of aborting * avoid leaking the AVIOContext on failure * check the return code of avio_read() --- fftools/ffmpeg_mux_init.c | 44 +++ 1 file changed, 35 insertions(+), 9 deletions(-) diff --git a/fftools/ffmpeg_mux_init.c

[FFmpeg-devel] [PATCH 23/33] fftools/ffmpeg_mux_init: drop an obsolete assignment

This line was added in c30a4489b44 along with AVStream.sample_aspect_ratio. However, configuring SAR for video encoding is now done after this code (specifically in enc_open(), which is called when the first video frame to be encoded is obtained), so this line cannot have any meaningful effect.

[FFmpeg-devel] [PATCH 06/33] fftools/ffmpeg: return errors from assert_file_overwrite() instead of aborting

--- fftools/ffmpeg.h | 2 +- fftools/ffmpeg_demux.c| 4 +++- fftools/ffmpeg_mux_init.c | 11 --- fftools/ffmpeg_opt.c | 12 +++- 4 files changed, 19 insertions(+), 10 deletions(-) diff --git a/fftools/ffmpeg.h b/fftools/ffmpeg.h index 3201163a4f..30020cd0f8

[FFmpeg-devel] [PATCH 05/33] fftools/ffmpeg_demux: add logging for -dump_attachment

Makes it more clear what was written where. --- fftools/ffmpeg_demux.c | 4 1 file changed, 4 insertions(+) diff --git a/fftools/ffmpeg_demux.c b/fftools/ffmpeg_demux.c index 498830098d..ab99daf9f8 100644 --- a/fftools/ffmpeg_demux.c +++ b/fftools/ffmpeg_demux.c @@ -1288,6 +1288,10 @@

[FFmpeg-devel] [PATCH 01/33] fftools/ffmpeg_mux_init: return errors from of_open() instead of aborting

--- fftools/ffmpeg_mux_init.c | 16 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/fftools/ffmpeg_mux_init.c b/fftools/ffmpeg_mux_init.c index 6ab541d7c5..8a3e7b98cf 100644 --- a/fftools/ffmpeg_mux_init.c +++ b/fftools/ffmpeg_mux_init.c @@ -2380,7 +2380,7 @@ int

[FFmpeg-devel] [PATCH 04/33] fftools/ffmpeg_demux: forward errors from dump_attachment() instead of aborting

Also, check the return code of avio_close(). --- fftools/ffmpeg_demux.c | 19 --- 1 file changed, 12 insertions(+), 7 deletions(-) diff --git a/fftools/ffmpeg_demux.c b/fftools/ffmpeg_demux.c index 40bbfa0c0e..498830098d 100644 --- a/fftools/ffmpeg_demux.c +++

[FFmpeg-devel] [PATCH 03/33] fftools/ffmpeg_demux: drop a redundant avio_flush()

It is immediately followed by avio_close(), which is documented to flush the buffers. --- fftools/ffmpeg_demux.c | 1 - 1 file changed, 1 deletion(-) diff --git a/fftools/ffmpeg_demux.c b/fftools/ffmpeg_demux.c index a6df2a1904..40bbfa0c0e 100644 --- a/fftools/ffmpeg_demux.c +++

Re: [FFmpeg-devel] [PATCH] lavc: deprecate AV_CODEC_FLAG_DROPCHANGED

If nobody has further comments, I intend to push the patch tomorrow. -- Anton Khirnov ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email

[FFmpeg-devel] Build failure un Debian Testing

Hi. We currently have a build failure on Debian Testing (and certainly Unstable): CC libavformat/adtsenc.o src/libavcodec/x86/mathops.h: Assembler messages: ×19 src/libavcodec/x86/mathops.h:125: Error: operand type mismatch for `shr' make: ***