Re: [FFmpeg-devel] [PATCH v3] avcodec/cbs_vp8: Add support for VP8 codec bitstream READ methods

> -Original Message- > From: ffmpeg-devel On Behalf Of Dai, > Jianhui J > Sent: Tuesday, June 20, 2023 9:42 AM > To: FFmpeg development discussions and patches > Subject: Re: [FFmpeg-devel] [PATCH v3] avcodec/cbs_vp8: Add support for VP8 > codec bitstream READ methods > > > > >

Re: [FFmpeg-devel] [PATCH 1/2] fftools/opt_common: Use %c instead of %s to write single char

James Almer: > On 7/30/2023 9:47 PM, Andreas Rheinhardt wrote: >> Also combine multiple printfs. >> >> Signed-off-by: Andreas Rheinhardt >> --- >>   fftools/opt_common.c | 28 ++-- >>   1 file changed, 14 insertions(+), 14 deletions(-) >> >> diff --git

Re: [FFmpeg-devel] [PATCH 1/2] fftools/opt_common: Use %c instead of %s to write single char

James Almer: > On 7/30/2023 9:47 PM, Andreas Rheinhardt wrote: >> Also combine multiple printfs. >> >> Signed-off-by: Andreas Rheinhardt >> --- >>   fftools/opt_common.c | 28 ++-- >>   1 file changed, 14 insertions(+), 14 deletions(-) >> >> diff --git

Re: [FFmpeg-devel] [PATCH 1/2] fftools/opt_common: Use %c instead of %s to write single char

On 7/30/2023 9:47 PM, Andreas Rheinhardt wrote: Also combine multiple printfs. Signed-off-by: Andreas Rheinhardt --- fftools/opt_common.c | 28 ++-- 1 file changed, 14 insertions(+), 14 deletions(-) diff --git a/fftools/opt_common.c b/fftools/opt_common.c index

[FFmpeg-devel] [PATCH 2/2] fftools/opt_common: Don't add unnecessary " "

Before: D.AIL. smackaudio Smacker audio (decoders: smackaud ) After: D.AIL. smackaudio Smacker audio (decoders: smackaud) Signed-off-by: Andreas Rheinhardt --- fftools/opt_common.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/fftools/opt_common.c

[FFmpeg-devel] [PATCH 1/2] fftools/opt_common: Use %c instead of %s to write single char

Also combine multiple printfs. Signed-off-by: Andreas Rheinhardt --- fftools/opt_common.c | 28 ++-- 1 file changed, 14 insertions(+), 14 deletions(-) diff --git a/fftools/opt_common.c b/fftools/opt_common.c index 7c996f140d..3881d5bbef 100644 --- a/fftools/opt_common.c

Re: [FFmpeg-devel] [PATCH 01/12] avradio/avformat/sdrdemux: Move agc_gain into local variable

NAK to whole set. ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".

[FFmpeg-devel] [PATCH 08/12] avradio/avformat/sdrdemux: set wanted gain also when manually set

Signed-off-by: Michael Niedermayer --- libavformat/sdrdemux.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/libavformat/sdrdemux.c b/libavformat/sdrdemux.c index 8f0f4657f3..3f3390049c 100644 --- a/libavformat/sdrdemux.c +++ b/libavformat/sdrdemux.c @@ -1476,7 +1476,7

[FFmpeg-devel] [PATCH 12/12] avradio/avformat/sdrdemux: replace heuristic FM scaling by logic

Signed-off-by: Michael Niedermayer --- libavformat/sdrdemux.c | 4 +++- tests/ref/fate/sdr-fm | 12 ++-- 2 files changed, 9 insertions(+), 7 deletions(-) diff --git a/libavformat/sdrdemux.c b/libavformat/sdrdemux.c index bda7387213..f8590a2e18 100644 --- a/libavformat/sdrdemux.c +++

[FFmpeg-devel] [PATCH 07/12] avradio/avformat/sdrdemux: Avoid uninitialized memory on mono -> stereo switch

Signed-off-by: Michael Niedermayer --- libavformat/sdrdemux.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/libavformat/sdrdemux.c b/libavformat/sdrdemux.c index 69349add7b..8f0f4657f3 100644 --- a/libavformat/sdrdemux.c +++ b/libavformat/sdrdemux.c @@ -1150,6 +1150,8 @@ static int

[FFmpeg-devel] [PATCH 11/12] avradio/avformat/sdrdemux: fix FM block size

as we copied twice the bandwith needed previously, we now also need only half the block size. Done in a seperate patch for easier bisection Signed-off-by: Michael Niedermayer --- libavformat/sdrdemux.c | 2 +- tests/ref/fate/sdr-fm | 12 ++-- 2 files changed, 7 insertions(+), 7

[FFmpeg-devel] [PATCH 06/12] avradio/avformat/sdrdemux: run clip check on the correct samples

Signed-off-by: Michael Niedermayer --- libavformat/sdrdemux.c | 7 +++ 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/libavformat/sdrdemux.c b/libavformat/sdrdemux.c index 44a6489bd2..69349add7b 100644 --- a/libavformat/sdrdemux.c +++ b/libavformat/sdrdemux.c @@ -1153,10

[FFmpeg-devel] [PATCH 10/12] avradio/avformat/sdrdemux: fix off by 2 FM bandwidth error

Also adjust related parameters Signed-off-by: Michael Niedermayer --- libavformat/sdrdemux.c | 8 tests/ref/fate/sdr-am | 25 - tests/ref/fate/sdr-fm | 14 +++--- 3 files changed, 23 insertions(+), 24 deletions(-) diff --git a/libavformat/sdrdemux.c

[FFmpeg-devel] [PATCH 09/12] avradio/avformat/sdrdemux: dont use a fuction name as local variable

Signed-off-by: Michael Niedermayer --- libavformat/sdrdemux.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/libavformat/sdrdemux.c b/libavformat/sdrdemux.c index 3f3390049c..0e327f4860 100644 --- a/libavformat/sdrdemux.c +++ b/libavformat/sdrdemux.c @@ -1043,13

[FFmpeg-devel] [PATCH 05/12] avradio/avformat/sdrdemux: delay station search on AGC adjust

Signed-off-by: Michael Niedermayer --- libavformat/sdrdemux.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/libavformat/sdrdemux.c b/libavformat/sdrdemux.c index fa45d30a3d..44a6489bd2 100644 --- a/libavformat/sdrdemux.c +++ b/libavformat/sdrdemux.c @@ -1536,6 +1536,8 @@ static void

[FFmpeg-devel] [PATCH 04/12] avradio/avformat/sdrdemux: only update agc_gain on success

Signed-off-by: Michael Niedermayer --- libavformat/sdrdemux.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/libavformat/sdrdemux.c b/libavformat/sdrdemux.c index e5ee4e80f5..fa45d30a3d 100644 --- a/libavformat/sdrdemux.c +++ b/libavformat/sdrdemux.c @@ -1533,8

[FFmpeg-devel] [PATCH 03/12] avradio/avdevice/sdrindev: Soapy / RTLSDR ignores gain in direct sampling mode

Signed-off-by: Michael Niedermayer --- libavdevice/sdrindev.c | 4 1 file changed, 4 insertions(+) diff --git a/libavdevice/sdrindev.c b/libavdevice/sdrindev.c index f07bd6b154..8766fc2f34 100644 --- a/libavdevice/sdrindev.c +++ b/libavdevice/sdrindev.c @@ -88,6 +88,10 @@ static int

[FFmpeg-devel] [PATCH 02/12] avradio/avformat/sdrdemux: Move Software AGC into buffer thread

This allows the AGC to act with less latency Signed-off-by: Michael Niedermayer --- libavformat/sdr.h | 1 - libavformat/sdrdemux.c | 77 -- 2 files changed, 44 insertions(+), 34 deletions(-) diff --git a/libavformat/sdr.h b/libavformat/sdr.h index

[FFmpeg-devel] [PATCH 01/12] avradio/avformat/sdrdemux: Move agc_gain into local variable

Signed-off-by: Michael Niedermayer --- libavformat/sdr.h | 1 - libavformat/sdrdemux.c | 7 --- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/libavformat/sdr.h b/libavformat/sdr.h index 77278ada67..1f2d3a49ab 100644 --- a/libavformat/sdr.h +++ b/libavformat/sdr.h @@

Re: [FFmpeg-devel] What is FFmpeg and what should it be

Kieran Kunhya (12023-07-30): > I plan to write a more detailed response to Nicolas' email. However, > this response is superb because it immediately points out the flaw in > the arguments. Users will not tolerate "incomplete" features, they > will always want their edge case (packet capture

Re: [FFmpeg-devel] What is FFmpeg and what should it be

On Sun, Jul 30, 2023 at 6:07 PM Andrey Turkin wrote: > > вс, 30 июл. 2023 г. в 16:04, Nicolas George : > > > Kieran Kunhya (12023-07-28): > > > FFmpeg doesn't implement TCP in userspace, it doesn't implement the > > > WiFi protocol etc etc. Different layers are delegated to different > > >

Re: [FFmpeg-devel] What is FFmpeg and what should it be

вс, 30 июл. 2023 г. в 16:04, Nicolas George : > Kieran Kunhya (12023-07-28): > > FFmpeg doesn't implement TCP in userspace, it doesn't implement the > > WiFi protocol etc etc. Different layers are delegated to different > > programs. > There is a good reason to have some part of TCP implemented

Re: [FFmpeg-devel] [PATCH 1/2] avcodec/cbs: Add specialization for ff_cbs_(read|write)_unsigned()

Andreas Rheinhardt: > These functions allow not only to read and write unsigned values, > but also to check ranges and to emit trace output which can be > beautified when processing arrays (indices like "[i]" are replaced > by their actual numbers). > > Yet lots of callers actually only need

Re: [FFmpeg-devel] [PATCH] avcodec/h264_slice: Remove always-false check

Andreas Rheinhardt: > The H.264 decoder, the only codec with which this code > is ever called, does not set AVCodec.pix_fmts. > > Signed-off-by: Andreas Rheinhardt > --- > libavcodec/h264_slice.c | 14 +- > 1 file changed, 5 insertions(+), 9 deletions(-) > > diff --git

[FFmpeg-devel] What is FFmpeg and what should it be

Kieran Kunhya (12023-07-28): > FFmpeg doesn't implement TCP in userspace, it doesn't implement the > WiFi protocol etc etc. Different layers are delegated to different > programs. Hi. You seem to be discussing this in more good faith than I previously imagined, so I will try to tone done the