Re: [FFmpeg-devel] [PATCH 1/3] avcodec/jpeg2000htdec: Avoid freeing uninitialized pointers in ff_jpeg2000_decode_htj2k()

2023-08-03 Thread Caleb Etemesi
Looks good, for the other two, I may need to check with a problematic sample I had to see if it works Kind regards, Caleb Etemesi On Thu, 3 Aug 2023, 23:58 Pierre-Anthony Lemieux, wrote: > On Thu, Aug 3, 2023 at 1:50 PM Tomas Härdin wrote: > > > > tor 2023-08-03 klockan 17:36 +0200 skrev

Re: [FFmpeg-devel] [PATCH v4 1/9] libavutil: add hwcontext_d3d12va and AV_PIX_FMT_D3D12

2023-08-03 Thread Xiang, Haihao
On Wo, 2023-07-19 at 18:01 +0800, Tong Wu wrote: > From: Wu Jianhua > > Signed-off-by: Wu Jianhua > Signed-off-by: Tong Wu > --- >  configure  |   5 + >  doc/APIchanges |   7 + >  libavutil/Makefile |   3 + >  

[FFmpeg-devel] [PATCH] avformat/flvdec: remove unused context member of flv

2023-08-03 Thread Steven Liu
The exheader is unnecessary after 207e9f4e505d969d6ff7545b449295a1b88d6d1c Iust use local varible can do the same function. Signed-off-by: Steven Liu --- libavformat/flvdec.c | 9 - 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/libavformat/flvdec.c b/libavformat/flvdec.c

[FFmpeg-devel] [PATCH v2 1/2] lavu/tx: add real to real and real to imaginary RDFT transforms

2023-08-03 Thread Lynne
These are in-place transforms, required for DCT-I and DST-I. Templated as the mod2 variant requires minor modifications, and is required specifically for DCT-I/DST-I. >From c12c72e9de37a9eedf83e8ceb5ee444575420237 Mon Sep 17 00:00:00 2001 From: Lynne Date: Thu, 3 Aug 2023 18:21:23 +0200

Re: [FFmpeg-devel] [PATCH 1/2] lavu/tx: add real to real and real to imaginary RDFT transforms

2023-08-03 Thread Lynne
Aug 3, 2023, 22:39 by andreas.rheinha...@outlook.com: > Michael Niedermayer: > >> On Thu, Aug 03, 2023 at 06:26:16PM +0200, Lynne wrote: >> >>> These are in-place transforms, required for DCT-I and DST-I. >>> >>> Templated as the mod2 variant requires minor modifications, and is >>> required

[FFmpeg-devel] [PATCH 7/7] avcodec/qsvenc: Remove unnecessary config_components.h inclusion

2023-08-03 Thread Andreas Rheinhardt
While just at it, also improve the other headers a bit. Signed-off-by: Andreas Rheinhardt --- libavcodec/qsvenc.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/libavcodec/qsvenc.c b/libavcodec/qsvenc.c index df63c182b0..7ff9d333a2 100644 --- a/libavcodec/qsvenc.c +++

[FFmpeg-devel] [PATCH 6/7] avfilter: Remove unnecessary formats.h inclusions

2023-08-03 Thread Andreas Rheinhardt
A filter needs formats.h iff it uses FILTER_QUERY_FUNC(); since lots of filters have been switched to use something else than FILTER_QUERY_FUNC, they don't need it any more, but removing this header has been forgotten. This commit does this; files with formats.h inclusion went down from 304 to 139

[FFmpeg-devel] [PATCH 5/7] avfilter/internal: Don't include formats.h

2023-08-03 Thread Andreas Rheinhardt
internal.h doesn't rely on it; instead include it directly in every user that needs it (a filter needing it is basically equivalent to it using FILTER_QUERY_FUNC, i.e. a majority of filters doesn't need it). Signed-off-by: Andreas Rheinhardt --- libavfilter/aeval.c | 1 +

Re: [FFmpeg-devel] [PATCH 3/4] avfilter: Deduplicate default video inputs/outputs

2023-08-03 Thread Andreas Rheinhardt
Marvin Scholz: > > > On 3 Aug 2023, at 16:33, Andreas Rheinhardt wrote: > >> Lots of video filters use a very simple input or output: >> An array with a single AVFilterPad whose name is "default" >> and whose type is AVMEDIA_TYPE_VIDEO; everything else is unset. >> >> Given that we never use

Re: [FFmpeg-devel] [PATCH 1/3] avcodec/jpeg2000htdec: Avoid freeing uninitialized pointers in ff_jpeg2000_decode_htj2k()

2023-08-03 Thread Pierre-Anthony Lemieux
On Thu, Aug 3, 2023 at 1:50 PM Tomas Härdin wrote: > > tor 2023-08-03 klockan 17:36 +0200 skrev Michael Niedermayer: > > On Thu, Aug 03, 2023 at 10:20:29AM +0200, Tomas Härdin wrote: > > > ons 2023-08-02 klockan 02:01 +0200 skrev Michael Niedermayer: > > > > Fixes: freeing of uninitialized

Re: [FFmpeg-devel] What is FFmpeg and what should it be

2023-08-03 Thread Tomas Härdin
tor 2023-08-03 klockan 15:25 +0200 skrev Nicolas George: > Tomas Härdin (12023-07-31): > > As far as I recall libxml2 does not enable the fancier features of > > XML > > unless told to do so. And if it can't disable things like DTD then > > a > > ticket should be opened with them to make that

Re: [FFmpeg-devel] [PATCH 1/3] avcodec/jpeg2000htdec: Avoid freeing uninitialized pointers in ff_jpeg2000_decode_htj2k()

2023-08-03 Thread Tomas Härdin
tor 2023-08-03 klockan 17:36 +0200 skrev Michael Niedermayer: > On Thu, Aug 03, 2023 at 10:20:29AM +0200, Tomas Härdin wrote: > > ons 2023-08-02 klockan 02:01 +0200 skrev Michael Niedermayer: > > > Fixes: freeing of uninitialized pointers > > > Fixes: part of 58299 > > > > > > Found-by:

Re: [FFmpeg-devel] [PATCH 1/2] lavu/tx: add real to real and real to imaginary RDFT transforms

2023-08-03 Thread Andreas Rheinhardt
Michael Niedermayer: > On Thu, Aug 03, 2023 at 06:26:16PM +0200, Lynne wrote: >> These are in-place transforms, required for DCT-I and DST-I. >> >> Templated as the mod2 variant requires minor modifications, and is >> required specifically for DCT-I/DST-I. >> >> Quite optimized, as there's no need

Re: [FFmpeg-devel] [PATCH 1/2] lavu/tx: add real to real and real to imaginary RDFT transforms

2023-08-03 Thread Michael Niedermayer
On Thu, Aug 03, 2023 at 06:26:16PM +0200, Lynne wrote: > These are in-place transforms, required for DCT-I and DST-I. > > Templated as the mod2 variant requires minor modifications, and is > required specifically for DCT-I/DST-I. > > Quite optimized, as there's no need for any additional buffer

Re: [FFmpeg-devel] [PATCH] avformat/flvdec: handle exheader fourcc correctly in metadata

2023-08-03 Thread Marton Balint
On Wed, 2 Aug 2023, Steven Liu wrote: Marton Balint 于2023年7月30日周日 01:49写道: In metadata fourcc is carried in the AMF number, not as binary. Partially based on a patch by Steven Liu. Signed-off-by: Marton Balint --- libavformat/flvdec.c | 76 +---

Re: [FFmpeg-devel] What is FFmpeg and what should it be

2023-08-03 Thread Kieran Kunhya
On Thu, 3 Aug 2023, 15:25 Michael Niedermayer, wrote: > On Thu, Aug 03, 2023 at 02:24:04PM -0400, Kieran Kunhya wrote: > > > > > > > > > There are 2 things DAB and DVB both use mpeg ts > > > > > > > DAB does not use mpegts. It has several layers of it's own framing. > > Well, i stand corrected

Re: [FFmpeg-devel] What is FFmpeg and what should it be

2023-08-03 Thread Michael Niedermayer
On Thu, Aug 03, 2023 at 02:24:04PM -0400, Kieran Kunhya wrote: > > > > > > There are 2 things DAB and DVB both use mpeg ts > > > > DAB does not use mpegts. It has several layers of it's own framing. Well, i stand corrected then. I saw it on the ML and in some spec but that was about IP data in

Re: [FFmpeg-devel] What is FFmpeg and what should it be

2023-08-03 Thread Kieran Kunhya
> > > There are 2 things DAB and DVB both use mpeg ts > DAB does not use mpegts. It has several layers of it's own framing. Kieran > ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To

Re: [FFmpeg-devel] What is FFmpeg and what should it be

2023-08-03 Thread Michael Niedermayer
On Wed, Aug 02, 2023 at 04:44:14PM +0200, Jean-Baptiste Kempf wrote: > On Wed, 2 Aug 2023, at 16:20, Michael Niedermayer wrote: > > There are multiple problems but the real problem is that > > How many people discuss an SDR API ? (0) > > How many people propose an SDR API ? (0) > > Did you ask

Re: [FFmpeg-devel] [PATCH 3/4] avfilter: Deduplicate default video inputs/outputs

2023-08-03 Thread Marvin Scholz
On 3 Aug 2023, at 16:33, Andreas Rheinhardt wrote: > Lots of video filters use a very simple input or output: > An array with a single AVFilterPad whose name is "default" > and whose type is AVMEDIA_TYPE_VIDEO; everything else is unset. > > Given that we never use pointer equality for inputs

Re: [FFmpeg-devel] [PATCH 1/2] lavu/tx: add real to real and real to imaginary RDFT transforms

2023-08-03 Thread Lynne
Aug 3, 2023, 18:26 by d...@lynne.ee: > These are in-place transforms, required for DCT-I and DST-I. > > Templated as the mod2 variant requires minor modifications, and is > required specifically for DCT-I/DST-I. > > Quite optimized, as there's no need for any additional buffer storage. >

[FFmpeg-devel] [PATCH 2/2] lavu/tx: add DCT-I and DST-I transforms

2023-08-03 Thread Lynne
These are true, actual DCT-I and DST-I transforms, unlike the libavcodec versions, which are plainly not. Error tests via https://github.com/cyanreg/lavu_fft_test RMS error on a 2048-sample DCT-I: RMSE   av_tx = 0.00 (4096 matches, first mismatch at -1) RMSE  fftw3f = 0.00 (4096 matches,

[FFmpeg-devel] [PATCH 1/2] lavu/tx: add real to real and real to imaginary RDFT transforms

2023-08-03 Thread Lynne
These are in-place transforms, required for DCT-I and DST-I. Templated as the mod2 variant requires minor modifications, and is required specifically for DCT-I/DST-I. Quite optimized, as there's no need for any additional buffer storage. >From 2ea5e2541c2551bf1b56e967d35946289a85aa49 Mon Sep 17

Re: [FFmpeg-devel] What is FFmpeg and what should it be

2023-08-03 Thread Michael Niedermayer
On Wed, Aug 02, 2023 at 03:46:29PM +, Cosmin Stejerean wrote: > > > > On Aug 2, 2023, at 7:30 AM, Nicolas George wrote: > > > > Michael Niedermayer (12023-08-02): > >> The libraries should be split into runtime loadable plugins > >> Not only would that make tools alot smaller it also would

Re: [FFmpeg-devel] [PATCH 1/3] avfilter/avfilter: Also deprecate variable name

2023-08-03 Thread Andreas Rheinhardt
Andreas Rheinhardt: > Otherwise the var_names and the corresponding enum will be off > and e.g. the array holding the variable values will be too small. > > Signed-off-by: Andreas Rheinhardt > --- > libavfilter/avfilter.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git

Re: [FFmpeg-devel] [PATCH 1/3] avcodec/jpeg2000htdec: Avoid freeing uninitialized pointers in ff_jpeg2000_decode_htj2k()

2023-08-03 Thread Michael Niedermayer
On Thu, Aug 03, 2023 at 10:20:29AM +0200, Tomas Härdin wrote: > ons 2023-08-02 klockan 02:01 +0200 skrev Michael Niedermayer: > > Fixes: freeing of uninitialized pointers > > Fixes: part of 58299 > > > > Found-by: continuous fuzzing process > >

[FFmpeg-devel] [PATCH 4/4] avfilter/vf_colorconstancy: Remove redundant CONFIG check

2023-08-03 Thread Andreas Rheinhardt
This file is only used by the greyedge filter and therefore only compiled if said filter is enabled. This also allows to remove a config_components.h inclusion, avoiding unnecessary rebuilds. Signed-off-by: Andreas Rheinhardt --- libavfilter/vf_colorconstancy.c | 6 -- 1 file changed, 6

[FFmpeg-devel] [PATCH 2/4] avfilter/internal: Don't include video.h

2023-08-03 Thread Andreas Rheinhardt
internal.h does not depend on video.h (and should not depend on it) and therefore should not include video.h at all; instead all users of video.h should include it directly. Doing so also avoids unnecessary video.h inclusions in files that don't need it, like most audio filters. Signed-off-by:

[FFmpeg-devel] [PATCH 1/4] avfilter: Deduplicate default audio inputs/outputs

2023-08-03 Thread Andreas Rheinhardt
Lots of audio filters use very simple inputs or outputs: An array with a single AVFilterPad whose name is "default" and whose type is AVMEDIA_TYPE_AUDIO; everything else is unset. Given that we never use pointer equality for inputs or outputs*, we can simply use a single AVFilterPad instead of

Re: [FFmpeg-devel] What is FFmpeg and what should it be

2023-08-03 Thread Nicolas George
Tomas Härdin (12023-08-03): > I thought of another thing that bears mentioning: Michael has expressed > interest in implementing DAB. This carries with it two problems: > > * Each DAB ensemble is an MPEG-TS stream > * There can be more than one ensemble on air > > The first means mere

Re: [FFmpeg-devel] What is FFmpeg and what should it be

2023-08-03 Thread Nicolas George
Tomas Härdin (12023-07-31): > As far as I recall libxml2 does not enable the fancier features of XML > unless told to do so. And if it can't disable things like DTD then a > ticket should be opened with them to make that possible. You are missing the point: even if all these features are entirely

Re: [FFmpeg-devel] What is FFmpeg and what should it be

2023-08-03 Thread Tomas Härdin
sön 2023-07-30 klockan 15:04 +0200 skrev Nicolas George: > Michael's code seems pretty self-contained to me. > > And once again: > > *** IT DOES NOT HAVE TO BE COMPLETE TO BE USEFUL. *** I thought of another thing that bears mentioning: Michael has expressed interest in implementing DAB. This

Re: [FFmpeg-devel] [PATCH 1/3] avcodec/jpeg2000htdec: Avoid freeing uninitialized pointers in ff_jpeg2000_decode_htj2k()

2023-08-03 Thread Tomas Härdin
ons 2023-08-02 klockan 02:01 +0200 skrev Michael Niedermayer: > Fixes: freeing of uninitialized pointers > Fixes: part of 58299 > > Found-by: continuous fuzzing process > https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg > Signed-off-by: Michael Niedermayer > --- >  

[FFmpeg-devel] [PATCH v3 6/6] lavc/vaapi_encode: Add VAAPI AV1 encoder

2023-08-03 Thread fei . w . wang-at-intel . com
From: Fei Wang Signed-off-by: Fei Wang --- Changelog |1 + configure |3 + doc/encoders.texi | 13 + libavcodec/Makefile |1 + libavcodec/allcodecs.c|1 + libavcodec/vaapi_encode.c | 125 +++-

[FFmpeg-devel] [PATCH v3 5/6] lavc/vaapi_encode: Separate reference frame into previous/future list

2023-08-03 Thread fei . w . wang-at-intel . com
From: Fei Wang To support more reference frames from different directions. Signed-off-by: Fei Wang --- libavcodec/vaapi_encode.c | 112 +--- libavcodec/vaapi_encode.h | 15 +++-- libavcodec/vaapi_encode_h264.c | 94 +--

[FFmpeg-devel] [PATCH v3 4/6] lavc/vaapi_encode: Extract set output pkt timestamp function

2023-08-03 Thread fei . w . wang-at-intel . com
From: Fei Wang Signed-off-by: Fei Wang --- libavcodec/vaapi_encode.c | 37 - 1 file changed, 24 insertions(+), 13 deletions(-) diff --git a/libavcodec/vaapi_encode.c b/libavcodec/vaapi_encode.c index 8c9f14df66..c8545cd8db 100644 ---

[FFmpeg-devel] [PATCH v3 3/6] lavc/vaapi_encode: Init pic at the beginning of API

2023-08-03 Thread fei . w . wang-at-intel . com
From: Fei Wang Signed-off-by: Fei Wang --- libavcodec/vaapi_encode.c | 5 + 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/libavcodec/vaapi_encode.c b/libavcodec/vaapi_encode.c index bfca315a7a..8c9f14df66 100644 --- a/libavcodec/vaapi_encode.c +++ b/libavcodec/vaapi_encode.c

[FFmpeg-devel] [PATCH v3 2/6] lavc/av1: Add common code and unit test for level handling

2023-08-03 Thread fei . w . wang-at-intel . com
From: Fei Wang Signed-off-by: Fei Wang --- update: 1. Rename libavcodec/av1_levels*. 2. Use array instead of handle for AV1LevelDescriptor.name. 3. Compile libavcodec/av1_levels* only when enable vaapi av1 encoder. libavcodec/Makefile | 1 + libavcodec/av1_levels.c | 92

[FFmpeg-devel] [PATCH v3 1/6] avcodec/cbs_av1: Add tx mode enum values

2023-08-03 Thread fei . w . wang-at-intel . com
From: Fei Wang Signed-off-by: Fei Wang --- libavcodec/av1.h | 7 +++ libavcodec/cbs_av1_syntax_template.c | 4 ++-- 2 files changed, 9 insertions(+), 2 deletions(-) diff --git a/libavcodec/av1.h b/libavcodec/av1.h index 384f7cddc7..8704bc41c1 100644 ---