Re: [FFmpeg-devel] [PATCH v2] lavu/hwcontext_vaapi: Add vaapi_drm_format_map support for x2rgb10

2023-08-09 Thread Xiang, Haihao
On Wo, 2023-08-09 at 14:45 +0200, David Rosca wrote: > Support for allocating frames with x2rgb10 format was added > in c00264f5013, this adds support for importing DMA-BUFs. > > v2: Fix #ifdef -> #if Could you add the update history in annotate, not git commit log ? Thanks Haihao > --- >  

Re: [FFmpeg-devel] [PATCH v3] avcodec/cbs_vp8: Add support for VP8 codec bitstream READ methods

2023-08-09 Thread Xiang, Haihao
On Ma, 2023-07-31 at 02:14 +, Dai, Jianhui J wrote: > > > > -Original Message- > > From: ffmpeg-devel On Behalf Of Dai, > > Jianhui J > > Sent: Tuesday, June 20, 2023 9:42 AM > > To: FFmpeg development discussions and patches > > Subject: Re: [FFmpeg-devel] [PATCH v3]

Re: [FFmpeg-devel] [PATCH v3 6/6] lavc/vaapi_encode: Add VAAPI AV1 encoder

2023-08-09 Thread Wang, Fei W
On Mon, 2023-08-07 at 22:21 +0100, Mark Thompson wrote: > On 03/08/2023 07:01, fei.w.wang-at-intel@ffmpeg.org wrote: > > From: Fei Wang > > > > Signed-off-by: Fei Wang > > --- > > Changelog |1 + > > configure |3 + > > doc/encoders.texi

Re: [FFmpeg-devel] [PATCH v7 0/5] JPEG XL Parser (and bug fixes)

2023-08-09 Thread Leo Izen
On 8/2/23 16:33, Leo Izen wrote: Changes from v6: - Added dummy stub libavformat/jpegxl_parse.c to fix shared builds Bumping for review. I know the commit message in patch 3/5 is wrong, but I can fix that on merge, or v8 if a v8 is necessary. - Leo Izen

[FFmpeg-devel] [PATCH] new audio filter and misc improvements

2023-08-09 Thread Paul B Mahol
Patches attached. From 2d8c330f543397642fa1afe0a01a67155008d4e1 Mon Sep 17 00:00:00 2001 From: Paul B Mahol Date: Wed, 9 Aug 2023 21:53:04 +0200 Subject: [PATCH 3/3] avfilter/af_adeclick: do not output pointless message Signed-off-by: Paul B Mahol --- libavfilter/af_adeclick.c | 7 --- 1

Re: [FFmpeg-devel] [PATCH v2] avcodec/mv30: Check the input length before allocation

2023-08-09 Thread Paul B Mahol
On Wed, Aug 9, 2023 at 11:15 PM James Almer wrote: > On 8/9/2023 6:20 PM, Paul B Mahol wrote: > > On Wed, Aug 9, 2023 at 9:30 PM Michael Niedermayer < > mich...@niedermayer.cc> > > wrote: > > > >> Hi Paul > >> > >> On Wed, Aug 09, 2023 at 08:53:03PM +0200, Paul B Mahol wrote: > >>> This is not

Re: [FFmpeg-devel] [PATCH v2] avcodec/mv30: Check the input length before allocation

2023-08-09 Thread James Almer
On 8/9/2023 6:20 PM, Paul B Mahol wrote: On Wed, Aug 9, 2023 at 9:30 PM Michael Niedermayer wrote: Hi Paul On Wed, Aug 09, 2023 at 08:53:03PM +0200, Paul B Mahol wrote: This is not correct, and please stop writing such patches. Thanks. If there is a problem in the bugfix, please explain

Re: [FFmpeg-devel] [PATCH v2] avcodec/mv30: Check the input length before allocation

2023-08-09 Thread Paul B Mahol
On Wed, Aug 9, 2023 at 9:30 PM Michael Niedermayer wrote: > Hi Paul > > On Wed, Aug 09, 2023 at 08:53:03PM +0200, Paul B Mahol wrote: > > This is not correct, and please stop writing such patches. Thanks. > > If there is a problem in the bugfix, please explain what the problem is. > If you do

Re: [FFmpeg-devel] [PATCH v2] avcodec/mv30: Check the input length before allocation

2023-08-09 Thread Michael Niedermayer
Hi Paul On Wed, Aug 09, 2023 at 08:53:03PM +0200, Paul B Mahol wrote: > This is not correct, and please stop writing such patches. Thanks. If there is a problem in the bugfix, please explain what the problem is. If you do not like the specific fix, you can fix it differently too or tell me what

Re: [FFmpeg-devel] [PATCH v2] avcodec/mv30: Check the input length before allocation

2023-08-09 Thread Paul B Mahol
This is not correct, and please stop writing such patches. Thanks. ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with

[FFmpeg-devel] [PATCH v2] avcodec/mv30: Check the input length before allocation

2023-08-09 Thread Michael Niedermayer
Fixes: Timeout Fixes: 60867/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_MV30_fuzzer-6381933108527104 Fixes: 30147/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_MV30_fuzzer-5549246684200960 Found-by: continuous fuzzing process

Re: [FFmpeg-devel] [PATCH v2] avcodec/dovi_rpu: verify RPU data CRC32

2023-08-09 Thread quietvoid
On 09/08/2023 13.08, James Almer wrote: On 8/9/2023 2:05 PM, quietvoid wrote: The Dolby Vision RPU contains a CRC32 to validate the payload against. The implementation is CRC32/MPEG-2. The CRC is only verified with the AV_EF_CRCCHECK flag. Signed-off-by: quietvoid ---  

[FFmpeg-devel] [PATCH v3] avcodec/dovi_rpu: verify RPU data CRC32

2023-08-09 Thread quietvoid
The Dolby Vision RPU contains a CRC32 to validate the payload against. The implementation is CRC32/MPEG-2. The CRC is only verified with the AV_EF_CRCCHECK flag. Signed-off-by: quietvoid --- libavcodec/dovi_rpu.c | 46 --- libavcodec/dovi_rpu.h | 3 ++-

Re: [FFmpeg-devel] [PATCH v2] avcodec/dovi_rpu: verify RPU data CRC32

2023-08-09 Thread James Almer
On 8/9/2023 2:05 PM, quietvoid wrote: The Dolby Vision RPU contains a CRC32 to validate the payload against. The implementation is CRC32/MPEG-2. The CRC is only verified with the AV_EF_CRCCHECK flag. Signed-off-by: quietvoid --- libavcodec/dovi_rpu.c | 45

[FFmpeg-devel] [PATCH v2] avcodec/dovi_rpu: verify RPU data CRC32

2023-08-09 Thread quietvoid
The Dolby Vision RPU contains a CRC32 to validate the payload against. The implementation is CRC32/MPEG-2. The CRC is only verified with the AV_EF_CRCCHECK flag. Signed-off-by: quietvoid --- libavcodec/dovi_rpu.c | 45 --- libavcodec/dovi_rpu.h | 3 ++-

Re: [FFmpeg-devel] [PATCH v4 2/4] mpegts: Stash original PTS for SCTE-35 sections for processing later

2023-08-09 Thread Devin Heitmueller
Hi Kieran, Thanks for your review. On Wed, Aug 9, 2023 at 9:55 AM Kieran Kunhya wrote: > How is this frame accurate? Surely "last_pcr" can be up to 100ms out. You > need to actually be interpolating the true value in order to be frame > accurate (not saying this is easy/doable in FFmpeg). But

Re: [FFmpeg-devel] What is FFmpeg and what should it be

2023-08-09 Thread Paul B Mahol
On Wed, Aug 9, 2023 at 5:59 PM Michael Niedermayer wrote: > On Tue, Aug 08, 2023 at 09:53:11PM +0300, Rémi Denis-Courmont wrote: > > Le tiistaina 8. elokuuta 2023, 18.22.49 EEST Michael Niedermayer a écrit > : > > > > > That is missing that people suggest a path forward but > > > > > with too

Re: [FFmpeg-devel] What is FFmpeg and what should it be

2023-08-09 Thread Michael Niedermayer
On Tue, Aug 08, 2023 at 09:53:11PM +0300, Rémi Denis-Courmont wrote: > Le tiistaina 8. elokuuta 2023, 18.22.49 EEST Michael Niedermayer a écrit : > > > > That is missing that people suggest a path forward but > > > > with too few details to easily walk that path. > > > > > > Uh, I hate to state

[FFmpeg-devel] [PATCH] avcodec/dovi_rpu: verify RPU data CRC32

2023-08-09 Thread quietvoid
The Dolby Vision RPU contains a CRC32 to validate the payload against. It must be an identical match for the metadata to be used. The implementation is CRC32/MPEG-2. Signed-off-by: quietvoid --- libavcodec/dovi_rpu.c | 37 +++-- 1 file changed, 35 insertions(+),

Re: [FFmpeg-devel] [PATCH v4 2/4] mpegts: Stash original PTS for SCTE-35 sections for processing later

2023-08-09 Thread Kieran Kunhya
On Mon, 31 Jul 2023 at 09:38, Devin Heitmueller < devin.heitmuel...@ltnglobal.com> wrote: > We need the original PTS value in order to do subsequent processing, > so set it as packet side data. > > Signed-off-by: Devin Heitmueller > --- > libavformat/mpegts.c | 11 ++- > 1 file changed,

Re: [FFmpeg-devel] [PATCH 2/7] avutil/bprint: Allow size == 0 in av_bprint_init_for_buffer()

2023-08-09 Thread Andreas Rheinhardt
James Almer: > On 8/9/2023 7:08 AM, Nicolas George wrote: >> Andreas Rheinhardt (12023-08-06): >>> The AVBPrint API guarantees that the string buffer is always >>> zero-terminated; in order to honour this guarantee, there >>> obviously must be a string buffer at all and it must have >>> a size >=

Re: [FFmpeg-devel] [PATCH] lavu/hwcontext_vaapi: Add vaapi_drm_format_map support for x2rgb10

2023-08-09 Thread David Rosca
On Wed, Aug 9, 2023 at 2:35 PM Rémi Denis-Courmont wrote: > > > > Le 9 août 2023 15:02:45 GMT+03:00, David Rosca a écrit : > >Support for allocating frames with x2rgb10 format was added > >in c00264f5013, this adds support for importing DMA-BUFs. > >--- > > libavutil/hwcontext_vaapi.c | 3 +++ >

[FFmpeg-devel] [PATCH v2] lavu/hwcontext_vaapi: Add vaapi_drm_format_map support for x2rgb10

2023-08-09 Thread David Rosca
Support for allocating frames with x2rgb10 format was added in c00264f5013, this adds support for importing DMA-BUFs. v2: Fix #ifdef -> #if --- libavutil/hwcontext_vaapi.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/libavutil/hwcontext_vaapi.c b/libavutil/hwcontext_vaapi.c index

Re: [FFmpeg-devel] [PATCH] lavu/hwcontext_vaapi: Add vaapi_drm_format_map support for x2rgb10

2023-08-09 Thread Rémi Denis-Courmont
Le 9 août 2023 15:02:45 GMT+03:00, David Rosca a écrit : >Support for allocating frames with x2rgb10 format was added >in c00264f5013, this adds support for importing DMA-BUFs. >--- > libavutil/hwcontext_vaapi.c | 3 +++ > 1 file changed, 3 insertions(+) > >diff --git

[FFmpeg-devel] [PATCH] lavu/hwcontext_vaapi: Add vaapi_drm_format_map support for x2rgb10

2023-08-09 Thread David Rosca
Support for allocating frames with x2rgb10 format was added in c00264f5013, this adds support for importing DMA-BUFs. --- libavutil/hwcontext_vaapi.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/libavutil/hwcontext_vaapi.c b/libavutil/hwcontext_vaapi.c index 6c3a227ddd..63544ce476

Re: [FFmpeg-devel] [PATCH 2/7] avutil/bprint: Allow size == 0 in av_bprint_init_for_buffer()

2023-08-09 Thread James Almer
On 8/9/2023 7:08 AM, Nicolas George wrote: Andreas Rheinhardt (12023-08-06): The AVBPrint API guarantees that the string buffer is always zero-terminated; in order to honour this guarantee, there obviously must be a string buffer at all and it must have a size >= 1. Therefore

Re: [FFmpeg-devel] [PATCH 2/7] avutil/bprint: Allow size == 0 in av_bprint_init_for_buffer()

2023-08-09 Thread Nicolas George
Andreas Rheinhardt (12023-08-06): > The AVBPrint API guarantees that the string buffer is always > zero-terminated; in order to honour this guarantee, there > obviously must be a string buffer at all and it must have > a size >= 1. Therefore av_bprint_init_for_buffer() treats > passing a NULL

Re: [FFmpeg-devel] [PATCH 1/5] avformat/matroskaenc: Support rotations

2023-08-09 Thread Andreas Rheinhardt
Andreas Rheinhardt: > Matroska supports orthogonal transformations (both pure rotations > as well as reflections) via its 3D-projection elements, namely > ProjectionPoseYaw (for a horizontal reflection) as well as > ProjectionPoseRoll (for rotations). This commit adds support > for this. > >

Re: [FFmpeg-devel] [PATCH 2/7] avutil/bprint: Allow size == 0 in av_bprint_init_for_buffer()

2023-08-09 Thread Andreas Rheinhardt
Andreas Rheinhardt: > The AVBPrint API guarantees that the string buffer is always > zero-terminated; in order to honour this guarantee, there > obviously must be a string buffer at all and it must have > a size >= 1. Therefore av_bprint_init_for_buffer() treats > passing a NULL buffer or size ==