Re: [FFmpeg-devel] [PATCH] avformat/libsrt: Decode URL parameter strings

2023-08-10 Thread zhilizhao(赵志立)
> On Aug 11, 2023, at 00:13, Armin Hasitzka wrote: > > Hi again, > > we found this the other day when using a stream ID containing "%2F", > expecting this to be resolved to "/". While "%2F" could obviously be sent > decoded, "&" (decoded) would currently end the value and not be used, "+" >

Re: [FFmpeg-devel] [PATCH 3/3] avcodec/jpeg2000htdec: Check m

2023-08-10 Thread Pierre-Anthony Lemieux
On Sun, Aug 6, 2023 at 9:28 AM Pierre-Anthony Lemieux wrote: > > On Sat, Aug 5, 2023 at 9:30 AM Michael Niedermayer > wrote: > > > > On Fri, Aug 04, 2023 at 06:19:46PM -0700, Pierre-Anthony Lemieux wrote: > > > On Tue, Aug 1, 2023 at 5:02 PM Michael Niedermayer > > > wrote: > > > > > > > > This

[FFmpeg-devel] [PATCH v1] avcodec/jpeg2000htdec: check if block decoding will exceed internal precision

2023-08-10 Thread pal
From: Pierre-Anthony Lemieux Intended to replace https://patchwork.ffmpeg.org/project/ffmpeg/patch/20230802000135.26482-3-mich...@niedermayer.cc/ with a more accurate block decoding magnitude bound. --- libavcodec/jpeg2000htdec.c | 32 +++- 1 file changed, 31

Re: [FFmpeg-devel] [PATCH 01/12] avradio/avformat/sdrdemux: Move agc_gain into local variable

2023-08-10 Thread Paul B Mahol
On Thu, Aug 10, 2023 at 11:03 PM Michael Niedermayer wrote: > Hi Paul > > also CC-ing jb as he seemed interrested in teh subject > > On Mon, Jul 31, 2023 at 12:26:50AM +0200, Paul B Mahol wrote: > > NAK to whole set. > > I suggest you lift that NAK. > NAK is here to stay forever, until: All

Re: [FFmpeg-devel] [PATCH 01/12] avradio/avformat/sdrdemux: Move agc_gain into local variable

2023-08-10 Thread Michael Niedermayer
Hi Paul also CC-ing jb as he seemed interrested in teh subject On Mon, Jul 31, 2023 at 12:26:50AM +0200, Paul B Mahol wrote: > NAK to whole set. I suggest you lift that NAK. If you do i would apply this set of bugfixes and after that look into, if its possible to factorize the SDR code out. I

Re: [FFmpeg-devel] What is FFmpeg and what should it be

2023-08-10 Thread Tomas Härdin
tor 2023-08-10 klockan 14:39 +0200 skrev Nicolas George: > If a sponsor tried to leverage their sponsoring to dictate the > direction > of the project, threatening to withhold it unless they get their way, > then we should realize that sponsor is a dangerous asshole and sever > all > ties with

[FFmpeg-devel] [PATCH] examples/transcode: flush decoder on EOF

2023-08-10 Thread Zhao Zhili
From: Zhao Zhili Signed-off-by: Zhao Zhili --- doc/examples/transcode.c | 31 +-- 1 file changed, 29 insertions(+), 2 deletions(-) diff --git a/doc/examples/transcode.c b/doc/examples/transcode.c index 305181663c..ed6ac9fa03 100644 --- a/doc/examples/transcode.c

Re: [FFmpeg-devel] [PATCH] new audio filter and misc improvements

2023-08-10 Thread Paul B Mahol
On Thu, Aug 10, 2023 at 5:13 PM Michael Niedermayer wrote: > On Thu, Aug 10, 2023 at 12:10:49PM +0200, Paul B Mahol wrote: > > On Thu, Aug 10, 2023 at 11:48 AM Michael Niedermayer < > mich...@niedermayer.cc> > > wrote: > > > > > On Wed, Aug 09, 2023 at 11:36:16PM +0200, Paul B Mahol wrote: > > >

[FFmpeg-devel] [PATCH] avformat/libsrt: Decode URL parameter strings

2023-08-10 Thread Armin Hasitzka
Hi again, we found this the other day when using a stream ID containing "%2F", expecting this to be resolved to "/". While "%2F" could obviously be sent decoded, "&" (decoded) would currently end the value and not be used, "+" (decoded) would be overwritten with " ", and "=" (decoded) could cause

Re: [FFmpeg-devel] [PATCH v4 2/4] mpegts: Stash original PTS for SCTE-35 sections for processing later

2023-08-10 Thread Kieran Kunhya
Sent from my mobile device On Thu, 10 Aug 2023, 11:12 Devin Heitmueller, < devin.heitmuel...@ltnglobal.com> wrote: > Hi Kieran, > > On Thu, Aug 10, 2023 at 9:09 AM Kieran Kunhya wrote: > > You're exposing this incorrect information as public API, two wrongs > don't make a right. > > The

Re: [FFmpeg-devel] [PATCH v2] avcodec/mv30: Check the input length before allocation

2023-08-10 Thread Paul B Mahol
On Thu, Aug 10, 2023 at 5:46 PM Michael Niedermayer wrote: > On Thu, Aug 10, 2023 at 12:12:51PM +0200, Paul B Mahol wrote: > > On Thu, Aug 10, 2023 at 11:34 AM Michael Niedermayer < > mich...@niedermayer.cc> > > wrote: > > > > > On Wed, Aug 09, 2023 at 11:20:43PM +0200, Paul B Mahol wrote: > > >

Re: [FFmpeg-devel] [PATCH v2] avcodec/mv30: Check the input length before allocation

2023-08-10 Thread Michael Niedermayer
On Thu, Aug 10, 2023 at 12:12:51PM +0200, Paul B Mahol wrote: > On Thu, Aug 10, 2023 at 11:34 AM Michael Niedermayer > wrote: > > > On Wed, Aug 09, 2023 at 11:20:43PM +0200, Paul B Mahol wrote: > > > On Wed, Aug 9, 2023 at 9:30 PM Michael Niedermayer < > > mich...@niedermayer.cc> > > > wrote: >

Re: [FFmpeg-devel] What is FFmpeg and what should it be

2023-08-10 Thread Jean-Baptiste Kempf
On Thu, 10 Aug 2023, at 14:39, Nicolas George wrote: >> livelihood, and millions for their computer use" in response to NG's >> argument >> that FFmpeg should be turned into a fun experimental research project, and >> that people who wanted to keep FFmpeg what he calls a "serious open-source

[FFmpeg-devel] [PATCH] exclude currently unused 0.17% of fate samples from rsync

2023-08-10 Thread Michael Niedermayer
Several developers where upset, that from the over 1gb of fate samples 2mb are only used by the ffmpeg branch with SDR support in https://git.ffmpeg.org/libavradio This avoids these samples from being downloaded or synchronized. It should have no real world effect on anything of course if 0.17%

Re: [FFmpeg-devel] [PATCH] new audio filter and misc improvements

2023-08-10 Thread Michael Niedermayer
On Thu, Aug 10, 2023 at 12:10:49PM +0200, Paul B Mahol wrote: > On Thu, Aug 10, 2023 at 11:48 AM Michael Niedermayer > wrote: > > > On Wed, Aug 09, 2023 at 11:36:16PM +0200, Paul B Mahol wrote: > > > Patches attached. > > > > > af_adeclick.c |7 --- > > > 1 file changed, 4

Re: [FFmpeg-devel] [PATCH v4 2/4] mpegts: Stash original PTS for SCTE-35 sections for processing later

2023-08-10 Thread Devin Heitmueller
Hi Kieran, On Thu, Aug 10, 2023 at 9:09 AM Kieran Kunhya wrote: > You're exposing this incorrect information as public API, two wrongs don't > make a right. The information is already exposed via the public API, in the form of pkt->pts. The fact that I've exposed that same value as side data

Re: [FFmpeg-devel] What is FFmpeg and what should it be

2023-08-10 Thread James Almer
On 8/10/2023 9:39 AM, Nicolas George wrote: Rémi Denis-Courmont (12023-08-08): No. You are taking for granted that SDR belongs in FFmpeg in the first place, and that's exactly what people disagree with. And you are taking for granted that it does not belongs in FFmpeg. But what you refuse to

Re: [FFmpeg-devel] What is FFmpeg and what should it be

2023-08-10 Thread Vittorio Giovara
On Thu, Aug 10, 2023 at 2:39 PM Nicolas George wrote: > > No. You are taking for granted that SDR belongs in FFmpeg in the first > place, > > and that's exactly what people disagree with. > > And you are taking for granted that it does not belongs in FFmpeg. > > But what you refuse to realize is

Re: [FFmpeg-devel] [PATCH v4 2/4] mpegts: Stash original PTS for SCTE-35 sections for processing later

2023-08-10 Thread Kieran Kunhya
On Thu, 10 Aug 2023, 08:59 Devin Heitmueller, < devin.heitmuel...@ltnglobal.com> wrote: > On Thu, Aug 10, 2023 at 8:48 AM Kieran Kunhya wrote: > > > > > > > > On Thu, 10 Aug 2023 at 08:41, Kieran Kunhya wrote: > >> > >> On Thu, 10 Aug 2023 at 08:20, Devin Heitmueller < >

Re: [FFmpeg-devel] [PATCH v4 2/4] mpegts: Stash original PTS for SCTE-35 sections for processing later

2023-08-10 Thread Devin Heitmueller
On Thu, Aug 10, 2023 at 8:48 AM Kieran Kunhya wrote: > > > > On Thu, 10 Aug 2023 at 08:41, Kieran Kunhya wrote: >> >> On Thu, 10 Aug 2023 at 08:20, Devin Heitmueller >> wrote: >>> >>> On Thu, Aug 10, 2023 at 8:13 AM Kieran Kunhya wrote: >>> > The (closest?) video PTS is even worse than the

Re: [FFmpeg-devel] [PATCH v4 2/4] mpegts: Stash original PTS for SCTE-35 sections for processing later

2023-08-10 Thread Kieran Kunhya
On Thu, 10 Aug 2023 at 08:41, Kieran Kunhya wrote: > On Thu, 10 Aug 2023 at 08:20, Devin Heitmueller < > devin.heitmuel...@ltnglobal.com> wrote: > >> On Thu, Aug 10, 2023 at 8:13 AM Kieran Kunhya wrote: >> > The (closest?) video PTS is even worse than the last PCR because the >> VBV means the

Re: [FFmpeg-devel] [PATCH v4 2/4] mpegts: Stash original PTS for SCTE-35 sections for processing later

2023-08-10 Thread Kieran Kunhya
On Thu, 10 Aug 2023 at 08:20, Devin Heitmueller < devin.heitmuel...@ltnglobal.com> wrote: > On Thu, Aug 10, 2023 at 8:13 AM Kieran Kunhya wrote: > > The (closest?) video PTS is even worse than the last PCR because the VBV > means the closest PTS can be quite far from the interpolated PCR. > >

Re: [FFmpeg-devel] What is FFmpeg and what should it be

2023-08-10 Thread Nicolas George
Rémi Denis-Courmont (12023-08-08): > I have made some preposterous statements in my dark past, but I am pretty > sure > that I didn't make any statement to that effect, no. > > I did assert that there "are dozens of people, ostensibly including [you], > that depend on FFmpeg being ""Serious

Re: [FFmpeg-devel] [PATCH v4 2/4] mpegts: Stash original PTS for SCTE-35 sections for processing later

2023-08-10 Thread Devin Heitmueller
On Thu, Aug 10, 2023 at 8:13 AM Kieran Kunhya wrote: > The (closest?) video PTS is even worse than the last PCR because the VBV > means the closest PTS can be quite far from the interpolated PCR. It's arguments like that which prompted me to explicitly exclude such a patch from the series.

Re: [FFmpeg-devel] [PATCH v4 2/4] mpegts: Stash original PTS for SCTE-35 sections for processing later

2023-08-10 Thread Kieran Kunhya
On Wed, 9 Aug 2023, 12:37 Devin Heitmueller, < devin.heitmuel...@ltnglobal.com> wrote: > eI have a separate patch which better tracks the > video PTS and uses that as the basis for specifying the SCTE-35 > timestamp value (and that's what I use in production). I will be > looking to submit that

Re: [FFmpeg-devel] [PATCH v2] avcodec/mv30: Check the input length before allocation

2023-08-10 Thread Paul B Mahol
On Thu, Aug 10, 2023 at 11:34 AM Michael Niedermayer wrote: > On Wed, Aug 09, 2023 at 11:20:43PM +0200, Paul B Mahol wrote: > > On Wed, Aug 9, 2023 at 9:30 PM Michael Niedermayer < > mich...@niedermayer.cc> > > wrote: > > > > > Hi Paul > > > > > > On Wed, Aug 09, 2023 at 08:53:03PM +0200, Paul B

Re: [FFmpeg-devel] [PATCH] new audio filter and misc improvements

2023-08-10 Thread Paul B Mahol
On Thu, Aug 10, 2023 at 11:48 AM Michael Niedermayer wrote: > On Wed, Aug 09, 2023 at 11:36:16PM +0200, Paul B Mahol wrote: > > Patches attached. > > > af_adeclick.c |7 --- > > 1 file changed, 4 insertions(+), 3 deletions(-) > > b19bd0c3f05d5ebce92f7500dab61bd85d9b3661 >

Re: [FFmpeg-devel] [PATCH] new audio filter and misc improvements

2023-08-10 Thread Michael Niedermayer
On Wed, Aug 09, 2023 at 11:36:16PM +0200, Paul B Mahol wrote: > Patches attached. > af_adeclick.c |7 --- > 1 file changed, 4 insertions(+), 3 deletions(-) > b19bd0c3f05d5ebce92f7500dab61bd85d9b3661 > 0003-avfilter-af_adeclick-do-not-output-pointless-message.patch > From

Re: [FFmpeg-devel] [PATCH v2] avcodec/mv30: Check the input length before allocation

2023-08-10 Thread Michael Niedermayer
On Wed, Aug 09, 2023 at 11:20:43PM +0200, Paul B Mahol wrote: > On Wed, Aug 9, 2023 at 9:30 PM Michael Niedermayer > wrote: > > > Hi Paul > > > > On Wed, Aug 09, 2023 at 08:53:03PM +0200, Paul B Mahol wrote: > > > This is not correct, and please stop writing such patches. Thanks. > > > > If

Re: [FFmpeg-devel] [PATCH v1 1/1] lavc/qsvenc: disable SEI frame before each P-frame

2023-08-10 Thread Xiang, Haihao
Hi, How can I disable SEI frame? Is there any other option? You may use option -scenario to indicate the scenario for the encoding session, but I'm not sure whether your runtime has the optimization for SEI. Thanks Haihao 获取 Outlook for iOS

Re: [FFmpeg-devel] [PATCH 06/15] avformat/matroskaenc: Hoist check out of loop

2023-08-10 Thread Andreas Rheinhardt
Andreas Rheinhardt: > Signed-off-by: Andreas Rheinhardt > --- > libavformat/matroskaenc.c | 8 ++-- > 1 file changed, 6 insertions(+), 2 deletions(-) > > diff --git a/libavformat/matroskaenc.c b/libavformat/matroskaenc.c > index be70e7a6f1..d9bc31daee 100644 > ---

[FFmpeg-devel] [PATCH] lavc/qsvenc: return error with zero output

2023-08-10 Thread Xiang, Haihao
From: Haihao Xiang Signed-off-by: Haihao Xiang --- libavcodec/qsvenc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavcodec/qsvenc.c b/libavcodec/qsvenc.c index 7ff9d333a2..b3b7475b0f 100644 --- a/libavcodec/qsvenc.c +++ b/libavcodec/qsvenc.c @@ -2584,7 +2584,7 @@ int

[FFmpeg-devel] [PATCH v3] lavu/hwcontext_vaapi: Add vaapi_drm_format_map support for x2rgb10

2023-08-10 Thread David Rosca
Support for allocating frames with x2rgb10 format was added in c00264f5013, this adds support for importing DMA-BUFs. --- v2: fix #ifdef -> #if v3: annotate libavutil/hwcontext_vaapi.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/libavutil/hwcontext_vaapi.c