Re: [FFmpeg-devel] [PATCH 1/3] lavc/vp8dsp: R-V V put_bilin_h

2024-02-23 Thread Rémi Denis-Courmont
Hi, Le 24 février 2024 03:07:36 GMT+02:00, flow gg a écrit : > .ifc \len,4 >-vsetivlizero, 5, e8, mf2, ta, ma >+vsetivlizero, 5, e8, m1, ta, ma > .elseif \len == 8 > vsetivlizero, 9, e8, m1, ta, ma > .else >@@ -112,9 +112,9 @@ endfunc >

Re: [FFmpeg-devel] [PATCH 1/4] fftools/ffprobe: Don't cast const away needlessly

2024-02-23 Thread Andreas Rheinhardt
Andreas Rheinhardt: > Signed-off-by: Andreas Rheinhardt > --- > fftools/ffprobe.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/fftools/ffprobe.c b/fftools/ffprobe.c > index aa1153e709..95643f9a23 100644 > --- a/fftools/ffprobe.c > +++ b/fftools/ffprobe.c > @@ -789,7

Re: [FFmpeg-devel] [PATCH 1/3] avcodec/cbs_h266_syntax_template: Don't omit unused function parameter

2024-02-23 Thread Andreas Rheinhardt
Andreas Rheinhardt: > The calls to the sei_decoded_picture_hash read and write functions > are performed with four pointer arguments; just because one > of them is unused by the callees does not mean that they > can be omitted: This is undefined behaviour. > (This was not recognized because the

Re: [FFmpeg-devel] [PATCH 1/3] lavc/vp8dsp: R-V V put_bilin_h

2024-02-23 Thread flow gg
.ifc \len,4 -vsetivlizero, 5, e8, mf2, ta, ma +vsetivlizero, 5, e8, m1, ta, ma .elseif \len == 8 vsetivlizero, 9, e8, m1, ta, ma .else @@ -112,9 +112,9 @@ endfunc vslide1down.vx v2, \dst, t5 .ifc \len,4 -vsetivlizero,

Re: [FFmpeg-devel] [PATCH] Set native order for wav channel layouts up until 8 channels.

2024-02-23 Thread James Almer
On 2/23/2024 7:32 PM, Romain Beauxis wrote: Le ven. 23 févr. 2024 à 15:11, Marton Balint a écrit : On Fri, 23 Feb 2024, Romain Beauxis wrote: The new default channel layout for the various RIFF/WAV decoders is not backward compatible. Historically, most decoders will expect the channel

Re: [FFmpeg-devel] [RFC] clarifying the TC conflict of interest rule

2024-02-23 Thread Michael Niedermayer
On Thu, Feb 22, 2024 at 10:14:20PM +0100, Anton Khirnov wrote: > Quoting Niklas Haas (2024-02-20 21:50:33) > > On Tue, 20 Feb 2024 09:50:33 +0100 Anton Khirnov wrote: > > > + Each TC member must vote on such decision according to what is, in their > > > + view, best for the project. If a TC

[FFmpeg-devel] [PATCH] avcodec/libsvtav1: send the EOS signal without a one frame delay to allow for the library to operate in a low-delay mode

2024-02-23 Thread Cosmin Stejerean via ffmpeg-devel
From: Cosmin Stejerean Co-authored-by: Amir Naghdinezhad Signed-off-by: Cosmin Stejerean --- libavcodec/libsvtav1.c | 10 ++ 1 file changed, 10 insertions(+) diff --git a/libavcodec/libsvtav1.c b/libavcodec/libsvtav1.c index 3b41f5a39e..1eda63200c 100644 --- a/libavcodec/libsvtav1.c

Re: [FFmpeg-devel] [PATCH] Set native order for wav channel layouts up until 8 channels.

2024-02-23 Thread Marton Balint
On Fri, 23 Feb 2024, Romain Beauxis wrote: Le ven. 23 févr. 2024 à 15:11, Marton Balint a écrit : On Fri, 23 Feb 2024, Romain Beauxis wrote: > The new default channel layout for the various RIFF/WAV decoders is not > backward compatible. > > Historically, most decoders will expect the

Re: [FFmpeg-devel] [PATCH 14/38] lavu/opt: factor per-type dispatch out of av_opt_set()

2024-02-23 Thread Michael Niedermayer
Hi Anton On Fri, Feb 23, 2024 at 02:58:36PM +0100, Anton Khirnov wrote: > Will be useful in following commits. > --- breaks: ./ffmpeg -y -request_channel_layout 3 -i bug/401/mlp_5point1_downmixof6channel.mlp -bitexact file-2-mlp_5point1_downmixof6channel.wav [mlp @ 0x55690e23ff80] Error

Re: [FFmpeg-devel] [PATCH] libavutil/timestamp.h: Fix loss of precision in timestamps for silencedetect on long files

2024-02-23 Thread Marton Balint
On Fri, 23 Feb 2024, Allan Cady via ffmpeg-devel wrote: [Apologies for the awful mess in the previous email. Trying again with straight text.] On Thursday, February 22, 2024 at 01:16:19 AM PST, Marton Balint wrote: For starters, I'm curious why there are two functions & macros:

Re: [FFmpeg-devel] [PATCH] Set native order for wav channel layouts up until 8 channels.

2024-02-23 Thread Romain Beauxis
Le ven. 23 févr. 2024 à 15:11, Marton Balint a écrit : > > > > On Fri, 23 Feb 2024, Romain Beauxis wrote: > > > The new default channel layout for the various RIFF/WAV decoders is not > > backward compatible. > > > > Historically, most decoders will expect the channel layouts to follow > > the

Re: [FFmpeg-devel] [PATCH] libavutil/timestamp.h: Fix loss of precision in timestamps for silencedetect on long files

2024-02-23 Thread Allan Cady via ffmpeg-devel
[Apologies for the awful mess in the previous email. Trying again with straight text.] On Thursday, February 22, 2024 at 01:16:19 AM PST, Marton Balint wrote: >> For starters, I'm curious why there are two functions & macros: >> >> av_ts2str/av_ts_make_string (which used "%" format specifier)

Re: [FFmpeg-devel] [PATCH] libavutil/timestamp.h: Fix loss of precision in timestamps for silencedetect on long files

2024-02-23 Thread Allan Cady via ffmpeg-devel
On Thursday, February 22, 2024 at 01:16:19 AM PST, Marton Balint wrote: >> For starters, I'm curious why there are two functions & macros: >> av_ts2str/av_ts_make_string (which used "%" format specifier)> > That takes >> a 64-bit integer timestamp and is actually using "%"PRId64 >

Re: [FFmpeg-devel] [PATCH] Set native order for wav channel layouts up until 8 channels.

2024-02-23 Thread Marton Balint
On Fri, 23 Feb 2024, Romain Beauxis wrote: The new default channel layout for the various RIFF/WAV decoders is not backward compatible. Historically, most decoders will expect the channel layouts to follow the native layout up-to a reasonable number of channels. Additionally, non-native

[FFmpeg-devel] [PATCH] Set native order for wav channel layouts up until 8 channels.

2024-02-23 Thread Romain Beauxis
The new default channel layout for the various RIFF/WAV decoders is not backward compatible. Historically, most decoders will expect the channel layouts to follow the native layout up-to a reasonable number of channels. Additionally, non-native layouts are causing troubles with filters chaining.

Re: [FFmpeg-devel] [REFUND-REQUEST] FOSDEM 2024

2024-02-23 Thread Stefano Sabatini
Il ven 23 feb 2024, 11:00 J. Dekker ha scritto: > Hi, > > I attended FOSDEM for ffmpeg and would like to request travel > reimbursement. > > Flight | 162,46 EUR > === > Total | 162,46 EUR > Looks good on my side, but keep in mind you can also ask accomodation expenses refund if you

Re: [FFmpeg-devel] [PATCH] avformat/mxfenc: add h264_mp4toannexb bitstream filter if needed when muxing h264

2024-02-23 Thread Marton Balint
On Fri, 23 Feb 2024, Andreas Rheinhardt wrote: Marton Balint: Partially fixes ticket #10395. Signed-off-by: Marton Balint --- libavformat/mxfenc.c | 12 1 file changed, 12 insertions(+) diff --git a/libavformat/mxfenc.c b/libavformat/mxfenc.c index 61ed6fc3db..adc31c1cf4

Re: [FFmpeg-devel] [RFC] clarifying the TC conflict of interest rule

2024-02-23 Thread Ronald S. Bultje
Hi Nicolas On Fri, Feb 23, 2024 at 2:56 AM Nicolas George wrote: > Anton Khirnov (12024-02-22): > > In my updated proposal, based on comments by Niklas and Rémi, I'm > > leaving it up to the TC member in question, based on the assumption that > > TC members are honest. > > > > A "stronger"

[FFmpeg-devel] [PATCH] configure: Disable linker warnings for common symbols

2024-02-23 Thread Andreas Rheinhardt
Common symbols are not part of ISO-C and therefore not used by FFmpeg at all. Yet linker warnings to ensure it stays that way are nevertheless wrong, because the existence of common symbols does not imply that there is a bug in our code. More precisely, Clang's ASAN implementation uses a common

Re: [FFmpeg-devel] [PATCH 23/38] avcodec/hevcdec: respect side data preference

2024-02-23 Thread Marton Balint
On Fri, 23 Feb 2024, Anton Khirnov wrote: From: Niklas Haas If the time code side data is overridden by the packet level, we also make sure not to update `out->metadata` to a mismatched timecode. For HDR side data, we unfortunately need to omit a return check because the new function does

Re: [FFmpeg-devel] [PATCH v3 1/2] lavu/hashtable: create generic robin hood hash table

2024-02-23 Thread Michael Niedermayer
On Wed, Feb 21, 2024 at 05:09:21PM -0800, Connor Worley wrote: > Signed-off-by: Connor Worley > --- > libavutil/Makefile | 2 + > libavutil/hashtable.c | 192 > libavutil/hashtable.h | 40 > libavutil/tests/hashtable.c | 108

Re: [FFmpeg-devel] [PATCH 15/38] lavu/opt: add array options

2024-02-23 Thread Marton Balint
On Fri, 23 Feb 2024, Anton Khirnov wrote: AVOption.array_max_size is added before AVOption.unit to avoid increasing sizeof(AVOption). --- doc/APIchanges| 3 + libavutil/opt.c | 344 -- libavutil/opt.h | 26

Re: [FFmpeg-devel] [PATCH 16/38] lavc: add a decoder option for configuring side data preference

2024-02-23 Thread James Almer
On 2/23/2024 2:53 PM, James Almer wrote: On 2/23/2024 2:51 PM, Marton Balint wrote: On Fri, 23 Feb 2024, Anton Khirnov wrote: This and the following commits fix #10857 --- doc/APIchanges |  3 +++ libavcodec/avcodec.h   | 20 libavcodec/decode.c    |

Re: [FFmpeg-devel] [PATCH 16/38] lavc: add a decoder option for configuring side data preference

2024-02-23 Thread James Almer
On 2/23/2024 2:51 PM, Marton Balint wrote: On Fri, 23 Feb 2024, Anton Khirnov wrote: This and the following commits fix #10857 --- doc/APIchanges |  3 +++ libavcodec/avcodec.h   | 20 libavcodec/decode.c    | 36

Re: [FFmpeg-devel] [PATCH 16/38] lavc: add a decoder option for configuring side data preference

2024-02-23 Thread Marton Balint
On Fri, 23 Feb 2024, Anton Khirnov wrote: This and the following commits fix #10857 --- doc/APIchanges | 3 +++ libavcodec/avcodec.h | 20 libavcodec/decode.c| 36 libavcodec/options_table.h | 12 4

Re: [FFmpeg-devel] [PATCH] hwcontext_videotoolbox: add vt_device_derive

2024-02-23 Thread Gnattu OC via ffmpeg-devel
I’ve tested and confirmed to work, and `reverse=1` also works for chaining to other videotoolbox filters. > On Feb 23, 2024, at 22:25, Zhao Zhili wrote: > > ___ > ffmpeg-devel mailing list > ffmpeg-devel@ffmpeg.org >

Re: [FFmpeg-devel] [PATCH 1/3] lavc/vp8dsp: R-V V put_bilin_h

2024-02-23 Thread Rémi Denis-Courmont
Hi, + +.macro bilin_h_load dst len +.ifc \len,4 +vsetivlizero, 5, e8, mf2, ta, ma Don't use fractional multipliers if you don't mix element widths. +.elseif \len == 8 +vsetivlizero, 9, e8, m1, ta, ma +.else +vsetivlizero, 17, e8, m2, ta, ma

Re: [FFmpeg-devel] [RFC] clarifying the TC conflict of interest rule

2024-02-23 Thread Anton Khirnov
Quoting Michael Niedermayer (2024-02-23 15:00:24) > On Tue, Feb 20, 2024 at 09:22:57AM +0100, Anton Khirnov wrote: > > Hi, > > in the 'avcodec/s302m: enable non-PCM decoding' thread it became > > apparent that there is wide disagreement about the interpretation of > > this line in the TC rules: >

Re: [FFmpeg-devel] [RFC] clarifying the TC conflict of interest rule

2024-02-23 Thread Anton Khirnov
Quoting Zhao Zhili (2024-02-23 15:52:50) > > > 在 2024年2月23日,下午7:26,Gyan Doshi 写道: > > > >  > > > >> On 2024-02-23 01:26 pm, Nicolas George wrote: > >> Anton Khirnov (12024-02-22): > >>> In my updated proposal, based on comments by Niklas and Rémi, I'm > >>> leaving it up to the TC member in

Re: [FFmpeg-devel] [PATCH 38/38] tests/fate/matroska: add tests for side data preference

2024-02-23 Thread James Almer
On 2/23/2024 12:02 PM, Anton Khirnov wrote: Quoting Anton Khirnov (2024-02-23 14:59:00) +fate-matroska-side-data-pref-codec: CMD = run ffprobe$(PROGSSUF)$(EXESUF) $(TARGET_SAMPLES)/mkv/hdr10tags-both.mkv \ Please upload

Re: [FFmpeg-devel] [PATCH v2 3/5] avutil/hwcontext_vulkan: Fix leaks when semaphore creation fails

2024-02-23 Thread Lynne
Feb 22, 2024, 15:43 by quinkbl...@foxmail.com: > From: Zhao Zhili > > --- > libavutil/hwcontext_vulkan.c | 27 +-- > 1 file changed, 17 insertions(+), 10 deletions(-) > LGTM on all Vulkan patches you posted. ___ ffmpeg-devel

Re: [FFmpeg-devel] [PATCH 38/38] tests/fate/matroska: add tests for side data preference

2024-02-23 Thread Anton Khirnov
Quoting Anton Khirnov (2024-02-23 14:59:00) > +fate-matroska-side-data-pref-codec: CMD = run ffprobe$(PROGSSUF)$(EXESUF) > $(TARGET_SAMPLES)/mkv/hdr10tags-both.mkv \ Please upload https://ups.khirnov.net/92f7f28810e0d34af917dba853a5056d1d8001182f5ffb70c7d14fb72ec58fa4/hdr10tags-both.mkv to

Re: [FFmpeg-devel] [RFC] clarifying the TC conflict of interest rule

2024-02-23 Thread Zhao Zhili
> 在 2024年2月23日,下午7:26,Gyan Doshi 写道: > >  > >> On 2024-02-23 01:26 pm, Nicolas George wrote: >> Anton Khirnov (12024-02-22): >>> In my updated proposal, based on comments by Niklas and Rémi, I'm >>> leaving it up to the TC member in question, based on the assumption that >>> TC members are

[FFmpeg-devel] [PATCH 3/3] lavc/vp8dsp: R-V V put_bilin_hv

2024-02-23 Thread flow gg
From e1a01b1e0a365935868d7825d53c7cc64e2c1787 Mon Sep 17 00:00:00 2001 From: sunyuechi Date: Fri, 23 Feb 2024 22:35:23 +0800 Subject: [PATCH 3/3] lavc/vp8dsp: R-V V put_bilin_hv C908: vp8_put_bilin4_hv_c: 567.7 vp8_put_bilin4_hv_rvv_i32: 255.7 vp8_put_bilin8_hv_c: 2169.5

[FFmpeg-devel] [PATCH 2/3] lavc/vp8dsp: R-V V put_bilin_v

2024-02-23 Thread flow gg
From 488d0cd6645b2c6936c3298e010615facb6d0bd0 Mon Sep 17 00:00:00 2001 From: sunyuechi Date: Fri, 23 Feb 2024 22:35:01 +0800 Subject: [PATCH 2/3] lavc/vp8dsp: R-V V put_bilin_v C908: vp8_put_bilin4_v_c: 383.5 vp8_put_bilin4_v_rvv_i32: 139.7 vp8_put_bilin8_v_c: 1455.7 vp8_put_bilin8_v_rvv_i32:

[FFmpeg-devel] [PATCH 1/3] lavc/vp8dsp: R-V V put_bilin_h

2024-02-23 Thread flow gg
From b773a2b640ba38a106539da7f3414d6892364c4f Mon Sep 17 00:00:00 2001 From: sunyuechi Date: Fri, 23 Feb 2024 13:27:42 +0800 Subject: [PATCH 1/3] lavc/vp8dsp: R-V V put_bilin_h C908: vp8_put_bilin4_h_c: 373.5 vp8_put_bilin4_h_rvv_i32: 158.7 vp8_put_bilin8_h_c: 1437.7 vp8_put_bilin8_h_rvv_i32:

[FFmpeg-devel] [PATCH 04/38] lavu/opt: cosmetics, group (un)init and management functions together

2024-02-23 Thread Anton Khirnov
--- libavutil/opt.h | 336 +--- 1 file changed, 173 insertions(+), 163 deletions(-) diff --git a/libavutil/opt.h b/libavutil/opt.h index d72d65052f..e2b6ba1f35 100644 --- a/libavutil/opt.h +++ b/libavutil/opt.h @@ -402,15 +402,9 @@ typedef struct

[FFmpeg-devel] [PATCH 34/38] avcodec/snowdec: use ff_frame_new_side_data

2024-02-23 Thread Anton Khirnov
From: Niklas Haas For consistency, even though this cannot be overriden at the packet level. --- libavcodec/snowdec.c | 9 - 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/libavcodec/snowdec.c b/libavcodec/snowdec.c index 70fbab9a49..97aea748b6 100644 ---

[FFmpeg-devel] [PATCH 35/38] avcodec/mjpegdec: use ff_frame_new_side_data

2024-02-23 Thread Anton Khirnov
From: Niklas Haas For consistency, even though this can't (yet) be overriden at the packet level. --- libavcodec/mjpegdec.c | 66 ++- 1 file changed, 34 insertions(+), 32 deletions(-) diff --git a/libavcodec/mjpegdec.c b/libavcodec/mjpegdec.c index

[FFmpeg-devel] [PATCH 03/38] lavu/opt: document AVOption.flags

2024-02-23 Thread Anton Khirnov
--- libavutil/opt.h | 3 +++ 1 file changed, 3 insertions(+) diff --git a/libavutil/opt.h b/libavutil/opt.h index 36e28249ee..d72d65052f 100644 --- a/libavutil/opt.h +++ b/libavutil/opt.h @@ -320,6 +320,9 @@ typedef struct AVOption { double min; ///< minimum valid value for

[FFmpeg-devel] [PATCH 07/38] lavu/opt: simplify printing option type in opt_list()

2024-02-23 Thread Anton Khirnov
--- libavutil/opt.c | 107 +--- 1 file changed, 37 insertions(+), 70 deletions(-) diff --git a/libavutil/opt.c b/libavutil/opt.c index d13b1ab504..554916fbaf 100644 --- a/libavutil/opt.c +++ b/libavutil/opt.c @@ -1231,6 +1231,41 @@ static char

[FFmpeg-devel] [PATCH 08/38] lavu/opt: factor out printing option default from opt_list()

2024-02-23 Thread Anton Khirnov
--- libavutil/opt.c | 150 +--- 1 file changed, 78 insertions(+), 72 deletions(-) diff --git a/libavutil/opt.c b/libavutil/opt.c index 554916fbaf..49b7da7742 100644 --- a/libavutil/opt.c +++ b/libavutil/opt.c @@ -1266,6 +1266,83 @@ static void

[FFmpeg-devel] [PATCH 37/38] lavc/*dec: use side data preference for mastering display/content light metadata

2024-02-23 Thread Anton Khirnov
--- libavcodec/av1dec.c| 46 +++- libavcodec/h2645_sei.c | 96 +++--- libavcodec/libdav1d.c | 47 - libavcodec/pngdec.c| 54 ++-- libavcodec/qsvdec.c| 50 +- 5 files

[FFmpeg-devel] [PATCH 19/38] avcodec/av1dec: respect side data preference

2024-02-23 Thread Anton Khirnov
From: Niklas Haas --- libavcodec/av1dec.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavcodec/av1dec.c b/libavcodec/av1dec.c index 7debc4deda..4fcfed3c7b 100644 --- a/libavcodec/av1dec.c +++ b/libavcodec/av1dec.c @@ -946,7 +946,7 @@ static int

[FFmpeg-devel] [PATCH 38/38] tests/fate/matroska: add tests for side data preference

2024-02-23 Thread Anton Khirnov
Cf. #10857 --- tests/fate/matroska.mak | 6 + tests/ref/fate/matroska-side-data-pref-codec | 255 ++ tests/ref/fate/matroska-side-data-pref-global | 255 ++ 3 files changed, 516 insertions(+) create mode 100644

[FFmpeg-devel] [PATCH 27/38] avcodec/pngdec: respect side data preference

2024-02-23 Thread Anton Khirnov
From: Niklas Haas --- libavcodec/pngdec.c | 15 ++- 1 file changed, 10 insertions(+), 5 deletions(-) diff --git a/libavcodec/pngdec.c b/libavcodec/pngdec.c index 026da30c25..8f409c74b8 100644 --- a/libavcodec/pngdec.c +++ b/libavcodec/pngdec.c @@ -660,6 +660,7 @@ static int

[FFmpeg-devel] [PATCH 28/38] avcodec/tiff: respect side data preference

2024-02-23 Thread Anton Khirnov
From: Niklas Haas --- libavcodec/tiff.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/libavcodec/tiff.c b/libavcodec/tiff.c index 71cb703821..cb4d378753 100644 --- a/libavcodec/tiff.c +++ b/libavcodec/tiff.c @@ -1706,11 +1706,11 @@ static int

[FFmpeg-devel] [PATCH 20/38] avcodec/cri: respect side data preference

2024-02-23 Thread Anton Khirnov
From: Niklas Haas This function was already ignoring OOM errors. --- libavcodec/cri.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/libavcodec/cri.c b/libavcodec/cri.c index c4eb468610..990e52ac99 100644 --- a/libavcodec/cri.c +++ b/libavcodec/cri.c @@ -398,8 +398,8 @@

[FFmpeg-devel] [PATCH 31/38] avcodec/dpx: respect side data preference

2024-02-23 Thread Anton Khirnov
From: Niklas Haas If the time code side data is overridden by the packet level, we also make sure not to update `p->metadata` to a mismatched timecode. --- libavcodec/dpx.c | 24 +--- 1 file changed, 13 insertions(+), 11 deletions(-) diff --git a/libavcodec/dpx.c

[FFmpeg-devel] [PATCH 14/38] lavu/opt: factor per-type dispatch out of av_opt_set()

2024-02-23 Thread Anton Khirnov
Will be useful in following commits. --- libavutil/opt.c | 35 ++- 1 file changed, 22 insertions(+), 13 deletions(-) diff --git a/libavutil/opt.c b/libavutil/opt.c index 0ca6d4d555..ebc8063dc6 100644 --- a/libavutil/opt.c +++ b/libavutil/opt.c @@ -484,13 +484,11

[FFmpeg-devel] [PATCH 32/38] avcodec/mpeg12dec: use ff_frame_new_side_data

2024-02-23 Thread Anton Khirnov
From: Niklas Haas For consistency, even though this cannot be overriden at the packet level. --- libavcodec/mpeg12dec.c | 18 ++ 1 file changed, 10 insertions(+), 8 deletions(-) diff --git a/libavcodec/mpeg12dec.c b/libavcodec/mpeg12dec.c index 96987f5a8e..1038a08637 100644 ---

[FFmpeg-devel] [PATCH 29/38] avcodec/webp: respect side data preference

2024-02-23 Thread Anton Khirnov
From: Niklas Haas --- libavcodec/webp.c | 13 + 1 file changed, 9 insertions(+), 4 deletions(-) diff --git a/libavcodec/webp.c b/libavcodec/webp.c index 54b3fde6dc..9308ea2b69 100644 --- a/libavcodec/webp.c +++ b/libavcodec/webp.c @@ -1500,11 +1500,16 @@ exif_end:

[FFmpeg-devel] [PATCH 22/38] lavc/hevcdec: pass an actual codec context to ff_h2645_sei_to_frame()

2024-02-23 Thread Anton Khirnov
Needed by following commit. --- libavcodec/hevcdec.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavcodec/hevcdec.c b/libavcodec/hevcdec.c index b5311ae510..17c6a9212f 100644 --- a/libavcodec/hevcdec.c +++ b/libavcodec/hevcdec.c @@ -2778,7 +2778,7 @@ static int

[FFmpeg-devel] [PATCH 30/38] avcodec/libdav1d: respect side data preference

2024-02-23 Thread Anton Khirnov
From: Niklas Haas --- libavcodec/libdav1d.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavcodec/libdav1d.c b/libavcodec/libdav1d.c index 78a5c63bf4..f002c994c1 100644 --- a/libavcodec/libdav1d.c +++ b/libavcodec/libdav1d.c @@ -561,7 +561,7 @@

[FFmpeg-devel] [PATCH 21/38] avcodec/h264_slice: respect side data preference

2024-02-23 Thread Anton Khirnov
From: Niklas Haas If the time code side data is overridden by the packet level, we also make sure not to update `out->metadata` to a mismatched timecode. --- libavcodec/h264_slice.c | 35 ++- 1 file changed, 18 insertions(+), 17 deletions(-) diff --git

[FFmpeg-devel] [PATCH 17/38] avcodec: add internal side data wrappers

2024-02-23 Thread Anton Khirnov
From: Niklas Haas The signature of ff_frame_new_side_data got more complicated due to a need to distinguish between "failed allocating side data" and "side data was already present". We could do something similar to ff_frame_new_side_data_from_buf, but most callers ignore the OOM condition on

[FFmpeg-devel] [PATCH 33/38] avcodec/h2645_sei: use ff_frame_new_side_data_from_buf

2024-02-23 Thread Anton Khirnov
From: Niklas Haas For consistency, even though this cannot be overriden at the packet level. Signed-off-by: Anton Khirnov --- libavcodec/h2645_sei.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/libavcodec/h2645_sei.c b/libavcodec/h2645_sei.c index

[FFmpeg-devel] [PATCH 24/38] avcodec/libjxldec: respect side data preference

2024-02-23 Thread Anton Khirnov
From: Niklas Haas Also fixes a memory leak where the side data was previously not properly cleaned up on OOM, although we now unfortunately don't distinguish between OOM and overriden side data. Signed-off-by: Anton Khirnov --- libavcodec/libjxldec.c | 4 ++-- 1 file changed, 2 insertions(+),

[FFmpeg-devel] [PATCH 18/38] lavc: add content light/mastering display side data wrappers

2024-02-23 Thread Anton Khirnov
--- libavcodec/decode.c | 25 + libavcodec/decode.h | 21 + 2 files changed, 46 insertions(+) diff --git a/libavcodec/decode.c b/libavcodec/decode.c index 10946f208a..ad5525860c 100644 --- a/libavcodec/decode.c +++ b/libavcodec/decode.c @@ -35,6 +35,7

[FFmpeg-devel] [PATCH 16/38] lavc: add a decoder option for configuring side data preference

2024-02-23 Thread Anton Khirnov
This and the following commits fix #10857 --- doc/APIchanges | 3 +++ libavcodec/avcodec.h | 20 libavcodec/decode.c| 36 libavcodec/options_table.h | 12 4 files changed, 71 insertions(+) diff

[FFmpeg-devel] [PATCH 26/38] avcodec/mpeg12dec: respect side data preference

2024-02-23 Thread Anton Khirnov
From: Niklas Haas We only need to consider side data types that may possibly come from the packet. --- libavcodec/mpeg12dec.c | 31 --- 1 file changed, 16 insertions(+), 15 deletions(-) diff --git a/libavcodec/mpeg12dec.c b/libavcodec/mpeg12dec.c index

[FFmpeg-devel] [PATCH 23/38] avcodec/hevcdec: respect side data preference

2024-02-23 Thread Anton Khirnov
From: Niklas Haas If the time code side data is overridden by the packet level, we also make sure not to update `out->metadata` to a mismatched timecode. For HDR side data, we unfortunately need to omit a return check because the new function does not distinguish between OOM and overridden side

[FFmpeg-devel] [PATCH 36/38] avcodec/hevcdec: switch to ff_frame_new_side_data_from_buf

2024-02-23 Thread Anton Khirnov
From: Niklas Haas For consistency, even though this cannot be overriden at the packet level. --- libavcodec/hevcdec.c | 10 +++--- 1 file changed, 3 insertions(+), 7 deletions(-) diff --git a/libavcodec/hevcdec.c b/libavcodec/hevcdec.c index 0cb2577b39..e5213aa252 100644 ---

[FFmpeg-devel] [PATCH 13/38] lavu/opt: factor per-type dispatch out of av_opt_get()

2024-02-23 Thread Anton Khirnov
Will be useful in following commits. --- libavutil/opt.c | 220 ++-- 1 file changed, 121 insertions(+), 99 deletions(-) diff --git a/libavutil/opt.c b/libavutil/opt.c index 8ee89237c5..0ca6d4d555 100644 --- a/libavutil/opt.c +++ b/libavutil/opt.c @@

[FFmpeg-devel] [PATCH 25/38] avcodec/mjpegdec: respect side data preference

2024-02-23 Thread Anton Khirnov
From: Niklas Haas --- libavcodec/mjpegdec.c | 16 +--- 1 file changed, 9 insertions(+), 7 deletions(-) diff --git a/libavcodec/mjpegdec.c b/libavcodec/mjpegdec.c index 81f724d230..43b36d0a8f 100644 --- a/libavcodec/mjpegdec.c +++ b/libavcodec/mjpegdec.c @@ -2840,16 +2840,18 @@

[FFmpeg-devel] [PATCH 12/38] lavu/opt: get rid of useless read_number() calls

2024-02-23 Thread Anton Khirnov
The option type is known and fixed for all these, so reading the value directly is simpler and more clear. --- libavutil/opt.c | 13 + 1 file changed, 5 insertions(+), 8 deletions(-) diff --git a/libavutil/opt.c b/libavutil/opt.c index 75a27c4d9b..8ee89237c5 100644 ---

[FFmpeg-devel] [PATCH 06/38] lavu/opt: cosmetics, group option reading function together

2024-02-23 Thread Anton Khirnov
--- libavutil/opt.h | 82 +++-- 1 file changed, 46 insertions(+), 36 deletions(-) diff --git a/libavutil/opt.h b/libavutil/opt.h index 6ed19888a5..e34b8506f8 100644 --- a/libavutil/opt.h +++ b/libavutil/opt.h @@ -755,6 +755,11 @@ int

[FFmpeg-devel] [PATCH 09/38] lavu/opt: drop useless handling of NULL return from get_bool_name()

2024-02-23 Thread Anton Khirnov
That function always returns an actual string. --- libavutil/opt.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/libavutil/opt.c b/libavutil/opt.c index 49b7da7742..0ffdfc9a1e 100644 --- a/libavutil/opt.c +++ b/libavutil/opt.c @@ -853,7 +853,7 @@ int av_opt_get(void

[FFmpeg-devel] [PATCH 15/38] lavu/opt: add array options

2024-02-23 Thread Anton Khirnov
AVOption.array_max_size is added before AVOption.unit to avoid increasing sizeof(AVOption). --- doc/APIchanges| 3 + libavutil/opt.c | 344 -- libavutil/opt.h | 26 libavutil/tests/opt.c | 34 + tests/ref/fate/opt| 23

[FFmpeg-devel] [PATCH 11/38] lavu/opt: simplify error handling in get_number()

2024-02-23 Thread Anton Khirnov
--- libavutil/opt.c | 7 +-- 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/libavutil/opt.c b/libavutil/opt.c index 54a99c689c..75a27c4d9b 100644 --- a/libavutil/opt.c +++ b/libavutil/opt.c @@ -961,16 +961,11 @@ static int get_number(void *obj, const char *name, double *num,

[FFmpeg-devel] [PATCH 05/38] lavu/opt: cosmetics, group option setting function together

2024-02-23 Thread Anton Khirnov
--- libavutil/opt.h | 102 +--- 1 file changed, 54 insertions(+), 48 deletions(-) diff --git a/libavutil/opt.h b/libavutil/opt.h index e2b6ba1f35..6ed19888a5 100644 --- a/libavutil/opt.h +++ b/libavutil/opt.h @@ -576,6 +576,11 @@ enum { * @} */

[FFmpeg-devel] [PATCH 10/38] lavu/opt: drop an always-NULL argument to get_number()

2024-02-23 Thread Anton Khirnov
--- libavutil/opt.c | 12 +--- 1 file changed, 5 insertions(+), 7 deletions(-) diff --git a/libavutil/opt.c b/libavutil/opt.c index 0ffdfc9a1e..54a99c689c 100644 --- a/libavutil/opt.c +++ b/libavutil/opt.c @@ -955,7 +955,7 @@ FF_ENABLE_DEPRECATION_WARNINGS return *out_val ? 0 :

[FFmpeg-devel] [PATCH 02/38] lavu/opt: cosmetics, move AV_OPT_FLAG_* out of AVOption

2024-02-23 Thread Anton Khirnov
Also drop an obsolete FIXME. --- libavutil/opt.h | 69 - 1 file changed, 34 insertions(+), 35 deletions(-) diff --git a/libavutil/opt.h b/libavutil/opt.h index 6ed3407b09..36e28249ee 100644 --- a/libavutil/opt.h +++ b/libavutil/opt.h @@ -245,40

[FFmpeg-devel] [PATCH 01/38] lavu/opt: cosmetics, change option flags to (1 << N) style

2024-02-23 Thread Anton Khirnov
It is easier to read. Also, change their doxy comments to use the same style. --- libavutil/opt.h | 48 1 file changed, 36 insertions(+), 12 deletions(-) diff --git a/libavutil/opt.h b/libavutil/opt.h index 461b5d3b6b..6ed3407b09 100644 ---

[FFmpeg-devel] [PATCH] array AVOptions and side data preference

2024-02-23 Thread Anton Khirnov
Hi, this patchset implements a solution to the problem of side data precedence for lavc decoding, recently raised by Derek (#10857). The issue was caused by the recent addition of a mechanism for providing global side data (typically from the demuxer) to decoders, which will then propagate it to

Re: [FFmpeg-devel] [PATCH] hwcontext_videotoolbox: add vt_device_derive

2024-02-23 Thread Zhao Zhili
___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] [RFC] clarifying the TC conflict of interest rule

2024-02-23 Thread Michael Niedermayer
On Thu, Feb 22, 2024 at 10:54:56PM +0100, Anton Khirnov wrote: > Quoting Michael Niedermayer (2024-02-20 22:51:20) > > On Tue, Feb 20, 2024 at 09:12:11PM +, Cosmin Stejerean via ffmpeg-devel > > wrote: > > > > > > > > > > On Feb 20, 2024, at 12:41 PM, Michael Niedermayer > > > > wrote: >

Re: [FFmpeg-devel] [RFC] clarifying the TC conflict of interest rule

2024-02-23 Thread Nicolas George
Gyan Doshi (12024-02-23): > Just to be clear, that's not my basis. > > I said, > > "As a TC member who is part of the disagreement, I believe your > participation is recused." > > based on the existing rule, > > "If the disagreement involves a member of the TC, that member should recuse >

Re: [FFmpeg-devel] [RFC] clarifying the TC conflict of interest rule

2024-02-23 Thread Nicolas George
Michael Niedermayer (12024-02-23): > Each option should provide a patch. Fine. But the wording can be discussed too. Regards, -- Nicolas George >From 7955ed2c1074f85f0f55a58072a8623c8ff4bf34 Mon Sep 17 00:00:00 2001 From: Nicolas George Date: Fri, 23 Feb 2024 15:12:51 +0100 Subject: [PATCH]

[FFmpeg-devel] [PATCH 2/2] avutil/hwcontext_opencl: Add map from Videotoolbox to OpenCL

2024-02-23 Thread Zhao Zhili
From: Zhao Zhili For example: ./ffmpeg -hwaccel videotoolbox \ -hwaccel_output_format videotoolbox_vld \ -i foo.mp4 \ -vf hwmap=derive_device=opencl,transpose_opencl=dir=clock,hwmap,format=nv12 \ -c:v hevc_videotoolbox \ -c:a copy \ -b:v 2M -tag:v

[FFmpeg-devel] [PATCH 1/2] avutil/hwcontext_opencl: Fix missing linesize when map from opencl

2024-02-23 Thread Zhao Zhili
From: Zhao Zhili --- libavutil/hwcontext_opencl.c | 1 + 1 file changed, 1 insertion(+) diff --git a/libavutil/hwcontext_opencl.c b/libavutil/hwcontext_opencl.c index c1764ed098..de093fffb1 100644 --- a/libavutil/hwcontext_opencl.c +++ b/libavutil/hwcontext_opencl.c @@ -2014,6 +2014,7 @@

Re: [FFmpeg-devel] [PATCH v1] lavc/vvc_ps: Correct vaule of ALF_NUM_FILTERS_CC

2024-02-23 Thread Nuo Mi
applied, thank you Fei On Fri, Feb 23, 2024 at 2:27 PM wrote: > From: Fei Wang > > Signed-off-by: Fei Wang > --- > libavcodec/vvc/vvc_ps.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/libavcodec/vvc/vvc_ps.h b/libavcodec/vvc/vvc_ps.h > index 5adf3f3453..1164d0eab6

Re: [FFmpeg-devel] [RFC] clarifying the TC conflict of interest rule

2024-02-23 Thread Michael Niedermayer
On Tue, Feb 20, 2024 at 09:22:57AM +0100, Anton Khirnov wrote: > Hi, > in the 'avcodec/s302m: enable non-PCM decoding' thread it became > apparent that there is wide disagreement about the interpretation of > this line in the TC rules: > > > If the disagreement involves a member of the TC, that

[FFmpeg-devel] [PATCH] avcodec/evc: Reference to ISO_IEC_23094-1-2020 document section for EVC_MAX_APS_COUNT enum has been changed

2024-02-23 Thread Dawid Kozinski
Signed-off-by: Dawid Kozinski --- libavcodec/evc.h | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/libavcodec/evc.h b/libavcodec/evc.h index 9711c760fe..182a01f3d2 100644 --- a/libavcodec/evc.h +++ b/libavcodec/evc.h @@ -106,14 +106,14 @@ enum EVCSliceType { }; enum

Re: [FFmpeg-devel] [PATCH 11/11] avcodec/vvcdec: add Intra Block Copy decoder

2024-02-23 Thread Nuo Mi
On Thu, Feb 22, 2024 at 3:15 PM Nuo Mi wrote: > From: Wu Jianhua > > Introduction at https://ieeexplore.ieee.org/document/9408666 > > passed files: > 10b444_A_Kwai_3.bit > 10b444_B_Kwai_3.bit > CodingToolsSets_D_Tencent_2.bit > IBC_A_Tencent_2.bit > IBC_B_Tencent_2.bit >

Re: [FFmpeg-devel] [PATCH 1/2] avcodec/parser: fix fetch_timestamp in a scenario with unaligned packets

2024-02-23 Thread Nicolas Gaullier
>De : ffmpeg-devel De la part de Michael >Niedermayer >Envoyé : mercredi 21 février 2024 05:32 >On Tue, Feb 20, 2024 at 05:33:01PM +0100, Nicolas Gaullier wrote: >> Fix fetch_timestamp when the frame start is in a previous packet. >> >> Signed-off-by: Nicolas Gaullier >> --- >>

Re: [FFmpeg-devel] [PATCH 2/3] avcodec/x86: disable hevc 12b luma deblock

2024-02-23 Thread Nuo Mi
On Wed, Feb 21, 2024 at 7:10 PM J. Dekker wrote: > Over/underflow in some cases. > > Signed-off-by: J. Dekker > --- > libavcodec/x86/hevcdsp_init.c | 9 + > 1 file changed, 5 insertions(+), 4 deletions(-) > > diff --git a/libavcodec/x86/hevcdsp_init.c b/libavcodec/x86/hevcdsp_init.c >

[FFmpeg-devel] [PATCH 1/3] avcodec/h264_parser: fix start of packet for some broken streams

2024-02-23 Thread Nicolas Gaullier
--- libavcodec/h264_parser.c | 11 ++- 1 file changed, 10 insertions(+), 1 deletion(-) diff --git a/libavcodec/h264_parser.c b/libavcodec/h264_parser.c index 94cfbc481e..6b721ec253 100644 --- a/libavcodec/h264_parser.c +++ b/libavcodec/h264_parser.c @@ -124,7 +124,16 @@ static int

Re: [FFmpeg-devel] [RFC] clarifying the TC conflict of interest rule

2024-02-23 Thread Gyan Doshi
On 2024-02-23 01:26 pm, Nicolas George wrote: Anton Khirnov (12024-02-22): In my updated proposal, based on comments by Niklas and Rémi, I'm leaving it up to the TC member in question, based on the assumption that TC members are honest. A "stronger" version could conceivably leave it to CC

Re: [FFmpeg-devel] [PATCH v3] avfilter: add vf_overlay_videotoolbox

2024-02-23 Thread Gnattu OC via ffmpeg-devel
A ping for this. > On Feb 21, 2024, at 09:53, gnattu wrote: > > Overlay filter for VideoToolbox hwframes. Unlike most hardware > overlay filters, this filter does not require the two inputs to > have the same pixel format; instead, it will perform format > conversion automatically with hardware

[FFmpeg-devel] [REFUND-REQUEST] FOSDEM 2024

2024-02-23 Thread J. Dekker
Hi, I attended FOSDEM for ffmpeg and would like to request travel reimbursement. Flight | 162,46 EUR === Total | 162,46 EUR -- jd ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To