Re: [FFmpeg-devel] [PATCH 1/7] lavc/vp9dsp: R-V mc copy_avg

2024-03-26 Thread flow gg
Hi, here's the github link (https://github.com/hleft/FFmpeg/tree/vp8vp9) Rémi Denis-Courmont 于2024年3月27日周三 02:30写道: > Hi, > > Le perjantaina 22. maaliskuuta 2024, 8.12.41 EET flow gg a écrit : > > It might be a bit inconvenient to find the patches related to vp8, vp9 > that > > were sent

Re: [FFmpeg-devel] [PATCH 1/3] lavc/vp8dsp: R-V V put_epel h

2024-03-26 Thread flow gg
Okay, changed to use const, updated at this GitHub link ( https://github.com/hleft/FFmpeg/tree/vp8vp9) Rémi Denis-Courmont 于2024年3月27日周三 02:38写道: > Le perjantaina 22. maaliskuuta 2024, 8.01.00 EET flow gg a écrit : > > (This should be used after applying these 4 patches) > > > > ``` > >

[FFmpeg-devel] [PATCH 6/6] avutil/opt: Avoid av_uninit

2024-03-26 Thread Andreas Rheinhardt
GCC 9-13 do not emit warnings for this at all optimization levels even when -Wmaybe-uninitialized is not disabled. Signed-off-by: Andreas Rheinhardt --- libavutil/opt.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavutil/opt.c b/libavutil/opt.c index

[FFmpeg-devel] [PATCH 5/6] avcodec/ratecontrol: Use forward declaration for AVExpr

2024-03-26 Thread Andreas Rheinhardt
Avoids including eval.h everywhere where mpegvideo.h is included. Signed-off-by: Andreas Rheinhardt --- libavcodec/ratecontrol.h | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/libavcodec/ratecontrol.h b/libavcodec/ratecontrol.h index 4de80fad90..1f44b44341 100644 ---

[FFmpeg-devel] [PATCH 4/6] avcodec/h264_refs: Use smaller scope, don't use av_uninit

2024-03-26 Thread Andreas Rheinhardt
In particular, declare iterators with loop scope. Also remove av_uninit while at it, because they are now unnecessary due to the changes of the preceding commit. Signed-off-by: Andreas Rheinhardt --- libavcodec/h264_refs.c | 121 ++--- 1 file changed, 53

[FFmpeg-devel] [PATCH 3/6] avcodec/h264_refs: Rewrite code to make control flow clearer

2024-03-26 Thread Andreas Rheinhardt
While this change IMO makes the control flow clearer for the human reader, it is especially important for GCC: It erroneously believes that it is possible to enter the SHORT2(UNUSED|LONG) cases without having entered the preceding block that initializes pic, frame_num, structure and j; it would

[FFmpeg-devel] [PATCH 2/6] avcodec/libvpxenc: Remove obsolete av_unused

2024-03-26 Thread Andreas Rheinhardt
Forgotten in 753074721bd414874d18c372c491bdc6323fa3bf. Signed-off-by: Andreas Rheinhardt --- libavcodec/libvpxenc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavcodec/libvpxenc.c b/libavcodec/libvpxenc.c index 42f73a92f6..f7bfdc1461 100644 ---

[FFmpeg-devel] [PATCH 1/6] avcodec/libvpxenc: Only search for side data when intending to use it

2024-03-26 Thread Andreas Rheinhardt
Also rewrite the code so that a variable that is only used depending upon CONFIG_LIBVPX_VP9_ENCODER is not declared outside of the #if block. (The variable was declared with av_uninit, but it should have been av_unused, as the former does not work for all compilers.) Signed-off-by: Andreas

Re: [FFmpeg-devel] [PATCH] all: Don't use ATOMIC_VAR_INIT

2024-03-26 Thread Andreas Rheinhardt
Andreas Rheinhardt: > C11 required to use ATOMIC_VAR_INIT to statically initialize > atomic objects with static storage duration. Yet this macro > was unsuitable for initializing structures [1] and was actually > unneeded for all known implementations (this includes our > compatibility fallback

Re: [FFmpeg-devel] [PATCH v1] avcodec/cbs_vp8: Use little endian in fixed()

2024-03-26 Thread Dai, Jianhui J
> -Original Message- > From: ffmpeg-devel On Behalf Of Ronald > S. Bultje > Sent: Tuesday, March 26, 2024 9:14 PM > To: FFmpeg development discussions and patches > Subject: Re: [FFmpeg-devel] [PATCH v1] avcodec/cbs_vp8: Use little endian in > fixed() > > Hi, > > On Wed, Jan 24, 2024

Re: [FFmpeg-devel] [PATCH 1/4] Bump prior release/7.0 branch

2024-03-26 Thread Michael Niedermayer
On Tue, Mar 26, 2024 at 11:57:12PM +0100, Michael Niedermayer wrote: > Signed-off-by: Michael Niedermayer > --- > libavcodec/version.h| 2 +- > libavdevice/version.h | 2 +- > libavfilter/version.h | 2 +- > libavformat/version.h | 2 +- > libavutil/version.h | 2 +- >

Re: [FFmpeg-devel] [PATCH] avformat/mov: don't abort on duplicate Mastering Display Metadata boxes

2024-03-26 Thread James Almer
On 3/26/2024 9:13 PM, Andreas Rheinhardt wrote: James Almer: The VP9 spec defines a SmDm box for this information, and the ISOBMFF spec defines a mdvc one. If both are present, just ignore one of them. This is in line with clli and CoLL boxes. Fixes ticket #10711. Signed-off-by: James Almer

Re: [FFmpeg-devel] [PATCH] avformat/mov: don't abort on duplicate Mastering Display Metadata boxes

2024-03-26 Thread Andreas Rheinhardt
James Almer: > The VP9 spec defines a SmDm box for this information, and the ISOBMFF spec > defines a > mdvc one. If both are present, just ignore one of them. > This is in line with clli and CoLL boxes. > > Fixes ticket #10711. > > Signed-off-by: James Almer > --- > libavformat/mov.c | 13

[FFmpeg-devel] [PATCH] avformat/mov: don't abort on duplicate Mastering Display Metadata boxes

2024-03-26 Thread James Almer
The VP9 spec defines a SmDm box for this information, and the ISOBMFF spec defines a mdvc one. If both are present, just ignore one of them. This is in line with clli and CoLL boxes. Fixes ticket #10711. Signed-off-by: James Almer --- libavformat/mov.c | 13 ++--- 1 file changed, 10

Re: [FFmpeg-devel] Fw: A static compilation duplicate reference error. Request a fix.

2024-03-26 Thread Timo Rothenpieler
There is a bug here, please update it when you request an update. https://github.com/FFmpeg/FFmpeg/blob/61afe4d98ce62d9dfc6f0548e18730ba2f621cc2/libavformat/file.c#L531 The correct result should be #include "libavcodec/ffjni.h" Pretty sure this is intentional, to get the private symbol into

Re: [FFmpeg-devel] [PATCH 2/5] avcodec/liblc3: Add encoding/decoding support of LC3 audio codec

2024-03-26 Thread Andreas Rheinhardt
Antoine Soulier via ffmpeg-devel: > The LC3 audio codec is the default codec of Bluetooth LE audio. > This is a wrapper over the liblc3 library (https://github.com/google/liblc3). > > Signed-off-by: Antoine Soulier > --- > libavcodec/Makefile | 2 + > libavcodec/allcodecs.c | 2 + >

Re: [FFmpeg-devel] [PATCH] Changelog: add Android content URIs protocol entry

2024-03-26 Thread Matthieu Bouron
On Tue, Mar 26, 2024 at 04:30:53PM +0100, Stefano Sabatini wrote: > On date Monday 2024-03-25 09:14:15 +0100, Matthieu Bouron wrote: > > --- > > Changelog | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/Changelog b/Changelog > > index 934241a965..e4373ff991 100644 > > ---

[FFmpeg-devel] [PATCH 5/5] Changelog: Add LC3/LC3plus decoding/encoding support

2024-03-26 Thread Antoine Soulier via ffmpeg-devel
Signed-off-by: Antoine Soulier --- Changelog | 1 + 1 file changed, 1 insertion(+) diff --git a/Changelog b/Changelog index 934241a965..2282f8ca76 100644 --- a/Changelog +++ b/Changelog @@ -37,6 +37,7 @@ version : - Support PacketTypeMetadata of PacketType in enhanced flv format - ffplay with

[FFmpeg-devel] [PATCH 4/5] doc: Add LC3/LC3plus muxer and encoder parameters documentation

2024-03-26 Thread Antoine Soulier via ffmpeg-devel
Signed-off-by: Antoine Soulier --- doc/encoders.texi | 57 +++ doc/general_contents.texi | 11 +++- doc/muxers.texi | 6 + 3 files changed, 73 insertions(+), 1 deletion(-) diff --git a/doc/encoders.texi b/doc/encoders.texi index

[FFmpeg-devel] [PATCH 3/5] avformat/lc3: Add file format for LC3/LC3plus transport

2024-03-26 Thread Antoine Soulier via ffmpeg-devel
A file format is described in Bluetooth SIG LC3 and ETSI TS 103 634, for test purpose. This is the format implemented here. Signed-off-by: Antoine Soulier --- libavformat/Makefile | 2 + libavformat/allformats.c | 2 + libavformat/lc3dec.c | 137

[FFmpeg-devel] [PATCH 2/5] avcodec/liblc3: Add encoding/decoding support of LC3 audio codec

2024-03-26 Thread Antoine Soulier via ffmpeg-devel
The LC3 audio codec is the default codec of Bluetooth LE audio. This is a wrapper over the liblc3 library (https://github.com/google/liblc3). Signed-off-by: Antoine Soulier --- libavcodec/Makefile | 2 + libavcodec/allcodecs.c | 2 + libavcodec/codec_desc.c | 7 ++

[FFmpeg-devel] [PATCH 1/5] configure: Add option for enabling LC3/LC3plus wrapper

2024-03-26 Thread Antoine Soulier via ffmpeg-devel
Signed-off-by: Antoine Soulier --- configure | 6 ++ 1 file changed, 6 insertions(+) diff --git a/configure b/configure index 2a1d22310b..4262b96117 100755 --- a/configure +++ b/configure @@ -244,6 +244,7 @@ External library support: --enable-libjxl enable JPEG XL de/encoding

[FFmpeg-devel] [PATCH 4/4] Bump after 7.0 branch point

2024-03-26 Thread Michael Niedermayer
Signed-off-by: Michael Niedermayer --- libavcodec/version.h| 2 +- libavdevice/version.h | 2 +- libavfilter/version.h | 2 +- libavformat/version.h | 2 +- libavutil/version.h | 2 +- libpostproc/version.h | 2 +- libswresample/version.h | 2 +- libswscale/version.h| 2 +- 8

[FFmpeg-devel] [PATCH 3/4] doc/APIchanges: Add 7.0 cut point

2024-03-26 Thread Michael Niedermayer
Signed-off-by: Michael Niedermayer --- doc/APIchanges | 2 ++ 1 file changed, 2 insertions(+) diff --git a/doc/APIchanges b/doc/APIchanges index 680d3672e75..44858b283ea 100644 --- a/doc/APIchanges +++ b/doc/APIchanges @@ -2,6 +2,8 @@ The last version increases of all libraries were on

[FFmpeg-devel] [PATCH 2/4] Changelog: Add 7.0 point

2024-03-26 Thread Michael Niedermayer
Signed-off-by: Michael Niedermayer --- Changelog | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Changelog b/Changelog index 934241a965e..a7cad9848c5 100644 --- a/Changelog +++ b/Changelog @@ -1,7 +1,7 @@ Entries are sorted chronologically from oldest to youngest within each

[FFmpeg-devel] [PATCH 1/4] Bump prior release/7.0 branch

2024-03-26 Thread Michael Niedermayer
Signed-off-by: Michael Niedermayer --- libavcodec/version.h| 2 +- libavdevice/version.h | 2 +- libavfilter/version.h | 2 +- libavformat/version.h | 2 +- libavutil/version.h | 2 +- libpostproc/version.h | 2 +- libswresample/version.h | 2 +- libswscale/version.h| 2 +- 8

[FFmpeg-devel] Fw: A static compilation duplicate reference error. Request a fix.

2024-03-26 Thread 联盟少侠
There is a bug here, please update it when you request an update. https://github.com/FFmpeg/FFmpeg/blob/61afe4d98ce62d9dfc6f0548e18730ba2f621cc2/libavformat/file.c#L531 The correct result should be #include "libavcodec/ffjni.h" >From Android AliMail

Re: [FFmpeg-devel] [RFC] clarifying the TC conflict of interest rule

2024-03-26 Thread Michael Niedermayer
On Tue, Mar 26, 2024 at 09:20:46AM +0100, Anton Khirnov wrote: > The vote has been started, with the voter list generated by > general_assembly.pl: > # GA for 2021-01-01T00:00:00/2024-01-01T00:00:00; 50 people; > SHA256:e63c3589d48557b90767f581eb1372c6c883ab87395dade38c61d0db0771fabd; >

Re: [FFmpeg-devel] [PATCH] V2 tests/fate/filter-audio.mak: add test for ATEMPO audio filter

2024-03-26 Thread Rajiv Harlalka
On Thu, 21 Mar 2024 at 3:43 PM, Rajiv Harlalka wrote: > Please find an updated patch for tests on the atempo audio filter > Bumping this patch up for visibility. ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org

Re: [FFmpeg-devel] [PATCH 2/5] avcodec/liblc3: Add encoding/decoding support of LC3 audio codec

2024-03-26 Thread Andreas Rheinhardt
Antoine Soulier via ffmpeg-devel: > 1. Thanks, I will add the caps. > 2. Yes, the `lc3_hr_setup_decoder()` returns the given memory address (And > do not write anything when 'NULL'). > But bad parameters also return `NULL`, even if parameters are already > validated elsewhere, I will change this

Re: [FFmpeg-devel] [PATCH 1/4] lavu/frame: add side data descriptors

2024-03-26 Thread James Almer
On 3/23/2024 10:04 AM, Anton Khirnov wrote: They allow exporting extended information about side data types. --- doc/APIchanges | 4 +++ libavutil/frame.c | 70 ++--- libavutil/frame.h | 27 + libavutil/version.h | 2 +- 4

Re: [FFmpeg-devel] [PATCH] avcodec/mfenc: expose more properties of the media foundation encoder

2024-03-26 Thread Mark Thompson
On 26/03/2024 19:25, Mark Samuelson wrote: --- libavcodec/mf_utils.h | 5 + libavcodec/mfenc.c| 19 +++ 2 files changed, 24 insertions(+) This seems like a good idea. diff --git a/libavcodec/mf_utils.h b/libavcodec/mf_utils.h index aebfb9ad21..387c005f38 100644

[FFmpeg-devel] [PATCH] avformat/dvdvideodec: remove `if ((ret = ...) < 0)` pattern

2024-03-26 Thread Marth64
Recent advice plus my own experience agree that this pattern is error-prone. Instead, set `ret` in its own line and do the error validation after. Also, explicitly return 0 on success in dvdvideo_chapters_setup_preindex() Signed-off-by: Marth64 --- libavformat/dvdvideodec.c | 132

Re: [FFmpeg-devel] Add optimization in swscale for LA.

2024-03-26 Thread Michael Niedermayer
On Tue, Mar 26, 2024 at 11:11:00AM +0800, Shiyou Yin wrote: > > > 2024年3月16日 11:03,Shiyou Yin 写道: > > > > [PATCH 1/3] swscale: [LA] Optimize range convert for yuvj420p. > > [PATCH 2/3] swscale: [LA] Optimize yuv2plane1_8_c. > > [PATCH 3/3] swscale: [LA] Optimize swscale funcs in input.c > > >

Re: [FFmpeg-devel] [PATCH 2/3] avformat/mov: Do not deallocate heif_item in a input dependant way

2024-03-26 Thread Michael Niedermayer
On Mon, Mar 25, 2024 at 10:22:19PM -0300, James Almer wrote: > On 3/22/2024 8:08 PM, Michael Niedermayer wrote: > > Fixes: out of array access > > Fixes: > > 67070/clusterfuzz-testcase-minimized-ffmpeg_IO_DEMUXER_fuzzer-5685384082161664 > > > > Found-by: continuous fuzzing process > >

[FFmpeg-devel] [PATCH] avcodec/mfenc: expose more properties of the media foundation encoder

2024-03-26 Thread Mark Samuelson
--- libavcodec/mf_utils.h | 5 + libavcodec/mfenc.c| 19 +++ 2 files changed, 24 insertions(+) diff --git a/libavcodec/mf_utils.h b/libavcodec/mf_utils.h index aebfb9ad21..387c005f38 100644 --- a/libavcodec/mf_utils.h +++ b/libavcodec/mf_utils.h @@ -97,6 +97,11 @@

Re: [FFmpeg-devel] [PATCH 1/7] avcodec/hcadec: do not set hfr_group_count to invalid values

2024-03-26 Thread Michael Niedermayer
On Tue, Mar 26, 2024 at 03:30:50AM +0100, Michael Niedermayer wrote: > Fixes: > 62285/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_HCA_fuzzer-6247136417087488 > Fixes: out of array write > > Found-by: continuous fuzzing process >

Re: [FFmpeg-devel] [PATCH 01/10] avformat/concatdec: Check user_duration sum

2024-03-26 Thread Michael Niedermayer
On Tue, Mar 26, 2024 at 01:11:42AM +0100, Michael Niedermayer wrote: > Fixes: > 62276/clusterfuzz-testcase-minimized-ffmpeg_dem_CONCAT_fuzzer-6434245599690752 > Fixes: signed integer overflow: 922337202677300 + 2233700 cannot be > represented in type 'long' > > Found-by: continuous

Re: [FFmpeg-devel] [PATCH 2/5] avcodec/liblc3: Add encoding/decoding support of LC3 audio codec

2024-03-26 Thread Antoine Soulier via ffmpeg-devel
1. Thanks, I will add the caps. 2. Yes, the `lc3_hr_setup_decoder()` returns the given memory address (And do not write anything when 'NULL'). But bad parameters also return `NULL`, even if parameters are already validated elsewhere, I will change this call to be more clean. > "What makes you

Re: [FFmpeg-devel] [PATCH 2/5] avcodec/liblc3: Add encoding/decoding support of LC3 audio codec

2024-03-26 Thread Antoine Soulier via ffmpeg-devel
Thanks for your review. I am not sure to understand "1e3f might be replaced by a symbolic constant/macro". It's for a conversion from microseconds to milliseconds (standard unit used for the frame duration). It's not a magical constant, I do some greps and it looks like such constant "1000.f" are

Re: [FFmpeg-devel] [PATCH 1/3] lavc/vp8dsp: R-V V put_epel h

2024-03-26 Thread Rémi Denis-Courmont
Le perjantaina 22. maaliskuuta 2024, 8.01.00 EET flow gg a écrit : > (This should be used after applying these 4 patches) > > ``` > [FFmpeg-devel] [PATCH] lavc/vp8dsp: R-V V put_vp8_pixels > [FFmpeg-devel] [PATCH 1/3] lavc/vp8dsp: R-V V put_bilin_h > 1-3 > ``` In general, I am not sure that it

Re: [FFmpeg-devel] [PATCH 3/5] avformat/lc3: Add file format for LC3/LC3plus transport

2024-03-26 Thread Andreas Rheinhardt
Antoine Soulier via ffmpeg-devel: > A file format is described in Bluetooth SIG LC3 and ETSI TS 103 634, for > test purpose. This is the format implemented here. > > Signed-off-by: Antoine Soulier > Signed-off-by: Antoine SOULIER > --- > libavformat/Makefile | 3 + >

Re: [FFmpeg-devel] [PATCH 1/7] lavc/vp9dsp: R-V mc copy_avg

2024-03-26 Thread Rémi Denis-Courmont
Hi, Le perjantaina 22. maaliskuuta 2024, 8.12.41 EET flow gg a écrit : > It might be a bit inconvenient to find the patches related to vp8, vp9 that > were sent earlier. Here, I've placed them in a zip file in this reply ZIP files are not particularly convenient. The only easy way for me to

Re: [FFmpeg-devel] [PATCH 2/5] avcodec/liblc3: Add encoding/decoding support of LC3 audio codec

2024-03-26 Thread Andreas Rheinhardt
Antoine Soulier via ffmpeg-devel: > The LC3 audio codec is the default codec of Bluetooth LE audio. > This is a wrapper over the liblc3 library (https://github.com/google/liblc3). > > Signed-off-by: Antoine Soulier > Signed-off-by: Antoine SOULIER > --- > libavcodec/Makefile | 3 + >

Re: [FFmpeg-devel] [PATCH v3] avformat: enable UDP IPv6 multicast interface selection using localaddr

2024-03-26 Thread Rémi Denis-Courmont
Both patches -1 for same reasons as before and that's unnecessary, functionally incorrect and potentially racy, enumeration of local interfaces. -- レミ・デニ-クールモン http://www.remlab.net/ ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org

Re: [FFmpeg-devel] [PATCH v2] avformat: enable UDP IPv6 multicast interface selection

2024-03-26 Thread Rémi Denis-Courmont
Le perjantaina 22. maaliskuuta 2024, 12.16.30 EET Ignjatović, Lazar (RS) a écrit : > This message has been marked as Public on 03/22/2024 10:16Z. > > On Friday, March 22, 2024 10:55 AM Rémi Denis-Courmont wrote: > > So why are you arguing now? > > Because I still belive that using localaddr is

Re: [FFmpeg-devel] [PATCH 4/5] doc: Add LC3/LC3plus muxer and encoder parameters documentation

2024-03-26 Thread Stefano Sabatini
On date Tuesday 2024-03-26 16:47:38 +, ffmpeg-devel Mailing List wrote: > Signed-off-by: Antoine Soulier > Signed-off-by: Antoine SOULIER > --- > doc/encoders.texi | 57 +++ > doc/general_contents.texi | 12 - > doc/muxers.texi |

Re: [FFmpeg-devel] [PATCH 5/5] Changelog: Add LC3/LC3plus decoding/encoding support

2024-03-26 Thread Stefano Sabatini
On date Tuesday 2024-03-26 16:47:39 +, ffmpeg-devel Mailing List wrote: > Signed-off-by: Antoine Soulier > Signed-off-by: Antoine SOULIER > --- > Changelog | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/Changelog b/Changelog > index c6e8f6bcaf..fb08ee2f81 100644 > --- a/Changelog

Re: [FFmpeg-devel] [PATCH 3/5] avformat/lc3: Add file format for LC3/LC3plus transport

2024-03-26 Thread Stefano Sabatini
On date Tuesday 2024-03-26 16:47:37 +, ffmpeg-devel Mailing List wrote: > A file format is described in Bluetooth SIG LC3 and ETSI TS 103 634, for > test purpose. This is the format implemented here. > > Signed-off-by: Antoine Soulier > Signed-off-by: Antoine SOULIER > --- >

Re: [FFmpeg-devel] [PATCH 1/5] configure: Add option for enabling LC3/LC3plus wrapper

2024-03-26 Thread Antoine Soulier via ffmpeg-devel
Compared with the C implementation of KissFFT (it's the only one I tested on ARM M4). Yes, there is no SIMD on x86. This was not the main target. Was mainly made for ARM M4 (for BLE devices Nordic Semi / Zephyr), and ARM Neon (Android). By the way, this does not change a lot, the FFT/MDCT on

Re: [FFmpeg-devel] [PATCH 2/5] avcodec/liblc3: Add encoding/decoding support of LC3 audio codec

2024-03-26 Thread Stefano Sabatini
On date Tuesday 2024-03-26 16:47:36 +, ffmpeg-devel Mailing List wrote: > The LC3 audio codec is the default codec of Bluetooth LE audio. > This is a wrapper over the liblc3 library (https://github.com/google/liblc3). > > Signed-off-by: Antoine Soulier > Signed-off-by: Antoine SOULIER > ---

Re: [FFmpeg-devel] [PATCH 1/5] configure: Add option for enabling LC3/LC3plus wrapper

2024-03-26 Thread Paul B Mahol
On Tue, Mar 26, 2024 at 6:07 PM Antoine Soulier wrote: > What do you mean by sub-optimal? > It's stacked by prime factors, and unrolled for FFT3 and FF5. > The butterfly implementations of FFT3 and FF5, gives me slightly slower > computation. FFT5 is done first, so it takes advantage of

Re: [FFmpeg-devel] [PATCH 1/5] configure: Add option for enabling LC3/LC3plus wrapper

2024-03-26 Thread Antoine Soulier via ffmpeg-devel
Arf, sorry for that. I used `git send-email -s`, perhaps it's the source of the double signed-off. On Tue, Mar 26, 2024 at 10:32 AM Stefano Sabatini wrote: > On date Tuesday 2024-03-26 16:47:35 +, ffmpeg-devel Mailing List wrote: > > > Signed-off-by: Antoine Soulier > > Signed-off-by:

Re: [FFmpeg-devel] [PATCH 1/5] configure: Add option for enabling LC3/LC3plus wrapper

2024-03-26 Thread Stefano Sabatini
On date Tuesday 2024-03-26 16:47:35 +, ffmpeg-devel Mailing List wrote: > Signed-off-by: Antoine Soulier > Signed-off-by: Antoine SOULIER why the double sign-off? [...] LGTM. ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org

Re: [FFmpeg-devel] [PATCH] avformat/httpauth: add SHA-256 Digest Authorization

2024-03-26 Thread Stefano Sabatini
On date Tuesday 2024-03-26 05:52:59 +, �� | Eugene wrote: > - add SHA-256 Digest Authorization for RFC7616 using avutil/hash.h > > Signed-off-by: Eugene-bitsensing > --- > libavformat/httpauth.c | 116 - > libavformat/httpauth.h | 8 +++ > 2

Re: [FFmpeg-devel] [PATCH 1/5] configure: Add option for enabling LC3/LC3plus wrapper

2024-03-26 Thread Antoine Soulier via ffmpeg-devel
What do you mean by sub-optimal? It's stacked by prime factors, and unrolled for FFT3 and FF5. The butterfly implementations of FFT3 and FF5, gives me slightly slower computation. FFT5 is done first, so it takes advantage of sin()/cos() values of 0 or 1. There are also no reordering steps (this

Re: [FFmpeg-devel] [PATCH 1/5] configure: Add option for enabling LC3/LC3plus wrapper

2024-03-26 Thread Paul B Mahol
Isn't this using sub-optimal MDCT implementation? ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject

[FFmpeg-devel] [PATCH 5/5] Changelog: Add LC3/LC3plus decoding/encoding support

2024-03-26 Thread Antoine Soulier via ffmpeg-devel
Signed-off-by: Antoine Soulier Signed-off-by: Antoine SOULIER --- Changelog | 1 + 1 file changed, 1 insertion(+) diff --git a/Changelog b/Changelog index c6e8f6bcaf..fb08ee2f81 100644 --- a/Changelog +++ b/Changelog @@ -2,6 +2,7 @@ Entries are sorted chronologically from oldest to youngest

[FFmpeg-devel] [PATCH 4/5] doc: Add LC3/LC3plus muxer and encoder parameters documentation

2024-03-26 Thread Antoine Soulier via ffmpeg-devel
Signed-off-by: Antoine Soulier Signed-off-by: Antoine SOULIER --- doc/encoders.texi | 57 +++ doc/general_contents.texi | 12 - doc/muxers.texi | 4 +++ 3 files changed, 72 insertions(+), 1 deletion(-) diff --git

[FFmpeg-devel] [PATCH 3/5] avformat/lc3: Add file format for LC3/LC3plus transport

2024-03-26 Thread Antoine Soulier via ffmpeg-devel
A file format is described in Bluetooth SIG LC3 and ETSI TS 103 634, for test purpose. This is the format implemented here. Signed-off-by: Antoine Soulier Signed-off-by: Antoine SOULIER --- libavformat/Makefile | 3 + libavformat/allformats.c | 3 + libavformat/lc3dec.c | 140

[FFmpeg-devel] [PATCH 2/5] avcodec/liblc3: Add encoding/decoding support of LC3 audio codec

2024-03-26 Thread Antoine Soulier via ffmpeg-devel
The LC3 audio codec is the default codec of Bluetooth LE audio. This is a wrapper over the liblc3 library (https://github.com/google/liblc3). Signed-off-by: Antoine Soulier Signed-off-by: Antoine SOULIER --- libavcodec/Makefile | 3 + libavcodec/allcodecs.c | 3 +

[FFmpeg-devel] [PATCH 1/5] configure: Add option for enabling LC3/LC3plus wrapper

2024-03-26 Thread Antoine Soulier via ffmpeg-devel
Signed-off-by: Antoine Soulier Signed-off-by: Antoine SOULIER --- configure | 7 +++ 1 file changed, 7 insertions(+) diff --git a/configure b/configure index 343edb38ab..eb8ff81a11 100755 --- a/configure +++ b/configure @@ -244,6 +244,7 @@ External library support: --enable-libjxl

Re: [FFmpeg-devel] [PATCH 02/10] avutil/fifo, file: Remove unused headers

2024-03-26 Thread Stefano Sabatini
On date Monday 2024-03-25 02:53:16 +0100, Andreas Rheinhardt wrote: > Forgotten in 4105899245d79976b4a1a230455066417f3f194d, > 4c92fc02f850f4f813e8cef8f8f8ed37d498e090. > > Signed-off-by: Andreas Rheinhardt > --- > libavutil/fifo.h | 4 > libavutil/file.h | 1 - > 2 files changed, 5

Re: [FFmpeg-devel] [PATCH 01/10] doc/examples: Always use <> includes

2024-03-26 Thread Stefano Sabatini
On date Monday 2024-03-25 02:51:16 +0100, Andreas Rheinhardt wrote: > Signed-off-by: Andreas Rheinhardt > --- > doc/examples/filter_audio.c | 18 +- > doc/examples/qsv_decode.c| 16 > doc/examples/transcode_aac.c | 20 ++-- > 3 files changed,

Re: [FFmpeg-devel] [PATCH v4 1/1] avformat/mpegts: Add duration_probesize AVOption

2024-03-26 Thread Stefano Sabatini
On date Tuesday 2024-03-26 14:18:31 +0100, Nicolas Gaullier wrote: > Yet another probesize option aimed at users interested > in better durations probing for itself, or because using > avformat_find_stream_info indirectly and requiring exact values: for > concatdec for example, especially if

Re: [FFmpeg-devel] [PATCH 1/1] avcodec/dolby_e: Add error recovery when parse_mantissas run out of bits

2024-03-26 Thread Nicolas Gaullier
>De : Nicolas Gaullier >Envoyé : lundi 11 mars 2024 15:01 > >Mantissas are the last data in the channel subsegment and it appears it is >sometimes missing a very few bits for the parsing to complete. >This must not be confused with data corruption. >In standard conditions with certified

Re: [FFmpeg-devel] [PATCH v9 1/5] avformat/subtitles: extend ff_subtitles_queue_insert() to support not yet available events

2024-03-26 Thread Andreas Rheinhardt
Marth64: > If ff_subtitles_queue_insert() were given a NULL buffer > with 0 length, it would still attempt to grow the packet > or memcpy depending on if merge option is enabled. > > In this commit, allow passing a NULL buffer with 0 length > without attempting to do such operations. This way, if

Re: [FFmpeg-devel] [PATCH v9 0/5] RCWT Closed Captions demuxer (v9)

2024-03-26 Thread Stefano Sabatini
On date Tuesday 2024-03-26 10:29:18 -0500, Marth64 wrote: > Ping if possible. The patches still apply. 3 of the 5 patches are > documentation only and the demuxer itself is much smaller now. The muxer > already made it in, so was hoping the demuxer could go too :fingers_crossed: I sent a few

Re: [FFmpeg-devel] [PATCH v9 3/5] avformat/rcwtenc: remove repeated documentation

2024-03-26 Thread Stefano Sabatini
On date Saturday 2024-03-23 21:25:02 -0500, Marth64 wrote: > The high level summary of RCWT can be delegated doc/muxers, which > makes it easier to maintain and more consistent with the documentation > of the demuxer. > > Signed-off-by: Marth64 > --- > libavformat/rcwtenc.c | 5 - > 1 file

Re: [FFmpeg-devel] [PATCH v9 2/5] avformat/rcwtdec: add RCWT Closed Captions demuxer

2024-03-26 Thread Stefano Sabatini
On date Saturday 2024-03-23 21:25:01 -0500, Marth64 wrote: > RCWT (Raw Captions With Time) is a format native to ccextractor, > a commonly used OSS tool for processing 608/708 Closed Captions (CC). > RCWT can be used to archive the original extracted CC bitstream. > The muxer was added in January

Re: [FFmpeg-devel] [PATCH v2] doc: Add libtoch backend option to dnn_processing

2024-03-26 Thread Leo Izen
On 3/25/24 07:16, Guo, Yejun wrote: -Original Message- From: ffmpeg-devel On Behalf Of wenbin.chen-at-intel@ffmpeg.org Sent: Monday, March 25, 2024 10:15 AM To: ffmpeg-devel@ffmpeg.org Subject: [FFmpeg-devel] [PATCH v2] doc: Add libtoch backend option to dnn_processing Typo in

Re: [FFmpeg-devel] [PATCH v4 0/4] Fix some active sequences in subtitles

2024-03-26 Thread Marth64
Ping on this set authored by Oneric as well. ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] [PATCH v2] avformat/dvdvideodec: add explicit inttypes.h include

2024-03-26 Thread Marth64
Was already applied. Thanks Stefano and Leo! ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] [PATCH v2] avformat/dvdvideodec: add explicit inttypes.h include

2024-03-26 Thread Stefano Sabatini
On date Monday 2024-03-25 16:21:02 -0500, Marth64 wrote: > Since log statements printing int64 were made portable in > 4464b7eeb194e98ac115f18d2b6be67361407c8a, let us include > inttypes.h explicitly (as it is unclear where PRId64 and > such are coming from now). > > Reported-by: Traneptora >

Re: [FFmpeg-devel] [PATCH v9 1/5] avformat/subtitles: extend ff_subtitles_queue_insert() to support not yet available events

2024-03-26 Thread Marth64
> is the move needed? (but not blocking) It is not needed, but the code flows better I think in terms of readability. I think it feels cleaner to say, "set up `sub` then add it to the array" vs. "set up sub's data, add it to the array, then set up its other fields". But, I am good either way and

Re: [FFmpeg-devel] [PATCH v9 1/5] avformat/subtitles: extend ff_subtitles_queue_insert() to support not yet available events

2024-03-26 Thread Stefano Sabatini
On date Saturday 2024-03-23 21:25:00 -0500, Marth64 wrote: > If ff_subtitles_queue_insert() were given a NULL buffer > with 0 length, it would still attempt to grow the packet > or memcpy depending on if merge option is enabled. > > In this commit, allow passing a NULL buffer with 0 length >

Re: [FFmpeg-devel] [PATCH] Changelog: add Android content URIs protocol entry

2024-03-26 Thread Stefano Sabatini
On date Monday 2024-03-25 09:14:15 +0100, Matthieu Bouron wrote: > --- > Changelog | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/Changelog b/Changelog > index 934241a965..e4373ff991 100644 > --- a/Changelog > +++ b/Changelog > @@ -37,6 +37,7 @@ version : > - Support

Re: [FFmpeg-devel] [PATCH v9 0/5] RCWT Closed Captions demuxer (v9)

2024-03-26 Thread Marth64
Ping if possible. The patches still apply. 3 of the 5 patches are documentation only and the demuxer itself is much smaller now. The muxer already made it in, so was hoping the demuxer could go too :fingers_crossed: ___ ffmpeg-devel mailing list

[FFmpeg-devel] [PATCH 1/1] avcodec/h264_parser: fix start of packet for some broken streams

2024-03-26 Thread Nicolas Gaullier
--- libavcodec/h264_parser.c | 11 ++- 1 file changed, 10 insertions(+), 1 deletion(-) diff --git a/libavcodec/h264_parser.c b/libavcodec/h264_parser.c index 94cfbc481e..6b721ec253 100644 --- a/libavcodec/h264_parser.c +++ b/libavcodec/h264_parser.c @@ -124,7 +124,16 @@ static int

[FFmpeg-devel] [PATCH 0/1] avcodec/h264_parser: fix start of packet for some broken

2024-03-26 Thread Nicolas Gaullier
This is a patch from my patch serie https://patchwork.ffmpeg.org/project/ffmpeg/list/?series=10999 Maybe it is easier to review it this way, independantly. This patch shows some benefits by itself, but most importantly, it is required for my patch serie to avoid any regression with some invalid

[FFmpeg-devel] [PATCH] avcodec: Allow enabling DTX in libopusenc

2024-03-26 Thread Paul Adenot
From: Paul Adenot --- doc/encoders.texi | 4 libavcodec/libopusenc.c | 9 + 2 files changed, 13 insertions(+) diff --git a/doc/encoders.texi b/doc/encoders.texi index 7c223ed74c..d459b2865f 100644 --- a/doc/encoders.texi +++ b/doc/encoders.texi @@ -1000,6 +1000,10 @@ Other

[FFmpeg-devel] [PATCH v4 1/1] avformat/mpegts: Add duration_probesize AVOption

2024-03-26 Thread Nicolas Gaullier
Yet another probesize option aimed at users interested in better durations probing for itself, or because using avformat_find_stream_info indirectly and requiring exact values: for concatdec for example, especially if streamcopying above it. The current code is a performance trade-off that can

[FFmpeg-devel] [PATCH v4 0/1] avformat/mpegts: Add duration_probesize AVOption

2024-03-26 Thread Nicolas Gaullier
Thanks to Stefano for the precise inspection, I addressed all the points. The question about what is specific to mpeg remains, so I will try to elaborate on this. I don't see how duration_probesize could be needed in any way beyond estimate_timings_from_pts(). And it seems there is no other

Re: [FFmpeg-devel] [PATCH v1] avcodec/cbs_vp8: Use little endian in fixed()

2024-03-26 Thread Ronald S. Bultje
Hi, On Wed, Jan 24, 2024 at 7:54 PM Dai, Jianhui J < jianhui.j.dai-at-intel@ffmpeg.org> wrote: > This commit adds value range checks to cbs_vp8_read_unsigned_le, > migrates fixed() to use it, and enforces little-endian consistency for > all read methods. > > Signed-off-by: Jianhui Dai > ---

Re: [FFmpeg-devel] [PATCH v2] avcodec/cbs_vp8: Improve the bitstream position check

2024-03-26 Thread Ronald S. Bultje
Hi, On Tue, Mar 19, 2024 at 2:05 AM Dai, Jianhui J < jianhui.j.dai-at-intel@ffmpeg.org> wrote: > The VP8 compressed header may not be byte-aligned due to boolean > coding. Round up byte count for accurate data positioning. > > Signed-off-by: Jianhui Dai > --- > libavcodec/cbs_vp8.c | 4

[FFmpeg-devel] [PATCH] avformat: enable UDP IPv6 multicast interface selection using zone index

2024-03-26 Thread RS
avformat: enable UDP IPv6 multicast interface selection using zone index Enabled IPv6 interface selection using zone index. Properly resolved interface index in places where default 0 interface index is used (marked with TODO: within udp.c). Adjusted binding for multicast sockets that are used

[FFmpeg-devel] [PATCH v3] avformat: enable UDP IPv6 multicast interface selection using localaddr

2024-03-26 Thread RS
avformat: enable UDP IPv6 multicast interface selection using localaddr localaddr option now properly works with IPv6 addresses. Properly resolved interface index in places where default 0 interface index is used (marked with TODO: within udp.c). Adjusted binding for multicast sockets that are

Re: [FFmpeg-devel] [PATCH] tests/audiogen: Fix total RIFF chunk size

2024-03-26 Thread Tobias Rapp
On 15/03/2024 09:53, Tobias Rapp wrote: The "RIFF" identifier and chunk size fields should not be included within the size value. --- tests/audiogen.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/audiogen.c b/tests/audiogen.c index c43bb70..df1dea6 100644 ---

Re: [FFmpeg-devel] [PATCH] Remove struct named initializer from aac profile option.

2024-03-26 Thread Hendrik Leppkes
On Tue, Mar 26, 2024 at 9:42 AM Muiz Yusuff wrote: > > From: Muiz > > All fields of the stuct use unnamed struct initialization. > Also omit the field name for `AVOption::unit` to maintain consistency. "unit" intentionally uses designated initializers, so that adding new fields before it is

[FFmpeg-devel] [PATCH] Remove struct named initializer from aac profile option.

2024-03-26 Thread Muiz Yusuff
From: Muiz All fields of the stuct use unnamed struct initialization. Also omit the field name for `AVOption::unit` to maintain consistency. --- libavcodec/profiles.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavcodec/profiles.h b/libavcodec/profiles.h index

Re: [FFmpeg-devel] [RFC] clarifying the TC conflict of interest rule

2024-03-26 Thread Anton Khirnov
The vote has been started, with the voter list generated by general_assembly.pl: # GA for 2021-01-01T00:00:00/2024-01-01T00:00:00; 50 people; SHA256:e63c3589d48557b90767f581eb1372c6c883ab87395dade38c61d0db0771fabd; HEAD:f872b1971401817356708b8863dff4ee6bd02600 If you are in the GA and have not

Re: [FFmpeg-devel] [PATCH] tests: Remove fate-libx265-hdr10

2024-03-26 Thread Anton Khirnov
Quoting Zhao Zhili (2024-03-26 03:30:21) > Ping. Is it OK to apply the patch as it is? Fine with me. -- Anton Khirnov ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link

Re: [FFmpeg-devel] [PATCH 00/21] aarch64: hevc: Add missing hevc_pel NEON functions

2024-03-26 Thread Martin Storsjö
On Tue, 26 Mar 2024, Jean-Baptiste Kempf wrote: On Mon, 25 Mar 2024, at 22:56, J. Dekker wrote: On Mon, 25 Mar 2024, Martin Storsjö wrote: Since some time, we have pretty complete AArch64 NEON coverage for the hevc decoder. However, some of these functions require the I8MM instruction set

Re: [FFmpeg-devel] [PATCH 00/21] aarch64: hevc: Add missing hevc_pel NEON functions

2024-03-26 Thread Jean-Baptiste Kempf
On Mon, 25 Mar 2024, at 22:56, J. Dekker wrote: >> On Mon, 25 Mar 2024, Martin Storsjö wrote: >> >>> Since some time, we have pretty complete AArch64 NEON coverage >>> for the hevc decoder. >>> >>> However, some of these functions require the I8MM instruction set >>> extension, and many of them