Re: [FFmpeg-devel] [PATCH v3] configure: require pkg-config for libvorbis

On 7/4/2017 8:38 PM, Paul B Mahol wrote: > This one works, so OK from me. Pushed. - Derek ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH 07/12] cngenc: Add missing error check

On 7/6/2017 10:07 PM, Rostislav Pehlivanov wrote: > Just remove setting and checking the return value altogether, > ff_lpc_calc_ref_coeffs returns the order which you give it and can't error > out. Would look good to me if you did that, so feel free to push once done. OK. - Derek

Re: [FFmpeg-devel] [PATCH 0/1] Add new encoder for camera sensor metadata

On 7/7/2017 1:36 AM, Louis O'Bryan wrote: > I am adding a new encoder for camera sensor metadata. This is an > implementation of a not-yet-published open standard for adding camera > sensor data to mp4 containers, including the GPS, acceleration, gyro, > and camera orientation. > After this change

Re: [FFmpeg-devel] [RFC][PATCH] movenc: write clap tag

On 7/7/2017 2:20 AM, Dave Rice wrote: > Currently this patch writes the clap atom under this condition > "track->par->codec_id == AV_CODEC_ID_RAWVIDEO & track->mode == MODE_MOV”; > however, AV_CODEC_ID_RAWVIDEO isn’t quite what the spec asks for. Any advice > on how to write this condition for “

Re: [FFmpeg-devel] [PATCH 0/1] Add new encoder for camera sensor metadata

On 7/7/2017 2:34 AM, Louis O'Bryan wrote: > That is fair. If that is a requirement / everyone else thinks the same, > then I will push on the team making the spec to have it public before I > submit a patch to FFmpeg. Cool; I'll wait for others' opinions, of course. Perfectly fine if you still wa

Re: [FFmpeg-devel] [PATCH] movenc: write clap tag

On 7/7/2017 3:20 AM, Dave Rice wrote: > Resolves https://trac.ffmpeg.org/ticket/6145 and writes a clap atom that is > coincident with the frames width and height. > > > From 23d80d0d47829fed61e817b1e7c3f6d420c9ab5c Mon Sep 17 00:00:00 2001 > From: Dave Rice > Date: Thu, 6 Jul 2017 21:12:38 -040

Re: [FFmpeg-devel] [PATCH] avformat: remove obsolete commented-out DEBUG define

On 7/7/2017 8:43 AM, Tobias Rapp wrote: > Signed-off-by: Tobias Rapp > --- > libavformat/avienc.c | 2 -- > libavformat/segment.c | 2 -- > 2 files changed, 4 deletions(-) LGTM. - Derek ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffm

Re: [FFmpeg-devel] [PATCH 02/12] hdsenc: Add missing goto statement

On 7/6/2017 11:38 PM, Steven Liu wrote: > Maybe there have no video stream, but have audio stream, so just give > user a warning and continue? Not an expert on the HDS code, but how can you fragment audio with no min frag size set, and no video stream? - Derek

Re: [FFmpeg-devel] [PATCH] movenc: write clap tag

On 7/7/2017 4:32 PM, Derek Buitenhuis wrote: > Patch itself LGTM. Just realized, this will change a bunch of FATE tests, won't it? - Derek ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH] movenc: write clap tag

On 7/7/2017 10:13 PM, James Almer wrote: > Isn't this necessary only for files with raw video? As is, this box > would be written on any mov file with a video stream. This was addressed a previous email: http://lists.ffmpeg.org/pipermail/ffmpeg-devel/2017-July/213350.html I guess the spec is

Re: [FFmpeg-devel] [PATCH 10/12] rtspdec: Fix return error

On 7/6/2017 7:28 PM, Derek Buitenhuis wrote: > Signed-off-by: Derek Buitenhuis > --- > libavformat/rtspdec.c | 1 - > 1 file changed, 1 deletion(-) Pushing this today if nobody objects. - Derek ___ ffmpeg-devel mailing list ffmpeg-deve

Re: [FFmpeg-devel] [PATCH] movenc:adds keywords metadata

On 7/10/2017 11:04 PM, Kieran O Leary wrote: > A user mentioned in ffmpeg-user ( > http://ffmpeg.org/pipermail/ffmpeg-user/2017-July/036571.html) that they > couldn't write the 'keywords' metadata tag. I tested this patch and it > appears to add the metadata value when using MOV and MP4 as output.

Re: [FFmpeg-devel] [PATCH] movenc:adds keywords metadata

On 7/11/2017 8:01 PM, Kieran O Leary wrote: > Thanks for taking a look. Pushed. - Derek ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH] avfilter: add motion filter

Quick scan / review follows. > +#include Do we allow C99 bool in FFmpeg? I thought we didn't. > +#define FORCE_INLINE __attribute__((always_inline)) > +#define RESTRICT __restrict av_restrict av_always_inline > +static inline int floorn(int n, int m) > +{ > +return n - n % m; > +} > + > +

Re: [FFmpeg-devel] [PATCH] avfilter: add motion filter

On 7/13/2017 3:11 PM, wm4 wrote: > We definitely use some C99 constructs in FFmpeg, but normally we don't > use stdbool.h. Yeah, but we disallow others (like VLAs), so, yeah. - Derek ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.or

Re: [FFmpeg-devel] [PATCH] avformat/riff.h : remove unused function parameter "const AVCodecTag *tags" of "void ff_put_bmp_header()"

On 7/14/2017 12:12 PM, Александр Слободенюк wrote: > It was left by the history Probably OK. - Derek ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

[FFmpeg-devel] [PATCH] webmdashenc: Fix memory leak

Signed-off-by: Derek Buitenhuis --- libavformat/webmdashenc.c | 38 ++ 1 file changed, 30 insertions(+), 8 deletions(-) diff --git a/libavformat/webmdashenc.c b/libavformat/webmdashenc.c index 550ad72e4d..1280d8a763 100644 --- a/libavformat/webmdashenc.c

Re: [FFmpeg-devel] [PATCH] webmdashenc: Fix memory leak

On 7/14/2017 3:38 PM, Derek Buitenhuis wrote: > Signed-off-by: Derek Buitenhuis > --- > libavformat/webmdashenc.c | 38 ++ > 1 file changed, 30 insertions(+), 8 deletions(-) Pushing today, unless there are objectio

Re: [FFmpeg-devel] [PATCH] avfilter: add LIBVMAF filter

On 7/16/2017 1:29 PM, Ronald S. Bultje wrote: > Pushed. > > Ronald I am going to quote myself here, because it was never address, was not even replied to, and is outright incorrect on some OSes: >> +enabled libvmaf && { check_lib libvmaf "libvmaf.h" "compute_vmaf" >> -lvmaf -lstdc++ -

Re: [FFmpeg-devel] [PATCH] avfilter: add LIBVMAF filter

On 7/16/2017 1:49 PM, Derek Buitenhuis wrote: > Students should learn to reply to reviews instead of sending new patches > with no changelog and having them pushed anyway. Furthermore: Missing a version bump. - Derek ___ ffmpeg-devel mailin

Re: [FFmpeg-devel] [PATCH] Add FITS Encoder

On 7/16/2017 1:31 PM, Paras Chadha wrote: > Signed-off-by: Paras Chadha > --- > doc/general.texi | 2 + > libavcodec/Makefile| 1 + > libavcodec/allcodecs.c | 1 + > libavcodec/fitsenc.c | 238 > + > libavformat/img2enc.c | 1 +

Re: [FFmpeg-devel] [PATCH] avfilter: add LIBVMAF filter

On 7/16/2017 2:35 PM, Ronald S. Bultje wrote: > I tested on OSX and it works fine. I'm OK with pkg-config, but since > libvmaf doesn't currently have one, we cannot rely on it. It will work fine (but link to libstdc++ unnecessarily) if you have build libvmaf as a shared library, but it will fail a

Re: [FFmpeg-devel] [PATCH] avfilter: add LIBVMAF filter

On 7/16/2017 3:15 PM, Matt Oliver wrote: > Im getting the same error. The patch had an error in it as this line is > wrong: > +vmaf_filter_deps="libvmaf" > > It should be: > +libvmaf_filter_deps="libvmaf" > > As the filter is registered as libvmaf_filter not vmaf_filter in > allfilters.cpp I've

Re: [FFmpeg-devel] [PATCH] avfilter: add LIBVMAF filter

On 7/16/2017 4:33 PM, Ashish Pratap Singh wrote: > Hi, sorry for that. > I will open a pull request soon (to libvmaf) for the pkg-config file. Thanks! - Derek ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpe

Re: [FFmpeg-devel] [PATCH 1/7] Revert "Revert "lavfi/buffersrc: push the frame deeper if requested.""

On 7/17/2017 3:19 PM, Nicolas George wrote: > This reverts commit 04aa09c4bcf2d5a634a35da3a3ae3fc1abe30ef8. > > The fate-ffm change is caused by field_order now being set > on the output format because the first frame arrives earlier. > The fate-mxf change is assumed to be the same. > > Signed-of

Re: [FFmpeg-devel] [PATCH 6/7] lavfi/framesync2: implement activate design.

On 7/17/2017 3:19 PM, Nicolas George wrote: > Signed-off-by: Nicolas George > --- > libavfilter/framesync2.c | 166 > +++ > libavfilter/framesync2.h | 77 -- > 2 files changed, 82 insertions(+), 161 deletions(-) So what does this

Re: [FFmpeg-devel] [PATCH 6/7] lavfi/framesync2: implement activate design.

On 7/18/2017 3:30 PM, Paul B Mahol wrote: > I actually like this 'design', as its more like VS one. I wasn't commenting on the code/design itself, but the commit message, or rather, lack thereof. - Derek ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg

Re: [FFmpeg-devel] [PATCH 1/7] Revert "Revert "lavfi/buffersrc: push the frame deeper if requested.""

On 7/18/2017 3:48 PM, Nicolas George wrote: > The reasons are exactly the same as the commit that it restores. I will > include that and the other comments you request once I can access my > work tree comfortably. OK. - Derek ___ ffmpeg-devel mailing li

Re: [FFmpeg-devel] [PATCH] movenc: support GPMF track (gpmd) remuxing

On 7/21/2017 9:30 AM, Clément Bœsch wrote: > +avio_wb16(pb, 1); /* Data-reference index */ Why is this whole atom hardcoded (i.e. with is '1'). - Derek ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-d

Re: [FFmpeg-devel] [PATCH 1/2] lavu/frame: add new side data type for ICC profiles

On 7/21/2017 12:55 AM, Rostislav Pehlivanov wrote: >> All this could apply to a dedicated field. Using side data only brings a >> type pruning of the actual type. Except: >> >> > Yes, it could. However I still think having it as a side data is better > since its the easiest way and that's what all

Re: [FFmpeg-devel] [PATCH] movenc: support GPMF track (gpmd) remuxing

On 7/21/2017 2:55 PM, Clément Bœsch wrote: > It's basically the same layout for every stsd sample description. Check > the other tags that extend that layout, the also have that data ref idx to > 1. I think I copied from the rtp code, but it's the same for the other as > well. This gpmd atom just e

Re: [FFmpeg-devel] [PATCH] avformat/hlsenc: support fmp4 single file mode

On 7/31/2017 5:03 AM, Steven Liu wrote: > add byterange mode of the hls fmp4 > > Signed-off-by: Steven Liu > --- > libavformat/hlsenc.c | 72 > > 1 file changed, 44 insertions(+), 28 deletions(-) > > diff --git a/libavformat/hlsenc.c b/libav

Re: [FFmpeg-devel] [PATCH v2] avformat/hlsenc: support fmp4 single file mode

On 8/1/2017 4:57 PM, Steven Liu wrote: > add byterange mode of the hls fmp4 > > Signed-off-by: Steven Liu > --- > libavformat/hlsenc.c | 83 > +--- > 1 file changed, 53 insertions(+), 30 deletions(-) [...] > +if (hls->max_seg_size > 0) {

Re: [FFmpeg-devel] [PATCH] lavf/movenc.c: Set sgpd and sbgp atoms to represent decoder delay for AAC.

On 8/4/2017 7:46 PM, Sasi Inguva wrote: > According to > https://developer.apple.com/library/content/documentation/QuickTime/QTFF/QTFFAppenG/QTFFAppenG.html > > Signed-off-by: Sasi Inguva > --- > libavformat/movenc.c| 70 > + > tests/ref/fate

Re: [FFmpeg-devel] [PATCH] lavf/movenc.c: Set sgpd and sbgp atoms to represent decoder delay for AAC.

On 8/4/2017 8:50 PM, Sasi Inguva wrote: > [...] Thanks for the reference, please add the section numbers alongside the QTFF doc in the commit message. > This patch sets the sgpd and sbgp atoms irrespective of whether it's > fragmented or not. So the byte addresses for some atoms will change for

Re: [FFmpeg-devel] [PATCH] lavf/movenc.c: Set sgpd and sbgp atoms to represent decoder delay for AAC.

On 8/4/2017 7:46 PM, Sasi Inguva wrote: > According to > https://developer.apple.com/library/content/documentation/QuickTime/QTFF/QTFFAppenG/QTFFAppenG.html > > Signed-off-by: Sasi Inguva > --- > libavformat/movenc.c| 70 > + > tests/ref/fate

Re: [FFmpeg-devel] [PATCH] lavf/movenc.c: Set sgpd and sbgp atoms to represent decoder delay for AAC.

On 8/4/2017 9:35 PM, Sasi Inguva wrote: > According to > https://developer.apple.com/library/content/documentation/QuickTime/QTFF/QTFFAppenG/QTFFAppenG.html > and ISO-IEC-14496-12 Section 10.1.1.1 and 10.1.1.3 > > Signed-off-by: Sasi Inguva > --- > libavformat/movenc.c| 70 > +

Re: [FFmpeg-devel] [PATCH] lavf/movenc.c: Set sgpd and sbgp atoms to represent decoder delay for AAC.

On 8/5/2017 5:27 PM, Derek Buitenhuis wrote: > Probably OK, if FATE changes have been confirmed to be benign. Woops, replied to the wrong patch version. - Derek ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listi

Re: [FFmpeg-devel] [PATCH] lavf/movenc.c: Set sgpd and sbgp atoms to represent decoder delay for AAC.

On 8/9/2017 1:00 AM, Sasi Inguva wrote: > According to > https://developer.apple.com/library/content/documentation/QuickTime/QTFF/QTFFAppenG/QTFFAppenG.html > and ISO-IEC-14496-12 Section 10.1.1.1 and 10.1.1.3 > > Signed-off-by: Sasi Inguva > --- > libavformat/movenc.c| 22

[FFmpeg-devel] [PATCH] mjpeg: Add support for ICC side data

his likely does not work for MJPEG files with embedded ICC profiles, but I could not find a real, exisiting file, that had that. Signed-off-by: Derek Buitenhuis --- libavcodec/mjpegdec.c | 90 +++ libavcodec/mjpegdec.h | 5 +++ 2 files changed, 95

Re: [FFmpeg-devel] [PATCH] mjpeg: Add support for ICC side data

On 8/24/2017 1:22 AM, Michael Niedermayer wrote: > should be ok i think Rostislav asked me on IRC to try with MJPEG, so I am going to try and synthesize such a file and work on a v2. I don't suppose you, or anyone else has an MJPEG file with ICC profiles embedded? :) - Derek

[FFmpeg-devel] [PATCH v2] mjpeg: Add support for ICC side data

JPEGs store embedded profiles under the APP2 marker, signified with a "ICC_PROFILE" null-terminated string header, and can be split across multiple APP2 markers, out of order. Signed-off-by: Derek Buitenhuis --- libavcodec/mjpegd

[FFmpeg-devel] [PATCH] utils: Do not expand a macro with 'defined' in it

mp; HAVE_MPROTECT && defined MAP_ANONYMOUS) ^ Signed-off-by: Derek Buitenhuis --- libswscale/utils.c | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/libswscale/utils.c b/libswscale/utils.c index b75510d..dcab707 1

Re: [FFmpeg-devel] [PATCH] utils: Do not expand a macro with 'defined' in it

On 8/24/2017 9:02 PM, Derek Buitenhuis wrote: > Fixes: > > libswscale/utils.c:1632:5: warning: macro expansion producing 'defined' > has undefined behavior [-Wexpansion-to-defined] > #if USE_MMAP > ^ > libswscale/utils.c:1577:49: note

Re: [FFmpeg-devel] [PATCH v2] mjpeg: Add support for ICC side data

On 8/25/2017 1:37 AM, Michael Niedermayer wrote: > should be ok Pushed, with an extra check added for duplicate sequence numbers. - Derek ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH] avfilter/vf_libvmaf: fix pre convert to framesync2 bugs

On 8/30/2017 2:24 PM, Ronald S. Bultje wrote: > Pushed. Did libvmaf bump its version for this breaking change? (It should have...) If so, bump the required version in configure, or other users will get crashes. - Derek ___ ffmpeg-devel mailing list ffm

Re: [FFmpeg-devel] mir-swamp.org

On 8/2/2014 5:14 PM, Michael Niedermayer wrote: > 1. Refusing members from gmail (and i assume other free mail services) > is a major problem, most people use gmail and most invites i did sent > went out to gmail users. Also there was no error or warning when > sending the invites, people just cant

Re: [FFmpeg-devel] mir-swamp.org

On 8/2/2014 5:23 PM, Derek Buitenhuis wrote: > FWIW I got an invite at my gmail account. Never mind, I can't actually register. - Derek ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] Reintroducing FFmpeg to Debian

On 8/16/2014 11:27 PM, wm4 wrote: > That is very valuable advice. We'll get to work right away. I've added it to my TODO: * Don't write bugs. - Derek ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH] mov: better check dref atome validity

On 8/21/2014 12:09 PM, Christophe Gisquet wrote: > I'm not sure it is the best fix, but I don't think this could happen > in any valid file, nor it would help to swallow the error. Perhaps off-topic, but the source drop from Elemental seems to include completely rewritten dref code -- is it worth

Re: [FFmpeg-devel] [PATCH] mov: better check dref atome validity

On 8/21/2014 4:13 PM, Michael Niedermayer wrote: > can you provide a link ? Provided on IRC. - Derek ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] OpenEXR update and question

On 8/25/2014 6:46 PM, Gonzalo Garramuno wrote: > It is patented but free to use as long as you use the openexr library. wat ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH] tests: switch to a test image that is under public domain

On 8/26/2014 12:42 AM, Michael Niedermayer wrote: [...] > tests/lena.pnm | 109 > I'm sorry but this is beyond stupid. We can't use the defacto DSP testing image because it is not *FREE* enough for Debian? It is utterly asinine to remov

Re: [FFmpeg-devel] [PATCH] tests: switch to a test image that is under public domain

On 8/26/2014 3:47 PM, Andreas Cadhalpun wrote: >> We can't use the defacto DSP testing image because it is not *FREE* enough >> for Debian? It is utterly asinine to remove it because Debian doesn't want >> to distribute Lena with source deb. They can remove it themselves. > > You could still use i

Re: [FFmpeg-devel] [PATCH] tests: Download lena.pnm if its missing from the source tree

On 8/28/2014 2:25 AM, James Almer wrote: > wget is not available on a standard Msys installation. Probably the same with > Cygwin. bc isn't standard either and FATE uses it. - Derek ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.or

Re: [FFmpeg-devel] [PATCH] tests: Download lena.pnm if its missing from the source tree

On 8/28/2014 12:28 PM, Andreas Cadhalpun wrote: > ffmpeg -f data -i http://samples.ffmpeg.org/image-samples/lena.pnm -c > copy -f data -map 0 -y lena.pnm >>> >>> From: >>> >> >> possible >> >> but would this make and

Re: [FFmpeg-devel] [PATCH] tests: Download lena.pnm if its missing from the source tree

On 8/28/2014 1:42 PM, Andreas Cadhalpun wrote: > That's clear. But it doesn't work without internet connection. > So why not use fate-rsync, which is only run manually, when internet is > available? Probably because it entails reworking the vsynth build system stuff quite a bit to placate a singl

Re: [FFmpeg-devel] Symbian port

On 8/29/2014 10:21 PM, Lou Logan wrote: > ffmpeg-user is not for help involving forks, scripts, counterfeits, or > other third-party tools. Only FFmpeg tools are supported. Please take your tribalism elsewhere. - Derek ___ ffmpeg-devel mailing list ffmp

Re: [FFmpeg-devel] patch for x32 for libpostproc

On 9/4/2014 4:33 AM, Reinhard Tartler wrote: > So the promise given in > https://lists.libav.org/pipermail/libav-devel/2012-February/020712.html > doesn't hold anymore? > > Any chance to make you reconsider reviving the standalone libpostproc.git? Guilty party here. I kinda just neglected it bec

Re: [FFmpeg-devel] [PATCH] avcodec/libx265: enable psnr reporting when requested by the user

On 9/28/2014 3:46 AM, Michael Niedermayer wrote: > applied Sorry I missed that, been very busy lately. Luckily the patch seems OK. Is there a similar flag for SSIM? - Derek ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailma

Re: [FFmpeg-devel] [PATCH] avcodec/libx265: enable psnr reporting when requested by the user

On 9/28/2014 2:26 PM, Michael Niedermayer wrote: > i dont think so, also > libxvid and libx264 use private AVOptions for ssim, OK. - Derek ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

[FFmpeg-devel] [PATCH 0/2] avfilter: Some OOM fixes

Decided to fuzz some stuff randomly again, using: https://gist.github.com/dwbuiten/7101755 Derek Buitenhuis (2): avfilter/aresample: Check for mmemory alloc failure for out sample rates avfilter: Properly check for failed format query libavfilter/af_aresample.c |5

[FFmpeg-devel] [PATCH 2/2] avfilter: Properly check for failed format query

Signed-off-by: Derek Buitenhuis --- libavfilter/avfiltergraph.c |4 +++- 1 files changed, 3 insertions(+), 1 deletions(-) diff --git a/libavfilter/avfiltergraph.c b/libavfilter/avfiltergraph.c index 9178939..a859ecb 100644 --- a/libavfilter/avfiltergraph.c +++ b/libavfilter/avfiltergraph.c

[FFmpeg-devel] [PATCH 1/2] avfilter/aresample: Check for mmemory alloc failure for out sample rates

Signed-off-by: Derek Buitenhuis --- libavfilter/af_aresample.c |5 + 1 files changed, 5 insertions(+), 0 deletions(-) diff --git a/libavfilter/af_aresample.c b/libavfilter/af_aresample.c index 5f34321..550da54 100644 --- a/libavfilter/af_aresample.c +++ b/libavfilter/af_aresample.c

Re: [FFmpeg-devel] [PATCH 0/2] avfilter: Some OOM fixes

On 10/2/2014 11:55 AM, Derek Buitenhuis wrote: > avfilter/aresample: Check for mmemory alloc failure for out sample > rates Typo fixed locally. Woops. - Derek ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/m

Re: [FFmpeg-devel] [PATCH 1/2] avfilter/aresample: Check for mmemory alloc failure for out sample rates

On 10/2/2014 11:55 AM, Derek Buitenhuis wrote: > +av_log(ctx, AV_LOG_ERROR, "Cannot allocate output sampelrates.\n"); Also fixed locally. - Derek ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/li

Re: [FFmpeg-devel] [PATCH 2/2] avcodec/libx264: Fix build with older than 142 X264_BUILD

On 10/4/2014 11:32 AM, Michael Niedermayer wrote: > untested > > Signed-off-by: Michael Niedermayer > --- > libavcodec/libx264.c |4 > 1 file changed, 4 insertions(+) ... why - Derek ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http

Re: [FFmpeg-devel] [PATCH] configure: add build tree's directories to rpath

On 10/21/2014 8:21 AM, Carl Eugen Hoyos wrote: > This sounds like a very bad idea to me I agree. It's not nice to have remnants of the build process in the installed binaries. If you need to run them during development, use LD_LIBRARY_PATH or or build statically. - Derek

Re: [FFmpeg-devel] [PATCH] lavfi/afade: fix cur_sample computation

On 10/21/2014 10:47 AM, Stefano Sabatini wrote: > -int64_t cur_sample = av_rescale_q(buf->pts, (AVRational){1, > outlink->sample_rate}, outlink->time_base); > +int64_t cur_sample = av_rescale_q(buf->pts, inlink->time_base, > (AVRational){1, inlink->sample_rate}); Probably OK. - Derek __

Re: [FFmpeg-devel] [PATCH] lavf/mov.c: Prevent memory leak in case of invalid metadata reads.

On 10/21/2014 9:12 AM, Thilo Borgmann wrote: > Subject: [PATCH] lavf/mov.c: Prevent memory leak in case of invalid metadata > reads. > > --- > libavformat/mov.c | 14 -- > 1 file changed, 8 insertions(+), 6 deletions(-) LGTM. - Derek ___

Re: [FFmpeg-devel] [PATCH]Mention in the documentation that fieldmatch needs cfr input

On 10/21/2014 8:32 AM, Carl Eugen Hoyos wrote: > +The filter only works for strictly constant frame rate input. If your input > +has variable frame rate, try the @ref{pullup} filter. Perhaps the filter should output a warning as well? - Derek ___ ffmpeg

Re: [FFmpeg-devel] [PATCH] lavd/v4l2: don't use avpriv_ prefix for internal functions

On 10/21/2014 7:56 AM, James Almer wrote: > No need to keep the old symbols around until a major bump since lavd > functions > with the avpriv_ prefix were never exposed. lol. > Signed-off-by: James Almer > --- > "avpriv_*;" can be added to libavdevice.v after this patch, but personally > I'd

Re: [FFmpeg-devel] [PATCH] lavfi/concat: accept a single segment

On 10/21/2014 10:47 AM, Stefano Sabatini wrote: > - AV_OPT_TYPE_INT, { .i64 = 2 }, 2, INT_MAX, V|A|F}, > + AV_OPT_TYPE_INT, { .i64 = 1 }, 1, INT_MAX, V|A|F}, I'm not sure I follow how this 'allows' n=1? Doesn't this just change the default? - Derek __

Re: [FFmpeg-devel] [PATCH] lavfi/concat: accept a single segment

On 10/21/2014 11:22 AM, Stefano Sabatini wrote: > - AV_OPT_TYPE_INT, { .i64 = 2 }, 2, INT_MAX, V|A|F}, > + AV_OPT_TYPE_INT, { .i64 = 2 }, 1, INT_MAX, V|A|F}, OK. - Derek ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/m

Re: [FFmpeg-devel] FFmpeg at NAB 2024

On 11/1/2023 9:25 PM, Derek Buitenhuis wrote: > This is certainly interesting considering we just had a giant thread about > not using > or using SPI, with multiple people accused of having corporate interests. Adding to the list of wtf NAB things: https://twitter.com/JanetGreco

Re: [FFmpeg-devel] [PATCH 0/3] avcodec/h264dec: Fix dropped frames when draining

On 4/3/2024 10:45 PM, arch1t3cht wrote: > Can I bump this? It's my first time sending a patch here so let me know > if I did something wrong. To me, it LGTM, but I would like someone more experience in H.264 internals to OK it, too - possibly Michael? - Derek _

[FFmpeg-devel] [PATCH 0/6] HTTP rate limiting and retry improvements

This patch set adds support for properly handling HTTP 429 codes, and their rate limiting, which is widely used and is standardized. Derek Buitenhuis (6): avutil/error: Add HTTP 429 Too Many Requests AVERROR code avformat/http: Use AVERROR_HTTP_TOO_MANY_REQUESTS avformat/http: Don't ba

[FFmpeg-devel] [PATCH 1/6] avutil/error: Add HTTP 429 Too Many Requests AVERROR code

This is a common error code from e.g. CDNs or cloud storage, and it is useful to be able to handle it differently to a generic 4XX code. Its source is RFC6585. Signed-off-by: Derek Buitenhuis --- libavutil/error.h | 1 + libavutil/version.h | 2 +- 2 files changed, 2 insertions(+), 1

[FFmpeg-devel] [PATCH 2/6] avformat/http: Use AVERROR_HTTP_TOO_MANY_REQUESTS

Added in thep previous commit. Signed-off-by: Derek Buitenhuis --- libavformat/http.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/libavformat/http.c b/libavformat/http.c index ed20359552..bbace2694f 100644 --- a/libavformat/http.c +++ b/libavformat/http.c @@ -286,6 +286,7

[FFmpeg-devel] [PATCH 3/6] avformat/http: Don't bail on parsing headers on "bad" HTTP codes

Many "bad" HTTP codes like 429 and 503 may include important info in their headers. Also, in general, there is no purpose in bailing here. Signed-off-by: Derek Buitenhuis --- libavformat/http.c | 25 - 1 file changed, 20 insertions(+), 5 deletions(-) di

[FFmpeg-devel] [PATCH 4/6] avformat/http: Add support for Retry-After header

unlikely. This adds an AVOption to respect that header. Signed-off-by: Derek Buitenhuis --- libavformat/http.c| 12 libavformat/version.h | 2 +- 2 files changed, 13 insertions(+), 1 deletion(-) diff --git a/libavformat/http.c b/libavformat/http.c index e7603037f4..8f092f108d

[FFmpeg-devel] [PATCH 5/6] avformat/http: Rename attempts to auth_attempts

This accurately reflects what it does, as per e75bbcf493aeb549d04c56f49406aeee3950d93b. Signed-off-by: Derek Buitenhuis --- libavformat/http.c | 16 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/libavformat/http.c b/libavformat/http.c index 8f092f108d

[FFmpeg-devel] [PATCH 6/6] avformat/http: Add options to set the max number of connection retries

Not every use case benefits from setting retries in terms of the backoff. Signed-off-by: Derek Buitenhuis --- libavformat/http.c| 12 +--- libavformat/version.h | 2 +- 2 files changed, 10 insertions(+), 4 deletions(-) diff --git a/libavformat/http.c b/libavformat/http.c index

[FFmpeg-devel] [PATCH 1/6] avutil/error: Add HTTP 429 Too Many Requests AVERROR code

This is a common error code from e.g. CDNs or cloud storage, and it is useful to be able to handle it differently to a generic 4XX code. Its source is RFC6585. Signed-off-by: Derek Buitenhuis --- libavutil/error.c | 1 + libavutil/error.h | 1 + libavutil/version.h | 2 +- 3 files changed

Re: [FFmpeg-devel] [PATCH 1/6] avutil/error: Add HTTP 429 Too Many Requests AVERROR code

On 4/15/2024 5:31 PM, Andreas Rheinhardt wrote: > Wouldn't you need to add a new entry to error_entries in error.c for this? You are right, I missed that since grep failed me, as error.c uses macros, and thus does not contain any AVERROR_HTTP_* directly. I have sent a v2 for this patch. - Derek

Re: [FFmpeg-devel] [PATCH 1/6] avutil/error: Add HTTP 429 Too Many Requests AVERROR code

On 4/15/2024 5:43 PM, Derek Buitenhuis wrote: > --- > libavutil/error.c | 1 + > libavutil/error.h | 1 + > libavutil/version.h | 2 +- > 3 files changed, 3 insertions(+), 1 deletion(-) This is a v2 I forgot to tag as v2. Woops. - Derek ___

[FFmpeg-devel] [PATCH 4/6 v2] avformat/http: Add support for Retry-After header

unlikely. This adds an AVOption to respect that header. Signed-off-by: Derek Buitenhuis --- libavformat/http.c| 12 libavformat/version.h | 2 +- 2 files changed, 13 insertions(+), 1 deletion(-) diff --git a/libavformat/http.c b/libavformat/http.c index e7603037f4..5ed481b63a

Re: [FFmpeg-devel] [PATCH 4/6] avformat/http: Add support for Retry-After header

On 4/15/2024 5:35 PM, James Almer wrote: > Why strtoull for an int? If the value can't be negative, then make it > unsigned and use strtoul instead. Done, v2 sent. - Derek ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/

Re: [FFmpeg-devel] [PATCH 0/3] avcodec/h264dec: Fix dropped frames when draining

On 4/9/2024 4:15 PM, Derek Buitenhuis wrote: > To me, it LGTM, but I would like someone more experience in H.264 internals > to OK it, too - possibly Michael? If there are no objections raised, I will merge this tomorrow. - Derek ___ ffmpeg

[FFmpeg-devel] [PATCH 7/6] doc/protocols: Re-order HTTP options to match http.c order

This makes the list easier to maintain. Signed-off-by: Derek Buitenhuis --- doc/protocols.texi | 112 ++--- 1 file changed, 56 insertions(+), 56 deletions(-) diff --git a/doc/protocols.texi b/doc/protocols.texi index f54600b846..5ce1ddc8f4 100644 --- a

[FFmpeg-devel] [PATCH 8/6] doc/protocols: Fill in missing HTTP options

Signed-off-by: Derek Buitenhuis --- doc/protocols.texi | 30 ++ 1 file changed, 30 insertions(+) diff --git a/doc/protocols.texi b/doc/protocols.texi index 5ce1ddc8f4..60c6d831dd 100644 --- a/doc/protocols.texi +++ b/doc/protocols.texi @@ -492,6 +492,10 @@ contains

Re: [FFmpeg-devel] [PATCH 4/6 v2] avformat/http: Add support for Retry-After header

On 4/15/2024 6:33 PM, Stefano Sabatini wrote: > missing doc/protocols.texi update Sent patch 7 and 8 to address this. - Derek ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit l

Re: [FFmpeg-devel] FFmpeg table at NAB

On 4/17/2024 12:21 AM, Devin Heitmueller wrote: > Hello all, [...] Yeah, this is exactly what I was screaming into the void about for literal months, no literally 0 response. Look for the thread: [FFmpeg-devel] FFmpeg at NAB 2024 It spans months. My last mail is particularily relevant to your

Re: [FFmpeg-devel] FFmpeg table at NAB

On 4/17/2024 2:54 PM, James Almer wrote: > But why were there GPAC people at the FFmpeg booth? > And i don't think a single person should represent the project in these > conferences to begin with. All this should go through the GA, including > who funds it and how. That is a good question, and

Re: [FFmpeg-devel] Mailinglist conduct

On 4/17/2024 8:00 PM, Ronald S. Bultje wrote: > This was an unnecessary personal attack, please don't do that again. Repeat > offense may result in temporary bans on the mailinglist and/or IRC. Please > keep it civil. That does not make it untrue, however. I would have preferred a ban. - Derek _

Re: [FFmpeg-devel] Mailinglist conduct

On 4/17/2024 8:33 PM, James Almer wrote: >>> This was an unnecessary personal attack, please don't do that again. Repeat >>> offense may result in temporary bans on the mailinglist and/or IRC. Please >>> keep it civil. >> >> That does not make it untrue, however. > > It's ok to have opinions. But

[FFmpeg-devel] [PATCH v2 0/9] HTTP rate limiting and retry improvements

d use strtoull, per James' review. * Added docs, as per Stefano's reviews./ * Added a new option to limit the total reconnect delay. * Unfortunate, but HTTP connection management is messy business. Original set link: https://ffmpeg.org/pipermail/ffmpeg-devel/2024-April/325

[FFmpeg-devel] [PATCH v2 1/9] avutil/error: Add HTTP 429 Too Many Requests AVERROR code

This is a common error code from e.g. CDNs or cloud storage, and it is useful to be able to handle it differently to a generic 4XX code. Its source is RFC6585. Signed-off-by: Derek Buitenhuis --- libavutil/error.c | 1 + libavutil/error.h | 1 + libavutil/version.h | 2 +- 3 files changed

[FFmpeg-devel] [PATCH v2 2/9] avformat/http: Use AVERROR_HTTP_TOO_MANY_REQUESTS

Added in thep previous commit. Signed-off-by: Derek Buitenhuis --- libavformat/http.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/libavformat/http.c b/libavformat/http.c index ed20359552..bbace2694f 100644 --- a/libavformat/http.c +++ b/libavformat/http.c @@ -286,6 +286,7

[FFmpeg-devel] [PATCH v2 3/9] avformat/http: Don't bail on parsing headers on "bad" HTTP codes

Many "bad" HTTP codes like 429 and 503 may include important info in their headers. Also, in general, there is no purpose in bailing here. Signed-off-by: Derek Buitenhuis --- libavformat/http.c | 25 - 1 file changed, 20 insertions(+), 5 deletions(-) di

<    4   5   6   7   8   9   10   11   12   13   >