[FFmpeg-devel] [PATCH 09/12] lavf/concat: add support for chapters

Signed-off-by: Nicolas George --- doc/demuxers.texi | 4 libavformat/concatdec.c | 12 +++- 2 files changed, 15 insertions(+), 1 deletion(-) diff --git a/doc/demuxers.texi b/doc/demuxers.texi index 6bb0574e94..0c347e3f47 100644 --- a/doc/demuxers.texi +++ b/doc/demuxers.texi

[FFmpeg-devel] [PATCH 08/12] tools/dvd2concat: specify stream_codec for subtitles

Avoid requiring a huge probe size and analyze duration. Signed-off-by: Nicolas George --- tools/dvd2concat | 1 + 1 file changed, 1 insertion(+) diff --git a/tools/dvd2concat b/tools/dvd2concat index 474b474191..ea8b7ba8c9 100755 --- a/tools/dvd2concat +++ b/tools/dvd2concat @@ -92,6 +92,7

[FFmpeg-devel] [PATCH 07/12] lavf/concatdec: add stream_codec directive

Signed-off-by: Nicolas George --- doc/demuxers.texi | 3 +++ libavformat/concatdec.c | 13 + 2 files changed, 16 insertions(+) diff --git a/doc/demuxers.texi b/doc/demuxers.texi index 87e4d0319a..6bb0574e94 100644 --- a/doc/demuxers.texi +++ b/doc/demuxers.texi @@ -181,6

[FFmpeg-devel] [PATCH 05/12] tools/dvd2concat: include language metadata

Signed-off-by: Nicolas George --- tools/dvd2concat | 2 ++ 1 file changed, 2 insertions(+) diff --git a/tools/dvd2concat b/tools/dvd2concat index ef04a87d05..474b474191 100755 --- a/tools/dvd2concat +++ b/tools/dvd2concat @@ -88,9 +88,11 @@ my $concat = "ffconcat version 1.0\n"

[FFmpeg-devel] [PATCH 06/12] tests/concat-demuxer: add stream_meta test

Signed-off-by: Nicolas George --- tests/ref/fate/concat-demuxer-simple2-lavf-ts | 4 ++-- tests/simple2.ffconcat| 2 ++ 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/tests/ref/fate/concat-demuxer-simple2-lavf-ts b/tests/ref/fate/concat-demuxer-simple2

[FFmpeg-devel] [PATCH 04/12] lavf/concatdec: support stream metadata

Signed-off-by: Nicolas George --- doc/demuxers.texi | 4 libavformat/concatdec.c | 14 -- 2 files changed, 16 insertions(+), 2 deletions(-) diff --git a/doc/demuxers.texi b/doc/demuxers.texi index fd06be3195..87e4d0319a 100644 --- a/doc/demuxers.texi +++ b/doc

[FFmpeg-devel] [PATCH 03/12] lavf/concat: deprecate file_packet_metadata

Signed-off-by: Nicolas George --- doc/demuxers.texi | 1 + libavformat/concatdec.c | 3 +++ tests/extended.ffconcat | 2 +- tests/simple1.ffconcat | 2 +- 4 files changed, 6 insertions(+), 2 deletions(-) diff --git a/doc/demuxers.texi b/doc/demuxers.texi index f338700396..fd06be3195

[FFmpeg-devel] [PATCH 02/12] lavf/concat: add file_packet_meta directive

Same as file_packet_metadata without the double parsing. Signed-off-by: Nicolas George --- doc/demuxers.texi | 5 + libavformat/concatdec.c | 9 + 2 files changed, 14 insertions(+) diff --git a/doc/demuxers.texi b/doc/demuxers.texi index eb3351833a..f338700396 100644 --- a

[FFmpeg-devel] [PATCH 01/12] lavf/concat: refactor parsing

Signed-off-by: Nicolas George --- libavformat/concatdec.c | 255 ++-- 1 file changed, 167 insertions(+), 88 deletions(-) Fixed av_dict_set() on failure. Added some space. diff --git a/libavformat/concatdec.c b/libavformat/concatdec.c index 30db456b0e

Re: [FFmpeg-devel] [PATCH 2/6] lavf/concat: add file_packet_meta directive

set are also affected by this. Thanks, I made the same mistake last time. It is counter-intuitive: realloc() does not free its argument if it fails, for example. Anyway, fixed by moving the =NULL earlier. Stand by for a new version with more features. Regards, -- Nicolas George signature.asc Desc

[FFmpeg-devel] [PATCH 6/6] tests/concat-demuxer: add stream_meta test

Signed-off-by: Nicolas George --- tests/ref/fate/concat-demuxer-simple2-lavf-ts | 4 ++-- tests/simple2.ffconcat| 2 ++ 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/tests/ref/fate/concat-demuxer-simple2-lavf-ts b/tests/ref/fate/concat-demuxer-simple2

[FFmpeg-devel] [PATCH 5/6] tools/dvd2concat: include language metadata.

Signed-off-by: Nicolas George --- tools/dvd2concat | 2 ++ 1 file changed, 2 insertions(+) diff --git a/tools/dvd2concat b/tools/dvd2concat index ef04a87d05..474b474191 100755 --- a/tools/dvd2concat +++ b/tools/dvd2concat @@ -88,9 +88,11 @@ my $concat = "ffconcat version 1.0\n"

[FFmpeg-devel] [PATCH 4/6] lavf/concatdec: support stream metadata.

Signed-off-by: Nicolas George --- doc/demuxers.texi | 4 libavformat/concatdec.c | 14 -- 2 files changed, 16 insertions(+), 2 deletions(-) diff --git a/doc/demuxers.texi b/doc/demuxers.texi index fd06be3195..87e4d0319a 100644 --- a/doc/demuxers.texi +++ b/doc

[FFmpeg-devel] [PATCH 3/6] lavf/concat: deprecate file_packet_metadata

Signed-off-by: Nicolas George --- doc/demuxers.texi | 1 + libavformat/concatdec.c | 3 +++ tests/extended.ffconcat | 2 +- tests/simple1.ffconcat | 2 +- 4 files changed, 6 insertions(+), 2 deletions(-) diff --git a/doc/demuxers.texi b/doc/demuxers.texi index f338700396..fd06be3195

[FFmpeg-devel] [PATCH 2/6] lavf/concat: add file_packet_meta directive

Same as file_packet_metadata without the double parsing. Signed-off-by: Nicolas George --- doc/demuxers.texi | 5 + libavformat/concatdec.c | 8 2 files changed, 13 insertions(+) diff --git a/doc/demuxers.texi b/doc/demuxers.texi index eb3351833a..f338700396 100644 --- a/doc

[FFmpeg-devel] [PATCH 1/6] lavf/concat: refactor parsing

Signed-off-by: Nicolas George --- libavformat/concatdec.c | 245 +--- 1 file changed, 157 insertions(+), 88 deletions(-) It does not make the code shorter, but it makes it clearer and reduces the risk of mistakes, like the ones I made myself recently. Also

Re: [FFmpeg-devel] [PATCH v2 0/8] A New Take on the Immortal Sub2Video Code

teacher? I have all the students I need, thank you very much. I have said all I have to say to you. Until you prove you understand the code as it is and as it needs to be for long-term maintenance, goodbye. -- Nicolas George signature.asc Description: PGP s

Re: [FFmpeg-devel] [PATCH v2 0/8] A New Take on the Immortal Sub2Video Code

ng FATE tests for the parts that are not yet covered, as I suggested recently. -- Nicolas George signature.asc Description: PGP signature ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscr

Re: [FFmpeg-devel] Compatibility of different library versions (was: avformat: Add internal flags for AV(In|Out)putFormat)

not be done only for libavdevice, it should be done for all libraries that use avpriv symbols too. Regards, -- Nicolas George signature.asc Description: PGP signature ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/

Re: [FFmpeg-devel] [PATCH 07/25] avfilter/graphdump: Use pointer to const for pointer to static strings

Andreas Rheinhardt (12021-08-27): > Signed-off-by: Andreas Rheinhardt > --- > libavfilter/graphdump.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) No objection to all four patches. Regards, -- Nicolas George signature.asc Description: P

Re: [FFmpeg-devel] [PATCH 3/3] lavfi/formats: document the negotiation process

Soft Works (12021-08-27): > I finally came to review your proposed changes as documented in this > patch and I also watched your presentation: This patch does not propose changes, except minor optimizations. -- A Nicolas ___ ffmpeg-devel mailing li

Re: [FFmpeg-devel] [PATCH 2/2] libavdevice: Fix a potential deadlock issue on the lock ctx->frame_lock in function avf_read_packet

fer) + c * > num_samples; \ > } > \ > @@ -1162,6 +1173,7 @@ static int avf_read_packet(AVFormatContext *s, AVPacket > *pkt) > } else { > OSStatus ret = CMBlockBu

Re: [FFmpeg-devel] [PATCH] [RFC] Add option for writing detailed filtergraph information to file or stdout

ration in your discussion. -- Nicolas George signature.asc Description: PGP signature ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-deve

Re: [FFmpeg-devel] [PATCH] [RFC] Add option for writing detailed filtergraph information to file or stdout

is useful for debugging and testing purposes but should not be accessed by regular tools. -- Nicolas George signature.asc Description: PGP signature ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-deve

Re: [FFmpeg-devel] [PATCH] [RFC] Add option for writing detailed filtergraph information to file or stdout

Soft Works (12021-08-26): > Does that answer your question? Yes. It is almost exactly what I had guessed. And therefore my answer is what I expected it do be: that does not justify thousands, or even hundreds, of lines of code in the core library and tools. -- Nicolas George signature.

Re: [FFmpeg-devel] [PATCH] [RFC] Add option for writing detailed filtergraph information to file or stdout

Soft Works (12021-08-26): > The purpose is to get a precise and detailed view of the filtergraphs > at runtime including all connections with their negotiated formats and > media types. I asked the purpose, you are rephrasing what the patch does. -- Nicolas George signature.asc De

Re: [FFmpeg-devel] [PATCH] [RFC] Add option for writing detailed filtergraph information to file or stdout

> - the hw context > - if video hw context, both: hw pixfmt + sw pixfmt > - Output can either be printed to stdout or written to specified file > - Output is machine-readable > - Can output in all the same formats like ffprobe (default, compact, flat, >

Re: [FFmpeg-devel] [PATCH] avfilter/avfilter: add a return at the end of a non-void function

James Almer (12021-08-24): > Fixes compilation with GCC 11 when configured with "--disable-optimizations > --toolchain=gcc-tsan" > > Signed-off-by: James Almer > --- > libavfilter/avfilter.c | 1 + > 1 file changed, 1 insertion(+) Ok, thanks. Regards, --

Re: [FFmpeg-devel] [PATCH] [fateserver] Cleanup and security strengthening

Michael Niedermayer (12021-08-23): > Please make sure you use g...@git.ffmpeg.org:fateserver not > g...@source.ffmpeg.org:fateserver My bad. I fixed it and it worked. Thanks. Regards, -- Nicolas George signature.asc Description: PGP sig

Re: [FFmpeg-devel] [PATCH] [fateserver] Cleanup and security strengthening

ss denied fatal: Could not read from remote repository. I think the key gives me access to some repositories (the main one, of course), but another bit of configuration is necessary to give me access to this one. Regards, -- Nicolas George signature.asc Description: PGP

Re: [FFmpeg-devel] [PATCH] [fateserver] Cleanup and security strengthening

of thing be done by the system admin? Is there one? I am not sure, I am prone to understand there is not really one. I hope at least there is a backup of the data. Regards, -- Nicolas George signature.asc Description: PGP signature ___ ffmpeg-de

Re: [FFmpeg-devel] [PATCH] [fateserver] Cleanup and security strengthening

Nicolas George (12021-08-23): > To deploy the changes cleanly, I would need write access to the > fateserver Git repository. I already have access to the FATE server > itself, but not the public repository. Any objection to me doing: New release '20.04.2 LTS' available. Run

Re: [FFmpeg-devel] [PATCH] [fateserver] Cleanup and security strengthening

Nicolas George (12021-08-23): > I will try to deploy the changes this shortly. To deploy the changes cleanly, I would need write access to the fateserver Git repository. I already have access to the FATE server itself, but not the public repository. Thanks in advance. -- Nicolas Geo

Re: [FFmpeg-devel] [PATCH] [fateserver] Cleanup and security strengthening

better. > > -<>-<>- > > sub ready_for_gzip() { > +# Under CGI, $PATH is safe > +($ENV{PATH}) = $ENV{PATH} =~ /(.*)/s; > > It is untainting the PATH as "hidden" side effect of calling > ready_for_gzip().

[FFmpeg-devel] [PATCH 2/2] fftools: add -lavfi_dump option

Signed-off-by: Nicolas George --- doc/ffmpeg.texi | 4 fftools/ffmpeg.h| 1 + fftools/ffmpeg_filter.c | 14 ++ fftools/ffmpeg_opt.c| 3 +++ 4 files changed, 22 insertions(+) This will be useful for tests covering suble cases of the format negotiation. I

[FFmpeg-devel] [PATCH 1/2] lavfi/graphdump: add plain listing output

Signed-off-by: Nicolas George --- libavfilter/avfilter.h | 5 ++- libavfilter/graphdump.c | 79 +++-- 2 files changed, 80 insertions(+), 4 deletions(-) diff --git a/libavfilter/avfilter.h b/libavfilter/avfilter.h index 69ecb0186d..2a3c1e79a8 100644 --- a

[FFmpeg-devel] FATE coverage for format negotiation

the one that is most similar. Regards, -- Nicolas George signature.asc Description: PGP signature ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email

[FFmpeg-devel] [PATCH 2/2] lavi/pixdesc: simplify depth computatoin in get_pix_fmt_score().

Signed-off-by: Nicolas George --- libavutil/pixdesc.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/libavutil/pixdesc.c b/libavutil/pixdesc.c index f1898a6a13..967de7dcde 100644 --- a/libavutil/pixdesc.c +++ b/libavutil/pixdesc.c @@ -2721,10 +2721,10 @@ static int

[FFmpeg-devel] [PATCH 1/2] lavu/pixdesc: remove get_pix_fmt_depth().

Apart from erroring when nb_components == 0, it is dead code. nb_components == 0 only for HW formats, and HW formats are handled earlier in get_pix_fmt_score(). Signed-off-by: Nicolas George --- libavutil/pixdesc.c | 26 +- 1 file changed, 1 insertion(+), 25 deletions

Re: [FFmpeg-devel] [PATCH 1/4] libavformat/concatdec: remove support for unsafe=-1

Nicolas George (12021-08-20): > Second patch updated with Andrea's comments. > Final patch removing the in-protocol option syntax withdrawn for now. > Other patches unchanged. > Will push soon. Series pushed. Regards, -- Nicolas George signature.asc Descripti

Re: [FFmpeg-devel] [PATCH v3 02/25] avfilter/avfilter: Allow to free non-static pads generically

int ff_append_inpad (AVFilterContext *f, AVFilterPad *p); > int ff_append_outpad(AVFilterContext *f, AVFilterPad *p); > +int ff_append_inpad_free_name (AVFilterContext *f, AVFilterPad *p); > +int ff_append_outpad_free_name(AVFilterContext *f, AVFilterPad *p); > > /** > * Req

Re: [FFmpeg-devel] [PATCH 09/10] avfilter/formats: Don't set samplerate or channel count on video links

t work was to reproduce every tiny quirk of the framework because some filter used them. It would have been much more convenient if they had been explicit like that. Regards, -- Nicolas George signature.asc Description: PGP signature ___ ffmpeg-deve

Re: [FFmpeg-devel] [PATCH 4/6] avfilter/avfilter: Allow to free non-static pads generically

_in/out_pad(). If you are not convinced, we can try the experiment with an innocent bystander: pick somebody neutral, explain your proposal from scratch, I explain my proposal from scratch, and we see what they think. Regards, -- Nicolas George signature.asc Description: PGP signature

Re: [FFmpeg-devel] [PATCH v1 0/2] libavformat/protocols.c: avio_enum_protocols(): Cleanup

Nicolas George (12021-08-20): > Please do not hijack threads. See the mailing-list FAQ. Please disregard this, I made a mistake. Sorry for wasting everybody's time. -- Nicolas George signature.asc Description: PGP signature ___ ffmp

Re: [FFmpeg-devel] [PATCH v1 0/2] libavformat/protocols.c: avio_enum_protocols(): Cleanup

See the mailing-list FAQ. -- Nicolas George signature.asc Description: PGP signature ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...

[FFmpeg-devel] [PATCH 4/4] tools/dvd2concat: use option keyword

subfile,,start,X,end,Y,,: is ugly and will be gone some day. Signed-off-by: Nicolas George --- tools/dvd2concat | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/tools/dvd2concat b/tools/dvd2concat index 0280838a6b..ef04a87d05 100755 --- a/tools/dvd2concat +++ b/tools

[FFmpeg-devel] [PATCH 3/4] tools/dvd2concat: document that -protocol_whitelist is needed

Signed-off-by: Nicolas George --- tools/dvd2concat | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/tools/dvd2concat b/tools/dvd2concat index 8effee86b9..0280838a6b 100755 --- a/tools/dvd2concat +++ b/tools/dvd2concat @@ -37,7 +37,8 @@ normally contains a directory named B

[FFmpeg-devel] [PATCH 2/4] lavf/concatdec: support per-file options

Signed-off-by: Nicolas George --- doc/demuxers.texi | 4 libavformat/concatdec.c | 35 ++- 2 files changed, 38 insertions(+), 1 deletion(-) diff --git a/doc/demuxers.texi b/doc/demuxers.texi index 5f18e4551b..eb3351833a 100644 --- a/doc/demuxers.texi

[FFmpeg-devel] [PATCH 1/4] libavformat/concatdec: remove support for unsafe=-1

It only makes sense as the default value, but it is not the default since 689211d5727231c3fe92762d224dbadebdbf4e30. Signed-off-by: Nicolas George --- doc/demuxers.texi | 9 +++-- libavformat/concatdec.c | 6 ++ 2 files changed, 5 insertions(+), 10 deletions(-) Second patch

Re: [FFmpeg-devel] [PATCH] dox/examples/encode_video: add explanations in comments.

Jan Ekström (12021-08-20): > Looks good to me with the dox->doc fixup you've already done in the > commit message. Thanks, pushed. Regards, -- Nicolas George signature.asc Description: PGP signature ___ ffmpeg-devel mailing lis

Re: [FFmpeg-devel] [PATCH] lavfi: merge AVFilterChannelLayouts into AVFilterFormats.

I do not think it worth sending it again. Regards, -- Nicolas George signature.asc Description: PGP signature ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or

Re: [FFmpeg-devel] [PATCH 3/3] lavfi/formats: document the negotiation process

Nicolas George (12021-08-19): > + *FIXME: the similarity logic (the ref argument to > + *pick_format()) added in FFmpeg duplicates and > + *overrides the swapping logic added in libav. Better > + *merge

Re: [FFmpeg-devel] Third opinion? (was: lavf/avio: remove support for proto, , opt, val, , syntax.)

6]subfile:file02.bin Anyway, I think I can push the series except for the last patch now. Any objection? Regards, -- Nicolas George signature.asc Description: PGP signature ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/m

Re: [FFmpeg-devel] [PATCH] dox/examples/encode_video: add explanations in comments.

Nicolas George (12021-08-16): > Signed-off-by: Nicolas George > --- > doc/examples/encode_video.c | 24 +--- > 1 file changed, 21 insertions(+), 3 deletions(-) I fixed dox → doc in the subject. Will push soon unless somebody comments. Regards, -- Ni

Re: [FFmpeg-devel] [PATCH 09/10] avfilter/formats: Don't set samplerate or channel count on video links

l > - * layouts/sample rates. If there are no links hooked to this filter, the > list > - * is freed. > + * Helpers for query_formats() which set all free audio links to the same > list > + * of channel layouts/sample rates. If there are no links hooked to this > list, >

Re: [FFmpeg-devel] [PATCH 05/10] avfilter/avfilter: Deprecate avfilter_pad_count()

> 2 files changed, 8 insertions(+) LGTM. Regards, -- Nicolas George signature.asc Description: PGP signature ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or

Re: [FFmpeg-devel] [PATCH 10/10] avfilter/avfiltergraph: Remove dead checks

t > --- > This relies on no audio parts being set for video links, but this is > indeed so since the last commit. > > libavfilter/avfiltergraph.c | 22 +- > 1 file changed, 1 insertion(+), 21 deletions(-) Looks ok. Regards, -- Nicolas George signatu

Re: [FFmpeg-devel] [PATCH 08/10] avfilter/formats: Avoid redundant counter

we don't have to keep track of whether we > have attached the list to an owner. > > Signed-off-by: Andreas Rheinhardt > --- > libavfilter/formats.c | 7 ++- > 1 file changed, 2 insertions(+), 5 deletions(-) Should be ok. Regards, -- Nicolas Geor

Re: [FFmpeg-devel] [PATCH 04/10] fftools/cmdutils: Switch to avfilter_filter_pad_count()

Andreas Rheinhardt (12021-08-15): > Signed-off-by: Andreas Rheinhardt > --- > fftools/cmdutils.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) LGTM but I do not maintain this. Regards, -- Nicolas George signature.asc Description: P

Re: [FFmpeg-devel] [PATCH 01/10] fftools/cmdutils: Use avfilter_pad_count() for AVFilter's number of pads

= 0; pad && avfilter_pad_get_name(pad, j); j++) { > +nb_pads = avfilter_pad_count(pad); > +for (j = 0; j < nb_pads; j++) { > if (descr_cur >= descr + sizeof(descr) - 4) > break; > *(descr_cur++) = > ge

[FFmpeg-devel] [PATCH] lavfi: merge AVFilterChannelLayouts into AVFilterFormats.

Make AVFilterFormats.formats uint64_t. They are short-lived lists and usually quite short too. Signed-off-by: Nicolas George --- I think the simplification in formats.c is well worth the cost in memory: most of the lines removed are hard-to-maintain macro code. Furthermore, it will make

Re: [FFmpeg-devel] [PATCH 03/10] avfilter/avfilter: Add avfilter_filter_pad_count()

libavfilter/avfilter.h | 5 + > 2 files changed, 10 insertions(+) LGTM. Regards, -- Nicolas George signature.asc Description: PGP signature ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-dev

Re: [FFmpeg-devel] [PATCH 02/10] avfilter/avfilter: Add numbers of (in|out)pads directly to AVFilter

S and FF_FILTER_OUTPUTS instead of just FILTER like everywhere else. I suppose you missed it because it depends on a proprietary operating system. I do not mind if you break it, but I suppose other would ;-) LGTM apart from that. Regards, -- Nicolas George signature.asc Description: PGP si

Re: [FFmpeg-devel] [PATCH 1/3] lavfi/formats: cosmetic: move negotiation stuff at the end

Nicolas George (12021-08-19): > Since these three patches are cosmetic and internal documentation, I > will push soon, probably as soon as I have something new to post on top > of them. Series pushed. > Anton and Michael: you are the authors of the redundant similarity > log

Re: [FFmpeg-devel] Implementing FATE tests

ot;add fate tests" that is about a filter, and see what it does. For example: https://git.ffmpeg.org/gitweb/ffmpeg.git/commit/06aab9790db1f7cd57bdcba6008c5e7f4030c7c4 Regards, -- Nicolas George signature.asc Description: PGP signature ___ ffm

Re: [FFmpeg-devel] [PATCH] lavfi/formats: document the negotiation process.

partial negotiation system that I regret introducing for amerge and is now used by about two and a half filters. This is one of the things that needs overhauling. Regards, -- Nicolas George signature.asc Description: PGP signature ___ ffmpeg-devel

Re: [FFmpeg-devel] [PATCH] avfilter/avfiltergraph: Don't use AVClass * for logcontext

Andreas Rheinhardt (12021-08-20): > Forgotten in 57fa314090ab006808911fd790053b534749aa53. > > Signed-off-by: Andreas Rheinhardt > --- > libavfilter/avfiltergraph.c | 13 ++--- > 1 file changed, 6 insertions(+), 7 deletions(-) Ok of course, thanks. Regards, --

Re: [FFmpeg-devel] [PATCH 2/3] lavfi/sine: switch to activate.

Paul B Mahol (12021-08-19): > will apply ASAP! Sorry, completely slipped my mind. Please go ahead. Regards, -- Nicolas George signature.asc Description: PGP signature ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.

[FFmpeg-devel] [PATCH 3/3] lavfi/formats: document the negotiation process

Signed-off-by: Nicolas George --- libavfilter/formats.h | 85 +++ 1 file changed, 85 insertions(+) diff --git a/libavfilter/formats.h b/libavfilter/formats.h index d94977a3aa..7c8258ed08 100644 --- a/libavfilter/formats.h +++ b/libavfilter/formats.h

[FFmpeg-devel] [PATCH 2/3] lavfi/formats: rename AVFilterNegotiation.nb to nb_mergers

Signed-off-by: Nicolas George --- libavfilter/avfiltergraph.c | 6 +++--- libavfilter/formats.c | 4 ++-- libavfilter/formats.h | 2 +- 3 files changed, 6 insertions(+), 6 deletions(-) diff --git a/libavfilter/avfiltergraph.c b/libavfilter/avfiltergraph.c index 41a91a9bda

[FFmpeg-devel] [PATCH 1/3] lavfi/formats: cosmetic: move negotiation stuff at the end

It was between AVFilterFormats and AVFilterChannelLayouts. Signed-off-by: Nicolas George --- libavfilter/formats.h | 30 +++--- 1 file changed, 15 insertions(+), 15 deletions(-) The last commit is the one I sent earlier, just rebased on top of this cosmetic change

[FFmpeg-devel] [PATCH] lavfi/formats: document the negotiation process.

Signed-off-by: Nicolas George --- libavfilter/formats.h | 85 +++ 1 file changed, 85 insertions(+) diff --git a/libavfilter/formats.h b/libavfilter/formats.h index ed513c265a..b3e780a41d 100644 --- a/libavfilter/formats.h +++ b/libavfilter/formats.h

Re: [FFmpeg-devel] [PATCH 4/9] avfilter/overlay_subs: Add overlay_subs filter

Nicolas George (12021-08-19): > This is not that hard to do. As I pointed, I already started working on > it. It would have gone faster if there were other people interesting in, > reviewing the code trustfully and offering useful suggestions. This is the notes I have taken abo

Re: [FFmpeg-devel] [PATCH 4/9] avfilter/overlay_subs: Add overlay_subs filter

not be that guy. I am very happy if somebody wants to seriously work on subtitles in libavfilter, but seriously is an important word here. If it was as easy as slapping a few pieces of code around like you did, I would already have done it years ago. The first step in libavfilter is to refa

Re: [FFmpeg-devel] [PATCH 2/9] avfilter/subtitles: Add subtitles.c

> and the 'eval' test had a different result for > > Evaluating 'not(NAN)' > 'not(NAN)' -> 0.00 > (but I got 'not(NAN)' -> 1.00) This is suspicious. Regards, -- Nicolas George signature.asc Description: PGP signature ___

Re: [FFmpeg-devel] [PATCH 2/9] avfilter/subtitles: Add subtitles.c

Soft Works (12021-08-19): > And patchwork running Fate? You do not need to care. I pretty much hope you run FATE, including samples, yourself before sending any patch. -- Nicolas George signature.asc Description: PGP signature ___ ffmpeg-de

Re: [FFmpeg-devel] [PATCH 2/9] avfilter/subtitles: Add subtitles.c

Soft Works (12021-08-19): > I can't update my patch before it's committed You can, you just need to apply Andrea's patch on your tree. -- Nicolas George signature.asc Description: PGP signature ___ ffmpeg-devel mailing list ffmpe

Re: [FFmpeg-devel] [PATCH 2/9] avfilter/subtitles: Add subtitles.c

Soft Works (12021-08-19): > You mean Andreas' work? Committed or uncommitted? https://ffmpeg.org/pipermail/ffmpeg-devel/2021-August/283930.html Approved but not yet committed. Regards, -- Nicolas George signature.asc Description: PGP s

Re: [FFmpeg-devel] [PATCH 4/9] avfilter/overlay_subs: Add overlay_subs filter

s, you need to have a clear idea of how it will work in the final version. Again, that means discussing before implementing. Regards, -- Nicolas George signature.asc Description: PGP signature ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http

Re: [FFmpeg-devel] [PATCH 2/9] avfilter/subtitles: Add subtitles.c

4 files changed, 112 insertions(+) > create mode 100644 libavfilter/subtitles.c > create mode 100644 libavfilter/subtitles.h The change in internal.h is conflicting with Andrea's work. Regards, -- Nicolas George signature.asc Description: PGP signature

Re: [FFmpeg-devel] [PATCH 4/9] avfilter/overlay_subs: Add overlay_subs filter

that this refactoring of negotiation is not only for subtitles: it also helps for data packets and for partial graph reconfiguration. Regards, -- Nicolas George signature.asc Description: PGP signature ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org

Re: [FFmpeg-devel] [PATCH 4/6] avfilter/avfilter: Allow to free non-static pads generically

; to each ff_insert_(in|out)pad() call. Just the name of the flag requires eight times as much characters in the source code. Regards, -- Nicolas George signature.asc Description: PGP signature ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http

Re: [FFmpeg-devel] [PATCH v2] doc/git-howto: be more strict about commit message formatting.

that whole page > for corrections and improvements. Ok. Pushed. Thanks. Regards, -- Nicolas George signature.asc Description: PGP signature ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-de

Re: [FFmpeg-devel] [WIP] Event loop

eduler. Since I could not find one, I will try to start again on this soon. Do you have an opinion on the low-level single-thread API? Can you share some details about the needs your special device? I would consider them when writing the API. Regards, -- Nicolas George signature.asc Descriptio

Re: [FFmpeg-devel] [PATCH 4/6] avfilter/avfilter: Allow to free non-static pads generically

drawback that the information about the nature of the pads ends up at two places of the code that are not close to each other. It is not good for maintenance and readability. I think a boolean flag to ff_append_...pad() would do the job much more elegantly. What do you think about it? Regard

Re: [FFmpeg-devel] [PATCH 2/6] avfilter/avfilter: Remove unused feature to add pads in the middle

s/ff_insert_pad/ff_append_pad/' *.[ch] sed -i 's/ff_insert_inpad/ff_append_inpad/' *.[ch] sed -i 's/ff_insert_outpad/ff_append_outpad/' *.[ch] would be in order. Regards, -- Nicolas George signature.asc Description: PGP signature ___

Re: [FFmpeg-devel] [PATCH 1/6] avfilter/internal: Replace AVFilterPad.needs_writable by flags

anged, 41 insertions(+), 36 deletions(-) LGTM. I do not maintain most of these files, but it it straightforward enough. Regards, -- Nicolas George signature.asc Description: PGP signature ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg

Re: [FFmpeg-devel] [PATCH 1/3] avfilter/avfilter: Remove redundant assignment

Andreas Rheinhardt (12021-08-17): > av_frame_copy_props() already copies pts. > > Signed-off-by: Andreas Rheinhardt > --- > libavfilter/avfilter.c | 1 - > 1 file changed, 1 deletion(-) All three look ok. Thanks. Regards, -- Nicolas George signature.asc Descript

Re: [FFmpeg-devel] [PATCH 02/23] avfilter/internal: Uninline ff_insert_(in|out)pad()

n for the two ff_ functions. They are declared in a header, the documentation should be there. Regards, -- Nicolas George signature.asc Description: PGP signature ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listin

Re: [FFmpeg-devel] [PATCH v2] doc/git-howto: be more strict about commit message formatting.

the summary. I see some people call it the subject. > Seems OK. Don't mind if I rephrase, later on. I will leave some more time then. Regards, -- Nicolas George signature.asc Description: PGP signature ___ ffmpeg-devel mailing list ffmpe

[FFmpeg-devel] [PATCH] dox/examples/encode_video: add explanations in comments.

Signed-off-by: Nicolas George --- doc/examples/encode_video.c | 24 +--- 1 file changed, 21 insertions(+), 3 deletions(-) diff --git a/doc/examples/encode_video.c b/doc/examples/encode_video.c index 908eb203d5..939ed68324 100644 --- a/doc/examples/encode_video.c +++ b/doc

[FFmpeg-devel] [PATCH v2] doc/git-howto: be more strict about commit message formatting.

Explain the format of the first line: "context: summary". Add examples and explain bad practices. Make it a section, so that we can link to it. Signed-off-by: Nicolas George --- doc/git-howto.texi | 46 ++ 1 file changed, 38 insertions(+), 8

Re: [FFmpeg-devel] [PATCH 23/23] avfilter: Remove init_opaque callback

--- > libavfilter/avfilter.c | 4 +--- > libavfilter/avfilter.h | 7 --- > 2 files changed, 1 insertion(+), 10 deletions(-) Should be ok. I do not maintain the other files, but the changes are straightforward and should be ok. Thanks. -- Nicolas George signature.asc

Re: [FFmpeg-devel] [PATCH 10/23] avfilter/avf_concat: Free pads' names generically

Andreas Rheinhardt (12021-08-12): > Signed-off-by: Andreas Rheinhardt > --- > libavfilter/avf_concat.c | 14 +++--- > 1 file changed, 3 insertions(+), 11 deletions(-) LGTM. Regards, -- Nicolas George signature.asc Description: P

Re: [FFmpeg-devel] [PATCH 05/23] avfilter/af_amerge: Free inpads' names generically

Andreas Rheinhardt (12021-08-12): > Signed-off-by: Andreas Rheinhardt > --- > libavfilter/af_amerge.c | 7 ++- > 1 file changed, 2 insertions(+), 5 deletions(-) LGTM. Regards, -- Nicolas George signature.asc Description: P

Re: [FFmpeg-devel] [PATCH 03/23] avfilter/avfilter: Allow to free pads generically

first flag and FREE_NAME as a new flag. That way, you do not need to distinguish input and output pads in the surrounding code. But since you already wrote the code, I will not insist if you prefer to keep it as it is. Regards, -- Nicolas George signature.a

Re: [FFmpeg-devel] [PATCH 02/23] avfilter/internal: Uninline ff_insert_(in|out)pad()

ned index, AVFilterPad *p); > > /** Insert a new output pad for the filter. */ > -static inline int ff_insert_outpad(AVFilterContext *f, unsigned index, > - AVFilterPad *p) > -{ > -return ff_insert_pad(index, &f->nb_outputs, offsetof(AVFi

Re: [FFmpeg-devel] [PATCH] avfilter: add (a)segment filters

{ > +.name = "default", > +.type = AVMEDIA_TYPE_VIDEO, > +.config_props = config_input, > +}, > +{ NULL } > +}; > + > +const AVFilter ff_vf_segment = { > +.name= "segment", > +.description = NULL_IF_CONFIG_SMALL

Re: [FFmpeg-devel] Patchwork hook for bad commit messages

and admittedly a few exceptional case. Since these are warnings and can safely be ignored, I think it is an acceptable rate of false-positives. Regards, -- Nicolas George def check_commit_message(msg) : (summary, _, rest) = msg.partition("\n") (sep, _, body) = rest.partition(&qu

Re: [FFmpeg-devel] Optimised math functions in FFMPEG?

Please give a little details. If you want to speed your filter up, the best would be to make it work with integers. It would also allow to make reliable unit tests. Regards, -- Nicolas George signature.asc Description: PGP signature ___ ffmpeg-deve

<    3   4   5   6   7   8   9   10   11   12   >