[FFmpeg-devel] [PATCH 4/4] rl.h: remove deprecated and now unused vlc member.

2014-08-31 Thread Reimar Döffinger
--- libavcodec/mpeg12.c| 13 +++-- libavcodec/mpegvideo.c | 8 libavcodec/rl.h| 8 3 files changed, 15 insertions(+), 14 deletions(-) diff --git a/libavcodec/mpeg12.c b/libavcodec/mpeg12.c index 27d680f..cb00baf 100644 --- a/libavcodec/mpeg12.c +++

Re: [FFmpeg-devel] [PATCH 1/2] h261, h263 decoders: convert to RL_VLC.

2014-08-31 Thread Reimar Döffinger
On Sun, Aug 31, 2014 at 03:38:21PM +0200, Reimar Döffinger wrote: On Sun, Aug 31, 2014 at 09:24:24AM -0400, Ronald S. Bultje wrote: On Sun, Aug 31, 2014 at 8:54 AM, Reimar Döffinger reimar.doeffin...@gmx.de wrote: I forgot to say: this is the first time I use this API, and I

Re: [FFmpeg-devel] [PATCH 1/4] h261, h263 decoders: convert to RL_VLC.

2014-08-31 Thread Reimar Döffinger
On Sun, Aug 31, 2014 at 05:44:09PM +0200, Michael Niedermayer wrote: On Sun, Aug 31, 2014 at 04:48:41PM +0200, Reimar Döffinger wrote: Some additional optimizations in following patch. what effect on speed do these patches have ? No idea at this point. If someone else feels like

Re: [FFmpeg-devel] [PATCH 1/4] h261, h263 decoders: convert to RL_VLC.

2014-08-31 Thread Reimar Döffinger
On Sun, Aug 31, 2014 at 06:28:24PM +0200, Reimar Döffinger wrote: On Sun, Aug 31, 2014 at 05:44:09PM +0200, Michael Niedermayer wrote: On Sun, Aug 31, 2014 at 04:48:41PM +0200, Reimar Döffinger wrote: Some additional optimizations in following patch. what effect on speed do

Re: [FFmpeg-devel] [PATCH] intmath.h: Remove duplicated ARM include.

2014-08-31 Thread Reimar Döffinger
On Sun, Aug 31, 2014 at 06:18:14PM +0200, Michael Niedermayer wrote: On Sun, Aug 31, 2014 at 12:29:04PM +0200, Reimar Döffinger wrote: Signed-off-by: Reimar Döffinger reimar.doeffin...@gmx.de --- libavutil/intmath.h | 4 1 file changed, 4 deletions(-) LGTM Pushed

Re: [FFmpeg-devel] [PATCH] aacps_tablegen: replace TABLE_CONST by const.

2014-08-31 Thread Reimar Döffinger
On Sun, Aug 31, 2014 at 06:19:37PM +0200, Michael Niedermayer wrote: On Sun, Aug 31, 2014 at 12:42:15PM +0200, Reimar Döffinger wrote: Doesn't change generated code, just is more consistent and a bit less error-prone. Signed-off-by: Reimar Döffinger reimar.doeffin...@gmx.de

Re: [FFmpeg-devel] [PATCH 3/4] ituh263dec: Optimize new RL_VLC based decoding.

2014-08-31 Thread Reimar Döffinger
On Sun, Aug 31, 2014 at 07:09:13PM +0200, Michael Niedermayer wrote: On Sun, Aug 31, 2014 at 04:48:43PM +0200, Reimar Döffinger wrote: @@ -549,11 +549,8 @@ retry: av_log(s-avctx, AV_LOG_ERROR, run overflow at %dx%d i:%d\n, s-mb_x, s-mb_y, s-mb_intra); return -1

Re: [FFmpeg-devel] [PATCH 3/4] ituh263dec: Optimize new RL_VLC based decoding.

2014-08-31 Thread Reimar Döffinger
On Sun, Aug 31, 2014 at 08:14:04PM +0200, Michael Niedermayer wrote: On Sun, Aug 31, 2014 at 08:06:54PM +0200, Reimar Döffinger wrote: On Sun, Aug 31, 2014 at 07:09:13PM +0200, Michael Niedermayer wrote: On Sun, Aug 31, 2014 at 04:48:43PM +0200, Reimar Döffinger wrote: @@ -549,11 +549,8

[FFmpeg-devel] [PATCH] rl.h: Allocate temporary VLC tables instead of having them static.

2014-08-31 Thread Reimar Döffinger
Signed-off-by: Reimar Döffinger reimar.doeffin...@gmx.de --- libavcodec/mpeg12.c| 23 --- libavcodec/mpegvideo.c | 14 ++ libavcodec/rl.h| 8 ++-- 3 files changed, 24 insertions(+), 21 deletions(-) diff --git a/libavcodec/mpeg12.c b/libavcodec

Re: [FFmpeg-devel] [PATCH] rl.h: Allocate temporary VLC tables instead of having them static.

2014-08-31 Thread Reimar Döffinger
On Sun, Aug 31, 2014 at 08:27:17PM +0200, Reimar Döffinger wrote: Signed-off-by: Reimar Döffinger reimar.doeffin...@gmx.de This was intended to come out under rl.h: remove deprecated and now unused vlc member., as that one needs to be applied first. I can merge them though if desired. I

[FFmpeg-devel] [PATCH] h261dec, ituh263dec: Avoid unnecessary -1 inside inner loop.

2014-08-31 Thread Reimar Döffinger
3646 - 3597 decicycles in inner loop when decoding vsynth1-flv. Signed-off-by: Reimar Döffinger reimar.doeffin...@gmx.de --- libavcodec/h261dec.c| 7 --- libavcodec/ituh263dec.c | 9 + 2 files changed, 9 insertions(+), 7 deletions(-) diff --git a/libavcodec/h261dec.c b

[FFmpeg-devel] [PATCH] h261dec, ituh263dec: ensure CLOSE_READER is done on error paths, too.

2014-08-31 Thread Reimar Döffinger
Signed-off-by: Reimar Döffinger reimar.doeffin...@gmx.de --- libavcodec/h261dec.c| 2 ++ libavcodec/ituh263dec.c | 4 ++-- 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/libavcodec/h261dec.c b/libavcodec/h261dec.c index c9470b1..9b95775 100644 --- a/libavcodec/h261dec.c +++ b

[FFmpeg-devel] [PATCH] mpegaudiodec: share identical tables between float and fixed decoder.

2014-08-31 Thread Reimar Döffinger
ff_mpa_table_4_3_value alone saves over 128kB. Signed-off-by: Reimar Döffinger reimar.doeffin...@gmx.de --- libavcodec/Makefile| 24 +++--- libavcodec/mpegaudio_tablegen.c| 13 +-- libavcodec/mpegaudio_tablegen.h| 26 +++--- libavcodec/mpegaudiodec_common.c | 135

Re: [FFmpeg-devel] [PATCH] h261dec, ituh263dec: ensure CLOSE_READER is done on error paths, too.

2014-08-31 Thread Reimar Döffinger
On Sun, Aug 31, 2014 at 09:56:03PM +0200, Michael Niedermayer wrote: On Sun, Aug 31, 2014 at 09:40:05PM +0200, Reimar Döffinger wrote: Signed-off-by: Reimar Döffinger reimar.doeffin...@gmx.de --- libavcodec/h261dec.c| 2 ++ libavcodec/ituh263dec.c | 4 ++-- 2 files changed, 4

Re: [FFmpeg-devel] [PATCH 1/4] h261, h263 decoders: convert to RL_VLC.

2014-08-31 Thread Reimar Döffinger
On Sun, Aug 31, 2014 at 09:32:45PM +0200, Michael Niedermayer wrote: On Sun, Aug 31, 2014 at 04:48:41PM +0200, Reimar Döffinger wrote: -code = get_vlc2(s-gb, rl-vlc.table, TCOEFF_VLC_BITS, 2); -if (code 0) { +UPDATE_CACHE(re, s-gb); +GET_RL_VLC(level, run

[FFmpeg-devel] [PATCH] h261dec, ituh263dec: Move condition.

2014-08-31 Thread Reimar Döffinger
Stops compiler from doing incredibly stupid things. With vsynth1-flv inner loop goes from 3501 to 3275 decicycles. Signed-off-by: Reimar Döffinger reimar.doeffin...@gmx.de --- libavcodec/h261dec.c| 12 ++-- libavcodec/ituh263dec.c | 10 +- 2 files changed, 11 insertions

[FFmpeg-devel] [PATCH] ac3dec: avoid duplicating symbols between fixed and float decoder.

2014-08-31 Thread Reimar Döffinger
Signed-off-by: Reimar Döffinger reimar.doeffin...@gmx.de --- libavcodec/ac3.h | 4 +- libavcodec/ac3dec.c | 188 +++ libavcodec/ac3dec_data.c | 138 ++ libavcodec/ac3dec_data.h | 15 4 files changed

Re: [FFmpeg-devel] [PATCH v4] Add SUP/PGS subtitle demuxer

2014-08-31 Thread Reimar Döffinger
On Mon, Sep 01, 2014 at 12:05:23AM +0200, wm4 wrote: +for (nb_packets = 0; nb_packets 10; nb_packets++) { +size_t full_packet_size; +if (buf_size 10 + 3) +break; +if (memcmp(buf, PG, 2)) +return 0; AV_RB16(buf) != SUP_PGS_MAGIC would

Re: [FFmpeg-devel] [PATCH] lavu/hash.c: Add missing static const.

2014-08-30 Thread Reimar Döffinger
On Fri, Aug 29, 2014 at 09:29:46PM +0200, Clément Bœsch wrote: On Fri, Aug 29, 2014 at 06:34:52PM +0200, Reimar Döffinger wrote: Signed-off-by: Reimar Döffinger reimar.doeffin...@gmx.de --- libavutil/hash.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavutil

[FFmpeg-devel] [PATCH 5/6] xv.c: Add missing const to lookup table.

2014-08-30 Thread Reimar Döffinger
Signed-off-by: Reimar Döffinger reimar.doeffin...@gmx.de --- libavdevice/xv.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/libavdevice/xv.c b/libavdevice/xv.c index aeb3e41..c19c15c 100644 --- a/libavdevice/xv.c +++ b/libavdevice/xv.c @@ -67,7 +67,7 @@ typedef struct

[FFmpeg-devel] [PATCH 4/6] lavf: add const/static const to pix_fmts arrays.

2014-08-30 Thread Reimar Döffinger
Signed-off-by: Reimar Döffinger reimar.doeffin...@gmx.de --- libavfilter/vf_blackdetect.c| 2 +- libavfilter/vf_lenscorrection.c | 2 +- libavfilter/vf_signalstats.c| 2 +- libavfilter/vf_tinterlace.c | 2 +- 4 files changed, 4 insertions(+), 4 deletions(-) diff --git a/libavfilter

[FFmpeg-devel] [PATCH 3/6] sipr16kdata.h: add forgotten const.

2014-08-30 Thread Reimar Döffinger
Signed-off-by: Reimar Döffinger reimar.doeffin...@gmx.de --- libavcodec/sipr16kdata.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavcodec/sipr16kdata.h b/libavcodec/sipr16kdata.h index 96bf0e9..16a653d 100644 --- a/libavcodec/sipr16kdata.h +++ b/libavcodec/sipr16kdata.h

[FFmpeg-devel] [PATCH 1/6] fft: add ff_ prefix to some global arrays.

2014-08-30 Thread Reimar Döffinger
Signed-off-by: Reimar Döffinger reimar.doeffin...@gmx.de --- libavcodec/fft_init_table.c | 4 ++-- libavcodec/fft_table.h | 4 ++-- libavcodec/fft_template.c | 12 ++-- libavcodec/mips/fft_mips.c | 8 4 files changed, 14 insertions(+), 14 deletions(-) diff --git

[FFmpeg-devel] [PATCH] aacsbr: support hardcoding tables.

2014-08-30 Thread Reimar Döffinger
For sbr_qmf_window_us there is even a question if it maybe should be fully hardcoded all the time. Since half of it is coded, it ends up in .data and not .bss. Signed-off-by: Reimar Döffinger reimar.doeffin...@gmx.de --- libavcodec/Makefile | 4 +- libavcodec/aacsbr.c | 10

Re: [FFmpeg-devel] [PATCH 4/6] lavf: add const/static const to pix_fmts arrays.

2014-08-30 Thread Reimar Döffinger
On Sat, Aug 30, 2014 at 08:07:29AM -0700, Timothy Gu wrote: On Aug 30, 2014 7:44 AM, Reimar Döffinger reimar.doeffin...@gmx.de wrote: It's lavfi, not lavf. Fixed locally. ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org

[FFmpeg-devel] [PATCH] WMA: add const to avoid warnings with hardcoded tables.

2014-08-30 Thread Reimar Döffinger
Signed-off-by: Reimar Döffinger reimar.doeffin...@gmx.de --- libavcodec/wma.h | 2 +- libavcodec/wmaprodec.c | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/libavcodec/wma.h b/libavcodec/wma.h index c4056ec..01244a0 100644 --- a/libavcodec/wma.h +++ b/libavcodec

[FFmpeg-devel] [PATCH] Add av_cold to table generation functions.

2014-08-30 Thread Reimar Döffinger
Signed-off-by: Reimar Döffinger reimar.doeffin...@gmx.de --- libavcodec/aac_tablegen.h | 2 +- libavcodec/aacps_tablegen.h| 4 ++-- libavcodec/aacsbr_tablegen.h | 2 +- libavcodec/cbrt_tablegen.h | 3 ++- libavcodec/dv_tablegen.h | 3 ++- libavcodec

Re: [FFmpeg-devel] [PATCH 5/6] xv.c: Add missing const to lookup table.

2014-08-30 Thread Reimar Döffinger
On Sat, Aug 30, 2014 at 05:55:39PM +0200, Paul B Mahol wrote: On 8/30/14, Reimar Doeffinger reimar.doeffin...@gmx.de wrote: Signed-off-by: Reimar Doeffinger reimar.doeffin...@gmx.de --- libavdevice/xv.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) lgtm Thanks, pushed.

Re: [FFmpeg-devel] [PATCH] cabac: initialize all of ff_h264_cabac_tables programmatically.

2014-08-30 Thread Reimar Döffinger
On 30.08.2014, at 19:46, Reimar Döffinger reimar.doeffin...@gmx.de wrote: On 30.08.2014, at 19:01, wm4 nfx...@googlemail.com wrote: but still I wonder why you'd optimize for binary size, in exchange for higher RAM usage. What is your motivation for doing this? The only higher RAM usage

Re: [FFmpeg-devel] [PATCH] lavu/hash.c: Add missing static const.

2014-08-30 Thread Reimar Döffinger
On Sat, Aug 30, 2014 at 12:58:35PM -0700, Timothy Gu wrote: On Aug 30, 2014 7:37 AM, Reimar Döffinger reimar.doeffin...@gmx.de wrote: But mostly I care about having it in .rodata, everything else I'm willing to adapt to what others prefer. What are the gains for using .rodata instead

Re: [FFmpeg-devel] [PATCH 2/2] Add missing const all over the place.

2014-08-29 Thread Reimar Döffinger
On Thu, Aug 28, 2014 at 05:20:44PM -0700, Timothy Gu wrote: On Aug 28, 2014 3:46 PM, Reimar Döffinger reimar.doeffin...@gmx.de wrote: There is a risk that one in the code that is not always compiled might break things. What do you mean by 'one in the code'? The intended grouping

[FFmpeg-devel] [PATCH 1/3] fft: add missing const.

2014-08-29 Thread Reimar Döffinger
This table was the largest object in FFmpeg's .data, and really should be in .rodata. Signed-off-by: Reimar Döffinger reimar.doeffin...@gmx.de --- libavcodec/fft_init_table.c | 2 +- libavcodec/fft_table.h | 2 +- libavcodec/fft_template.c | 2 +- 3 files changed, 3 insertions(+), 3

[FFmpeg-devel] [PATCH 3/3] fft_template: Move variables to where they are used.

2014-08-29 Thread Reimar Döffinger
Signed-off-by: Reimar Döffinger reimar.doeffin...@gmx.de --- libavcodec/fft_template.c | 11 --- 1 file changed, 4 insertions(+), 7 deletions(-) diff --git a/libavcodec/fft_template.c b/libavcodec/fft_template.c index 3abf948..23ea453 100644 --- a/libavcodec/fft_template.c +++ b

[FFmpeg-devel] [PATCH] lavu/hash.c: Add missing static const.

2014-08-29 Thread Reimar Döffinger
Signed-off-by: Reimar Döffinger reimar.doeffin...@gmx.de --- libavutil/hash.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavutil/hash.c b/libavutil/hash.c index 773f29e..979fdd9 100644 --- a/libavutil/hash.c +++ b/libavutil/hash.c @@ -63,7 +63,7 @@ typedef struct

Re: [FFmpeg-devel] [PATCH] Fix MSVC warnings about possible value truncation.

2014-08-29 Thread Reimar Döffinger
On 30.08.2014, at 00:44, Peter Kasting pkast...@google.com wrote: Hi FFMPEG devs, please forgive any errors here as I'm normally a Chromium developer and this is my first submission to FFMPEG. The attached patch fixes instances of MSVC warning C4244 about possible value truncation (e.g. when

[FFmpeg-devel] [PATCH 2/2] Add missing const all over the place.

2014-08-28 Thread Reimar Döffinger
There is a risk that one in the code that is not always compiled might break things. Signed-off-by: Reimar Döffinger reimar.doeffin...@gmx.de --- ffserver.c | 2 +- libavcodec/aaccoder.c | 2 +- libavcodec/aic.c| 2 +- libavcodec/atrac3plus.c

[FFmpeg-devel] [PATCH 1/2] patcheck: check for pointer arrays that are not const.

2014-08-28 Thread Reimar Döffinger
Signed-off-by: Reimar Döffinger reimar.doeffin...@gmx.de --- tools/patcheck | 1 + 1 file changed, 1 insertion(+) diff --git a/tools/patcheck b/tools/patcheck index 3342c6a..cbdbf8d 100755 --- a/tools/patcheck +++ b/tools/patcheck @@ -42,6 +42,7 @@ hiegrep2(){ cat $TMP } +hiegrep 'static

Re: [FFmpeg-devel] [PATCH]Fix pnm encoding with bpc set

2014-08-27 Thread Reimar Döffinger
On 27.08.2014, at 16:41, Carl Eugen Hoyos ceho...@ag.or.at wrote: Reimar Döffinger Reimar.Doeffinger at gmx.de writes: Currently no relevant codecs use 12 bits, which is the reason why 9 and 10 bits exist as separate formats while 12 bits does not. Do you believe that x264 code would

Re: [FFmpeg-devel] [PATCH]Fix pnm encoding with bpc set

2014-08-26 Thread Reimar Döffinger
On 25.08.2014, at 19:33, Christophe Gisquet christophe.gisq...@gmail.com wrote: Hi, 2014-08-25 6:41 GMT+02:00 Reimar Döffinger reimar.doeffin...@gmx.de: The colorspace is supposed to be authoritative. If it says 16 bit, then showing it as 16 bit must work properly. The only intention

Re: [FFmpeg-devel] [PATCH]Fix pnm encoding with bpc set

2014-08-24 Thread Reimar Döffinger
On 24.08.2014, at 14:02, Christophe Gisquet christophe.gisq...@gmail.com wrote: Hi, I think a first point must be cleared, seeing your reaction to my pnmdec comment. Here' are the opinions: - Mine: bits_per_raw_sample should indicate the dynamics of the signal when it is different from the

Re: [FFmpeg-devel] [PATCH 3/4] dict.c: Free non-strduped av_dict_set arguments on error.

2014-08-23 Thread Reimar Döffinger
On Fri, Aug 22, 2014 at 07:47:09AM +0200, Reimar Döffinger wrote: On 22.08.2014, at 07:36, Reimar Döffinger reimar.doeffin...@gmx.de wrote: On 22.08.2014, at 04:06, Michael Niedermayer michae...@gmx.at wrote: On Sat, Aug 16, 2014 at 02:43:46PM +0200, Reimar Döffinger wrote: On Wed, Aug 13

Re: [FFmpeg-devel] [PATCH] Adds decode support for formats other than 420

2014-08-22 Thread Reimar Döffinger
On 22.08.2014, at 22:31, Deb Mukherjee debar...@google.com wrote: +// returns 0 on success, 1 on unsupported Please choose one of the standard ways, either 1 for success and 0 failure, or negative failure, 0 or positive success. This variant, at least in the context of FFmpeg, is just

Re: [FFmpeg-devel] [PATCH] x86/hevc_res_add: refactor ff_hevc_transform_add{16, 32}_8

2014-08-21 Thread Reimar Döffinger
On 21.08.2014, at 22:40, Kieran Kunhya kier...@obe.tv wrote: It does that, but on older SSE2 cpus with not-so-good OOO execution grouping instructions like this might help reduce dependencies a bit. Are any older SSE2 CPUs actually capable of decoding reasonable HEVC? Of course they are. Not

Re: [FFmpeg-devel] [PATCH 3/4] dict.c: Free non-strduped av_dict_set arguments on error.

2014-08-21 Thread Reimar Döffinger
On 22.08.2014, at 04:06, Michael Niedermayer michae...@gmx.at wrote: On Sat, Aug 16, 2014 at 02:43:46PM +0200, Reimar Döffinger wrote: On Wed, Aug 13, 2014 at 01:57:56PM +0200, Michael Niedermayer wrote: On Mon, Aug 11, 2014 at 09:17:18PM +0200, Reimar Döffinger wrote: Unfortunately

Re: [FFmpeg-devel] Invitation to VDD and registration

2014-08-17 Thread Reimar Döffinger
On Sat, Aug 16, 2014 at 05:13:53PM +0100, Kieran Kunhya wrote: And do not forget the language barrier: when writing a mail, there is as much time as necessary to find words. IRL, the people struggling to find their words are at a clear disadvantage. We can rotate between different

Re: [FFmpeg-devel] Invitation to VDD and registration

2014-08-16 Thread Reimar Döffinger
On 16.08.2014, at 03:48, Jean-Baptiste Kempf j...@videolan.org wrote: On 16 Aug, Michael Niedermayer wrote : I had not intended to come to VDD and reading this https://lists.debian.org/debian-devel/2014/08/msg00478.html I definitively will not come to VDD, as it would just be wasted time,

Re: [FFmpeg-devel] [PATCH 3/4] dict.c: Free non-strduped av_dict_set arguments on error.

2014-08-16 Thread Reimar Döffinger
On Mon, Aug 11, 2014 at 10:11:59PM +0200, wm4 wrote: On Mon, 11 Aug 2014 21:17:18 +0200 Reimar Döffinger reimar.doeffin...@gmx.de wrote: Unfortunately this was not explicitly documented and thus might be very risky. But basically all uses I saw in FFmpeg had a memleak in these cases

Re: [FFmpeg-devel] [PATCH 3/4] dpx: abort if encrypted

2014-08-13 Thread Reimar Döffinger
On 13.08.2014, at 13:48, Paul B Mahol one...@gmail.com wrote: On 8/13/14, Christophe Gisquet christophe.gisq...@gmail.com wrote: --- libavcodec/dpx.c | 9 + 1 file changed, 9 insertions(+) diff --git a/libavcodec/dpx.c b/libavcodec/dpx.c index 8cd7d73..2ad7527 100644 ---

Re: [FFmpeg-devel] Invitation to VDD and registration

2014-08-13 Thread Reimar Döffinger
On 13.08.2014, at 18:42, Stefano Sabatini stefa...@gmail.com wrote: On date Sunday 2014-07-20 18:16:52 +0200, Jean-Baptiste Kempf encoded: My dear friends of the FFmpeg community, I'd like to invite you to the VideoLAN Dev Days 2014, the 3rd week-end of September, in Dublin, Ireland. Google

Re: [FFmpeg-devel] [PATCH] vp9: ignore reference segmentation map if error_resilience flag is set.

2014-08-13 Thread Reimar Döffinger
On 13.08.2014, at 12:48, Ronald S. Bultje rsbul...@gmail.com wrote: Might it be useful to add some of those special samples to fate? Probably. The first 10 frames of the sample in this ticket would show this already, is anyone good with webm file cutting/remuxing? If not, I can try to

Re: [FFmpeg-devel] [PATCH 3/4] dpx: abort if encrypted

2014-08-13 Thread Reimar Döffinger
On Wed, Aug 13, 2014 at 06:51:00PM +0200, Christophe Gisquet wrote: Hi, 2014-08-13 18:46 GMT+02:00 Reimar Döffinger reimar.doeffin...@gmx.de: More specifically: how certain is it this value is always correct? Failing to play an unencrypted file just because of a wrong flag (or even

Re: [FFmpeg-devel] [RFC][PATCH] Allow include files to be installed into subdirectory

2014-08-13 Thread Reimar Döffinger
On 12.08.2014, at 02:21, Ivan Kalvachev ikalvac...@gmail.com wrote: It would be decided by the gcc -I inclusion option. It modifies the search paths for header files, so that it checks these paths before the system/default ones (When using `#include libavcodec/avcodec.h `) Libav headers are

Re: [FFmpeg-devel] [PATCH] Add missing initialization for AVProbeData.

2014-08-11 Thread Reimar Döffinger
On Mon, Aug 11, 2014 at 06:09:54PM +, Carl Eugen Hoyos wrote: Reimar Döffinger Reimar.Doeffinger at gmx.de writes: This has become necessary since the new mime field was added. The patch is definitely ok, sorry for missing this when I fixed one occurrence. I'm glad you fixed

[FFmpeg-devel] [PATCH 1/4] dict.c: Add av_dict_set_int helper function.

2014-08-11 Thread Reimar Döffinger
This allows getting rid of the many, slightly differing, implementations of basically the same thing. Signed-off-by: Reimar Döffinger reimar.doeffin...@gmx.de --- doc/APIchanges | 3 +++ libavutil/dict.c| 8 libavutil/dict.h| 8 libavutil/version.h | 2 +- 4 files

[FFmpeg-devel] [PATCH 4/4] dict.c: empty dictionaries should be a NULL pointer.

2014-08-11 Thread Reimar Döffinger
Ensure this is even the case if they are empty because we failed adding the first entry. Signed-off-by: Reimar Döffinger reimar.doeffin...@gmx.de --- libavutil/dict.c | 4 1 file changed, 4 insertions(+) diff --git a/libavutil/dict.c b/libavutil/dict.c index f23b768..bdb5690 100644

Re: [FFmpeg-devel] [PATCH 02/14] libavcodec: Implementation of AAC_fixed_decoder (LC-module) [2/5]

2014-08-07 Thread Reimar Döffinger
On Thu, Aug 07, 2014 at 09:51:36AM +, Nedeljko Babic wrote: +Q30(0.95), Q30(0.9922480620), Q30(0.9846153846), Q30(0.9770992366), I'm a bit unsure btw. if this makes more sense than coding the converted numbers. It feels like it combines the disadvantages, since it neither

Re: [FFmpeg-devel] [RFC] Implementation of closed caption support

2014-08-04 Thread Reimar Döffinger
On Mon, Aug 04, 2014 at 08:04:39PM +0100, Kieran Kunhya wrote: And as far as I can tell if you want to remux but with separate subtitle stream that would even mean that you have to re-encode the video for no good reason. You can just swap out the caption data. It's guaranteed to be CBR

Re: [FFmpeg-devel] [RFC] Implementation of closed caption support

2014-08-04 Thread Reimar Döffinger
On Mon, Aug 04, 2014 at 09:35:02PM +0200, Gisle Sælensminde wrote: Bitstream filter: Pro: - Modular, the CC code can be kept separate. - Less complex code Cons: Need for features that I can't see is present in the bitstream filters: - As far as I can see -no support for timestamps

Re: [FFmpeg-devel] [RFC] Implementation of closed caption support

2014-08-04 Thread Reimar Döffinger
On Mon, Aug 04, 2014 at 10:16:25PM +0200, Gisle Sælensminde wrote: Den 04. aug. 2014 21:58, skrev Reimar Döffinger: *scratches head* I wonder now if you misunderstood or if you discarded the variant I pointed out due to effort/complexity? Or because I don't know all the parts of the ffmpeg

Re: [FFmpeg-devel] [PATCH 02/14] libavcodec: Implementation of AAC_fixed_decoder (LC-module) [2/5]

2014-08-01 Thread Reimar Döffinger
On Fri, Aug 01, 2014 at 03:53:08PM +0200, Nedeljko Babic wrote: +#if !defined(_AAC_FLOAT_EMU_) +#define _AAC_FLOAT_EMU_ That is not out usual style 1) We use #ifndef 2) Identifiers starting with _ + upper case letter are reserved by POSIX and never should be used 3) The naming convention is

Re: [FFmpeg-devel] [PATCH 06/14] libavcodec: Implementation of AAC_fixed_decoder (SBR-module) [1/4]

2014-08-01 Thread Reimar Döffinger
On Fri, Aug 01, 2014 at 03:53:12PM +0200, Nedeljko Babic wrote: From: Djordje Pesut djordje.pe...@imgtec.com Move the existing code to a new template file. If code was only moved (I have not checked), I don't think adding your copyright is appropriate.

[FFmpeg-devel] [PATCH 1/4] dict.c: minor simplification.

2014-07-30 Thread Reimar Döffinger
Signed-off-by: Reimar Döffinger reimar.doeffin...@gmx.de --- libavutil/dict.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/libavutil/dict.c b/libavutil/dict.c index 358958c..aea8910 100644 --- a/libavutil/dict.c +++ b/libavutil/dict.c @@ -90,10 +90,9 @@ int av_dict_set

[FFmpeg-devel] [PATCH 2/4] dict.c: Add av_dict_set_int helper function.

2014-07-30 Thread Reimar Döffinger
This allows getting rid of the many, slightly differing, implementations of basically the same thing. Signed-off-by: Reimar Döffinger reimar.doeffin...@gmx.de --- doc/APIchanges | 3 +++ ffmpeg_opt.c | 12 +++- ffplay.c | 2

Re: [FFmpeg-devel] [PATCH 1/3] dict.c: Free non-strduped av_dict_set arguments on error.

2014-07-30 Thread Reimar Döffinger
On Tue, Jul 29, 2014 at 10:13:39PM +0200, Michael Niedermayer wrote: On Tue, Jul 29, 2014 at 09:26:48PM +0200, Reimar Döffinger wrote: Unfortunately this was not explicitly documented and thus might be very risky. But basically all uses I saw in FFmpeg had a memleak in these cases

Re: [FFmpeg-devel] [PATCH 2/4] dict.c: Add av_dict_set_int helper function.

2014-07-30 Thread Reimar Döffinger
On Wed, Jul 30, 2014 at 08:38:06PM +0200, Reimar Döffinger wrote: This allows getting rid of the many, slightly differing, implementations of basically the same thing. This one really can need a few extra eyes. It's likely I missed a few places, and there's a risk I messed up one or the other

[FFmpeg-devel] [PATCH] mxfdec: add missing const to array declaration.

2014-07-29 Thread Reimar Döffinger
Signed-off-by: Reimar Döffinger reimar.doeffin...@gmx.de --- libavformat/mxfdec.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavformat/mxfdec.c b/libavformat/mxfdec.c index 4d2a506..03f3df7 100644 --- a/libavformat/mxfdec.c +++ b/libavformat/mxfdec.c @@ -992,7 +992,7

[FFmpeg-devel] [PATCH] movdec: remove nonsensical snprintf.

2014-07-29 Thread Reimar Döffinger
Signed-off-by: Reimar Döffinger reimar.doeffin...@gmx.de --- libavformat/mov.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/libavformat/mov.c b/libavformat/mov.c index 6a9af69..7b1dbb2 100644 --- a/libavformat/mov.c +++ b/libavformat/mov.c @@ -119,15 +119,13 @@ static

[FFmpeg-devel] [PATCH 1/3] dict.c: Free non-strduped av_dict_set arguments on error.

2014-07-29 Thread Reimar Döffinger
Unfortunately this was not explicitly documented and thus might be very risky. But basically all uses I saw in FFmpeg had a memleak in these cases. Signed-off-by: Reimar Döffinger reimar.doeffin...@gmx.de --- libavutil/dict.c | 9 +++-- libavutil/dict.h | 2 ++ 2 files changed, 9 insertions

Re: [FFmpeg-devel] [PATCH] avcodec/mjpegenc_common: always store JFIF, idependent of the aspect ratio

2014-07-19 Thread Reimar Döffinger
On 16.07.2014, at 17:46, Andrey Utkin andrey.krieger.ut...@gmail.com wrote: 2014-07-15 21:39 GMT+03:00 Andrey Utkin andrey.krieger.ut...@gmail.com: 2014-07-15 19:16 GMT+03:00 Nicolas George geo...@nsup.org: Le septidi 27 messidor, an CCXXII, Andrey Utkin a écrit : Thanks, with this change

Re: [FFmpeg-devel] [PATCH] avcodec/mjpegenc_common: always store JFIF, idependent of the aspect ratio

2014-07-16 Thread Reimar Döffinger
On 15.07.2014, at 16:31, Michael Niedermayer michae...@gmx.at wrote: Found-by: kriegero1 Signed-off-by: Michael Niedermayer michae...@gmx.at Nit: iNdependent in commit message. +/* JFIF header */ +put_marker(p, APP0); +put_bits(p, 16, 16); +avpriv_put_string(p, JFIF, 1);

Re: [FFmpeg-devel] [PATCH] avcodec/mjpegenc_common: always store JFIF, idependent of the aspect ratio

2014-07-16 Thread Reimar Döffinger
On 15.07.2014, at 18:14, Andrey Utkin andrey.krieger.ut...@gmail.com wrote: Thanks, with this change streaming HTTP MJPEG stream into browsers work (with inserting boundaries, which is easy for scripting). oh, and please add an explanation like this (assuming this is the reason for it) to the

Re: [FFmpeg-devel] [PATCH] kCVPixelFormatType_OneComponent8 only exists from 10.8 onward

2014-07-14 Thread Reimar Döffinger
On 14.07.2014, at 04:55, Hanspeter Niederstrasser niederstras...@gmail.com wrote: The AVFoundation indev uses kCVPixelFormatType_OneComponent8, but that only exists on 10.8 and up. This puts it behind a #if. It's not ideal. Maybe not worth the effort, but it would be better if a version

<    2   3   4   5   6   7