Re: [FFmpeg-devel] [PATCH] avformat/ivfenc: Change the length fields to 32 bits

2019-10-07 Thread Vittorio Giovara
this seems good to me, unless objections i'll merge it in 24h On Mon, Oct 7, 2019 at 11:10 AM Raphaël Zumer wrote: > Just sending a reminder for my set of patches (the set of v2 patches up > in the thread and this one). Are there any further comments? > > Thanks > Raphaël Zumer > > On Wed,

Re: [FFmpeg-devel] [REQUEST] ffmpeg-security subscription

2019-08-15 Thread Vittorio Giovara
On Wed, Aug 14, 2019 at 10:11 PM Reimar Döffinger wrote: > On 14.08.2019, at 11:45, Paul B Mahol wrote: > > I strongly disagree with you. Why some people have subscription to > security > > mailing list and I'm not allowed also? > > Long version, explaining to the best of my knowledge and

Re: [FFmpeg-devel] [PATCH 6/8] avcodec/decode: Do not overwrite AVFrame.pkt_pos if its already set

2019-08-12 Thread Vittorio Giovara
On Mon, Aug 12, 2019 at 9:19 PM Michael Niedermayer wrote: > Signed-off-by: Michael Niedermayer > --- > libavcodec/decode.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/libavcodec/decode.c b/libavcodec/decode.c > index 6c31166ec2..09a509d659 100644 > ---

Re: [FFmpeg-devel] [PATCH] mov: Support fake moov boxes disguised as hoov

2019-08-12 Thread Vittorio Giovara
On Thu, Aug 8, 2019 at 10:28 PM Vittorio Giovara wrote: > Some broken apps generate files that have a fake box named 'hoov' > instead of a proper 'moov' one. This is speculation but it seems like > this box contains data to be modified later (eg as file grows in size, > data get

Re: [FFmpeg-devel] [PATCH 1/3] avutil/pixfmt: Add EBU Tech. 3213-E AVColorPrimaries value

2019-08-09 Thread Vittorio Giovara
On Fri, Aug 9, 2019 at 3:29 AM wrote: > From: Raphaël Zumer > > This is an alias for JEDEC P22. > > The name associated with the value is also changed > from "jedec-p22" to "ebu3213" to match ITU-T H.273. > > Signed-off-by: Raphaël Zumer > --- > doc/APIchanges | 3 +++ >

[FFmpeg-devel] [PATCH] mov: Support fake moov boxes disguised as hoov

2019-08-08 Thread Vittorio Giovara
Some broken apps generate files that have a fake box named 'hoov' instead of a proper 'moov' one. This is speculation but it seems like this box contains data to be modified later (eg as file grows in size, data gets re-written) and its name is supposed to be changed to 'moov' once it can be used

Re: [FFmpeg-devel] [PATCH] lavc/videotoolboxenc: add hdr10, linear, hlg color transfer function for videotoolboxenc

2019-07-17 Thread Vittorio Giovara
On Tue, Jul 16, 2019 at 10:29 PM Limin Wang wrote: > On Tue, Jul 16, 2019 at 09:36:32PM -0400, Rick Kern wrote: > > Testing for the new transfer functions when compiling for OSX 10.12 > reports > > the color settings as "yuv420p(tv, bt2020nc/bt2020/reserved)" in ffprobe. > > Is "reserved" (0)

Re: [FFmpeg-devel] [PATCH] libavfilter/vf_colorspace.c: fix demarcation point of gamma linearize function

2019-07-03 Thread Vittorio Giovara
On Wed, Jul 3, 2019 at 12:51 AM vincenluo(罗永林) wrote: > ___ > ffmpeg-devel mailing list > ffmpeg-devel@ffmpeg.org > https://ffmpeg.org/mailman/listinfo/ffmpeg-devel > Great find, your patch is absolutely correct. Pushing soon, thank you. -- Vittorio

Re: [FFmpeg-devel] [PATCH 1/3] avcodec/cfhd: remove unused function

2019-06-27 Thread Vittorio Giovara
On Thu, Jun 27, 2019 at 9:44 AM Nicolas George wrote: > Kieran Kunhya (12019-06-27): > > I'm happy to do it now that I am aware of the issue. I will do it when I > am > > at home in a few days. > > Thanks. I am sure Steven will not mind waiting a few days. > > > This absolutism is absurd. > > Do

Re: [FFmpeg-devel] [PATCH v2] avcodec/h264_sei: Add acces to truncated SEI data

2019-06-09 Thread Vittorio Giovara
On Sat, Jun 8, 2019 at 9:28 AM Antonin Gouzer wrote: > --- > Some codecs editors had miss interpreted the H264 standart and > have coded a wrong size in the SEI data. > size = SEI size + 1. > The SEI data is detected as "truncated" > Ex: >

Re: [FFmpeg-devel] [PATCH v3] avcodec: Add librav1e encoder

2019-05-29 Thread Vittorio Giovara
On Wed, May 29, 2019 at 2:28 PM Derek Buitenhuis wrote: > Uses the crav1e C bindings for rav1e. > --- a/doc/encoders.texi > +++ b/doc/encoders.texi > @@ -1378,6 +1378,35 @@ makes it possible to store non-rgb pix_fmts. > > @end table > > +@section librav1e > + > +rav1e AV1 encoder wrapper. > + >

Re: [FFmpeg-devel] Export display matrix mirroring info as part of the rotate API

2019-05-16 Thread Vittorio Giovara
On Thu, May 16, 2019 at 9:32 PM Jun Li wrote: > On Thu, May 16, 2019 at 4:34 PM Ted Meyer < > tmathmeyer-at-google@ffmpeg.org> wrote: > > > Right now ffmpeg doesn't export a mirroring status when checking the > > display matrix for rotation. > > Here is an example video:

Re: [FFmpeg-devel] [PATCH] avfilter/vf_tonemap: add slice threading

2019-04-30 Thread Vittorio Giovara
On Tue, Apr 30, 2019 at 6:07 AM Paul B Mahol wrote: > Signed-off-by: Paul B Mahol > --- > libavfilter/vf_tonemap.c | 39 ++- > 1 file changed, 34 insertions(+), 5 deletions(-) > > diff --git a/libavfilter/vf_tonemap.c b/libavfilter/vf_tonemap.c > index

Re: [FFmpeg-devel] [PATCH v3] avcodec: add AV_CODEC_FLAG_DROPCHANGED to flags

2019-04-17 Thread Vittorio Giovara
On Tue, Apr 16, 2019 at 3:42 AM Gyan wrote: > Patch revised as per > http://www.ffmpeg.org/pipermail/ffmpeg-devel/2019-April/242591.html > > Gyan > sorry if i'm late to the party but why are these new fields in avcodeccontext? they seem to be perfect candidates for side data, or am i missing

Re: [FFmpeg-devel] [PATCH] avutil/colorspace: add macros for RGB->YUV BT.709

2019-04-17 Thread Vittorio Giovara
On Wed, Apr 17, 2019 at 12:26 AM Gyan wrote: > > > On 13-04-2019 05:23 PM, Gyan wrote: > > Will be helpful for correct result in filters that paint like > > fillborders/drawbox or those using drawutils. > > Ping. > these seem to only work for 8 bit content, is that their only intended usecase?

Re: [FFmpeg-devel] [PATCH v10 1/2] lavc/svt_hevc: add libsvt hevc encoder wrapper

2019-03-29 Thread Vittorio Giovara
On Fri, Mar 29, 2019 at 5:28 AM Jing Sun wrote: > +static int config_enc_params(EB_H265_ENC_CONFIGURATION *param, > + AVCodecContext *avctx) > +{ > +SvtContext *svt_enc = avctx->priv_data; > +int ret; > + > +param->sourceWidth = avctx->width; > +

Re: [FFmpeg-devel] [PATCH v9 1/2] lavc/svt_hevc: add libsvt hevc encoder wrapper

2019-03-27 Thread Vittorio Giovara
On Tue, Mar 26, 2019 at 10:47 PM Jing Sun wrote: > Signed-off-by: Zhengxu Huang > Signed-off-by: Hassene Tmar > Signed-off-by: Jun Zhao > Signed-off-by: Jing Sun > --- > configure| 4 + > libavcodec/Makefile | 1 + > libavcodec/allcodecs.c | 1 + >

Re: [FFmpeg-devel] [PATCH v7 1/2] lavc/svt_hevc: add libsvt hevc encoder wrapper.

2019-03-19 Thread Vittorio Giovara
On Tue, Mar 19, 2019 at 2:17 AM Sun, Jing A wrote: > -Original Message- > From: ffmpeg-devel [mailto:ffmpeg-devel-boun...@ffmpeg.org] On Behalf Of > Jing SUN > Sent: Monday, March 11, 2019 6:38 PM > To: ffmpeg-devel@ffmpeg.org > Cc: Sun, Jing A ; Huang, Zhengxu < >

Re: [FFmpeg-devel] [PATCH v7 1/2] lavc/svt_hevc: add libsvt hevc encoder wrapper.

2019-03-13 Thread Vittorio Giovara
On Wed, Mar 13, 2019 at 8:29 PM Sun, Jing A wrote: > > > > On Tue, Mar 12, 2019 at 11:40 PM Sun, Jing A > wrote: > > Hi Giovara, > > > > SVT HEVC has the interface to enable/disable sending a vui structure in > the HEVC bitstream, but supports no interface for setting the color > properties

Re: [FFmpeg-devel] [PATCH v7 1/2] lavc/svt_hevc: add libsvt hevc encoder wrapper.

2019-03-13 Thread Vittorio Giovara
On Tue, Mar 12, 2019 at 11:40 PM Sun, Jing A wrote: > Hi Giovara, > > > > SVT HEVC has the interface to enable/disable sending a vui structure in > the HEVC bitstream, but supports no interface for setting the color > properties before encoding yet. I will be opening an issue in SVT HEVC >

Re: [FFmpeg-devel] [PATCH v7 1/2] lavc/svt_hevc: add libsvt hevc encoder wrapper.

2019-03-11 Thread Vittorio Giovara
On Mon, Mar 11, 2019 at 12:50 AM Sun, Jing A wrote: > I just searched my inbox again but failed to find that email of question > you mentioned. > Yeah I often see my mail bounced with this message: Address not foundYour message wasn't delivered to *jun.z...@intel.com* because the address

Re: [FFmpeg-devel] [PATCH v7 1/2] lavc/svt_hevc: add libsvt hevc encoder wrapper.

2019-03-08 Thread Vittorio Giovara
On Fri, Mar 8, 2019 at 4:39 AM Jing SUN wrote: > From: Jing Sun > > base on patch by Huang, Zhengxu from https://github.com/intel/SVT-HEVC > > V4: - Fix the build error with new API in PR#52 > - Fix the encoding hang issue by API change in PR#52 > - Fix the last frame dropping issue >

Re: [FFmpeg-devel] [PATCH 2/2] avcodec/libdav1d: use a custom picture allocator

2019-03-05 Thread Vittorio Giovara
On Mon, Mar 4, 2019 at 4:08 PM James Almer wrote: > Replaces the libdav1d internal allocator. It uses an AVBufferPool to > reduce the > amount of allocated buffers. > About 5% speed up when decoding 720p or higher streams. > > Signed-off-by: James Almer > --- > get_buffer2() can't be used for

Re: [FFmpeg-devel] [PATCH 1/2] avcodec/libdav1d: route dav1d internal logs through av_log()

2019-03-05 Thread Vittorio Giovara
On Mon, Mar 4, 2019 at 4:08 PM James Almer wrote: > Bump the minimum required version to the first one with the logger API > callback. > > Signed-off-by: James Almer > --- > configure | 2 +- > libavcodec/libdav1d.c | 9 + > 2 files changed, 10 insertions(+), 1 deletion(-)

Re: [FFmpeg-devel] [PATCH v6 1/2] lavc/svt_hevc: add libsvt hevc encoder wrapper.

2019-03-05 Thread Vittorio Giovara
On Tue, Mar 5, 2019 at 1:45 AM Jing SUN wrote: > From: Jing Sun > > base on patch by Huang, Zhengxu from https://github.com/intel/SVT-HEVC > > V4: - Fix the build error with new API in PR#52 > - Fix the encoding hang issue by API change in PR#52 > - Fix the last frame dropping issue >

[FFmpeg-devel] [PATCH] libdav1d: Add support for reading hdr10 metadata

2019-03-05 Thread Vittorio Giovara
--- configure | 2 +- libavcodec/libdav1d.c | 30 +- 2 files changed, 30 insertions(+), 2 deletions(-) diff --git a/configure b/configure index dcead3a300..a5cef4bc09 100755 --- a/configure +++ b/configure @@ -6142,7 +6142,7 @@ enabled libcelt

Re: [FFmpeg-devel] [PATCH] avformat/mov: fix start_time for streams with empty edits in the middle

2019-02-25 Thread Vittorio Giovara
On Sat, Feb 23, 2019 at 1:09 PM Vittorio Giovara wrote: > Empty edits can occur at any position within the edit list except for at > the end. Empty edits in the middle should not impact the reported stream > start_time or the video PTS adjustment, so only include empty edits at &g

[FFmpeg-devel] [PATCH] avformat/mov: fix start_time for streams with empty edits in the middle

2019-02-23 Thread Vittorio Giovara
Empty edits can occur at any position within the edit list except for at the end. Empty edits in the middle should not impact the reported stream start_time or the video PTS adjustment, so only include empty edits at the start of the list in empty_edits_sum_duration. Please see attachment. --

Re: [FFmpeg-devel] [PATCH] http: Do not try to make a new request when seeking past the end of the file

2019-02-22 Thread Vittorio Giovara
On Wed, Feb 20, 2019 at 9:54 AM Vittorio Giovara wrote: > From: Justin Ruggles > > This avoids making invalid HTTP Range requests for a byte range past the > known end of the file during a seek. Those requests generally return a HTTP > response of 416 Range Not Satisfiabl

[FFmpeg-devel] [PATCH] http: Do not try to make a new request when seeking past the end of the file

2019-02-20 Thread Vittorio Giovara
-off-by: Vittorio Giovara --- libavformat/http.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/libavformat/http.c b/libavformat/http.c index a0a0636cf2..1e40268599 100644 --- a/libavformat/http.c +++ b/libavformat/http.c @@ -1691,6 +1691,13 @@ static int64_t http_seek_internal

[FFmpeg-devel] [PATCH] avformat/http: Do not try to make a new request when seeking past the end of the file

2019-02-15 Thread Vittorio Giovara
-off-by: Vittorio Giovara --- libavformat/http.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/libavformat/http.c b/libavformat/http.c index a0a0636cf2..1e40268599 100644 --- a/libavformat/http.c +++ b/libavformat/http.c @@ -1691,6 +1691,13 @@ static int64_t http_seek_internal

Re: [FFmpeg-devel] [PATCH] avcodec/cbs_av1: change the assert in trailing_bits to accept zero bits when reading

2019-02-13 Thread Vittorio Giovara
On Sun, Feb 10, 2019 at 3:12 PM James Almer wrote: > If nb_bits is zero when reading an OBU, then it's not a bug in CBS but an > invalid bitstream, and we should abort gracefully instead. > > Signed-off-by: James Almer > --- > rav1e is currently encoding invalid Metadata OBUs without trailing

Re: [FFmpeg-devel] SDR->HDR tone mapping algorithm?

2019-02-08 Thread Vittorio Giovara
On Fri, Feb 8, 2019 at 3:22 AM Harish Krupo wrote: > Hello, > > We are in the process of implementing HDR rendering support in the > Weston display compositor [1] (HDR discussion here [2]). When HDR > and SDR surfaces like a video buffer and a subtitle buffer are presented > together, the

Re: [FFmpeg-devel] Rename RSHIFT macro to ROUNDED_RSHIFT

2019-01-22 Thread Vittorio Giovara
On Mon, Jan 21, 2019 at 2:15 PM FeRD wrote: > On Mon, Jan 21, 2019 at 1:55 PM Moritz Barsnick wrote: > > > On Mon, Jan 21, 2019 at 12:38:58 -0500, FeRD (Frank Dana) wrote: > > > > > After applying both patches, 'make fate' succeeds and ffmpeg is still > > > functional. > > > > You're not

Re: [FFmpeg-devel] [PATCH] avcodec/rscc: Avoid returning frames that have nearly no undamaged pixels in them

2019-01-18 Thread Vittorio Giovara
On Thu, Jan 17, 2019 at 6:34 PM Michael Niedermayer wrote: > On Wed, Jan 16, 2019 at 09:05:18PM -0500, Vittorio Giovara wrote: > > On Wed, Jan 16, 2019 at 7:44 PM Michael Niedermayer > > > wrote: > > > > > Fixes: Timeout > > > Fixes: &g

Re: [FFmpeg-devel] [PATCH] avcodec/proresdec2: only set avctx->color* when values are specified

2019-01-18 Thread Vittorio Giovara
On Fri, Jan 18, 2019 at 6:43 AM Carl Eugen Hoyos wrote: > 2019-01-18 4:48 GMT+01:00, Neil Birkbeck : > > On Thu, Jan 17, 2019 at 7:43 PM Neil Birkbeck > > wrote: > > > >> This allows preservation of color values set from the container, > >> while still letting the bitstream take precedent when

Re: [FFmpeg-devel] [PATCH] avcodec/proresdec2: only set avctx->color* when values are specified

2019-01-18 Thread Vittorio Giovara
On Thu, Jan 17, 2019 at 10:57 PM Neil Birkbeck wrote: > On Thu, Jan 17, 2019 at 7:43 PM Neil Birkbeck > wrote: > > > This allows preservation of color values set from the container, > > while still letting the bitstream take precedent when its values > > are specified to some actual value

Re: [FFmpeg-devel] [PATCH] avcodec/rscc: Avoid returning frames that have nearly no undamaged pixels in them

2019-01-16 Thread Vittorio Giovara
On Wed, Jan 16, 2019 at 7:44 PM Michael Niedermayer wrote: > Fixes: Timeout > Fixes: > 12192/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_RSCC_fuzzer-6279038004363264 > > Before: > clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_RSCC_fuzzer-6279038004363264 > in 15423 ms > After: >

[FFmpeg-devel] [PATCH] matroskadec: Adjust content light side data check

2019-01-13 Thread Vittorio Giovara
While in practice both fields are always initialized, this mimics what other tools like ffms2, and x265 do more closely. This work has been sponsored by Tyrell Corporation, for a compensation of dozen of cents of US dollars. --- libavformat/matroskadec.c | 7 ++- 1 file changed, 6

Re: [FFmpeg-devel] [PATCH V5 1/2] avutil: add ROI (Region Of Interest) data struct and bump version

2019-01-07 Thread Vittorio Giovara
On Sat, Jan 5, 2019 at 2:15 AM James Almer wrote: > On 1/4/2019 10:08 AM, Vittorio Giovara wrote: > > On Fri, Jan 4, 2019 at 12:22 PM Nicolas George wrote: > > > >> Rostislav Pehlivanov (12019-01-04): > >>>> +typedef struct AVRegionOfInterest { > >

Re: [FFmpeg-devel] [PATCH V5 1/2] avutil: add ROI (Region Of Interest) data struct and bump version

2019-01-04 Thread Vittorio Giovara
On Fri, Jan 4, 2019 at 7:57 PM Rostislav Pehlivanov wrote: > On Fri, 4 Jan 2019 at 16:28, Vittorio Giovara > wrote: > > > On Fri, Jan 4, 2019 at 2:37 PM Nicolas George wrote: > > > > > Vittorio Giovara (12019-01-04): > > > > I personally disagr

Re: [FFmpeg-devel] [PATCH V5 1/2] avutil: add ROI (Region Of Interest) data struct and bump version

2019-01-04 Thread Vittorio Giovara
On Fri, Jan 4, 2019 at 2:37 PM Nicolas George wrote: > Vittorio Giovara (12019-01-04): > > I personally disagree, what are coordinates within an AVFrame if not the > > length/size of an object in memory? > > That would be an argument for making AVFrame.width and AV

Re: [FFmpeg-devel] [PATCH V5 1/2] avutil: add ROI (Region Of Interest) data struct and bump version

2019-01-04 Thread Vittorio Giovara
On Fri, Jan 4, 2019 at 12:22 PM Nicolas George wrote: > Rostislav Pehlivanov (12019-01-04): > > > +typedef struct AVRegionOfInterest { > > > +size_t self_size; > > > +size_t top; > > > +size_t bottom; > > > +size_t left; > > > +size_t right; > > I'd still much rather have

Re: [FFmpeg-devel] [PATCH V4 1/2] avutil: add ROI data struct and bump version

2019-01-02 Thread Vittorio Giovara
On Wed, Jan 2, 2019 at 6:48 PM James Almer wrote: > On 12/28/2018 7:09 AM, Guo, Yejun wrote: > > The encoders such as libx264 support different QPs offset for different > MBs, > > it makes possible for ROI-based encoding. It makes sense to add support > > within ffmpeg to generate/accept ROI

Re: [FFmpeg-devel] [PATCH V4 1/2] avutil: add ROI data struct and bump version

2019-01-02 Thread Vittorio Giovara
On Wed, Jan 2, 2019 at 6:45 PM James Almer wrote: > On 1/2/2019 2:18 PM, Vittorio Giovara wrote: > > On Wed, Jan 2, 2019 at 4:13 PM Vittorio Giovara < > vittorio.giov...@gmail.com> > > wrote: > > > >> > >> > >> On Fri, Dec 28, 2018 at 3

Re: [FFmpeg-devel] [PATCH V4 1/2] avutil: add ROI data struct and bump version

2019-01-02 Thread Vittorio Giovara
On Wed, Jan 2, 2019 at 4:13 PM Vittorio Giovara wrote: > > > On Fri, Dec 28, 2018 at 3:17 AM Guo, Yejun wrote: > >> The encoders such as libx264 support different QPs offset for different >> MBs, >> it makes possible for ROI-based encoding. It makes sense t

Re: [FFmpeg-devel] [PATCH V4 1/2] avutil: add ROI data struct and bump version

2019-01-02 Thread Vittorio Giovara
On Fri, Dec 28, 2018 at 3:17 AM Guo, Yejun wrote: > The encoders such as libx264 support different QPs offset for different > MBs, > it makes possible for ROI-based encoding. It makes sense to add support > within ffmpeg to generate/accept ROI infos and pass into encoders. > > Typical usage:

Re: [FFmpeg-devel] [PATCH] Add HDR dynamic metadata struct (for SMPTE 2094-40) to libavutil.

2018-12-21 Thread Vittorio Giovara
On Thu, Dec 20, 2018 at 8:14 PM Mohammad Izadi wrote: > From: Mohammad Izadi > > The dynamic metadata contains data for color volume transform - > application 4 of SMPTE 2094-40:2016 standard. The data comes from HEVC in > the SEI_TYPE_USER_DATA_REGISTERED_ITU_T_T35. > > pushed, thanks --

Re: [FFmpeg-devel] [PATCH] Add HDR dynamic metadata struct (for SMPTE 2094-40) to libavutil.

2018-12-20 Thread Vittorio Giovara
On Thu, Dec 20, 2018 at 7:18 PM Mohammad Izadi wrote: > Hi Vittorio, > > Thank you for your feedback ! Here is my answers to your questions: > > I thought we were going to rename the header as dynamic_hdr.h since it may > contain multiple variants of metadata. > Also I believe "metadata" in the

Re: [FFmpeg-devel] [PATCH] Add HDR dynamic metadata struct (for SMPTE 2094-40) to libavutil.

2018-12-19 Thread Vittorio Giovara
On Wed, Dec 19, 2018 at 7:08 PM Mohammad Izadi wrote: > From: Mohammad Izadi > > The dynamic metadata contains data for color volume transform - > application 4 of SMPTE 2094-40:2016 standard. The data comes from HEVC in > the SEI_TYPE_USER_DATA_REGISTERED_ITU_T_T35. > > I'll add support to

Re: [FFmpeg-devel] [PATCH] Add HDR dynamic metadata struct (for SPMTE 2094-40) to libavutil.

2018-12-17 Thread Vittorio Giovara
On Tue, Dec 18, 2018 at 12:04 AM Mohammad Izadi wrote: > As Jan mentioned, we need to specify the kind of the HDR metadata. Here are > some alternatives: > > AVDynamicHDRPlus > AVSMPTE2094App4 (Application 4 is HDR10+ while Dolby is application 1) > AVHDRPlusMetadata > > Which one do you

Re: [FFmpeg-devel] [PATCH] Add HDR dynamic metadata struct (for SPMTE 2094-40) to libavutil.

2018-12-17 Thread Vittorio Giovara
On Mon, Dec 17, 2018 at 5:53 PM Jan Ekström wrote: > On Tue, Dec 18, 2018 at 12:41 AM Vittorio Giovara > wrote: > > > > On Mon, Dec 10, 2018 at 2:50 PM Mohammad Izadi > wrote: > > > > > From: Mohammad Izadi > > > > > > The dyn

Re: [FFmpeg-devel] [PATCH] Add HDR dynamic metadata struct (for SPMTE 2094-40) to libavutil.

2018-12-17 Thread Vittorio Giovara
On Mon, Dec 10, 2018 at 2:50 PM Mohammad Izadi wrote: > From: Mohammad Izadi > > The dynamic metadata contains data for color volume transform - > application 4 of SPMTE 2094-40:2016 standard. The data comes from HEVC in > the SEI_TYPE_USER_DATA_REGISTERED_ITU_T_T35. > > I'll add support to

Re: [FFmpeg-devel] [PATCH 1/4] proresenc_nanatoliy: Rename a profile name with the correct one

2018-11-05 Thread Vittorio Giovara
On Sat, Nov 3, 2018 at 10:23 AM Paul B Mahol wrote: > On 11/2/18, Vittorio Giovara wrote: > > In all Apple documentation, this profile is called Prores . > > --- > > libavcodec/proresenc_anatoliy.c | 16 > > 1 file changed, 8

Re: [FFmpeg-devel] [PATCH 4/4] mjpeg: Use profile names in the encoder and decoder

2018-11-05 Thread Vittorio Giovara
On Fri, Nov 2, 2018 at 5:29 PM Carl Eugen Hoyos wrote: > 2018-11-02 20:35 GMT+01:00, Vittorio Giovara : > > --- > > libavcodec/codec_desc.c | 1 + > > libavcodec/mjpegdec.c | 2 ++ > > libavcodec/profiles.c | 9 + > > libavcodec/profiles.h | 1 +

[FFmpeg-devel] [PATCH 2/4] prores: Use profile names in the various encoders and decoders

2018-11-02 Thread Vittorio Giovara
Export FF_PROFILE_PRORES_* symbols to the public header. --- libavcodec/avcodec.h| 7 +++ libavcodec/codec_desc.c | 1 + libavcodec/profiles.c | 10 ++ libavcodec/profiles.h | 1 + libavcodec/proresdec2.c | 2 ++

[FFmpeg-devel] [PATCH 4/4] mjpeg: Use profile names in the encoder and decoder

2018-11-02 Thread Vittorio Giovara
--- libavcodec/codec_desc.c | 1 + libavcodec/mjpegdec.c | 2 ++ libavcodec/profiles.c | 9 + libavcodec/profiles.h | 1 + libavcodec/version.h| 2 +- 5 files changed, 14 insertions(+), 1 deletion(-) diff --git a/libavcodec/codec_desc.c b/libavcodec/codec_desc.c index

[FFmpeg-devel] [PATCH 3/4] proresdec2: Parse codec_tag and export profile information

2018-11-02 Thread Vittorio Giovara
--- libavcodec/proresdec2.c | 24 libavcodec/version.h| 2 +- 2 files changed, 25 insertions(+), 1 deletion(-) diff --git a/libavcodec/proresdec2.c b/libavcodec/proresdec2.c index 6b3021bdfa..130a4e3fe8 100644 --- a/libavcodec/proresdec2.c +++

[FFmpeg-devel] [PATCH 1/4] proresenc_nanatoliy: Rename a profile name with the correct one

2018-11-02 Thread Vittorio Giovara
In all Apple documentation, this profile is called Prores . --- libavcodec/proresenc_anatoliy.c | 16 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/libavcodec/proresenc_anatoliy.c b/libavcodec/proresenc_anatoliy.c index 6b9ce4a59a..dbbf13f4c0 100644 ---

Re: [FFmpeg-devel] [PATCH V3] Add a filter implementing HDR image reconstruction from a single exposure using deep CNNs

2018-10-21 Thread Vittorio Giovara
On Mon, Oct 22, 2018 at 4:19 AM Guo, Yejun wrote: > +.description = NULL_IF_CONFIG_SMALL("HDR image reconstruction from > a single exposure using deep CNNs."), > > > > > why "reconstruction"? there is nothing to construct back if the source > wasn't hdr to begin with > > > "tonemap" is

Re: [FFmpeg-devel] [PATCH V3] Add a filter implementing HDR image reconstruction from a single exposure using deep CNNs

2018-10-19 Thread Vittorio Giovara
On Fri, Oct 19, 2018 at 10:11 AM Guo, Yejun wrote: > see the algorithm's paper and code below. > > the filter's parameter looks like: > sdr2hdr=model_filename=/path_to_tensorflow_graph.pb:out_fmt=gbrp10le > can you add some usage documentation to doc/filters.texi? The input of the deep CNN

Re: [FFmpeg-devel] [PATCH] avformat: add H264 and HEVC support in IVF muxer

2018-10-15 Thread Vittorio Giovara
On Thu, Oct 11, 2018 at 5:28 PM Jan Ekström wrote: > On Thu, Oct 11, 2018 at 10:58 PM Alex Sukhanov > wrote: > > > > Hi Mark, > > > > at Google we have some old service which is still running and it works > only > > with the IVF container. It would be great if ffmpeg could generate such > >

Re: [FFmpeg-devel] [PATCH 2/2] decklink: Add support for output of Active Format Description (AFD)

2018-08-27 Thread Vittorio Giovara
On Wed, Aug 22, 2018 at 9:53 PM, Devin Heitmueller < dheitmuel...@ltnglobal.com> wrote: > Implement support for including AFD in decklink output. This > includes making sure the AFD data is preserved when going from > an AVFrame to a V210 packet (needed for 10-bit support). > > Updated to

Re: [FFmpeg-devel] [PATCH 1/4] vf_tonemap: Update the default peak values

2018-07-31 Thread Vittorio Giovara
On Wed, Jul 25, 2018 at 5:46 PM, Vittorio Giovara < vittorio.giov...@gmail.com> wrote: > When there is no metadata attached to a frame, take into account both > the PQ and HLG transfers, and change the HLG default value to 10: > the value of 12 is the maximum range in scene

Re: [FFmpeg-devel] [PATCH] Support for Ambisonics and OpusProjection* API.

2018-07-26 Thread Vittorio Giovara
On Thu, Jul 26, 2018 at 4:15 PM, Rostislav Pehlivanov wrote: > Hey, > > As of now, the ambisonics API is enabled by default in libopus. We still > don't have a way to signal ambisonics yet. > We still have plenty of bits left in libavutil/channel_layout.h to signal > many orders of ambisonics

[FFmpeg-devel] [PATCH 4/4] vf_tonemap: Update hdr metadata with the new peak value

2018-07-25 Thread Vittorio Giovara
Less effective than the approach in vf_tonemap_opencl because there is no peak detection, but it's still a good idea to implement this. --- libavfilter/vf_tonemap.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/libavfilter/vf_tonemap.c b/libavfilter/vf_tonemap.c index

[FFmpeg-devel] [PATCH 2/4] vf_tonemap[_opencl]: Move determine_signal_peak() to a shared file

2018-07-25 Thread Vittorio Giovara
The two functions are identical. Use the shared LumaCoeffients type too. --- libavfilter/Makefile| 2 +- libavfilter/colorspace.c| 29 + libavfilter/colorspace.h| 6 ++ libavfilter/vf_tonemap.c| 38 +++--

[FFmpeg-devel] [PATCH 3/4] vf_tonemap_opencl: Move update_metadata() to a shared file

2018-07-25 Thread Vittorio Giovara
--- libavfilter/colorspace.c| 17 + libavfilter/colorspace.h| 1 + libavfilter/vf_tonemap_opencl.c | 19 +-- 3 files changed, 19 insertions(+), 18 deletions(-) diff --git a/libavfilter/colorspace.c b/libavfilter/colorspace.c index

[FFmpeg-devel] [PATCH 1/4] vf_tonemap: Update the default peak values

2018-07-25 Thread Vittorio Giovara
When there is no metadata attached to a frame, take into account both the PQ and HLG transfers, and change the HLG default value to 10: the value of 12 is the maximum range in scene referred light, but the reference OOTF maps this from 0 to 1000 cd/m² on the ideal HLG monitor. This matches what

Re: [FFmpeg-devel] [PATCH] ffv1dec: Ensure that pixel format constraints are respected

2018-07-19 Thread Vittorio Giovara
On Wed, Jul 18, 2018 at 10:37 PM, Michael Niedermayer < mich...@niedermayer.cc> wrote: > On Wed, Jul 18, 2018 at 11:03:47AM -0400, Derek Buitenhuis wrote: > > On Wed, Jul 18, 2018 at 10:01 AM, Vittorio Giovara > > wrote: > > >> this does not follow from

[FFmpeg-devel] [PATCH] ffv1dec: Ensure that pixel format constraints are respected

2018-07-18 Thread Vittorio Giovara
On Tue, Jul 17, 2018 at 11:58:06PM +0200,Michael Niedermayer wrote: > > Its a consequence of the subsampling factor. > > this does not follow from what you write below. But more so this is not > how pixel formats were implemented in FFmpeg. > Where does this idea come from ? I found the

[FFmpeg-devel] [PATCH] svq1dec: Ensure that pixel format constraints are respected

2018-07-18 Thread Vittorio Giovara
2018-07-17 21:39 GMT+02:00, Carl Eugen Hoyos : > 2018-07-17 21:39 GMT+02:00, Vittorio Giovara : > > YUV410P requires that sizes are divisible by 4. There seem to be > > some encoders that ignore that and encode a different value in > > the bitstream itself. Handle t

[FFmpeg-devel] [PATCH 2/2] ffv1dec: Ensure that pixel format constraints are respected

2018-07-17 Thread Vittorio Giovara
YUV410P requires that sizes are divisible by 4. There are some encoders (including ffmpeg's) that ignore this constraint and encode a different value in the bitstream itself. Handle that case by exporting the relative cropping information. --- Alternatively it is possible to always enforce mod4

[FFmpeg-devel] [PATCH 1/2] svq1dec: Ensure that pixel format constraints are respected

2018-07-17 Thread Vittorio Giovara
YUV410P requires that sizes are divisible by 4. There seem to be some encoders that ignore that and encode a different value in the bitstream itself. Handle that case by exporting the relative cropping information. --- Alternatively it is possible to always enforce mod4 sizes and call it a day.

[FFmpeg-devel] [PATCH] Use the same name for stereo3d frame/packet side data

2018-06-04 Thread Vittorio Giovara
--- libavutil/frame.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavutil/frame.c b/libavutil/frame.c index 00215ac29a..deb9b6f334 100644 --- a/libavutil/frame.c +++ b/libavutil/frame.c @@ -819,7 +819,7 @@ const char *av_frame_side_data_name(enum AVFrameSideDataType

Re: [FFmpeg-devel] [PATCH] lavfi: a minor fix to tonemap peak detection.

2018-05-21 Thread Vittorio Giovara
On Mon, May 21, 2018 at 2:58 AM, Ruiling Song wrote: > If the transfer was SMPTE2084, use the peak of 1 even if not tagged. > Otherwise, we would assume it is HLG with a peak of 1200. > Based on suggestion by Niklas Haas. > > Signed-off-by: Ruiling Song

Re: [FFmpeg-devel] [PATCH 01/24] avcodec: add color_range to AVCodec struct

2018-05-01 Thread Vittorio Giovara
-- On Wed May 2 01:45:47 EEST 2018 Rostislav Pehlivanov wrote: > I agree with you, they need to be gone. The purpose of the patchset also > isn't just to get rid of them, its to have a good api to handle color > ranges and how it ought to be handled by filters and codecs. His only > objection

Re: [FFmpeg-devel] [PATCH 01/24] avcodec: add color_range to AVCodec struct

2018-05-01 Thread Vittorio Giovara
-- On 5/1/2018 4:39 PM, Paul B Mahol wrote: > Signed-off-by: Paul B Mahol > --- > libavcodec/avcodec.h | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/libavcodec/avcodec.h b/libavcodec/avcodec.h > index fb0c6fae70..3a8f69243c 100644 > --- a/libavcodec/avcodec.h > +++

[FFmpeg-devel] [PATCH] aac: Rework extradata parsing code

2018-04-17 Thread Vittorio Giovara
- enable the parsing code - use the new buffer instead of replacing the context one - do not push/pop configuration, just discard the exiting one - propagate errors correctly --- ping libavcodec/aacdec_template.c | 22 -- 1 file changed, 8 insertions(+), 14 deletions(-)

[FFmpeg-devel] [PATCH] aac: Rework extradata parsing code

2018-04-12 Thread Vittorio Giovara
- enable the parsing code - use the new buffer instead of replacing the context one - do not push/pop configuration, just discard the exiting one - propagate errors correctly --- libavcodec/aacdec_template.c | 22 -- 1 file changed, 8 insertions(+), 14 deletions(-) diff --git

[FFmpeg-devel] [PATCH] avformat/rtpenc_chain: use the proper function to free AVFormatContext

2018-04-06 Thread Vittorio Giovara
Yes the order of operations is a problem in a generic matrix, but for a display matrix the order is more or less consolidated in a defacto standard: check for flip first, then rotation. We have the same pattern in h264 and hevc decoder for the rotation side data. You are right that the

Re: [FFmpeg-devel] [PATCH] display: Add AVDisplayOrientation API

2018-04-05 Thread Vittorio Giovara
--- > On Wed, Apr 04, 2018 at 05:30:24PM +0200, Vittorio Giovara wrote: > > libavutil/display.c | 92 > > + > > libavutil/display.h | 53 ++ > > 2 files changed, 145 insertions(+) >

[FFmpeg-devel] [PATCH] display: Add AVDisplayOrientation API

2018-04-04 Thread Vittorio Giovara
that describe which rendering operations should be performed on the frame. The existing API is still available and useful in case of custom rotations. Signed-off-by: Vittorio Giovara <vittorio.giov...@gmail.com> --- Note: the new operations describe a clockwise rotation, while the old API pr

Re: [FFmpeg-devel] [PATCH 2/2] pixdesc: deprecate AV_PIX_FMT_FLAG_PSEUDOPAL

2018-04-03 Thread Vittorio Giovara
On Thu, Mar 29, 2018 at 03:30:43PM +0200, wm4 wrote: >* PSEUDOPAL pixel formats are not paletted, but carried a palette with the *>* intention of allowing code to treat unpaletted formats as paletted. The *>* palette simply mapped the byte values to the resulting RGB values, *>* making it some

Re: [FFmpeg-devel] [PATCH] avfilter/vf_scale: Do not set YUV color range for RGB formats

2018-04-02 Thread Vittorio Giovara
On 3/20/18, Michael Niedermayer http://ffmpeg.org/mailman/listinfo/ffmpeg-devel>> wrote: >* Signed-off-by: Michael Niedermayer > *>* --- *>* libavfilter/vf_scale.c | 7 ++- *>* 1 file changed, 6 insertions(+), 1 deletion(-) *>>* diff --git

Re: [FFmpeg-devel] [PATCH 2/2] libavcodec/mjpeg: remove YUVJ mentions

2017-12-11 Thread Vittorio Giovara
>* On 12/8/17, Paul B Mahol http://gmail.com>>* >> On 12/8/17, Vittorio Giovara > <http://ffmpeg.org/mailman/listinfo/ffmpeg-devel>> wrote: >*> If we were to break this feature, I'd suggest going the full route of *>*> adding a PixelFormaton and wo

Re: [FFmpeg-devel] [PATCH 01/27] avcodec: add color_range to AVCodec struct and use it

2017-12-11 Thread Vittorio Giovara
>* On Sat, Dec 9, 2017 at 10:37 AM, Paul B Mahol > wrote:* > Endless bikeshed... Being dismissive to valid points is not good for project health. > I hate how people can be so ignorant these days. Can you tone it down a notch maybe? I can't

Re: [FFmpeg-devel] [PATCH 2/2] libavcodec/mjpeg: remove YUVJ mentions

2017-12-08 Thread Vittorio Giovara
> On 12/8/17, Paul B Mahole * >* wrote: >*> This will basically break everyone encoding mjpeg right now, since it *>*> suddenly only accepts different formats without any common-ground *>*> before/after. *>*> Furthermore, there is no replacement for

[FFmpeg-devel] [PATCH] vf_zscale: Fix alpha destination graph for floating point pixel formats

2017-12-07 Thread Vittorio Giovara
This was setting the input pixel type instead of the output one, leading to incorrect data being fed to the library. Signed-off-by: Vittorio Giovara <vittorio.giov...@gmail.com> --- libavfilter/vf_zscale.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libav

[FFmpeg-devel] [PATCH 1/2] vf_zscale: Relax color properties maximum bounds

2017-11-28 Thread Vittorio Giovara
This simplifies adding new values, which are already validated elsewhere. Signed-off-by: Vittorio Giovara <vittorio.giov...@gmail.com> --- libavfilter/vf_zscale.c | 24 1 file changed, 12 insertions(+), 12 deletions(-) diff --git a/libavfilter/vf_zscale.c b/libav

[FFmpeg-devel] [PATCH 2/2] vf_zscale: Add more supported input properties

2017-11-28 Thread Vittorio Giovara
Signed-off-by: Vittorio Giovara <vittorio.giov...@gmail.com> --- This version should be more complete. Regarding configure changes, this library is not packaged by any distribution that I could find, so users will just need to use zimg HEAD or any stable snapshot (2.6.2). Vittorio libav

Re: [FFmpeg-devel] [PATCH] mov: Support mdcv and clli boxes for mastering display an color light level

2017-11-27 Thread Vittorio Giovara
>* On 11/27/2017 5:20 PM, James Almer wrote:*> Pointless duplicate atoms :/ At >least these don't use fixed point > values, so they are nicer. indeed > I assume no file will have both smdm and mdcv, or coll and clli, so > reusing the MOVStreamContext fields should be ok, but maybe free the >

Re: [FFmpeg-devel] [PATCH] mov: Support mdcv and clli boxes for mastering display an color light level

2017-11-27 Thread Vittorio Giovara
> On 11/27/2017 5:20 PM, James Almer wrote: > Where are these two defined? Because > https://github.com/webmproject/vp9-dash/blob/master/VPCodecISOMediaFileFormatBinding.md > describes coll and smdm, and those are already supported. these are unrelated to vp9 (or mp4), they are the mov-only atoms

[FFmpeg-devel] [PATCH] mov: Support mdcv and clli boxes for mastering display an color light level

2017-11-27 Thread Vittorio Giovara
Signed-off-by: Vittorio Giovara <vittorio.giov...@gmail.com> --- libavformat/mov.c | 71 +++ 1 file changed, 71 insertions(+) diff --git a/libavformat/mov.c b/libavformat/mov.c index 79023ef369..bb463017a3 100644 --- a/libavformat/mov.c

Re: [FFmpeg-devel] [PATCH 0/1][TOOL][HACK] Allocation NULL check fuzzer

2017-11-24 Thread Vittorio Giovara
On 11/24/2017 11:35 PM, Derek *Buitenhuis* wrote: > It would probably make an absolute ton of reports, since there are quite > a few unchecked allocs in FFmpeg... might be kinda spammy. That might not be the case any more, most of the checks have been added in the Coverity effort of 2015 and

[FFmpeg-devel] [PATCH] vf_zscale: Add more supported input properties

2017-11-15 Thread Vittorio Giovara
--- Now without mxf code >_> There is a stable release with this code, and it's a minor update, not sure if it warrants a configure check, but I'll add it if requested. Vittorio libavfilter/vf_zscale.c | 26 -- 1 file changed, 24 insertions(+), 2 deletions(-) diff --git

[FFmpeg-devel] [PATCH] vf_zscale: Add more supported input properties

2017-11-14 Thread Vittorio Giovara
--- libavfilter/vf_zscale.c | 26 -- libavformat/mxfdec.c| 20 2 files changed, 44 insertions(+), 2 deletions(-) diff --git a/libavfilter/vf_zscale.c b/libavfilter/vf_zscale.c index 09fd842fe5..7d048da1ef 100644 --- a/libavfilter/vf_zscale.c +++

[FFmpeg-devel] [PATCH] prores: Always assume limited range

2017-09-27 Thread Vittorio Giovara
As defined by the spcifications --- libavcodec/proresdec_lgpl.c | 1 + 1 file changed, 1 insertion(+) diff --git a/libavcodec/proresdec_lgpl.c b/libavcodec/proresdec_lgpl.c index bc5bdb5a4d..c86d433f50 100644 --- a/libavcodec/proresdec_lgpl.c +++ b/libavcodec/proresdec_lgpl.c @@ -177,6 +177,7 @@

Re: [FFmpeg-devel] [PATCH 1/2] lavu: add a gamma field to AVMasteringDisplayMetadata

2017-09-20 Thread Vittorio Giovara
>* In my opinion we should not add new fields to structures that map 1:1 to *>* something defined elsewhere (with the exception of booleans). *>* I think this should be a separate side data and type, ie AVGammaResponse, *>* that can of course reside in the same header. *>* -- *>* Vittorio *>*

[FFmpeg-devel] [PATCH] pixdesc: Add API to map color property name to enum value

2017-09-20 Thread Vittorio Giovara
Signed-off-by: Vittorio Giovara <vittorio.giov...@gmail.com> --- Updated following review. Vittorio libavutil/pixdesc.c | 65 + libavutil/pixdesc.h | 25 + 2 files changed, 90 insertions(+) diff --git a/libavutil/pix

  1   2   3   4   >