Re: [FFmpeg-devel] [PATCH] configure: add build tree's directories to rpath
Le decadi 30 vendémiaire, an CCXXIII, Lukasz Marek a écrit :
> Building with static link is much slower.
> I agree patch is wrong, it could be controlled by separate option, just
> for devel, but nvm.
It can be controlled by LD_LIBRARY_PATH, as Derek pointed out. I use this
(zsh):
libs=($src/lib*(/:t))
ld_library_path=($build/${^libs})
export LD_LIBRARY_PATH=${(j.:.)ld_library_path}
Note that what you proposed could devolve into a security issue for people
building in /tmp or similar directories: once the build dir has been
cleaned, any user can create it and hijack all users' ffmpeg sessions.
Regards,
--
Nicolas George
signature.asc
Description: Digital signature
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
Re: [FFmpeg-devel] [PATCH] configure: add build tree's directories to rpath
On 21 October 2014 12:01, Derek Buitenhuis wrote: > On 10/21/2014 8:21 AM, Carl Eugen Hoyos wrote: > > This sounds like a very bad idea to me > > I agree. It's not nice to have remnants of the build process in the > installed binaries. > > If you need to run them during development, use LD_LIBRARY_PATH or > or build statically. > Building with static link is much slower. I agree patch is wrong, it could be controlled by separate option, just for devel, but nvm. Thx for pointing an issue. ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
Re: [FFmpeg-devel] [PATCH] configure: add build tree's directories to rpath
On 10/21/2014 8:21 AM, Carl Eugen Hoyos wrote: > This sounds like a very bad idea to me I agree. It's not nice to have remnants of the build process in the installed binaries. If you need to run them during development, use LD_LIBRARY_PATH or or build statically. - Derek ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
Re: [FFmpeg-devel] [PATCH] configure: add build tree's directories to rpath
Lukasz Marek gmail.com> writes: > if you run > configure --enable-rpath --disable-static --enable-shared > make > make install > then installed binaries of the fftolls will have more > paths defined to look libraries for. This sounds like a very bad idea to me > but The goal is to allow to run fftool in build tree > without installing. Of course, I understand. Carl Eugen ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
Re: [FFmpeg-devel] [PATCH] configure: add build tree's directories to rpath
W dniu wtorek, 21 października 2014 Carl Eugen Hoyos napisał(a): > Lukasz Marek gmail.com> writes: > > > This commit allows to run programs linked > > dynamically in build dir without installing. > > Sorry if I misunderstand: > Doesn't this patch change the properties of the > installed binaries? if you run configure --enable-rpath --disable-static --enable-shared make make install then installed binaries of the fftolls will have more paths defined to look libraries for. but The goal is to allow to run fftool in build tree without installing. it really simpliefies and speed up recompilation during development. Now I'm not sure if other option should be added to enable it. ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
Re: [FFmpeg-devel] [PATCH] configure: add build tree's directories to rpath
Lukasz Marek gmail.com> writes: > This commit allows to run programs linked > dynamically in build dir without installing. Sorry if I misunderstand: Doesn't this patch change the properties of the installed binaries? Carl Eugen ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
[FFmpeg-devel] [PATCH] configure: add build tree's directories to rpath
This commit allows to run programs linked dynamically in build dir without installing. Signed-off-by: Lukasz Marek --- configure | 1 + 1 file changed, 1 insertion(+) diff --git a/configure b/configure index 3e181aa..5cef407 100755 --- a/configure +++ b/configure @@ -5076,6 +5076,7 @@ check_disable_warning -Wno-pointer-sign # add some linker flags check_ldflags -Wl,--warn-common check_ldflags -Wl,-rpath-link=libpostproc:libswresample:libswscale:libavfilter:libavdevice:libavformat:libavcodec:libavutil:libavresample +enabled rpath && add_ldexeflags -Wl,-rpath,libpostproc:libswresample:libswscale:libavfilter:libavdevice:libavformat:libavcodec:libavutil:libavresample enabled rpath && add_ldexeflags -Wl,-rpath,$libdir test_ldflags -Wl,-Bsymbolic && append SHFLAGS -Wl,-Bsymbolic -- 1.9.1 ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
