Re: [FFmpeg-devel] [PATCH 0/3] Finish new iteration APIs

2018-02-23 Thread wm4
On Fri, 23 Feb 2018 01:21:52 +0100 Michael Niedermayer wrote: > On Thu, Feb 22, 2018 at 07:31:27PM +0100, wm4 wrote: > > On Thu, 22 Feb 2018 16:28:56 +0100 > > Michael Niedermayer wrote: > > > > > On Wed, Feb 21, 2018 at 09:02:40PM +0100, wm4

Re: [FFmpeg-devel] [PATCH 0/3] Finish new iteration APIs

2018-02-22 Thread Tobias Rapp
On 22.02.2018 16:47, Nicolas George wrote: Hi. Not sure where in the thread would be the best place to reply, so I might as well reply here. There is one idea I have been toying with for some time that relates to codec registration. It is significantly different from the direction this

Re: [FFmpeg-devel] [PATCH 0/3] Finish new iteration APIs

2018-02-22 Thread Michael Niedermayer
On Thu, Feb 22, 2018 at 07:31:27PM +0100, wm4 wrote: > On Thu, 22 Feb 2018 16:28:56 +0100 > Michael Niedermayer wrote: > > > On Wed, Feb 21, 2018 at 09:02:40PM +0100, wm4 wrote: > > > On Wed, 21 Feb 2018 19:14:59 +0100 > > > Michael Niedermayer

Re: [FFmpeg-devel] [PATCH 0/3] Finish new iteration APIs

2018-02-22 Thread Rostislav Pehlivanov
On 22 February 2018 at 18:31, wm4 wrote: > > > > We have IIRC like 400 decoders, most are odd/rare/fringe and its a valid > > request to hard disable these at runtime process wide. > > Maybe we should just disable them by default, instead of forcing the > user to play

Re: [FFmpeg-devel] [PATCH 0/3] Finish new iteration APIs

2018-02-22 Thread wm4
On Thu, 22 Feb 2018 16:28:56 +0100 Michael Niedermayer wrote: > On Wed, Feb 21, 2018 at 09:02:40PM +0100, wm4 wrote: > > On Wed, 21 Feb 2018 19:14:59 +0100 > > Michael Niedermayer wrote: > > > > > On Wed, Feb 21, 2018 at 09:27:02AM +0100, wm4

Re: [FFmpeg-devel] [PATCH 0/3] Finish new iteration APIs

2018-02-22 Thread Nicolas George
Hi. Not sure where in the thread would be the best place to reply, so I might as well reply here. There is one idea I have been toying with for some time that relates to codec registration. It is significantly different from the direction this discussion was taking, but I think it offers a lot

Re: [FFmpeg-devel] [PATCH 0/3] Finish new iteration APIs

2018-02-22 Thread Michael Niedermayer
On Wed, Feb 21, 2018 at 09:02:40PM +0100, wm4 wrote: > On Wed, 21 Feb 2018 19:14:59 +0100 > Michael Niedermayer wrote: > > > On Wed, Feb 21, 2018 at 09:27:02AM +0100, wm4 wrote: > > > On Tue, 20 Feb 2018 21:45:12 +0100 > > > Michael Niedermayer

Re: [FFmpeg-devel] [PATCH 0/3] Finish new iteration APIs

2018-02-21 Thread wm4
On Sun, 18 Feb 2018 17:58:16 + Josh de Kock wrote: > This should be the last of the major API changes. I'm not entirely > sure if I missed anything. > > Josh > All 3 patches LGTM if all tests pass and ffmpeg.c codec/device/filter listing is the same as before the patch.

Re: [FFmpeg-devel] [PATCH 0/3] Finish new iteration APIs

2018-02-21 Thread wm4
On Wed, 21 Feb 2018 19:14:59 +0100 Michael Niedermayer wrote: > On Wed, Feb 21, 2018 at 09:27:02AM +0100, wm4 wrote: > > On Tue, 20 Feb 2018 21:45:12 +0100 > > Michael Niedermayer wrote: > > > > > On Tue, Feb 20, 2018 at 06:28:20PM +0100, wm4

Re: [FFmpeg-devel] [PATCH 0/3] Finish new iteration APIs

2018-02-21 Thread Michael Niedermayer
On Wed, Feb 21, 2018 at 09:27:02AM +0100, wm4 wrote: > On Tue, 20 Feb 2018 21:45:12 +0100 > Michael Niedermayer wrote: > > > On Tue, Feb 20, 2018 at 06:28:20PM +0100, wm4 wrote: > > > On Tue, 20 Feb 2018 17:30:32 +0100 > > > Michael Niedermayer

Re: [FFmpeg-devel] [PATCH 0/3] Finish new iteration APIs

2018-02-21 Thread James Almer
On 2/21/2018 5:04 PM, wm4 wrote: > On Sun, 18 Feb 2018 17:58:16 + > Josh de Kock wrote: > >> This should be the last of the major API changes. I'm not entirely >> sure if I missed anything. >> >> Josh >> > > All 3 patches LGTM if all tests pass and ffmpeg.c

Re: [FFmpeg-devel] [PATCH 0/3] Finish new iteration APIs

2018-02-21 Thread Michael Niedermayer
On Wed, Feb 21, 2018 at 04:04:15PM +0700, Muhammad Faiz wrote: > On Tue, Feb 20, 2018 at 2:30 AM, Michael Niedermayer > wrote: > > On Sun, Feb 18, 2018 at 05:58:16PM +, Josh de Kock wrote: > >> This should be the last of the major API changes. I'm not entirely > >>

Re: [FFmpeg-devel] [PATCH 0/3] Finish new iteration APIs

2018-02-21 Thread Muhammad Faiz
On Tue, Feb 20, 2018 at 2:30 AM, Michael Niedermayer wrote: > On Sun, Feb 18, 2018 at 05:58:16PM +, Josh de Kock wrote: >> This should be the last of the major API changes. I'm not entirely >> sure if I missed anything. > > Moving from a register based system where a

Re: [FFmpeg-devel] [PATCH 0/3] Finish new iteration APIs

2018-02-21 Thread wm4
On Tue, 20 Feb 2018 21:45:12 +0100 Michael Niedermayer wrote: > On Tue, Feb 20, 2018 at 06:28:20PM +0100, wm4 wrote: > > On Tue, 20 Feb 2018 17:30:32 +0100 > > Michael Niedermayer wrote: > > > > > On Tue, Feb 20, 2018 at 10:17:02AM -0300, James

Re: [FFmpeg-devel] [PATCH 0/3] Finish new iteration APIs

2018-02-20 Thread Michael Niedermayer
On Tue, Feb 20, 2018 at 06:28:20PM +0100, wm4 wrote: > On Tue, 20 Feb 2018 17:30:32 +0100 > Michael Niedermayer wrote: > > > On Tue, Feb 20, 2018 at 10:17:02AM -0300, James Almer wrote: > > > On 2/20/2018 9:21 AM, wm4 wrote: > > > > On Tue, 20 Feb 2018 08:47:51 -0300 >

Re: [FFmpeg-devel] [PATCH 0/3] Finish new iteration APIs

2018-02-20 Thread Michael Niedermayer
On Tue, Feb 20, 2018 at 02:02:14PM -0300, James Almer wrote: > On 2/20/2018 1:30 PM, Michael Niedermayer wrote: > > On Tue, Feb 20, 2018 at 10:17:02AM -0300, James Almer wrote: > >> On 2/20/2018 9:21 AM, wm4 wrote: > >>> On Tue, 20 Feb 2018 08:47:51 -0300 > >>> James Almer

Re: [FFmpeg-devel] [PATCH 0/3] Finish new iteration APIs

2018-02-20 Thread Michael Niedermayer
On Tue, Feb 20, 2018 at 04:44:13PM +, Rostislav Pehlivanov wrote: > On 20 February 2018 at 16:30, Michael Niedermayer > wrote: > > > On Tue, Feb 20, 2018 at 10:17:02AM -0300, James Almer wrote: > > > On 2/20/2018 9:21 AM, wm4 wrote: > > > > On Tue, 20 Feb 2018

Re: [FFmpeg-devel] [PATCH 0/3] Finish new iteration APIs

2018-02-20 Thread wm4
On Tue, 20 Feb 2018 17:30:32 +0100 Michael Niedermayer wrote: > On Tue, Feb 20, 2018 at 10:17:02AM -0300, James Almer wrote: > > On 2/20/2018 9:21 AM, wm4 wrote: > > > On Tue, 20 Feb 2018 08:47:51 -0300 > > > James Almer wrote: > > > > > >>> It

Re: [FFmpeg-devel] [PATCH 0/3] Finish new iteration APIs

2018-02-20 Thread James Almer
On 2/20/2018 1:30 PM, Michael Niedermayer wrote: > On Tue, Feb 20, 2018 at 10:17:02AM -0300, James Almer wrote: >> On 2/20/2018 9:21 AM, wm4 wrote: >>> On Tue, 20 Feb 2018 08:47:51 -0300 >>> James Almer wrote: >>> > It has fully achieved its objectives. There's no more

Re: [FFmpeg-devel] [PATCH 0/3] Finish new iteration APIs

2018-02-20 Thread Rostislav Pehlivanov
On 20 February 2018 at 16:30, Michael Niedermayer wrote: > On Tue, Feb 20, 2018 at 10:17:02AM -0300, James Almer wrote: > > On 2/20/2018 9:21 AM, wm4 wrote: > > > On Tue, 20 Feb 2018 08:47:51 -0300 > > > James Almer wrote: > > > > > >>> It has fully

Re: [FFmpeg-devel] [PATCH 0/3] Finish new iteration APIs

2018-02-20 Thread Michael Niedermayer
On Tue, Feb 20, 2018 at 10:17:02AM -0300, James Almer wrote: > On 2/20/2018 9:21 AM, wm4 wrote: > > On Tue, 20 Feb 2018 08:47:51 -0300 > > James Almer wrote: > > > >>> It has fully achieved its objectives. There's no more visible global > >>> mutable state, and the actual

Re: [FFmpeg-devel] [PATCH 0/3] Finish new iteration APIs

2018-02-20 Thread James Almer
On 2/20/2018 9:21 AM, wm4 wrote: > On Tue, 20 Feb 2018 08:47:51 -0300 > James Almer wrote: > >>> It has fully achieved its objectives. There's no more visible global >>> mutable state, and the actual global mutable state has been reduced to >>> less than 5 codec entries. >>

Re: [FFmpeg-devel] [PATCH 0/3] Finish new iteration APIs

2018-02-20 Thread wm4
On Tue, 20 Feb 2018 08:47:51 -0300 James Almer wrote: > > It has fully achieved its objectives. There's no more visible global > > mutable state, and the actual global mutable state has been reduced to > > less than 5 codec entries. > > It's true that after the deprecation

Re: [FFmpeg-devel] [PATCH 0/3] Finish new iteration APIs

2018-02-20 Thread James Almer
On 2/20/2018 3:24 AM, wm4 wrote: > On Mon, 19 Feb 2018 23:30:24 -0300 > James Almer wrote: > >> On 2/19/2018 11:16 PM, Michael Niedermayer wrote: >>> On Mon, Feb 19, 2018 at 09:57:35PM +0100, Hendrik Leppkes wrote: On Mon, Feb 19, 2018 at 8:30 PM, Michael Niedermayer

Re: [FFmpeg-devel] [PATCH 0/3] Finish new iteration APIs

2018-02-19 Thread wm4
On Mon, 19 Feb 2018 23:30:24 -0300 James Almer wrote: > On 2/19/2018 11:16 PM, Michael Niedermayer wrote: > > On Mon, Feb 19, 2018 at 09:57:35PM +0100, Hendrik Leppkes wrote: > >> On Mon, Feb 19, 2018 at 8:30 PM, Michael Niedermayer > >> wrote: >

Re: [FFmpeg-devel] [PATCH 0/3] Finish new iteration APIs

2018-02-19 Thread James Almer
On 2/19/2018 11:16 PM, Michael Niedermayer wrote: > On Mon, Feb 19, 2018 at 09:57:35PM +0100, Hendrik Leppkes wrote: >> On Mon, Feb 19, 2018 at 8:30 PM, Michael Niedermayer >> wrote: >>> On Sun, Feb 18, 2018 at 05:58:16PM +, Josh de Kock wrote: This should be the

Re: [FFmpeg-devel] [PATCH 0/3] Finish new iteration APIs

2018-02-19 Thread Michael Niedermayer
On Mon, Feb 19, 2018 at 09:57:35PM +0100, Hendrik Leppkes wrote: > On Mon, Feb 19, 2018 at 8:30 PM, Michael Niedermayer > wrote: > > On Sun, Feb 18, 2018 at 05:58:16PM +, Josh de Kock wrote: > >> This should be the last of the major API changes. I'm not entirely > >>

Re: [FFmpeg-devel] [PATCH 0/3] Finish new iteration APIs

2018-02-19 Thread Hendrik Leppkes
On Mon, Feb 19, 2018 at 8:30 PM, Michael Niedermayer wrote: > On Sun, Feb 18, 2018 at 05:58:16PM +, Josh de Kock wrote: >> This should be the last of the major API changes. I'm not entirely >> sure if I missed anything. > > Moving from a register based system where a

Re: [FFmpeg-devel] [PATCH 0/3] Finish new iteration APIs

2018-02-19 Thread Michael Niedermayer
On Sun, Feb 18, 2018 at 05:58:16PM +, Josh de Kock wrote: > This should be the last of the major API changes. I'm not entirely > sure if I missed anything. Moving from a register based system where a user app can register any subset to a system which registers all via an array will increase