Re: [FFmpeg-devel] [PATCH] Support HDR10+ metadata for HEVC.

2020-12-06 Thread James Almer
On 12/6/2020 8:13 AM, Hendrik Leppkes wrote: On Sat, Dec 5, 2020 at 11:28 PM James Almer wrote: On 12/1/2020 3:09 PM, Mohammad Izadi wrote: Ian, can you please take a look into it? And if it's fine to push it. Thanks, Mohammad I removed the packet side data addition since it was not used

Re: [FFmpeg-devel] [PATCH] Support HDR10+ metadata for HEVC.

2020-12-06 Thread Hendrik Leppkes
On Sat, Dec 5, 2020 at 11:28 PM James Almer wrote: > > On 12/1/2020 3:09 PM, Mohammad Izadi wrote: > > Ian, can you please take a look into it? And if it's fine to push it. > > > > Thanks, > > Mohammad > > I removed the packet side data addition since it was not used by any > module. It can be

Re: [FFmpeg-devel] [PATCH] Support HDR10+ metadata for HEVC.

2020-12-05 Thread James Almer
On 12/1/2020 3:09 PM, Mohammad Izadi wrote: Ian, can you please take a look into it? And if it's fine to push it. Thanks, Mohammad I removed the packet side data addition since it was not used by any module. It can be added when a demuxer needs to propagate it. Also removed the entry for

Re: [FFmpeg-devel] [PATCH] Support HDR10+ metadata for HEVC.

2020-12-01 Thread Mohammad Izadi
Ian, can you please take a look into it? And if it's fine to push it. Thanks, Mohammad On Mon, Nov 23, 2020 at 1:29 PM Mohammad Izadi wrote: > From: Mohammad Izadi > > HDR10+ is dynamic metadata (A/341 Amendment - SMPTE2094-40) that needs to > be decoded from ITU-T T.35 in HEVC bitstream.

[FFmpeg-devel] [PATCH] Support HDR10+ metadata for HEVC.

2020-11-23 Thread Mohammad Izadi
From: Mohammad Izadi HDR10+ is dynamic metadata (A/341 Amendment - SMPTE2094-40) that needs to be decoded from ITU-T T.35 in HEVC bitstream. The HDR10+ is transferred to side data packet to be used or passed through. --- The fate test file can be found here:

Re: [FFmpeg-devel] [PATCH] Support HDR10+ metadata for HEVC.

2020-11-23 Thread Mohammad Izadi
Thanks, Mohammad On Fri, Nov 20, 2020 at 5:44 AM Anton Khirnov wrote: > Quoting Mohammad Izadi (2020-11-20 04:57:11) > > From: Mohammad Izadi > > > > HDR10+ is dynamic metadata (A/341 Amendment - SMPTE2094-40) that needs > to be decoded from ITU-T T.35 in HEVC bitstream. The HDR10+ is

Re: [FFmpeg-devel] [PATCH] Support HDR10+ metadata for HEVC.

2020-11-20 Thread Anton Khirnov
Quoting Mohammad Izadi (2020-11-20 04:57:11) > From: Mohammad Izadi > > HDR10+ is dynamic metadata (A/341 Amendment - SMPTE2094-40) that needs to be > decoded from ITU-T T.35 in HEVC bitstream. The HDR10+ is transferred to side > data packet to be used or passed through. > --- > The fate test

[FFmpeg-devel] [PATCH] Support HDR10+ metadata for HEVC.

2020-11-19 Thread Mohammad Izadi
From: Mohammad Izadi HDR10+ is dynamic metadata (A/341 Amendment - SMPTE2094-40) that needs to be decoded from ITU-T T.35 in HEVC bitstream. The HDR10+ is transferred to side data packet to be used or passed through. --- The fate test file can be found here:

Re: [FFmpeg-devel] [PATCH] Support HDR10+ metadata for HEVC.

2020-11-17 Thread Mohammad Izadi
On Sun, Nov 15, 2020 at 12:19 AM Andreas Rheinhardt < andreas.rheinha...@gmail.com> wrote: > Mohammad Izadi: > > From: Mohammad Izadi > > > > HDR10+ is dynamic metadata (A/341 Amendment - SMPTE2094-40) that needs > to be decoded from ITU-T T.35 in HEVC bitstream. The HDR10+ is transferred > to

[FFmpeg-devel] [PATCH] Support HDR10+ metadata for HEVC.

2020-11-17 Thread Mohammad Izadi
From: Mohammad Izadi HDR10+ is dynamic metadata (A/341 Amendment - SMPTE2094-40) that needs to be decoded from ITU-T T.35 in HEVC bitstream. The HDR10+ is transferred to side data packet to be used or passed through. --- The fate test file can be found here:

[FFmpeg-devel] [PATCH] Support HDR10+ metadata for HEVC.

2020-11-16 Thread Mohammad Izadi
From: Mohammad Izadi HDR10+ is dynamic metadata (A/341 Amendment - SMPTE2094-40) that needs to be decoded from ITU-T T.35 in HEVC bitstream. The HDR10+ is transferred to side data packet to be used or passed through. --- The fate test file can be found here:

[FFmpeg-devel] [PATCH] Support HDR10+ metadata for HEVC.

2020-11-15 Thread Mohammad Izadi
From: Mohammad Izadi HDR10+ is dynamic metadata (A/341 Amendment - SMPTE2094-40) that needs to be decoded from ITU-T T.35 in HEVC bitstream. The HDR10+ is transferred to side data packet to be used or passed through. --- The fate test file can be found here:

Re: [FFmpeg-devel] [PATCH] Support HDR10+ metadata for HEVC.

2020-11-15 Thread Andreas Rheinhardt
Mohammad Izadi: > From: Mohammad Izadi > > HDR10+ is dynamic metadata (A/341 Amendment - SMPTE2094-40) that needs to be > decoded from ITU-T T.35 in HEVC bitstream. The HDR10+ is transferred to side > data packet to be used or passed through. > > The fate test file can be found here: >

[FFmpeg-devel] [PATCH] Support HDR10+ metadata for HEVC.

2020-11-14 Thread Mohammad Izadi
From: Mohammad Izadi HDR10+ is dynamic metadata (A/341 Amendment - SMPTE2094-40) that needs to be decoded from ITU-T T.35 in HEVC bitstream. The HDR10+ is transferred to side data packet to be used or passed through. The fate test file can be found here:

Re: [FFmpeg-devel] [PATCH] Support HDR10+ metadata for HEVC.

2020-11-14 Thread Mohammad Izadi
Thank you Ian for your great detailed comments. Thanks, Mohammad On Wed, Nov 11, 2020 at 5:10 PM Jan Ekström wrote: > On 14.10.2020 2:53, Mohammad Izadi wrote: > > From: Mohammad Izadi > > > > HDR10+ is dynamic metadata (A/341 Amendment - SMPTE2094-40) that needs > to be decoded from ITU-T

Re: [FFmpeg-devel] [PATCH] Support HDR10+ metadata for HEVC.

2020-11-11 Thread Jan Ekström
On 14.10.2020 2:53, Mohammad Izadi wrote: > From: Mohammad Izadi > > HDR10+ is dynamic metadata (A/341 Amendment - SMPTE2094-40) that needs to be > decoded from ITU-T T.35 in HEVC bitstream. The HDR10+ is transferred to side > data packet to be used or passed through. > > The fate test file can

Re: [FFmpeg-devel] [PATCH] Support HDR10+ metadata for HEVC.

2020-11-11 Thread Mohammad Izadi
Is anybody there? Any update? Can we push it to the head? Thanks, Mohammad On Fri, Nov 6, 2020 at 9:42 PM Mohammad Izadi wrote: > Any update? Can we push it to the head? > Thanks, > Mohammad > > > On Mon, Oct 26, 2020 at 11:53 AM Mohammad Izadi wrote: > >> Thank you, Jan! I hope you feel

Re: [FFmpeg-devel] [PATCH] Support HDR10+ metadata for HEVC.

2020-11-06 Thread Mohammad Izadi
Any update? Can we push it to the head? Thanks, Mohammad On Mon, Oct 26, 2020 at 11:53 AM Mohammad Izadi wrote: > Thank you, Jan! I hope you feel better soon. > > > > On Sun, Oct 25, 2020 at 5:49 PM Jan Ekström wrote: > >> On Wed, Oct 14, 2020 at 2:54 AM Mohammad Izadi >> wrote: >> > >> >

Re: [FFmpeg-devel] [PATCH] Support HDR10+ metadata for HEVC.

2020-10-26 Thread Mohammad Izadi
Thank you, Jan! I hope you feel better soon. On Sun, Oct 25, 2020 at 5:49 PM Jan Ekström wrote: > On Wed, Oct 14, 2020 at 2:54 AM Mohammad Izadi > wrote: > > > > From: Mohammad Izadi > > > > HDR10+ is dynamic metadata (A/341 Amendment - SMPTE2094-40) that needs > to be decoded from ITU-T

Re: [FFmpeg-devel] [PATCH] Support HDR10+ metadata for HEVC.

2020-10-25 Thread Jan Ekström
On Wed, Oct 14, 2020 at 2:54 AM Mohammad Izadi wrote: > > From: Mohammad Izadi > > HDR10+ is dynamic metadata (A/341 Amendment - SMPTE2094-40) that needs to be > decoded from ITU-T T.35 in HEVC bitstream. The HDR10+ is transferred to side > data packet to be used or passed through. > > The

Re: [FFmpeg-devel] [PATCH] Support HDR10+ metadata for HEVC.

2020-10-24 Thread Harry Mallon
> On 23 Oct 2020, at 05:57, Mohammad Izadi > wrote: > > Any comments? > > Thanks, > Mohammad > > > On Tue, Oct 13, 2020 at 4:53 PM Mohammad Izadi wrote: > >> From: Mohammad Izadi >> >> [..] Hi Mohammad, Your change is in Patchwork here

Re: [FFmpeg-devel] [PATCH] Support HDR10+ metadata for HEVC.

2020-10-22 Thread Mohammad Izadi
Any comments? Thanks, Mohammad On Tue, Oct 13, 2020 at 4:53 PM Mohammad Izadi wrote: > From: Mohammad Izadi > > HDR10+ is dynamic metadata (A/341 Amendment - SMPTE2094-40) that needs to > be decoded from ITU-T T.35 in HEVC bitstream. The HDR10+ is transferred to > side data packet to be used

[FFmpeg-devel] [PATCH] Support HDR10+ metadata for HEVC.

2020-10-13 Thread Mohammad Izadi
From: Mohammad Izadi HDR10+ is dynamic metadata (A/341 Amendment - SMPTE2094-40) that needs to be decoded from ITU-T T.35 in HEVC bitstream. The HDR10+ is transferred to side data packet to be used or passed through. The fate test file can be found here:

Re: [FFmpeg-devel] [PATCH] Support HDR10+ metadata for HEVC.

2020-09-08 Thread Mohammad Izadi
I will add the test by the end of this week. Thanks, Mohammad On Mon, Sep 7, 2020 at 2:56 AM Jan Ekström wrote: > On Sat, Jul 25, 2020 at 12:09 AM Mohammad Izadi > wrote: > > > > On Fri, Jul 24, 2020 at 9:30 AM Andreas Rheinhardt < > > andreas.rheinha...@gmail.com> wrote: > > > > > Mohammad

Re: [FFmpeg-devel] [PATCH] Support HDR10+ metadata for HEVC.

2020-09-07 Thread Jan Ekström
On Sat, Jul 25, 2020 at 12:09 AM Mohammad Izadi wrote: > > On Fri, Jul 24, 2020 at 9:30 AM Andreas Rheinhardt < > andreas.rheinha...@gmail.com> wrote: > > > Mohammad Izadi: > > > From: Mohammad Izadi > > > > > > HDR10+ is dynamic metadata (A/341 Amendment - SMPTE2094-40) that needs > > to be

Re: [FFmpeg-devel] [PATCH] Support HDR10+ metadata for HEVC.

2020-09-01 Thread Jan Ekström
On Tue, Sep 1, 2020 at 5:22 PM Harry Mallon wrote: > > > > > > On 12 Aug 2020, at 21:58, Vittorio Giovara > > wrote: > > > > On Wed, Aug 12, 2020 at 6:40 PM Mohammad Izadi wrote: > > > >> Vittorio, > >> > >> What is the next step for me? > >> > >> Thanks, > >> Mohammad > >> > > > > Hi, I don't

Re: [FFmpeg-devel] [PATCH] Support HDR10+ metadata for HEVC.

2020-09-01 Thread Harry Mallon
> On 12 Aug 2020, at 21:58, Vittorio Giovara wrote: > > On Wed, Aug 12, 2020 at 6:40 PM Mohammad Izadi wrote: > >> Vittorio, >> >> What is the next step for me? >> >> Thanks, >> Mohammad >> > > Hi, I don't have any more comments for the patch, except that it would be > nice if there

Re: [FFmpeg-devel] [PATCH] Support HDR10+ metadata for HEVC.

2020-08-12 Thread Vittorio Giovara
On Wed, Aug 12, 2020 at 6:40 PM Mohammad Izadi wrote: > Vittorio, > > What is the next step for me? > > Thanks, > Mohammad > Hi, I don't have any more comments for the patch, except that it would be nice if there were some kind of fate testing. See for example

Re: [FFmpeg-devel] [PATCH] Support HDR10+ metadata for HEVC.

2020-08-12 Thread Mohammad Izadi
Vittorio, What is the next step for me? Thanks, Mohammad On Fri, Aug 7, 2020 at 9:51 AM Mohammad Izadi wrote: > Any more comments? Are you OK to merge? > Thanks, > Mohammad > > > On Thu, Jul 30, 2020 at 9:06 AM Vittorio Giovara < > vittorio.giov...@gmail.com> wrote: > >> On Mon, Jul 27,

Re: [FFmpeg-devel] [PATCH] Support HDR10+ metadata for HEVC.

2020-08-07 Thread Mohammad Izadi
Any more comments? Are you OK to merge? Thanks, Mohammad On Thu, Jul 30, 2020 at 9:06 AM Vittorio Giovara wrote: > On Mon, Jul 27, 2020 at 11:44 PM Mohammad Izadi < > izadi-at-google@ffmpeg.org> wrote: > > > It seems FATE is for the regression test. Here is a sample that you can > use > >

Re: [FFmpeg-devel] [PATCH] Support HDR10+ metadata for HEVC.

2020-07-30 Thread Vittorio Giovara
On Mon, Jul 27, 2020 at 11:44 PM Mohammad Izadi < izadi-at-google@ffmpeg.org> wrote: > It seems FATE is for the regression test. Here is a sample that you can use > and check: > > https://www.dropbox.com/s/3ewr2t2lvv2cy8d/20200727_143643.mp4?dl=0 > > Thanks I will check it out. Fate is

Re: [FFmpeg-devel] [PATCH] Support HDR10+ metadata for HEVC.

2020-07-27 Thread Mohammad Izadi
It seems FATE is for the regression test. Here is a sample that you can use and check: https://www.dropbox.com/s/3ewr2t2lvv2cy8d/20200727_143643.mp4?dl=0 Thanks, Mohammad On Mon, Jul 27, 2020 at 7:53 AM Vittorio Giovara wrote: > On Fri, Jul 24, 2020 at 11:09 PM Mohammad Izadi < >

Re: [FFmpeg-devel] [PATCH] Support HDR10+ metadata for HEVC.

2020-07-27 Thread Vittorio Giovara
On Fri, Jul 24, 2020 at 11:09 PM Mohammad Izadi < izadi-at-google@ffmpeg.org> wrote: > On Fri, Jul 24, 2020 at 9:30 AM Andreas Rheinhardt < > andreas.rheinha...@gmail.com> wrote: > > > Mohammad Izadi: > > > From: Mohammad Izadi > > > > > > HDR10+ is dynamic metadata (A/341 Amendment -

Re: [FFmpeg-devel] [PATCH] Support HDR10+ metadata for HEVC.

2020-07-24 Thread Mohammad Izadi
On Fri, Jul 24, 2020 at 9:30 AM Andreas Rheinhardt < andreas.rheinha...@gmail.com> wrote: > Mohammad Izadi: > > From: Mohammad Izadi > > > > HDR10+ is dynamic metadata (A/341 Amendment - SMPTE2094-40) that needs > to be decoded from ITU-T T.35 in HEVC bitstream. The HDR10+ is transferred > to

Re: [FFmpeg-devel] [PATCH] Support HDR10+ metadata for HEVC.

2020-07-24 Thread Andreas Rheinhardt
Mohammad Izadi: > From: Mohammad Izadi > > HDR10+ is dynamic metadata (A/341 Amendment - SMPTE2094-40) that needs to be > decoded from ITU-T T.35 in HEVC bitstream. The HDR10+ is transferred to side > data packet to be used or passed through. > --- > libavcodec/avpacket.c | 1 + >

Re: [FFmpeg-devel] [PATCH] Support HDR10+ metadata for HEVC

2020-07-24 Thread James Almer
On 7/23/2020 7:26 PM, Mohammad Izadi wrote: >>> void av_fast_padded_malloc(void *ptr, unsigned int *size, size_t >> min_size) >>> { >>> @@ -2346,3 +2359,170 @@ int ff_int_from_list_or_default(void *ctx, const >> char * val_name, int val, >>> "%s %d are not supported. Set to default

[FFmpeg-devel] [PATCH] Support HDR10+ metadata for HEVC.

2020-07-23 Thread Mohammad Izadi
From: Mohammad Izadi HDR10+ is dynamic metadata (A/341 Amendment - SMPTE2094-40) that needs to be decoded from ITU-T T.35 in HEVC bitstream. The HDR10+ is transferred to side data packet to be used or passed through. --- libavcodec/avpacket.c | 1 + libavcodec/decode.c | 1 +

Re: [FFmpeg-devel] [PATCH] Support HDR10+ metadata for HEVC

2020-07-23 Thread Mohammad Izadi
I am not sure if you received the patch in reply to the thread? I used: git send-email 0001-Support-HDR10-metadata-for-HEVC.patch --to= ffmpeg-devel@ffmpeg.org --in-reply-to= 422719c5-f010-6b39-6415-b3bf46dcb...@rothenpieler.org It seems it created a new thread. Did you receive it? Thanks,

[FFmpeg-devel] [PATCH] Support HDR10+ metadata for HEVC.

2020-07-23 Thread Mohammad Izadi
From: Mohammad Izadi HDR10+ is dynamic metadata (A/341 Amendment - SMPTE2094-40) that needs to be decoded from ITU-T T.35 in HEVC bitstream. The HDR10+ is transferred to side data packet to be used or passed through. --- libavcodec/avpacket.c | 1 + libavcodec/decode.c | 1 +

Re: [FFmpeg-devel] [PATCH] Support HDR10+ metadata for HEVC

2020-07-23 Thread Mohammad Izadi
Thanks, Mohammad On Thu, Jul 23, 2020 at 1:14 AM zhilizhao wrote: > > > > On Jul 17, 2020, at 5:47 AM, Steinar H. Gunderson < > steinar+ffm...@gunderson.no> wrote: > > > > On Thu, Jul 16, 2020 at 06:34:31PM -0300, James Almer wrote: > >>> static AVMutex codec_mutex = AV_MUTEX_INITIALIZER; >

Re: [FFmpeg-devel] [PATCH] Support HDR10+ metadata for HEVC

2020-07-23 Thread Mohammad Izadi
Please see my answers inline: On Thu, Jul 16, 2020 at 2:34 PM James Almer wrote: > On 7/16/2020 4:23 PM, Mohammad Izadi wrote: > > From: Mohammad Izadi > > > > --- > > libavcodec/avpacket.c | 1 + > > libavcodec/decode.c | 1 + > > libavcodec/hevc_sei.c | 40 +++--- > >

Re: [FFmpeg-devel] [PATCH] Support HDR10+ metadata for HEVC

2020-07-23 Thread Timo Rothenpieler
On 23/07/2020 10:13, zhilizhao wrote: On Jul 17, 2020, at 5:47 AM, Steinar H. Gunderson wrote: On Thu, Jul 16, 2020 at 06:34:31PM -0300, James Almer wrote: static AVMutex codec_mutex = AV_MUTEX_INITIALIZER; +static const uint8_t usa_country_code = 0xB5; +static const uint16_t

Re: [FFmpeg-devel] [PATCH] Support HDR10+ metadata for HEVC

2020-07-23 Thread zhilizhao
> On Jul 17, 2020, at 5:47 AM, Steinar H. Gunderson > wrote: > > On Thu, Jul 16, 2020 at 06:34:31PM -0300, James Almer wrote: >>> static AVMutex codec_mutex = AV_MUTEX_INITIALIZER; >>> +static const uint8_t usa_country_code = 0xB5; >>> +static const uint16_t smpte_provider_code = 0x003C; >>>

Re: [FFmpeg-devel] [PATCH] Support HDR10+ metadata for HEVC

2020-07-22 Thread Mohammad Izadi
Please see my answers inline: On Thu, Jul 16, 2020 at 1:30 PM Carl Eugen Hoyos wrote: > Am Do., 16. Juli 2020 um 21:24 Uhr schrieb Mohammad Izadi > : > > > -user_identifier = get_bits_long(gb, 32); > > - > > -switch (user_identifier) { > > -case MKBETAG('G', 'A', '9', '4'): > >

Re: [FFmpeg-devel] [PATCH] Support HDR10+ metadata for HEVC

2020-07-16 Thread Steinar H. Gunderson
On Thu, Jul 16, 2020 at 06:34:31PM -0300, James Almer wrote: >> static AVMutex codec_mutex = AV_MUTEX_INITIALIZER; >> +static const uint8_t usa_country_code = 0xB5; >> +static const uint16_t smpte_provider_code = 0x003C; >> +static const uint16_t smpte2094_40_provider_oriented_code = 0x0001; >>

Re: [FFmpeg-devel] [PATCH] Support HDR10+ metadata for HEVC

2020-07-16 Thread James Almer
On 7/16/2020 4:29 PM, Carl Eugen Hoyos wrote: > Am Do., 16. Juli 2020 um 21:24 Uhr schrieb Mohammad Izadi > : > >> -user_identifier = get_bits_long(gb, 32); >> - >> -switch (user_identifier) { >> -case MKBETAG('G', 'A', '9', '4'): > > Why did you have to change this existing

Re: [FFmpeg-devel] [PATCH] Support HDR10+ metadata for HEVC

2020-07-16 Thread James Almer
On 7/16/2020 4:23 PM, Mohammad Izadi wrote: > From: Mohammad Izadi > > --- > libavcodec/avpacket.c | 1 + > libavcodec/decode.c | 1 + > libavcodec/hevc_sei.c | 40 +++--- > libavcodec/hevc_sei.h | 5 ++ > libavcodec/hevcdec.c | 7 ++ > libavcodec/internal.h | 9 +++ >

Re: [FFmpeg-devel] [PATCH] Support HDR10+ metadata for HEVC

2020-07-16 Thread Carl Eugen Hoyos
Am Do., 16. Juli 2020 um 21:24 Uhr schrieb Mohammad Izadi : > -user_identifier = get_bits_long(gb, 32); > - > -switch (user_identifier) { > -case MKBETAG('G', 'A', '9', '4'): Why did you have to change this existing code? Could you elaborate a little on the use-cases this patch

[FFmpeg-devel] [PATCH] Support HDR10+ metadata for HEVC

2020-07-16 Thread Mohammad Izadi
From: Mohammad Izadi --- libavcodec/avpacket.c | 1 + libavcodec/decode.c | 1 + libavcodec/hevc_sei.c | 40 +++--- libavcodec/hevc_sei.h | 5 ++ libavcodec/hevcdec.c | 7 ++ libavcodec/internal.h | 9 +++ libavcodec/packet.h | 9 +++ libavcodec/utils.c| 180