New patch implements the other half of James suggestion (stop parsing
headers after data) and does not include the AVERROR_INVALIDDATA returns.
http://ffmpeg.org/pipermail/ffmpeg-devel/2019-June/245502.html
On Sun, Jun 16, 2019 at 6:16 AM Reimar Döffinger
wrote:
> On 14.06.2019, at 17:01, James
On 14.06.2019, at 17:01, James Almer wrote:
> On 6/14/2019 11:52 AM, Reimar Döffinger wrote:
>>
>>
>> On 14.06.2019, at 03:15, Chris Cunningham wrote:
>>
>>> Only "succeed" to read a header if the codec is valid. Otherwise
>>> return AVERROR_INVALIDDATA.
>>
>> That doesn't sound right to
On 6/14/2019 11:52 AM, Reimar Döffinger wrote:
>
>
> On 14.06.2019, at 03:15, Chris Cunningham wrote:
>
>> Only "succeed" to read a header if the codec is valid. Otherwise
>> return AVERROR_INVALIDDATA.
>
> That doesn't sound right to me, an unknown codec in (possibly) a single
> stream is
On 14.06.2019, at 03:15, Chris Cunningham wrote:
> Only "succeed" to read a header if the codec is valid. Otherwise
> return AVERROR_INVALIDDATA.
That doesn't sound right to me, an unknown codec in (possibly) a single stream
is not an error.
I understood the discussion more to say the if
+James
This is patch is a follow up from an earlier thread:
https://patchwork.ffmpeg.org/patch/11983/
I've implemented the easy part of that proposal. We also discussed
disallowing multiple headers in an ogm change (generally a revert of:
Only "succeed" to read a header if the codec is valid. Otherwise
return AVERROR_INVALIDDATA.
---
libavformat/oggparseogm.c | 12 ++--
1 file changed, 10 insertions(+), 2 deletions(-)
diff --git a/libavformat/oggparseogm.c b/libavformat/oggparseogm.c
index a07453760b..e71298d39a 100644
