Re: [FFmpeg-devel] [PATCH] avformat/rtpproto: add support for RTP/UDP socket reuse

2023-01-05 Thread Nicolas George
Camille Oudot (12023-01-04): > So does it still makes sense to have a patch to pass through a RTP > "reuseaddr" option to the underlying UDP URL "reuse" option? Yes, totally. But let us make it the right way: not just add this option and forward code, but correctly set up the objects so that all

Re: [FFmpeg-devel] [PATCH] avformat/rtpproto: add support for RTP/UDP socket reuse

2023-01-04 Thread Camille Oudot
> Because it is an useful option. Only not for this use case. > Because nobody noticed it was badly named when it was applied. > > > Why would it not apply to "rtp" also? > > Because nobody made the UDP socket context a child object of the RTP > context. So does it still makes sense to have a

Re: [FFmpeg-devel] [PATCH] avformat/rtpproto: add support for RTP/UDP socket reuse

2023-01-03 Thread Nicolas George
Camille Oudot (12023-01-03): > Why does the "reuse" option exists on the "udp" protocol in the first > place? Because it is an useful option. Only not for this use case. Because nobody noticed it was badly named when it was applied. > Why would it not apply to "rtp" also? Because nobody made

Re: [FFmpeg-devel] [PATCH] avformat/rtpproto: add support for RTP/UDP socket reuse

2023-01-03 Thread Camille Oudot
Why does the "reuse" option exists on the "udp" protocol in the first place? Why would it not apply to "rtp" also? Here is the original patch proposal on udp: http://ffmpeg.org/pipermail/ffmpeg-devel/2006-October/thread.html#18946 > Sure. But then that does not solve the problem of RTCP mux and

Re: [FFmpeg-devel] [PATCH] avformat/rtpproto: add support for RTP/UDP socket reuse

2023-01-03 Thread Rémi Denis-Courmont
Le tiistaina 3. tammikuuta 2023, 11.03.30 EET Camille Oudot a écrit : > Hi, I'm back on the topic. Thanks to all of you for your comments. > > > So I agree that SO_REUSEADDR is "absolutely not a hack"... if you use > > it to recycle IP/port pair without waiting for the time-out. But > > that's

Re: [FFmpeg-devel] [PATCH] avformat/rtpproto: add support for RTP/UDP socket reuse

2023-01-03 Thread Camille Oudot
Hi, I'm back on the topic. Thanks to all of you for your comments. > So I agree that SO_REUSEADDR is "absolutely not a hack"... if you use > it to recycle IP/port pair without waiting for the time-out. But > that's mainly of interest of listening/receiving sockets. That is indeed the case for

Re: [FFmpeg-devel] [PATCH] avformat/rtpproto: add support for RTP/UDP socket reuse

2022-12-31 Thread Rémi Denis-Courmont
Le maanantaina 26. joulukuuta 2022, 23.47.17 EET Nicolas George a écrit : > "zhilizhao(赵志立)" (12022-12-26): > > Just use the same socket file descriptor. Don’t use OS dependent hack to > > implement a feature. > > SO_REUSEADDR is absolutely not a hack. So I agree that SO_REUSEADDR is "absolutely

Re: [FFmpeg-devel] [PATCH] avformat/rtpproto: add support for RTP/UDP socket reuse

2022-12-26 Thread zhilizhao(赵志立)
> On Dec 27, 2022, at 05:47, Nicolas George wrote: > > "zhilizhao(赵志立)" (12022-12-26): >> Just use the same socket file descriptor. Don’t use OS dependent hack to >> implement a feature. > > SO_REUSEADDR is absolutely not a hack. I agree that it is not the > correct way of implementing the

Re: [FFmpeg-devel] [PATCH] avformat/rtpproto: add support for RTP/UDP socket reuse

2022-12-26 Thread Nicolas George
"zhilizhao(赵志立)" (12022-12-26): > Just use the same socket file descriptor. Don’t use OS dependent hack to > implement a feature. SO_REUSEADDR is absolutely not a hack. I agree that it is not the correct way of implementing the feature evoked in this thread, but I insist it is not a hack. --

Re: [FFmpeg-devel] [PATCH] avformat/rtpproto: add support for RTP/UDP socket reuse

2022-12-25 Thread zhilizhao(赵志立)
> On Dec 26, 2022, at 07:52, Camille Oudot > wrote: > > On Sun, 2022-12-25 at 11:00 +0100, Rémi Denis-Courmont wrote: > > >> Again, there is also REUSEPORT, which is what you'd want on Linux in >> this case, but behaves differently on BSD and doesn't exist at all on >> Windows (IIRC). > >

Re: [FFmpeg-devel] [PATCH] avformat/rtpproto: add support for RTP/UDP socket reuse

2022-12-25 Thread Camille Oudot
On Sun, 2022-12-25 at 11:00 +0100, Rémi Denis-Courmont wrote: > Again, there is also REUSEPORT, which is what you'd want on Linux in > this case, but behaves differently on BSD and doesn't exist at all on > Windows (IIRC). That option is indeed preferable for security. It works equally good for

Re: [FFmpeg-devel] [PATCH] avformat/rtpproto: add support for RTP/UDP socket reuse

2022-12-25 Thread Rémi Denis-Courmont
Le 24 décembre 2022 14:07:26 GMT+01:00, Camille Oudot a écrit : >Hello, > >On Sat, 2022-12-24 at 13:36 +0200, Rémi Denis-Courmont wrote: >> I don't see why you need an option for this. In parsing the SDP, it >> should be self-evident if a given socket needs to be reused for RTCP- >> mux or for

Re: [FFmpeg-devel] [PATCH] avformat/rtpproto: add support for RTP/UDP socket reuse

2022-12-24 Thread Camille Oudot
Hello, On Sat, 2022-12-24 at 13:36 +0200, Rémi Denis-Courmont wrote: > I don't see why you need an option for this. In parsing the SDP, it > should be self-evident if a given socket needs to be reused for RTCP- > mux or for SDP BUNDLE. I indeed disregarded the "receiving RTP streams" part, my

Re: [FFmpeg-devel] [PATCH] avformat/rtpproto: add support for RTP/UDP socket reuse

2022-12-24 Thread Rémi Denis-Courmont
Hello, Le jeudi 22 décembre 2022, 17:42:09 EET Camille Oudot a écrit : > Re-submitting because google webmail did not set the correct mime type, > sorry for the noise. I don't see why you need an option for this. In parsing the SDP, it should be self-evident if a given socket needs to

Re: [FFmpeg-devel] [PATCH] avformat/rtpproto: add support for RTP/UDP socket reuse

2022-12-22 Thread Nicolas George
Camille Oudot (12022-12-22): > This patch introduces a "reuse" option over the RTP protocol. It simply > passes the value to the underlying UDP protocol's "reuse" option. > > Some RTP peers expect multiple streams to come from the same IP/port, e.g. > when RTP BUNDLE is involved (different

Re: [FFmpeg-devel] [PATCH] avformat/rtpproto: add support for RTP/UDP socket reuse

2022-12-22 Thread Camille Oudot
Re-submitting because google webmail did not set the correct mime type, sorry for the noise. -- Camille From 998e1d3d79b416422e2b1d4f9a5ffb92062db256 Mon Sep 17 00:00:00 2001 From: Camille Oudot Date: Fri, 16 Dec 2022 15:30:02 +0100 Subject: [PATCH] avformat/rtpproto: add support for RTP/UDP

[FFmpeg-devel] [PATCH] avformat/rtpproto: add support for RTP/UDP socket reuse

2022-12-22 Thread Camille Oudot
From 998e1d3d79b416422e2b1d4f9a5ffb92062db256 Mon Sep 17 00:00:00 2001 From: Camille Oudot Date: Fri, 16 Dec 2022 15:30:02 +0100 Subject: [PATCH] avformat/rtpproto: add support for RTP/UDP socket reuse This patch introduces a "reuse" option over the RTP protocol. It simply passes the value to