Re: [FFmpeg-devel] [PATCH] configure: improve logic and checks for nvenc

2016-08-31 Thread James Almer
On 8/31/2016 5:26 AM, Timo Rothenpieler wrote: >>> +echo 'NV_ENCODE_API_FUNCTION_LIST flist;' >>> +echo 'void f(void) { struct { const GUID guid; } s[] = { { >>> NV_ENC_PRESET_HQ_GUID } }; }' >> >> This will most likely prevent nvenc from being enabled for msvc 2012, but >> not

Re: [FFmpeg-devel] [PATCH] configure: improve logic and checks for nvenc

2016-08-31 Thread Timo Rothenpieler
> 2016-08-31 15:26 GMT+02:00 Timo Rothenpieler : >>> 2016-08-31 15:03 GMT+02:00 Timo Rothenpieler : Forgot this, the idea with my approach is to handle the case where --enable-nvenc is requested, but the compile-check fails. >>> Just

Re: [FFmpeg-devel] [PATCH] configure: improve logic and checks for nvenc

2016-08-31 Thread Carl Eugen Hoyos
2016-08-31 15:26 GMT+02:00 Timo Rothenpieler : >> 2016-08-31 15:03 GMT+02:00 Timo Rothenpieler : >>> Forgot this, the idea with my approach is to handle the case where >>> --enable-nvenc is requested, but the compile-check fails. >> >>> Just silently

Re: [FFmpeg-devel] [PATCH] configure: improve logic and checks for nvenc

2016-08-31 Thread Timo Rothenpieler
> 2016-08-31 15:03 GMT+02:00 Timo Rothenpieler : >> Forgot this, the idea with my approach is to handle the case where >> --enable-nvenc is requested, but the compile-check fails. > >> Just silently disabling it then seems wrong. > > But this is what we do for all

Re: [FFmpeg-devel] [PATCH] configure: improve logic and checks for nvenc

2016-08-31 Thread Carl Eugen Hoyos
2016-08-31 15:03 GMT+02:00 Timo Rothenpieler : > Forgot this, the idea with my approach is to handle the case where > --enable-nvenc is requested, but the compile-check fails. > Just silently disabling it then seems wrong. But this is what we do for all auto-detected

Re: [FFmpeg-devel] [PATCH] configure: improve logic and checks for nvenc

2016-08-31 Thread Timo Rothenpieler
Forgot this, the idea with my approach is to handle the case where --enable-nvenc is requested, but the compile-check fails. Just silently disabling it then seems wrong. ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org

Re: [FFmpeg-devel] [PATCH] configure: improve logic and checks for nvenc

2016-08-31 Thread Timo Rothenpieler
>> +echo 'NV_ENCODE_API_FUNCTION_LIST flist;' >> +echo 'void f(void) { struct { const GUID guid; } s[] = { { >> NV_ENC_PRESET_HQ_GUID } }; }' > > This will most likely prevent nvenc from being enabled for msvc 2012, but not > old > mingw32, which is failing with the error: > >

Re: [FFmpeg-devel] [PATCH] configure: improve logic and checks for nvenc

2016-08-30 Thread James Almer
On 8/30/2016 8:00 AM, Timo Rothenpieler wrote: > --- > configure | 37 + > 1 file changed, 25 insertions(+), 12 deletions(-) > > diff --git a/configure b/configure > index 52931c3..bcfc9a8 100755 > --- a/configure > +++ b/configure > @@ -5992,20 +5992,33 @@

[FFmpeg-devel] [PATCH] configure: improve logic and checks for nvenc

2016-08-30 Thread Timo Rothenpieler
--- configure | 37 + 1 file changed, 25 insertions(+), 12 deletions(-) diff --git a/configure b/configure index 52931c3..bcfc9a8 100755 --- a/configure +++ b/configure @@ -5992,20 +5992,33 @@ enabled vdpau && enabled xlib && check_lib2 "vdpau/vdpau.h