Re: [FFmpeg-devel] [PATCH] libaformat: fix incorrect handling of incomplete AVBPrint.

2023-07-29 Thread Reimar Döffinger
> On 27 Jul 2023, at 19:44, Nicolas George wrote: > > Reimar Döffinger (12023-07-27): >> Thanks, sent a new version with that updated, plus a fix for a typo >> in the commit message. > > If it is all you have changed, then I do not think I need to look at it > again. > > I do not maintain

Re: [FFmpeg-devel] [PATCH] libaformat: fix incorrect handling of incomplete AVBPrint.

2023-07-27 Thread Nicolas George
Reimar Döffinger (12023-07-27): > Thanks, sent a new version with that updated, plus a fix for a typo > in the commit message. If it is all you have changed, then I do not think I need to look at it again. I do not maintain most of the files you have changed, but I think you can go ahead.

Re: [FFmpeg-devel] [PATCH] libaformat: fix incorrect handling of incomplete AVBPrint.

2023-07-27 Thread Reimar Döffinger
> On 27 Jul 2023, at 19:33, Nicolas George wrote: > > reimar.doeffin...@gmx.de (12023-07-23): >> From: Reimar Döffinger >> >> Change some internal APIs a bit to make it harder to make >> such mistakes. >> In particular, have the read chunk functions return an error >> when the result is

Re: [FFmpeg-devel] [PATCH] libaformat: fix incorrect handling of incomplete AVBPrint.

2023-07-27 Thread Nicolas George
reimar.doeffin...@gmx.de (12023-07-23): > From: Reimar Döffinger > > Change some internal APIs a bit to make it harder to make > such mistakes. > In particular, have the read chunk functions return an error > when the result is incomplete. > This might be less flexible, but since there has been

Re: [FFmpeg-devel] [PATCH] libaformat: fix incorrect handling of incomplete AVBPrint.

2023-07-27 Thread Reimar Döffinger
> On 23 Jul 2023, at 14:00, reimar.doeffin...@gmx.de wrote: > > From: Reimar Döffinger > > Change some internal APIs a bit to make it harder to make > such mistakes. > In particular, have the read chunk functions return an error > when the result is incomplete. > This might be less flexible,

[FFmpeg-devel] [PATCH] libaformat: fix incorrect handling of incomplete AVBPrint.

2023-07-23 Thread Reimar . Doeffinger
From: Reimar Döffinger Change some internal APIs a bit to make it harder to make such mistakes. In particular, have the read chunk functions return an error when the result is incomplete. This might be less flexible, but since there has been no use-case for that so far, avoiding coding mistakes

Re: [FFmpeg-devel] [PATCH] libaformat: fix incorrect handling of incomplete AVBPrint.

2023-06-22 Thread James Almer
On 6/22/2023 6:04 PM, reimar.doeffin...@gmx.de wrote: diff --git a/libavformat/realtextdec.c b/libavformat/realtextdec.c index c281dec346..9f6aab789e 100644 --- a/libavformat/realtextdec.c +++ b/libavformat/realtextdec.c @@ -80,6 +80,11 @@ static int realtext_read_header(AVFormatContext *s)

[FFmpeg-devel] [PATCH] libaformat: fix incorrect handling of incomplete AVBPrint.

2023-06-22 Thread Reimar . Doeffinger
From: Reimar Döffinger Change some internal APIs a bit to make it harder to make such mistakes. In particular, have the read chunk functions return an error when the result is incomplete. This might be less flexible, but since there has been no use-case for that so far, avoiding coding mistakes