Re: [FFmpeg-devel] [PATCH] mov: Remove ancient heuristic hack

On 8/25/16, Michael Niedermayer wrote: > On Thu, Aug 25, 2016 at 05:46:57PM +0100, Derek Buitenhuis wrote: >> On 8/25/2016 5:34 PM, James Almer wrote: >> > On 8/25/2016 12:45 PM, Carl Eugen Hoyos wrote: >> >> 2016-08-24 16:55 GMT+02:00 Derek Buitenhuis >> >>

Re: [FFmpeg-devel] [PATCH] mov: Remove ancient heuristic hack

On Thu, Aug 25, 2016 at 05:46:57PM +0100, Derek Buitenhuis wrote: > On 8/25/2016 5:34 PM, James Almer wrote: > > On 8/25/2016 12:45 PM, Carl Eugen Hoyos wrote: > >> 2016-08-24 16:55 GMT+02:00 Derek Buitenhuis : > >>> This breaks files with legitimate single-entry edit

Re: [FFmpeg-devel] [PATCH] mov: Remove ancient heuristic hack

On 8/25/2016 1:46 PM, Derek Buitenhuis wrote: > On 8/25/2016 5:34 PM, James Almer wrote: >> On 8/25/2016 12:45 PM, Carl Eugen Hoyos wrote: >>> 2016-08-24 16:55 GMT+02:00 Derek Buitenhuis : This breaks files with legitimate single-entry edit lists, >>> and the

Re: [FFmpeg-devel] [PATCH] mov: Remove ancient heuristic hack

On 8/25/2016 5:34 PM, James Almer wrote: > On 8/25/2016 12:45 PM, Carl Eugen Hoyos wrote: >> 2016-08-24 16:55 GMT+02:00 Derek Buitenhuis : >>> This breaks files with legitimate single-entry edit lists, >> >>> and the hack, introduced in

Re: [FFmpeg-devel] [PATCH] mov: Remove ancient heuristic hack

On 8/25/2016 12:45 PM, Carl Eugen Hoyos wrote: > 2016-08-24 16:55 GMT+02:00 Derek Buitenhuis : >> This breaks files with legitimate single-entry edit lists, > >> and the hack, introduced in f03a081df09f9c4798a17d7e24446ed47924b11b, > > I believe "Hack" is not

Re: [FFmpeg-devel] [PATCH] mov: Remove ancient heuristic hack

On 8/25/2016 4:52 PM, Michael Niedermayer wrote: >> the patch removes all uses of wrong_dts, the field should be >> > removed too > oops i forgot cc-ing you, iam not used to reply-all on the ML OK. I thought it was used in the FLV demuxer too, but it seems it has it's own copy inside the FLV

Re: [FFmpeg-devel] [PATCH] mov: Remove ancient heuristic hack

On Thu, Aug 25, 2016 at 05:45:03PM +0200, Michael Niedermayer wrote: > On Thu, Aug 25, 2016 at 03:49:22PM +0100, Derek Buitenhuis wrote: > > On 8/25/2016 3:40 PM, Michael Niedermayer wrote: > > > but its probably best to remove in a seperate patch so if it breaks > > > something bisect would

Re: [FFmpeg-devel] [PATCH] mov: Remove ancient heuristic hack

On Thu, Aug 25, 2016 at 03:49:22PM +0100, Derek Buitenhuis wrote: > On 8/25/2016 3:40 PM, Michael Niedermayer wrote: > > but its probably best to remove in a seperate patch so if it breaks > > something bisect would immedeatly point to which of the 2 changes > > caused it > > Sounds good. > > If

Re: [FFmpeg-devel] [PATCH] mov: Remove ancient heuristic hack

2016-08-24 16:55 GMT+02:00 Derek Buitenhuis : > This breaks files with legitimate single-entry edit lists, > and the hack, introduced in f03a081df09f9c4798a17d7e24446ed47924b11b, I believe "Hack" is not acceptable on this mailing list anymore, please remove it from

Re: [FFmpeg-devel] [PATCH] mov: Remove ancient heuristic hack

On 8/25/2016 3:40 PM, Michael Niedermayer wrote: > but its probably best to remove in a seperate patch so if it breaks > something bisect would immedeatly point to which of the 2 changes > caused it Sounds good. If you think this patch is OK, please push it with this part of the commit message

Re: [FFmpeg-devel] [PATCH] mov: Remove ancient heuristic hack

On Thu, Aug 25, 2016 at 03:25:56PM +0100, Derek Buitenhuis wrote: > On 8/24/2016 10:54 PM, Michael Niedermayer wrote: > > IIRC the removed code tried to detect a reorder delay that is not > > possible in a valid file due to the profile constraints. Aka dts and > > pts are too far appart for the

Re: [FFmpeg-devel] [PATCH] mov: Remove ancient heuristic hack

On 8/24/2016 10:54 PM, Michael Niedermayer wrote: > IIRC the removed code tried to detect a reorder delay that is not > possible in a valid file due to the profile constraints. Aka dts and > pts are too far appart for the largest amount of buffers allowed in > any codec. Basing this on timestamps

Re: [FFmpeg-devel] [PATCH] mov: Remove ancient heuristic hack

On Wed, Aug 24, 2016 at 03:55:24PM +0100, Derek Buitenhuis wrote: > This breaks files with legitimate single-entry edit lists, > and the hack, introduced in f03a081df09f9c4798a17d7e24446ed47924b11b, > has no link to any known sample in its commit message, nor > does it actually fix the problem

Re: [FFmpeg-devel] [PATCH] mov: Remove ancient heuristic hack

On 8/24/2016 7:00 PM, Carl Eugen Hoyos wrote: > Does this patch also fix the issue? > http://ffmpeg.org/pipermail/ffmpeg-devel/2016-August/197817.html It doesn't. The patch I sent fixes a problem with a current workaround in the mov demuxer. Edit lists are just one way it could have triggered it.

Re: [FFmpeg-devel] [PATCH] mov: Remove ancient heuristic hack

On 8/24/2016 6:50 PM, Carl Eugen Hoyos wrote: >> This breaks files with legitimate single-entry edit lists, >> and the hack, introduced in f03a081df09f9c4798a17d7e24446ed47924b11b, >> has no link to any known sample in its commit message, nor > > I suspect the commit message links to this sample:

Re: [FFmpeg-devel] [PATCH] mov: Remove ancient heuristic hack

2016-08-24 16:55 GMT+02:00 Derek Buitenhuis : > I am sending this patch in a professional context, as it is > a problem I have run into at work, with legitimate files, > produced by x264 and L-SMASH. Does this patch also fix the issue?

Re: [FFmpeg-devel] [PATCH] mov: Remove ancient heuristic hack

Hi Derek! 2016-08-24 16:55 GMT+02:00 Derek Buitenhuis : > This breaks files with legitimate single-entry edit lists, > and the hack, introduced in f03a081df09f9c4798a17d7e24446ed47924b11b, > has no link to any known sample in its commit message, nor I suspect the

[FFmpeg-devel] [PATCH] mov: Remove ancient heuristic hack

This breaks files with legitimate single-entry edit lists, and the hack, introduced in f03a081df09f9c4798a17d7e24446ed47924b11b, has no link to any known sample in its commit message, nor does it actually fix the problem properly, but instead has a one-off heuristic to try and "fix" them at the