On 4/20/2018 9:39 PM, Gyan Doshi wrote:
It's very much possible I'm missing something but I don't see what.
Yup. I see that the decoder sets the frame flags correctly. The ticket
sample file is wrongly muxed, and so the inversion is wrong.
Will send patch tomorrow unless someone gets to i
On 4/20/2018 1:09 PM, Paul B Mahol wrote:
> On 4/20/18, James Almer wrote:
>> On 4/20/2018 12:34 PM, Gyan Doshi wrote:
>>>
>>>
>>> On 4/20/2018 8:35 PM, James Almer wrote:
>>>
>>>
I don't understand the reasoning to invert the logic here. The current
behavior is clearly not right. We're
On 4/20/2018 9:22 PM, James Almer wrote:
Wouldn't this hint that the file in question is broken?
I don't follow. If the inversion was a mistake, then frames currently
not marked by demuxer are in fact keyframes and a stream decoded from
that frame onwards should show correct output. I see
On 4/20/18, James Almer wrote:
> On 4/20/2018 12:34 PM, Gyan Doshi wrote:
>>
>>
>> On 4/20/2018 8:35 PM, James Almer wrote:
>>
>>
>>> I don't understand the reasoning to invert the logic here. The current
>>> behavior is clearly not right. We're marking Inter coded frames as key
>>> frames and Int
On 4/20/2018 12:34 PM, Gyan Doshi wrote:
>
>
> On 4/20/2018 8:35 PM, James Almer wrote:
>
>
>> I don't understand the reasoning to invert the logic here. The current
>> behavior is clearly not right. We're marking Inter coded frames as key
>> frames and Intra coded frames as non keyframes.
>
>
On 4/20/2018 8:35 PM, James Almer wrote:
I don't understand the reasoning to invert the logic here. The current
behavior is clearly not right. We're marking Inter coded frames as key
frames and Intra coded frames as non keyframes.
This behaviour was how it was originally. See the sample att
On 4/20/2018 2:39 AM, Misty De Meo wrote:
> On Thu, Apr 19, 2018 at 8:31 PM, James Almer wrote:
>>
>>> +film->sample_table[i].duration = AV_RB32(&scratch[12]);
>>
>> While for video tracks this field seems to report the same packet
>> durations that were being calculated pre patch, this fi
On Thu, Apr 19, 2018 at 8:31 PM, James Almer wrote:
>
> > +film->sample_table[i].duration = AV_RB32(&scratch[12]);
>
> While for video tracks this field seems to report the same packet
> durations that were being calculated pre patch, this field for audio
> tracks is always 1.
>
> Before t
On 4/18/2018 4:29 PM, mi...@brew.sh wrote:
> From: Misty De Meo
>
> ---
> libavformat/segafilm.c | 20 +++-
> 1 file changed, 3 insertions(+), 17 deletions(-)
>
> diff --git a/libavformat/segafilm.c b/libavformat/segafilm.c
> index e72c26b144..1529fc385e 100644
> --- a/libavform
From: Misty De Meo
---
libavformat/segafilm.c | 20 +++-
1 file changed, 3 insertions(+), 17 deletions(-)
diff --git a/libavformat/segafilm.c b/libavformat/segafilm.c
index e72c26b144..1529fc385e 100644
--- a/libavformat/segafilm.c
+++ b/libavformat/segafilm.c
@@ -43,6 +43,7 @@
10 matches
Mail list logo
