Re: [FFmpeg-devel] [PATCH 1/2] avcodec/snowdec: Check intra block dc differences.

2017-11-17 Thread Carl Eugen Hoyos
2017-11-17 1:47 GMT+01:00 Ronald S. Bultje : > stop being difficult. Yes please! I have no idea what's driving you but please stop this childish attitude: You haven't answered to a bug report since an eternity, so you simply cannot claim that error messages are unneeded.

Re: [FFmpeg-devel] [PATCH 1/2] avcodec/snowdec: Check intra block dc differences.

2017-11-17 Thread Michael Niedermayer
On Fri, Nov 17, 2017 at 10:28:49AM -0500, Ronald S. Bultje wrote: > Hi, > > On Fri, Nov 17, 2017 at 10:14 AM, Michael Niedermayer < > mich...@niedermayer.cc> wrote: > > > As a maintainer If a file fails with an error i want to know > > what error it is. Why is this so hard or controversal ? > >

Re: [FFmpeg-devel] [PATCH 1/2] avcodec/snowdec: Check intra block dc differences.

2017-11-17 Thread Nicolas George
Le septidi 27 brumaire, an CCXXVI, Ronald S. Bultje a écrit : > Because *it doesn't happen* for real files. Then why do you want it gone? Regards, -- Nicolas George signature.asc Description: Digital signature ___ ffmpeg-devel mailing list

Re: [FFmpeg-devel] [PATCH 1/2] avcodec/snowdec: Check intra block dc differences.

2017-11-17 Thread Ronald S. Bultje
Hi, On Fri, Nov 17, 2017 at 10:14 AM, Michael Niedermayer < mich...@niedermayer.cc> wrote: > As a maintainer If a file fails with an error i want to know > what error it is. Why is this so hard or controversal ? Because *it doesn't happen* for real files. But you don't want to listen. You

Re: [FFmpeg-devel] [PATCH 1/2] avcodec/snowdec: Check intra block dc differences.

2017-11-17 Thread Michael Niedermayer
On Thu, Nov 16, 2017 at 11:13:27PM -0300, James Almer wrote: > On 11/16/2017 10:43 PM, Michael Niedermayer wrote: > > On Thu, Nov 16, 2017 at 07:47:55PM -0500, Ronald S. Bultje wrote: > >> Hi, > >> > >> On Thu, Nov 16, 2017 at 4:41 PM, Michael Niedermayer > >> >>> wrote:

Re: [FFmpeg-devel] [PATCH 1/2] avcodec/snowdec: Check intra block dc differences.

2017-11-16 Thread James Almer
On 11/16/2017 10:43 PM, Michael Niedermayer wrote: > On Thu, Nov 16, 2017 at 07:47:55PM -0500, Ronald S. Bultje wrote: >> Hi, >> >> On Thu, Nov 16, 2017 at 4:41 PM, Michael Niedermayer >> wrote: >> >>> On Thu, Nov 16, 2017 at 01:21:19PM -0500, Ronald S. Bultje wrote:

Re: [FFmpeg-devel] [PATCH 1/2] avcodec/snowdec: Check intra block dc differences.

2017-11-16 Thread Michael Niedermayer
On Thu, Nov 16, 2017 at 07:47:55PM -0500, Ronald S. Bultje wrote: > Hi, > > On Thu, Nov 16, 2017 at 4:41 PM, Michael Niedermayer > wrote: > > > On Thu, Nov 16, 2017 at 01:21:19PM -0500, Ronald S. Bultje wrote: > > > Hi, > > > > > > On Thu, Nov 16, 2017 at 11:50 AM,

Re: [FFmpeg-devel] [PATCH 1/2] avcodec/snowdec: Check intra block dc differences.

2017-11-16 Thread Ronald S. Bultje
Hi, On Thu, Nov 16, 2017 at 4:41 PM, Michael Niedermayer wrote: > On Thu, Nov 16, 2017 at 01:21:19PM -0500, Ronald S. Bultje wrote: > > Hi, > > > > On Thu, Nov 16, 2017 at 11:50 AM, Michael Niedermayer < > > mich...@niedermayer.cc> wrote: > > > > > On Thu, Nov 16, 2017

Re: [FFmpeg-devel] [PATCH 1/2] avcodec/snowdec: Check intra block dc differences.

2017-11-16 Thread Kieran Kunhya
On Thu, 16 Nov 2017 at 18:21 Ronald S. Bultje wrote: > We are re-hashing old arguments here. I'm not really interested in that. > > My review comment is and remains: please remove the log msg. Otherwise, the > patch is perfectly fine. > I agree with Ronald's argument. I

Re: [FFmpeg-devel] [PATCH 1/2] avcodec/snowdec: Check intra block dc differences.

2017-11-16 Thread Michael Niedermayer
On Thu, Nov 16, 2017 at 01:21:19PM -0500, Ronald S. Bultje wrote: > Hi, > > On Thu, Nov 16, 2017 at 11:50 AM, Michael Niedermayer < > mich...@niedermayer.cc> wrote: > > > On Thu, Nov 16, 2017 at 06:26:06AM -0500, Ronald S. Bultje wrote: > > > Hi, > > > > > > On Wed, Nov 15, 2017 at 10:15 PM,

Re: [FFmpeg-devel] [PATCH 1/2] avcodec/snowdec: Check intra block dc differences.

2017-11-16 Thread Ronald S. Bultje
Hi, On Thu, Nov 16, 2017 at 11:50 AM, Michael Niedermayer < mich...@niedermayer.cc> wrote: > On Thu, Nov 16, 2017 at 06:26:06AM -0500, Ronald S. Bultje wrote: > > Hi, > > > > On Wed, Nov 15, 2017 at 10:15 PM, Carl Eugen Hoyos > > wrote: > > > > > 2017-11-16 4:06 GMT+01:00

Re: [FFmpeg-devel] [PATCH 1/2] avcodec/snowdec: Check intra block dc differences.

2017-11-16 Thread Michael Niedermayer
On Thu, Nov 16, 2017 at 06:26:06AM -0500, Ronald S. Bultje wrote: > Hi, > > On Wed, Nov 15, 2017 at 10:15 PM, Carl Eugen Hoyos > wrote: > > > 2017-11-16 4:06 GMT+01:00 Ronald S. Bultje : > > > > > So, commit it without the error message? I really don't

Re: [FFmpeg-devel] [PATCH 1/2] avcodec/snowdec: Check intra block dc differences.

2017-11-16 Thread Ronald S. Bultje
Hi, On Wed, Nov 15, 2017 at 10:15 PM, Carl Eugen Hoyos wrote: > 2017-11-16 4:06 GMT+01:00 Ronald S. Bultje : > > > So, commit it without the error message? I really don't see the issue. > > As explained, the issue is that without an error message, it > is

Re: [FFmpeg-devel] [PATCH 1/2] avcodec/snowdec: Check intra block dc differences.

2017-11-16 Thread Paul B Mahol
On 11/16/17, Carl Eugen Hoyos wrote: > 2017-11-16 4:06 GMT+01:00 Ronald S. Bultje : > >> So, commit it without the error message? I really don't see the issue. > > As explained, the issue is that without an error message, it > is impossible to parse any

Re: [FFmpeg-devel] [PATCH 1/2] avcodec/snowdec: Check intra block dc differences.

2017-11-15 Thread Carl Eugen Hoyos
2017-11-16 4:06 GMT+01:00 Ronald S. Bultje : > So, commit it without the error message? I really don't see the issue. As explained, the issue is that without an error message, it is impossible to parse any related bug report. Carl Eugen

Re: [FFmpeg-devel] [PATCH 1/2] avcodec/snowdec: Check intra block dc differences.

2017-11-15 Thread Ronald S. Bultje
Hi, On Wed, Nov 15, 2017 at 7:02 PM, Michael Niedermayer wrote: > On Wed, Nov 15, 2017 at 03:26:42PM -0500, Ronald S. Bultje wrote: > > Hi, > > > > On Wed, Nov 15, 2017 at 3:17 PM, Michael Niedermayer > > > wrote: > > > > > Fixes: Timeout > > >

Re: [FFmpeg-devel] [PATCH 1/2] avcodec/snowdec: Check intra block dc differences.

2017-11-15 Thread Michael Niedermayer
On Wed, Nov 15, 2017 at 03:26:42PM -0500, Ronald S. Bultje wrote: > Hi, > > On Wed, Nov 15, 2017 at 3:17 PM, Michael Niedermayer > wrote: > > > Fixes: Timeout > > Fixes: 3142/clusterfuzz-testcase-5007853163118592 > > > > Found-by: continuous fuzzing process

Re: [FFmpeg-devel] [PATCH 1/2] avcodec/snowdec: Check intra block dc differences.

2017-11-15 Thread Carl Eugen Hoyos
2017-11-15 21:26 GMT+01:00 Ronald S. Bultje : > Hi, > > On Wed, Nov 15, 2017 at 3:17 PM, Michael Niedermayer > wrote: > >> Fixes: Timeout >> Fixes: 3142/clusterfuzz-testcase-5007853163118592 >> >> Found-by: continuous fuzzing process

Re: [FFmpeg-devel] [PATCH 1/2] avcodec/snowdec: Check intra block dc differences.

2017-11-15 Thread Ronald S. Bultje
Hi, On Wed, Nov 15, 2017 at 3:17 PM, Michael Niedermayer wrote: > Fixes: Timeout > Fixes: 3142/clusterfuzz-testcase-5007853163118592 > > Found-by: continuous fuzzing process https://github.com/google/oss- > fuzz/tree/master/projects/ffmpeg > Signed-off-by: Michael

[FFmpeg-devel] [PATCH 1/2] avcodec/snowdec: Check intra block dc differences.

2017-11-15 Thread Michael Niedermayer
Fixes: Timeout Fixes: 3142/clusterfuzz-testcase-5007853163118592 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Niedermayer --- libavcodec/snowdec.c | 19 +++ 1 file changed, 15