>On 11/17/17, 4:31 PM, "Nicolas George" wrote:
>
>Le sextidi 26 brumaire, an CCXXVI, Jeyapal, Karthick a écrit :
>> I have done the change as suggested. Please find the new patch attached.
>
>Sorry, but I still have doubts about it.
>
>To begin with, -1 is not an acceptable
Le sextidi 26 brumaire, an CCXXVI, Jeyapal, Karthick a écrit :
> I have done the change as suggested. Please find the new patch attached.
Sorry, but I still have doubts about it.
To begin with, -1 is not an acceptable error code.
But what bothers me most is that on the two uses, one has an
>On 11/16/17, 4:43 PM, "Nicolas George" wrote:
Thanks for the reply.
>I think that would work, thanks.
>
>But I see that in the other patches you call ffio_geturlcontext()
>without checking its return value. That is not good at all, and that
>would make Coverity squirm.
>
>If
Le sextidi 26 brumaire, an CCXXVI, Jeyapal, Karthick a écrit :
> Thanks for the feedback. I have a relevant condition check so that
> only a real URLContext is returned.
> Please find the new patch attached.
I think that would work, thanks.
But I see that in the other patches you call
>On 11/15/17, 6:34 PM, "Nicolas George" wrote:
>This is rather fragile. Some kind of check that is is actually a real
>URLContext would be a very good idea.
Thanks for the feedback. I have a relevant condition check so that
only a real URLContext is returned.
Please find the
Le septidi 17 brumaire, an CCXXVI, Karthick J a écrit :
> ---
> libavformat/avio_internal.h | 8
> libavformat/aviobuf.c | 8
> 2 files changed, 16 insertions(+)
>
> diff --git a/libavformat/avio_internal.h b/libavformat/avio_internal.h
> index c01835d..04c1ad5 100644
>
>>On Tue, Nov 7, 2017 at 2:34 AM Karthick J wrote:
>>---
>> libavformat/avio_internal.h | 8
>> libavformat/aviobuf.c | 8
>> 2 files changed, 16 insertions(+)
>
>LGTM. This would make my hls demuxer keepalive patch simpler as well.
>
>I know there were
On Tue, Nov 7, 2017 at 2:34 AM Karthick J wrote:
> ---
> libavformat/avio_internal.h | 8
> libavformat/aviobuf.c | 8
> 2 files changed, 16 insertions(+)
>
> diff --git a/libavformat/avio_internal.h b/libavformat/avio_internal.h
> index
---
libavformat/avio_internal.h | 8
libavformat/aviobuf.c | 8
2 files changed, 16 insertions(+)
diff --git a/libavformat/avio_internal.h b/libavformat/avio_internal.h
index c01835d..04c1ad5 100644
--- a/libavformat/avio_internal.h
+++ b/libavformat/avio_internal.h
@@