[FFmpeg-devel] [PATCH 2/3] swscale/x86/yuv2yuvX: Add yuv2yuvX avx512

2023-07-17 Thread Alan Kelly
--- Checks for EXTERNAL_AVX512ICL to prevent downclocking on Skylake libswscale/x86/swscale.c| 7 +++ libswscale/x86/yuv2yuvX.asm | 19 ++- 2 files changed, 25 insertions(+), 1 deletion(-) diff --git a/libswscale/x86/swscale.c b/libswscale/x86/swscale.c index

Re: [FFmpeg-devel] [PATCH 2/3] swscale/x86/yuv2yuvX: Add yuv2yuvX avx512

2023-07-17 Thread Alan Kelly
Happy to add the check. Thanks, Alan On Fri, Jul 14, 2023 at 4:59 PM James Almer wrote: > On 7/14/2023 11:57 AM, Kieran Kunhya wrote: > > On Fri, 14 Jul 2023 at 14:03, James Almer wrote: > > > >> On 7/14/2023 9:59 AM, Kieran Kunhya wrote: > +#if ARCH_X86_64 && HAVE_AVX512_EXTERNAL >

Re: [FFmpeg-devel] [PATCH 2/3] swscale/x86/yuv2yuvX: Add yuv2yuvX avx512

2023-07-14 Thread James Almer
On 7/14/2023 11:57 AM, Kieran Kunhya wrote: On Fri, 14 Jul 2023 at 14:03, James Almer wrote: On 7/14/2023 9:59 AM, Kieran Kunhya wrote: +#if ARCH_X86_64 && HAVE_AVX512_EXTERNAL +if (EXTERNAL_AVX512(cpu_flags)) +c->yuv2planeX = yuv2yuvX_avx512; #endif You want

Re: [FFmpeg-devel] [PATCH 2/3] swscale/x86/yuv2yuvX: Add yuv2yuvX avx512

2023-07-14 Thread Kieran Kunhya
On Fri, 14 Jul 2023 at 14:03, James Almer wrote: > On 7/14/2023 9:59 AM, Kieran Kunhya wrote: > >> +#if ARCH_X86_64 && HAVE_AVX512_EXTERNAL > >> +if (EXTERNAL_AVX512(cpu_flags)) > >> +c->yuv2planeX = yuv2yuvX_avx512; > >> #endif > >> > > > > You want EXTERNAL_AVX512ICL

Re: [FFmpeg-devel] [PATCH 2/3] swscale/x86/yuv2yuvX: Add yuv2yuvX avx512

2023-07-14 Thread James Almer
On 7/14/2023 9:59 AM, Kieran Kunhya wrote: +#if ARCH_X86_64 && HAVE_AVX512_EXTERNAL +if (EXTERNAL_AVX512(cpu_flags)) +c->yuv2planeX = yuv2yuvX_avx512; #endif You want EXTERNAL_AVX512ICL here. vpermt2q with zmm registers is avx512f and not any of the extensions, so

Re: [FFmpeg-devel] [PATCH 2/3] swscale/x86/yuv2yuvX: Add yuv2yuvX avx512

2023-07-14 Thread Kieran Kunhya
> +#if ARCH_X86_64 && HAVE_AVX512_EXTERNAL > +if (EXTERNAL_AVX512(cpu_flags)) > +c->yuv2planeX = yuv2yuvX_avx512; > #endif > You want EXTERNAL_AVX512ICL here. Kieran ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org

[FFmpeg-devel] [PATCH 2/3] swscale/x86/yuv2yuvX: Add yuv2yuvX avx512

2023-07-14 Thread Alan Kelly
--- libswscale/x86/swscale.c| 7 +++ libswscale/x86/yuv2yuvX.asm | 19 ++- 2 files changed, 25 insertions(+), 1 deletion(-) diff --git a/libswscale/x86/swscale.c b/libswscale/x86/swscale.c index 8c67bf4fab..52423a1199 100644 --- a/libswscale/x86/swscale.c +++