Re: [FFmpeg-devel] [PATCH 2/8] lavu: new AVWriter API

2023-05-02 Thread Nicolas George
Rémi Denis-Courmont (12023-05-02): > I think that that is pretty rich coming from you, just judging by your > earlier > responses to other people. Pointers? -- Nicolas George signature.asc Description: PGP signature ___ ffmpeg-devel mailing list

Re: [FFmpeg-devel] [PATCH 2/8] lavu: new AVWriter API

2023-05-02 Thread Rémi Denis-Courmont
Le tiistaina 2. toukokuuta 2023, 21.36.53 EEST Nicolas George a écrit : > The only thing dumb and confusing I see here is the mail I am answering > to. > I must say, I am impressed by the rudeness and arrogance of such a > comment without even looking at the code itself. I think that that is

Re: [FFmpeg-devel] [PATCH 2/8] lavu: new AVWriter API

2023-05-02 Thread Nicolas George
Rémi Denis-Courmont (12023-05-02): > Please re-read the comments. You are totally misses the point. I confess so, indeed, I completely failed to understand your point after reading your comment multiple times. > Well, I'll add myself to the already long list of people publicly objecting > to >

Re: [FFmpeg-devel] [PATCH 2/8] lavu: new AVWriter API

2023-05-02 Thread Rémi Denis-Courmont
Le tiistaina 2. toukokuuta 2023, 19.53.43 EEST Nicolas George a écrit : > Rémi Denis-Courmont (12023-05-02): > > Indirecting the printf function seems pretty pointless. The last thing you > > Please re-read the code, there is no other way of obtaining a va_list > from an actual argument than

Re: [FFmpeg-devel] [PATCH 2/8] lavu: new AVWriter API

2023-05-02 Thread Nicolas George
Rémi Denis-Courmont (12023-05-02): > Indirecting the printf function seems pretty pointless. The last thing you Please re-read the code, there is no other way of obtaining a va_list from an actual argument than making a call to a vararg function. > want are different implementations of printf()

Re: [FFmpeg-devel] [PATCH 2/8] lavu: new AVWriter API

2023-05-02 Thread Rémi Denis-Courmont
Le perjantaina 28. huhtikuuta 2023, 12.55.02 EEST Nicolas George a écrit : > +/** > * + * Generic API > + > *** > / + > +#define FIELDOK(st, f) ((char

Re: [FFmpeg-devel] [PATCH 2/8] lavu: new AVWriter API

2023-04-28 Thread Nicolas George
Rodney Baker (12023-04-28): > I'm not normally a reviewer, but I noticed a few minor grammatical things > that > stood out - hope this is OK. Thanks, it is absolutely useful. > Nit - s/compating/comparing/ Fixed. > > +**Note:** AVWriter is 8-bit clean, the strings it manipulates can be >

Re: [FFmpeg-devel] [PATCH 2/8] lavu: new AVWriter API

2023-04-28 Thread Rodney Baker
I'm not normally a reviewer, but I noticed a few minor grammatical things that stood out - hope this is OK. Regards, Rodney. On Friday, 28 April 2023 7:25:02 PM ACST Nicolas George wrote: > Signed-off-by: Nicolas George > --- > doc/avwriter_intro.md | 186 >

[FFmpeg-devel] [PATCH 2/8] lavu: new AVWriter API

2023-04-28 Thread Nicolas George
Signed-off-by: Nicolas George --- doc/avwriter_intro.md | 186 libavutil/Makefile| 2 +- libavutil/writer.c| 458 +++ libavutil/writer.h| 488 ++ 4 files changed, 1133 insertions(+), 1